On Mon, Sep 07, 2020 at 12:33:41PM +0200, Neil Armstrong wrote:
> Hi,
>
> Please ignore this serie, the vendors patch is missing and the panel driver
> still has the vrefresh...
>
> Will repost.
Please fix so DRM_DEV_* is replaced by dev_* logging.
We no longer use the DRM_ based logging for pan
Hi Laurent.
> >
> > Please read the cover letter, it explains why it's done this way. The
> > whole point of this patchset is to merge DSI and DBI frameworks in a
> > way that can be maintained.
>
> I think this proves the point that the proposed naming is confusing. At
> least a rename would
Hi Sumit.
On Wed, Aug 26, 2020 at 09:33:08PM +0530, Sumit Semwal wrote:
> Novatek NT36672a is a generic DSI IC that drives command and video mode
> panels. Add the driver for it.
>
> Right now adding support for some Poco F1 phones that have an LCD panel
> from Tianma connected with this IC, with
Hi Sumit.
On Wed, Aug 26, 2020 at 09:33:07PM +0530, Sumit Semwal wrote:
> Novatek nt36672a is a display driver IC that can drive DSI panel. It
> is also present in the Tianma video mode panel, which is a FHD+ panel
> with a resolution of 1080x2246 and 6.18 inches size. It is found in
> some of the
o
> probe.
>
> Fix the driver so that it will probe even if the IPU node is not present
> in devicetree (but then IPU support is disabled of course).
>
> v2: Take a different approach
>
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Signed-of
On Thu, Aug 27, 2020 at 01:44:03PM +0200, Paul Cercueil wrote:
> of_graph_get_remote_node() requires of_node_put() to be called on the
> device_node pointer when it's no more in use.
>
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Signed-off-by: P
operty
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Sam Ravnborg
I expect this patch is picked up with the dts fixes.
Sam
> ---
> .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> dif
Hi Jagan.
On Sat, Aug 29, 2020 at 10:03:27PM +0530, Jagan Teki wrote:
> Add dt-bindings for 10.1" TFT LCD module from Ampire Co. Ltd.
> as part of panel-simple.
>
> Signed-off-by: Jagan Teki
Thanks for the quick update.
Applied both patches to drm-misc-next.
Sam
> ---
> Changes for v2
On Fri, Aug 28, 2020 at 05:58:33PM +0300, Robert Chiras (OSS) wrote:
> From: Robert Chiras
>
> The flag MIPI_DSI_CLOCK_NON_CONTINUOUS was wrong used in the DSI driver,
> so it was added to this panel, but not necessary.
> So, remove this flag since it is not needed.
>
> Signed-off-by: Robert Chi
On Fri, Aug 28, 2020 at 01:12:50PM +0530, Vinod Koul wrote:
> DSI end-points are supposed to be at node 0 and node 1 as per binding.
> So fix this and use node 0 and node 1 for dsi.
>
> Reported-by: Dmitry Baryshkov
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Signe
Hi Laurentiu.
> As to who is going to do the actual merge, I know we had a brief
> discussion about it some time ago and I was supposed to apply for
> drm-misc rights, however it feels a little awkward to merge my own
> code... :)
You are encouraged to commit your own code, it is anyway you who k
Hi Jagan.
On Fri, Aug 28, 2020 at 09:29:38PM +0530, Jagan Teki wrote:
> Add Ampire, AM-1280800N3TZQW-T00H 10.1" TFT LCD panel timings.
>
> Signed-off-by: Jagan Teki
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28
> 1 file changed, 28 insertions(+)
>
> diff --git
Hi Kevin.
> >
> > Any specific reason why this is not a ports node like used by many other
> > display bindings?
> > In other words - I think this is too simple.
> We only support one display pipeline now, other interface, like
> DP(DisplayPort), HDMI...will be add later...
>
> ports:
> $re
Hi Kevin
> >
> > > +
> > > + drm->dev_private = sprd;
> > dev_private is deprecated. Alwyas use upclassing.
> dev_private is deprecated ? I see everyone is still using it, so it
> will be deprecated in the future?
It is deprecated - and a lot of drivers is in need up an update to get
away from
Hi Paul.
On Wed, Aug 26, 2020 at 11:58:41PM +0200, Paul Cercueil wrote:
> Even if support for the IPU was compiled in, we may run on a device
> (e.g. the Qi LB60) where the IPU is not available, or simply with an old
> devicetree without the IPU node. In that case the ingenic-drm refused to
> prob
rieve the EDID.
>
> Signed-off-by: Enric Balletbo i Serra
> ---
>
> Changes in v2:
> - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++---
> 1 file changed, 58 insertions(+), 6 d
d the patch `drm/bridge: ps8640: Get the EDID from eDP control`
> - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
>
> Enric Balletbo i Serra (5):
> drm/bridge_connector: Set default status connected for eDP connectors
> drm/bridge: ps8640: Get the EDID from eDP
Hi Mauro.
Laurent and I discussed this driver a little on irc.
Some highlights:
This parts could use register names:
+ writel(0x2, noc_dss_base + 0xc);
+ writel(0x2, noc_dss_base + 0x8c);
+ writel(0x2, noc_dss_base + 0x10c);
+ writel(0x2, noc_dss_base + 0x18c);
The two no
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
>
> If you'd like to see the entire thing, I'm placing it here:
>
>
> https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/hikey970_v2/
Review 3/3
For next submis
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 2/N
The way output_poll_changed is used to set gpio_mux to select between
the panel and the HDMI looks strange. But I do not know if there is a
more correct way to do it. Other
Hi Mauro
> kirin9xx_fb_panel.h b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
> new file mode 100644
> index ..a69c20470f1d
> --- /dev/null
> +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
This file is not referenced and should be deleted.
Sam
Hi Mauro.
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 1/N
Lots of small details I missed last time.
A good thing is that there is an opportunity to delete som more code.
Sam
> diff --git a/drivers/staging/hikey9xx/gpu/Kc
Hi Nadezda
On Wed, Aug 19, 2020 at 05:37:56PM +0300, Nadezda Lutovinova wrote:
> If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr,
> then a null pointer dereference is accessed.
>
> The patch adds checking of the return value of ge_b850v3_lvds_init().
>
> Found by Linux D
On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote:
> passing zero to 'PTR_ERR'
>
> Reported-by: kernel test robot
> Signed-off-by: Vinay Simha BN
Applied to drm-misc-next - thanks.
Sam
> ---
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Hi Enric.
On Fri, Aug 21, 2020 at 01:38:09PM +0200, Sam Ravnborg wrote:
> Hi Enric.
>
> >
> > Let me reformulate the question for if it was not clear.
> >
> > What I did is be able to read the EDID every time userspace asks for it (so
> > kernel enables al
On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote:
> The get_edid() callback can be triggered anytime by an ioctl, i.e
>
> drm_mode_getconnector (ioctl)
> -> drm_helper_probe_single_connector_modes
>-> drm_bridge_connector_get_modes
> -> ps8640_bridge_g
ra
Reviewed-by: Sam Ravnborg
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> b/drivers/gpu/drm/bridge/parade-ps8640.c
> index ce3e8b2da8c9
y the new
> drm_bridge model is supported.
>
> Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Sam Ravnborg
I will await the updated series before applying.
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 4
> 1 file changed, 4 insertions(+)
>
> diff -
Hi Douglas.
On Fri, Aug 21, 2020 at 08:35:14AM -0700, Douglas Anderson wrote:
> The KD116N21-30NV-A010 is a pretty standard eDP panel. Add it to the
> list of compatible strings.
>
> Signed-off-by: Douglas Anderson
Both patches applied to drm-misc-next.
Sam
> ---
>
> .../devicetree
Hi Mauro.
On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote:
> Another quick question:
>
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> > > +#define DSS_REDUCE(x)((x) > 0 ? ((x) - 1) : (x))
> > Use generic macros for
Hi Mauro.
Thanks for the detailed feedabck.
Two comments in the following.
Sam
>
> > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0");
> > > + if (!ctx->dss_pri_clk) {
> > > + DRM_ERROR("failed to parse dss_pri_clk\n");
> > > + return -ENODEV;
> > > + }
> ...
>
> > I had ex
Hi Enric.
>
> Let me reformulate the question for if it was not clear.
>
> What I did is be able to read the EDID every time userspace asks for it (so
> kernel enables all the required) and Sam is proposing to just fail if all is
> not
> setup. I can obviously do this but my question is, at whi
#x27;t initialize drm_panel->dev manually, it is done by
> drm_panel_init().
>
> Signed-off-by: Paul Cercueil
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-novatek-nt39016.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --
t; Signed-off-by: Paul Cercueil
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> b/drivers/gpu/drm/panel/panel-novatek-nt
Hi Mauro.
Quick feedback below.
Sam
On Thu, Aug 20, 2020 at 05:13:22PM +0200, Mauro Carvalho Chehab wrote:
> Em Thu, 20 Aug 2020 16:48:08 +0200
> Sam Ravnborg escreveu:
>
> > Hi Mauro.
> >
> > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab
Hi Mauro.
On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> I'm already handling the other comments from your review (I'll send a
> more complete comment about them after finishing)
Hi John.
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
>
> I'm not sure I see all of these as compelling for pushing it in via
> staging. And I suspect in the process of submitting the patches for
> review folks may find the cause of some
Hi Mauro.
Some feedback in the following.
Good to see DT schma files and not .txt files - but needs a bit more
work.
Sam
On Wed, Aug 19, 2020 at 01:46:17PM +0200, Mauro Carvalho Chehab wrote:
> Add a description of the bindings used by Kirin 960/970 Display
> Serial Interface (DSI) contr
Hi Xin Ji.
On Mon, Aug 10, 2020 at 10:35:46PM +0200, Sam Ravnborg wrote:
> Hi Xin Ji.
>
> On Thu, Jul 09, 2020 at 04:31:09PM +0800, Xin Ji wrote:
> > Hi all,
> >
> > The following series add support for the Slimport ANX7625 transmitter, a
> > ultra-low power
Hi Paul.
On Wed, Aug 19, 2020 at 08:14:12PM +0200, Paul Cercueil wrote:
> There is already a 'struct device' pointer in the drm_panel structure,
> that we can access easily from our priv structure, so there's no need
> for a separate 'dev' field there.
>
> This also allows drm_panel_of_backlight(
Hi Chun-Kuang
Two small details below.
Sam
On Wed, Aug 19, 2020 at 11:44:20PM +0800, Chun-Kuang Hu wrote:
> From: CK Hu
>
> mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's
> more suitable to place a phy driver into phy driver folder, so move
> mtk_hdmi_phy driver
Hi Mauro.
On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> This patch series port the out-of-tree driver for Hikey 970 (which
> should also support Hikey 960) from the official 96boards tree:
>
>https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
>
> Based on h
Hi Guido.
On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote:
>
> The panel uses a Focaltech FT8006p, the touch part is handled by the already
> existing edt-ft5x06. It can be found in e.g. the Librem 5.
>
> Changes from v2:
> - Due to review comments by Sa
On Tue, Aug 18, 2020 at 02:51:40PM +0800, Tian Tao wrote:
> patch #1 is using the drv_err instead of DRM_ERROR in hibmc_ttm.c
> patch #2 is using the drv_err instead of DRM_ERROR in hibmc_drm_vdac.c
> patch #3 is using the drv_err and drm_dbg_atomic instead of DRM_ERROR
> and DRM_DEBUG_ATOMIC in
Hi Vaibhav
On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote:
> Drivers should do only device-specific jobs. But in general, drivers using
> legacy PCI PM framework for .suspend()/.resume() have to manage many PCI
> PM-related tasks themselves which can be done by PCI Core itself. This
Hi Vaibhav
On Tue, Aug 11, 2020 at 12:27:12AM +0530, Vaibhav Gupta wrote:
> Drivers should do only device-specific jobs. But in general, drivers using
> legacy PCI PM framework for .suspend()/.resume() have to manage many PCI
> PM-related tasks themselves which can be done by PCI Core itself. This
On Sun, Aug 16, 2020 at 07:55:21PM +0200, Guido Günther wrote:
> Hi Sam,
> thanks for having a look!
>
> On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote:
> > Hi Guido.
> >
> > On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote:
> >
Hi Guido.
On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido Günther wrote:
> This was prompted by Sam's review in
> https://lore.kernel.org/dri-devel/20200815210802.ga1242...@ravnborg.org/
> and yamllint. I also added myself as maintainer, hope that's o.k.
>
> Guido Günther (2):
> dt-bindings: pa
Hi Dmitry
On Fri, Aug 14, 2020 at 12:56:05AM +0300, Dmitry Osipenko wrote:
> Hello!
>
> This series adds support for display panel's DT rotation property. It's a
> continuation of the work that was initially started by Derek Basehore for
> the panel driver that is used by some Mediatek device [1]
On Sat, Aug 15, 2020 at 12:40:22PM +0200, Guido Günther wrote:
> Hi Sam,
> On Sat, Aug 15, 2020 at 12:02:30PM +0200, Sam Ravnborg wrote:
> > Hi Guido.
> >
> > > +static int mantix_probe(struct mipi_dsi_device *dsi)
> > > +{
> > > + struct device
Hi Guido.
On Fri, Aug 14, 2020 at 03:36:23PM +0200, Guido Günther wrote:
> The panel uses a Focaltech FT8006p, the touch part is handled by the
> already existing edt-ft5x06.
>
> Signed-off-by: Guido Günther
Looks good.
A few notes in the following, nothing major.
Sam
> ---
> MAINTAI
Hi Paul.
On Tue, Aug 11, 2020 at 02:22:35AM +0200, Paul Cercueil wrote:
> Hi list,
>
> Here's a list of 5 patches that bring some cleanups and improvements.
>
> Patches 1-2 clean up the novatek,nt39016 code to remove custom handling
> of the backlight and to add the missing carriage returns on e
Hi Guido.
> > In fact I did decided against it since i was told that missing dev_* and
> > DRM_* logging shouldn't be done. So is that o.k. nowadays?
> s/missing/mixing/
>
> I often request that logging is consistent - so I recognize the
> argument.
>
> For panel/* I have not made up my mind wha
Hi Icenowy
On Mon, Jul 20, 2020 at 01:04:06AM +0800, Icenowy Zheng wrote:
> The controller chip of Feixin K101-IM2BA02 is going to be discontinued,
> so Feixin start to provide K101-IM2BYL02 panel as a replacement, which
> utilizes Ilitek ILI9881C controller.
>
> Add support for K101-IM2BYL02 pan
Hi Guido.
> +static int mantix_probe(struct mipi_dsi_device *dsi)
> +{
> + struct device *dev = &dsi->dev;
> + struct mantix *ctx;
> + int ret;
> +
> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return -ENOMEM;
> +
> + ctx->reset_gpio =
Hi Guido.
On Sat, Aug 15, 2020 at 06:47:37PM +0200, Guido Günther wrote:
> Hi Sam,
> On Sat, Aug 15, 2020 at 10:39:17AM +0200, Sam Ravnborg wrote:
> > Hi Guido.
> >
> > On Fri, Aug 14, 2020 at 03:36:22PM +0200, Guido Günther wrote:
> > > The panel uses a Foc
On Sat, Aug 15, 2020 at 11:16:21PM +0200, Guido Günther wrote:
> The panel uses a Focaltech FT8006p, the touch part is handled by the
> already existing edt-ft5x06.
>
> Signed-off-by: Guido Günther
Reviewed-by: Sam Ravnborg
I assume you will apply yourself, otherwise I will do so
On Sat, Aug 15, 2020 at 11:16:20PM +0200, Guido Günther wrote:
> Add prefix for Mantix Display Technology Co.,Ltd.
>
> Signed-off-by: Guido Günther
Acked-by: Sam Ravnborg
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Hi Guido.
On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote:
> The panel uses a Focaltech FT8006p, the touch part is handled by the
> already existing edt-ft5x06.
>
> Signed-off-by: Guido Günther
Two small nits - otherwise looks good.
Reviewed-by: Sam Ravnborg
I c
Hi Guido.
On Fri, Aug 14, 2020 at 03:36:22PM +0200, Guido Günther wrote:
> The panel uses a Focaltech FT8006p, the touch part is handled by the
> already existing edt-ft5x06.
>
> Signed-off-by: Guido Günther
A few trivialities.
> ---
> .../display/panel/mantix,mlaf057we51-x.yaml | 73 ++
Hi Sumit.
On Tue, Aug 11, 2020 at 11:51:07PM +0530, Sumit Semwal wrote:
> Some Poco F1 phones have an LCD panel from Tianma, model nt36672a,
> with a resolution of 1080x2246 that operates in DSI video mode.
>
> Add the drm panel driver for it.
>
> During testing, Benni Steini helped us fix
> th
Hi Venkateshwar
On Tue, Aug 11, 2020 at 06:16:17AM +0530, Venkateshwar Rao Gannavarapu wrote:
> The Xilinx MIPI DSI TX subsystem soft IP is used to display video
> data from AXI-4 stream interface.
>
> It supports upto 4 lanes, multiple RGB color formats, video mode
> and command mode. The driver
> keyword.
>
> Found with yamllint (which I plan to integrate into the checks).
I have browsed through the patch - and there was only a few things
that jumped at me.
With these points considered:
Acked-by: Sam Ravnborg
I expect only some (few) of my points to actually results in any updates.
Hi Venkateshwar
On Tue, Aug 11, 2020 at 06:16:15AM +0530, Venkateshwar Rao Gannavarapu wrote:
> Xilinx DSI-TX subsytem consists of DSI controller core, AXI crossbar
> and D-PHY as sub blocks. DSI TX subsystem driver supports multiple lanes
> upto 4, RGB color formats, video mode and command modes.
Hi Vinay.
> >
> > If Laurent or others identify further things to improve we can take
> > it in-tree.
>
> Just one thing, please see below.
>
> > > > >> + d2l_write(tc->i2c, VTIM1, vtime1);
> > > > >> + d2l_write(tc->i2c, HTIM2, htime2);
> > > > >> + d2l_write(tc->i2c, VTIM2,
Hi Xin Ji.
On Thu, Jul 09, 2020 at 04:31:09PM +0800, Xin Ji wrote:
> Hi all,
>
> The following series add support for the Slimport ANX7625 transmitter, a
> ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable
> device.
>
>
> This is the v14 version, any mistakes, please let
Hi Allen.
On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote:
> it6505 changes trigger conditions.
> ---
> Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge
Hi allen.
On Thu, Jul 16, 2020 at 05:47:31PM +0800, allen wrote:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> Signed-off-by: Jitao Shi
> Signed-off-by: Pi-Hsun Shih
> Signed-off-by: Yilun Lin
> Signed-off-by: Hermes Wu
> Signed-off-by: Allen C
ated
> > >> mdelay to usleep_range
> > >> bus_formats added
> > >>
> > >> v3:
> > >> * Andrzej Hajda review comments incorporated
> > >> drm_connector_status removed
> > >> u32 rev removed and local variabl is
gt; - converted from .txt to .yaml
> >
> > Signed-off-by: Vinay Simha BN
> > Reviewed-by: Sam Ravnborg
> > Reviewed-by: Rob Herring
The binding is already reviewed by Rob and me - as you have recorded
above. It will be applied when the driver is ready.
Sam
> > --
Hi Vaibhav
On Mon, Aug 10, 2020 at 03:09:48PM +0530, Vaibhav Gupta wrote:
> On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote:
> > Hi Vaibhav
> >
> > On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote:
> > > Drivers using legacy power management
Hi Vaibhav
On Wed, Aug 05, 2020 at 11:37:12PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
>
> Switch to generic p
Hi Vaibhav
On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
>
> Switch to generic p
Hi Joe.
On Sun, Aug 02, 2020 at 07:34:13PM +0200, Sam Ravnborg wrote:
> Hi Joe.
>
> On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote:
> > These functions are now empty and no longer
> > useful so remove the functions and their uses.
> >
>
On Mon, Aug 03, 2020 at 12:52:40PM -0700, Joe Perches wrote:
> On Mon, 2020-08-03 at 21:41 +0200, Sam Ravnborg wrote:
> > On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote:
> > > Replace the existing /* fall through */ comments and its variants with
> >
Hi Tom,
On Mon, Jul 20, 2020 at 12:18:45PM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analysis reports this repesentative error
>
> pvr2fb.c:1049:2: warning: 1st function call argument
> is an uninitialized value [core.CallAndMessage]
> if (*cable_arg)
> ^~
On Tue, Jul 07, 2020 at 04:05:39PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
>
> [1]
> https://www.kernel.org/doc/h
Hi Joe.
On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote:
> These functions are now empty and no longer
> useful so remove the functions and their uses.
>
> Signed-off-by: Joe Perches
> ---
>
> > > It's too tedious to break apart into multiple patches.
> > > Done with coccinelle and
Hi Joe.
On Sun, Aug 02, 2020 at 01:00:11AM -0700, Joe Perches wrote:
> These functions are now empty and no longer
> useful so remove the functions and their uses.
>
> Signed-off-by: Joe Perches
> ---
>
> It's too tedious to break apart into multiple patches.
> Done with coccinelle and typing.
Hi Bernard.
On Sat, Aug 01, 2020 at 08:02:13PM +0800, Bernard Zhao wrote:
> The function "int drm_panel_add(struct drm_panel *panel)"
> always returns 0, this return value is meaningless.
> Also, there is no need to check return value which calls
> "drm_panel_add and", error branch code will never
Hi Paul.
While I continue to try to wrap my head around how I think we should
support DBI here are some panel specific comments.
Sam
On Mon, Jul 27, 2020 at 06:46:11PM +0200, Paul Cercueil wrote:
> This driver supports the NewVision NV3052C based LCDs. Right now, it
> only supports the L
reason of this patch
>
> Signed-off-by: Paul Cercueil
Reviewed-by: Sam Ravnborg
And thanks for the quick update!
Sam
> ---
> drivers/gpu/drm/ingenic/ingenic-ipu.c | 23 ---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/g
ards a hardware
> bug.
>
> Thanksfully multiplanar YUV is not affected.
>
> Until this bug is fixed or worked around, address this issue by removing
> support for YUV 4:2:2 on the IPU of the JZ4725B.
>
> v2: Update commit message (remove the "crash beyond repair" bit)
>
th the chagelog updated:
Reviewed-by: Sam Ravnborg
Sam
>
> Signed-off-by: Paul Cercueil
> ---
> drivers/gpu/drm/ingenic/ingenic-ipu.c | 23 ---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c
On Thu, Jul 30, 2020 at 03:46:25AM +0200, Paul Cercueil wrote:
> When configuring the IPU for packed YUV 4:2:2, depending on the scaling
> ratios given by the source and destination resolutions, it is possible
> to crash the IPU block beyond repair, to the point where a software
> reset of the IP d
>
> Make it work properly on newer SoCs by letting the LCD controller
> trigger the IPU frame restart signal.
>
> Signed-off-by: Paul Cercueil
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/ingenic/ingenic-ipu.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 de
Hi Kevin.
Thanks for submitting this set of drivers.
To better review the pataches can you please give some kind of high
level overview.
An ascii block diagram that identifies all the relevant blocks and how
they relate would be great.
This makes it easier to verify if the right modelling is us
Hi Kevin.
Some feedback in the following.
I lost track of thing for the atomic modesettting stuff and I hope other
will review that.
Sam
On Tue, Jul 28, 2020 at 06:07:57PM +0800, Kevin Tang wrote:
> From: Kevin Tang
>
> Adds DPU(Display Processor Unit) support for the Unisoc's display
Hi Kevin.
On Tue, Jul 28, 2020 at 06:07:56PM +0800, Kevin Tang wrote:
> From: Kevin Tang
>
> DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs
> which transfers the image data from a video memory buffer to an internal
> LCD interface.
>
> Cc: Orson Zhai
> Cc: Chunyan Z
Hi Kevin.
Nice split of the driver.
Some feedback in the following.
Most to bring the driver up-to-date with what have happened since
we saw it last time.
Keeping up with the changes in drm is not always easy.
Sam
On Tue, Jul 28, 2020 at 06:07:55PM +0800, Kevin Tang wrote:
> From: Kevin
Hi Kevin
On Tue, Jul 28, 2020 at 06:07:54PM +0800, Kevin Tang wrote:
> From: Kevin Tang
>
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai
> Cc: Chunyan Zhang
> Signed
;
> Paul Cercueil (2):
> drm/ingenic: Handle errors of drm_atomic_get_plane_state
> drm/ingenic: Validate mode in a .mode_valid callback
Both looks fine, you can add my:
Reviewed-by: Sam Ravnborg
I assume you will apply the patches.
Maybe wait for Daniel to take a look, he had
Hi Paul.
On Mon, Jul 27, 2020 at 06:46:10PM +0200, Paul Cercueil wrote:
> This driver will register a DBI host driver for panels connected over
> SPI.
So this is actually a MIPI DBI host driver.
I personally would love to have added mipi_ in the names - to make it
all more explicit.
But maybe tha
Hi Paul.
On Mon, Jul 27, 2020 at 06:46:09PM +0200, Paul Cercueil wrote:
> The current MIPI DSI framework can very well be used to support MIPI DBI
> panels. In order to add support for the various bus types supported by
> DBI, the DRM panel drivers should specify the bus type they will use,
> and
Hi Paul.
On Mon, Jul 27, 2020 at 06:46:08PM +0200, Paul Cercueil wrote:
> Add documentation for the Device Tree node for LCD panels based on the
> NewVision NV3052C controller.
>
> Signed-off-by: Paul Cercueil
Very happy to see work on RG-350 :-)
Some feedback below.
Sam
> ---
> .../
Hi Swapnil
Small nits in the following.
Sam
On Wed, Jul 22, 2020 at 09:40:40AM +0200, Swapnil Jakhade wrote:
> Add j721e wrapper for mhdp, which sets up the clock and data muxes.
>
> Signed-off-by: Jyri Sarha
> Signed-off-by: Yuti Amonkar
> Signed-off-by: Swapnil Jakhade
> Reviewed-b
Hi Swapnil
Thanks for submitting this driver.
A few highlevel things.
New bridge drivers shall be prepare for use in a chained
bridge driver setup.
This prompts you to add the following:
- Reelvant bridge operations
I noticed at least get_edid, and detect seems applicable.
- Support the
Hi Swapnil.
On Wed, Jul 22, 2020 at 09:40:38AM +0200, Swapnil Jakhade wrote:
> From: Yuti Amonkar
>
> Document the bindings used for the Cadence MHDP DPI/DP bridge in
> yaml format.
>
> Signed-off-by: Yuti Amonkar
> Signed-off-by: Swapnil Jakhade
> Reviewed-by: Rob Herring
> Reviewed-by: Lau
ns for describing
> Amlogic Video Framebuffer Compression")
> Signed-off-by: Neil Armstrong
Looks correct just looking at the patch below.
Acked-by: Sam Ravnborg
I assume you will apply the patch.
Sam
> ---
> include/uapi/drm/drm_fourcc.h | 2 +-
> 1 file changed, 1 insert
Hi Rodrigo.
On Fri, Jul 24, 2020 at 05:34:04PM -0300, Rodrigo Alencar wrote:
> The supported displays are ls027b7dh01 (tested), ls044q7dh01,
> ls013b7dh05, ls013b7dh03
>
> Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.com>
Thanks for submitting this driver.
Unfortunately I have some
201 - 300 of 2594 matches
Mail list logo
