Hi Douglas,
On Mon, May 18, 2020 at 11:05:58AM -0700, Doug Anderson wrote:
> Sam,
>
> On Mon, May 18, 2020 at 10:59 AM Sam Ravnborg wrote:
> >
> > Hi Douglas.
> >
> > > > Given the previous feedback from Linus W, Stephen, and Laurent I
> > > >
Hi Enric/Chun-Kuang.
> >
> > My point is: when do you attach panel to a connector?
> > In this patch,
> >
> > ret = drm_bridge_attach(>encoder, >bridge, NULL,
> > DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> >
> > it would call into mtk_dsi_bridge_attach() with
> >
Hi Douglas.
> > Given the previous feedback from Linus W, Stephen, and Laurent I
> > expect things are good enough to land now, but it'd be good to get
> > confirmation (I removed some of the previous tags just to get
> > confirmation). If we can get review tags early next week maybe it'll
> >
On Fri, May 08, 2020 at 04:33:29PM -0700, Douglas Anderson wrote:
> The AUX channel transfer error bits in the status register are latched
> and need to be cleared. Clear them before doing our transfer so we
> don't see old bits and get confused.
>
> Without this patch having a single failure
first field, so the pointer received had the same
> value, but this was not semantically correct.
>
> Cc: sta...@vger.kernel.org # v5.3
> Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
> Signed-off-by: Paul Cercueil
Acked-by: Sam Ravnborg
> ---
&
> check")
> Signed-off-by: Paul Cercueil
Looks correct.
Acked-by: Sam Ravnborg
> ---
>
> Notes:
> This patch was previously sent standalone.
> I marked it as superseded in patchwork.
> Nothing has been changed here.
>
> drivers/gpu/drm/ingenic
Hi Paul.
On Sat, May 16, 2020 at 11:50:47PM +0200, Paul Cercueil wrote:
> Add documentation of the Device Tree bindings for the Image Processing
> Unit (IPU) found in most Ingenic SoCs.
>
> Signed-off-by: Paul Cercueil
For me it fails like this:
read the minItems/maxItems thing twice to get it,
so I also played a little with the examples, and it worked as expected.
Acked-by: Sam Ravnborg
> ---
>
> Notes:
> This patch comes from a different patchset so it's effectively a V2.
>
> Changes were:
> - lcd_pclk
Hi Richard.
On Sat, May 09, 2020 at 01:17:32PM +0200, s...@48.io wrote:
> From: Marek Vasut
>
> Add driver for the ITE IT6251 LVDS-to-eDP bridge.
I assume this is the same driver submitted here:
https://lore.kernel.org/dri-devel/f2892d7b-a60b-4e15-faa7-97ccb20e8...@codeaurora.org/
I miss a
Hi Richard/Marek.
On Sat, May 09, 2020 at 01:17:31PM +0200, s...@48.io wrote:
> From: Marek Vasut
>
> Add DT bindings for ITE IT6251 LVDS-to-eDP bridge.
Looks good, just a few comments in the following.
Sam
>
> Signed-off-by: Marek Vasut
> Signed-off-by: Richard Marko
> Cc: Daniel
Hi Richard.
On Sat, May 09, 2020 at 01:18:34PM +0200, s...@48.io wrote:
> From: Sean Cross
>
> The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> integrated backlight, and connects via eDP.
>
> It is used in the Kosagi Novena.
Thanks for the patch.
>
> Signed-off-by:
Hi Jason.
On Wed, May 06, 2020 at 02:17:45PM +0800, Jason Yan wrote:
> No other functions use the return value of pxa168fb_init_mode() and the
> return value is always 0 now. Make it return void. This fixes the
> following coccicheck warning:
>
> drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded
Hi Jason.
On Wed, May 06, 2020 at 02:17:45PM +0800, Jason Yan wrote:
> No other functions use the return value of pxa168fb_init_mode() and the
> return value is always 0 now. Make it return void. This fixes the
> following coccicheck warning:
>
> drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded
On Thu, May 07, 2020 at 10:49:28AM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> drivers/gpu/drm/i2c/tda998x_drv.c:1136:5: warning:
> symbol 'tda998x_audio_digital_mute' was not declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-off-by: Samuel Zou
Thanks.
Hi Douglas.
On Thu, May 07, 2020 at 02:34:54PM -0700, Douglas Anderson wrote:
>
> As talked about in commit c2bfc223882d ("drm/bridge: ti-sn65dsi86:
> Remove the mystery delay"), the normal HPD pin on ti-sn65dsi86 is
> kinda useless, at least for embedded DisplayPort (eDP). However,
> despite
Hi Dillon.
On Fri, May 08, 2020 at 06:13:43PM +0800, dillon min wrote:
> Hi Sam,
>
> Thanks for your comments, i will rework this panel driver after l3gd20
> patch submission.
>
> Sam Ravnborg 于2020年5月8日周五 下午5:02写道：
>
> > Hi Dillon.
> >
> >
On Fri, May 08, 2020 at 03:59:01PM -0700, Douglas Anderson wrote:
> This panel appears to be the same or nearly the same as the BOE
> NV133FHM-N61, but since (in the very least) it identifies itself as a
> different model in the EDID we should add a new compatible string for
> it.
>
>
Hi Douglas
On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote:
> The BOE NV133FHM-N61 is documented in the original commit to be a
> 13.3" panel, but the size listed in our struct doesn't match.
> Specifically:
>
> math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92
>
>
Hi Dillon.
Patch submissions starts to look fine.
On Fri, May 08, 2020 at 12:13:14PM +0800, dillon.min...@gmail.com wrote:
> From: dillon min
>
> This is a driver for 320x240 TFT panels, accepting a rgb input
> streams that get adapted and scaled to the panel.
This driver is, I suppose,
For example in exynos_dpi_probe()
Is would be nice to only have to review for this
type of changes once, so one patch-set is preferred
over single patches over time.
You can add:
Reviewed-by: Sam Ravnborg
to this patch when you re-send a new series.
Thanks,
Sam
> ---
> driv
Hi Konrad.
On Wed, May 06, 2020 at 11:09:54PM +0200, Konrad Dybcio wrote:
> changes since v3:
> - fix dt-bindings issue
>
> changes since v2:
> - fix Kconfig indentation
>
> changes since v1:
> - make `backlight_properties props` constant
> - a couple of line breaks
> - change name and
rm69299.o
>
> Signed-off-by: Randy Dunlap
> Cc: Thierry Reding
> Cc: Sam Ravnborg
> Cc: dri-de...@lists.freedesktop.org
Thanks.
Added Fixes: tag and applied to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-visionox-rm69299.c |1 +
> 1 file changed
s upper case because others used upper case.
But there is a good explanation and then all is fine wiht me.
And it is an alphabetic order - so
Acked-by: Sam Ravnborg
>
> -Sergey
>
> >
> > Sam
> >
> > >"^bananapi,.*":
> > > description: BIPAI KEJI LIMITED
> > >"^beacon,.*":
> > > --
> > > 2.25.1
Hi Zou Wei.
On Thu, Apr 30, 2020 at 08:13:17PM +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/gpu/drm/udl/udl_modeset.c:269:5: warning: symbol 'udl_handle_damage'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-off-by: Zou Wei
Thanks,
On Wed, Apr 29, 2020 at 10:09:42PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/video/fbdev/valkyriefb.c:348:10-11: WARNING comparing pointer to
> 0, suggest !E
> drivers/video/fbdev/valkyriefb.c:334:12-13: WARNING comparing pointer to
> 0
>
Hi Christophe
On Wed, May 06, 2020 at 08:19:02PM +0200, Christophe JAILLET wrote:
> Some memory is vmalloc'ed in the 'w100fb_save_vidmem' function and freed in
> the 'w100fb_restore_vidmem' function. (these functions are called
> respectively from the 'suspend' and the 'resume' functions)
>
>
Hi Sergey.
On Wed, May 06, 2020 at 08:42:21PM +0300, sergey.se...@baikalelectronics.ru
wrote:
> From: Serge Semin
>
> Add "BAIKAL ELECTRONICS, JSC" to the list of devicetree vendor prefixes
> as "baikal".
>
> Website: http://www.baikalelectronics.com
>
> Signed-off-by: Serge Semin
> Cc:
Hi Christophe
On Mon, Apr 27, 2020 at 11:19:45AM +0200, Christophe JAILLET wrote:
> Some memory is vmalloc'ed in the 'suspend' function and freed in the
> 'resume' function.
> However, it is also freed in the remove function.
>
> In order to avoid a potential double free, set the corresponding
On Wed, Apr 22, 2020 at 03:18:26PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/video/fbdev/i810/i810_main.c:1969:3-7: WARNING: Assignment of
> 0/1 to bool variable
> drivers/video/fbdev/i810/i810_main.c:1971:3-8: WARNING: Assignment of
> 0/1 to bool variable
>
properly.
>
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Dmitry Osipenko
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/tegra/rgb.c | 58 +++--
> 1 file changed, 49 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/rg
On Sat, Apr 18, 2020 at 08:07:01PM +0300, Dmitry Osipenko wrote:
> Newer Tegra device-trees will specify a video output graph which involves
> a bridge. This patch adds initial support for the DRM bridges to the Tegra
> DRM output.
>
> Signed-off-by: Dmitry Osipenko
Acked-b
On Sat, Apr 18, 2020 at 08:07:00PM +0300, Dmitry Osipenko wrote:
> The OF node should be put before returning error in tegra_output_probe(),
> otherwise node's refcount will be leaked.
>
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Sam Ravnborg
&
dge graph
> is a valid case. Let's check presence of the local port in a device-tree
> before proceeding with parsing the graph.
>
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_of.c | 13 -
> 1 file changed, 12 insertions(+),
_get_local_port() which returns pointer to a local
> port node, or NULL if graph isn't specified in a device-tree for a given
> device node.
>
> Signed-off-by: Dmitry Osipenko
Nice little helper function.
Reviewed-by: Sam Ravnborg
Rob - OK to commit to drm-misc-next?
Hi Dough.
> >
> > If we don't want to test that, I would at least document it in the DT
> > bindings. It will be a good occasion to switch the bindings to YAML ;-)
>
> Interesting that you bring this up. Conversion to yaml is sitting
> waiting to land (or additional review comments):
>
>
Hi David.
On Tue, Apr 28, 2020 at 02:45:21PM +0800, David Lu wrote:
> fix boe_tv105wum_nw0 display shift.
>
> Signed-off-by: David Lu
Added fixes: tag and applied to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8
> 1 file changed, 4
0x1050@60,
> with VGA as well as DVI.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Sam Ravnborg
>
> ---
> Changes since v4:
> - Removed the registration with the component framework and creation of
> drm_encoder.
>
> Changes since v3:
> - Cosmetic c
ix most of the issues with:
>
> ./scripts/documentation-file-ref-check --fix
>
> Signed-off-by: Mauro Carvalho Chehab
Patch looks good.
Acked-by: Sam Ravnborg
> ---
>
> PS.: This patch is against today's linux-next.
>
>
> .../devicetree/bindings/display/bridge/sii902x.txt
Hi Souptick
On Sat, May 02, 2020 at 03:28:11AM +0530, Souptick Joarder wrote:
> These are dead code since 3.15. If there is no plan to use it further
> it can be removed forever.
Could you explain why you conclude this is dead code sine 3.15 -
and maybe point to the commit that made it dead.
I
oc() for the unicode screen buffer")
> Cc:
Looks good.
Reviewed-by: Sam Ravnborg
Not the I know the code, but verified that no more kfree() was
used for vc_uni_screen.
Sam
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index e5ffed795e..48a8199f78 1006
at your suggestion is good.
Sam
> [1]?
>
> [1] Z00T is the model number of the smartphone that uses this panel
>
> Konrad
>
> On Sat, May 2, 2020, 09:05 Sam Ravnborg wrote:
>
> > Hi Konrad.
> >
> > On Fri, May 01, 2020 at 10:48:22PM +0200, Konrad
Hi Allen.
On Mon, Apr 27, 2020 at 05:16:51PM +0800, allen wrote:
> The IT6505 is a high-performance DisplayPort 1.1a transmitter, fully
> compliant with DisplayPort 1.1a, HDCP 1.3 specifications. The IT6505 supports
> color depth of up to 36 bits (12 bits/color) and ensures robust transmission
Hi Konrad.
On Fri, May 01, 2020 at 10:48:22PM +0200, Konrad Dybcio wrote:
> This adds support for TMP5P5 NT35596 1080x1920 video
> mode panel that can be found on some Asus Zenfone 2
> Laser (Z00T) devices.
Very well-writen driver. Only a few small things in the following.
Sam
>
>
Hi dillon min
> > okay, thanks alexandre, i will go through these docs. currently i'm on may
> day holiday, will be back at next wensday.
> after go back to work. i will separate this patch to five part with 9
> patchs , should be more clear
>
> dts releated
> 1, ARM: dts: stm32: Add i2c3
Hi Konrad.
On Fri, May 01, 2020 at 10:48:21PM +0200, Konrad Dybcio wrote:
> I am aware of the fact that this is probably not the correct
> naming of this panel, yet I am unable to retrieve any additional
> information about it, as it is used in a smartphone to which no
> schematics are released.
Hi Konrad.
Thanks for the new panel binding.
But you need to redo this as panel bindings today must be in DT Schema
format (.yaml).
Please see other bindings in the same dir for examples.
Sam
On Fri, May 01, 2020 at 10:48:23PM +0200, Konrad Dybcio wrote:
> Signed-off-by: Konrad Dybcio
Hi Xin Ji.
> > > +static void anx7625_power_on_init(struct anx7625_data *ctx)
> > > +{
> > > + int retry_count, i;
> > > + int ret;
> > > + struct device *dev = >client->dev;
> > > +
> > > + for (retry_count = 0; retry_count < 3; retry_count++) {
> > > + anx7625_power_on(ctx);
> > > +
On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote:
> On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote:
> > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote:
> > > Add missed ":" on kernel-doc function parameter.
> > >
> > > This patch fixes this warnings from `make htmldocs`:
> >
Hi Arnd.
On Tue, Apr 28, 2020 at 11:53:54PM +0200, Arnd Bergmann wrote:
> Some older versions of gcc badly optimize code that passes
> an inline function argument into another function by reference,
> causing huge stack usage:
>
> drivers/gpu/drm/bridge/tc358768.c: In function
drivers/video/fbdev/controlfb.c:756:23: error: incompatible types when
> assigning to type 'pgprot_t' {aka 'struct '} from type 'int'
>
> Fix it by adding missing PPC32 dependency.
>
> Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support")
> Reporte
Hi Christoph
On Wed, Apr 29, 2020 at 05:51:01AM -0700, Christoph Hellwig wrote:
> Why do we even bother allocing the driver to compile for !ppc32
> given that it clearly needs ppc-specific infrastructure? The whole
> idea of needing magic stubs for the COMPILE_TEST case seems rather
>
add COMPILE_TEST support")
> Reported-by: Stephen Rothwell
> Reported-by: kbuild test robot
> Cc: Sam Ravnborg
> Cc: Daniel Vetter
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> v2: fix implicit btext_update_display() function declaration error
>
&g
Hi Gareth.
On Mon, Apr 27, 2020 at 09:21:47AM +0100, Gareth Williams wrote:
> Add DRM support for the Digital Blocks DB9000 LCD Controller
> with the Renesas RZ/N1 specific changes.
>
> Signed-off-by: Gareth Williams
> ---
> drivers/gpu/drm/Kconfig| 2 +
>
Hi Rob.
On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote:
> On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg wrote:
> >
> > Hi Björn.
> >
> > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > > Define the vendor prefix fo
Hi Bogdan.
> > > adv7533_detach_dsi(adv7511);
> > > i2c_unregister_device(adv7511->i2c_cec);
> > > if (adv7511->cec_clk)
> > > @@ -1266,8 +1278,9 @@ static const struct i2c_device_id
> > > adv7511_i2c_ids[] = {
> > > { "adv7511", ADV7511 },
> > > { "adv7511w", ADV7511 },
> > >
Hi Stephen.
On Fri, Aug 16, 2019 at 01:31:32PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> warning: same module names found:
>
Hi Masahiro
> Changes in v2:
> - Add a whitelist. The CONFIG leakages in this list are not warned.
> This patch can be applied now. A new leakage will be blocked.
Very good!
Acked-by: Sam Ravnborg
Sam
e to redefinition of something.
>
> Some headers must be excluded from the test-coverage for now. I will
> let them in after they are fixed.
Smart and simple - nice.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Sam Ravnborg
Sam
Hi Masahiro.
On Mon, Jul 29, 2019 at 02:34:44AM +0900, Masahiro Yamada wrote:
> This compile-test started from the strong belief that (almost) all
> headers should be able to be compiled as a standalone unit, but this
> requirement seems to be annoying.
>
> I believe it is nice to compile-test
mixed" [drivers/gpu/drm/exynos/exynosdrm.ko] undefined!
>
> With below patch I think the build error reported already will be fixed,
> https://patchwork.kernel.org/patch/11035147/
I have the exact same patch locally - that I forgot to send out.
So:
Acked-by: Sam Ravnborg
Sam
dev/Makefile| 1 -
> drivers/video/fbdev/jz4740_fb.c | 690
> 3 files changed, 700 deletions(-)
> delete mode 100644 drivers/video/fbdev/jz4740_fb.c
Nice work of you and others involved.
Acked-by: Sam Ravnborg
Sam
t DSI access to
> enable() so the upstream bridge can prepare the DSI host controller in
> it's pre_enable().
>
> The second patch makes the disable() call symmetric to the above and the third
> one just eases debugging.
>
> Changes from v1:
> * As per review comments b
Hi Guido.
On Fri, Jul 26, 2019 at 11:21:42AM +0200, Guido Günther wrote:
> This makes it symmetric with the panel init happening in enable().
>
> Signed-off-by: Guido Günther
> ---
> drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 10 +++---
> 1 file changed, 7 insertions(+), 3
Hi Guido.
A few comments follows.
Sam
On Wed, Jul 24, 2019 at 05:52:25PM +0200, Guido Günther wrote:
> The Northwest Logic MIPI DSI IP core can be found in NXPs i.MX8 SoCs.
>
> Signed-off-by: Guido Günther
> ---
> .../bindings/display/bridge/imx-nwl-dsi.txt | 89 +++
Hi Alexey
On Thu, Jul 25, 2019 at 10:56:33PM +0300, Alexey Dobriyan wrote:
> What are these files for?
>
> $ cat ../obj/include/linux/kernel.h.s
> .file "null"
> .text
> .ident "GCC: (Gentoo 9.1.0-r1 p1.1) 9.1.0"
> .section
Hi Masahiro.
On Fri, Jul 19, 2019 at 07:08:59PM +0900, Masahiro Yamada wrote:
> This compile-test started from the strong belief that (almost) all
> headers should be able to be compiled as a standalone unit, but this
> requirement seems to be just annoying.
>
> I believe compile-test of
Hi Dough.
On Mon, Jul 01, 2019 at 09:39:24AM -0700, Doug Anderson wrote:
> Hi,
>
> On Sun, Jun 30, 2019 at 1:22 PM Sam Ravnborg wrote:
> >
> > > @@ -91,6 +92,8 @@ struct panel_simple {
> > > struct i2c_adapter *ddc;
> > >
Hi Masahiro.
On Fri, Jun 28, 2019 at 01:39:02AM +0900, Masahiro Yamada wrote:
> The headers in include/ are globally used in the kernel source tree
> to provide common APIs. They are included from external modules, too.
>
> It will be useful to make as many headers self-contained as possible
>
ew class or error if they
run a "make headers_check" sometimes later.
This can be a next step to consolidate this.
With the suggestions below considered you can add my:
Reviewed-by: Sam Ravnborg
>
> We use -std=gnu89 for the kernel space since the kernel code highly
> depends o
ou/want/to/build/
> Makefile:219: (Do not forget the trailing slash)
> Makefile:220:
> Makefile:221: If you are building an external module,
> Makefile:222: Please use 'M=' or 'KBUILD_EXTMOD' instead
> Makefile:223: ==========
>
> Suggested-by: Christoph Hellwig
> Signed-off-by: Masahiro Yamada
Nice!
Acked-by: Sam Ravnborg
Sam
Hi Robert.
On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote:
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).
I was about to apply these - but I get following warnings during build:
CC drivers/gpu/drm/panel/panel-raydium-rm67191.o
On Wed, Jun 26, 2019 at 10:53:57AM +0800, Jitao Shi wrote:
> Add documentation for boe tv101wum-n16 panel.
>
> Signed-off-by: Jitao Shi
Reviewed-by: Sam Ravnborg
> ---
> .../display/panel/boe,tv101wum-nl6.txt| 34 +++
> 1 file changed, 34 insertions
On Fri, Jun 07, 2019 at 01:11:07PM +0200, H. Nikolaus Schaller wrote:
> The change adds support for the Sharp LQ070Y3DG3B 7.0" TFT LCD panel.
>
> Tested on Letux7004.
>
> Signed-off-by: H. Nikolaus Schaller
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm
>
> When all header files below include/drm are self-contained it will be a
> single line:
>
> header-test-y += $(all_headers_with_subdir)
In reality it will likely be the above, and then a list of
header-test-n += foo.h
For the header files that we for one or the other reason do not want
Hi Masahiro
> > ...
> On this level it would be better to do:
> header-test-y += $(call find_all_header_files)
>
> # drm files that are not self-contained
> header-test-n += drm_legacy.h
I made a quick hack on top of your patch to demonstrate
the ideas.
See patch below.
When all header files
Hi Masahiro
> At first, I tried to split Makefile per directory,
> and add header-test-y one by one.
>
> I think you expect they look like this:
>
>
> include/Makefile:
>
> subdir-y += drm
> subdir-y += linux
> subdir-y += media
So far we agree.
> include/drm/Makefile:
>
> header-test-y +=
her architectures.
Signed-off-by: Sam Ravnborg
Cc: Yoshinori Sato
Cc: Rich Felker
Cc: Will Deacon
Cc: Andrew Morton
Cc: Mark Brown
Cc: Inki Dae
Cc: Krzysztof Kozlowski
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
arch/sh/include/asm/io.h | 6 +-
1 file changed, 5 insertions(+)
Hi Masahiro.
On Sat, Jun 22, 2019 at 01:39:31AM +0900, Masahiro Yamada wrote:
> Make as many headers self-contained as possible so that they can be
> included without relying on a specific include order.
It is very nice finally to get some infrastructure to validate header
files.
But to avoid
On Wed, Jun 12, 2019 at 10:49:52AM +0200, Paul Cercueil wrote:
>
>
> Le mar. 11 juin 2019 à 23:55, Rob Herring a écrit :
> > On Mon, 3 Jun 2019 17:23:30 +0200, Paul Cercueil wrote:
> > > Add documentation for the devicetree bindings of the LCD controller
> > > present in
> > > the JZ47xx
Hi Robert.
On top of the feedback from Fabio here is a bit more.
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
Divide include up in block in following order:
#include
#include
#incude
Hi Rodrigo et al.
On Thu, Jun 13, 2019 at 07:04:03AM +0200, Sam Ravnborg wrote:
> Hi Rodrigo.
>
> On Wed, Jun 12, 2019 at 11:10:54PM -0300, Rodrigo Siqueira wrote:
> > For historical reason, the function drm_wait_vblank_ioctl always return
> > -EINVAL if something gets
Hi Derek.
On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote:
> This adds a helper function for reading the rotation (panel
> orientation) from the device tree.
>
> Signed-off-by: Derek Basehore
> ---
> drivers/gpu/drm/drm_panel.c | 41 +
>
Hi Jitao
Always good to see more panels added.
On Sat, Jun 08, 2019 at 03:02:29PM +0800, Jitao Shi wrote:
> Add documentation for boe tv101wum-n16 panel.
The changelog says tv101wum-n16 but the compatible says tv101wum-nl6.
Please pick the right one and be consistent. (number one '1' versus
Hi Daniel.
On Fri, May 24, 2019 at 10:53:46AM +0200, Daniel Vetter wrote:
> There's a callchain of:
>
> fbcon_fb_blaned -> do_(un)blank_screen -> consw->con_blank
^^
Spelling error - as this is a callchain it would be good to have it
fixed.
Patch itself looks fine.
Sam
Hi Daniel.
On Mon, May 20, 2019 at 07:29:52PM +0200, Daniel Vetter wrote:
> On Mon, May 20, 2019 at 7:20 PM Sam Ravnborg wrote:
> >
> > Hi Daniel.
> >
> > > With the recursion broken in the previous patch we can drop the
> > > FBINFO_MISC_USEREVENT fl
Hi Daniel.
> With the recursion broken in the previous patch we can drop the
> FBINFO_MISC_USEREVENT flag around calls to fb_blank - recursion
> prevention was it's only job.
>
When grepping for FBINFO_MISC_USEREVENT I get a few hits not addressed
in the patch below:
Hi Geert/Masahiro.
On Fri, May 10, 2019 at 08:46:35AM +0200, Geert Uytterhoeven wrote:
> Hi Yamada-san,
>
> On Fri, May 10, 2019 at 8:14 AM Masahiro Yamada
> wrote:
> > Kconfig updates the .config when it exits even if its content is
> > exactly the same as before. Since its timestamp becomes
Hi allen.
Thanks for this fine patch.
A few comments follows.
Consider to use DRM_DEV_ERROR and friends.
Then you get the devicename included in logging
and this makes it much easier to find relevant entries.
On Wed, May 08, 2019 at 03:48:41PM +0800, allen wrote:
> From: Allen Chen
>
> This
Hi Thierry.
> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM
OK to add the "pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM"
patch via drm-misc?
Then we can add all 6 patches in one go.
Sam
(Kept remaining of mail for reference)
>
> Hi,
>
> These patches adds
On Tue, May 07, 2019 at 06:37:07PM +0530, Jagan Teki wrote:
> HD702E lcd is FriendlyELEC developed eDP LCD panel with 800x1280
> resolution. It has built in Goodix, GT9271 captive touchscreen
> with backlight adjustable via PWM.
>
> Add support for it.
>
> Cc: Thierry Redin
Hi John.
On Tue, Apr 23, 2019 at 04:20:42PM -0700, John Stultz wrote:
> From: Xu YiPing
>
> As part of refactoring the kirin driver to better support
> different hardware revisions, this patch moves some shared
> structures and helpers to the common kirin_drm_drv.h
>
> These structures will
Hi Gerd.
On Thu, Apr 04, 2019 at 05:24:27PM +0200, Gerd Hoffmann wrote:
> Also rename to drm_fb_xrgb_to_rgb565().
> Pure code motion, no functional change.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Sam Ravnborg
Hi Thierry.
> Changes from v2
> * As per review comments from Sam Ravnborg
> * Lowercase sentinel
> * Drop '_panel' postfix
> * DRM_DEV_ logging instead of plain DRM_
> * Add Sam's Reviewed-by:
> * Add "panel-rocktech-" to the driver name following
>
Hi Johan.
Thanks for this nive driver.
A few review comments follows.
Sam
On Sat, Mar 02, 2019 at 11:41:13AM +0100, Johan Jonker wrote:
> From: Zheng Yang
>
> Introduce rk3066 hdmi.
A little more info would be good here.
Do not assume all reader knows as much as you do.
>
>
Hi Guido.
Thanks for addressing review comments in first round.
Just a few nits in this follow-up.
With these nits addressed:
Reviewed-by: Sam Ravnborg
On Fri, Mar 01, 2019 at 02:02:04PM +0100, Guido Günther wrote:
> +#include
This include file is, as far as I could tell, no longer u
Hi Paul.
On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote:
> The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.
>
> Signed-off-by: Paul Cercueil
> Tested-by: Artur Rojek
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28
> 1 file
Hi Paul.
Driver looks good and is a very nice piece of work.
In the following a number of minor issues.
One area that jumped at me was framedesc and the use of dma_alloc_coherent()
I hope someone that knows the memory handling better can give some advice here.
To me it looks like something drm
Hi Paul.
Good to see work migrating fbdev => drm.
Following comments is based on experience while working on migrating
another driver from fbdev => drm.
On Thu, Feb 28, 2019 at 07:07:54PM -0300, Paul Cercueil wrote:
> Add documentation for the devicetree bindings of the DRM driver for the
>
Hi Claudiu
On Wed, Feb 27, 2019 at 04:24:40PM +, claudiu.bez...@microchip.com wrote:
> From: Sandeep Sheriker Mallikarjun
>
> For SAM9X60 SoC, sys_clk is through lcd_gclk clock source and this
> needs to be enabled before enabling lcd_clk.
We have "ownership" of the clocks in the mfd
igned-off-by: Claudiu Beznea
Looks good, good to have simpler code.
Reviewed-by: Sam Ravnborg
401 - 500 of 4807 matches
Mail list logo
