Re: [PATCH] cifs: Fix inconsistent IS_ERR and PTR_ERR

2021-02-19 Thread Samuel Cabrero
Thanks Yue, it looks good to me. Reviewed-by: Samuel Cabrero On Thu, 2021-02-18 at 17:28 +0800, YueHaibing wrote: > Fix inconsistent IS_ERR and PTR_ERR in cifs_find_swn_reg(). The > proper > pointer to be passed as argument to PTR_ERR() is share_name. > > This bug was detected w

Re: [PATCH 1/3] cifs: Delete a stray unlock in cifs_swn_reconnect()

2020-12-17 Thread Samuel Cabrero
On Thu, 2020-12-17 at 14:01 +0300, Dan Carpenter wrote: > The unlock is done in the caller, this is a stray which leads to a > double unlock bug. > Indeed. Reviewed-by: Samuel Cabrero -- Samuel Cabrero / SUSE Labs Samba Team GPG: D7D6 E259 F91C F0B3 2E61 1239 3655 6EC9 7051 0