Hi Uwe,
Thanks for the patches!
Patch series is,
Acked-by: Samuel Iglesias Gonsalvez
Greg, Would you mind picking this patch series through your char-misc
tree?
Thanks!
Sam
On Sun, 2021-02-07 at 22:55 +0100, Uwe Kleine-König wrote:
> A driver without a probe function isn't useful as it can
Hi Tom,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez
Greg, Would you mind picking this patch through your char-misc
tree?
Thanks!
Sam
On Mon, 2020-10-19 at 12:32 -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
>
Hello Wei,
Thanks for the patch!
Patch is,
Acked-by: Samuel Iglesias Gonsalvez
Greg, Would you mind picking this patch series through your char-misc
tree?
Thanks!
Sam
On Thu, 2020-05-07 at 09:42 +, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
>
by: Samuel Iglesias Gonsálvez
---
drivers/ipack/ipack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index 575c4f29e0f7..a1e07a77d4e6 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -212,7 +212,7 @@ struct ipack_
: Samuel Iglesias Gonsálvez
---
Greg, Would you mind picking this patch series through your char-misc tree?
Sam
drivers/ipack/ipack.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index 12102448fddd..575c4f29e0f7 100644
--- a/drivers/ipack
Hello Markus,
Thanks for the patches!
Series is,
Acked-by: Samuel Iglesias Gonsalvez
Greg, Would you mind picking this patch series through your char-misc
tree?
Sam
On Sat, 2017-05-13 at 10:56 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 13 May 2017 10:37:06 +0200
>
On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote:
> There was not any kind of protection against carrier driver removal.
> In this way, device driver can 'get' the carrier driver when it is
> using it.
>
> Signed-off-by: Federico Vaga
> ---
> drivers/ipack/carriers/tpci200.c |3 ++-
>
On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote:
> Signed-off-by: Federico Vaga
> ---
> drivers/ipack/devices/ipoctal.c | 35 ++-
> 1 file changed, 14 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/
On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote:
> Signed-off-by: Federico Vaga
> ---
> drivers/ipack/devices/ipoctal.c | 30 +++---
> 1 file changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoct
On Mon, 2014-09-01 at 13:49 +0200, Federico Vaga wrote:
> In some condition we receive the break interrupt but nothing is putted
> in the Rx FIFO and the correspondend bit in the status register is not
> set. Thus, no-one clear the interrupt and the handler will be called
> forever.
>
> This patch
On 2014-08-22 14:09, Rasmus Villemoes wrote:
Signed-off-by: Rasmus Villemoes
---
drivers/ipack/devices/ipoctal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ipack/devices/ipoctal.h
b/drivers/ipack/devices/ipoctal.h
index 28f1c42..7fede0e 100644
--- a/drivers/ip
On Fri, 2014-07-18 at 17:27 +0200, Benoit Taine wrote:
> We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
> kernel coding style guidelines. This issue was reported by checkpatch.
>
> Signed-off-by: Benoit Taine
>
> ---
> Tested by compilation without errors.
>
> d
On Thu, 2014-07-03 at 10:53 +0200, Federico Vaga wrote:
> The request for an IRQ handler must be done after whole configuration. This
> was not the case for this driver which request the IRQ in the middle of
> the configuration. Sometimes, it happens that something is not completely
> configured, w
On Thu, 2014-06-26 at 09:52 +0200, Samuel Iglesias Gonsálvez wrote:
> On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote:
> > In some conditions (echo or particular sequence of special
> > characters), on buffer push, the tty layer calls the write operation
> > whi
On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote:
> In some conditions (echo or particular sequence of special
> characters), on buffer push, the tty layer calls the write operation
> while we are holding the spinlock. This means deadlock within the same
> process on kernels version < 3.12. I
On lun, 2013-10-07 at 18:27 -0700, Greg Kroah-Hartman wrote:
> The dev_attrs field of struct bus_type is going away soon, dev_groups
> should be used instead. This converts the ipack bus code to use the
> correct field.
>
> Cc: Samuel Iglesias Gonsalvez
> Cc: Jens Taprogge
> Cc:
> Signed-off-b
On Fri, Mar 08, 2013 at 11:36:24AM -0800, Greg Kroah-Hartman wrote:
[...]
> If the others require this one to be applied, in order for them to apply
> properly, yes, it would be great to resend. If not, I'll just skip the
> first one.
>
They don't require the first one. You can skip it.
Thanks,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote:
> On Fri, Mar 08, 2013 at 09:21:45AM +0100, Samuel Iglesias
> Gonsalvez wrote:
>> Signed-off-by: Samuel Iglesias Gonsalvez
>> --- drivers/ipack/ipack.c |1 + 1 file changed, 1
>> insertion(+)
>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote:
Yes, you are right. It's not possible to have it freed twice once it's
in ipack_device_release().
You can skip this patch. If you want, I can resend the others accordingly.
Sam
-BEGIN PGP SIG
Hello Dmitry,
First of all, thanks for your comments.
On 02/26/2013 11:28 PM, Dmitry Torokhov wrote:
> On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote:
>> put_device() must be called after device_register() fails,
>> since device_register() always initializes the refcoun
On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote:
> On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> > Move ipack header files to include/linux/ directory where they belong to.
>
> Why do these belong in include/linux?
They are used for other drivers that could be in othe
On Fri, 2012-11-16 at 18:48 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote:
> > On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory wh
On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote:
> On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote:
> > Move ipack header files to include/linux/ directory where they belong to.
> >
> > Signed-off-by: Samuel Iglesias Gonsalvez
> > ---
> > drivers/ipack/carri
On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge
> >
> > The field irq currently is identical to the slot number. It does not seem
> > to
> > have any real use. The number is written to
On Thu, 2012-09-13 at 13:02 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote:
> > Clear the BREAK flag from the ISR register.
> >
> > Signed-off-by: Samuel Iglesias Gonsalvez
>
> What are the user visible effects of this bugfix?
>
It clear
On Thu, 2012-09-13 at 16:14 +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next merge of the staging tree got a conflict in
> drivers/staging/ipack/devices/ipoctal.c between commit 734cc1783816
> ("TTY: use tty_port_register_device") from the tty tree and commit
> 2afb41d9d30d ("Stagi
On Wed, 2012-09-12 at 14:28 +0200, Jens Taprogge wrote:
[...]
> Sam,
>
> can you please add the endianess-aware versions back? Patch attached.
>
> One of the earlier uses was not correct.
Done!
The patch will be submitted with the next batch.
Thanks,
Sam
signature.asc
Description: This i
On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote:
> > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote:
> > > > +static int tpci200_get_clockrate(struct ipack_device *dev)
> > > > +{
> > > > + struct tpci200_b
On Tue, 2012-09-11 at 13:39 +0200, Jens Taprogge wrote:
> On Tue, Sep 11, 2012 at 01:31:06PM +0200, Samuel Iglesias Gonsálvez wrote:
> > On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote:
> > > On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote:
From: Jens Taprogge
We provide callbacks to:
- set/get the clockrate a module is accessed at,
- get the error state of a slot,
- get/reset the timeout state of a slot.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.h | 15
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |6 ++
drivers/staging/ipack/ipack.h |2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
space CRC.
Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq.
Samuel Iglesias Gonsálvez (10):
Staging: ipack/bridges/tpci200: remove struct list_head
Staging: ipack/bridges/tpci200: reorder the iounmap and
pci_release_region
Staging: ipack/bridges/tpci200: increment the
From: Jens Taprogge
After a successful match is found the driver field in struct device is
set by the core device code. We can use this field.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 17 +++--
drivers/staging
From: Jens Taprogge
Resetting the previous timeout we avoid to read the timeout status register
and see timeout errors that don't correspond to the present state of the
device.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |
From: Jens Taprogge
Reading the ID space at 8 MHz is always supported. Most carriers will
boot up in 8MHz mode. Still, play it safe and ensure we are operating at
8Mhz.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 11
As the linked list was removed before, delete the useless struct list_head
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.h
b/drivers/staging/ipack/bridges/tpci200
From: Jens Taprogge
This saves us from a little pointer arithmetic and cleans up the code a bit.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 28 +++-
drivers/staging/ipack/bridges/tpci200.h
From: Jens Taprogge
Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout
callbacks.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 109 ++-
1 file changed, 108
Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 59 -
drivers/staging/ipack/ipack.h |1 +
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack
As the IRQ was requested by the driver, it should free it also.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index
As indicated in the documentation of pci_dev_get.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
b/drivers/staging/ipack/bridges/tpci200.c
index 383571c
Using the call to the ipack_device_unregister() function to avoid the
strange way it was doing, as the device model will take care of calling
the bus's .remove function when a device is being unregistered.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci
Find the IP modules that are plugged to the carrier and unregister them.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index 26dc976
Move iounmap and pci_release_region to tpci200_unregister(), as it is the place
where the clean-up of the device is done.
Also, renamed iounmap() to pci_iounmap() as the mapped region was requested
from PCI bus.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200
As the IP module driver takes care of freeing its resources.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |1 -
drivers/staging/ipack/ipack.h |3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
The ipoctal devices can be uninstalled from the ipack_driver_unregister()
call as the device model calles the bus's .remove() function for each device
registered by the driver and it will execute the .remove() function of the
ipoctal driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
dr
As the ipack_bus_unregister() takes care of unregistering the devices plugged
in the carrier, it is not needed to do it in the carrier driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |7 +--
1 file changed, 1 insertion(+), 6 deletions
From: Jens Taprogge
This way we do no longer need to keep a dangling pointer to struct
ipack_device in tpci200_slot after the device has been removed.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 19
It is not needed as the IP module should free its IRQ using
tpci200_free_irq callback.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/staging/ipack
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index c36ba9e..1ad73e5 100644
--- a/drivers
On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote:
> On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote:
> > From: Jens Taprogge
> >
> > Reading the ID space at 8 MHz is always supported. Most carriers will
> > boot up in 8MHz mode. Still,
On Tue, 2012-09-11 at 11:51 +0300, Dan Carpenter wrote:
> The whole patchset looks good.
>
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
Taking into account that I need to resend the patches, I can add these
suggestions.
Thanks for your revision,
Sam
signature.asc
Description: T
On Mon, 2012-09-10 at 11:29 -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 10, 2012 at 10:51:39AM +0200, Samuel Iglesias Gonsálvez wrote:
> > From: Jens Taprogge
> >
> > This saves us from a little pointer arithmetic and cleans up the code a bit.
> >
> > Signed-
From: Jens Taprogge
Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout
callbacks.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 107 +++
1 file changed, 107
From: Jens Taprogge
We provide callbacks to:
- set/get the clockrate a module is accessed at,
- get the error state of a slot,
- get/reset the timeout state of a slot.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.h | 15
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index 521ff55..6e0b441 100644
--- a/drivers
From: Jens Taprogge
After a successful match is found the driver field in struct device is
set by the core device code. We can use this field.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 17 +++--
drivers/staging
From: Jens Taprogge
Reading the ID space at 8 MHz is always supported. Most carriers will
boot up in 8MHz mode. Still, play it safe and ensure we are operating at
8Mhz.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 11
As the linked list was removed before, delete the useless struct list_head
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.h
b/drivers/staging/ipack/bridges/tpci200
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index 95f56b8..eba2021 100644
--- a/drivers
As indicated in the documentation of pci_dev_get.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
b/drivers/staging/ipack/bridges/tpci200.c
index 5150794
Using the call to the ipack_device_unregister() function to avoid the
strange way it was doing, as the device model will take care of calling
the bus's .remove function when a device is being unregistered.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |6 ++
drivers/staging/ipack/ipack.h |2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
The ipoctal devices can be uninstalled from the ipack_driver_unregister()
call as the device model calles the bus's .remove() function for each device
registered by the driver and it will execute the .remove() function of the
ipoctal driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
dr
As the IRQ was requested by the driver, it should free it also.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index
Find the IP modules that are plugged to the carrier and unregister them.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index b368a26
As the ipack_bus_unregister() takes care of unregistering the devices plugged
in the carrier, it is not needed to do it in the carrier driver.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |7 +--
1 file changed, 1 insertion(+), 6 deletions
It is not needed as the IP module should free its IRQ using
tpci200_free_irq callback.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/staging/ipack
As the IP module driver takes care of freeing its resources.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |1 -
drivers/staging/ipack/ipack.h |3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
From: Jens Taprogge
This way we do no longer need to keep a dangling pointer to struct
ipack_device in tpci200_slot after the device has been removed.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 19
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
b/drivers/staging/ipack/bridges/tpci200.c
index 861b00d..5150794 100644
--- a/drivers/staging
From: Jens Taprogge
This saves us from a little pointer arithmetic and cleans up the code a bit.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 28 +++-
drivers/staging/ipack/bridges/tpci200.h
Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 59 -
drivers/staging/ipack/ipack.h |1 +
2 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack
depends on HAS_IOMEM
> ---help---
> If you say Y here you get support for the IndustryPack Framework
> for drivers for many types of boards that support this industrial
Acked-by: Samuel Iglesias Gonsálvez
Thanks,
Sam
signature.asc
Description: This is a digitally signed message part
=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function
'ioread16be' [-Werror=implicit-function-declaration]
Reported-by: Stephen Rothwell
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c |1 +
1
unchanged. We can thus directly access
the memory and registers of IP Modules without having to rely on the
read and write wrappers currently exposed in ipack_bus_opts. A later
patch will convert the existing driver and remove the wrappers.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias
From: Jens Taprogge
Define memory address space, fix sparse warnings and mark the structs
reflecting hardware memory layout "packed" to be on the safe side.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 14 ++--
From: Jens Taprogge
They are not used any longer.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 218 ---
1 file changed, 218 deletions(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.h | 26 ++
drivers/staging/ipack/ipack_ids.h | 27 +++
include/linux/mod_devicetable.h |7 +++
scripts/mod/file2alias.c | 15 +++
4 files changed, 75 insertions
From: Jens Taprogge
We keep a copy of the ID space for later use.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 80 +
drivers/staging/ipack/ipack.h |5 +++
2 files changed, 85 insertions
From: Jens Taprogge
Devices are match based upon their vendor and device ids. Since
the individual drivers provide a list of supported ids they do not
need to implement the matching themselves.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack
From: Jens Taprogge
The modalias entries for the module are now created.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/ipack/devices
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c |8 +---
drivers/staging/ipack/ipack.h |2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ipack
From: Jens Taprogge
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index a5ef28f
From: Jens Taprogge
Also include it in the hotplug event so that udev can
provide the respective driver.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 36
1 file changed, 36 insertions(+)
diff
From: Jens Taprogge
Also expose the values through sysfs.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.c | 81 +++--
drivers/staging/ipack/ipack.h |4 +-
2 files changed, 80 insertions(+), 5
From: Jens Taprogge
No need to have a struct when it has only one field.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 82 +++---
drivers/staging/ipack/devices/scc2698.h | 116
From: Jens Taprogge
Rename them in the process.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 26 +++---
drivers/staging/ipack/ipack_ids.h |5 +
2 files changed, 16 insertions(+), 15
They are not used any longer.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/ipack.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ipack/ipack.h b/drivers/staging/ipack/ipack.h
index 8bc001e..e3609b1 100644
From: Jens Taprogge
These changes make it easier to add more initialization steps later on.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions
From: Jens Taprogge
Before it was using the functions in ipack_bus_ops.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 29 -
1 file changed, 8 insertions(+), 21 deletions(-)
diff --git a
: Provide ID Prom through sysfs.
Samuel Iglesias Gonsálvez (1):
Staging: ipack: remove read/write operations from ipack_bus_ops
drivers/staging/ipack/bridges/tpci200.c | 280 ++-
drivers/staging/ipack/bridges/tpci200.h |9 +
drivers/staging/ipack/devices
The linked list of registered devices is not needed as the struct
tpci200_board is saved in private data field of the pci device.
Signed-off-by: Jens Taprogge
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c | 34 ++-
1 file
The CPU might write-combine and/or cache memory access. Something that for
most modules is not desired.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ipack
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/bridges/tpci200.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/bridges/tpci200.c
b/drivers/staging/ipack/bridges/tpci200.c
index 2b83fa8..a7fb2cf 100644
--- a/drivers/staging/ipack
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/TODO |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ipack/TODO b/drivers/staging/ipack/TODO
index 0f8bf20..25ed7ae 100644
--- a/drivers/staging/ipack/TODO
+++ b/drivers/staging/ipack/TODO
Use the ANSI/VITA 4.0-1995 (S2011) naming convention for the mezzanine or
daughter boards. They are called IP modules in the Standard.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/TODO |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
ned-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ipack/devices/ipoctal.c
b/drivers/staging/ipack/devices/ipoctal.c
index a5af423..a1aae40 100644
--- a/drivers/staging/ip
Initialize the device when registering it. Sometimes the user access to it
and the device is in an unknown state, so it could fail.
Signed-off-by: Samuel Iglesias Gonsálvez
---
drivers/staging/ipack/devices/ipoctal.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers
99 matches
Mail list logo
