[PATCH] bpf: Fix backport of "bpf: restrict unknown scalars of mixed signed bounds for unprivileged"

2021-04-19 Thread Samuel Mendoza-Jonas
-statement (aad2eeaf4 "bpf: Simplify ptr_min_max_vals adjustment"). Move the check to the proper location in adjust_ptr_min_max_vals(). Fixes: 17efa65350c5a ("bpf: restrict unknown scalars of mixed signed bounds for unprivileged") Signed-off-by: Samuel Mendoza-Jonas Reviewed-by:

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread Samuel Mendoza-Jonas
On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote: > On Sun, 20 Dec 2020 at 12:40, John Wang < > wangzhiqiang...@bytedance.com> wrote: > > > > When aggregating ncsi interfaces and dedicated interfaces to bond > > interfaces, the ncsi response handler will use the wrong net device > > to > >

Re: [PATCH] net/ncsi: Disable global multicast filter

2019-09-15 Thread Samuel Mendoza-Jonas
disabling the component wholesale but I don't believe this actually *breaks* anyone's configuration. It would be nice to see some Tested-By's from the OpenBMC people though. I'll have a look at the multicast issues, CC'ing in Chris too who IIRC was looking at similar issues for u-bmc i

[PATCH net-next v3 1/6] net/ncsi: Don't enable all channels when HWA available

2018-11-07 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 3 +-- net/ncsi/ncsi-manage.c | 50 -- 2 files changed, 5 insertions(+), 48 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 25e483e8278b..65f47a648be3 100644 --- a/net/ncsi/ncsi

[PATCH net-next v3 1/6] net/ncsi: Don't enable all channels when HWA available

2018-11-07 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 3 +-- net/ncsi/ncsi-manage.c | 50 -- 2 files changed, 5 insertions(+), 48 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 25e483e8278b..65f47a648be3 100644 --- a/net/ncsi/ncsi

[PATCH net-next v3 2/6] net/ncsi: Probe single packages to avoid conflict

2018-11-07 Thread Samuel Mendoza-Jonas
on the RMII bus when packages try to respond. Update the probe loop to probe each package one by one, and once complete check if HWA is universally supported. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/internal.h| 1 + net/ncsi/ncsi-manage.c | 85

[PATCH net-next v3 0/6] net/ncsi: Allow enabling multiple packages & channels

2018-11-07 Thread Samuel Mendoza-Jonas
packages in a few places when multi-package is enabled. - Avoid doubling up reset operations, and check the current driver state before reset to let any running operations complete. - Reorganise the LSC handler slightly to avoid enabling Tx twice. Samuel Mendoza-Jonas (6): net/ncsi: Don't en

[PATCH net-next v3 4/6] net/ncsi: Don't mark configured channels inactive

2018-11-07 Thread Samuel Mendoza-Jonas
is important because a channel can be 'active' but have its link down; in this case the channel may still need to be configured so that it may receive AEN link-state-change packets. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 17 +++-- net/ncsi/ncsi-manage.c | 3 +-- 2

[PATCH net-next v3 2/6] net/ncsi: Probe single packages to avoid conflict

2018-11-07 Thread Samuel Mendoza-Jonas
on the RMII bus when packages try to respond. Update the probe loop to probe each package one by one, and once complete check if HWA is universally supported. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/internal.h| 1 + net/ncsi/ncsi-manage.c | 85

[PATCH net-next v3 0/6] net/ncsi: Allow enabling multiple packages & channels

2018-11-07 Thread Samuel Mendoza-Jonas
packages in a few places when multi-package is enabled. - Avoid doubling up reset operations, and check the current driver state before reset to let any running operations complete. - Reorganise the LSC handler slightly to avoid enabling Tx twice. Samuel Mendoza-Jonas (6): net/ncsi: Don't en

[PATCH net-next v3 4/6] net/ncsi: Don't mark configured channels inactive

2018-11-07 Thread Samuel Mendoza-Jonas
is important because a channel can be 'active' but have its link down; in this case the channel may still need to be configured so that it may receive AEN link-state-change packets. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 17 +++-- net/ncsi/ncsi-manage.c | 3 +-- 2

Re: [RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-10 Thread Samuel Mendoza-Jonas
over channels. > > If the NCSI_ATTR_MULTI_FLAG attribute is also present then the preferred > > channel is configured for Tx/Rx and the other channels are enabled only > > for Rx. > > > > Signed-off-by: Samuel Mendoza-Jonas > > --- > > include/uapi/linux/ncs

Re: [RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-10 Thread Samuel Mendoza-Jonas
over channels. > > If the NCSI_ATTR_MULTI_FLAG attribute is also present then the preferred > > channel is configured for Tx/Rx and the other channels are enabled only > > for Rx. > > > > Signed-off-by: Samuel Mendoza-Jonas > > --- > > include/uapi/linux/ncs

[RFC PATCH 1/2] net/ncsi: Don't enable all channels when HWA available

2018-10-08 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 3 +-- net/ncsi/ncsi-manage.c | 51 +++--- 2 files changed, 9 insertions(+), 45 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 25e483e8278b..65f47a648be3 100644 --- a/net/ncsi/ncsi

[RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-08 Thread Samuel Mendoza-Jonas
for Tx/Rx and the other channels are enabled only for Rx. Signed-off-by: Samuel Mendoza-Jonas --- include/uapi/linux/ncsi.h | 16 +++ net/ncsi/internal.h | 11 +- net/ncsi/ncsi-aen.c | 2 +- net/ncsi/ncsi-manage.c| 138 net/ncsi/ncsi-netlink.c | 217

[RFC PATCH 1/2] net/ncsi: Don't enable all channels when HWA available

2018-10-08 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c| 3 +-- net/ncsi/ncsi-manage.c | 51 +++--- 2 files changed, 9 insertions(+), 45 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 25e483e8278b..65f47a648be3 100644 --- a/net/ncsi/ncsi

[RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-08 Thread Samuel Mendoza-Jonas
for Tx/Rx and the other channels are enabled only for Rx. Signed-off-by: Samuel Mendoza-Jonas --- include/uapi/linux/ncsi.h | 16 +++ net/ncsi/internal.h | 11 +- net/ncsi/ncsi-aen.c | 2 +- net/ncsi/ncsi-manage.c| 138 net/ncsi/ncsi-netlink.c | 217

[PATCH net] net/ncsi: Fixup .dumpit message flags and ID check in Netlink handler

2018-08-21 Thread Samuel Mendoza-Jonas
The ncsi_pkg_info_all_nl() .dumpit handler is missing the NLM_F_MULTI flag, causing additional package information after the first to be lost. Also fixup a sanity check in ncsi_write_package_info() to reject out of range package IDs. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi

[PATCH net] net/ncsi: Fixup .dumpit message flags and ID check in Netlink handler

2018-08-21 Thread Samuel Mendoza-Jonas
The ncsi_pkg_info_all_nl() .dumpit handler is missing the NLM_F_MULTI flag, causing additional package information after the first to be lost. Also fixup a sanity check in ncsi_write_package_info() to reject out of range package IDs. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi

[PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-16 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley <j...@jms.id.au> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-

[PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-16 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-rsp.c | 178 +-- 4 files chan

[PATCH net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-08 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley <j...@jms.id.au> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-

[PATCH net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-08 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-rsp.c | 178 +-- 4 files chan

[PATCH net-next v2] net/ncsi: Add generic netlink family

2018-03-04 Thread Samuel Mendoza-Jonas
, and NCSI_CMD_CLEAR_INTERFACE which clears any preferred setting. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Add a separate NCSI_CMD_CLEAR_INTERFACE command instead of allowing missing attributes in NCSI_CMD_SET_INTERFACE. include/uapi/linux/ncsi.h | 115 + net/ncsi/Ma

[PATCH net-next v2] net/ncsi: Add generic netlink family

2018-03-04 Thread Samuel Mendoza-Jonas
, and NCSI_CMD_CLEAR_INTERFACE which clears any preferred setting. Signed-off-by: Samuel Mendoza-Jonas --- v2: Add a separate NCSI_CMD_CLEAR_INTERFACE command instead of allowing missing attributes in NCSI_CMD_SET_INTERFACE. include/uapi/linux/ncsi.h | 115 + net/ncsi/Makefile | 2 +- net/ncsi

Re: [PATCH net-next] net/ncsi: Add generic netlink family

2018-02-26 Thread Samuel Mendoza-Jonas
On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 23 Feb 2018 15:15:18 +1100 > > > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination. > > + * Requires NCSI_ATT

Re: [PATCH net-next] net/ncsi: Add generic netlink family

2018-02-26 Thread Samuel Mendoza-Jonas
On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 23 Feb 2018 15:15:18 +1100 > > > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination. > > + * Requires NCSI_ATTR_IFINDEX and the preferred

[PATCH net-next] net/ncsi: Add generic netlink family

2018-02-22 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- include/uapi/linux/ncsi.h | 113 + net/ncsi/Makefile | 2 +- net/ncsi/internal.h | 3 + net/ncsi/ncsi-manage.c| 30 +++- net/ncsi/ncsi-netlink.c | 394 ++ net/ncs

[PATCH net-next] net/ncsi: Add generic netlink family

2018-02-22 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- include/uapi/linux/ncsi.h | 113 + net/ncsi/Makefile | 2 +- net/ncsi/internal.h | 3 + net/ncsi/ncsi-manage.c| 30 +++- net/ncsi/ncsi-netlink.c | 394 ++ net/ncsi/ncsi-netlink.h | 20 +++ 6

[PATCH] hwmon: (pmbus/ir35221) Remove unnecessary scaling

2018-01-14 Thread Samuel Mendoza-Jonas
command according to the linear format is sufficient. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- drivers/hwmon/pmbus/ir35221.c | 189 -- 1 file changed, 189 deletions(-) diff --git a/drivers/hwmon/pmbus/ir35221.c b/drivers/hwmon

[PATCH] hwmon: (pmbus/ir35221) Remove unnecessary scaling

2018-01-14 Thread Samuel Mendoza-Jonas
command according to the linear format is sufficient. Signed-off-by: Samuel Mendoza-Jonas --- drivers/hwmon/pmbus/ir35221.c | 189 -- 1 file changed, 189 deletions(-) diff --git a/drivers/hwmon/pmbus/ir35221.c b/drivers/hwmon/pmbus/ir35221.c index 8b906b44484b

[PATCH net-next] net/ncsi: Don't take any action on HNCDSC AEN

2017-12-14 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-aen.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 67e708e98ccf..e7b05de1e6d1 100644 --- a/net/ncsi/ncsi-aen.c

[PATCH net-next] net/ncsi: Don't take any action on HNCDSC AEN

2017-12-14 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 67e708e98ccf..e7b05de1e6d1 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c

[PATCH net-next 1/2] net/ncsi: Improve general state logging

2017-11-07 Thread Samuel Mendoza-Jonas
The NCSI driver is mostly silent which becomes a headache when trying to determine what has occurred on the NCSI connection. This adds additional logging in a few key areas such as state transitions and calling out certain errors more visibly. Signed-off-by: Samuel Mendoza-Jonas &l

[PATCH net-next 1/2] net/ncsi: Improve general state logging

2017-11-07 Thread Samuel Mendoza-Jonas
The NCSI driver is mostly silent which becomes a headache when trying to determine what has occurred on the NCSI connection. This adds additional logging in a few key areas such as state transitions and calling out certain errors more visibly. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi

[PATCH net-next 2/2] net/ncsi: Don't return error on normal response

2017-11-07 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-rsp.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 58186c4102f0..efd933ff5570 100644 --- a/net/ncsi/ncsi

[PATCH net-next 2/2] net/ncsi: Don't return error on normal response

2017-11-07 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-rsp.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 58186c4102f0..efd933ff5570 100644 --- a/net/ncsi/ncsi-rsp.c +++ b/net/ncsi/ncsi-rsp.c

[PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout

2017-10-18 Thread Samuel Mendoza-Jonas
failing channel should be set to active in order for deinitialization and failover to be done. Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 8 +--- 1 file changed, 5 insertions(+)

[PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found

2017-10-18 Thread Samuel Mendoza-Jonas
ed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index b022deb39d31..0

[PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout

2017-10-18 Thread Samuel Mendoza-Jonas
to active in order for deinitialization and failover to be done. Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-manage.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 09

[PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found

2017-10-18 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-manage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index b022deb39d31..0966eff48ce7 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -1005,12 +1005,15

[PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-18 Thread Samuel Mendoza-Jonas
n <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-rsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 265b9a892d41..927dad4759d1 100644 --- a/net/ncsi/ncsi-rsp.c +++ b/n

[PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-18 Thread Samuel Mendoza-Jonas
02 With this applied, no error reported on GVI response packets: # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR === GVI 200 Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas

[PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-18 Thread Samuel Mendoza-Jonas
0x164) [ 459.04] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c) This also updates the monitor instead of just returning if ncsi_xmit_cmd() fails to send the get-link-status command so that the monitor properly times out. Fixes: e6f44ed6d04d3 &quo

[PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length

2017-10-18 Thread Samuel Mendoza-Jonas
Correct the value of the HNCDSC AEN packet. Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-aen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-aen.c b/net

[PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-18 Thread Samuel Mendoza-Jonas
0x164) [ 459.04] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c) This also updates the monitor instead of just returning if ncsi_xmit_cmd() fails to send the get-link-status command so that the monitor properly times out. Fixes: e6f44ed6d04d3 "net/ncsi:

[PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length

2017-10-18 Thread Samuel Mendoza-Jonas
Correct the value of the HNCDSC AEN packet. Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-aen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 68

[PATCH net] net/ncsi: Don't limit vids based on hot_channel

2017-10-10 Thread Samuel Mendoza-Jonas
only drop a new VLAN id if we are already tracking the maximum allowed by the NCSI specification. Per-channel limits are already handled by ncsi_add_filter(), but add a message to set_one_vid() to make it obvious that the channel can not support any more VLAN ids. Signed-off-by: Samuel Mendoza-Jonas

[PATCH net] net/ncsi: Don't limit vids based on hot_channel

2017-10-10 Thread Samuel Mendoza-Jonas
only drop a new VLAN id if we are already tracking the maximum allowed by the NCSI specification. Per-channel limits are already handled by ncsi_add_filter(), but add a message to set_one_vid() to make it obvious that the channel can not support any more VLAN ids. Signed-off-by: Samuel Mendoza-Jonas

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 22 Sep 2017 11:00:00 +1000 > > > If we haven't configured a channel yet (or are in the process of doing > > so) we won't have a hot_channe

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 22 Sep 2017 11:00:00 +1000 > > > If we haven't configured a channel yet (or are in the process of doing > > so) we won't have a hot_channel - does it make more sense t

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-21 Thread Samuel Mendoza-Jonas
On Wed, 2017-09-20 at 16:05 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Wed, 20 Sep 2017 14:12:51 +1000 > > > When handling new VLAN tags in NCSI we check the maximum allowed number > > of filters on the last active ("ho

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-21 Thread Samuel Mendoza-Jonas
On Wed, 2017-09-20 at 16:05 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Wed, 20 Sep 2017 14:12:51 +1000 > > > When handling new VLAN tags in NCSI we check the maximum allowed number > > of filters on the last active ("hot") channel. However if t

[PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-19 Thread Samuel Mendoza-Jonas
is missing. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 3fd3c39e6278..fc800f934beb 100644 --- a/net/nc

[PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-19 Thread Samuel Mendoza-Jonas
is missing. Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-manage.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 3fd3c39e6278..fc800f934beb 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-30 Thread Samuel Mendoza-Jonas
an_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! >>> ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! Add definitions for !CONFIG_NET_NCSI to bring it into line with the rest of

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-30 Thread Samuel Mendoza-Jonas
an_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! >>> ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! Add definitions for !CONFIG_NET_NCSI to bring it into line with the rest of ncsi.h

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-29 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Mon, 28 Aug 2017 16:18:40 +1000 > > > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > > A fair amount of code alrea

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-29 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Mon, 28 Aug 2017 16:18:40 +1000 > > > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > > A fair amount of code already exists in the NCSI sta

[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions

2017-08-28 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi

[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions

2017-08-28 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index 5e03ed190e18

[PATCH net-next v3 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-28 Thread Samuel Mendoza-Jonas
Mendoza-Jonas <s...@mendozajonas.com> --- v2: Moved ftgmac100 change into same patch and reordered drivers/net/ethernet/faraday/ftgmac100.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c

[PATCH net-next v3 2/3] net/ncsi: Configure VLAN tag filter

2017-08-28 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v3: - Add comment describing change to ncsi_find_filter() - Catch NULL in clear_one_vid() from ncsi_get_filter() - S

[PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-28 Thread Samuel Mendoza-Jonas
changes when kicking updated channel Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering when available drivers/net/ethernet/faraday/ftgmac100.c | 5 + include/net/ncsi.h | 2

[PATCH net-next v3 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-28 Thread Samuel Mendoza-Jonas
Mendoza-Jonas --- v2: Moved ftgmac100 change into same patch and reordered drivers/net/ethernet/faraday/ftgmac100.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 34dae51effd4..05fe7123d5ae 100644

[PATCH net-next v3 2/3] net/ncsi: Configure VLAN tag filter

2017-08-28 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas --- v3: - Add comment describing change to ncsi_find_filter() - Catch NULL in clear_one_vid() from ncsi_get_filter() - Simplify state changes when kic

[PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-28 Thread Samuel Mendoza-Jonas
changes when kicking updated channel Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering when available drivers/net/ethernet/faraday/ftgmac100.c | 5 + include/net/ncsi.h | 2

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-14 at 11:39 +0930, Joel Stanley wrote: > On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas > <s...@mendozajonas.com> wrote: > > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > > stack process new VLAN tags and configure

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-14 at 11:39 +0930, Joel Stanley wrote: > On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas > wrote: > > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > > stack process new VLAN tags and configure the channel VLAN filter > > ap

[PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-13 Thread Samuel Mendoza-Jonas
Mendoza-Jonas <s...@mendozajonas.com> --- v2: Moved ftgmac100 change into same patch and reordered drivers/net/ethernet/faraday/ftgmac100.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c

[PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-13 Thread Samuel Mendoza-Jonas
Mendoza-Jonas --- v2: Moved ftgmac100 change into same patch and reordered drivers/net/ethernet/faraday/ftgmac100.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 34dae51effd4..05fe7123d5ae 100644

[PATCH net-next v2 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
adds the appropriate flag and callbacks to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering

[PATCH net-next v2 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
adds the appropriate flag and callbacks to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering

[PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

2017-08-13 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi

[PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- include/net/ncsi.h | 2 + net/ncsi/internal.h| 11 ++ net/ncsi/ncsi-manage.c | 295 ++

[PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

2017-08-13 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index 5e03ed190e18

[PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas --- include/net/ncsi.h | 2 + net/ncsi/internal.h| 11 ++ net/ncsi/ncsi-manage.c | 295 - net/ncsi/ncsi-rsp.c

Re: [PATCH 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
On Fri, 2017-08-11 at 14:48 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 11 Aug 2017 16:16:45 +1000 > > > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation. > > A fair amount of code alrea

Re: [PATCH 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
On Fri, 2017-08-11 at 14:48 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 11 Aug 2017 16:16:45 +1000 > > > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation. > > A fair amount of code already exists in the NCSI sta

[PATCH 1/3] ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features

2017-08-11 Thread Samuel Mendoza-Jonas
This is required for the VLAN core to call the add/kill callback for VLAN IDs. 'ftgmac100' already supports VLAN tagging but this flag lets the network stack know that we want to be notified of VLAN tags being added or removed when we have NCSI support. Signed-off-by: Samuel Mendoza-Jonas &l

[PATCH 1/3] ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features

2017-08-11 Thread Samuel Mendoza-Jonas
This is required for the VLAN core to call the add/kill callback for VLAN IDs. 'ftgmac100' already supports VLAN tagging but this flag lets the network stack know that we want to be notified of VLAN tags being added or removed when we have NCSI support. Signed-off-by: Samuel Mendoza-Jonas

[PATCH 2/3] net/ncsi: Fix several packet definitions

2017-08-11 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index db7083bfd476..1fec9f

[PATCH 0/3] NCSI VLAN Filtering Support

2017-08-11 Thread Samuel Mendoza-Jonas
adds the appropriate flag to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter

[PATCH 2/3] net/ncsi: Fix several packet definitions

2017-08-11 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas --- net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index db7083bfd476..1fec9fda7f60 100644 --- a/net/ncsi

[PATCH 0/3] NCSI VLAN Filtering Support

2017-08-11 Thread Samuel Mendoza-Jonas
adds the appropriate flag to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter

[PATCH 3/3] net/ncsi: Configure VLAN tag filter

2017-08-11 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- drivers/net/ethernet/faraday/ftgmac100.c | 2 + include/net/ncsi.h | 2 + net/ncsi/internal.h

[PATCH 3/3] net/ncsi: Configure VLAN tag filter

2017-08-11 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas --- drivers/net/ethernet/faraday/ftgmac100.c | 2 + include/net/ncsi.h | 2 + net/ncsi/internal.h | 11 ++ ne

Re: doc: Document suitability of IBM Verse for kernel development

2017-06-19 Thread Samuel Mendoza-Jonas
* > + > +See Lotus Notes. > + > Mutt (TUI) > ** > Acked-by: Samuel Mendoza-Jonas <s...@mendozajonas.com>

Re: doc: Document suitability of IBM Verse for kernel development

2017-06-19 Thread Samuel Mendoza-Jonas
t; index ac892b30815e..07faa5457bcb 100644 > --- a/Documentation/process/email-clients.rst > +++ b/Documentation/process/email-clients.rst > @@ -167,6 +167,11 @@ Lotus Notes (GUI) > > Run away from it. > > +IBM Verse (Web GUI) > +*** > + > +See Lotus Notes. > + > Mutt (TUI) > ** > Acked-by: Samuel Mendoza-Jonas

Re: [PATCH v5 11/13] powerpc: Allow userspace to set device tree properties in kexec_file_load

2016-08-11 Thread Samuel Mendoza-Jonas
On Thu, 2016-08-11 at 20:08 -0300, Thiago Jung Bauermann wrote: > Implement the arch_kexec_verify_buffer hook to verify that a device > tree blob passed by userspace via kexec_file_load contains only nodes > and properties from a whitelist. > > In elf64_load we merge those properties into the

Re: [PATCH v5 11/13] powerpc: Allow userspace to set device tree properties in kexec_file_load

2016-08-11 Thread Samuel Mendoza-Jonas
On Thu, 2016-08-11 at 20:08 -0300, Thiago Jung Bauermann wrote: > Implement the arch_kexec_verify_buffer hook to verify that a device > tree blob passed by userspace via kexec_file_load contains only nodes > and properties from a whitelist. > > In elf64_load we merge those properties into the

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-09 Thread Samuel Mendoza-Jonas
On Tue, 2016-08-09 at 10:19 -0300, Thiago Jung Bauermann wrote: > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > > > > On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > > > > > > Mimi Zohar writes: > > > > > > > > diff --git

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-09 Thread Samuel Mendoza-Jonas
On Tue, 2016-08-09 at 10:19 -0300, Thiago Jung Bauermann wrote: > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > > > > On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > > > > > > Mimi Zohar writes: > > > > > > > > diff --git a/security/integrity/ima/ima.h > > > >

[PATCH] tty/hvc: Use IRQF_SHARED for hvc consoles

2016-03-18 Thread Samuel Mendoza-Jonas
is closed, but OPAL will still generate interrupts that are not handled, leading to rcu_sched stall warnings. Set IRQF_SHARED when calling request_irq, allowing additional consoles to start properly. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> Cc: <sta...@vger.kernel.org>

[PATCH] tty/hvc: Use IRQF_SHARED for hvc consoles

2016-03-18 Thread Samuel Mendoza-Jonas
is closed, but OPAL will still generate interrupts that are not handled, leading to rcu_sched stall warnings. Set IRQF_SHARED when calling request_irq, allowing additional consoles to start properly. Signed-off-by: Samuel Mendoza-Jonas Cc: # 4.1.x- --- drivers/tty/hvc/hvc_irq.c | 5 - 1 file