On Wed, Aug 14, 2013 at 2:41 PM, Julia Lawall wrote:
>
> From: Julia Lawall
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to devm_ioremap_resource.
>
> A debugging statement in the error-handling code is removed as well, as it
> doe
On Thu, Jul 11, 2013 at 6:31 PM, Tanya Brokhman wrote:
> When the scheduler reports to the block layer that there is an urgent
> request pending, the device driver may decide to stop the transmission
> of the current request in order to handle the urgent one. This is done
> in order to reduce the
On Thu, Jun 13, 2013 at 10:06 AM, Sujit Reddy Thumma
wrote:
> On 6/12/2013 11:04 AM, Santosh Y wrote:
>>>
>>>
>>> /**
>>> + * ufshcd_query_request() - API for issuing query request to the
>>> device.
>>> + * @hba: ufs
On Fri, Jun 14, 2013 at 1:10 PM, Sujit Reddy Thumma
wrote:
> On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote:
>>>
>>> static struct scsi_host_template ufshcd_driver_template = {
>>> @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct
>>> ufs_hba **hba_handle,
>>> /* Configu
>
> /**
> + * ufshcd_query_request() - API for issuing query request to the device.
> + * @hba: ufs driver context
> + * @query: params for query request
> + * @descriptor: buffer for sending/receiving descriptor
> + * @retries: number of times to try executing the command
> + *
> + * All n
> +/*
> + * ufshcd_wait_for_register - wait for register value to change
> + * @hba - per-adapter interface
> + * @reg - mmio register offset
> + * @mask - mask to apply to read register value
> + * @val - wait condition
> + * @interval_us - polling interval in microsecs
> + * @timeout_ms - timeout
On Fri, May 24, 2013 at 7:52 AM, Libo Chen wrote:
>
> we should check kzalloc, avoid to hit oops
>
> Signed-off-by: Libo Chen
> ---
> drivers/scsi/megaraid.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index
rnings mentioned by Dan in the previous mail.
Re-base it on Seungwon's V4 patch series and you can add my Acked-by:
Santosh Y
> + "%s: NULL pointer hba = %p, query = %p response =
> %p\n",
> +
> +
> +/**
> + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU)
> + * @hba - UFS hba
> + * @lrb - pointer to local reference block
> + */
> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> +{
> + u32 upiu_flags;
> + int ret = 0;
> +
> +
> +
> +/**
> + * ufshcd_validate_dev_connection() - Check device connection status
> + * @hba: per-adapter instance
> + *
> + * Send NOP OUT UPIU and wait for NOP IN response to check whether the
> + * device Transport Protocol (UTP) layer is ready after a reset.
> + * If the UTP layer at the devic
> -static inline void
> -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd)
> +static int ufshcd_send_uic_command(struct ufs_hba *hba,
> + struct uic_command *uic_cmnd, int retries)
> {
> + int err = 0;
> + unsigned long flags;
> +
> + if (un
> + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU)
> + * @hba - UFS hba
> + * @lrb - pointer to local reference block
> + */
> +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb
> *lrbp)
> +{
> + u32 upiu_flags;
> + int ret = 0;
> +
> + if (!l
>
> This can be done inside the following if condition i.e. if
> (hba->query.descriptor != NULL).
> and change the condition to if (!hba->query.descriptor).
>
I meant to write if (hba->query.descriptor)...:-)
--
~Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
linux-...@vger.kernel.org is for UFS filesystem.
> The API for submitting a query request is ufs_query_request() in
> ufs_core.c. This function is responsible for:
This can be part of ufshcd.c which is actually the core file, no need
to create a new core file for the function.
> +
> +#define UFS
14 matches
Mail list logo
