Re: [alsa-devel] [PATCH v2 0/3] soundwire: debugfs support for 5.4

t; hardware capabilities) > squashed patch 3 > Changes looks good to me. Acked-by: Sanyog Kale > ___ > Alsa-devel mailing list > alsa-de...@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --

Re: [RFC PATCH 27/40] soundwire: Add Intel resource management algorithm

Developers can > also implement their own .compute_params() callback for specific > resource management algorithm. > > Credits: this patch is based on an earlier internal contribution by > Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. All hard-coded > values were removed fro

Re: [RFC PATCH 28/40] soundwire: intel: handle disabled links

On Thu, Jul 25, 2019 at 06:40:20PM -0500, Pierre-Louis Bossart wrote: > On most hardware platforms, SoundWire interfaces are pin-muxed with > other interfaces (typically DMIC or I2S) and the status of each link > needs to be checked at boot time. > > For Intel platforms, the BIOS provides a menu

Re: [alsa-devel] [RFC PATCH 23/40] soundwire: stream: fix disable sequence

On Mon, Aug 05, 2019 at 10:33:25AM -0500, Pierre-Louis Bossart wrote: > > > On 8/5/19 4:56 AM, Sanyog Kale wrote: > > On Thu, Jul 25, 2019 at 06:40:15PM -0500, Pierre-Louis Bossart wrote: > > > When we disable the stream and then call hw_free, two bank switch

Re: [RFC PATCH 26/40] soundwire: cadence_master: fix divider setting in clock register

On Thu, Jul 25, 2019 at 06:40:18PM -0500, Pierre-Louis Bossart wrote: > From: Rander Wang > > The existing code uses an OR operation which would mix the original > divider setting with the new one, resulting in an invalid > configuration that can make codecs hang. > > Add the mask definition

Re: [RFC PATCH 25/40] soundwire: intel: use BIOS information to set clock dividers

On Thu, Jul 25, 2019 at 06:40:17PM -0500, Pierre-Louis Bossart wrote: > The BIOS provides an Intel-specific property, let's use it to avoid > hard-coded clock dividers. > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/cadence_master.c | 26 ++ >

Re: [RFC PATCH 24/40] soundwire: cadence_master: use BIOS defaults for frame shape

On Thu, Jul 25, 2019 at 06:40:16PM -0500, Pierre-Louis Bossart wrote: > Remove hard-coding and use BIOS values. If they are wrong use default > 48x2 frame shape. > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/cadence_master.c | 19 +-- > 1 file changed, 17

Re: [RFC PATCH 23/40] soundwire: stream: fix disable sequence

On Thu, Jul 25, 2019 at 06:40:15PM -0500, Pierre-Louis Bossart wrote: > When we disable the stream and then call hw_free, two bank switches > will be handled and as a result we re-enable the stream on hw_free. > I didnt quite get why there will be two bank switches as part of disable flow which

Re: [RFC PATCH 21/40] soundwire: export helpers to find row and column values

On Thu, Jul 25, 2019 at 06:40:13PM -0500, Pierre-Louis Bossart wrote: > Add a prefix for common tables and export 2 helpers to set the frame > shapes based on row/col values. > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/bus.h| 7 +-- > drivers/soundwire/stream.c |

Re: [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE

On Thu, Jul 25, 2019 at 06:40:01PM -0500, Pierre-Louis Bossart wrote: > Per the hardware documentation, all changes to MCP_CONFIG, > MCP_CONTROL, MCP_CMDCTRL and MCP_PHYCTRL need to be validated with a > self-clearing write to MCP_CONFIG_UPDATE. > > For some reason, the existing code only does

Re: [RFC PATCH 02/40] soundwire: cadence_master: add debugfs register dump

On Thu, Jul 25, 2019 at 06:39:54PM -0500, Pierre-Louis Bossart wrote: > Add debugfs file to dump the Cadence master registers > > Credits: this patch is based on an earlier internal contribution by > Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change > is the u

Re: [alsa-devel] [PATCH v2] soundwire: stream: fix bad unlock balance

link cases only but released > > > unconditionally, leading to an unlock balance warning for > > > single-link usages"? > > Yes. > > Thanks for the precision. the change is legit so assuming the commit message > is reworded to mention single link usage please feel free to take the > following tag. > > Acked-by: Pierre-Louis Bossart > Changes looks okay to me. Please update commit message as pierre suggested. Acked-by: Sanyog Kale > > Thanks! --

Re: [PATCH] soundwire: stream: fix bad unlock balance

On Thu, May 23, 2019 at 10:30:20AM +0100, Srinivas Kandagatla wrote: > > > On 23/05/2019 10:20, Sanyog Kale wrote: > > On Thu, May 23, 2019 at 09:43:14AM +0100, Srinivas Kandagatla wrote: > > > > > > > > > On 22/05/2019 17:41, Pierre-Louis Bossart wrot

Re: [PATCH] soundwire: stream: fix bad unlock balance

On Thu, May 23, 2019 at 09:43:14AM +0100, Srinivas Kandagatla wrote: > > > On 22/05/2019 17:41, Pierre-Louis Bossart wrote: > > > > > > On 5/22/19 11:25 AM, Srinivas Kandagatla wrote: > > > This patch fixes below warning due to unlocking without locking. > > > > > > ??

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

ific data > >c) Implement ones own methods which do not use anything provided > > here > > > > Signed-off-by: Sanyog Kale <sanyog.r.k...@intel.com> > > Signed-off-by: Vinod Koul <vinod.k...@intel.com> > > --- > > 5 files changed, 733 inser

Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

ific data > >c) Implement ones own methods which do not use anything provided > > here > > > > Signed-off-by: Sanyog Kale > > Signed-off-by: Vinod Koul > > --- > > 5 files changed, 733 insertions(+), 1 deletion(-) > > create mode 100644

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to