[PATCH] of: property: Fix fw_devlink handling of interrupts/interrupts-extended

2021-02-08 Thread Saravana Kannan
Commit 4104ca776ba3 ("of: property: Add fw_devlink support for interrupts") was not taking interrupt-map into account. Fix that. Reported-by: Marek Szyprowski Fixes: 4104ca776ba3 ("of: property: Add fw_devlink support for interrupts") Signed-off-by: Saravana Kannan Tested-

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-08 Thread Saravana Kannan
On Mon, Feb 8, 2021 at 12:14 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 06.02.2021 05:32, Saravana Kannan wrote: > > On Fri, Feb 5, 2021 at 9:55 AM Saravana Kannan wrote: > >> On Fri, Feb 5, 2021 at 9:52 AM Geert Uytterhoeven > >> wrote: > >

Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving

2021-02-08 Thread Saravana Kannan
On Mon, Feb 8, 2021 at 12:40 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 05.02.2021 23:26, Saravana Kannan wrote: > > There are a lot of devices/drivers where they never have a struct device > > created for them or the driver initializes the hardware without ever &

Re: [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed

2021-02-08 Thread Saravana Kannan
On Mon, Feb 8, 2021 at 7:39 AM Rob Herring wrote: > > On Fri, Feb 5, 2021 at 4:27 PM Saravana Kannan wrote: > > > > This allows fw_devlink to recognize clock provider drivers that don't > > use the device-driver model to initialize the device. fw_devlink will >

Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving

2021-02-06 Thread Saravana Kannan
On Sat, Feb 6, 2021 at 11:41 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Fri, Feb 5, 2021 at 11:26 PM Saravana Kannan wrote: > > There are a lot of devices/drivers where they never have a struct device > > created for them or the driver initializes the hardware

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-05 Thread Saravana Kannan
On Fri, Feb 5, 2021 at 9:55 AM Saravana Kannan wrote: > > On Fri, Feb 5, 2021 at 9:52 AM Geert Uytterhoeven > wrote: > > > > Hi Saravana, > > > > On Fri, Feb 5, 2021 at 6:20 PM Saravana Kannan wrote: > > > On Fri, Feb 5, 2021 at 2:20 AM Geert Uytterh

Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving

2021-02-05 Thread Saravana Kannan
On Fri, Feb 5, 2021 at 2:26 PM Saravana Kannan wrote: > > There are a lot of devices/drivers where they never have a struct device > created for them or the driver initializes the hardware without ever > binding to the struct device. > > This series is intended to avoid any bo

[PATCH v4 2/8] of: property: Don't add links to absent suppliers

2021-02-05 Thread Saravana Kannan
If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH v4 3/8] driver core: Add fw_devlink.strict kernel param

2021-02-05 Thread Saravana Kannan
This param allows forcing all dependencies to be treated as mandatory. This will be useful for boards in which all optional dependencies like IOMMUs and DMAs need to be treated as mandatory dependencies. Signed-off-by: Saravana Kannan --- Documentation/admin-guide/kernel-parameters.txt | 5

[PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed

2021-02-05 Thread Saravana Kannan
to appear and bind to a driver. Signed-off-by: Saravana Kannan --- drivers/clk/clk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 8c1d04db990d..27ff90eacb1f 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -4555,6 +455

[PATCH v4 0/8] Make fw_devlink=on more forgiving

2021-02-05 Thread Saravana Kannan
. Patch 3 and 4 allow for handling optional DT bindings. Patch 5 sets up a generic API to handle drivers that never bind with their devices. Patch 6 through 8 update different frameworks to use the new API. Thanks, Saravana Saravana Kannan (8): driver core: fw_devlink: Detect supplier devices

[PATCH v4 4/8] of: property: Add fw_devlink support for optional properties

2021-02-05 Thread Saravana Kannan
Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/of

[PATCH v4 6/8] irqdomain: Mark fwnodes when their irqdomain is added/removed

2021-02-05 Thread Saravana Kannan
bind to a driver. Signed-off-by: Saravana Kannan --- kernel/irq/irqdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 6aacd342cd14..288151393a06 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -205,6 +205,7

[PATCH v4 5/8] driver core: fw_devlink: Handle suppliers that don't use driver core

2021-02-05 Thread Saravana Kannan
doesn't make the consumers wait indefinitely on suppliers that'll never bind to a driver. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 15 +++ include/linux/fwnode.h | 19 +-- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v4 7/8] PM: domains: Mark fwnodes when their powerdomain is added/removed

2021-02-05 Thread Saravana Kannan
appear and bind to a driver. Signed-off-by: Saravana Kannan --- drivers/base/power/domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 9a14eedacb92..6ac52a038bb9 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/powe

[PATCH v4 1/8] driver core: fw_devlink: Detect supplier devices that will never be added

2021-02-05 Thread Saravana Kannan
is blocked on a firmware node that will never be populated as a device. We also mark such fwnodes as NOT_DEVICE, so that no new fwnode links are created with these nodes as suppliers. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan Acked-b

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-05 Thread Saravana Kannan
On Fri, Feb 5, 2021 at 12:06 AM Geert Uytterhoeven wrote: > > Hi Marek, > > On Fri, Feb 5, 2021 at 8:38 AM Marek Szyprowski > wrote: > > On 04.02.2021 22:31, Saravana Kannan wrote: > > > On Thu, Feb 4, 2021 at 3:52 AM Marek Szyprowski > > > wrote: >

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-05 Thread Saravana Kannan
On Fri, Feb 5, 2021 at 9:52 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Fri, Feb 5, 2021 at 6:20 PM Saravana Kannan wrote: > > On Fri, Feb 5, 2021 at 2:20 AM Geert Uytterhoeven > > wrote: > > > On Fri, Feb 5, 2021 at 11:06 AM Saravana Kannan > &g

Re: [PATCH 4.14 07/15] driver core: Extend device_is_dependent()

2021-02-05 Thread Saravana Kannan
n, modify device_is_dependent() to check the ancestors > of the target device by following its parent pointer in addition to > the device_for_each_child() walk. > > Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support") > Reported-by: Stephan Gerhold

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-05 Thread Saravana Kannan
On Fri, Feb 5, 2021 at 2:20 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Fri, Feb 5, 2021 at 11:06 AM Saravana Kannan wrote: > > On Fri, Feb 5, 2021 at 12:06 AM Geert Uytterhoeven > > wrote: > > > On Fri, Feb 5, 2021 at 8:38 AM Marek Szyprowski > >

Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Saravana Kannan
On Thu, Feb 4, 2021 at 5:54 PM Fabio Estevam wrote: > > Hi Saravana, > > On Thu, Feb 4, 2021 at 10:39 PM Saravana Kannan wrote: > > > > Using IRQCHIP_DECLARE lets fw_devlink know that it should not wait for > > these interrupt controllers to be populated as st

[PATCH v1] gpiolib: Don't probe gpio_device if it's not the primary device

2021-02-04 Thread Saravana Kannan
ind gpio_device to a driver to enable fw_devlink=on by default") Signed-off-by: Saravana Kannan Tested-by: Dmitry Osipenko --- Greg/Linus, This will need to go into driver-core because the Fixes is in driver-core too. Thanks, Saravana drivers/gpio/gpiolib.c | 14 ++ 1 file chan

[PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Saravana Kannan
' probes forever. Converting to IRQCHIP_DECLARE addresses boot issues on imx25 with fw_devlink=on that were reported by Martin. This also removes a lot of boilerplate code. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by:

[PATCH v2] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Saravana Kannan
Remove a lot of boilerplate code. Also address boot issues on imx25 with fw_devlink=on that were reported by Martin. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by: Saravana Kannan Tested-by: Martin Kaiser --- v1 -> v

[PATCH v3 3/4] driver core: Add fw_devlink.strict kernel param

2021-02-04 Thread Saravana Kannan
This param allows forcing all dependencies to be treated as mandatory. This will be useful for boards in which all optional dependencies like IOMMUs and DMAs need to be treated as mandatory dependencies. Signed-off-by: Saravana Kannan --- Documentation/admin-guide/kernel-parameters.txt | 5

[PATCH v3 4/4] of: property: Add fw_devlink support for optional properties

2021-02-04 Thread Saravana Kannan
Not all DT bindings are mandatory bindings. Add support for optional DT bindings and mark iommus, iommu-map, dmas as optional DT bindings. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/of

[PATCH v3 1/4] driver core: fw_devlink: Detect supplier devices that will never be added

2021-02-04 Thread Saravana Kannan
is blocked on a firmware node that will never be populated as a device. We also mark such fwnodes as NOT_DEVICE, so that no new fwnode links are created with these nodes as suppliers. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan Acked-b

[PATCH v3 2/4] of: property: Don't add links to absent suppliers

2021-02-04 Thread Saravana Kannan
If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH v3 0/4] Make fw_devlink=on more forgiving

2021-02-04 Thread Saravana Kannan
ch to ise the flag set in patch 1 to not create bad links. v2 -> v3: - Patch 1: Added Rafael's Ack - New patches 3 and 4 Saravana Kannan (4): driver core: fw_devlink: Detect supplier devices that will never be added of: property: Don't add links to absent suppliers driver cor

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-04 Thread Saravana Kannan
On Thu, Feb 4, 2021 at 3:52 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 21.01.2021 23:57, Saravana Kannan wrote: > > This allows fw_devlink to create device links between consumers of an > > interrupt and the supplier of the interrupt. > > > > Cc: Marc Z

Re: [PATCH v2 3/3] of: property: Don't add links to absent suppliers

2021-02-04 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 8:33 PM Saravana Kannan wrote: > > If driver core marks a firmware node as not a device, don't add fwnode > links where it's a supplier. > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Signed-off-by: Saravana

Re: [PATCH v2 2/3] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-02-04 Thread Saravana Kannan
On Thu, Feb 4, 2021 at 10:41 AM Rafael J. Wysocki wrote: > > On Tue, Feb 2, 2021 at 8:47 PM Saravana Kannan wrote: > > > > On Tue, Feb 2, 2021 at 6:34 AM Rafael J. Wysocki wrote: > > > > > > On Tue, Feb 2, 2021 at 5:33 AM Saravana Ka

Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

2021-02-03 Thread Saravana Kannan
On Wed, Feb 3, 2021 at 1:58 PM Martin Kaiser wrote: > > Thus wrote Saravana Kannan (sarava...@google.com): > > > > With modules disabled, the kernel boots but probe fails for some > > > (non-mainline) drivers in my tree. > > > Thanks Martin! > > > >

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-03 Thread Saravana Kannan
ock is the timer, which is used as a > clocksource, and needs the clock initialized early. Postponing the > timers caused the fail at boot. > > Signed-off-by: Tudor Ambarus Thanks Tudor! Acked-by: Saravana Kannan -Saravana > --- > Tested on sama5d2_xplained. > > driv

Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

2021-02-03 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 11:55 PM Geert Uytterhoeven wrote: > > On Tue, Feb 2, 2021 at 11:44 PM Saravana Kannan wrote: > > On Tue, Feb 2, 2021 at 1:22 PM Martin Kaiser wrote: > > > Thus wrote Saravana Kannan (sarava...@google.com): > > > All of those drivers have a g

Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 1:22 PM Martin Kaiser wrote: > > Hi Saravana, > > Thus wrote Saravana Kannan (sarava...@google.com): > > > Martin, > > > If you tested this series, can you please give a Tested-by? > > I tested this v2 series on top of next-20210202 (w

Re: [PATCH v2 2/3] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 6:34 AM Rafael J. Wysocki wrote: > > On Tue, Feb 2, 2021 at 5:33 AM Saravana Kannan wrote: > > > > After a deferred probe attempt has exhaused all the devices that can be > > bound, any device that remains unbound has one/both of these conditions

Re: [PATCH v2 1/3] driver core: fw_devlink: Detect supplier devices that will never be added

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 6:12 AM Rafael J. Wysocki wrote: > > On Tue, Feb 2, 2021 at 5:33 AM Saravana Kannan wrote: > > > > During the initial parsing of firmware by fw_devlink, fw_devlink might > > infer that some supplier firmware nodes would get populated as devices.

Re: [PATCH v1 2/2] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 12:49 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Mon, Feb 1, 2021 at 9:49 PM Saravana Kannan wrote: > > On Mon, Feb 1, 2021 at 2:32 AM Geert Uytterhoeven > > wrote: > > > On Sat, Jan 30, 2021 at 5:03 AM Saravana Kannan >

Re: [PATCH v2 0/3] Make fw_devlink=on more forgiving

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 9:41 AM Rob Herring wrote: > > On Tue, Feb 2, 2021 at 10:52 AM wrote: > > > > Hi, Saravana, > > > > On 2/2/21 6:33 AM, Saravana Kannan wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > >

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-02-02 Thread Saravana Kannan
On Tue, Feb 2, 2021 at 12:12 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 01.02.2021 10:02, Saravana Kannan wrote: > > On Mon, Feb 1, 2021 at 12:05 AM Marek Szyprowski > > wrote: > >> On 30.01.2021 05:08, Saravana Kannan wrote: > >>> On

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-02-02 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 11:55 PM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Tue, Feb 2, 2021 at 4:01 AM Saravana Kannan wrote: > > On Mon, Feb 1, 2021 at 2:40 AM Geert Uytterhoeven > > wrote: > > > On Sat, Jan 30, 2021 at 5:09 AM Saravana Kannan &g

[PATCH v2 3/3] of: property: Don't add links to absent suppliers

2021-02-01 Thread Saravana Kannan
If driver core marks a firmware node as not a device, don't add fwnode links where it's a supplier. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH v2 2/3] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-02-01 Thread Saravana Kannan
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/base/base.h | 2 + drivers/base/core.c | 104 drivers/base/dd.c | 5 +++ 3 files changed, 94 insertions(+), 17 deletions(-) di

[PATCH v2 1/3] driver core: fw_devlink: Detect supplier devices that will never be added

2021-02-01 Thread Saravana Kannan
is blocked on a firmware node that will never be populated as a device. We also mark such fwnodes as NOT_DEVICE, so that no new fwnode links are created with these nodes as suppliers. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan ---

[PATCH v2 0/3] Make fw_devlink=on more forgiving

2021-02-01 Thread Saravana Kannan
7;s a bug), but I think this series will fix your issue too (even without the clock driver fix). Can you please give this a shot? Martin, If you tested this series, can you please give a Tested-by? Thanks, Saravana v1 -> v2: Patch 1: Added a flag to fwnodes that aren't devices. Patch 3: Ne

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 2:40 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Sat, Jan 30, 2021 at 5:09 AM Saravana Kannan wrote: > > On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan > > wrote: > > > This patch series solves two general issues with fw

Re: [PATCH v1 2/2] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 2:32 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Sat, Jan 30, 2021 at 5:03 AM Saravana Kannan wrote: > > After a deferred probe attempt has exhaused all the devices that can be > > bound, any device that remains unbound has one/both of t

Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 8:49 AM Dmitry Osipenko wrote: > > 01.02.2021 00:28, Saravana Kannan пишет: > >> This patch causes these new errors on NVIDIA Tegra30 Nexus 7 using recent > >> linux-next: > >> > >> gpio-1022 (cpu-pwr-req-hog): hogged as input &g

Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 2:52 AM Martin Kaiser wrote: > > Hi Saravana, > > Thus wrote Saravana Kannan (sarava...@google.com): > > > This series [1] has a high chance of fixing it for you if > > CONFIG_MODULES is disabled in your set up. Can you give it a shot? > >

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 2:54 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Thu, Jan 28, 2021 at 6:08 PM Saravana Kannan wrote: > > I already accounted for early clocks like this when I designed > > fw_devlink. Each driver shouldn't need to set OF_POPULATED.

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 12:05 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 30.01.2021 05:08, Saravana Kannan wrote: > > On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan > > wrote: > >> This patch series solves two general issues with fw_devlink=on > >

Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Saravana Kannan
On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam wrote: > > Hi Saravana, > > On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan wrote: > > > +static int __init imx_avic_init(struct device_node *node, > > + struct device_node *parent) >

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-01-31 Thread Saravana Kannan
On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan wrote: > > This patch series solves two general issues with fw_devlink=on > > Patch 1/2 addresses the issue of firmware nodes that look like they'll > have struct devices created for them, but will never actually have > struct

Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-31 Thread Saravana Kannan
On Sat, Jan 30, 2021 at 9:39 AM Dmitry Osipenko wrote: > > 22.01.2021 22:35, Saravana Kannan пишет: > > There are multiple instances of GPIO device tree nodes of the form: > > > > foo { > > compatible = "acme,foo"; > >

Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props

2021-01-31 Thread Saravana Kannan
On Sun, Jan 31, 2021 at 8:38 AM Martin Kaiser wrote: > > Dear all, > > Thus wrote Saravana Kannan (sarava...@google.com): > > > Sending again because I messed up the To/Cc for the coverletter. > > > This series combines two patches [1] [2] that'd conflict. &g

[PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Saravana Kannan
Remove a lot of boilerplate code. Also address boot issues on imx25 with fw_devlink=on that were reported by Martin. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by: Saravana Kannan --- I've compile tested this for imx25

[PATCH v1 2/2] driver core: fw_devlink: Handle missing drivers for optional suppliers

2021-01-30 Thread Saravana Kannan
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/base/base.h | 2 + drivers/base/core.c | 104 drivers/base/dd.c | 5 +++ 3 files changed, 94 insertions(+), 17 deletions(-) di

[PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-01-30 Thread Saravana Kannan
this a shot? Marc, Can you try this series with the gpiolib fix reverted please? I'm pretty sure this will fix that case. Linus, This series very likely removes the need for the gpiolib patch (we can wait for Marc to confirm). I'm split on whether we should leave it in or not. Tho

[PATCH v1 1/2] driver core: fw_devlink: Detect supplier devices that will never be added

2021-01-30 Thread Saravana Kannan
will never be populated as a device. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/base/core.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/driv

Re: [PATCH v1 0/2] Make fw_devlink=on more forgiving

2021-01-29 Thread Saravana Kannan
On Fri, Jan 29, 2021 at 8:03 PM Saravana Kannan wrote: > > This patch series solves two general issues with fw_devlink=on > > Patch 1/2 addresses the issue of firmware nodes that look like they'll > have struct devices created for them, but will never actually have > struct

Re: [PATCH v1 0/5] Enable fw_devlink=on by default

2021-01-28 Thread Saravana Kannan
On Thu, Jan 28, 2021 at 7:03 AM Jon Hunter wrote: > > > On 14/01/2021 16:56, Jon Hunter wrote: > > > > On 14/01/2021 16:47, Saravana Kannan wrote: > > > > ... > > > >>> Yes this is the warning shown here [0] and this is coming from > >&

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-01-28 Thread Saravana Kannan
On Thu, Jan 28, 2021 at 2:59 AM wrote: > > Hi, Saravana, > > On 1/25/21 8:16 PM, Saravana Kannan wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Jan 25, 2021 at 9:05 AM wrote: > >

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-01-28 Thread Saravana Kannan
On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus wrote: > > The sama5d2 requires the clock provider initialized before timers. > We can't use a platform driver for the sama5d2-pmc driver, as the > platform_bus_init() is called later on, after time_init(). > > As fw_devlink considers only devices, it

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-27 Thread Saravana Kannan
On Wed, Jan 27, 2021 at 8:56 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 27, 2021 at 5:42 PM Saravana Kannan wrote: > > On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven > > wrote: > > > On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan &g

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-27 Thread Saravana Kannan
On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan wrote: > > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > > wrote: > > > On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan &g

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Saravana Kannan
On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan wrote: > > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > > Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: > > &g

Re: [PATCH v2] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-26 Thread Saravana Kannan
On Tue, Jan 26, 2021 at 1:40 AM Andy Shevchenko wrote: > > > > On Friday, January 22, 2021, Saravana Kannan wrote: >> >> There are multiple instances of GPIO device tree nodes of the form: >> >> foo { >> compatible = "acme,foo"

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-01-25 Thread Saravana Kannan
On Thu, Jan 21, 2021 at 8:04 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 20, 2021 at 6:23 PM Saravana Kannan wrote: > > On Wed, Jan 20, 2021 at 6:27 AM Geert Uytterhoeven > > wrote: > > > On Wed, Jan 20, 2021 at 10:40 AM Geert Uytterhoeven >

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Saravana Kannan
On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: > > Hi Saravana, > > > > On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan > > wrote: > >> On Wed, Jan 20, 2021 at 3:53 PM Michael Walle > >

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Saravana Kannan
On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: > > On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravan

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-01-25 Thread Saravana Kannan
On Mon, Jan 25, 2021 at 9:05 AM wrote: > > Hi, Saravana, > > On 12/18/20 5:17 AM, Saravana Kannan wrote: > > Cyclic dependencies in some firmware was one of the last remaining > > reasons fw_devlink=on couldn't be set by default. Now that cyclic > > de

Re: [PATCH] driver core: Fix a reource leak in 'fw_devlink_create_devlink()'

2021-01-24 Thread Saravana Kannan
On Sat, Jan 23, 2021 at 10:32 PM Christophe JAILLET wrote: > > In 'fw_devlink_create_devlink()', all exit paths, successful or not, > release the reference taken on 'sup_dev'. > All but this one. > > Use the existing error handling case to call the missing 'put_device()'. > > Fixes: f9aa460672c9c

Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-23 Thread Saravana Kannan
On Sat, Jan 23, 2021 at 2:52 PM Linus Walleij wrote: > > On Fri, Jan 22, 2021 at 8:36 PM Saravana Kannan wrote: > > > There are multiple instances of GPIO device tree nodes of the form: > > > > foo { > > compatible = "acme,foo"; > >

[PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-22 Thread Saravana Kannan
an/ [2] - https://lore.kernel.org/lkml/e28e1f38d87c12a3c714a6573beba...@kernel.org/ Cc: Marc Zyngier Cc: Jisheng Zhang Cc: Kever Yang Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- v1 -> v2: - Fixed up compilation errors that we

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Saravana Kannan
On Fri, Jan 22, 2021 at 1:05 PM Andy Shevchenko wrote: > > On Fri, Jan 22, 2021 at 10:59 PM Saravana Kannan wrote: > > On Fri, Jan 22, 2021 at 8:34 AM Rafael J. Wysocki wrote: > > > On Wed, Jan 20, 2021 at 9:01 PM Saravana Kannan > > > wrote: > > > >

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Saravana Kannan
On Fri, Jan 22, 2021 at 8:34 AM Rafael J. Wysocki wrote: > > On Wed, Jan 20, 2021 at 9:01 PM Saravana Kannan wrote: > > > > On Wed, Jan 20, 2021 at 11:15 AM Rafael J. Wysocki > > wrote: > > > > > > On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko &g

Re: [PATCH v4] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-22 Thread Saravana Kannan
On Fri, Jan 22, 2021 at 5:08 AM Linus Walleij wrote: > > On Fri, Jan 22, 2021 at 10:55 AM Andy Shevchenko > wrote: Andy, I'll address your exit() comments too. > > On Fri, Jan 22, 2021 at 12:40 AM Saravana Kannan > > wrote: > > > > @@ -596,6 +596,7 @@

Re: [TEST PATCH v1] driver: core: Make fw_devlink=on more forgiving

2021-01-21 Thread Saravana Kannan
On Thu, Jan 21, 2021 at 2:38 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Thu, Jan 21, 2021 at 9:28 AM Saravana Kannan wrote: > > On Thu, Jan 21, 2021 at 12:22 AM Saravana Kannan > > wrote: > > > This patch is for test purposes only and pretty expe

[PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-01-21 Thread Saravana Kannan
This allows fw_devlink to create device links between consumers of an interrupt and the supplier of the interrupt. Cc: Marc Zyngier Cc: Kevin Hilman Cc: Greg Kroah-Hartman Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Reviewed-by: Linus Walleij Signed-off-by: Saravana Kannan

[PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding

2021-01-21 Thread Saravana Kannan
e. Cc: linux-tegra Cc: Linus Walleij Cc: Bartosz Golaszewski Cc: Greg Kroah-Hartman Cc: Geert Uytterhoeven Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Tested-by: Jon Hunter Signed-off-by: Saravana

[PATCH v2 0/2] of: property: Add fw_devlink support for more props

2021-01-21 Thread Saravana Kannan
comments. Added Reviewed-by tags. Saravana Kannan (2): of: property: Add fw_devlink support for "gpio" and "gpios" binding of: property: Add fw_devlink support for interrupts drivers/of/property.c | 34 ++ 1 file changed, 34 insertions(+) -- 2.30.0.296.g2bfb1c46d8-goog

[PATCH v4] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-21 Thread Saravana Kannan
an/ [2] - https://lore.kernel.org/lkml/e28e1f38d87c12a3c714a6573beba...@kernel.org/ Cc: Marc Zyngier Cc: Jisheng Zhang Cc: Kever Yang Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- v1 -> v2: - Fixed up compilation errors that we

Re: [PATCH v2] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-21 Thread Saravana Kannan
On Thu, Jan 21, 2021 at 5:01 AM Linus Walleij wrote: > > On Sat, Jan 16, 2021 at 2:14 AM Saravana Kannan wrote: > > > There are multiple instances of GPIO devictree nodes of the form: > > > > foo { > > compatible = "acme,foo"; > >

[PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-01-21 Thread Saravana Kannan
This allows fw_devlink to create device links between consumers of an interrupt and the supplier of the interrupt. Cc: Marc Zyngier Cc: Kevin Hilman Cc: Greg Kroah-Hartman Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Reviewed-by: Linus Walleij Signed-off-by: Saravana Kannan

[PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding

2021-01-21 Thread Saravana Kannan
e. Cc: linux-tegra Cc: Linus Walleij Cc: Bartosz Golaszewski Cc: Greg Kroah-Hartman Cc: Geert Uytterhoeven Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Tested-by: Jon Hunter Signed-off-by: Saravana

Re: [PATCH v1 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding

2021-01-21 Thread Saravana Kannan
On Thu, Jan 21, 2021 at 5:11 AM Linus Walleij wrote: > > On Wed, Jan 20, 2021 at 9:05 AM Saravana Kannan wrote: > > > To provide backward compatibility for boards that use deprecated DT > > bindings, we need to add fw_devlink support for "gpio" and "gpios

[TEST PATCH v1] driver: core: Make fw_devlink=on more forgiving

2021-01-21 Thread Saravana Kannan
rc Zyngier Signed-off-by: Saravana Kannan --- drivers/base/base.h | 3 ++ drivers/base/core.c | 117 +++- drivers/base/dd.c | 24 + 3 files changed, 142 insertions(+), 2 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index f

Re: [TEST PATCH v1] driver: core: Make fw_devlink=on more forgiving

2021-01-21 Thread Saravana Kannan
On Thu, Jan 21, 2021 at 12:22 AM Saravana Kannan wrote: > > This patch is for test purposes only and pretty experimental. Code might > not be optimized, clean, formatted properly, etc. > > Please review it only for functional bugs like locking bugs, wrong > logic, etc. > &g

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 3:53 PM Michael Walle wrote: > > Am 2021-01-20 20:47, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle > > wrote: > >> > >> [RESEND, fat-fingered the buttons of my mail client and converted > >> all

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Saravana Kannan
; > > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > > > > > On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson > > > > > wrote: > > > > ... > > > > > > > > + ret = fwnode_property_read_u

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 11:47 AM Saravana Kannan wrote: > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravana K

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > >> > &

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > > > fw_devlink will defer the probe until all suppliers are ready. We can't > > use builtin_platform_driver_probe() because it doesn't retry after probe > > deferral. Convert it to buil

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 6:27 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 20, 2021 at 10:40 AM Geert Uytterhoeven > wrote: > > On Tue, Jan 19, 2021 at 10:51 PM Saravana Kannan > > wrote: > > > On Tue, Jan 19, 2021 at 10:08 AM Saravana Kanna

Re: [PATCH] of: property: Add device link support for interrupts

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 6:28 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Jan 20, 2021 at 10:53 AM Geert Uytterhoeven > wrote: > > On Fri, Dec 18, 2020 at 10:11 PM Saravana Kannan > > wrote: > > > Add support for creating device links out of

Re: [PATCH/RFC] soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init

2021-01-20 Thread Saravana Kannan
know he hates people using OF_POPULATED, but I think this case is reasonable and want to make sure he's aware of this. Once you fix my commit nitpick, you can add: Reviewed-by: Saravana Kannan -Saravana > > Fixes: e590474768f1cc04 ("driver core: Set fw_devlink=on by default") &g

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-20 Thread Saravana Kannan
On Wed, Jan 20, 2021 at 6:26 AM Christoph Hellwig wrote: > > On Fri, Jan 08, 2021 at 12:30:35AM +, Will McVicker wrote: > > For example, we have a CI setup that tests new kernel changes on the > > hikey960 and db845c devices without updating their kernel modules. When > > these tests fail, we

[PATCH v1 2/2] of: property: Add fw_devlink support for interrupts

2021-01-20 Thread Saravana Kannan
This allows fw_devlink to create device links between consumers of an interrupt and the supplier of the interrupt. Cc: Marc Zyngier Cc: Kevin Hilman Cc: Greg Kroah-Hartman Signed-off-by: Saravana Kannan --- drivers/of/property.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH v1 0/2] of: property: Add fw_devlink support for more props

2021-01-20 Thread Saravana Kannan
18210750.3455872-1-sarava...@google.com/ Individual -> Series: Patch 1/2: Addressed Geert's gpio-hog problem with gpio[s] property Patch 2/2: Switched to using of_irq_find_parent() Saravana Kannan (2): of: property: Add fw_devlink support for "gpio" and "gpios" binding

<    1   2   3   4   5   6   7   8   9   10   >