For non VTL platforms vtl is always 0, and there is no need of
get_vtl function. For VTL platforms get_vtl should always succeed
and should return the correct VTL.
Signed-off-by: Saurabh Sengar
---
arch/x86/hyperv/hv_init.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
adding SDI to drm connector list
Signed-off-by: Saurabh Sengar <saura...@xilinx.com>
---
drivers/gpu/drm/drm_connector.c | 1 +
include/uapi/drm/drm_mode.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 2
adding SDI to drm connector list
Signed-off-by: Saurabh Sengar
---
drivers/gpu/drm/drm_connector.c | 1 +
include/uapi/drm/drm_mode.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 2db7fb5..ea48ddb 100644
.
Signed-off-by: Saurabh Sengar <saura...@xilinx.com>
---
drivers/gpu/drm/drm_edid.c | 48 ++
include/drm/drm_edid.h | 2 ++
2 files changed, 50 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ec77bd3..0
.
Signed-off-by: Saurabh Sengar
---
drivers/gpu/drm/drm_edid.c | 48 ++
include/drm/drm_edid.h | 2 ++
2 files changed, 50 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ec77bd3..08cfd9d 100644
--- a/drivers/gpu
Added iounmap inorder to free memory mapped to pointer before returning
Signed-off-by: Saurabh Sengar
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..35af362
Added iounmap inorder to free memory mapped to pointer before returning
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-qu
as cpm_muram_alloc_common is used only in this file,
making it static
Signed-off-by: Saurabh Sengar
---
drivers/soc/fsl/qe/qe_common.c | 66 +-
include/soc/fsl/qe/qe.h| 2 --
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git
as cpm_muram_alloc_common is used only in this file,
making it static
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/soc/fsl/qe/qe_common.c | 66 +-
include/soc/fsl/qe/qe.h| 2 --
2 files changed, 33 insertions(
cpm_muram_alloc_common is called twice and both the times
spin_lock_irqsave is held.
Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause
deadlock
Signed-off-by: Saurabh Sengar
---
Let me know if there is any other way to fix it.
Also, I would say this function should be static
cpm_muram_alloc_common is called twice and both the times
spin_lock_irqsave is held.
Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause
deadlock
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
Let me know if there is any other way to fix it.
Also, I wou
On 23 December 2015 at 09:05, Ashutosh Dixit wrote:
> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing
> spin_unlock").
>
> The above patch is incorrect. There is nothing wrong with the original
> code. The spin_lock is acquired in the "prep" functions and released
> in
On 23 December 2015 at 09:05, Ashutosh Dixit wrote:
> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing
> spin_unlock").
>
> The above patch is incorrect. There is nothing wrong with the original
> code. The spin_lock is acquired in the "prep" functions
added the rx delay parameter as a device tunable parameter.
Signed-off-by: Saurabh Sengar
---
This is a follow up patch after the review comments by Samuel Ortiz
on the initial patch.
Below is the link to original patch which implemented this parameter
as sysfs entry:
https://lkml.org/lkml/2015
added the rx delay parameter as a device tunable parameter.
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
This is a follow up patch after the review comments by Samuel Ortiz
on the initial patch.
Below is the link to original patch which implemented this parameter
as sysfs
added the sysfs entry for nfcsim workqueue delay, as tx_delay
Signed-off-by: Saurabh Sengar
---
In case this TODO is not expected to be done, please let me know.
I wonder after my repeated attempts since last 50 days, I am not able to get a
single response.
Resending this patch in hope to get
added the sysfs entry for nfcsim workqueue delay, as tx_delay
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
In case this TODO is not expected to be done, please let me know.
I wonder after my repeated attempts since last 50 days, I am not able to get a
single response.
Res
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..35af362 100644
On 12 December 2015 at 15:41, Sudip Mukherjee
wrote:
> On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
>> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
>> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
>> > >
On 12 December 2015 at 14:10, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
>> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
>> > This patch does the following:
>> > * changed the complicated if statement
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
On 12 December 2015 at 14:10, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
>> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
>> > This patch does the following:
>> > * chan
On 12 December 2015 at 15:41, Sudip Mukherjee
<sudipm.mukher...@gmail.com> wrote:
> On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
>> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
>> > On Mon, Dec 07, 2015 at 06:35:11PM +05
If there is 'no suitable DMA available' error, device should be disabled
before returning
Signed-off-by: Saurabh Sengar
---
drivers/net/wan/wanxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index e73f138..a20d688 100644
--- a/drivers
If there is 'no suitable DMA available' error, device should be disabled
before returning
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/net/wan/wanxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index e
ping again !!
On 1 December 2015 at 21:10, Saurabh Sengar wrote:
> pinging for feedback.
> Please respond.
>
> On 20 November 2015 at 16:07, Saurabh Sengar wrote:
>> I have also tested this module its successfully creating the tx_delay
>> entry in nfc
>>
>>
ternary operator, as it was always returning the status value
only,
and hence removed the status variable too
Signed-off-by: Saurabh Sengar
---
drivers/staging/speakup/varhandlers.c | 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers
Inorder to notify the user that value is not successfuly set in sys
entry, error should be returned from store function instead of count
Signed-off-by: Saurabh Sengar
---
v2:
Hi Dan,
I will look more into this function in my free time.
For now just sending you this patch fixing ERANGE
Inorder to notify the user that value is not successfuly set in sys
entry, error should be returned from store function instead of count
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v2:
Hi Dan,
I will look more into this function in my free time.
For now just sending you this
ternary operator, as it was always returning the status value
only,
and hence removed the status variable too
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 50 +--
1 file changed, 25 insertions(+), 25 del
ping again !!
On 1 December 2015 at 21:10, Saurabh Sengar <saurabh.tr...@gmail.com> wrote:
> pinging for feedback.
> Please respond.
>
> On 20 November 2015 at 16:07, Saurabh Sengar <saurabh.tr...@gmail.com> wrote:
>> I have also tested this module its successfully
On 7 December 2015 at 12:18, Dan Carpenter wrote:
> On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote:
>> Inorder to notify the user that value is not successfuly set in sys
>> entry, error should be returned from store function instead of count
>>
>> Si
In case of error too function should return after releasing the mutex
Signed-off-by: Saurabh Sengar
---
drivers/gpu/host1x/mipi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index 52a6fd2..6e559a9 100644
--- a/drivers/gpu/host1x
in case of failed to get iova, function was returning without releasing
the mutex. Added it.
Signed-off-by: Saurabh Sengar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi
In case of error too function should return after releasing the mutex
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/gpu/host1x/mipi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index 52a6fd2..6e559a9
in case of failed to get iova, function was returning without releasing
the mutex. Added it.
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_hos
On 7 December 2015 at 12:18, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote:
>> Inorder to notify the user that value is not successfuly set in sys
>> entry, error should be returned from store function instead
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar
---
v3: reverted to v1 logic, on top of usb-next branch
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers
On 4 December 2015 at 21:53, Greg KH wrote:
> On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar
>> ---
>> v2: changed logic a bit, becaus
Inorder to notify the user that value is not successfuly set in sys
entry, error should be returned from store function instead of count
Signed-off-by: Saurabh Sengar
---
drivers/staging/speakup/kobjects.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
Inorder to notify the user that value is not successfuly set in sys
entry, error should be returned from store function instead of count
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/staging/speakup/kobjects.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v3: reverted to v1 logic, on top of usb-next branch
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drive
On 4 December 2015 at 21:53, Greg KH <gre...@linuxfoundation.org> wrote:
> On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar <saurabh.tr...@gm
I couldn't see this patch applied in linux-next branch still.
Regards,
Saurabh
On 24 November 2015 at 21:59, Lee Jones wrote:
> On Mon, 16 Nov 2015, Saurabh Sengar wrote:
>
>> for checking if a property is present or not,
>> use of_property_read_bool instead of of_get_prope
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar
---
v2: changed logic a bit, because of recent patches pushed to usb-next
drivers/usb/host/pci-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci
Hi Greg,
I am little unclear.
Now, shall I resend my patch on top of usb.git tree or linux.git tree.
Regards,
Saurabh
On 2 December 2015 at 21:15, Greg KH wrote:
> On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote:
>> On 2 December 2015 at 04:05, Greg KH wrote:
>>
Hi Greg,
I am little unclear.
Now, shall I resend my patch on top of usb.git tree or linux.git tree.
Regards,
Saurabh
On 2 December 2015 at 21:15, Greg KH <gre...@linuxfoundation.org> wrote:
> On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote:
>> On 2 December 2015
added iounmap inorder to free memory mapped to base before returning
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v2: changed logic a bit, because of recent patches pushed to usb-next
drivers/usb/host/pci-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
I couldn't see this patch applied in linux-next branch still.
Regards,
Saurabh
On 24 November 2015 at 21:59, Lee Jones <lee.jo...@linaro.org> wrote:
> On Mon, 16 Nov 2015, Saurabh Sengar wrote:
>
>> for checking if a property is present or not,
>> use of_pr
On 2 December 2015 at 04:05, Greg KH wrote:
> On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar
>> ---
>> drivers/usb/host/pci-quirks
pinging for feedback.
Please respond.
On 20 November 2015 at 16:07, Saurabh Sengar wrote:
> I have also tested this module its successfully creating the tx_delay
> entry in nfc
>
> root@saurabh:/home/saurabh# ls /sys/class/nfc/nfc0/tx_delay
> /sys/class/nfc/nfc0/tx_delay
>
&
On 2 December 2015 at 04:05, Greg KH <gre...@linuxfoundation.org> wrote:
> On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar <saurabh.tr...@gma
pinging for feedback.
Please respond.
On 20 November 2015 at 16:07, Saurabh Sengar <saurabh.tr...@gmail.com> wrote:
> I have also tested this module its successfully creating the tx_delay
> entry in nfc
>
> root@saurabh:/home/saurabh# ls /sys/class/nfc/nfc0/tx_delay
> /sys/cl
spin lock should be released while returning from function
Signed-off-by: Saurabh Sengar
---
v2: fixed comment from Vinod Koul
drivers/dma/mic_x100_dma.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
spin lock should be released while returning from function
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v2: fixed comment from Vinod Koul
drivers/dma/mic_x100_dma.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/mic_x100_d
pinging in case this patch is lost.
On 6 November 2015 at 17:46, Saurabh Sengar wrote:
> added iounmap inorder to free memory mapped to base before returning
>
> Signed-off-by: Saurabh Sengar
> ---
> drivers/usb/host/pci-quirks.c | 4 ++--
> 1 file changed, 2 insertio
pinging in case this patch is lost.
On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.tr...@gmail.com> wrote:
> added iounmap inorder to free memory mapped to base before returning
>
> Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
> ---
> drivers/usb/host
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled
Signed-off-by: Saurabh Sengar
---
drivers/mmc/host/of_mmc_spi.c | 4 ++--
1 file
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled
Signed-off-by: Saurabh Sengar
---
drivers/rtc/rtc-tps65910.c | 3 ++-
1 file changed
Add IRQF_ONESHOT if no primary handler is provided for request threaded
irq
Signed-off-by: Saurabh Sengar
---
drivers/extcon/extcon-rt8973a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c
index 36bf1d6
Add IRQF_ONESHOT if no primary handler is provided for request threaded
irq
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/extcon/extcon-rt8973a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/mm
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/rtc/rtc-tps6
any conclusion for this patch ?
any feedback ?
On Oct 28, 2015 2:46 PM, "Peter Chen" wrote:
>
> On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote:
> > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc
> >
> > Signed-off-by: Sa
any conclusion for this patch ?
any feedback ?
On Oct 28, 2015 2:46 PM, "Peter Chen" <peter.c...@freescale.com> wrote:
>
> On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote:
> > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc
&g
better way of using of_property_read_u32(), helps remove one variable
and many 'if' conditions
Signed-off-by: Saurabh Sengar
---
drivers/input/touchscreen/stmpe-ts.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers/input/touchscreen
use of_property_read_u8() for u8 values
Signed-off-by: Saurabh Sengar
---
v2 : added the missed semi colon
drivers/mtd/nand/orion_nand.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
use of_property_read_u8() for u8 values
Signed-off-by: Saurabh Sengar
---
drivers/mtd/nand/orion_nand.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index ee83749..1a68145 100644
use of_property_read_u8() for u8 variables,
also changed the return type to void as this function return type
is nowhere used.
Signed-off-by: Saurabh Sengar
---
drivers/thermal/samsung/exynos_tmu.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff
in case of error no need to set num_tx and num_rx = 1, because in case of error
these variables will remain unchanged by of_property_read_u32 ie 1 only
Signed-off-by: Saurabh Sengar
---
drivers/net/ethernet/freescale/fec_main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions
this patch does the following:
1 . remove unnecessary if, else condition
2 . reduce one variable
3 . change the return type of 2 functions to void as there return values
turn out to be 0 always after above changes
Signed-off-by: Saurabh Sengar
---
drivers/net/ethernet/apm/xgene
use of_property_read_u32(), it will save few steps and variables
Signed-off-by: Saurabh Sengar
---
drivers/memory/emif.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 04644e7..52a9ad1 100644
--- a/drivers
use of_propert_read_u32() for reading int value,
it can help reducing number of variables used
Signed-off-by: Saurabh Sengar
---
drivers/crypto/nx/nx-842-powernv.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/nx/nx-842-powernv.c
b/drivers
no need to explicitly check for pointer to be null,
of_prop_next_string anyways return NULL, if passed pointer is NULL
and hence loop will continue
Signed-off-by: Saurabh Sengar
---
drivers/leds/leds-powernv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/leds-powernv.c b
use of_property_read_u32(), it will save few steps and variables
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/memory/emif.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 0
no need to explicitly check for pointer to be null,
of_prop_next_string anyways return NULL, if passed pointer is NULL
and hence loop will continue
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/leds/leds-powernv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
use of_propert_read_u32() for reading int value,
it can help reducing number of variables used
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/crypto/nx/nx-842-powernv.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/nx/
this patch does the following:
1 . remove unnecessary if, else condition
2 . reduce one variable
3 . change the return type of 2 functions to void as there return values
turn out to be 0 always after above changes
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drive
in case of error no need to set num_tx and num_rx = 1, because in case of error
these variables will remain unchanged by of_property_read_u32 ie 1 only
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/net/ethernet/freescale/fec_main.c | 9 ++---
1 file chan
use of_property_read_u8() for u8 variables,
also changed the return type to void as this function return type
is nowhere used.
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/thermal/samsung/exynos_tmu.c | 30 +-
1 file changed, 13 inse
use of_property_read_u8() for u8 values
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/mtd/nand/orion_nand.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
better way of using of_property_read_u32(), helps remove one variable
and many 'if' conditions
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/input/touchscreen/stmpe-ts.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff
use of_property_read_u8() for u8 values
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v2 : added the missed semi colon
drivers/mtd/nand/orion_nand.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/d
removing null dereference
Signed-off-by: Saurabh Sengar
---
is there any better way to fix it ?
as if there is no 'x' there is no way we can access 'x->lock'
drivers/infiniband/hw/mlx5/qp.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/driv
removing null dereference
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
is there any better way to fix it ?
as if there is no 'x' there is no way we can access 'x->lock'
drivers/infiniband/hw/mlx5/qp.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/infi
On 21 November 2015 at 18:52, Mark Brown wrote:
> On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote:
>
>> I also have concern related to how we are passing 'regulator-mode' and
>> 'regulator-initial-mode'. Currently this require a extra function to be
>> set
On 21 November 2015 at 18:52, Mark Brown <broo...@kernel.org> wrote:
> On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote:
>
>> I also have concern related to how we are passing 'regulator-mode' and
>> 'regulator-initial-mode'. Currently this require a ext
use of_property_read_bool() for testing bool property
Signed-off-by: Saurabh Sengar
---
drivers/net/ethernet/freescale/gianfar.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c
b/drivers/net/ethernet/freescale/gianfar.c
index
correctly
root@saurabh:/home/saurabh# echo 15 > /sys/class/nfc/nfc0/tx_delay
root@saurabh:/home/saurabh# cat /sys/class/nfc/nfc0/tx_delay
15
and on removing the module its cleaning up without any oops
Tested-by: Saurabh Sengar
On 13 November 2015 at 16:48, Saurabh Sengar wrote:
> added the sysfs
correctly
root@saurabh:/home/saurabh# echo 15 > /sys/class/nfc/nfc0/tx_delay
root@saurabh:/home/saurabh# cat /sys/class/nfc/nfc0/tx_delay
15
and on removing the module its cleaning up without any oops
Tested-by: Saurabh Sengar <saurabh.tr...@gmail.com>
On 13 November 2015 at 16:48, Saura
use of_property_read_bool() for testing bool property
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers/net/ethernet/freescale/gianfar.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c
b/drivers/net/et
in case of_property_read_u32 fails, it keeps the parameter unchanged
so no need to test if its success and then assign the value
Signed-off-by: Saurabh Sengar
---
Hi Mark,
I also have concern related to how we are passing 'regulator-mode' and
'regulator-initial-mode'. Currently this require
in case of_property_read_u32 fails, it keeps the parameter unchanged
so no need to test if its success and then assign the value
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
Hi Mark,
I also have concern related to how we are passing 'regulator-mode' and
'regulator-initia
replacing kmalloc and memset by a single call of kzalloc
Signed-off-by: Saurabh Sengar
---
v2 : I didn't got any response for my initial patch,
I am sending it again on top of latest kernel(today's)
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
On 28 October 2015 at 11:56, Saurabh Sengar wrote:
> use memdup_user rather than duplicating implementation.
> found by coccinelle
>
> Signed-off-by: Saurabh Sengar
> ---
> drivers/tty/vt/keyboard.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled.
Signed-off-by: Saurabh Sengar
---
drivers/power/max8903_charger.c | 24
replacing kmalloc and memset by a single call of kzalloc
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
v2 : I didn't got any response for my initial patch,
I am sending it again on top of latest kernel(today's)
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 ins
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled.
Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
---
drivers
On 28 October 2015 at 11:56, Saurabh Sengar <saurabh.tr...@gmail.com> wrote:
> use memdup_user rather than duplicating implementation.
> found by coccinelle
>
> Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com>
> ---
> drivers/tty/vt/keyboard.c | 14 +
On 18 November 2015 at 12:54, Peter Chen wrote:
> I am clear now, I will queue it.
Thank you
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
1 - 100 of 207 matches
Mail list logo