[PATCH] x86/hyperv: Restrict get_vtl to only VTL platforms

For non VTL platforms vtl is always 0, and there is no need of get_vtl function. For VTL platforms get_vtl should always succeed and should return the correct VTL. Signed-off-by: Saurabh Sengar --- arch/x86/hyperv/hv_init.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH] drm: adding SDI to drm_connector_enum_list

adding SDI to drm connector list Signed-off-by: Saurabh Sengar --- drivers/gpu/drm/drm_connector.c | 1 + include/uapi/drm/drm_mode.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 2db7fb5..ea48ddb 100644 --- a

drm/edid: api to register cea modes if no edid supported

. Signed-off-by: Saurabh Sengar --- drivers/gpu/drm/drm_edid.c | 48 ++ include/drm/drm_edid.h | 2 ++ 2 files changed, 50 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ec77bd3..08cfd9d 100644 --- a/drivers/gpu

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

Added iounmap inorder to free memory mapped to pointer before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 26cb8c8..35af362

[PATCH] QE: making cpm_muram_alloc_common into static

as cpm_muram_alloc_common is used only in this file, making it static Signed-off-by: Saurabh Sengar --- drivers/soc/fsl/qe/qe_common.c | 66 +- include/soc/fsl/qe/qe.h| 2 -- 2 files changed, 33 insertions(+), 35 deletions(-) diff --git a

[PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held

cpm_muram_alloc_common is called twice and both the times spin_lock_irqsave is held. Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause deadlock Signed-off-by: Saurabh Sengar --- Let me know if there is any other way to fix it. Also, I would say this function should be static as

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

On 23 December 2015 at 09:05, Ashutosh Dixit wrote: > This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing > spin_unlock"). > > The above patch is incorrect. There is nothing wrong with the original > code. The spin_lock is acquired in the "prep" functions and released > in "submit"

[PATCH] NFC: added the rx delay parameter for nfcsim workqueue

added the rx delay parameter as a device tunable parameter. Signed-off-by: Saurabh Sengar --- This is a follow up patch after the review comments by Samuel Ortiz on the initial patch. Below is the link to original patch which implemented this parameter as sysfs entry: https://lkml.org/lkml/2015

[RESEND PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

added the sysfs entry for nfcsim workqueue delay, as tx_delay Signed-off-by: Saurabh Sengar --- In case this TODO is not expected to be done, please let me know. I wonder after my repeated attempts since last 50 days, I am not able to get a single response. Resending this patch in hope to get

[RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 26cb8c8..35af362 100644

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

On 12 December 2015 at 15:41, Sudip Mukherjee wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > >

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

On 12 December 2015 at 14:10, Dan Carpenter wrote: > On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > This patch does the following: >> > * changed the complicated if statement

[PATCH] wan: wanxl: add pci_disable_device in case of error

If there is 'no suitable DMA available' error, device should be disabled before returning Signed-off-by: Saurabh Sengar --- drivers/net/wan/wanxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index e73f138..a20d688 100644 ---

Re: [PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

ping again !! On 1 December 2015 at 21:10, Saurabh Sengar wrote: > pinging for feedback. > Please respond. > > On 20 November 2015 at 16:07, Saurabh Sengar wrote: >> I have also tested this module its successfully creating the tx_delay >> entry in nfc >> >>

[PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

ternary operator, as it was always returning the status value only, and hence removed the status variable too Signed-off-by: Saurabh Sengar --- drivers/staging/speakup/varhandlers.c | 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH v2] Staging: speakup: kobjects: Return the error type to caller

Inorder to notify the user that value is not successfuly set in sys entry, error should be returned from store function instead of count Signed-off-by: Saurabh Sengar --- v2: Hi Dan, I will look more into this function in my free time. For now just sending you this patch fixing ERANGE as

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

On 7 December 2015 at 12:18, Dan Carpenter wrote: > On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: >> Inorder to notify the user that value is not successfuly set in sys >> entry, error should be returned from store function instead of count >> >> Si

[PATCH] gpu: host1x: mipi: Added missing mutex_unlock

In case of error too function should return after releasing the mutex Signed-off-by: Saurabh Sengar --- drivers/gpu/host1x/mipi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 52a6fd2..6e559a9 100644 --- a/drivers/gpu/host1x

[PATCH] drm: msm: dsi: Added missing mutex_unlock

in case of failed to get iova, function was returning without releasing the mutex. Added it. Signed-off-by: Saurabh Sengar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi

[PATCH v3] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- v3: reverted to v1 logic, on top of usb-next branch drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers

Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

On 4 December 2015 at 21:53, Greg KH wrote: > On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> v2: changed logic a bit, becaus

[PATCH] Staging: speakup: kobjects: Return the error type to caller

Inorder to notify the user that value is not successfuly set in sys entry, error should be returned from store function instead of count Signed-off-by: Saurabh Sengar --- drivers/staging/speakup/kobjects.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH] mfd: mc13xxx-core: use of_property_read_bool()

I couldn't see this patch applied in linux-next branch still. Regards, Saurabh On 24 November 2015 at 21:59, Lee Jones wrote: > On Mon, 16 Nov 2015, Saurabh Sengar wrote: > >> for checking if a property is present or not, >> use of_property_read_bool instead of of_get_

[PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- v2: changed logic a bit, because of recent patches pushed to usb-next drivers/usb/host/pci-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/pci

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

Hi Greg, I am little unclear. Now, shall I resend my patch on top of usb.git tree or linux.git tree. Regards, Saurabh On 2 December 2015 at 21:15, Greg KH wrote: > On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote: >> On 2 December 2015 at 04:05, Greg KH wrote: >>

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

On 2 December 2015 at 04:05, Greg KH wrote: > On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar >> --- >> drivers/usb/host/pci-quirks

Re: [PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

pinging for feedback. Please respond. On 20 November 2015 at 16:07, Saurabh Sengar wrote: > I have also tested this module its successfully creating the tx_delay > entry in nfc > > root@saurabh:/home/saurabh# ls /sys/class/nfc/nfc0/tx_delay > /sys/class/nfc/nfc0/tx_delay > >

[PATCH v2] dma: mic_x100: add missing spin_unlock

spin lock should be released while returning from function Signed-off-by: Saurabh Sengar --- v2: fixed comment from Vinod Koul drivers/dma/mic_x100_dma.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

pinging in case this patch is lost. On 6 November 2015 at 17:46, Saurabh Sengar wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar > --- > drivers/usb/host/pci-quirks.c | 4 ++-- > 1 file changed, 2 insertio

[PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags

If no primary handler is specified for threaded_irq then a default one is assigned which always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT, because the source of interrupt is not disabled Signed-off-by: Saurabh Sengar --- drivers/mmc/host/of_mmc_spi.c | 4 ++-- 1 file

[PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags

If no primary handler is specified for threaded_irq then a default one is assigned which always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT, because the source of interrupt is not disabled Signed-off-by: Saurabh Sengar --- drivers/rtc/rtc-tps65910.c | 3 ++- 1 file changed

[PATCH] extcon: rt8973: Add IRQF_ONESHOT to interrupt flags

Add IRQF_ONESHOT if no primary handler is provided for request threaded irq Signed-off-by: Saurabh Sengar --- drivers/extcon/extcon-rt8973a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c index 36bf1d6

Re: [PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

any conclusion for this patch ? any feedback ? On Oct 28, 2015 2:46 PM, "Peter Chen" wrote: > > On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote: > > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc > > > > Signed-off-by: Sa

[PATCH] Input: smtpe-ts: better way of using of_property_read_u32()

better way of using of_property_read_u32(), helps remove one variable and many 'if' conditions Signed-off-by: Saurabh Sengar --- drivers/input/touchscreen/stmpe-ts.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/input/t

[PATCH v2] mtd: nand: use of_property_read_u8()

use of_property_read_u8() for u8 values Signed-off-by: Saurabh Sengar --- v2 : added the missed semi colon drivers/mtd/nand/orion_nand.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c

[PATCH] mtd: nand: use of_property_read_u8()

use of_property_read_u8() for u8 values Signed-off-by: Saurabh Sengar --- drivers/mtd/nand/orion_nand.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c index ee83749..1a68145 100644 --- a

[PATCH] thermal: exynos: use of_property_read_u8()

use of_property_read_u8() for u8 variables, also changed the return type to void as this function return type is nowhere used. Signed-off-by: Saurabh Sengar --- drivers/thermal/samsung/exynos_tmu.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff

[PATCH] net: fec: no need to test for the return type of of_property_read_u32

in case of error no need to set num_tx and num_rx = 1, because in case of error these variables will remain unchanged by of_property_read_u32 ie 1 only Signed-off-by: Saurabh Sengar --- drivers/net/ethernet/freescale/fec_main.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions

[PATCH] drivers: net: xgene: optimizing the code

this patch does the following: 1 . remove unnecessary if, else condition 2 . reduce one variable 3 . change the return type of 2 functions to void as there return values turn out to be 0 always after above changes Signed-off-by: Saurabh Sengar --- drivers/net/ethernet/apm/xgene

[PATCH] memory: emif: use of_property_read_u32()

use of_property_read_u32(), it will save few steps and variables Signed-off-by: Saurabh Sengar --- drivers/memory/emif.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 04644e7..52a9ad1 100644 --- a/drivers

[PATCH] crypto: nx: use of_property_read_u32()

use of_propert_read_u32() for reading int value, it can help reducing number of variables used Signed-off-by: Saurabh Sengar --- drivers/crypto/nx/nx-842-powernv.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers

[PATCH] leds/powernv : removing NULL check

no need to explicitly check for pointer to be null, of_prop_next_string anyways return NULL, if passed pointer is NULL and hence loop will continue Signed-off-by: Saurabh Sengar --- drivers/leds/leds-powernv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/leds/leds-powernv.c b

[PATCH] IB/mlx5: fix null dereference

removing null dereference Signed-off-by: Saurabh Sengar --- is there any better way to fix it ? as if there is no 'x' there is no way we can access 'x->lock' drivers/infiniband/hw/mlx5/qp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/infiniband

Re: [PATCH] regulator: of: simplifing the parsing code

On 21 November 2015 at 18:52, Mark Brown wrote: > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > >> I also have concern related to how we are passing 'regulator-mode' and >> 'regulator-initial-mode'. Currently this require a extra functio

[PATCH] gianfar: use of_property_read_bool()

use of_property_read_bool() for testing bool property Signed-off-by: Saurabh Sengar --- drivers/net/ethernet/freescale/gianfar.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index

Re: [PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

correctly root@saurabh:/home/saurabh# echo 15 > /sys/class/nfc/nfc0/tx_delay root@saurabh:/home/saurabh# cat /sys/class/nfc/nfc0/tx_delay 15 and on removing the module its cleaning up without any oops Tested-by: Saurabh Sengar On 13 November 2015 at 16:48, Saurabh Sengar wrote: > added the sysfs

[PATCH] regulator: of: simplifing the parsing code

in case of_property_read_u32 fails, it keeps the parameter unchanged so no need to test if its success and then assign the value Signed-off-by: Saurabh Sengar --- Hi Mark, I also have concern related to how we are passing 'regulator-mode' and 'regulator-initial-mode'. Curr

[PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

replacing kmalloc and memset by a single call of kzalloc Signed-off-by: Saurabh Sengar --- v2 : I didn't got any response for my initial patch, I am sending it again on top of latest kernel(today's) drivers/scsi/lpfc/lpfc_els.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

Re: [PATCH] tty/vt/keyboard: use memdup_user to simplify code

On 28 October 2015 at 11:56, Saurabh Sengar wrote: > use memdup_user rather than duplicating implementation. > found by coccinelle > > Signed-off-by: Saurabh Sengar > --- > drivers/tty/vt/keyboard.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) >

[PATCH] drivers: power: set IRQF_ONESHOT if no primary handler is specified

If no primary handler is specified for threaded_irq then a default one is assigned which always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT, because the source of interrupt is not disabled. Signed-off-by: Saurabh Sengar --- drivers/power/max8903_charger.c | 24

Re: [PATCH v4] usb: chipidea: removing of_find_property

On 18 November 2015 at 12:54, Peter Chen wrote: > I am clear now, I will queue it. Thank you -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH v4] usb: chipidea: removing of_find_property

On 18 November 2015 at 11:35, Peter Chen wrote: > On Wed, Nov 18, 2015 at 09:40:12AM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >> of_property_read_u32() anyway calls to of_find_property() only. >> >> Si

[PATCH v4] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v4 : removed return type check for optional property 'itc-setting' drivers/usb/chipidea/c

Re: [PATCH v3] usb: chipidea: removing of_find_property

ot OK, I will send a another patch(v4) as you have suggested. Regards, Saurabh On 18 November 2015 at 09:08, Peter Chen wrote: > On Tue, Nov 17, 2015 at 05:22:26PM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >> of_

Re: [PATCH v2] usb: chipidea: removing of_find_property

ith the blank line on line 692, looks strange. > > julia > > On Tue, 17 Nov 2015, kbuild test robot wrote: > >> CC: kbuild-...@01.org >> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com> >> TO: Saurabh Sengar >> C

[PATCH v3] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2 : removed pval variable v3 : removed unnecessary if condition drivers/usb/chipidea/core.c | 59

[PATCH v2] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2: removed pval variable drivers/usb/chipidea/core.c | 61 +++-- 1 file changed, 26

[PATCH] usb: chipidea: removing of_find_property

call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- drivers/usb/chipidea/core.c | 67 ++--- 1 file changed, 32 insertions(+), 35

[PATCH v2] usb: host: ohci-pxa27x: use of_property_read_bool()

for checking if a property is present or not, of_property_read_bool is more appropriate than of_get_property() Signed-off-by: Saurabh Sengar --- v2 : replaced then to than in description drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH] mfd: mc13xxx-core: use of_property_read_bool()

for checking if a property is present or not, use of_property_read_bool instead of of_get_property() Signed-off-by: Saurabh Sengar --- drivers/mfd/mc13xxx-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c

[PATCH] usb: host: ohci-pxa27x: use of_property_read_bool()

for checking if a property is present or not, of_property_read_bool is more appropriate then of_get_property() Signed-off-by: Saurabh Sengar --- drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/ohci-pxa27x.c b

[PATCH] mfd: ssbi: removing unnecessary strcmp

passing the actual enum value for controller type from device tree, instead of passing the string and converting it to enum Signed-off-by: Saurabh Sengar --- Documentation/devicetree/bindings/arm/msm/ssbi.txt | 6 +++--- arch/arm/boot/dts/qcom-apq8064.dtsi| 3 ++- arch/arm

Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC

On Fri, 13 Nov 2015 at 10:47:52 +, Wan, Kaike wrote: > I don't think so. > The following patch has rendered this patch unnecessary: > https://patchwork.kernel.org/patch/7526811/ > Kaike OK, could you please use "Reported-by" tag of my name in your patch Regards, Saurabh -- To unsubscribe fro

[PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

added the sysfs entry for nfcsim workqueue delay, as tx_delay Signed-off-by: Saurabh Sengar --- implementing the TODO task drivers/nfc/nfcsim.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc

Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC

On Wed, 28 Oct 2015 at 04:30:10 +, Weiny, Ira wrote: > Until we can remove the spinlock the current proposed patch should be applied > in the interim. Sorry for the noise before. > Reviewed-By: Ira Weiny Hi, is this patch expected to be applied ? -- To unsubscribe from this list: send th

[PATCH] mtd: phram: error handling

> More importantly, it's good to test these cases too: > * phram is built-in (not a module), with and without a phram= line on > the commandline > * writing to /sys/module/phram/parameters/phram (for both the module > and built-in cases) Hi Brian, 1) I have tried phram as built-in, with and

[PATCH] mtd: phram: error handling

Brian Norris wrote: > Well, today you're in luck! You're touching a driver that requires no > special hardware, so you should be able to test it. > I think you can try using the mem= kernel parameter (see > Documentation/kernel-parameters.txt) to restrict your system memory, and > then try using

[PATCH] mtd: phram: error handling

Expand parse_err macro with hidden flow in-place. Remove the now unused parse_err macro. Miscellanea: o Use invalid not illegal for error messages Noticed-by: Brian Norris Signed-off-by: Joe Perches Signed-off-by: Saurabh Sengar --- >> I think -EINVAL makes more sense than 1. That &g

[PATCH] dma: mic_x100: add missing spin_unlock

spin lock should be released while returning from function Signed-off-by: Saurabh Sengar --- drivers/dma/mic_x100_dma.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c index 068e920..7f6d477 100644

[PATCH] drm/nouveau/abi16: add missing mutex_unlock()

adding missing mutex_unlock() Signed-off-by: Saurabh Sengar --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index d336c22..280bd8e 100644

[PATCH v2] mtd: phram: error handling

registering the device with NULL pointer can lead to crash, hence fixing it Signed-off-by: Saurabh Sengar --- > Andy Shevchenko wrote: > Hmm… Why not just checking it before an register attempt? I think user > is in right to know as many problems as they have at one shot, with > y

[PATCH] mtd: phram: error handling

registering the device with NULL pointer can lead to crash, hence fixing it. Signed-off-by: Saurabh Sengar --- in case of 'illegal start address' or 'illegal device length', name pointer is getting freed. we shouldn't register the device with NULL pointer. driver

[PATCH] [media] hackrf: moving pointer reference before kfree

accessing a pointer after free could possible lead to segmentation fault, hence correcting it Signed-off-by: Saurabh Sengar --- drivers/media/usb/hackrf/hackrf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index f940056..332f687

Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC

>It's slightly winding code, but if you look at the callers of >efivar_init() you'll see that none of them set both 'atomic' and >'duplicates', so dup_variable_bug() will never be called while holding >a spinlock. >Or am I missing something? I was assuming that there could be a possibility when b

[PATCH v2] regulator: of: removing two variables min_uV and max_uV

replacing the of_get_property function with of_property_read_u32 function as its help removing two variables. Signed-off-by: Saurabh Sengar --- Hi Mark, >> /* Only one voltage? Then make sure it's set. */ >> - if (min_uV && max_uV && constrain

[PATCH] IB/ipoib: optimized the function ipoib_mcast_alloc

ipoib_mcast_alloc is called only in atomic context, hence removing the extra check. Signed-off-by: Saurabh Sengar --- Hi, Even if in future, if there are some functions expected to call it in normal context(not atomic), we can pass the GFP_KERNEL or GFP_ATOMIC directly to function call instead

[PATCH] regulator: of: removing two variables min_uV and max_uV

replacing the of_get_property function with of_property_read_u32 function as its help removing two variables. also the check for min_uV and max_uV is not required, even if they are zero and equal we should set apply_uV as true Signed-off-by: Saurabh Sengar --- drivers/regulator/of_regulator.c

[PATCH v2] net: rds: changing the return type from int to void

as result of function rds_iw_flush_mr_pool is nowhere checked, changing its return type from int to void. also removing the unused variable rc as there is nothing to return Signed-off-by: Saurabh Sengar --- v2 : modify patch description, as per the comments from Sergei Shtylyov net/rds

[PATCH] NFC: added the sysfs entry for nfcsim workqueue delay

added the sysfs entry for nfcsim workqueue delay, as tx_delay Signed-off-by: Saurabh Sengar --- Hi, As I have understood form TODO comment, I have implemented the sysfs entry for this device. Sorry, in case this patch is not meeting the expectation. I am just finding my way to contribute in

[PATCH] KVM: x86: removing unused variable

removing unused variables, found by coccinelle Signed-off-by: Saurabh Sengar --- arch/x86/kvm/x86.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 9a9a198..ec15294 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86

[PATCH] net: rds: chnaging the return type from int to void

as return type of function rds_iw_flush_mr_pool no where checked, chnaging its return type from int to void. also removing the unused variable rc as there is nothing to return. Signed-off-by: Saurabh Sengar --- net/rds/iw_rdma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH v4] um: net: replace GFP_KERNEL with GFP_ATOMIC when spinlock is held

since GFP_KERNEL with GFP_ATOMIC while spinlock is held, as code while holding a spinlock should be atomic. GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlockdex f70dd54..d898f6c 100644 Signed-off-by: Saurabh Sengar --- v4: fixing comments

[PATCH v3] um: net: replace GFP_KERNEL with GFP_ATOMIC when spinlock is held

replace GFP_KERNEL with GFP_ATOMIC while spinlock is held, as code while holding a spinlock should be atomic. GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- v3: removed the atomic variable, as per Richard

[PATCH v2] um: net: replace GFP_KERNEL with GFP_ATOMIC when spinlock is held

replace GFP_KERNEL with GFP_ATOMIC while spinlock is held, as code while holding a spinlock should be atomic. GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- v2: correcting the subject arch/um/drivers

[PATCH] git: um: replace GFP_KERNEL with GFP_ATOMIC while spinlock is held

replace GFP_KERNEL with GFP_ATOMIC while spinlock is held, as code while holding a spinlock should be atomic. GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- arch/um/drivers/net_kern.c | 31

[PATCH v3] audit: removing unused variable

variable rc is unnecessary hence removing it, also as the return type of function audit_log_common_recv_msg is no where used changing it to void. Signed-off-by: Saurabh Sengar --- kernel/audit.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/audit.c b/kernel

[PATCH v2] audit: removing unused variable

variable rc is unnecessary hence removing it, also as the return type of function audit_log_common_recv_msg is no where used changing it to void. Signed-off-by: Saurabh Sengar --- kernel/audit.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/audit.c b/kernel

Re: [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO_MEM

Thank you Peter, for your explanation. Regards, Saurabh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkm

[PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

replace dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Saurabh Sengar --- drivers/usb/chipidea/udc.c | 3 +-- drivers/usb/gadget/udc/gr_udc.c | 3 +-- drivers/usb/host/uhci-q.c | 3 +-- drivers/usb/host/whci/qset.c| 3 +-- drivers/usb/host/xhci

[PATCH] lpfc: replaced kmalloc + memset with kzalloc

replacing kmalloc and memset by a single call of kzalloc Signed-off-by: Saurabh Sengar --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 36bf58b..9729ab1 100644 --- a/drivers

[PATCH] tty/vt/keyboard: use memdup_user to simplify code

use memdup_user rather than duplicating implementation. found by coccinelle Signed-off-by: Saurabh Sengar --- drivers/tty/vt/keyboard.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c index 6f0336f..f973bfc

[PATCH] drivers: power: always set IRQF_ONESHOT if no primary handler is specified

If no primary handler is specified then a default one is assigned which always returns IRQ_WAKE_THREAD. This handler requires the IRQF_ONESHOT, because the source of interrupt is not disabled. Signed-off-by: Saurabh Sengar --- drivers/power/max8903_charger.c | 9 ++--- drivers/power

[PATCH] audit: removing unused variable

variavle rc in not required as it is just used for unchanged for return, and return is always 0 in the function. Signed-off-by: Saurabh Sengar --- kernel/audit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 662c007..409482f

[PATCH v2] efi: replace GFP_KERNEL with GFP_ATOMIC

replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock should be atomic GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- drivers/firmware/efi/vars.c | 12 +--- 1 file changed, 9

[PATCH v3] PM / suspend: replacing printk

replacing printk(s) with appropriate pr_info and pr_err in order to fix checkpatch.pl warnings Signed-off-by: Saurabh Sengar --- kernel/power/suspend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 7e4cda4

[PATCH v3] PM / suspend: replacing printk

replacing printk(s) with appropriate pr_info and pr_err in order to fix checkpatch.pl warnings. Signed-off-by: Saurabh Sengar --- kernel/power/suspend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 7e4cda4

[PATCH v2] PM / suspend: replacing printk

replacing prink(s) with appropriate pr_info and pr_err Signed-off-by: Saurabh Sengar --- kernel/power/suspend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 7e4cda4..2d8856b 100644 --- a/kernel/power/suspend.c

[PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC

replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock should be atomic GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- drivers/firmware/efi/vars.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC

replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock should be atomic GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- drivers/infiniband/core/sa_query.c | 4 ++-- 1 file changed, 2

  1   2   >