Re: checkpatch.pl "uninitialized value"

2013-01-14 Thread Schrober
On Monday 14 January 2013 05:50:12 Joe Perches wrote: > On Mon, 2013-01-14 at 14:45 +0100, Bernd Petrovitsch wrote: > > On Mon, 2013-01-14 at 14:42 +0100, Schrober wrote: > > [...] > > > > > it seems the current version of checkpatch.pl in linux-next is

Re: checkpatch.pl "uninitialized value"

2013-01-14 Thread Schrober
But of course, here is a simple example: ./scripts/checkpatch.pl -f lib/decompress_bunzip2.c -- Franz Schrober -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

checkpatch.pl "uninitialized value"

2013-01-14 Thread Schrober
uninitialized value $ms_size in pattern match (m//) at ./scripts/checkpatch.pl line 3386. -- Franz Schrober -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Hashtable implementation breaks on flow statements

2013-01-14 Thread Schrober
. This works well on hlist, list and other "abstract" data types. But the hash table would just jump to the next bucket and continue. -- Franz Schrober -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

container-of Implementation

2013-01-14 Thread Schrober
mptr not unnecessary? Why not following version? #define container_of(ptr, type, member) \ ((type *)((char *)(ptr) - offsetof(type, member))) -- Franz Schrober -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] checkpatch: Add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO

2012-08-02 Thread Schrober
} > > Looks reasonable enough. > > Acked-by: Andy Whitcroft Works well for me, thanks Just as note: I think this test was accidently added twice. Once in commit b13edf7ff2dd0fef95e981170fa71fa6b60421b0 and one time in 7d64ef43914a734990e48a80bc60686c8db21946 (just checked linux-next, and St

checkpatch.pl: Wrong check SINGLE_STATEMENT_DO_WHILE_MACRO

2012-08-02 Thread Schrober
se macros and break the kernel doing that. -- Franz Schrober -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/