Re: [PATCH linux-next V2] tty: Disable default console blanking interval

On Thu, 23 Mar 2017, Austin S. Hemmelgarn wrote: > On 2017-03-22 21:32, Scot Doyle wrote: > > On Wed, 22 Mar 2017, Tim Gardner wrote: > > > BugLink: http://bugs.launchpad.net/bugs/869017 > > > > > > Console blanking is not enabling DPMS power saving (the

Re: [PATCH linux-next V2] tty: Disable default console blanking interval

On Thu, 23 Mar 2017, Austin S. Hemmelgarn wrote: > On 2017-03-22 21:32, Scot Doyle wrote: > > On Wed, 22 Mar 2017, Tim Gardner wrote: > > > BugLink: http://bugs.launchpad.net/bugs/869017 > > > > > > Console blanking is not enabling DPMS power saving (the

Re: [PATCH linux-next V2] tty: Disable default console blanking interval

On Wed, 22 Mar 2017, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/869017 > > Console blanking is not enabling DPMS power saving (thereby negating any > power-saving benefit), and is simply turning the screen content blank. This > means that any crash output is invisible which is

Re: [PATCH linux-next V2] tty: Disable default console blanking interval

On Wed, 22 Mar 2017, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/869017 > > Console blanking is not enabling DPMS power saving (thereby negating any > power-saving benefit), and is simply turning the screen content blank. This > means that any crash output is invisible which is

[PATCH] vt: clear selection before resizing

com> Signed-off-by: Scot Doyle <lkm...@scotdoyle.com> --- drivers/tty/vt/vt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 06fb39c..5d6a549 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -874,6 +874,9 @@ static int

[PATCH] vt: clear selection before resizing

When resizing a vt its selection may exceed the new size, resulting in an invalid memory access [1]. Clear the selection before resizing. [1] http://lkml.kernel.org/r/CACT4Y+acDTwy4umEvf5ROBGiRJNrxHN4Cn5szCXE5Jw-d1B=x...@mail.gmail.com Reported-and-tested-by: Dmitry Vyukov Signed-off-by: Scot

Re: tty, fbcon: use-after-free in fbcon_invert_region

> On Tue, Oct 11, 2016 at 3:43 AM, Scot Doyle <lkm...@scotdoyle.com> wrote: > > I wonder if the text selection is outside the newly resized vc? > > Does this patch help? > > > > --- vt.c2016-10-11 00:32:43.079605599 - > > +++ vt.c.new

Re: tty, fbcon: use-after-free in fbcon_invert_region

> On Tue, Oct 11, 2016 at 3:43 AM, Scot Doyle wrote: > > I wonder if the text selection is outside the newly resized vc? > > Does this patch help? > > > > --- vt.c2016-10-11 00:32:43.079605599 - > > +++ vt.c.new2016-10-11 00:36:12.744

Re: tty, fbcon: use-after-free in fbcon_invert_region

On Fri, 7 Oct 2016, Dmitry Vyukov wrote: > On Sat, Sep 3, 2016 at 9:20 PM, Dmitry Vyukov wrote: > > Hello, > > > > The following program causes use-after-free in fbcon_invert_region: > > > >

Re: tty, fbcon: use-after-free in fbcon_invert_region

On Fri, 7 Oct 2016, Dmitry Vyukov wrote: > On Sat, Sep 3, 2016 at 9:20 PM, Dmitry Vyukov wrote: > > Hello, > > > > The following program causes use-after-free in fbcon_invert_region: > > > >

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

On Fri, 20 May 2016, Scot Doyle wrote: > On Fri, 20 May 2016, Jeremy Kerr wrote: > > Hi Ming, > > > > >Then looks there are two fix patches acked & tested: > > > > > > - the patch in this thread > > > - another one "[PATCH] tty: vt: Fi

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

On Fri, 20 May 2016, Scot Doyle wrote: > On Fri, 20 May 2016, Jeremy Kerr wrote: > > Hi Ming, > > > > >Then looks there are two fix patches acked & tested: > > > > > > - the patch in this thread > > > - another one "[PATCH] tty: vt: Fi

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

On Fri, 20 May 2016, Jeremy Kerr wrote: > Hi Ming, > > >Then looks there are two fix patches acked & tested: > > > > - the patch in this thread > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > >blink timer." > > https://lkml.org/lkml/2016/5/17/455 > > > >So which one will be

Re: [PATCH] fbcon: warn on invalid cursor blink intervals

On Fri, 20 May 2016, Jeremy Kerr wrote: > Hi Ming, > > >Then looks there are two fix patches acked & tested: > > > > - the patch in this thread > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor > >blink timer." > > https://lkml.org/lkml/2016/5/17/455 > > > >So which one will be

Re: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer.

lockup. > > The fix is to initialize vc_cur_blink_ms before calling the con_init() > function. > > Signed-off-by: David Daney <david.da...@cavium.com> > Cc: sta...@vger.kernel.org Acked-by: Scot Doyle <lkm...@scotdoyle.com>

Re: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer.

is to initialize vc_cur_blink_ms before calling the con_init() > function. > > Signed-off-by: David Daney > Cc: sta...@vger.kernel.org Acked-by: Scot Doyle

[PATCH] fbcon: warn on invalid cursor blink intervals

Two systems are locking on boot [1] because ops->cur_blink_jiffies is set to zero from vc->vc_cur_blink_ms. Ignore such invalid intervals and log a warning. [1] https://bugs.launchpad.net/bugs/1574814 Suggested-by: David Daney <david.da...@cavium.com> Signed-off-by: Sco

[PATCH] fbcon: warn on invalid cursor blink intervals

Two systems are locking on boot [1] because ops->cur_blink_jiffies is set to zero from vc->vc_cur_blink_ms. Ignore such invalid intervals and log a warning. [1] https://bugs.launchpad.net/bugs/1574814 Suggested-by: David Daney Signed-off-by: Scot Doyle Cc: [v4.2] --- drivers/video/c

Re: [PATCH] fbcon: use default if cursor blink interval is not valid

On Thu, 19 May 2016, David Daney wrote: > On 05/18/2016 09:21 PM, Scot Doyle wrote: > > Two current [1] and three previous [2] systems locked during boot > > because the cursor flash timer was set using an ops->cur_blink_jiffies > > value of 0. Previous patches attemp

Re: [PATCH] fbcon: use default if cursor blink interval is not valid

On Thu, 19 May 2016, David Daney wrote: > On 05/18/2016 09:21 PM, Scot Doyle wrote: > > Two current [1] and three previous [2] systems locked during boot > > because the cursor flash timer was set using an ops->cur_blink_jiffies > > value of 0. Previous patches attemp

Re: [PATCH] fbcon: use default if cursor blink interval is not valid

On Thu, 19 May 2016, Pavel Machek wrote: > Hi! > > > Two current [1] and three previous [2] systems locked during boot > > because the cursor flash timer was set using an ops->cur_blink_jiffies > > value of 0. Previous patches attempted to solve the problem by moving > > variable initialization

Re: [PATCH] fbcon: use default if cursor blink interval is not valid

On Thu, 19 May 2016, Pavel Machek wrote: > Hi! > > > Two current [1] and three previous [2] systems locked during boot > > because the cursor flash timer was set using an ops->cur_blink_jiffies > > value of 0. Previous patches attempted to solve the problem by moving > > variable initialization

[PATCH] fbcon: use default if cursor blink interval is not valid

64a8af, a1e533ec07d5 Signed-off-by: Scot Doyle <lkm...@scotdoyle.com> Cc: <sta...@vger.kernel.org> [v4.2] --- drivers/video/console/fbcon.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c inde

[PATCH] fbcon: use default if cursor blink interval is not valid

64a8af, a1e533ec07d5 Signed-off-by: Scot Doyle Cc: [v4.2] --- drivers/video/console/fbcon.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 6e92917..da61d87 100644 --- a/drivers/video/console/f

Re: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer.

On Wed, 18 May 2016, Ming Lei wrote: > On Wed, May 18, 2016 at 4:49 AM, Pavel Machek wrote: > > On Tue 2016-05-17 11:41:04, David Daney wrote: > >> From: David Daney > >> > >> We are getting somewhat random soft lockups with this signature: > >> > >> [

Re: [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer.

On Wed, 18 May 2016, Ming Lei wrote: > On Wed, May 18, 2016 at 4:49 AM, Pavel Machek wrote: > > On Tue 2016-05-17 11:41:04, David Daney wrote: > >> From: David Daney > >> > >> We are getting somewhat random soft lockups with this signature: > >> > >> [ 86.992215] [] el1_irq+0xa0/0x10c > >> [

Re: [PATCH] fbcon: initialize blink interval before calling fb_set_par

On Wed, 21 Oct 2015, Benjamin Herrenschmidt wrote: > On Fri, 2015-10-09 at 15:08 +0000, Scot Doyle wrote: > > Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459 > > fbcon: use the cursor blink interval provided by vt > > > > a PPC64LE kernel fails to boot when

Re: [PATCH] fbcon: initialize blink interval before calling fb_set_par

On Wed, 21 Oct 2015, Benjamin Herrenschmidt wrote: > On Fri, 2015-10-09 at 15:08 +0000, Scot Doyle wrote: > > Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459 > > fbcon: use the cursor blink interval provided by vt > > > > a PPC64LE kernel fails to boot when

[PATCH] fbcon: initialize blink interval before calling fb_set_par

b_set_par. Reported-and-tested-by: Alistair Popple Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 1aaf893..92f3949 100644 --- a/drivers/video/console/fbcon.c +++

[PATCH] fbcon: initialize blink interval before calling fb_set_par

b_set_par. Reported-and-tested-by: Alistair Popple <alist...@popple.id.au> Signed-off-by: Scot Doyle <lkm...@scotdoyle.com> --- drivers/video/console/fbcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 1a

Re: [BUG] RCU stall in cursor_timer_handler

On Sat, 3 Oct 2015, Alistair Popple wrote: > Hi, > > We have been intermittently seeing the below RCU stall at boot on a > PPC64LE 4.2.1 kernel which has been preventing the system from booting. > Further investigation indicates that ops->cur_blink_jiffies is > potentially being used

Re: [BUG] RCU stall in cursor_timer_handler

On Sat, 3 Oct 2015, Alistair Popple wrote: > Hi, > > We have been intermittently seeing the below RCU stall at boot on a > PPC64LE 4.2.1 kernel which has been preventing the system from booting. > Further investigation indicates that ops->cur_blink_jiffies is > potentially being used

Re: [PATCH] fbcon: unconditionally initialize cursor blink interval

On Tue, 4 Aug 2015, Pavel Machek wrote: > On Tue 2015-08-04 12:33:32, Scot Doyle wrote: > > A sun7i-a20-olinuxino-micro fails to boot when kernel parameter > > vt.global_cursor_default=0. The value is copied to vc->vc_deccm > > causing the initialization of ops->cur_

Re: [PATCH] fbcon: unconditionally initialize cursor blink interval

On Tue, 4 Aug 2015, Pavel Machek wrote: On Tue 2015-08-04 12:33:32, Scot Doyle wrote: A sun7i-a20-olinuxino-micro fails to boot when kernel parameter vt.global_cursor_default=0. The value is copied to vc-vc_deccm causing the initialization of ops-cur_blink_jiffies to be skipped

[PATCH] fbcon: unconditionally initialize cursor blink interval

A sun7i-a20-olinuxino-micro fails to boot when kernel parameter vt.global_cursor_default=0. The value is copied to vc->vc_deccm causing the initialization of ops->cur_blink_jiffies to be skipped. Unconditionally initialize it. Reported-and-tested-by: Jonathan Liu Signed-off-by: Scot

[PATCH] fbcon: unconditionally initialize cursor blink interval

-by: Scot Doyle lkm...@scotdoyle.com --- drivers/video/console/fbcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 658c34b..1aaf893 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c

Re: [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

On Tue, 21 Jul 2015, Michael Kerrisk (man-pages) wrote: > On 5 July 2015 at 19:41, Scot Doyle wrote: > > On Thu, 26 Mar 2015, Scot Doyle wrote: > >> Add a Console Private CSI sequence to specify the current console's > >> cursor blink interval. The interv

Re: [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

On Tue, 21 Jul 2015, Michael Kerrisk (man-pages) wrote: On 5 July 2015 at 19:41, Scot Doyle lkm...@scotdoyle.com wrote: On Thu, 26 Mar 2015, Scot Doyle wrote: Add a Console Private CSI sequence to specify the current console's cursor blink interval. The interval is specified as a number

Re: [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

On Thu, 26 Mar 2015, Scot Doyle wrote: > Add a Console Private CSI sequence to specify the current console's > cursor blink interval. The interval is specified as a number of > milliseconds until the next cursor display state toggle, from 50 to > 65535. > > Signed-

Re: [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

On Thu, 26 Mar 2015, Scot Doyle wrote: Add a Console Private CSI sequence to specify the current console's cursor blink interval. The interval is specified as a number of milliseconds until the next cursor display state toggle, from 50 to 65535. Signed-off-by: Scot Doyle lkm

Re: [PATCH 2/2] fbcon: use the cursor blink interval provided by vt

On Wed, 27 May 2015, Andrey Wagin wrote: ... > I regularly execute criu tests on linux-next. For this, I use virtual > machine from the digitalocean clould. The current version of > linux-next hangs after a few seconds. I use git bisect to find the > commit where the problem is appeaed. And it

Re: [PATCH 2/2] fbcon: use the cursor blink interval provided by vt

On Wed, 27 May 2015, Andrey Wagin wrote: ... I regularly execute criu tests on linux-next. For this, I use virtual machine from the digitalocean clould. The current version of linux-next hangs after a few seconds. I use git bisect to find the commit where the problem is appeaed. And it looks

Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

I'll come up with a > proper commit message. > > Thierry Hi all, sorry for the trouble. The timer delete was to prevent blink stutter when updating the interval. Since the stutter isn't so noticable when changing from the default 200ms, and since most people seem to prefer leaving the fbco

Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

with Thierry's approach. Tested-by: Scot Doyle lkm...@scotdoyle.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

Add a Console Private CSI sequence to specify the current console's cursor blink interval. The interval is specified as a number of milliseconds until the next cursor display state toggle, from 50 to 65535. Signed-off-by: Scot Doyle --- man4/console_codes.4 | 1 + 1 file changed, 1 insertion

[PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

vt now provides a cursor blink interval via vc_data. Use this interval instead of the currently hardcoded 200 msecs. Store it in fbcon_ops to avoid locking the console in cursor_timer_handler(). Signed-off-by: Scot Doyle Acked-by: Pavel Machek --- drivers/video/console/fbcon.c | 10

[PATCH v2 1/3] vt: add cursor blink interval escape sequence

msecs since slower hardware wasn't tested. Store the interval in the vc_data structure for later access by fbcon, initializing the value to fbcon's current hardcoded value of 200 msecs. Signed-off-by: Scot Doyle Acked-by: Pavel Machek --- drivers/tty/vt/vt.c| 9 + include/linux

[PATCH v2 0/3] add cursor blink interval terminal escape sequence

v2: Add documentation to console_codes man page (man-pages repo) This patch series adds an escape sequence to specify the current console's cursor blink interval. The default interval is set to fbcon's currently hardcoded 200 msecs. Scot Doyle (3): vt: add cursor blink interval escape

[PATCH v2 0/3] add cursor blink interval terminal escape sequence

v2: Add documentation to console_codes man page (man-pages repo) This patch series adds an escape sequence to specify the current console's cursor blink interval. The default interval is set to fbcon's currently hardcoded 200 msecs. Scot Doyle (3): vt: add cursor blink interval escape

[PATCH v2 1/3] vt: add cursor blink interval escape sequence

msecs since slower hardware wasn't tested. Store the interval in the vc_data structure for later access by fbcon, initializing the value to fbcon's current hardcoded value of 200 msecs. Signed-off-by: Scot Doyle lkm...@scotdoyle.com Acked-by: Pavel Machek pa...@ucw.cz --- drivers/tty/vt/vt.c

[PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

Add a Console Private CSI sequence to specify the current console's cursor blink interval. The interval is specified as a number of milliseconds until the next cursor display state toggle, from 50 to 65535. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- man4/console_codes.4 | 1 + 1 file

[PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

vt now provides a cursor blink interval via vc_data. Use this interval instead of the currently hardcoded 200 msecs. Store it in fbcon_ops to avoid locking the console in cursor_timer_handler(). Signed-off-by: Scot Doyle lkm...@scotdoyle.com Acked-by: Pavel Machek pa...@ucw.cz --- drivers/video

Re: [tpmdd-devel] [PATCH v2] tpm: fix: sanitized code paths in tpm_chip_register()

set # CONFIG_TCG_CRB is not set [0.236145] tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16) [0.292769] tpm_tis 00:08: [Firmware Bug]: TPM interrupt not working, polling instead and suspend/resume continue to function. Tested-by: Scot Doyle -- To unsubscribe from this list: send the line "u

Re: [tpmdd-devel] [PATCH v2] tpm: fix: sanitized code paths in tpm_chip_register()

] tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16) [0.292769] tpm_tis 00:08: [Firmware Bug]: TPM interrupt not working, polling instead and suspend/resume continue to function. Tested-by: Scot Doyle lkm...@scotdoyle.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 1/2] vt: add cursor blink interval escape sequence

On Fri, 27 Feb 2015, Scot Doyle wrote: > Add an escape sequence to specify the current console's cursor blink > interval. The interval is specified as a number of milliseconds until > the next cursor display state toggle, from 50 to 65535. /proc/loadavg > did not show a difference wit

Re: [PATCH 1/2] vt: add cursor blink interval escape sequence

On Fri, 27 Feb 2015, Scot Doyle wrote: Add an escape sequence to specify the current console's cursor blink interval. The interval is specified as a number of milliseconds until the next cursor display state toggle, from 50 to 65535. /proc/loadavg did not show a difference with a one msec

[PATCH 2/2] fbcon: use the cursor blink interval provided by vt

vt now provides a cursor blink interval via vc_data. Use this interval instead of the currently hardcoded 200 msecs. Store it in fbcon_ops to avoid locking the console in cursor_timer_handler(). Signed-off-by: Scot Doyle Acked-by: Pavel Machek --- drivers/video/console/fbcon.c | 10

[PATCH 1/2] vt: add cursor blink interval escape sequence

msecs since slower hardware wasn't tested. Store the interval in the vc_data structure for later access by fbcon, initializing the value to fbcon's current hardcoded value of 200 msecs. Signed-off-by: Scot Doyle Acked-by: Pavel Machek --- drivers/tty/vt/vt.c| 9 + include/linux

[PATCH 0/2] add cursor blink interval terminal escape sequence

blink interval via sysfs" Michael, I plan to send a documentation patch if these are accepted. This patch series adds an escape sequence to specify the current console's cursor blink interval. The default interval is set to fbcon's currently hardcoded 200 msecs. Scot Doyle (2): vt: add c

[PATCH 0/2] add cursor blink interval terminal escape sequence

sysfs Michael, I plan to send a documentation patch if these are accepted. This patch series adds an escape sequence to specify the current console's cursor blink interval. The default interval is set to fbcon's currently hardcoded 200 msecs. Scot Doyle (2): vt: add cursor blink interval escape

[PATCH 1/2] vt: add cursor blink interval escape sequence

msecs since slower hardware wasn't tested. Store the interval in the vc_data structure for later access by fbcon, initializing the value to fbcon's current hardcoded value of 200 msecs. Signed-off-by: Scot Doyle lkm...@scotdoyle.com Acked-by: Pavel Machek pa...@ucw.cz --- drivers/tty/vt/vt.c

[PATCH 2/2] fbcon: use the cursor blink interval provided by vt

vt now provides a cursor blink interval via vc_data. Use this interval instead of the currently hardcoded 200 msecs. Store it in fbcon_ops to avoid locking the console in cursor_timer_handler(). Signed-off-by: Scot Doyle lkm...@scotdoyle.com Acked-by: Pavel Machek pa...@ucw.cz --- drivers/video

Re: [PATCH 2/2] fbcon: expose cursor blink interval via sysfs

On Wed, 25 Feb 2015, Pavel Machek wrote: > On Mon 2015-01-26 20:41:53, Scot Doyle wrote: > > The fbcon cursor, when set to blink, is hardcoded to toggle display state > > five times per second. Expose this setting via > > /sys/class/graphics/fbcon/cursor_blink_ms &g

RE: [PATCH] ACPI / EC: Remove non-standard log emphasis

On Wed, 25 Feb 2015, Zheng, Lv wrote: ... > > I was using "+"/"#"/"*" to filter different EC log entries > > which makes debugging easier. > > And, if we changed this from pr_info into pr_debug, then we will have > > nothing in the suspend/resume logs for the EC device. > > While

RE: [PATCH] ACPI / EC: Remove non-standard log emphasis

On Wed, 25 Feb 2015, Zheng, Lv wrote: ... I was using +/#/* to filter different EC log entries which makes debugging easier. And, if we changed this from pr_info into pr_debug, then we will have nothing in the suspend/resume logs for the EC device. While there are plenty of

Re: [PATCH 2/2] fbcon: expose cursor blink interval via sysfs

On Wed, 25 Feb 2015, Pavel Machek wrote: On Mon 2015-01-26 20:41:53, Scot Doyle wrote: The fbcon cursor, when set to blink, is hardcoded to toggle display state five times per second. Expose this setting via /sys/class/graphics/fbcon/cursor_blink_ms Values written to the interface set

[PATCH] ACPI / EC: Remove non-standard log emphasis

Remove unusual pr_info() visual emphasis introduced in ad479e7f47ca "ACPI / EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag". Signed-off-by: Scot Doyle --- drivers/acpi/ec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers

[PATCH] ACPI / EC: Remove non-standard log emphasis

Remove unusual pr_info() visual emphasis introduced in ad479e7f47ca ACPI / EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/acpi/ec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec.c b

Re: [PATCH RFC] video: fbdev: sis: condition with no effect

On Thu, 5 Feb 2015, Tormod Volden wrote: > On Thu, Feb 5, 2015 at 9:45 PM, Scot Doyle wrote: > > On Wed, 4 Feb 2015, Nicholas Mc Guire wrote: > >> The if and the else branch code are identical - so the condition has no > >> effect on the effective code - this

Re: [PATCH RFC] video: fbdev: sis: condition with no effect

On Wed, 4 Feb 2015, Nicholas Mc Guire wrote: > The if and the else branch code are identical - so the condition has no > effect on the effective code - this patch removes the condition and the > duplicated code. > > Signed-off-by: Nicholas Mc Guire > --- > > This code has been in here since

Re: [PATCH RFC] video: fbdev: sis: condition with no effect

On Wed, 4 Feb 2015, Nicholas Mc Guire wrote: The if and the else branch code are identical - so the condition has no effect on the effective code - this patch removes the condition and the duplicated code. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- This code has been in here

Re: [PATCH RFC] video: fbdev: sis: condition with no effect

On Thu, 5 Feb 2015, Tormod Volden wrote: On Thu, Feb 5, 2015 at 9:45 PM, Scot Doyle wrote: On Wed, 4 Feb 2015, Nicholas Mc Guire wrote: The if and the else branch code are identical - so the condition has no effect on the effective code - this patch removes the condition

[PATCH v6 2/2] fbcon: expose cursor blink interval via sysfs

via the 'cursor_blink' boolean setting or some other mechanism, the 'cursor_blink_ms' setting may still be modified. The new value will be used if the blink is reactivated. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 65 +++ 1 file

[PATCH v6 1/2] fbcon: store cursor blink interval in fbcon_ops

fbcon toggles cursor display state every 200 milliseconds when blinking. Since users prefer different toggle intervals, prepare to expose the interval via sysfs by moving it to fbdev_ops and setting the default to 200 milliseconds. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 5

[PATCH v6 0/2] fbcon: user-defined cursor blink interval

error messages as suggested by Tomi Valkeinen v4: Add rationale into the patches as suggested by Richard Weinberger v5: Return error codes instead of logging error messages (my mistake) v6: Uncomment the correct line (my mistake again!) Scot Doyle (2): fbcon: store cursor blink interval

[PATCH v5 2/2] fbcon: expose cursor blink interval via sysfs

via the 'cursor_blink' boolean setting or some other mechanism, the 'cursor_blink_ms' setting may still be modified. The new value will be used if the blink is reactivated. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 66 +++ 1 file

[PATCH v5 1/2] fbcon: store cursor blink interval in fbcon_ops

fbcon toggles cursor display state every 200 milliseconds when blinking. Since users prefer different toggle intervals, prepare to expose the interval via sysfs by moving it to fbdev_ops and setting the default to 200 milliseconds. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 5

[PATCH v5 0/2] fbcon: user-defined cursor blink interval

error messages as suggested by Tomi Valkeinen v4: Add rationale into the patches as suggested by Richard Weinberger v5: Return error codes instead of logging error messages (my mistake) Scot Doyle (2): fbcon: store cursor blink interval in fbcon_ops fbcon: expose cursor blink interval via sysfs

[PATCH v6 0/2] fbcon: user-defined cursor blink interval

error messages as suggested by Tomi Valkeinen v4: Add rationale into the patches as suggested by Richard Weinberger v5: Return error codes instead of logging error messages (my mistake) v6: Uncomment the correct line (my mistake again!) Scot Doyle (2): fbcon: store cursor blink interval

[PATCH v6 1/2] fbcon: store cursor blink interval in fbcon_ops

fbcon toggles cursor display state every 200 milliseconds when blinking. Since users prefer different toggle intervals, prepare to expose the interval via sysfs by moving it to fbdev_ops and setting the default to 200 milliseconds. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/video

[PATCH v6 2/2] fbcon: expose cursor blink interval via sysfs

via the 'cursor_blink' boolean setting or some other mechanism, the 'cursor_blink_ms' setting may still be modified. The new value will be used if the blink is reactivated. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/video/console/fbcon.c | 65

[PATCH v5 0/2] fbcon: user-defined cursor blink interval

error messages as suggested by Tomi Valkeinen v4: Add rationale into the patches as suggested by Richard Weinberger v5: Return error codes instead of logging error messages (my mistake) Scot Doyle (2): fbcon: store cursor blink interval in fbcon_ops fbcon: expose cursor blink interval via sysfs

[PATCH v5 1/2] fbcon: store cursor blink interval in fbcon_ops

fbcon toggles cursor display state every 200 milliseconds when blinking. Since users prefer different toggle intervals, prepare to expose the interval via sysfs by moving it to fbdev_ops and setting the default to 200 milliseconds. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/video

[PATCH v5 2/2] fbcon: expose cursor blink interval via sysfs

via the 'cursor_blink' boolean setting or some other mechanism, the 'cursor_blink_ms' setting may still be modified. The new value will be used if the blink is reactivated. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/video/console/fbcon.c | 66

Re: [PATCH v2] tpm: fix suspend/resume paths for TPM 2.0

| 26 +- > 5 files changed, 34 insertions(+), 39 deletions(-) Resume still functions on TPM 1.2 chip, with and without CONFIG_TCG_CRB. Tested-by: Scot Doyle

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Thu, 29 Jan 2015, Michael Kerrisk (man-pages) wrote: > On 29 January 2015 at 02:27, Scot Doyle wrote: > > On Wed, 28 Jan 2015, Vivek Goyal wrote: > >> On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote: > >> > On Wed, 28 Jan 2015, Vivek Goyal wrote: >

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Thu, 29 Jan 2015, Michael Kerrisk (man-pages) wrote: On 29 January 2015 at 02:27, Scot Doyle lkm...@scotdoyle.com wrote: On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote: On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015

Re: [PATCH v2] tpm: fix suspend/resume paths for TPM 2.0

changed, 34 insertions(+), 39 deletions(-) Resume still functions on TPM 1.2 chip, with and without CONFIG_TCG_CRB. Tested-by: Scot Doyle lkm...@scotdoyle.com

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: > On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote: > > Hello Vivek, > > > > >> I've made various adjustments to the page in the light of your comments > > >> above. Thanks! > > > > > > Thank you for following it up and improving

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: > On Wed, Jan 28, 2015 at 10:10:59PM +0000, Scot Doyle wrote: > > On Wed, 28 Jan 2015, Vivek Goyal wrote: > > > On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote: > > > > When I tested, kexec_file_load required C

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: > On Wed, Jan 28, 2015 at 09:14:03PM +0000, Scot Doyle wrote: > > On Wed, 28 Jan 2015, Vivek Goyal wrote: > > > On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) > > > wrote: > > > > Hello Vivek

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote: On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote: Hello Vivek, I've made various adjustments to the page

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote: On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote: When I tested, kexec_file_load required CONFIG_RELOCATABLE. Is the same true

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

On Wed, 28 Jan 2015, Vivek Goyal wrote: On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote: Hello Vivek, I've made various adjustments to the page in the light of your comments above. Thanks! Thank you for following it up and improving kexec man page.

Re: [tpmdd-devel] [PATCH] tpm: fix suspend/resume paths for TPM 2.0

On Tue, 27 Jan 2015, Jarkko Sakkinen wrote: > Fixed suspend/resume paths for TPM 2.0 and consolidated all the > associated code to the tpm_pm_suspend() and tpm_pm_resume() > functions. Resume path should be handled by the firmware, i.e. > Startup(CLEAR) for hibernate and Startup(STATE) for

Re: [tpmdd-devel] [PATCH] tpm: fix suspend/resume paths for TPM 2.0

On Tue, 27 Jan 2015, Jarkko Sakkinen wrote: Fixed suspend/resume paths for TPM 2.0 and consolidated all the associated code to the tpm_pm_suspend() and tpm_pm_resume() functions. Resume path should be handled by the firmware, i.e. Startup(CLEAR) for hibernate and Startup(STATE) for suspend.

Re: [PATCH v4 0/2] fbcon: user-defined cursor blink interval

On Tue, 27 Jan 2015, Richard Weinberger wrote: > Am 27.01.2015 um 00:09 schrieb Scot Doyle: > > Since users prefer different fbcon cursor blink intervals, allow the > > interval to be set via sysfs. The current interval of 200 milliseconds > > is retained as the default

[PATCH v4 2/2] fbcon: expose cursor blink interval via sysfs

via the 'cursor_blink' boolean setting or some other mechanism, the 'cursor_blink_ms' setting may still be modified. The new value will be used if the blink is reactivated. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 79 +++ 1 file

[PATCH v4 1/2] fbcon: store cursor blink interval in fbcon_ops

fbcon toggles cursor display state every 200 milliseconds when blinking. Since users prefer different toggle intervals, prepare to expose the interval via sysfs by moving it to fbdev_ops and setting the default to 200 milliseconds. Signed-off-by: Scot Doyle --- drivers/video/console/fbcon.c | 5

[PATCH v4 0/2] fbcon: user-defined cursor blink interval

error messages as suggested by Tomi Valkeinen v4: Add rationale into patch descriptions as suggested by Richard Weinberger Scot Doyle (2): fbcon: store cursor blink interval in fbcon_ops fbcon: expose cursor blink interval via sysfs drivers/video/console/fbcon.c | 84

  1   2   3   >