Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > Assuming the answer to this question is "no", can you try out this > patch? > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > index 8fee5b6f8f66..af74849e8c0f 100644 > --- a/arch/x86/mm/pageattr.c > +++ b/arch/x86/mm/pageatt

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Sun, 2016-03-13 at 23:07 +, Matt Fleming wrote: > On Sun, 13 Mar, at 09:58:47PM, Matt Fleming wrote: > > Does $(grep pdpe1gb /proc/cpuinfo) show any output on your machine? > Assuming the answer to this question is "no", can you try out this > patch? The answer is no. Attached is the dmesg

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

2016-03-13 Thread Scott Ashcroft
On Fri, 2016-03-11 at 11:19 +, Matt Fleming wrote: > Some machines have EFI regions in page zero (physical address > 0x) and historically that region has been added to the e820 > map via trim_bios_range(), and ultimately mapped into the kernel page > tables. It was not mapped via efi_ma

HP Pavilion 11 x360 lockups on shutdown

2014-07-20 Thread Scott Ashcroft
Hi all, I've got an HP Pavilion 11 x360 laptop which sometimes fails to boot and when it does boot will always hang on shutdown. This seems to be a common issue on a bunch of newer HP laptops and there are quite a few reports in the various distro bug tracking systems. I've worked out that th

Re: Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-13 Thread Scott Ashcroft
Robert Hancock wrote: > You missed this code: name = pci_mmcfg_probes[i].probe(); This calls one of the probe functions above, which will set pci_mmcfg_config_num to something else, as with the name variable. It may set the name but not the config num, if the chipset is recognized but MMCON

Always zero test in arch/i386/pci/mmconfig-shared.c

2007-07-10 Thread Scott Ashcroft
I don't think it makes any change to subsequent flow but the code in pci_mmcfg_check_hostbridge is: pci_mmcfg_config_num = 0; ... if (name) { printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n", name, pci_mmcfg_config_num ? "with" : "without"); } So it will always p

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread scott . ashcroft
Mike Miller (OS Dev) wrote: + if (return_code = IO_OK) { Shouldn't that be == + printk(KERN_WARNING "Completed cache flush on controller %d\n", i); + } else { + printk(KERN_WARNING "Error Flushing cache on controller %d\n", i); } free_

Re: 2.2.19ac-pre9 lo interface Broke

2001-02-13 Thread Scott Ashcroft
Gordon Sadler wrote: > > I have some further info here. > I performed strace on ifup -a and ifdown -a. > > They aren't more than 4Kb each, but I'll cut and paste what appear to be > most relevant: > > ifup.strace: > fork() = 17974 > wait4(17974, [WIFEXITED(s) &&