incorrect type in assignment (different
> base types)
> ../block/sed-opal.c:376:25:expected unsigned long long [usertype]
> lowest_lba
> ../block/sed-opal.c:376:25:got restricted __be64 const [usertype]
> lowest_aligned_lba
>
> Fixes: 455a7b238cd6 ("block: Add Sed-opal
size of shadow mbr")
> Signed-off-by: Randy Dunlap
> Cc: Jens Axboe
> Cc: linux-bl...@vger.kernel.org
> Cc: Jonas Rabenstein
> Cc: David Kozub
> ---
Un cc'd David and Jonas, +CC'd Jon and Revanth.
This looks fine to me too.
Reviewed-by: Scott Bauer
On Fri, May 03, 2019 at 10:32:19PM +0200, David Kozub wrote:
> On Wed, 1 May 2019, Christoph Hellwig wrote:
>
> > > I successfully tested toggling the MBR done flag and writing the shadow
> > > MBR
> > > using some tools I hacked together[4] with a Samsung SSD 850 EVO drive.
> >
> > Can you subm
On Fri, Feb 08, 2019 at 12:44:14AM +, Derrick, Jonathan wrote:
> On Thu, 2019-02-07 at 23:56 +0100, David Kozub wrote:
> > On Mon, 4 Feb 2019, Christoph Hellwig wrote:
> > > > static int opal_enable_disable_shadow_mbr(struct opal_dev *dev,
> > > > stru
he shadow
> > > > mbr stores the required boot files. Of course, this saves also the
> > > > (few) commands required to enable the feature if it is already enabled
> > > > and one only wants to mark the shadow mbr as done.
> > > >
> &g
On Mon, Feb 04, 2019 at 07:04:15AM -0800, Christoph Hellwig wrote:
> On Fri, Feb 01, 2019 at 09:50:07PM +0100, David Kozub wrote:
> > This patch series extends SED OPAL support: it adds IOCTL for setting the
> > shadow
> > MBR done flag which can be useful for unlocking an OPAL disk on boot and it
x86-64 and arm64 systems.
>
> The series applies on v5.0-rc3.
>
> Changes from v2 to v3:
> * review suggestions from Scott Bauer
>
> As Scott suggested I tried to do a more thorough testing, esp. with things
> like
> wrong passwords/invalid values. I did not observe an
On Tue, Jan 22, 2019 at 11:31:46PM +0100, David Kozub wrote:
> Originally each of the opal functions that call next include
> opal_discovery0 in the array of steps. This is superfluous and
> can be done always inside next.
>
> Signed-off-by: David Kozub
Reviewed-by: Scott Bauer
e function that set opal_dev.steps returns.
> If opal_dev.steps was not set to NULL before return it would become
> a dangling pointer. When the steps are passed as argument this
> becomes easier to see and more difficult to misuse.
>
> Signed-off-by: David Kozub
Reviewed-by: Scott Bauer
rappy firmwares.
>
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
and unlocking a locking range the
> actual content is accessible.
>
> Co-authored-by: David Kozub
> Signed-off-by: Jonas Rabenstein
> Signed-off-by: David Kozub
Reviewed-by: Scott Bauer
between and the shadow
> mbr stores the required boot files. Of course, this saves also the
> (few) commands required to enable the feature if it is already enabled
> and one only wants to mark the shadow mbr as done.
>
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
er functions.
>
> Co-authored-by: Jonas Rabenstein
> Signed-off-by: David Kozub
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
rom_user may be
> used without an intermediate buffer.
>
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
On Tue, Jan 22, 2019 at 11:31:39PM +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Add function address (and if available its symbol) to the message if a
> step function fails.
>
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
On Tue, Jan 22, 2019 at 11:31:33PM +0100, David Kozub wrote:
> From: Jonas Rabenstein
>
> Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same,
> it is weird to use OPAL_UID_LENGTH for the definition of the methods.
>
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
cation.
>
> Co-authored-by: David Kozub
> Signed-off-by: Jonas Rabenstein
> Signed-off-by: David Kozub
Reviewed-by: Scott Bauer
the opening and closing tokens for the argument list are already
> emitted by cmd_start and cmd_finalize respectively and thus must not be
> additionally added.
>
> Co-authored-by: Jonas Rabenstein
> Signed-off-by: David Kozub
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
> Co-authored-by: Jonas Rabenstein
> Signed-off-by: David Kozub
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
> Signed-off-by: David Kozub
> Signed-off-by: Jonas Rabenstein
Reviewed-by: Scott Bauer
On Tue, Jan 22, 2019 at 11:31:32PM +0100, David Kozub wrote:
> This should make no change in functionality.
> The formatting changes were triggered by checkpatch.pl.
>
> Signed-off-by: David Kozub
Reviewed-by: Scott Bauer
On Sun, Jan 20, 2019 at 11:27:30AM +0100, David Kozub wrote:
> On Sat, 19 Jan 2019, Scott Bauer wrote:
>
> > On Thu, Jan 17, 2019 at 09:31:51PM +, David Kozub wrote:
> >
> > > +static int write_shadow_mbr(struct opal_dev *dev, void *data)
> > > +{
&g
On Thu, Jan 17, 2019 at 09:31:55PM +, David Kozub wrote:
> - for (state = 0; !error && state < n_steps; state++) {
> - step = &steps[state];
> -
> - error = step->fn(dev, step->data);
> - if (error) {
> - pr_debug("Step %zu (%pS) fail
On Thu, Jan 17, 2019 at 09:31:53PM +, David Kozub wrote:
> From: Jonas Rabenstein
>
> Check whether the shadow mbr does fit in the provided space on the
> target. Also a proper firmware should handle this case and return an
> error we may prevent problems or even damage with crappy firmwares.
On Thu, Jan 17, 2019 at 09:31:51PM +, David Kozub wrote:
> +static int write_shadow_mbr(struct opal_dev *dev, void *data)
> +{
> + struct opal_shadow_mbr *shadow = data;
> + const u8 __user *src;
> + u8 *dst;
> + size_t off = 0;
> + u64 len;
> + int err = 0;
> +
> +
On Thu, Jan 17, 2019 at 09:31:49PM +, David Kozub wrote:
> -
> - memcpy(&cmd->cmd[cmd->pos], bytestring, len);
> + start = &cmd->cmd[cmd->pos];
> cmd->pos += len;
This is somewhat pendatic, but it helps me review patches if we keep things
together.
Since we're no longer doing th
On Wed, Jan 16, 2019 at 09:56:51PM +, David Kozub wrote:
> block: sed-opal: rename next to execute_steps
I don't see this change anywhere on the lists. I have 0->15, but am missing
16/16.
Please resend v2 with the changes Christoph requested, so it's easier to review.
Lastly, please CC me
On Thu, Mar 29, 2018 at 08:27:30PM +0200, catch...@ghostav.ddnss.de wrote:
> On Thu, Mar 29, 2018 at 11:16:42AM -0600, Scott Bauer wrote:
> > Yeah, having to autheticate to write the MBR is a real bummer. Theoretically
> > you could dd a the pw struct + the shador MBR into sysfs. B
On Thu, Mar 29, 2018 at 07:30:02PM +0200, Jonas Rabenstein wrote:
> Hi,
> On Wed, Mar 21, 2018 at 02:43:21AM +0100, Jonas Rabenstein wrote:
> > On Tue, Mar 20, 2018 at 04:09:08PM -0600, Scott Bauer wrote:
> > > On Tue, Mar 20, 2018 at 10:36:04AM +0100, Jonas Rabenstein wrote
On Tue, Mar 20, 2018 at 10:36:04AM +0100, Jonas Rabenstein wrote:
> On Mon, Mar 19, 2018 at 08:52:24PM +0100, Christoph Hellwig wrote:
> > On Mon, Mar 19, 2018 at 07:36:50PM +0100, Jonas Rabenstein wrote:
> > > Allow modification of the shadow mbr. If the shadow mbr is not marked as
> > > done, thi
On Mon, Mar 19, 2018 at 08:59:45PM +0100, Christoph Hellwig wrote:
> > +static u8 *add_bytestring_header(int *err, struct opal_dev *cmd, size_t
> > len)
> > {
> > size_t header_len = 1;
> > bool is_short_atom = true;
> > -
> > - if (*err)
> > - return;
> > + char *start;
>
On Mon, Mar 19, 2018 at 08:53:35PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 19, 2018 at 07:36:42PM +0100, Jonas Rabenstein wrote:
> > Hi,
> > I was advised to resend the patchset as a v2 where all the patches are
> > in a flat hierarchy. So here is a complete set which hopefully pleases
> > al
le changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Scott Bauer
Tested-by: Scott Bauer
Hi Jens,
When you get time can you apply this if you have no objections?
Thanks
On Tue, Mar 13, 2018 at 02:08:53PM +0100, Jonas Rabenstein wrote:
> Hi,
> this patchset adds support to write data into the shadow mbr of sed-opal
> enabled devices. They apply cleanly on today next-tree (next-20180313)
> and requires the u64 short atom length fix from [0] as that is still
> missin
On Tue, Mar 13, 2018 at 02:09:01PM +0100, Jonas Rabenstein wrote:
> Allow modification of the shadow mbr. If the shadow mbr is not marked as
> done, this data will be presented read only as the device content. Only
> after marking the shadow mbr as done and unlocking a locking range the
> actual co
On Tue, Mar 13, 2018 at 02:08:56PM +0100, Jonas Rabenstein wrote:
> Every step starts with resetting the cmd buffer as well as the comid and
> constructs the appropriate OPAL_CALL command. Consequently, those
> actions may be combined into one generic function.
>
> Signed-off-by: Jonas Rabenstein
le changed, 4 insertions(+), 7 deletions(-)
>
Reviewed-by: Scott Bauer
Your two patches should be sent to stable for 4.14. I can queue those up and do
it,
or if you want to you can do it as well. Let me know what you prefer!
On Tue, Mar 06, 2018 at 04:23:24PM -0800, Derrick, Jonathan wrote:
> This looks correct.
>
> Adding my Ack unless Scott has objections
>
> Acked-by: Jonathan Derrick
Reviewed-by: Scott Bauer
Nice catch Jonas! Sorry you had to resend, my message filtering was a little
too agr
> > +config DM_UN_STRIPE
> > + tristate "Transpose IO to individual drives on a raid device"
> > + depends on BLK_DEV_DM
> > + ---help---
> > + Enable this feature if you with to unstripe I/O on a RAID 0
> > + device to the respective drive. If your hardware has physical
-off-by: Scott Bauer
Acked-by: Keith Busch
---
drivers/md/Kconfig | 10 +++
drivers/md/Makefile | 1 +
drivers/md/dm-unstripe.c | 204 +++
3 files changed, 215 insertions(+)
create mode 100644 drivers/md/dm-unstripe.c
diff --git a/drivers
Signed-off-by: Scott Bauer
---
Documentation/device-mapper/dm-unstripe.txt | 130
1 file changed, 130 insertions(+)
create mode 100644 Documentation/device-mapper/dm-unstripe.txt
diff --git a/Documentation/device-mapper/dm-unstripe.txt
b/Documentation/device
Change log:
v3->v4:
Addressed comments from Randy. Modified documentation to be clearer,
and fixed small off by one in bounds checking in constructor.
v2->v3:
1) Renamed variables in-code to reflect correct terminology with respect
to the dm-stripe target.
2) Fixed a __must_check missing
[snip]
On Wed, Dec 13, 2017 at 04:11:44PM -0800, Randy Dunlap wrote:
>
> >=
>
Thanks, good catch.
> > + tot_sec = i_size_read(bbdev->bd_inode) >> SECTOR_SHIFT;
> > + mod = tot_sec % target->chunk_sectors;
>
> Did you build this on 32-bit also? Is th
On Wed, Dec 13, 2017 at 04:18:06PM -0800, Randy Dunlap wrote:
> Use ASCII characters ___ or ---, not whatever those bottom block characters
> are.
Argh, sorry, I removed those for an internal review but forgot to remove them
here.
>
> > +
> > +The purpose of this unstriping is to provide
-off-by: Scott Bauer
Acked-by: Keith Busch
---
drivers/md/Kconfig | 10 +++
drivers/md/Makefile | 1 +
drivers/md/dm-unstripe.c | 204 +++
3 files changed, 215 insertions(+)
create mode 100644 drivers/md/dm-unstripe.c
diff --git a/drivers
Changes from v2->v3:
1) Renamed variables in-code to reflect correct terminology with respect
to the dm-stripe target.
2) Fixed a __must_check missing check in the constructor.
3) Used correct types for working with sector remaping.
3) Fixed documentation to reflect the correct termonolog
Signed-off-by: Scott Bauer
---
Documentation/device-mapper/dm-unstripe.txt | 130
1 file changed, 130 insertions(+)
create mode 100644 Documentation/device-mapper/dm-unstripe.txt
diff --git a/Documentation/device-mapper/dm-unstripe.txt
b/Documentation/device
On Tue, Dec 12, 2017 at 01:10:13PM -0500, Mike Snitzer wrote:
> On Mon, Dec 11 2017 at 11:00am -0500,
> Scott Bauer wrote:
>
> OK, but I'm left wondering: why doesn't the user avoid striping across
> the cores?
>
> Do the Intel NVMe drives not provide the ability
V1->v2 Changes:
1) Fixed up some spelling errors in documentation.
2) Cleaned up some variable names to something more appropriate.
Signed-off-by: Scott Bauer
---
Documentation/device-mapper/dm-unstripe.txt | 82 +
1 file changed, 82 insertions(+)
create mode 100644 Documentation/device-mapper/dm-unstripe.txt
diff --git a/Documentation/device-mapper/dm-unstripe.txt
b/Documentation/device-mapper
writes and I/O on opposite cores have lower completion times,
and better tail latencies.
Signed-off-by: Scott Bauer
---
drivers/md/Kconfig | 10 +++
drivers/md/Makefile | 1 +
drivers/md/dm-unstripe.c | 197 +++
3 files changed, 208 insertions
Signed-off-by: Scott Bauer
---
Documentation/device-mapper/dm-unstripe.txt | 82 +
1 file changed, 82 insertions(+)
create mode 100644 Documentation/device-mapper/dm-unstripe.txt
diff --git a/Documentation/device-mapper/dm-unstripe.txt
b/Documentation/device-mapper
writes and I/O on opposite cores have lower completion times,
and better tail latencies.
Signed-off-by: Scott Bauer
---
drivers/md/Kconfig | 10 +++
drivers/md/Makefile | 1 +
drivers/md/dm-unstripe.c | 197 +++
3 files changed, 208 insertions
He is no longer working on storage.
Signed-off-by: Scott Bauer
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index af0cb69f6a3e..5c0864d7d7ad 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12052,7 +12052,6 @@ F: drivers/mmc/host/sdhci-spear.c
}
>
> +static bool response_token_matches(const struct opal_resp_tok *token, u8
> match)
> +{
> + if (IS_ERR_OR_NULL(token) ||
> + token->type != OPAL_DTA_TOKENID_TOKEN ||
> + token->pos[0] != match)
> + return false;
> + return true;
> +}
> +
This is sorta pedantic but from my reading of the code token can never be null.
It will
either be a valid pointer or ERR_PTR(-EINVAL), but never null.
So maybe change this to IS_ERR(token) etc. Other than that little nit:
Reviewed-by: Scott Bauer
On Wed, Feb 15, 2017 at 12:42:08PM -0700, Jon Derrick wrote:
> Add a buffer size check against discovery and response header lengths
> before we loop over their buffers.
>
> Signed-off-by: Jon Derrick
Reviewed-by: Scott Bauer
On Wed, Feb 15, 2017 at 12:42:06PM -0700, Jon Derrick wrote:
> The short atom parser can return an errno from decoding but does not
> currently return the error as a signed value. Convert all of the parsers
> to ssize_t.
>
> Signed-off-by: Jon Derrick
Reviewed-by: Scott Bauer
On Wed, Feb 15, 2017 at 12:38:53PM -0700, Jon Derrick wrote:
> Add a buffer size check against discovery and response header lengths
> before we loop over their buffers.
>
> Signed-off-by: Jon Derrick
> ---
> block/sed-opal.c | 35 +--
> 1 file changed, 21 inserti
The IOC_OPAL_ACTIVATE_LSP took the wrong strcure which would
give us the wrong size when using _IOC_SIZE, switch it to the
right structure.
Fixes: 058f8a2 ("Include: Uapi: Add user ABI for Sed/Opal")
Signed-off-by: Scott Bauer
---
include/uapi/linux/sed-opal.h | 2 +-
1 file
_IOC_SIZE()
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 133 ---
drivers/nvme/host/core.c | 3 +-
include/linux/sed-opal.h | 4 +-
3 files ch
Signed-off-by: Scott Bauer
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e325373..b983b25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11094,7 +11094,7 @@ SECURE ENCRYPTING DEVICE (SED) OPAL DRIVER
M: Scott Bauer
M
On Mon, Feb 13, 2017 at 04:30:36PM +, David Laight wrote:
> From: Scott Bauer Sent: 13 February 2017 16:11
> > When CONFIG_KASAN is enabled, compilation fails:
> >
> > block/sed-opal.c: In function 'sed_ioctl':
> > block/sed-opal.c:2447:1: error: the fr
esOn Mon, Feb 13, 2017 at 09:11:09AM -0700, Scott Bauer wrote:
> Signed-off-by: Scott Bauer
> ---
> block/sed-opal.c | 6 --
> drivers/nvme/host/core.c | 3 ++-
> include/linux/sed-opal.h | 4 ++--
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 6 --
drivers/nvme/host/core.c | 3 ++-
include/linux/sed-opal.h | 4 ++--
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/sed-opal.c b/block/sed-opal.c
index bf1406e..2448d4a 100644
--- a/block/sed-opal.c
+++ b
the IOW for the IOC_OPAL_ACTIVATE_LSP took the wrong strcure which
would give us the wrong size when using _IOC_SIZE, switch it to the
right structure.
Fixes: 058f8a2 ("Include: Uapi: Add user ABI for Sed/Opal")
Signed-off-by: Scott Bauer
---
include/uapi/linux/sed-opal.h | 2
So we have a few patches here, they're pretty small. First patch changes
the sed-opal ioctl function parameters to take a void __user* instead of
an unsigned long, this required a small cast in the nvme driver.
Patch 2 is a UAPI fixup for the IOW to make an ioctl
the right size. Patch 3 fixes a com
_IOC_SIZE()
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 130 +++
1 file changed, 45 insertions(+), 85 deletions(-)
diff --git a/block/sed-opal.
Signed-off-by: Scott Bauer
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e325373..b983b25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11094,7 +11094,7 @@ SECURE ENCRYPTING DEVICE (SED) OPAL DRIVER
M: Scott Bauer
M
_IOC_SIZE()
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 132 ---
1 file changed, 48 insertions(+), 84 deletions(-)
diff --git a/block/sed-opal.
the IOW for the IOC_OPAL_ACTIVATE_LSP took the wrong strcure which
would give us the wrong size when using _IOC_SIZE, switch it to the
right structure.
Fixes: 058f8a2 ("Include: Uapi: Add user ABI for Sed/Opal")
Signed-off-by: Scott Bauer
---
include/uapi/linux/sed-opal.h | 2
changes from v3->v4:
Changed manual kzalloc + copy from user to memdup_user.
This small series fixes a small ABI issue when using the _IOC_SIZE
with the Activate Locking SP ioctl. I had put the wrong structure
in the IOW macro in the uapi header which caused issues when trying
to copy in the cont
On Fri, Feb 10, 2017 at 09:01:23AM +0100, Arnd Bergmann wrote:
> On Thursday, February 9, 2017 10:20:01 AM CET Scott Bauer wrote:
> > When CONFIG_KASAN is enabled, compilation fails:
> >
> > block/sed-opal.c: In function 'sed_ioctl':
> > block/sed-opal.c:
e0;136;0csOn Thu, Feb 09, 2017 at 11:24:58AM -0700, Jens Axboe wrote:
> On 02/09/2017 10:45 AM, Scott Bauer wrote:
> > On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote:
> >> From: Scott Bauer
> >>> Sent: 09 February 2017 17:20
> >>> It may
On Thu, Feb 09, 2017 at 05:43:20PM +, David Laight wrote:
> From: Scott Bauer
> > Sent: 09 February 2017 17:20
> > It may be too late to change anyhting in the uapi header. When we
> > switched over to using IOC_SIZE I found a bug where I had switched
> > up a str
_IOC_SIZE()
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 134 +--
1 file changed, 50 insertions(+), 84 deletions(-)
diff --git a/block/sed-opal.
the IOW for the IOC_OPAL_ACTIVATE_LSP took the wrong strcure which
would give us the wrong size when using _IOC_SIZE, switch it to the
right structure.
Fixes: 058f8a2 ("Include: Uapi: Add user ABI for Sed/Opal")
Signed-off-by: Scott Bauer
---
include/uapi/linux/sed-opal.h | 2
It may be too late to change anyhting in the uapi header. When we
switched over to using IOC_SIZE I found a bug where I had switched
up a structure in one of the series from v4 to v5 but never changed
the structure in the IOW. The structure that was in there was to small
so when we kzalloc on it we
oversized stack frame size.
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 187 ++-
1 file changed, 102 insertions(+), 85 deletions(-)
diff --git a/bloc
oversized stack frame size.
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reported-by: Arnd Bergmann
Signed-off-by: Scott Bauer
---
block/sed-opal.c | 187 ++-
1 file changed, 102 insertions(+), 85 deletions(-)
diff --git a/bloc
future we will have in-kernel callers and I don't want to have to do any
get_fs(KERNEL_DS) wizardry.
Instead I think we can use a union to lessen the stack burden. I tested this
patch just now
with config_ksasan and was able to build.
>From dfa6a2c842a6e45cab198c9058e753835a81521e Mon Sep
On Wed, Feb 08, 2017 at 02:58:28PM -0700, Scott Bauer wrote:
> On Wed, Feb 08, 2017 at 10:15:28PM +0100, Arnd Bergmann wrote:
> > When CONFIG_KASAN is in use, the sed_ioctl function uses unusually large
> > stack,
> > as each possible ioctl argument gets its own st
On Sun, Dec 25, 2016 at 03:15:53PM +0100, Jethro Beekman wrote:
> On 19-12-16 20:35, Scott Bauer wrote:
> > diff --git a/include/linux/sed.h b/include/linux/sed.h
> >
> > +/*
> > + * These constant values come from:
> > + * TCG Storage Architecture Core Spec v2.01
On Sun, Dec 25, 2016 at 03:15:52PM +0100, Jethro Beekman wrote:
> On 19-12-16 20:35, Scott Bauer wrote:
> > @@ -1796,6 +1797,13 @@ static void nvme_reset_work(struct work_struct *work)
> > if (result)
> > goto out;
> >
> > + result = nvme_opal_i
> > +
> > +int fdev_sed_ioctl(struct file *filep, unsigned int cmd,
> > + unsigned long arg)
> > +{
> > + struct sed_key key;
> > + struct sed_context *sed_ctx;
> > +
> > + if (!capable(CAP_SYS_ADMIN))
> > + return -EACCES;
> > +
> > + if (!filep->f_sedctx || !filep->
On Tue, Dec 20, 2016 at 07:46:39AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 20, 2016 at 10:49:16AM -0500, Keith Busch wrote:
> > On Mon, Dec 19, 2016 at 10:17:44PM -0800, Christoph Hellwig wrote:
> > > As far as I can tell Security Send / Receive has always been intended to
> > > apply to the
On 12/20/2016 08:46 AM, Christoph Hellwig wrote:
> On Tue, Dec 20, 2016 at 10:49:16AM -0500, Keith Busch wrote:
>> On Mon, Dec 19, 2016 at 10:17:44PM -0800, Christoph Hellwig wrote:
>>> As far as I can tell Security Send / Receive has always been intended to
>>> apply to the whole controller, eve
On Mon, Dec 19, 2016 at 04:59:54PM -0500, Keith Busch wrote:
> On Mon, Dec 19, 2016 at 12:35:48PM -0700, Scott Bauer wrote:
> > +static int nvme_sec_submit(struct nvme_ctrl *ctrl, u16 spsp, u8 secp,
> > + void *buffer, size_t len, u8 opcode)
> > +{
> &
This patch adds the definitions and structures for the SED
Opal code.
Signed-off-by: Scott Bauer
Signed-off-by: Rafael Antognolli
---
include/linux/sed-opal.h | 38 +
include/linux/sed.h | 76 ++
include/uapi/linux/sed-opal.h | 94
This patch implements the necessary logic to bring an Opal
enabled drive out of a factory-enabled into a working
Opal state.
This patch set also enables logic to save a password to
be replayed during a resume from suspend.
Signed-off-by: Scott Bauer
Signed-off-by: Rafael Antognolli
---
lib
Adds a new sed_context pointer to file struct, for char devs who wish
to suppor SED.
Adds ioctl handling code.
Signed-off-by: Scott Bauer
Signed-off-by: Rafael Antognolli
---
fs/ioctl.c | 3 +++
include/linux/fs.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/fs/ioctl.c b/fs
This patch implements the necessary logic to unlock a SED
enabled device coming back from an S3.
The patch also implements the necessary logic to allocate the
appropriate opal_dev structures to support the OPAL protocol.
Signed-off-by: Scott Bauer
Signed-off-by: Rafael Antognolli
---
drivers
Signed-off-by: Scott Bauer
Signed-off-by: Rafael Antognolli
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f6eb97b..76d542c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11051,6 +11051,16 @@ L: linux-...@vger.kernel.org
S
All commands are exported through the Fs ioctl.
Scott Bauer (5):
include: Add definitions for sed
lib: Add Sed-opal library
fs: Wire up SED/Opal to ioctl
nvme: Implement resume_from_suspend and SED Allocation code.
Maintainers: Add Information for SED Opal library
MAINTAINERS
On Wed, Nov 30, 2016 at 12:35:07PM -0600, Josh Poimboeuf wrote:
> On Tue, Nov 29, 2016 at 11:13:01AM -0700, Scott Bauer wrote:
> > This is super easy to repro ontop of 4.9-rc7:
> > run pm-suspend and it hits every time
> >
&
This is super easy to repro ontop of 4.9-rc7:
run pm-suspend and it hits every time
[ 968.667086]
==
[ 968.667091] BUG: KASAN: stack-out-of-bounds in
unwind_get_return_address+0x11d/0x130 at addr 8803867d7878
[ 968.667092] R
This patch validates the num_values parameter from userland during
the HIDIOCGUSAGES and HIDIOCSUSAGES commands. Previously, if the
report id was set to HID_REPORT_ID_UNKNOWN, we would fail to
validate the num_values parameter leading to a heap overflow.
Signed-off-by: Scott Bauer
---
drivers
okie calculation from using restored regs->sp to
using frame pointer from before restoration.
v1->v2
Miscellaneous nits and code cleanup.
Scott Bauer (4):
SROP Mitigation: Architecture independent code for signal cookies
x86: SROP Mitigation: Implement Signal
Balasubramanian
Signed-off-by: Scott Bauer
Signed-off-by: Scott Bauer
---
arch/x86/ia32/ia32_signal.c | 65 +++---
arch/x86/include/asm/fpu/signal.h | 2 +
arch/x86/kernel/fpu/signal.c | 10 +
arch/x86/kernel/signal.c | 83
This patch adds a sysctl argument to disable SROP protection.
Cc: Abhiram Balasubramanian
Signed-off-by: Scott Bauer
Signed-off-by: Scott Bauer
---
include/linux/signal.h | 1 +
kernel/signal.c| 13 +++--
kernel/sysctl.c| 8
3 files changed, 20 insertions
1 - 100 of 108 matches
Mail list logo
