[PATCH v2] media: rkisp1: rkisp1-params.c: Fix typos

s/when the camera active/when the camera is active/ s/thus not isr protection/therefore there is no need to acquire a lock/ Signed-off-by: Sebastian Fricke --- drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] media: rkisp1: rkisp1-params.c: Fix typos

s/when the camera active/when the camera is active/ s/thus not isr protection/thus no ISR protection/ Signed-off-by: Sebastian Fricke --- drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip

[PATCH] media: rkisp1: rksip1-capture.c: Improve comments and fix typos

; with the full word buffer, the abbreviation 'config' with the verb configure, and 'regs' with registers. The goal of this change is to ease the reading flow of the comment. Signed-off-by: Sebastian Fricke --- Side-note: I also believe there should be a description for the

Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

Hey Joe, On 18.04.2021 00:09, Joe Perches wrote: On Sun, 2021-04-18 at 06:08 +, Sebastian Fricke wrote: Remove a redundant space to improve the quality of the comment. I think this patch is not useful. It's not redundant. Thank you, I actually found this pattern a few more times

[PATCH] base: power: runtime.c: Remove a unnecessary space

Remove a redundant space to improve the quality of the comment. Signed-off-by: Sebastian Fricke --- Side-note: I found this while reading the code, I don't believe it is important but I thought it doesn't hurt to fix it. --- drivers/base/power/runtime.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v2 0/6] Support second Image Signal Processor on rk3399

: Sebastian Fricke Greetings, Sebastian On 10.02.2021 12:10, Heiko Stuebner wrote: The rk3399 has two ISPs and right now only the first one is usable. The second ISP is connected to the TXRX dphy on the soc. The phy of ISP1 is only accessible through the DSI controller's io-memory, so this s

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

Hey Heiko, On 11.02.2021 15:42, Heiko Stübner wrote: Hi Sebastian, Am Donnerstag, 11. Februar 2021, 06:25:15 CET schrieb Sebastian Fricke: Hey Heiko, On 10.02.2021 12:15, Heiko Stübner wrote: >Hi Sebastian, > >Am Freitag, 5. Februar 2021, 15:55:56 CET schrieb Heiko Stübner: >&g

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

!enable) +return; + if (gate->lock) spin_lock_irqsave(gate->lock, flags); else Am Freitag, 5. Februar 2021, 09:15:47 CET schrieb Heiko Stübner: > Hi Sebastian, > > Am Freitag, 5. Februar 2021, 07:43:35 CET schrieb Sebastian Fricke: > > On 03.02.2021 20:54, Heiko

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

Hey Heiko, On 03.02.2021 20:54, Heiko Stübner wrote: Hi Sebastian, Am Mittwoch, 3. Februar 2021, 19:14:22 CET schrieb Sebastian Fricke: Hey Heiko, I have tested your patch set on my nanoPC-T4, here is a complete log with: - relevant kernel log entries - system information - media ctl output

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

same time using the libcamera cam command. I would like to thank you a lot for making this possible. If you like to you can add: Tested-by: Sebastian Fricke On 02.02.2021 15:56, Heiko Stuebner wrote: The rk3399 has two ISPs and right now only the first one is usable. The second ISP is connected to

[PATCH] include/linux/miscdevice.h - Fix typo/grammar

Improve the clarity and grammar of descriptive comment on top of the minor number assignments. Fix a typo within 2 comments for macros. s/This helps in eleminating of boilerplate code. /This helps to eliminate boilerplate code./ Signed-off-by: Sebastian Fricke --- include/linux/miscdevice.h