Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

Johannes Thumshirn wrote: > Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running > into the BUG_ON() in scsi_target_reap(). > > This intermediate state is only valid in the path from scsi_remove_target() to > scsi_target_destroy() indicating this target is going to be remove

Re: [PATCH 2/3] lpfc: fix misleading indentation

he code > to be misindented in the first place. > > Signed-off-by: Arnd Bergmann > Fixes: 549e55cd2a1b ("[SCSI] lpfc 8.2.2 : Fix locking around HBA's port_list") > --- > drivers/scsi/lpfc/lpfc_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Sebastian Herbszt

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

ort of refactoring. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Sebastian Herbszt

Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

Saurabh Sengar wrote: > replacing kmalloc and memset by a single call of kzalloc > > Signed-off-by: Saurabh Sengar > --- > v2 : I didn't got any response for my initial patch, > I am sending it again on top of latest kernel(today's) > > drivers/scsi/lpfc/lpfc_els.c | 3 +-- > 1 file changed, 1

Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

> rdp_context->ndlp = lpfc_nlp_get(ndlp); > rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id; Reviewed-by: Sebastian Herbszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

Johannes Thumshirn wrote: > Sebastian Herbszt writes: > > > Johannes Thumshirn wrote: > >> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, > >> execution > >> continues normally and mp gets kfree()d. > >> > >> If the

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

Johannes Thumshirn wrote: > If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution > continues normally and mp gets kfree()d. > > If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the > error label where lpfc_mbuf_free() is called with mp->virt and mp->

[PATCH] MAINTAINERS: fcoe-devel is moderated

The fcoe-devel list is moderated for non-subscribers. Signed-off-by: Sebastian Herbszt --- diff -urp a/MAINTAINERS b/MAINTAINERS --- a/MAINTAINERS 2015-07-26 00:15:54.296522570 +0200 +++ b/MAINTAINERS 2015-08-05 00:45:05.251859853 +0200 @@ -4160,7 +4160,7 @@ F:drivers

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

I wrote: > Alexey Kardashevskiy wrote: > > On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: > > > James Smart wrote: > > >> > > >> Reviewed-By: James Smart > > >> > > >> > > >> Alexey, Sebastian, > > >> >

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

Alexey Kardashevskiy wrote: > On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: > > James Smart wrote: > >> > >> Reviewed-By: James Smart > >> > >> > >> Alexey, Sebastian, > >> > >> Yes - this section needs to be reverted.

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

James Smart wrote: > > Reviewed-By: James Smart > > > Alexey, Sebastian, > > Yes - this section needs to be reverted. This patch is good. > > -- james s Reviewed-by: Sebastian Herbszt Sebastian -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

Alexey Kardashevskiy wrote: > This reverts 4fbdf9cb is breaks LPFC on POWER7 machine, big endian kernel. > > This is the hardware used for verification: > 0005:01:00.0 Fibre Channel [0c04]: Emulex Corporation Saturn-X: LightPulse > Fibre Channel Host Adapter [10df:f100] (rev 03) > 0005:01:00.1 Fi

blk-mq: should elv_iosched_store return ENXIO/EINVAL?

Hello, setting an invalid elevator without blk-mq results in an error: # cat /sys/block/sda/queue/scheduler noop deadline [cfq] # echo foo > /sys/block/sda/queue/scheduler -bash: echo: write error: Invalid argument # dmesg [ 328.767088] elevator: type foo not found [ 328.767097] elevator: switc