Re: [PATCH 1/2] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 03:29:38PM +0800, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27XX series PMICs > fuel gauge unit device, which is used to calculate the battery capacity. > > Signed-off-by: Baolin Wang > --- >

Re: [PATCH v3 1/3] power: supply: max8998-charger: Fix platform data retrieval

2018-09-16 Thread Sebastian Reichel
Hi, On Tue, Jul 17, 2018 at 06:05:07PM +0200, Paweł Chmiel wrote: > From: Tomasz Figa > > Since the max8998 MFD driver supports instantiation by DT, platform data > retrieval is handled in MFD probe and cell drivers should get use > the pdata field of max8998_dev struct to obtain them. > >

Re: [PATCH 1/2] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 03:29:38PM +0800, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27XX series PMICs > fuel gauge unit device, which is used to calculate the battery capacity. > > Signed-off-by: Baolin Wang > --- >

Re: [PATCH v3 1/3] power: supply: max8998-charger: Fix platform data retrieval

2018-09-16 Thread Sebastian Reichel
Hi, On Tue, Jul 17, 2018 at 06:05:07PM +0200, Paweł Chmiel wrote: > From: Tomasz Figa > > Since the max8998 MFD driver supports instantiation by DT, platform data > retrieval is handled in MFD probe and cell drivers should get use > the pdata field of max8998_dev struct to obtain them. > >

Re: [PATCH] power_supply: sysfs: ratelimit property read error message

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 07:48:30PM -0500, David Lechner wrote: > This adds ratelimiting to the message that is printed when reading a > power supply property via sysfs returns an error. This will prevent > userspace applications from unintentionally dDOSing the system by > continuosuly

Re: [PATCH v2 0/3] power: supply: cros: add support for dedicated port and expose connected ports

2018-09-16 Thread Sebastian Reichel
Hi, On Fri, Aug 10, 2018 at 03:13:46PM +0200, Fabien Parent wrote: > Dear all, > > This patch series adds support for an optional dedicated port > to the ChromeOS power supply driver and adds a new property that expose > when a power supply is connected. The series was tested on ChromeOS "Fizz"

Re: [PATCH 0/6] shutdown procedure verification for SAMA5D2

2018-09-16 Thread Sebastian Reichel
Hi, On Thu, Aug 30, 2018 at 02:50:05PM +0300, Claudiu Beznea wrote: > Hi, > > Patch 1 from this series implement a fix for shutdown procedure > for SAMA5D2. > > The rest of the patch are improvements as follows: > patch 2 - use only one function for poweroff > patches 3-6 - cosmetic

Re: [PATCH] power_supply: sysfs: ratelimit property read error message

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 07:48:30PM -0500, David Lechner wrote: > This adds ratelimiting to the message that is printed when reading a > power supply property via sysfs returns an error. This will prevent > userspace applications from unintentionally dDOSing the system by > continuosuly

Re: [PATCH v2 0/3] power: supply: cros: add support for dedicated port and expose connected ports

2018-09-16 Thread Sebastian Reichel
Hi, On Fri, Aug 10, 2018 at 03:13:46PM +0200, Fabien Parent wrote: > Dear all, > > This patch series adds support for an optional dedicated port > to the ChromeOS power supply driver and adds a new property that expose > when a power supply is connected. The series was tested on ChromeOS "Fizz"

Re: [PATCH 0/6] shutdown procedure verification for SAMA5D2

2018-09-16 Thread Sebastian Reichel
Hi, On Thu, Aug 30, 2018 at 02:50:05PM +0300, Claudiu Beznea wrote: > Hi, > > Patch 1 from this series implement a fix for shutdown procedure > for SAMA5D2. > > The rest of the patch are improvements as follows: > patch 2 - use only one function for poweroff > patches 3-6 - cosmetic

Re: [PATCH v4 0/4] Add the BQ25896 charger IC

2018-08-30 Thread Sebastian Reichel
Hi, On Tue, Jul 31, 2018 at 11:49:05AM -0600, Angus Ainslie (Purism) wrote: > Changes since v3: > > Corrected reviewed-by tags. > Fix typos. > Clarify desscriptions of patches. > > Changes since v2: > > Remove additional un-used table entries. > Use the exsisting compitble string for the new

Re: [PATCH v4 0/4] Add the BQ25896 charger IC

2018-08-30 Thread Sebastian Reichel
Hi, On Tue, Jul 31, 2018 at 11:49:05AM -0600, Angus Ainslie (Purism) wrote: > Changes since v3: > > Corrected reviewed-by tags. > Fix typos. > Clarify desscriptions of patches. > > Changes since v2: > > Remove additional un-used table entries. > Use the exsisting compitble string for the new

Re: [PATCH 2/2] power: supply: Add Spreadtrum SC2731 charger support

2018-08-30 Thread Sebastian Reichel
Hi, On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote: > >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info) > >> +{ > >> + int ret; > >> + > >> + /* Enable charger module */ > >> + ret = regmap_update_bits(info->regmap, SC2731_MODULE_EN1, > >> +

Re: [PATCH 2/2] power: supply: Add Spreadtrum SC2731 charger support

2018-08-30 Thread Sebastian Reichel
Hi, On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote: > >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info) > >> +{ > >> + int ret; > >> + > >> + /* Enable charger module */ > >> + ret = regmap_update_bits(info->regmap, SC2731_MODULE_EN1, > >> +

Re: [PATCH] power: reset: syscon-poweroff: Replace mdelay() with msleep() in syscon_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:50:29PM +0800, Jia-Ju Bai wrote: > syscon_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. >

Re: [PATCH] power: reset: syscon-poweroff: Replace mdelay() with msleep() in syscon_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:50:29PM +0800, Jia-Ju Bai wrote: > syscon_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. >

Re: [PATCH] power: reset: piix4-poweroff: Replace mdelay() with msleep() and usleep_range() in piix4_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:48:38PM +0800, Jia-Ju Bai wrote: > piix4_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep() and usleep_range(). > > This is found by a static analysis tool named DCNS

Re: [PATCH] power: reset: piix4-poweroff: Replace mdelay() with msleep() and usleep_range() in piix4_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:48:38PM +0800, Jia-Ju Bai wrote: > piix4_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep() and usleep_range(). > > This is found by a static analysis tool named DCNS

Re: [PATCH] power: reset: gpio-poweroff: Replace mdelay() with msleep() in gpio_poweroff_do_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:46:14PM +0800, Jia-Ju Bai wrote: > gpio_poweroff_do_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by

Re: [PATCH] power: reset: gpio-poweroff: Replace mdelay() with msleep() in gpio_poweroff_do_poweroff()

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Jul 30, 2018 at 09:46:14PM +0800, Jia-Ju Bai wrote: > gpio_poweroff_do_poweroff() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by

Re: [PATCH][V2] power: supply: cros_usbpd: remove unused pointer 'dev'

2018-08-29 Thread Sebastian Reichel
Hi, On Wed, Aug 29, 2018 at 03:51:06PM +0100, Colin King wrote: > From: Colin Ian King > > Pointer 'dev' is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > variable 'dev' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH][V2] power: supply: cros_usbpd: remove unused pointer 'dev'

2018-08-29 Thread Sebastian Reichel
Hi, On Wed, Aug 29, 2018 at 03:51:06PM +0100, Colin King wrote: > From: Colin Ian King > > Pointer 'dev' is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > variable 'dev' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH] power: supply: ab8500_fg: fix obsolete function

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Aug 27, 2018 at 06:49:15AM -0400, Ding Xiang wrote: > simple_strtoul is obsolete, and use kstrtoint instead > > Signed-off-by: Ding Xiang > --- Thanks, queued. -- Sebastian > drivers/power/supply/ab8500_fg.c | 21 +++-- > 1 file changed, 15 insertions(+), 6

Re: [PATCH] power: supply: ab8500_fg: fix obsolete function

2018-08-29 Thread Sebastian Reichel
Hi, On Mon, Aug 27, 2018 at 06:49:15AM -0400, Ding Xiang wrote: > simple_strtoul is obsolete, and use kstrtoint instead > > Signed-off-by: Ding Xiang > --- Thanks, queued. -- Sebastian > drivers/power/supply/ab8500_fg.c | 21 +++-- > 1 file changed, 15 insertions(+), 6

Re: [PATCH] power: supply: maxim: Add SPDX license identifiers

2018-08-29 Thread Sebastian Reichel
Hi, On Tue, Aug 07, 2018 at 06:21:06PM +0200, Krzysztof Kozlowski wrote: > Replace GPL v2.0 and v2.0+ license statements with SPDX license > identifiers. > > Signed-off-by: Krzysztof Kozlowski > --- Thanks, queued. -- Sebastian > drivers/power/supply/max14577_charger.c | 22

Re: [PATCH] power: supply: maxim: Add SPDX license identifiers

2018-08-29 Thread Sebastian Reichel
Hi, On Tue, Aug 07, 2018 at 06:21:06PM +0200, Krzysztof Kozlowski wrote: > Replace GPL v2.0 and v2.0+ license statements with SPDX license > identifiers. > > Signed-off-by: Krzysztof Kozlowski > --- Thanks, queued. -- Sebastian > drivers/power/supply/max14577_charger.c | 22

Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node lookup

2018-08-22 Thread Sebastian Reichel
0_charger: find associated phy by more > reliable means.") > Cc: stable # 4.2 > Cc: NeilBrown > Cc: Felipe Balbi > Cc: Sebastian Reichel > Signed-off-by: Johan Hovold > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/twl4030_

Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node lookup

2018-08-22 Thread Sebastian Reichel
0_charger: find associated phy by more > reliable means.") > Cc: stable # 4.2 > Cc: NeilBrown > Cc: Felipe Balbi > Cc: Sebastian Reichel > Signed-off-by: Johan Hovold > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/twl4030_

[GIT PULL] power-supply changes for 4.19

2018-08-21 Thread Sebastian Reichel
ower: gemini-poweroff: Avoid more spurious poweroffs Liu Xiang (1): power: supply: bq27xxx: Update comments Sameer Nanda (2): mfd: cros_ec: Add USBPD charger commands and struct definitions. power: supply: add cros-ec USBPD charger driver. Sebastian Reichel (3): Merge tag 'ib-mfd

[GIT PULL] power-supply changes for 4.19

2018-08-21 Thread Sebastian Reichel
ower: gemini-poweroff: Avoid more spurious poweroffs Liu Xiang (1): power: supply: bq27xxx: Update comments Sameer Nanda (2): mfd: cros_ec: Add USBPD charger commands and struct definitions. power: supply: add cros-ec USBPD charger driver. Sebastian Reichel (3): Merge tag 'ib-mfd

Re: Vibrations on Droid 4?

2018-08-02 Thread Sebastian Reichel
Hi, On Wed, Aug 01, 2018 at 08:58:24PM +0200, Pavel Machek wrote: > > > Yep, so I have two patches that make the device appear, but vibrations > > > still do not work for me. > > > > > > a) any ideas how to debug that / get them to work? > > > > Hmm no new ideas except I wonder if there is also

Re: Vibrations on Droid 4?

2018-08-02 Thread Sebastian Reichel
Hi, On Wed, Aug 01, 2018 at 08:58:24PM +0200, Pavel Machek wrote: > > > Yep, so I have two patches that make the device appear, but vibrations > > > still do not work for me. > > > > > > a) any ideas how to debug that / get them to work? > > > > Hmm no new ideas except I wonder if there is also

Re: [PATCH] fix vibrations on Droid 4

2018-08-02 Thread Sebastian Reichel
.dts > b/arch/arm/boot/dts/omap4-droid4-xt894.dts > index c27fc87..7b82179 100644 Reviewed-by: Sebastian Reichel -- Sebastian > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > @@ -646,15 +646,6 @@ > OMAP

Re: [PATCH] fix vibrations on Droid 4

2018-08-02 Thread Sebastian Reichel
.dts > b/arch/arm/boot/dts/omap4-droid4-xt894.dts > index c27fc87..7b82179 100644 Reviewed-by: Sebastian Reichel -- Sebastian > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts > @@ -646,15 +646,6 @@ > OMAP

Re: [PATCH 04/32] ARM: dts: omap3-gta04: fixes for tvout / venc

2018-07-25 Thread Sebastian Reichel
Hi, On Wed, Jul 25, 2018 at 08:58:36AM +0200, H. Nikolaus Schaller wrote: > port@1 { > - reg = <1>; > + reg = <0>; You should also update the node name. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 04/32] ARM: dts: omap3-gta04: fixes for tvout / venc

2018-07-25 Thread Sebastian Reichel
Hi, On Wed, Jul 25, 2018 at 08:58:36AM +0200, H. Nikolaus Schaller wrote: > port@1 { > - reg = <1>; > + reg = <0>; You should also update the node name. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-07-22 Thread Sebastian Reichel
Hi, On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote: > On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: > > It seems that a *break* is missing in order to avoid a fall-through. > > Otherwise, the calculation of *data* makes no sense. > > > > Addresses-Coverity-ID: 1271172

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-07-22 Thread Sebastian Reichel
Hi, On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote: > On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: > > It seems that a *break* is missing in order to avoid a fall-through. > > Otherwise, the calculation of *data* makes no sense. > > > > Addresses-Coverity-ID: 1271172

Re: [PATCH] power: supply: mark expected switch fall-throughs

2018-07-22 Thread Sebastian Reichel
Hi, On Tue, Jul 17, 2018 at 04:28:46PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1394724 ("Missing break in switch") > Addresses-Coverity-ID: 114958 ("Missing break

Re: [PATCH] power: supply: mark expected switch fall-throughs

2018-07-22 Thread Sebastian Reichel
Hi, On Tue, Jul 17, 2018 at 04:28:46PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1394724 ("Missing break in switch") > Addresses-Coverity-ID: 114958 ("Missing break

Re: [PATCH] power:ds2782:Fix description error

2018-07-22 Thread Sebastian Reichel
Hi Elicec, On Wed, Jul 18, 2018 at 03:20:33PM +, elicec wrote: > After add support for ds2786 battery gas gauge,the description > didn't update. fix it. > > Signed-off-by: elicec > --- Thanks for the patch. The change looks good, but the subject of the patch should be prefixed with "power:

Re: [PATCH] power:ds2782:Fix description error

2018-07-22 Thread Sebastian Reichel
Hi Elicec, On Wed, Jul 18, 2018 at 03:20:33PM +, elicec wrote: > After add support for ds2786 battery gas gauge,the description > didn't update. fix it. > > Signed-off-by: elicec > --- Thanks for the patch. The change looks good, but the subject of the patch should be prefixed with "power:

Re: [PATCH 1/2] power: supply: lego_ev3_battery: Don't ignore iio_read_channel_processed() return value

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 03:19:43PM -0500, David Lechner wrote: > This changes the LEGO MINDSTORMS EV3 power supply driver to return an > error if iio_read_channel_processed() fails. > > Signed-off-by: David Lechner > --- Thanks, queued to power-supply's for-next branch. -- Sebastian >

Re: [PATCH 2/2] power: supply: lego_ev3_battery: fix Vce offset

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 03:19:44PM -0500, David Lechner wrote: > This fixes the value that accounts for the Vce of a transistor in the > LEGO MINDSTORMS EV3 power supply driver. The old value (200mV) was the > max value from the data sheet. After testing, the actual value has been > found to

Re: [PATCH 1/2] power: supply: lego_ev3_battery: Don't ignore iio_read_channel_processed() return value

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 03:19:43PM -0500, David Lechner wrote: > This changes the LEGO MINDSTORMS EV3 power supply driver to return an > error if iio_read_channel_processed() fails. > > Signed-off-by: David Lechner > --- Thanks, queued to power-supply's for-next branch. -- Sebastian >

Re: [PATCH 2/2] power: supply: lego_ev3_battery: fix Vce offset

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 03:19:44PM -0500, David Lechner wrote: > This fixes the value that accounts for the Vce of a transistor in the > LEGO MINDSTORMS EV3 power supply driver. The old value (200mV) was the > max value from the data sheet. After testing, the actual value has been > found to

Re: [PATCH v4 1/5] dt-bindings: w1: document generic onewire bindings

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 09:10:36AM -0600, Rob Herring wrote: > On Wed, Jul 18, 2018 at 6:40 AM Daniel Mack wrote: > > > > On Wednesday, July 11, 2018 05:01 PM, Rob Herring wrote: > > > On Fri, Jul 06, 2018 at 07:35:48AM +0200, Daniel Mack wrote: > > >> This patch adds a generic w1 bindings

Re: [PATCH v4 1/5] dt-bindings: w1: document generic onewire bindings

2018-07-22 Thread Sebastian Reichel
Hi, On Fri, Jul 20, 2018 at 09:10:36AM -0600, Rob Herring wrote: > On Wed, Jul 18, 2018 at 6:40 AM Daniel Mack wrote: > > > > On Wednesday, July 11, 2018 05:01 PM, Rob Herring wrote: > > > On Fri, Jul 06, 2018 at 07:35:48AM +0200, Daniel Mack wrote: > > >> This patch adds a generic w1 bindings

[DISCUSSION] spi multi chipselect support

2018-07-18 Thread Sebastian Reichel
Hi Mark, Some SPI slave devices have more than one chip select [0]. Rob suggested to use the following DT notation for this [1]: spi-controller { slave@0 { reg = <0>, <1>; }; }; I think this makes sense from a DT point of view, but this needs quite some changes in the SPI core.

[DISCUSSION] spi multi chipselect support

2018-07-18 Thread Sebastian Reichel
Hi Mark, Some SPI slave devices have more than one chip select [0]. Rob suggested to use the following DT notation for this [1]: spi-controller { slave@0 { reg = <0>, <1>; }; }; I think this makes sense from a DT point of view, but this needs quite some changes in the SPI core.

Re: [PATCH] dts/droid4: fix dts w.r.t. pwm

2018-07-16 Thread Sebastian Reichel
Hi, On Mon, Jul 16, 2018 at 09:10:48AM +0200, Pavel Machek wrote: > pwm node should not be under gpio6 node in the device tree. > > This fixes detection of the pwm on Droid 4. > > Signed-off-by: Pavel Machek Reviewed-by: Sebastian Reichel -- Sebastian > diff --g

Re: [PATCH] dts/droid4: fix dts w.r.t. pwm

2018-07-16 Thread Sebastian Reichel
Hi, On Mon, Jul 16, 2018 at 09:10:48AM +0200, Pavel Machek wrote: > pwm node should not be under gpio6 node in the device tree. > > This fixes detection of the pwm on Droid 4. > > Signed-off-by: Pavel Machek Reviewed-by: Sebastian Reichel -- Sebastian > diff --g

Re: Vibrations on Droid 4?

2018-07-11 Thread Sebastian Reichel
Hi, On Wed, Jul 11, 2018 at 06:27:39AM -0700, Tony Lindgren wrote: > * Pavel Machek [180711 08:05]: > > Hi! > > > > > > Its parent is gpio@4805d000 , and that one seems to be present. > > > > > > > > user@devuan:/sys/bus/platform/devices$ ls 4805d000.gpio > > > > driver

Re: Vibrations on Droid 4?

2018-07-11 Thread Sebastian Reichel
Hi, On Wed, Jul 11, 2018 at 06:27:39AM -0700, Tony Lindgren wrote: > * Pavel Machek [180711 08:05]: > > Hi! > > > > > > Its parent is gpio@4805d000 , and that one seems to be present. > > > > > > > > user@devuan:/sys/bus/platform/devices$ ls 4805d000.gpio > > > > driver

Re: [PATCH] power: supply: adp5061: Fix a couple off by ones

2018-07-11 Thread Sebastian Reichel
Hi, On Wed, Jul 11, 2018 at 10:58:13AM +0300, Dan Carpenter wrote: > We end up reading one element beyond the end of the adp5061_vmax[] array > here. > > Fixes: fe8e81b7e899 ("adp5061: New driver for ADP5061 I2C battery charger") > Signed-off-by: Dan Carpenter Thanks, queued. -- Sebastian >

Re: [PATCH] power: supply: adp5061: Fix a couple off by ones

2018-07-11 Thread Sebastian Reichel
Hi, On Wed, Jul 11, 2018 at 10:58:13AM +0300, Dan Carpenter wrote: > We end up reading one element beyond the end of the adp5061_vmax[] array > here. > > Fixes: fe8e81b7e899 ("adp5061: New driver for ADP5061 I2C battery charger") > Signed-off-by: Dan Carpenter Thanks, queued. -- Sebastian >

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Sebastian Reichel
Hi Peter, On Tue, Jul 10, 2018 at 04:47:02PM +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Reviewed-by: Sebastian Reichel -- Sebastian > MAINTAINERS | 2 +- > 1 file changed, 1 insertion

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Sebastian Reichel
Hi Peter, On Tue, Jul 10, 2018 at 04:47:02PM +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Reviewed-by: Sebastian Reichel -- Sebastian > MAINTAINERS | 2 +- > 1 file changed, 1 insertion

Re: Vibrations on Droid 4?

2018-07-10 Thread Sebastian Reichel
Hi, On Tue, Jul 10, 2018 at 03:30:40PM +0200, Pavel Machek wrote: > On Tue 2018-07-10 12:11:47, Sebastian Reichel wrote: > > On Tue, Jul 10, 2018 at 12:02:11AM +0200, Pavel Machek wrote: > > > > > Do you have vibrations on d4 working? > > > > > I

Re: Vibrations on Droid 4?

2018-07-10 Thread Sebastian Reichel
Hi, On Tue, Jul 10, 2018 at 03:30:40PM +0200, Pavel Machek wrote: > On Tue 2018-07-10 12:11:47, Sebastian Reichel wrote: > > On Tue, Jul 10, 2018 at 12:02:11AM +0200, Pavel Machek wrote: > > > > > Do you have vibrations on d4 working? > > > > > I

Re: Vibrations on Droid 4?

2018-07-10 Thread Sebastian Reichel
Hi, On Tue, Jul 10, 2018 at 12:02:11AM +0200, Pavel Machek wrote: > Hi! > > > > Do you have vibrations on d4 working? > > > I believe I have required drivers enabled, but no luck: > > > > > > user@devuan:/sys/bus/platform/drivers$ ls pwm-vibrator/ > > > bind uevent unbind > > >

Re: Vibrations on Droid 4?

2018-07-10 Thread Sebastian Reichel
Hi, On Tue, Jul 10, 2018 at 12:02:11AM +0200, Pavel Machek wrote: > Hi! > > > > Do you have vibrations on d4 working? > > > I believe I have required drivers enabled, but no luck: > > > > > > user@devuan:/sys/bus/platform/drivers$ ls pwm-vibrator/ > > > bind uevent unbind > > >

Re: [PATCH v4] driver core: add a debugfs entry to show deferred devices

2018-07-10 Thread Sebastian Reichel
sses. This can be error probe and has to be done in a ad-hoc > manner by everyone who needs to debug these kind of issues. > > Since the information is already known by the kernel, just show it to make > it easier to debug. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by:

Re: [PATCH v4] driver core: add a debugfs entry to show deferred devices

2018-07-10 Thread Sebastian Reichel
sses. This can be error probe and has to be done in a ad-hoc > manner by everyone who needs to debug these kind of issues. > > Since the information is already known by the kernel, just show it to make > it easier to debug. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by:

Re: Vibrations on Droid 4?

2018-07-09 Thread Sebastian Reichel
Hi, On Mon, Jul 09, 2018 at 10:15:35AM +0200, Pavel Machek wrote: > Do you have vibrations on d4 working? > I believe I have required drivers enabled, but no luck: > > user@devuan:/sys/bus/platform/drivers$ ls pwm-vibrator/ > bind uevent unbind > user@devuan:/sys/bus/platform/drivers$ ls

Re: Vibrations on Droid 4?

2018-07-09 Thread Sebastian Reichel
Hi, On Mon, Jul 09, 2018 at 10:15:35AM +0200, Pavel Machek wrote: > Do you have vibrations on d4 working? > I believe I have required drivers enabled, but no luck: > > user@devuan:/sys/bus/platform/drivers$ ls pwm-vibrator/ > bind uevent unbind > user@devuan:/sys/bus/platform/drivers$ ls

Re: [PATCH] power: supply: ltc2941-battery-gauge: Release device_node in ltc294x_i2c_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, May 08, 2018 at 10:16:31PM +0300, Alexey Khoroshilov wrote: > On 01.05.2018 15:39, Sebastian Reichel wrote: > > On Sun, Apr 29, 2018 at 01:35:55AM +0300, Alexey Khoroshilov wrote: > >> There is of_node_get(client->dev.of_node) in ltc294x_i2c_probe(), > >&g

Re: [PATCH] power: supply: ltc2941-battery-gauge: Release device_node in ltc294x_i2c_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, May 08, 2018 at 10:16:31PM +0300, Alexey Khoroshilov wrote: > On 01.05.2018 15:39, Sebastian Reichel wrote: > > On Sun, Apr 29, 2018 at 01:35:55AM +0300, Alexey Khoroshilov wrote: > >> There is of_node_get(client->dev.of_node) in ltc294x_i2c_probe(), > >&g

Re: [PATCH 0/2] power: generic-adc-battery: fix out of bounds write

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 26, 2018 at 03:28:28PM +0200, H. Nikolaus Schaller wrote: > This patch set addresses two bugs in the gab_probe() function which are > there since the first commit in 3.7-rc1: > > 1. there is an out of bounds write access by a miscalculated destination >address for the

Re: [PATCH 0/2] power: generic-adc-battery: fix out of bounds write

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 26, 2018 at 03:28:28PM +0200, H. Nikolaus Schaller wrote: > This patch set addresses two bugs in the gab_probe() function which are > there since the first commit in 3.7-rc1: > > 1. there is an out of bounds write access by a miscalculated destination >address for the

Re: [PATCH] power: supply: ab8500: stop using getnstimeofday64()

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 18, 2018 at 04:23:29PM +0200, Arnd Bergmann wrote: > getnstimeofday64() is deprecated in favor of the ktime_get() family. > > The direct replacement would be ktime_get_real_ts64(), but we only need > the seconds value, and it seems better to use boottime than real time > to avoid

Re: [PATCH] power: supply: ab8500: stop using getnstimeofday64()

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 18, 2018 at 04:23:29PM +0200, Arnd Bergmann wrote: > getnstimeofday64() is deprecated in favor of the ktime_get() family. > > The direct replacement would be ktime_get_real_ts64(), but we only need > the seconds value, and it seems better to use boottime than real time > to avoid

Re: [PATCH] power: remove possible deadlock when unregistering power_supply

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 25, 2018 at 09:51:48AM +0200, Benjamin Tissoires wrote: > If a device gets removed right after having registered a power_supply node, > we might enter in a deadlock between the remove call (that has a lock on > the parent device) and the deferred register work. > > Allow the

Re: [PATCH] power: remove possible deadlock when unregistering power_supply

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 25, 2018 at 09:51:48AM +0200, Benjamin Tissoires wrote: > If a device gets removed right after having registered a power_supply node, > we might enter in a deadlock between the remove call (that has a lock on > the parent device) and the deferred register work. > > Allow the

Re: [PATCH v4 3/5] w1: core: match sub-nodes of bus masters in devicetree

2018-07-06 Thread Sebastian Reichel
Hi Greg & Evgeniy, I suggest, that I take this patch and the DT bindings together with the power-supply changes, once the bindings have been reviewed by Rob (Herring). I will prepare an immutable branch, that can be pulled into w1 as needed. Are you fine with this? -- Sebastian On Fri, Jul 06,

Re: [PATCH v4 3/5] w1: core: match sub-nodes of bus masters in devicetree

2018-07-06 Thread Sebastian Reichel
Hi Greg & Evgeniy, I suggest, that I take this patch and the DT bindings together with the power-supply changes, once the bindings have been reviewed by Rob (Herring). I will prepare an immutable branch, that can be pulled into w1 as needed. Are you fine with this? -- Sebastian On Fri, Jul 06,

Re: [PATCH v4 5/5] power: supply: ds2760_battery: add devicetree probing

2018-07-06 Thread Sebastian Reichel
Hi, On Fri, Jul 06, 2018 at 07:35:52AM +0200, Daniel Mack wrote: > Add a matching table for devicetree probing, and optionally set the module > parameter variables from DT properties. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebast

Re: [PATCH v4 5/5] power: supply: ds2760_battery: add devicetree probing

2018-07-06 Thread Sebastian Reichel
Hi, On Fri, Jul 06, 2018 at 07:35:52AM +0200, Daniel Mack wrote: > Add a matching table for devicetree probing, and optionally set the module > parameter variables from DT properties. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebast

Re: [PATCH v4 4/5] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-07-06 Thread Sebastian Reichel
back. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebastian > drivers/power/supply/Kconfig | 2 +- > drivers/power/supply/ds2760_battery.c | 321 ++ > drivers/w1/slaves/Kconfig | 12 - > drivers/

Re: [PATCH v4 4/5] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-07-06 Thread Sebastian Reichel
back. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebastian > drivers/power/supply/Kconfig | 2 +- > drivers/power/supply/ds2760_battery.c | 321 ++ > drivers/w1/slaves/Kconfig | 12 - > drivers/

Re: [PATCH] power: supply: max1721x: fix spelling mistake "RSenese" -> "RSense"

2018-07-06 Thread Sebastian Reichel
Hi, On Sat, May 26, 2018 at 02:56:06PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_warn message text > > Signed-off-by: Colin Ian King > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] power: supply: max1721x: fix spelling mistake "RSenese" -> "RSense"

2018-07-06 Thread Sebastian Reichel
Hi, On Sat, May 26, 2018 at 02:56:06PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_warn message text > > Signed-off-by: Colin Ian King > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project

Re: [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project

Re: [PATCH] power: supply: tps65217: Switch to SPDX identifier.

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 05, 2018 at 12:00:21PM +0200, Enric Balletbo i Serra wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Enric Balletbo i Serra > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP

Re: [PATCH] power: supply: tps65217: Switch to SPDX identifier.

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 05, 2018 at 12:00:21PM +0200, Enric Balletbo i Serra wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Enric Balletbo i Serra > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP

Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:42PM -0700, Brian Norris wrote: > This compatible property was documented before the driver was renamed to > "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate > bq20z75->sbs rename to dt bindings")). The driver has continued to > support this

Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:42PM -0700, Brian Norris wrote: > This compatible property was documented before the driver was renamed to > "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate > bq20z75->sbs rename to dt bindings")). The driver has continued to > support this

Re: [PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:41PM -0700, Brian Norris wrote: > This driver was originally submitted for the TI BQ20Z75 battery IC > (commit a7640bfa10c5 ("power_supply: Add driver for TI BQ20Z75 gas gauge > IC")) and later renamed to express generic SBS support. While it's > mostly true that

Re: [PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:41PM -0700, Brian Norris wrote: > This driver was originally submitted for the TI BQ20Z75 battery IC > (commit a7640bfa10c5 ("power_supply: Add driver for TI BQ20Z75 gas gauge > IC")) and later renamed to express generic SBS support. While it's > mostly true that

Re: droid 4: connection refused from voltage_now

2018-07-06 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 09:52:38PM +0200, Pavel Machek wrote: > On Wed 2018-07-04 21:45:56, Ladislav Michl wrote: > > On Wed, Jul 04, 2018 at 07:11:56PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > I started to use droid 4 as my primary phone... so I have battery > > > monitor running

Re: droid 4: connection refused from voltage_now

2018-07-06 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 09:52:38PM +0200, Pavel Machek wrote: > On Wed 2018-07-04 21:45:56, Ladislav Michl wrote: > > On Wed, Jul 04, 2018 at 07:11:56PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > I started to use droid 4 as my primary phone... so I have battery > > > monitor running

Re: [PATCH v4 2/3] power: supply: add cros-ec USBPD charger driver.

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, May 02, 2018 at 05:44:17PM +0200, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > This driver gets various bits of information about what is connected to > USB PD ports from the EC and converts that into power_supply properties. > > Signed-off-by: Sameer Nanda >

Re: [PATCH v4 2/3] power: supply: add cros-ec USBPD charger driver.

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, May 02, 2018 at 05:44:17PM +0200, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > This driver gets various bits of information about what is connected to > USB PD ports from the EC and converts that into power_supply properties. > > Signed-off-by: Sameer Nanda >

Re: [GIT PULL] Immutable branch between MFD and Power? due for the v4.19 merge window

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 07:12:46AM +0100, Lee Jones wrote: > Apologies for the delay -- these two patches dropped from my radar. Thanks, merged. -- Sebastian > > Enjoy! > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > Linux 4.18-rc1 (2018-06-17

Re: [GIT PULL] Immutable branch between MFD and Power? due for the v4.19 merge window

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 07:12:46AM +0100, Lee Jones wrote: > Apologies for the delay -- these two patches dropped from my radar. Thanks, merged. -- Sebastian > > Enjoy! > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > Linux 4.18-rc1 (2018-06-17

[PATCHv2 0/2] Avoid firmware warning in imx-sdma

2018-07-04 Thread Sebastian Reichel
/20180628031332.ge21...@wotan.suse.de/ -- Sebastian Sebastian Reichel (2): firmware: add request_firmware_nowait_nowarn function dmaengine: imx-sdma: request firmware with FW_OPT_NO_WARN drivers/base/firmware_loader/main.c | 40 - drivers/dma/imx-sdma.c

[PATCHv2 1/2] firmware: add request_firmware_nowait_nowarn function

2018-07-04 Thread Sebastian Reichel
firmware). This is based on previous work from Rafał Miłecki . Signed-off-by: Sebastian Reichel --- drivers/base/firmware_loader/main.c | 40 - include/linux/firmware.h| 12 + 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/drivers/base

[PATCHv2 2/2] dmaengine: imx-sdma: request firmware with FW_OPT_NO_WARN

2018-07-04 Thread Sebastian Reichel
Request firmware with FW_OPT_NO_WARN. The driver works without the firmware by using the one supplied in ROM. There is already an info message, that informs about this. Signed-off-by: Sebastian Reichel --- drivers/dma/imx-sdma.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions

[PATCHv2 1/2] firmware: add request_firmware_nowait_nowarn function

2018-07-04 Thread Sebastian Reichel
firmware). This is based on previous work from Rafał Miłecki . Signed-off-by: Sebastian Reichel --- drivers/base/firmware_loader/main.c | 40 - include/linux/firmware.h| 12 + 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/drivers/base

<    5   6   7   8   9   10   11   12   13   14   >