't see any bugs which may causes kdump failure because
deadlocking/dynamic memory allocation don't happen in their write callbacks.
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c |4
include/linux/kmsg_dump.h |1 +
kernel/kexec.c|2 ++
3 files chan
see any bugs which may causes kdump failure because
deadlocking/dynamic memory allocation don't happen in their write callbacks.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
fs/pstore/platform.c |4
include/linux/kmsg_dump.h |1 +
kernel/kexec.c|2 ++
3
I confirmed that efi_pstore_read() and efi_pstore_erase() work correctly.
Please feel free to add
Tested-by: Seiji Aguchi
> -Original Message-
> From: Matt Fleming [mailto:matt.flem...@intel.com]
> Sent: Tuesday, April 30, 2013 7:28 AM
> To: Seiji Aguchi
> C
I confirmed that efi_pstore_read() and efi_pstore_erase() work correctly.
Please feel free to add
Tested-by: Seiji Aguchi seiji.agu...@hds.com
-Original Message-
From: Matt Fleming [mailto:matt.flem...@intel.com]
Sent: Tuesday, April 30, 2013 7:28 AM
To: Seiji Aguchi
Cc: linux
It worked with this fix.
Thanks!
Seiji
> -Original Message-
> From: Matt Fleming [mailto:matt.flem...@intel.com]
> Sent: Friday, April 26, 2013 10:55 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h...@zytor.com;
> mj...@srcf.ucam.org; tony
>Did you mount the efivarfs file system there?
Ah...
It worked by mounting efivarfs.
Thanks.
> -Original Message-
> From: Fleming, Matt [mailto:matt.flem...@intel.com]
> Sent: Friday, April 26, 2013 10:35 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; m
: Friday, April 26, 2013 5:56 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h...@zytor.com;
> mj...@srcf.ucam.org; tony.l...@intel.com; j...@ozlabs.org;
> t...@jklm.no; t...@linutronix.de; mi...@google.com;
> linux-tip-comm...@vger.kernel.org
> Su
] __efivar_entry_iter+0xcf/0x120
RSP 880194395ca8
CR2:
---[ end trace 1d19d659e0c71627 ]---
-Original Message-
From: Matt Fleming [mailto:matt.flem...@intel.com]
Sent: Friday, April 26, 2013 5:56 AM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h
Did you mount the efivarfs file system there?
Ah...
It worked by mounting efivarfs.
Thanks.
-Original Message-
From: Fleming, Matt [mailto:matt.flem...@intel.com]
Sent: Friday, April 26, 2013 10:35 AM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h
It worked with this fix.
Thanks!
Seiji
-Original Message-
From: Matt Fleming [mailto:matt.flem...@intel.com]
Sent: Friday, April 26, 2013 10:55 AM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h...@zytor.com;
mj...@srcf.ucam.org; tony.l...@intel.com; j
> -Original Message-
> From: Luis Henriques [mailto:luis.henriq...@canonical.com]
> Sent: Wednesday, April 10, 2013 8:18 AM
> To: Lingzhu Xiang
> Cc: Ben Hutchings; Seiji Aguchi; linux-kernel@vger.kernel.org;
> sta...@vger.kernel.org; kernel-t...@lists.ubuntu.com;
> -static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type,
> -int *count, struct timespec *timespec,
> -char **buf, struct pstore_info *psi)
> +struct pstore_read_data {
> + u64 *id;
> + enum pstore_type_id *type;
> +
-static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type,
-int *count, struct timespec *timespec,
-char **buf, struct pstore_info *psi)
+struct pstore_read_data {
+ u64 *id;
+ enum pstore_type_id *type;
+ int
-Original Message-
From: Luis Henriques [mailto:luis.henriq...@canonical.com]
Sent: Wednesday, April 10, 2013 8:18 AM
To: Lingzhu Xiang
Cc: Ben Hutchings; Seiji Aguchi; linux-kernel@vger.kernel.org;
sta...@vger.kernel.org; kernel-t...@lists.ubuntu.com; Matthew
Garrett; Josh Boyer
lugin function_graph
Seiji
> -Original Message-----
> From: Seiji Aguchi
> Sent: Friday, April 05, 2013 3:22 PM
> To: linux-kernel@vger.kernel.org; x...@kernel.org; rost...@goodmis.org;
> h...@zytor.com
> Cc: Thomas Gleixner (t...@linutronix.de); 'mi...@elte.hu' (mi...@elte.h
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 36
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace
mer_vector
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2)
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
-Original Message-
From: Seiji Aguchi
Sent: Friday, April 05, 2013 3:22 PM
To: linux-kernel@vger.kernel.org; x...@kernel.org; rost...@goodmis.org;
h...@zytor.com
Cc: Thomas Gleixner (t...@linutronix.de); 'mi...@elte.hu' (mi...@elte.hu);
Borislav Petkov (b...@alien8.de); linux-
e
, March 15, 2013 5:10 PM
> To: Seiji Aguchi
> Cc: H. Peter Anvin (h...@zytor.com); x...@kernel.org;
> linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
> 'mi...@elte.hu' (mi...@elte.hu); Borislav Petkov (b...@alien8.de); Satoru
> Moriya (smor...@redhat.com); dle-
&
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace
of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace/define_trace.h |5
ctor
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 36
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm
Thank you for giving me the feedback.
>
> So it appears the problem occurs because the other CPUs are not offlined
> correctly, and still have pending work which may generate
> wakeup IPIs to them?
Right.
>
> The fix would be to either offline them properly - or, if we don't want to do
>
Thank you for giving me the feedback.
So it appears the problem occurs because the other CPUs are not offlined
correctly, and still have pending work which may generate
wakeup IPIs to them?
Right.
The fix would be to either offline them properly - or, if we don't want to do
that to
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector tracepoints
trace,x86: code-sharing
of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include/linux/tracepoint.h |2 ++
include
:10 PM
To: Seiji Aguchi
Cc: H. Peter Anvin (h...@zytor.com); x...@kernel.org;
linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
'mi...@elte.hu' (mi...@elte.hu); Borislav Petkov (b...@alien8.de); Satoru
Moriya (smor...@redhat.com); dle-
deve...@lists.sourceforge.net; linux-e
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include
[] system_call_fastpath+0x16/0x1b
---[ end trace b3d5243c59d80624 ]---
[Solution]
Skip WARN_ON() when a panicked cpu which is set to stopping_cpu in
smp_send_stop() calls native_smp_send_reschedule().
Signed-off-by: Seiji Aguchi
---
arch/x86/kernel/smp.c |6 +-
1 files changed, 5
]---
[Solution]
Skip WARN_ON() when a panicked cpu which is set to stopping_cpu in
smp_send_stop() calls native_smp_send_reschedule().
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/kernel/smp.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel
OK. I will update my patch.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Tuesday, February 19, 2013 1:41 PM
> To: H. Peter Anvin
> Cc: Seiji Aguchi; x...@kernel.org; linux-kernel@vger.kernel.org; Thomas
> Gleixner (t...@l
OK. I will update my patch.
Seiji
-Original Message-
From: Steven Rostedt [mailto:rost...@goodmis.org]
Sent: Tuesday, February 19, 2013 1:41 PM
To: H. Peter Anvin
Cc: Seiji Aguchi; x...@kernel.org; linux-kernel@vger.kernel.org; Thomas
Gleixner (t...@linutronix.de); 'mi...@elte.hu
> > Not-yet-signed-off-by: Steven Rostedt
> >
> > ... so I was holding off on doing anything with it.
>
> Heh, and I was waiting for comments from you before doing anything further
> with it ;-)
>
> Email review deadlock!
So, how do you plan to push ahead with this patch?
Not-yet-signed-off-by: Steven Rostedt rost...@goodmis.org
... so I was holding off on doing anything with it.
Heh, and I was waiting for comments from you before doing anything further
with it ;-)
Email review deadlock!
So, how do you plan to push ahead with this patch?
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it was already called or not.
The time penalty is not desired in performance sensitive paths even if it is
tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/apic.h
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace
r
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vec
> > How important is it that the tracepoint is *inside* the enter/exit
> > handling? If not, it would be simpler to just do:
> >
> > smp_trace_irq_handler()
> > {
> > trace_irq_entry();
> > smp_irq_handler();
> > trace_irq_exit();
> > }
> >
> > ... which seems a bit cleaner. If this
riya; linux-kernel@vger.kernel.org;
> linux...@kvack.org; lwood...@redhat.com; Seiji Aguchi;
> a...@linux-foundation.org; hu...@google.com
> Subject: extra free kbytes tunable
>
> Hi,
>
> As discussed in this thread:
> http://marc.info/?l=linux-mm=131490523222031=2
>
@vger.kernel.org;
linux...@kvack.org; lwood...@redhat.com; Seiji Aguchi;
a...@linux-foundation.org; hu...@google.com
Subject: extra free kbytes tunable
Hi,
As discussed in this thread:
http://marc.info/?l=linux-mmm=131490523222031w=2
(with this cleanup as well: https://lkml.org/lkml/2011/9/2
How important is it that the tracepoint is *inside* the enter/exit
handling? If not, it would be simpler to just do:
smp_trace_irq_handler()
{
trace_irq_entry();
smp_irq_handler();
trace_irq_exit();
}
... which seems a bit cleaner. If this isn't possible, then
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector tracepoints
trace,x86
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include
();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it was already called or not.
The time penalty is not desired in performance sensitive paths even if it is
tiny.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
Peter,
Could you please review this patchset?
I have updated it in accordance with Steven's comment.
Seiji
> -Original Message-
> From: Seiji Aguchi
> Sent: Monday, February 04, 2013 5:49 PM
> To: 'Steven Rostedt'; x...@kernel.org; H. Peter Anvin (h...@zytor.com);
&g
Peter,
Could you please review this patchset?
I have updated it in accordance with Steven's comment.
Seiji
-Original Message-
From: Seiji Aguchi
Sent: Monday, February 04, 2013 5:49 PM
To: 'Steven Rostedt'; x...@kernel.org; H. Peter Anvin (h...@zytor.com);
linux-kernel
to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi
Acked-by: Matt Fleming
---
drivers/firmware/efivars.c | 85
ite() via kmsg_dump(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
Acked-by: Matt Fleming
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44 insertions(+), 42 deletions(-)
diff --git
problems above, this patchset makes efivars/efi_pstore
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while holding efivars->lock
efi_pstore: Introducing workqueue updating sy
Matt,
> Acked-by: Matt Fleming
>
> Tony, are you picking this up?
Thank you for reviewing and acking my patchset.
Tony,
This patchset can't be applied to a latest next tree due to following commits.
I will post v6 shortly to fit the latest next tree.
Then, please apply it.
efi: Make
Matt,
Acked-by: Matt Fleming matt.flem...@intel.com
Tony, are you picking this up?
Thank you for reviewing and acking my patchset.
Tony,
This patchset can't be applied to a latest next tree due to following commits.
I will post v6 shortly to fit the latest next tree.
Then, please apply it.
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while holding efivars-lock
efi_pstore: Introducing workqueue updating sysfs entries
drivers/firmware/efivars.c | 171
(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
Acked-by: Matt Fleming matt.flem...@intel.com
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44
to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Matt Fleming matt.flem...@intel.com
---
drivers/firmware
allocations during creating
>sysfs entries.
>An actual failure due to the create_sysfs_entry() has been reported.
> http://comments.gmane.org/gmane.linux.kernel.efi/406
>
> To resolve problems above, this patchset makes efivars/efi_pstore
> interrupt-safe.
>
> [P
explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while holding efivars-lock
- This patch fixes a problem (1).
efi_pstore: Introducing workqueue updating sysfs entries
- This patch fixes a problem (2).
drivers/firmware/efivars.c | 171
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/apic.h | 27
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector tracepoints
trace,x86: code-sharing between non-trace and trace irq handlers
Steven Rostedt (1):
tracing: Add
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector tracepoints
trace,x86: code-sharing between non-trace and trace irq handlers
Steven Rostedt (1):
tracing: Add DEFINE_EVENT_FN() macro
. This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/apic.h
>
> Also, don't forget to add the mutex protection that I suggested in another
> email.
Will do.
Thanks,
Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
> > +#include
> > +#include
> > +
> > +static struct desc_ptr trace_idt_descr = { NR_VECTORS * 16 - 1,
> > + (unsigned long) trace_idt_table };
> > +
> > +#ifndef CONFIG_X86_64
> > +gate_desc trace_idt_table[NR_VECTORS] __page_aligned_data
> > +
+#include asm/hw_irq.h
+#include asm/desc.h
+
+static struct desc_ptr trace_idt_descr = { NR_VECTORS * 16 - 1,
+ (unsigned long) trace_idt_table };
+
+#ifndef CONFIG_X86_64
+gate_desc trace_idt_table[NR_VECTORS] __page_aligned_data
+
Also, don't forget to add the mutex protection that I suggested in another
email.
Will do.
Thanks,
Seiji
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
gt; From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Thursday, January 31, 2013 6:22 PM
> To: Seiji Aguchi
> Cc: x...@kernel.org; H. Peter Anvin (h...@zytor.com);
> linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
> 'mi...@elte.hu' (mi...@elte.hu); Borislav Pe
Rostedt [mailto:rost...@goodmis.org]
Sent: Thursday, January 31, 2013 6:22 PM
To: Seiji Aguchi
Cc: x...@kernel.org; H. Peter Anvin (h...@zytor.com);
linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
'mi...@elte.hu' (mi...@elte.hu); Borislav Petkov (b...@alien8.de); Satoru
need to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 85 +---
include
ite() via kmsg_dump(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44 insertions(+), 42 deletions(-)
diff --git a/drivers/firmware/ef
ysfs_entry() has been reported.
http://comments.gmane.org/gmane.linux.kernel.efi/406
To resolve problems above, this patchset makes efivars/efi_pstore
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while
.
http://comments.gmane.org/gmane.linux.kernel.efi/406
To resolve problems above, this patchset makes efivars/efi_pstore
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while holding efivars-lock
kmsg_dump(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44 insertions(+), 42 deletions(-)
diff
need to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efivars.c | 85
> >
> > @@ -918,10 +918,7 @@ acpi_os_read_memory(acpi_physical_address phys_addr,
> > u64 *value, u32 width)
> > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > if (!virt_addr) {
> > rcu_read_unlock();
> > - virt_addr = acpi_os_ioremap(phys_addr, size);
>
[Issue]
Current erst driver is kicked in panic case.
On the other hand, a dynamic memory allocation seems to run in it
with a following code path.
erst_writer -> erst_write -> __erst_write_to_storage -> many of apei_exec_run
->
ctx->ins_table[entry->instruction].run()
which are functions
[Issue]
Current erst driver is kicked in panic case.
On the other hand, a dynamic memory allocation seems to run in it
with a following code path.
erst_writer - erst_write - __erst_write_to_storage - many of apei_exec_run
-
ctx-ins_table[entry-instruction].run()
which are functions defined in
snip
@@ -918,10 +918,7 @@ acpi_os_read_memory(acpi_physical_address phys_addr,
u64 *value, u32 width)
virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
if (!virt_addr) {
rcu_read_unlock();
- virt_addr = acpi_os_ioremap(phys_addr, size);
-
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/apic.h | 27
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 33
of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Seiji Aguchi
Signed-off-by: Steven Rostedt
---
include/linux/tracepoint.h |2 ++
include/trace/define_trace.h |5
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguch
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (3):
tracing: Add
of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Signed-off-by: Steven Rostedt rost...@goodmis.org
---
include/linux/tracepoint.h |2 ++
include
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/apic.h
201 - 300 of 598 matches
Mail list logo
