On Fri, Jan 8, 2021 at 3:13 AM Tom Rix wrote:
>
>
> On 1/7/21 12:41 PM, Jason Gunthorpe wrote:
> > On Tue, Dec 29, 2020 at 06:46:53PM -0800, t...@redhat.com wrote:
> >> From: Tom Rix
> >>
> >> In ocrdma_dealloc_ucontext_pd() uctx->cntxt_pd is assigned to
> >> the variable pd and then after uctx->
> Broadcom folks, can you confirm if this is OK? Is the string ABI for
> this driver?
>
bnxt_re doesn't have a string ABI.
This is a spelling mistake while posting the patch and it is okay to
merge this patch.
Thanks
Acked-by: Selvin Xavier
t; avoid < 80 column lengths and mistakenly output on multiple lines
> o Reflow modified lines to use 80 columns where appropriate
> o Consistently use "%s: " where __func__ is output
> o QPLIB: is now always output immediately after the dev_ header
>
> Signed-off-by: Joe Perches
Thanks for the patch, Joe.
Acked-by: Selvin Xavier
terminating newlines to avoid possible interleaving
>> o Realign arguments
>>
>> Signed-off-by: Joe Perches
>
> I don't see any problem with this patch. For the IB part:
>
> Acked-by: Doug Ledford
>
>
Acked-by: Selvin Xavier
On Tue, Mar 6, 2018 at 5:06 AM, Gustavo A. R. Silva
wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Thanks.
Acked-by: Selvin Xavier
> ---
>
iband/hw/ocrdma/ocrdma_stats.c | 6 ++
>> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 8 +++-
>> 3 files changed, 12 insertions(+), 21 deletions(-)
>>
>
> Thanks,
> Reviewed-by: Leon Romanovsky
Acked-by: Selvin Xavier
On Tue, Dec 19, 2017 at 6:00 PM, Leon Romanovsky wrote:
>> status = ocrdma_nonemb_mbx_cmd(dev, mqe, dev->stats_mem.va);
>
> It still doesn't make a lot of sense to me:
>
> ocrdma_mbx_rdma_stats():
> 1315if (reset)
> 1316 req->reset_stats = reset;
> 1317
> 1318 statu
dma/ocrdma_stats.c:dev->reset_stats.dev = dev;
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:if
> (!debugfs_create_file("reset_stats", S_IRUSR, dev->dir,
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:
> &dev->reset_stats, &ocrdma_dbg_ops))
> drivers/net/ethernet/emulex/benet/be_cmds.c:
> req->cmd_params.params.reset_stats = 0;
> drivers/net/ethernet/emulex/benet/be_cmds.h:u8 reset_stats;
>
> Thanks
The patch looks good to me.
Acked-by: Selvin Xavier
Thanks
Selvin
ll, so I may just
> pull it in. Thanks again.
Thanks Stephen and Doug for taking care of this.
Acked-by: Selvin Xavier
>
PCI error and FW hang needs to be handled as mentioned above by Doug.
As of now reboot is the only solution, for this very rare scenario. Is there any
support from the stack framework to cleanup kernel and application resources,
as this error path will be common for all other vendor drivers?
Thank you Yann Droneaud for forwarding this mail.
We will add an entry for ocrdma driver in MAINTAINERS file.
Thanks,
Selvin Xavier
> -Original Message-
> From: Yann Droneaud [mailto:ydrone...@opteya.com]
> Sent: Saturday, January 31, 2015 4:38 PM
> To: Rasmus Villemoes
Acked-by: Selvin Xavier
Thanks!
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Rasmus Villemoes
> Sent: Friday, January 16, 2015 8:10 PM
> To: Roland Dreier; Sean Hefty; Hal Rosenstock
> Cc: Rasmu
Acked-by: Selvin Xavier
Thanks!
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Rasmus Villemoes
> Sent: Friday, January 16, 2015 8:10 PM
> To: Roland Dreier; Sean Hefty; Hal Rosenstock
> Cc: Rasmu
> -Original Message-
> From: Or Gerlitz [mailto:or.gerl...@gmail.com]
> Sent: Tuesday, June 10, 2014 1:15 AM
> To: Roland Dreier; Selvin Xavier
> Cc: Steve Wise; linux-r...@vger.kernel.org; linux-kernel
> Subject: Re: [PATCH for-next 00/15] Bug fixes for ocrdma driver
14 matches
Mail list logo
