Re: [PATCH] usb: chipidea: delete an useless header file

2016-08-19 Thread Sergei Shtylyov
Hello. On 8/19/2016 3:05 PM, Jisheng Zhang wrote: is for net phy drivers, we don't need it. Signed-off-by: Jisheng Zhang --- drivers/usb/chipidea/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 69426e6..ae12595 100644

Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support

2016-08-11 Thread Sergei Shtylyov
On 8/10/2016 6:37 PM, patrice.chot...@st.com wrote: From: Patrice Chotard Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL returns 0. So force_port_map to 1 by using ports-implemented DT property. Signed-off-by: Patrice Chotard --- drivers/ata/ahci_st.c | 4 1 file changed, 4 ins

Re: [PATCH 09/20] SEAD3: Probe parallel flash via DT

2016-08-09 Thread Sergei Shtylyov
Hello. On 08/09/2016 03:35 PM, Paul Burton wrote: Probe the system parallel flash using device tree rather than platform code, in order to reduce the amount of the latter. Signed-off-by: Paul Burton --- arch/mips/boot/dts/mti/sead3.dts | 17 + arch/mips/mti-sead3/sead3-p

Re: [PATCH 08/11] net/fsl: use of_property_read_bool

2016-08-05 Thread Sergei Shtylyov
On 8/5/2016 2:38 PM, Julia Lawall wrote: Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S2,S1; @@ - if (of_get_property(e1,e2,NULL)) + if (o

Re: [PATCH 08/11] net/fsl: use of_property_read_bool

2016-08-05 Thread Sergei Shtylyov
Hello. On 8/5/2016 11:56 AM, Julia Lawall wrote: Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S2,S1; @@ - if (of_get_property(e1,e2,NULL)) +

Re: [RFC V2 PATCH 04/25] net/netpolicy: get CPU information

2016-08-05 Thread Sergei Shtylyov
Hello. On 8/4/2016 10:36 PM, kan.li...@intel.com wrote: From: Kan Liang Net policy also needs to know CPU information. Currently, online CPU number is enough. s/number/count/. Or "the number of online CPUs". Signed-off-by: Kan Liang --- net/core/netpolicy.c | 5 + 1 file changed

Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Sergei Shtylyov
Hello. On 8/2/2016 2:30 PM, Sergei Shtylyov wrote: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that

Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Sergei Shtylyov
Hello. On 8/2/2016 1:37 PM, Baole Ni wrote: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using mac

Re: [PATCH 1/1] dsa: b53: remove redundant if

2016-07-31 Thread Sergei Shtylyov
Hello. On 7/31/2016 10:42 AM, Heinrich Schuchardt wrote: For pdata == null the code leaves with an error. There is need to check the condition again. No need, you mean? Signed-off-by: Heinrich Schuchardt [...] MBR, Sergei

Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback

2016-07-31 Thread Sergei Shtylyov
Hello. On 7/31/2016 5:49 AM, Levin, Alexander wrote: Off by one in nic_config_loopback would access an invalid arrat variable when Array? vf id == MAX_LMAC. Signed-off-by: Sasha Levin [...] MBR, Sergei

Re: [PATCH v2 03/22] usb: serial: ti_usb_3410_5052: Use kzalloc instead of kmalloc

2016-07-27 Thread Sergei Shtylyov
On 7/26/2016 8:59 PM, Mathieu OTHACEHE wrote: Use kzalloc instead of kmalloc to avoid field initialisation to 0. Avoid? kzalloc() does initialize to 0. :-) Signed-off-by: Mathieu OTHACEHE MBR, Sergei

Re: [PATCH v2] platform: don't return 0 from platform_get_irq[_byname]() on error

2016-07-25 Thread Sergei Shtylyov
Hello. On 7/4/2016 1:04 AM, Sergei Shtylyov wrote: of_irq_get[_byname]() return 0 iff irq_create_of_mapping() call fails. Returning both error code and 0 on failure is a sign of a misdesigned API, it makes the failure check unnecessarily complex and error prone. We should rely on the

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Sergei Shtylyov
Hello. On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff fro

Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

2016-07-21 Thread Sergei Shtylyov
Hello. On 07/21/2016 09:41 PM, tom.t...@gmail.com wrote: From: Tom Yan 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan Perhaps Tejun is OK

Re: [PATCH net] e1000e: fix PTP on e1000_pch_lpt variants

2016-07-20 Thread Sergei Shtylyov
Hello. On 7/19/2016 11:25 PM, Jarod Wilson wrote: I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed. Switching from an if to a select, b

Re: [PATCH 1/2] net: ethernet: marvell: pxa168_eth: use phydev from struct net_device

2016-07-18 Thread Sergei Shtylyov
Hello. On 7/18/2016 12:30 AM, Philippe Reynes wrote: The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device.

Re: [PATCH v0 03/10] arm: orion5x: Add clk support for mv88f5181

2016-07-16 Thread Sergei Shtylyov
Hello. On 7/16/2016 5:29 PM, Jamie Lentin wrote: Referring to values in the u-boot port, add support for the mv88f5181 Signed-off-by: Jamie Lentin [...] diff --git a/drivers/clk/mvebu/orion.c b/drivers/clk/mvebu/orion.c index fd12956..a6e5bee 100644 --- a/drivers/clk/mvebu/orion.c +++ b/dr

Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-13 Thread Sergei Shtylyov
Hello. On 7/13/2016 2:45 PM, Yaniv Machani wrote: The HT capab info field inside the HT capab IE of the mesh beacon is incorrect (in the case of 20MHz channel width). To fix this driver will check configuration from cfg and will build it accordingly. Signed-off-by: Meirav Kama Signed-off-by:

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

2016-07-12 Thread Sergei Shtylyov
, allowing for the 40MHz clock to be detected. Also add in missing space between switch and parenthesis to clean up a checkpatch warning. Signed-off-by: Colin Ian King Acked-by: Sergei Shtylyov BTW, drivers/ata/pata_hpt366.c has the same bug... OK, I'll fix that too in a moment.

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

2016-07-12 Thread Sergei Shtylyov
On 7/12/2016 2:04 PM, Sergei Shtylyov wrote: From: Colin Ian King According to the HPT366 data sheet, PCI config space dword 0x40-0x43 bits 11:8 specify the primary drive cmd_high_time, however, currently just 3 bits of the 4 are being used because the mask is 0x07 and not 0x0f. Fix the mask

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

2016-07-12 Thread Sergei Shtylyov
, allowing for the 40MHz clock to be detected. Also add in missing space between switch and parenthesis to clean up a checkpatch warning. Signed-off-by: Colin Ian King Acked-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH 2/3] arm64: dts: rockchip: add GMAC dt nodes for rk3399 SoC

2016-07-06 Thread Sergei Shtylyov
Hello. On 7/6/2016 1:51 PM, Roger Chen wrote: This patch adds ethernet GMAC dt notes for Rockchip RK3399 SoC. Signed-off-by: Roger Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/rockc

Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

2016-07-05 Thread Sergei Shtylyov
Hello. On 07/05/2016 04:12 PM, David Howells wrote: When a jumbo packet is being split up and processed, the crypto checksum for each split-out packet is in the jumbo header and needs placing in the reconstructed packet header. When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keep

[PATCH v2] platform: don't return 0 from platform_get_irq[_byname]() on error

2016-07-03 Thread Sergei Shtylyov
as 0 can be a valid IRQ resource too... Fixes: aff008ad813c ("platform_get_irq: Revert to platform_get_resource if of_irq_get fails") Signed-off-by: Sergei Shtylyov CC: sta...@vger.kernel.org --- The patch is against the 'driver-core-linus' branch of Greg KH's &#x

Re: [PATCH v5 20/22] sh: IO-DATA HDL-U (a.k.a landisk) DeviceTree

2016-07-03 Thread Sergei Shtylyov
Hello. On 07/03/2016 07:46 PM, Yoshinori Sato wrote: Signed-off-by: Yoshinori Sato [...] diff --git a/arch/sh/boot/dts/landisk.dts b/arch/sh/boot/dts/landisk.dts new file mode 100644 index 000..3745ae0 --- /dev/null +++ b/arch/sh/boot/dts/landisk.dts @@ -0,0 +1,61 @@ [...] +&oclk { +

Re: [PATCH v4 22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree

2016-06-29 Thread Sergei Shtylyov
On 06/29/2016 04:41 PM, Yoshinori Sato wrote: Changes v4 - split patch Signed-off-by: Yoshinori Sato [...] diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts new file mode 100644 index 000..a1a0745 --- /dev/null +++ b/arch/sh/boot/dts/r2dplus.dts @@ -0,0 +1,83 @@

Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-06-28 Thread Sergei Shtylyov
Hello. On 06/28/2016 10:34 PM, Jon Mason wrote: Signed-off-by: Jon Mason --- .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt diff --git a/Documentati

Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function

2016-06-27 Thread Sergei Shtylyov
Hello. On 6/27/2016 8:07 AM, Hayes Wang wrote: Add byte_enable for ocp_read_word() to replace reading 4 bytes data with reading the desired 2 bytes data. This is used to avoid the issue which is described in commit:b4d99def. scripts/checkpatch.pl now enforces certain commit citing style,

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

2016-06-21 Thread Sergei Shtylyov
Hello. On 6/21/2016 6:56 AM, Yisen Zhuang wrote: From: Jun He When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and read new fbd_num to start new receive cycle. It recomputes cycle num is fbd_num minus clean_count, actually this cycle num is too big because it drop out rece

Re: [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792

2016-06-20 Thread Sergei Shtylyov
Hello. On 06/20/2016 06:43 PM, Arnd Bergmann wrote: The newly added support for R8A7792 causes build failures because we try to call rcar_gen2_clocks_init but that is not built into the kernel: arch/arm/mach-shmobile/built-in.o: In function `rcar_gen2_timer_init': :(.init.text+0x3b0): undefine

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

2016-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2016 04:52 PM, Arnd Bergmann wrote: Modern C standards expect the '__inline__' keyword to come before the return type in a declaration, and we get a warning for this with "make W=1": drivers/net/ethernet/freescale/gianfar.c:2278:1: error: 'inline' is not at beginning of declar

Re: [PATCH resend] libata:fix kernel panic when hotplug

2016-06-15 Thread Sergei Shtylyov
On 6/15/2016 12:15 PM, DingXiang wrote: From: Miao Xie In normal condition,if we use sas protocol and hotplug a sata disk on a port, the sas driver will send event "PORTE_BYTES_DMAED" and call function "sas_porte_bytes_dmaed". But if a sata disk is run io and unplug it,then plug a new sata di

Re: [PATCH resend] libata:fix kernel panic when hotplug

2016-06-15 Thread Sergei Shtylyov
On 6/15/2016 12:15 PM, DingXiang wrote: From: Miao Xie In normal condition,if we use sas protocol and hotplug a sata disk on a port, the sas driver will send event "PORTE_BYTES_DMAED" and call function "sas_porte_bytes_dmaed". But if a sata disk is run io and unplug it,then plug a new sata di

Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info

2016-06-14 Thread Sergei Shtylyov
On 06/14/2016 09:31 PM, Vivien Didelot wrote: With legacy probing, we cannot have a compatible info structure. We have to guess it. Instead of using only the first info structure of the info table, iterate over the compatible data. That way, the legacy code will support new compatible chips wit

Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

2016-06-14 Thread Sergei Shtylyov
Hello. On 06/14/2016 09:31 PM, Vivien Didelot wrote: Retrieve the info structure of the compatible of device in the new probe function, in order to know how to access the switch ID register. That way, a compatible info can be used to describe how to access the switch registers on models with d

Re: [PATCH v2 07/17] sh: Passing FDT address on zImage

2016-06-12 Thread Sergei Shtylyov
On 6/12/2016 9:54 AM, Yoshinori Sato wrote: Signed-off-by: Yoshinori Sato --- arch/sh/boot/compressed/head_32.S | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sh/boot/compressed/head_32.S b/arch/sh/boot/compressed/head_32.S index 3e15032..ef70454 100644 --- a/ar

Re: [PATCH v2 05/17] sh: command line passing chosen/bootargs in devicetree

2016-06-12 Thread Sergei Shtylyov
On 6/12/2016 9:54 AM, Yoshinori Sato wrote: Signed-off-by: Yoshinori Sato --- arch/sh/kernel/setup.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c index 8e3b099..d97de16 100644 --- a/arch/sh/kernel/setup.c +++ b/arch/sh/kernel/setup.

Re: [PATCH v2 01/17] sh: Add sh-specific early_init_dt_reserve_memory_arch

2016-06-12 Thread Sergei Shtylyov
On 6/12/2016 9:54 AM, Yoshinori Sato wrote: sh used P1 address space in early device tree. So need convert P1 to physical address before reserve memory. Signed-off-by: Yoshinori Sato --- arch/sh/boards/of-generic.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/sh/boar

Re: [PATCH v10 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Sergei Shtylyov
On 6/10/2016 2:46 PM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget so use named interrupt resources to allow device tree to specify the interrupts. Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host Maintain backward com

Re: [PATCH] of: irq: don't return 0 from of_irq_get()

2016-06-10 Thread Sergei Shtylyov
-off-by: Sergei Shtylyov So I think this is done this way because of the variation in NO_IRQ definition across architectures. I remember that NO_IRQ is "considered harmful" by Linus. Actually, I'm nit sure what you mean, could you elaborate on that? But then again, of_irq_ge

Re: [PATCH] platform: don't return 0 from platform_get_irq[_byname]() on error

2016-06-10 Thread Sergei Shtylyov
Hello. On 5/28/2016 11:51 PM, Sergei Shtylyov wrote: of_irq_get[_byname]() return 0 iff irq_create_of_mapping() call fails. Returning both error code and 0 on failure is a sign of a misdesigned API. We should rely on the platform IRQ resource in this case, not return 0, especially as 0 can

Re: [PATCH v10 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Sergei Shtylyov
On 6/10/2016 2:35 PM, Roger Quadros wrote: On 10/06/16 13:39, Sergei Shtylyov wrote: Hello. On 6/10/2016 12:56 PM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget so use named interrupt resources to allow device tree to specify the interrupts. Following are

Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core

2016-06-10 Thread Sergei Shtylyov
On 6/10/2016 1:19 PM, Roger Quadros wrote: It provides APIs for the following tasks - Registering an OTG/dual-role capable controller - Registering Host and Gadget controllers to OTG core - Providing inputs to and kicking the OTG state machine Provide a dual-role device (DRD) state machine. DR

Re: [PATCH v10 5/5] usb: dwc3: core: cleanup IRQ resources

2016-06-10 Thread Sergei Shtylyov
Hello. On 6/10/2016 12:56 PM, Roger Quadros wrote: Implementations might use different IRQs for host, gadget so use named interrupt resources to allow device tree to specify the interrupts. Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host Maintain bac

Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core

2016-06-09 Thread Sergei Shtylyov
On 6/9/2016 10:53 AM, Roger Quadros wrote: It provides APIs for the following tasks - Registering an OTG/dual-role capable controller - Registering Host and Gadget controllers to OTG core - Providing inputs to and kicking the OTG state machine Provide a dual-role device (DRD) state machine. DR

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

2016-06-09 Thread Sergei Shtylyov
Hello. On 6/9/2016 10:31 AM, Roger Quadros wrote: The OTG core will use struct otg_hcd_ops to interface with the HCD controller. Host controller driver (HCD) controller? Maybe just HC? :-) OK. OTOH, my googling has shown that HCD may stand for both HC driver and HC device... The ho

Re: Nokia N900: musb is in wrong state after boot

2016-06-08 Thread Sergei Shtylyov
On 6/8/2016 3:18 PM, joerg Reisenweber wrote: Tony, what do you think about that patch? Tony, PING Yeah I don't know, AFAIK we don't have a generic way to force MUSB to change mode without ID pin. If you have figured something generic for that which does not actually tinker with the PHY regi

Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core

2016-06-08 Thread Sergei Shtylyov
On 6/8/2016 3:06 PM, Roger Quadros wrote: Introduce usb_otg_add/remove_hcd() for use by host controllers that are part of OTG/dual-role port. Non Device tree platforms can use the otg_dev argument to specify the OTG controller device. If otg_dev is NULL then the device tree node's otg-controlle

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

2016-06-08 Thread Sergei Shtylyov
On 6/8/2016 3:04 PM, Roger Quadros wrote: The OTG core will use struct otg_hcd_ops to interface with the HCD controller. Host controller driver (HCD) controller? Maybe just HC? :-) OK. OTOH, my googling has shown that HCD may stand for both HC driver and HC device... The host contro

Re: Nokia N900: musb is in wrong state after boot

2016-06-08 Thread Sergei Shtylyov
On 6/8/2016 1:02 PM, Felipe Balbi wrote: * Pali Rohár [160607 05:53]: Tony, what do you think about that patch? Tony, PING Yeah I don't know, AFAIK we don't have a generic way to force MUSB to change mode without ID pin. If you have figured something generic for that which does not actual

Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core

2016-06-08 Thread Sergei Shtylyov
On 6/8/2016 12:03 PM, Roger Quadros wrote: Introduce usb_otg_add/remove_hcd() for use by host controllers that are part of OTG/dual-role port. Non Device tree platforms can use the otg_dev argument to specify the OTG controller device. If otg_dev is NULL then the device tree node's otg-controll

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

2016-06-08 Thread Sergei Shtylyov
Hello. On 6/8/2016 12:03 PM, Roger Quadros wrote: The OTG core will use struct otg_hcd_ops to interface with the HCD controller. Host controller driver (HCD) controller? Maybe just HC? :-) The main purpose of this interface is to avoid directly calling HCD APIs from the OTG core as they

Re: [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48

2016-06-07 Thread Sergei Shtylyov
Hello. On 6/7/2016 6:39 AM, Magnus Damm wrote: From: Magnus Damm Bump up the maximum numbers of micro-TLBS to 48. Each IPMMU device instance get micro-TLB assignment via the "iommus" property in DT. Older SoCs tend to use a maximum number of 32 micro-TLBd per IPMMU instance however Micr

Re: [PATCH v3 11/11] serial: sh-sci: Add DT support for dedicated RTS/CTS

2016-06-03 Thread Sergei Shtylyov
Hello. On 6/3/2016 1:00 PM, Geert Uytterhoeven wrote: Add support for indicating the availability of dedicated lines for RTS/CTS hardware flow control, using the standard "uart-has-rtscts" DT property. Signed-off-by: Geert Uytterhoeven --- v3: - No changes, v2: - New. --- drivers/tty/se

Re: [PATCH v2,1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode

2016-05-31 Thread Sergei Shtylyov
Hello. On 5/31/2016 8:52 AM, Chunfeng Yun wrote: Some resources, such as IPPC register etc, shared with device driver are moved into common glue layer when xHCI driver is the host side of dual-role mode and they should be changed as optional properties if they are required ones before. For clar

[PATCH] of: irq: don't return 0 from of_irq_get()

2016-05-28 Thread Sergei Shtylyov
of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning both error code and 0 on failure is a sign of a misdesigned API. Return -ENXIO instead like one of the callers, platform_get_irq(), does; fix up the kernel-doc as well... Signed-off-by: Sergei Shtylyov --- The patch is

[PATCH] platform: don't return 0 from platform_get_irq[_byname]() on error

2016-05-28 Thread Sergei Shtylyov
("platform_get_irq: Revert to platform_get_resource if of_irq_get fails") Signed-off-by: Sergei Shtylyov CC: sta...@vger.kernel.org --- The patch is against the 'driver-core-linus' branch of Greg KH's 'driver-core.git' repo. drivers/base/platform.c |4 ++--

[PATCH] of: irq: fix of_irq_get[_byname]() kernel-doc

2016-05-28 Thread Sergei Shtylyov
this case). Document all possible return value variants, making the writing of the word "IRQ" consistent, while at it... Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") Fixes: ad69674e73a1 ("of/irq: do irq resolution in platform_get_irq_byname()")

Re: [PATCH v3 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

2016-05-27 Thread Sergei Shtylyov
Hello. On 5/27/2016 2:31 PM, William Wu wrote: This patch documents the device tree documentation required for Documents the documentation? :-) Rockchip USB3.0 core wrapper consist of USB3.0 IP from Synopsys. Consisting? It could operate in device mode (SS, HS, FS) and host mode (

Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-23 Thread Sergei Shtylyov
On 05/23/2016 06:19 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprog

Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-23 Thread Sergei Shtylyov
On 05/23/2016 04:40 PM, Sergei Shtylyov wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was

Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-23 Thread Sergei Shtylyov
On 5/23/2016 4:26 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprogra

Re: [PATCH V2 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-23 Thread Sergei Shtylyov
Hello. On 5/23/2016 3:00 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was

Re: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Sergei Shtylyov
On 05/20/2016 08:06 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprog

Re: [PATCH 2/2] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-20 Thread Sergei Shtylyov
On 05/20/2016 05:51 PM, Andrew Goodbody wrote: Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprog

Re: [PATCH 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

2016-05-20 Thread Sergei Shtylyov
Hello. On 05/20/2016 05:51 PM, Andrew Goodbody wrote: shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx pack

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-19 Thread Sergei Shtylyov
Hello. On 5/15/2016 6:23 PM, Andrew Lunn wrote: I think there could be similar code one layer above to handle one gpio line for multiple phys. Ah, you want me to recognize some MAC/MDIO bound prop (e.g. "mdio-reset-gpios") in of_mdiobus_register()? I'll think about it now that my patch nee

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-14 Thread Sergei Shtylyov
Hello. On 05/14/2016 10:50 PM, Andrew Lunn wrote: Another issue is that on some boards we have one reset line tied to multiple PHYs.How do we prevent multiple resets being taking place when each of the PHYs are registered? My patch just doesn't address this case -- it's about the individual

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-14 Thread Sergei Shtylyov
Hello. On 05/13/2016 10:18 PM, Sergei Shtylyov wrote: [we already talked about this patch in #armlinux, I'm now just forwarding my comments on the list. Background was that I sent an easier and less complete patch with the same idea. See http://patchwork.ozlabs.org/patch/621418/] [added

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-14 Thread Sergei Shtylyov
Hello. On 05/14/2016 02:44 AM, Andrew Lunn wrote: Another issue is that on some boards we have one reset line tied to multiple PHYs.How do we prevent multiple resets being taking place when each of the PHYs are registered? My patch just doesn't address this case -- it's about the individual

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-13 Thread Sergei Shtylyov
Hello. On 05/13/2016 10:06 AM, Uwe Kleine-König wrote: [...] Index: net-next/drivers/of/of_mdio.c === --- net-next.orig/drivers/of/of_mdio.c +++ net-next/drivers/of/of_mdio.c @@ -44,6 +44,7 @@ static int of_get_phy_id(struct device

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-13 Thread Sergei Shtylyov
Hello. On 05/13/2016 07:06 AM, Andrew Lunn wrote: + gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios"); + /* Deassert the reset signal */ + if (!IS_ERR(gpiod)) + gpiod_direction_output(gpiod, 0); This is wrong I think. You must only ignore -ENODEV, a

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-13 Thread Sergei Shtylyov
On 05/13/2016 11:44 PM, Andrew Lunn wrote: Another issue is that on some boards we have one reset line tied to multiple PHYs.How do we prevent multiple resets being taking place when each of the PHYs are registered? My patch just doesn't address this case -- it's about the individual resets

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-13 Thread Sergei Shtylyov
Hello. On 05/13/2016 12:07 PM, Roger Quadros wrote: [...] +} +EXPORT_SYMBOL(mdio_device_reset); + /** * mdio_probe - probe an MDIO device * @dev: device to probe @@ -117,9 +126,16 @@ static int mdio_probe(struct device *dev struct mdio_driver *mdiodrv = to_mdio_driver(drv);

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-13 Thread Sergei Shtylyov
Hello. On 05/13/2016 12:35 AM, Sergei Shtylyov wrote: [we already talked about this patch in #armlinux, I'm now just forwarding my comments on the list. Background was that I sent an easier and less complete patch with the same idea. See http://patchwork.ozlabs.org/patch/621418/] [added

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-13 Thread Sergei Shtylyov
Hello. On 5/13/2016 8:56 AM, Ethan Zhao wrote: Allocating 64 Tx/Rx as default doesn't benefit perfomrnace when less Performance. CPUs were assigned. especially when DCB is enabled, so we should take num_online_cpus() as top limit, and aslo to make sure every TC has Also. at least

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-12 Thread Sergei Shtylyov
added Linus Walleij to Cc, there is a question for you/him below] On Fri, Apr 29, 2016 at 01:12:54AM +0300, Sergei Shtylyov wrote: --- net-next.orig/Documentation/devicetree/bindings/net/phy.txt +++ net-next/Documentation/devicetree/bindings/net/phy.txt @@ -35,6 +35,8 @@ Optional Properties: - broken

Re: [PATCH 04/36] usb: serial: ti_usb_3410_5052: Use inline functions rather than macro

2016-05-12 Thread Sergei Shtylyov
Hello. On 5/12/2016 11:48 AM, Mathieu OTHACEHE wrote: Inline functions are preferable to macros resembling functions. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/usb/se

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

2016-05-10 Thread Sergei Shtylyov
se of the reset GPIO for its own purposes... Signed-off-by: Sergei Shtylyov This looks good to me: Acked-by: Florian Fainelli Thank you! I'll send v3 without [RFT] then. Can you follow up with changes in phy_{suspend,resume} I'm not sure what changes you mean -- poweri

Re: [PATCH v5 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-05-10 Thread Sergei Shtylyov
On 5/10/2016 2:46 AM, David Lechner wrote: The CFGCHIP registers are used by a number of devices, so using a syscon device to share them. The first consumer of this will by the phy-da8xx-usb driver. Signed-off-by: David Lechner [...] diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch

Re: [PATCH v5 3/5] ARM: davinci: da8xx: Add USB PHY platform declaration

2016-05-10 Thread Sergei Shtylyov
Hello. On 5/10/2016 2:46 AM, David Lechner wrote: There is now a proper phy driver for the DA8xx SoC USB PHY. This adds the platform device declarations needed to use it. Signed-off-by: David Lechner [...] diff --git a/arch/arm/mach-davinci/include/mach/da8xx.h b/arch/arm/mach-davinci/inc

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-05 Thread Sergei Shtylyov
On 5/5/2016 4:31 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@ void musb_

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-05 Thread Sergei Shtylyov
Hello. On 5/4/2016 10:17 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@ v

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-04 Thread Sergei Shtylyov
Hello. On 05/04/2016 09:56 PM, Bin Liu wrote: yes, it also works with that reset and go to finish: diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9..8cd98e7 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -1599,6 +1599,10 @@

[PATCH RFT v2 2/2] macb: kill PHY reset code

2016-04-28 Thread Sergei Shtylyov
With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17 - drivers/net/ethernet/cadenc

[PATCH RFT 1/2] phylib: add device reset GPIO support

2016-04-28 Thread Sergei Shtylyov
he 'phylib' to get the MDIO device reset GPIO from the device tree node corresponding to this device -- which this patch is doing... Note that I had to modify the AT803x PHY driver as it would stop working otherwise as it made use of the reset GPIO for its own purposes... Signed-off

[PATCH RFT v2 0/2] Teach phylib hard-resetting devices

2016-04-28 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against DaveM's 'net-next.git' repo. They add to the 'phylib' support for resetting devices via GPIO and do some clean up after doing that... [1/2] phylib: add device reset GPIO support [2/2] macb: kill PHY reset code MBR, Sergei

Re: [PATCH] pinctrl: ish-pfc: avoid unused variable warning

2016-04-27 Thread Sergei Shtylyov
Hello. s/ish-/sh-/ in the subject. On 4/27/2016 12:56 PM, Arnd Bergmann wrote: After the conversion to devm_pinctrl_register, we get a warning in sh_pfc_remove when CONFIG_PINCTRL_SH_PFC_GPIO is disabled: drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove': drivers/pinctrl/sh-pfc/co

Re: [PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread Sergei Shtylyov
Hello. On 4/27/2016 11:29 AM, changbin...@intel.com wrote: From: "Du, Changbin" The dwc3 controller can't generate a disconnect event after it is stopped. Thus gadget dissconnect callback is not invoked when do soft dissconnect. Call dissconnect here to workaround this issue. "Disconnect

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-26 Thread Sergei Shtylyov
On 04/26/2016 08:17 PM, David Miller wrote: I plan to queue this patch through arm-soc for 4.7. Ok. How about this patch going thru your net-next repo instead? I'd like to keep the kernel bisectable... if my phylib/macb patches get merged earlier than this one, that board would be broken

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-26 Thread Sergei Shtylyov
Hello. On 04/26/2016 01:24 PM, Nicolas Ferre wrote: Fix gpio active flag for the phy reset-gpios property. The line is active low instead of active high. Actually, this flags was never used by the macb driver. Reported-by: Sergei Shtylyov Cc: Andrew Lunn Cc: David Miller Signed-off-by

Re: [PATCH] musb_host: fix lockup on rxcsr_h_error

2016-04-26 Thread Sergei Shtylyov
Hello. On 4/26/2016 9:45 AM, Max Uvarov wrote: Fix soft lockup when resetting remote device attached to usb host. Configuration: pppd -> musb hub -> usb-serial -> gms modem When gsm modem resets, musb rolls in incoming rx interrupts which does not give any time to other application as result it

Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear.

2016-04-25 Thread Sergei Shtylyov
Hello. On 4/24/2016 8:09 PM, Konstantin Shkolnyy wrote: The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but CRTSCTS? Also, "is" missing before "intended"? did it inconsistently. This change is non-functional for existing chips because the driver never set the flag a

Re: [PATCH RESEND 1/5] USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.

2016-04-25 Thread Sergei Shtylyov
Hello. On 4/24/2016 8:08 PM, Konstantin Shkolnyy wrote: A bug in the CRTSCT handling caused RTS to alternate between CRTSCTS? CRTSCTS=0 => "RTS transmits active signal" and CRTSCTS=1 => "RTS receives flow control" instead of CRTSCTS=0 => "RTS is statically active" and CRTSCTS=1 => "RTS r

Re: [PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff

2016-04-22 Thread Sergei Shtylyov
Hello. On 04/21/2016 09:15 PM, Andy Shevchenko wrote: The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results i

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Sergei Shtylyov
On 4/19/2016 3:21 PM, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc scripts/checkpatch.pl now enforces certain commit citing style, the commit summary should be specified too. I used checkpatch from 4.6.0-rc2(or3) and did not notice it. B

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Sergei Shtylyov
Hello. On 4/19/2016 10:12 AM, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc scripts/checkpatch.pl now enforces certain commit citing style, the commit summary should be specified too. device as to having an broken HPI implementation. Af

Re: [PATCH] mips: pistachio: Determine SoC revision during boot

2016-04-18 Thread Sergei Shtylyov
Hello. On 04/18/2016 05:24 PM, James Hartley wrote: Now that there are different revisions of the Pistachio SoC in circulation, add this information to the boot log to make it easier for users to determine which hardware they have. Signed-off-by: James Hartley Signed-off-by: Ionela Voinescu

Re: [PATCH v2 03/13] MIPS: Remove redundant asm/pgtable-bits.h inclusions

2016-04-18 Thread Sergei Shtylyov
Hello. On 4/18/2016 12:35 PM, Paul Burton wrote: asm/pgtable-bits.h is included in 2 assembly files and thus has to in either of the assembly files that include it. > Missed a line again? :-) Remove the redundant inclusions such that asm/pgtable-bits.h doesn't need to #ifdef around C cod

Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb

2016-04-15 Thread Sergei Shtylyov
On 04/15/2016 07:13 PM, David Lechner wrote: Device tree binding for new phy-da8xx-usb driver. Signed-off-by: David Lechner Acked-by: Rob Herring --- v4 changes: * swapped order of usb20 and usb11 to be in logical order of reg address. .../devicetree/bindings/phy/phy-da8xx-usb.txt |

<    3   4   5   6   7   8   9   10   11   12   >