Re: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-11 Thread Sergej Bauer
On Friday, February 12, 2021 3:27:40 AM MSK you wrote: > Hi Sergej, thank you for testing this ! Don't mention it, it's just a small assistance > On Thu, Feb 11, 2021 at 7:18 PM Sergej Bauer wrote: > > although whole set of tests might be an overly extensive, but after &g

Re: [PATCH net-next v2 1/5] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-11 Thread Sergej Bauer
On Thursday, February 11, 2021 7:18:26 PM MSK you wrote: > From: Sven Van Asbroeck > > The buffers in the lan743x driver's receive ring are always 9K, > even when the largest packet that can be received (the mtu) is > much smaller. This performs particularly badly on cpu archs > without dma cache

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-05 Thread Sergej Bauer
On Friday, February 5, 2021 5:07:22 PM MSK you wrote: > Hi Sergej, > > On Fri, Feb 5, 2021 at 7:44 AM Sergej Bauer wrote: > > Hi Sven > > I can confirm great stability improvement after your patch > > "lan743x: boost performance on cpu archs w/o dma cache sno

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-05 Thread Sergej Bauer
sOn Friday, February 5, 2021 7:39:40 PM MSK Sven Van Asbroeck wrote: > Hi Sergej, > > On Fri, Feb 5, 2021 at 10:09 AM Sergej Bauer wrote: > > Tests after applying patches [2/6] and [3/6] are: > > $ ifmtu eth7 500 > > $ sudo test_ber -l eth7 -c 1000 -n 100 -f500 -

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-02-05 Thread Sergej Bauer
Hi Sven I can confirm great stability improvement after your patch "lan743x: boost performance on cpu archs w/o dma cache snooping". Please note, that test_ber opens raw sockets as s = socket(AF_PACKET, SOCK_RAW, ETH_P_ALL) and resulting 'average speed' is a average egress speed. Test machine is I

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-26 Thread Sergej Bauer
On Saturday, January 23, 2021 4:39:47 AM MSK Florian Fainelli wrote: > On 1/22/2021 5:01 PM, Sergej Bauer wrote: > > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: > >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: > >>> On Saturday, January 23, 2

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-26 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-25 Thread Sergej Bauer
On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port but the difference is > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
resending answer to all: On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port b

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: > On 1/22/2021 3:58 PM, Sergej Bauer wrote: > > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > >>>>> @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 1:08:03 AM MSK Andrew Lunn wrote: > On Sat, Jan 23, 2021 at 12:42:41AM +0300, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > als

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 12:52:48 AM MSK Florian Fainelli wrote: > On 1/22/2021 1:42 PM, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > als

[PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
From: sba...@blackbox.su v1->v2: switch to using of fixed_phy as was suggested by Andrew and Florian also features-related parts are removed Previous versions can be found at: v1: initial version https://lkml.org/lkml/2020/9/17/1272 Signed-off-by: Sergej Bauer d

Re: [PATCH v4] lan743x: fix for potential NULL pointer dereference with bare card

2020-12-15 Thread Sergej Bauer
On Wednesday, December 16, 2020 4:12:42 AM MSK Jakub Kicinski wrote: > On Tue, 15 Dec 2020 23:39:14 + patchwork-bot+netdev...@kernel.org > > wrote: > > Hello: > > > > This patch was applied to bpf/bpf.git (refs/heads/master): > > > > On Tue, 15 Dec 2020 19:12:45 +0300 you wrote: > > > This i

[PATCH v4] lan743x: fix for potential NULL pointer dereference with bare card

2020-12-15 Thread Sergej Bauer
arkus Elfring) return -ENETDOWN instead of -EIO (review by Andrew Lunn) v4: Sven Van Asbruck noticed that the patch was being applied cleanly to the 5.9 branch, so the tag “Fixes” was added as Jakub suggested. Signed-off-by: Sergej Bauer Reviewed-by: Andrew Lunn Reviewed-by: Jakub Kicinski Fixes:

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-27 Thread Sergej Bauer
Hi Sven. > Hi Jakub, Sergej, > > On Tue, Nov 3, 2020 at 8:41 PM Jakub Kicinski wrote: > > On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > > > This is the 3rd revision of the patch fix for potential null pointer > > > dereference with lan743x card.

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-04 Thread Sergej Bauer
On Wednesday, November 4, 2020 4:38:33 AM MSK Jakub Kicinski wrote: > On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > > This is the 3rd revision of the patch fix for potential null pointer > > dereference with lan743x card. > > > > The simpliest way to reprod

[PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-01 Thread Sergej Bauer
arkus Elfring) return -ENETDOWN insted of -EIO (review by Andrew Lunn) Signed-off-by: Sergej Bauer --- diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index dcde496da7fb..c5de8f46cdd3 100644 --- a/drivers/net/ethernet/microchip/lan7

Re: [PATCH v2] lan743x: Fix for potential null pointer dereference

2020-11-01 Thread Sergej Bauer
On Sunday, November 1, 2020 11:38:20 PM MSK Andrew Lunn wrote: > On Sun, Nov 01, 2020 at 10:54:38PM +0300, Sergej Bauer wrote: > > > > Signed-off-by: Sergej Bauer > > > > > > * I miss a change description here. > > > > The reason for the fix is w

Re: [PATCH v2] lan743x: Fix for potential null pointer dereference

2020-11-01 Thread Sergej Bauer
> > Signed-off-by: Sergej Bauer > > * I miss a change description here. The reason for the fix is when the device is down netdev->phydev will be NULL and there is no checking for this situation. So 'ethtool ethN' leads to kernel panic. $ sudo ethtool eth7 [ 103

[PATCH v2] fix for potential NULL pointer dereference with bare lan743x

2020-10-31 Thread Sergej Bauer
Signed-off-by: Sergej Bauer --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index dcde496da7fb..ad38fc9e1468

[PATCH] fix for potential NULL pointer dereference with bare lan743x

2020-10-28 Thread Sergej Bauer
This is just a minor fix which prevents a kernel NULL pointer dereference when using phy-less lan743x. Signed-off-by: Sergej Bauer --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip

Re: [PATCH] add virtual PHY for PHY-less devices

2020-09-17 Thread Sergej Bauer
st to rearrange some lines in lan743x_phy_open. -- Sergej On Friday, September 18, 2020 1:16:30 AM MSK Florian Fainelli wrote: > On 9/17/2020 2:40 PM, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > Here is a kern

Re: [PATCH] add virtual PHY for PHY-less devices

2020-09-17 Thread Sergej Bauer
I had no time before this moment. p.p.s. sorry for long time to answer but it's far behind the midnight in my region. -- Sergej On Friday, September 18, 2020 1:15:47 AM MSK Andrew Lunn wrote: > On Fri, Sep 18, 2020 at 12:40:10AM +0300, Serge

[PATCH] add virtual PHY for PHY-less devices

2020-09-17 Thread Sergej Bauer
NTAINERS b/MAINTAINERS index f0068bceeb61..d4c10895aa13 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11423,6 +11448,12 @@ L: net...@vger.kernel.org S: Maintained F: drivers/net/ethernet/microchip/lan743x_* +MICROCHIP LAN743X VIRTUAL PHY DRIVER +M: Sergej Bauer +

Re: [PATCH 1/1] Add mkopci driver

2015-03-21 Thread Sergej Bauer
March 2015 20:32:16 Richard Weinberger wrote: > Am 21.03.2015 um 18:24 schrieb Sergej Bauer: > > Ok, I realized uselessness of merging this driver... > > Please don't give up that fast! > See: http://airlied.livejournal.com/#item80112 > > > And you brought me to a

Re: [PATCH 1/1] Add mkopci driver

2015-03-21 Thread Sergej Bauer
turday 21 March 2015, Sergej Bauer wrote: > > Richard, thanks for your review. > > > > But I still have several notes about driver: > > > > > - You add new proc files, which is not really welcomed. Please consider > > > sysfs. > > That will break a

Re: [PATCH 1/1] Add mkopci driver

2015-03-21 Thread Sergej Bauer
_MID || COMPILE_TEST) diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 7d5c4cd..afb92b4 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -56,3 +56,4 @@ obj-$(CONFIG_GENWQE) += genwqe/ obj-$(CONFIG_ECHO) += echo/ obj-$(CONFIG_VEXPRESS_SYSCFG) += vexpres

[PATCH 1/1] Add mkopci driver

2015-03-20 Thread sergej . bauer
queue. Signed-off-by: Sergej Bauer --- Documentation/misc-devices/mkopci.txt | 51 ++ drivers/misc/Kconfig |9 + drivers/misc/Makefile |1 + drivers/misc/mkopci.c | 1272 + include/misc/mkopci.h