[PATCH] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha

2021-02-08 Thread Seth Forshee
h as this: # mkdir mnt # mount -t tmpfs nodev mnt # mount -o remount,rw mnt mount: /home/ubuntu/mnt: mount point not mounted or bad option. Prevent CONFIG_TMPFS_INODE64 from being selected on alpha. Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") Cc: sta...@vger.kernel.o

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-08 Thread Seth Forshee
On Sun, Feb 07, 2021 at 05:48:31PM +0300, Kirill A. Shutemov wrote: > On Fri, Feb 05, 2021 at 05:06:20PM -0600, Seth Forshee wrote: > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selec

[PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-05 Thread Seth Forshee
This feature requires ino_t be 64-bits, which is true for every 64-bit architecture but s390, so prevent this option from being selected there. Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") Cc: # v5.9+ Signed-off-by: Seth Forshee --- fs/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH] tmpfs: Don't use 64-bit inodes by defulat with 32-bit ino_t

2021-02-05 Thread Seth Forshee
On Fri, Feb 05, 2021 at 01:23:13PM -0800, Andrew Morton wrote: > On Fri, 5 Feb 2021 14:55:43 -0600 Seth Forshee > wrote: > > > On Fri, Feb 05, 2021 at 12:41:57PM -0800, Andrew Morton wrote: > > > On Fri, 5 Feb 2021 14:21:59 -0600 Seth Forshee > > > wrote: >

Re: [PATCH] tmpfs: Don't use 64-bit inodes by defulat with 32-bit ino_t

2021-02-05 Thread Seth Forshee
On Fri, Feb 05, 2021 at 12:41:57PM -0800, Andrew Morton wrote: > On Fri, 5 Feb 2021 14:21:59 -0600 Seth Forshee > wrote: > > > Currently there seems to be an assumption in tmpfs that 64-bit > > architectures also have a 64-bit ino_t. This is not true; s390 at > &g

[PATCH] tmpfs: Don't use 64-bit inodes by defulat with 32-bit ino_t

2021-02-05 Thread Seth Forshee
CONFIG_TMPFS_INODE64 setting when sizeof(ino_t) < 8. Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") Signed-off-by: Seth Forshee --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 7c6b6d8f6c39..efde42acdc7a 10064

Re: [PATCH] x86: Disable CET instrumentation in the kernel

2021-01-29 Thread Seth Forshee
tch adding that switch: > > 29be86d7f9cb ("kbuild: add -fcf-protection=none when using retpoline flags") > > came from a Canonical. > > Adding the author to Cc for FYI. > > Seth, you can find this thread starting here: > > https://lkml.kernel.org/r/20210128215219.6kct3h2eiustncws@treble Thanks for the heads up. This still works fine for our needs. Acked-by: Seth Forshee

Re: BPF selftests build failure in 5.10-rc

2020-12-10 Thread Seth Forshee
On Wed, Dec 09, 2020 at 04:15:35PM -0800, Andrii Nakryiko wrote: > On Wed, Dec 9, 2020 at 2:24 PM Seth Forshee > wrote: > > > > Building the BPF selftests with clang 11, I'm getting the following > > error: > > > >CLNG-LLC [test_maps] profiler1.o > >

BPF selftests build failure in 5.10-rc

2020-12-09 Thread Seth Forshee
Building the BPF selftests with clang 11, I'm getting the following error: CLNG-LLC [test_maps] profiler1.o In file included from progs/profiler1.c:6: progs/profiler.inc.h:260:17: error: use of unknown builtin '__builtin_preserve_enum_value' [-Wimplicit-function-declaration]

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Seth Forshee
On Thu, Sep 17, 2020 at 11:14:06AM +0200, Jiri Olsa wrote: > On Thu, Sep 17, 2020 at 10:38:12AM +0200, Jiri Olsa wrote: > > On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > > > On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > > > > The requi

resolve_btfids breaks kernel cross-compilation

2020-09-16 Thread Seth Forshee
The requirement to build resolve_btfids whenever CONFIG_DEBUG_INFO_BTF is enabled breaks some cross builds. For example, when building a 64-bit powerpc kernel on amd64 I get: Auto-detecting system features: ...libelf: [ [32mon[m ] ... zlib: [

test_bpf regressions on s390 since 5.4

2020-07-16 Thread seth . forshee
The tests in lib/test_bpf.c were all passing in 5.4 when using the JIT, but some are failing in 5.7/5.8. Some of the failures are due to the removal of BPF_SIZE_MAX causing some expected failures to pass, which I have already send a patch for [1]. The remaining failures appear to be regressions. I

[PATCH] Revert "test_bpf: flag tests that cannot be jited on s390"

2020-07-16 Thread Seth Forshee
should no longer be flagged. Fixes: d1242b10ff03 ("s390/bpf: Remove JITed image size limitations") Signed-off-by: Seth Forshee --- lib/test_bpf.c | 20 1 file changed, 20 deletions(-) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index a5fddf9ebcb7..ca7d635bc

Re: [PATCH] MAINTAINERS: remove obsolete entry after file renaming

2020-06-29 Thread Seth Forshee
gt; Signed-off-by: Lukas Bulwahn I didn't think to check MAINTAINERS when renaming the file. This makes sense to me. Acked-by: Seth Forshee > --- > applies cleanly on next-20200626 > > Seth, please ack. > Mark, please pick this minor non-urgent patch into your -next tree. > &g

[PATCH] regulator: rename da903x to da903x-regulator

2020-06-24 Thread Seth Forshee
This module shares the same name as its parent PMIC driver, which confuses tools like kmod. Rename the regulator driver to avoid such problems. Signed-off-by: Seth Forshee --- drivers/regulator/Makefile | 2 +- drivers/regulator/{da903x.c => da903x-regulator.c} | 0

Re: [PATCH v2] selftests/ftrace: Use printf instead of echo in kprobe syntax error tests

2020-06-04 Thread Seth Forshee
On Fri, May 29, 2020 at 03:26:06PM -0600, Shuah Khan wrote: > On 5/29/20 2:37 PM, Seth Forshee wrote: > > On Wed, Mar 04, 2020 at 04:20:09PM -0600, Seth Forshee wrote: > > > Test cases which use echo to write strings containing backslashes > > > fail with some

Re: [PATCH v2] selftests/ftrace: Use printf instead of echo in kprobe syntax error tests

2020-05-29 Thread Seth Forshee
On Wed, Mar 04, 2020 at 04:20:09PM -0600, Seth Forshee wrote: > Test cases which use echo to write strings containing backslashes > fail with some shells, as echo's treatment of backslashes in > strings varies between shell implementations. Use printf instead, > as it should behave

[PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args

2019-09-17 Thread Seth Forshee
The addition of struct clone_args to uapi/linux/sched.h is not protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on RISC-V. Add the guards to fix this. Fixes: 7f192e3cd316 ("fork: add clone3") Signed-off-by: Seth Forshee --- include/uapi/linux/sched.h | 2 ++ 1 file

Re: [PATCH 0/1] Small potential fix for shiftfs

2019-08-15 Thread Seth Forshee
On Thu, Aug 15, 2019 at 04:36:02PM +0200, Oleksandr Natalenko wrote: > Hey, people. > > I was lurking at shiftfs just out of curiosity and managed to bump into > a compiler warning that is (as I suppose) easily fixed by the subsequent > patch. > > Feel free to drag this into your Ubuntu tree if

[PATCH v2] kbuild: add -fcf-protection=none when using retpoline flags

2019-07-17 Thread Seth Forshee
enabled prevents such build failures. Signed-off-by: Seth Forshee --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 3e4868a6498b..73a94d1db2b6 100644 --- a/Makefile +++ b/Makefile @@ -878,6 +878,12 @@ KBUILD_CFLAGS += $(call cc-option,-Werror

Re: [kbuild:kbuild 5/19] drivers/atm/eni.o: warning: objtool: eni_init_one()+0xe42: indirect call found in RETPOLINE build

2019-07-17 Thread Seth Forshee
On Wed, Jul 17, 2019 at 11:52:07AM +0900, Masahiro Yamada wrote: > On Wed, Jul 17, 2019 at 1:20 AM Josh Poimboeuf wrote: > > > > On Tue, Jul 16, 2019 at 07:42:49AM -0500, Seth Forshee wrote: > > > On Tue, Jul 16, 2019 at 03:57:24PM +0900, Masahiro Yamada wrote: &

Re: [kbuild:kbuild 5/19] drivers/atm/eni.o: warning: objtool: eni_init_one()+0xe42: indirect call found in RETPOLINE build

2019-07-16 Thread Seth Forshee
On Tue, Jul 16, 2019 at 03:57:24PM +0900, Masahiro Yamada wrote: > (+ Josh Poimboeuf) > > On Tue, Jul 16, 2019 at 8:44 AM kbuild test robot wrote: > > > > tree: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > > kbuild > > head:

[PATCH] kbuild: add -fcf-protection=none to retpoline flags

2019-07-09 Thread Seth Forshee
-mindirect-branch and -fcf-protection are not compatible, and so kernel builds fail with a gcc build where -fcf-protection is enabled by default. Add -fcf-protection=none to the retpoline flags to fix this. Signed-off-by: Seth Forshee --- Makefile | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH] x86/ima: require signed kernel modules

2019-02-08 Thread Seth Forshee
On Tue, Feb 05, 2019 at 01:52:21PM -0500, Mimi Zohar wrote: > On Tue, 2019-02-05 at 12:32 -0600, Seth Forshee wrote: > > On Tue, Feb 05, 2019 at 11:47:24AM -0500, Mimi Zohar wrote: > > > Hi Seth, > > > > > > On Tue, 2019-02-05 at 09:18 -0600, Seth Forshee wrote

Re: [PATCH] x86/ima: require signed kernel modules

2019-02-05 Thread Seth Forshee
On Tue, Feb 05, 2019 at 11:47:24AM -0500, Mimi Zohar wrote: > Hi Seth, > > On Tue, 2019-02-05 at 09:18 -0600, Seth Forshee wrote: > > On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote: > > > Require signed kernel modules on systems with

Re: [PATCH] x86/ima: require signed kernel modules

2019-02-05 Thread Seth Forshee
On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote: > Require signed kernel modules on systems with secure boot mode enabled. > > To coordinate between appended kernel module signatures and IMA > signatures, only define an IMA MODULE_CHECK policy rule if > CONFIG_MODULE_SIG is not

Re: [RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 03:16:05PM +0200, Amir Goldstein wrote: > On Fri, Nov 2, 2018 at 2:44 PM Seth Forshee > wrote: > > > > On Fri, Nov 02, 2018 at 12:02:45PM +0200, Amir Goldstein wrote: > > > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > > > wrote: &

Re: [RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 03:16:05PM +0200, Amir Goldstein wrote: > On Fri, Nov 2, 2018 at 2:44 PM Seth Forshee > wrote: > > > > On Fri, Nov 02, 2018 at 12:02:45PM +0200, Amir Goldstein wrote: > > > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > > > wrote: &

Re: [RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 12:02:45PM +0200, Amir Goldstein wrote: > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > wrote: > > > > shiftfs mounts cannot be nested for two reasons -- global > > CAP_SYS_ADMIN is required to set up a mark mount, and a single > >

Re: [RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 12:02:45PM +0200, Amir Goldstein wrote: > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > wrote: > > > > shiftfs mounts cannot be nested for two reasons -- global > > CAP_SYS_ADMIN is required to set up a mark mount, and a single > >

Re: [RFC PATCH 0/6] shiftfs fixes and enhancements

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 10:59:38AM +0200, Amir Goldstein wrote: > [cc: linux-unionfs > It should the mailing list for *all* "stacking fs". > We have a lot of common problems I think ;-) ] > > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > wrote: > > > >

Re: [RFC PATCH 0/6] shiftfs fixes and enhancements

2018-11-02 Thread Seth Forshee
On Fri, Nov 02, 2018 at 10:59:38AM +0200, Amir Goldstein wrote: > [cc: linux-unionfs > It should the mailing list for *all* "stacking fs". > We have a lot of common problems I think ;-) ] > > On Thu, Nov 1, 2018 at 11:49 PM Seth Forshee > wrote: > > > >

[RFC PATCH 2/6] shiftfs: map inodes to lower fs inodes instead of dentries

2018-11-01 Thread Seth Forshee
to the watch original inode. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 105 ++- 1 file changed, 79 insertions(+), 26 deletions(-) diff --git a/fs/shiftfs.c b/fs/shiftfs.c index 6028244c2f42..b179a1be7bc1 100644 --- a/fs/shiftfs.c +++ b/fs

[RFC PATCH 2/6] shiftfs: map inodes to lower fs inodes instead of dentries

2018-11-01 Thread Seth Forshee
to the watch original inode. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 105 ++- 1 file changed, 79 insertions(+), 26 deletions(-) diff --git a/fs/shiftfs.c b/fs/shiftfs.c index 6028244c2f42..b179a1be7bc1 100644 --- a/fs/shiftfs.c +++ b/fs

[RFC PATCH 3/6] shiftfs: copy inode attrs up from underlying fs

2018-11-01 Thread Seth Forshee
that is going to be repeated. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/fs/shiftfs.c b/fs/shiftfs.c index b179a1be7bc1..556594988dd2 100644 --- a/fs/shiftfs.c +++ b/fs/shiftfs.c @@ -266,6 +266,33

[RFC PATCH 4/6] shiftfs: translate uids using s_user_ns from lower fs

2018-11-01 Thread Seth Forshee
Do not assume that ids from the lower filesystem are from init_user_ns. Instead, translate them from that filesystem's s_user_ns and then to the shiftfs user ns. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/shiftfs.c b

[RFC PATCH 3/6] shiftfs: copy inode attrs up from underlying fs

2018-11-01 Thread Seth Forshee
that is going to be repeated. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/fs/shiftfs.c b/fs/shiftfs.c index b179a1be7bc1..556594988dd2 100644 --- a/fs/shiftfs.c +++ b/fs/shiftfs.c @@ -266,6 +266,33

[RFC PATCH 4/6] shiftfs: translate uids using s_user_ns from lower fs

2018-11-01 Thread Seth Forshee
Do not assume that ids from the lower filesystem are from init_user_ns. Instead, translate them from that filesystem's s_user_ns and then to the shiftfs user ns. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/shiftfs.c b

[RFC PATCH 5/6] shiftfs: add support for posix acls

2018-11-01 Thread Seth Forshee
Signed-off-by: Seth Forshee --- fs/Kconfig | 10 +++ fs/shiftfs.c | 185 +++ 2 files changed, 195 insertions(+) diff --git a/fs/Kconfig b/fs/Kconfig index 392c5a41a9f9..691f3c4fc7eb 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -121,6 +121,16

[RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-01 Thread Seth Forshee
has already been marked safe for id shifting by a user privileged towards all ids in that mount's user ns. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 68 +++- 1 file changed, 46 insertions(+), 22 deletions(-) diff --git a/fs/shiftfs.c b/fs

[RFC PATCH 5/6] shiftfs: add support for posix acls

2018-11-01 Thread Seth Forshee
Signed-off-by: Seth Forshee --- fs/Kconfig | 10 +++ fs/shiftfs.c | 185 +++ 2 files changed, 195 insertions(+) diff --git a/fs/Kconfig b/fs/Kconfig index 392c5a41a9f9..691f3c4fc7eb 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -121,6 +121,16

[RFC PATCH 6/6] shiftfs: support nested shiftfs mounts

2018-11-01 Thread Seth Forshee
has already been marked safe for id shifting by a user privileged towards all ids in that mount's user ns. Signed-off-by: Seth Forshee --- fs/shiftfs.c | 68 +++- 1 file changed, 46 insertions(+), 22 deletions(-) diff --git a/fs/shiftfs.c b/fs

[RFC PATCH 1/6] shiftfs: uid/gid shifting bind mount

2018-11-01 Thread Seth Forshee
for path declarations to fix errors with struct randomization ] Signed-off-by: Seth Forshee --- v3 - update to 4.14 (d_real changes) v1 - based on original shiftfs with uid mappings now done via s_user_ns v2 - fix revalidation of dentries add inode aliasing --- fs/Kconfig

[RFC PATCH 0/6] shiftfs fixes and enhancements

2018-11-01 Thread Seth Forshee
code). I've also pushed these patches to: git://git.kernel.org/pub/scm/linux/kernel/git/sforshee/linux.git shiftfs Thanks, Seth [1] https://linuxplumbersconf.org/event/2/contributions/212/ --- James Bottomley (1): shiftfs: uid/gid shifting bind mount Seth Forshee (5): shiftfs: map inodes

[RFC PATCH 1/6] shiftfs: uid/gid shifting bind mount

2018-11-01 Thread Seth Forshee
for path declarations to fix errors with struct randomization ] Signed-off-by: Seth Forshee --- v3 - update to 4.14 (d_real changes) v1 - based on original shiftfs with uid mappings now done via s_user_ns v2 - fix revalidation of dentries add inode aliasing --- fs/Kconfig

[RFC PATCH 0/6] shiftfs fixes and enhancements

2018-11-01 Thread Seth Forshee
code). I've also pushed these patches to: git://git.kernel.org/pub/scm/linux/kernel/git/sforshee/linux.git shiftfs Thanks, Seth [1] https://linuxplumbersconf.org/event/2/contributions/212/ --- James Bottomley (1): shiftfs: uid/gid shifting bind mount Seth Forshee (5): shiftfs: map inodes

Re: [PATCH v3 0/1] shiftfs: uid/gid shifting filesystem

2018-07-17 Thread Seth Forshee
+Cc David On Fri, Jun 15, 2018 at 02:35:14PM -0700, James Bottomley wrote: > This is a repost of the v2 patch updated for the d_real changes > > For those who want to test it out, there's a git tree here > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git > > on the

Re: [PATCH v3 0/1] shiftfs: uid/gid shifting filesystem

2018-07-17 Thread Seth Forshee
+Cc David On Fri, Jun 15, 2018 at 02:35:14PM -0700, James Bottomley wrote: > This is a repost of the v2 patch updated for the d_real changes > > For those who want to test it out, there's a git tree here > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git > > on the

Re: [REVIEW][PATCH 2/6] vfs: Allow userns root to call mknod on owned filesystems.

2018-05-24 Thread Seth Forshee
On Thu, May 24, 2018 at 11:55:45AM -0500, Eric W. Biederman wrote: > Seth Forshee <seth.fors...@canonical.com> writes: > > > On Wed, May 23, 2018 at 06:25:34PM -0500, Eric W. Biederman wrote: > >> These filesystems already always set SB_I_NODEV so mknod will not be >

Re: [REVIEW][PATCH 2/6] vfs: Allow userns root to call mknod on owned filesystems.

2018-05-24 Thread Seth Forshee
On Thu, May 24, 2018 at 11:55:45AM -0500, Eric W. Biederman wrote: > Seth Forshee writes: > > > On Wed, May 23, 2018 at 06:25:34PM -0500, Eric W. Biederman wrote: > >> These filesystems already always set SB_I_NODEV so mknod will not be > >> useful for gaining co

Re: [REVIEW][PATCH 2/6] vfs: Allow userns root to call mknod on owned filesystems.

2018-05-24 Thread Seth Forshee
uld allow a mknod in an underlying filesystem which should not be allowed. That mknod will be subject to this same check in the underlying filesystem using the credentials of the user that mounted the overaly fs, which should be sufficient to ensure that the mknod is permitted. Thus this looks o

Re: [REVIEW][PATCH 2/6] vfs: Allow userns root to call mknod on owned filesystems.

2018-05-24 Thread Seth Forshee
ying filesystem which should not be allowed. That mknod will be subject to this same check in the underlying filesystem using the credentials of the user that mounted the overaly fs, which should be sufficient to ensure that the mknod is permitted. Thus this looks okay to me. Acked-by: Seth Forshee

Re: [REVIEW][PATCH 1/6] vfs: Don't allow changing the link count of an inode with an invalid uid or gid

2018-05-24 Thread Seth Forshee
; filesystem. To prevent possible filesystem and to avoid the need for > filesystem maintainers to worry about it don't allow operations on > inodes with an invalid uid or gid. > > Signed-off-by: "Eric W. Biederman" <ebied...@xmission.com> Acked-by: Seth Forshee <seth.fors...@canonical.com>

Re: [REVIEW][PATCH 1/6] vfs: Don't allow changing the link count of an inode with an invalid uid or gid

2018-05-24 Thread Seth Forshee
; filesystem. To prevent possible filesystem and to avoid the need for > filesystem maintainers to worry about it don't allow operations on > inodes with an invalid uid or gid. > > Signed-off-by: "Eric W. Biederman" Acked-by: Seth Forshee

Re: [PATCH] fuse: Ensure posix acls are translated outside of init_user_ns

2018-05-08 Thread Seth Forshee
e to deal with. This seems reasonable as a short-term measure. Acked-by: Seth Forshee <seth.fors...@canonical.com>

Re: [PATCH] fuse: Ensure posix acls are translated outside of init_user_ns

2018-05-08 Thread Seth Forshee
pts to handle this better last cycle. I > figure we should go with the stupid version for now. I think I know > how to do better but I don't want that to gate forward progress on > fully unprivileged fuse mounts. Especially as this is the last known > issue to deal with. This seems reasonable as a short-term measure. Acked-by: Seth Forshee

Re: [RFC PATCH v3 2/2] ima: force re-appraisal on filesystems with FS_IMA_NO_CACHE

2018-01-22 Thread Seth Forshee
Cc: "Serge E. Hallyn" <se...@hallyn.com> > Cc: Seth Forshee <seth.fors...@canonical.com> > Cc: Christoph Hellwig <h...@infradead.org> > Tested-by: Dongsu Park <don...@kinvolk.io> > Signed-off-by: Alban Crequy <al...@kinvolk.io> I like this appr

Re: [RFC PATCH v3 2/2] ima: force re-appraisal on filesystems with FS_IMA_NO_CACHE

2018-01-22 Thread Seth Forshee
nvolk/linux/commits/alban/fuse-flag-ima-nocache-v3 > [4] https://github.com/kinvolk/fuse-userns-patches/commit/cf1f5750cab0 > > Cc: linux-kernel@vger.kernel.org > Cc: linux-integr...@vger.kernel.org > Cc: linux-security-mod...@vger.kernel.org > Cc: linux-fsde...@vger.kernel.

Re: [PATCH 08/11] fuse: Support fuse filesystems outside of init_user_ns

2018-01-17 Thread Seth Forshee
On Wed, Jan 17, 2018 at 07:56:59PM +0100, Alban Crequy wrote: > On Wed, Jan 17, 2018 at 3:29 PM, Seth Forshee > <seth.fors...@canonical.com> wrote: > > On Wed, Jan 17, 2018 at 11:59:06AM +0100, Alban Crequy wrote: > >> [Adding Tejun, David, Tom for question about cus

Re: [PATCH 08/11] fuse: Support fuse filesystems outside of init_user_ns

2018-01-17 Thread Seth Forshee
On Wed, Jan 17, 2018 at 07:56:59PM +0100, Alban Crequy wrote: > On Wed, Jan 17, 2018 at 3:29 PM, Seth Forshee > wrote: > > On Wed, Jan 17, 2018 at 11:59:06AM +0100, Alban Crequy wrote: > >> [Adding Tejun, David, Tom for question about cuse] > >> > >> On Fr

Re: [PATCH 08/11] fuse: Support fuse filesystems outside of init_user_ns

2018-01-17 Thread Seth Forshee
On Wed, Jan 17, 2018 at 11:59:06AM +0100, Alban Crequy wrote: > [Adding Tejun, David, Tom for question about cuse] > > On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park <don...@kinvolk.io> wrote: > > From: Seth Forshee <seth.fors...@canonical.com> > > > > In

Re: [PATCH 08/11] fuse: Support fuse filesystems outside of init_user_ns

2018-01-17 Thread Seth Forshee
On Wed, Jan 17, 2018 at 11:59:06AM +0100, Alban Crequy wrote: > [Adding Tejun, David, Tom for question about cuse] > > On Fri, Dec 22, 2017 at 3:32 PM, Dongsu Park wrote: > > From: Seth Forshee > > > > In order to support mounts from namespaces other than > >

Re: Memory hotplug regression in 4.13

2017-12-22 Thread Seth Forshee
On Fri, Dec 22, 2017 at 10:12:40AM -0600, Seth Forshee wrote: > On Fri, Dec 22, 2017 at 03:49:25PM +0100, Michal Hocko wrote: > > On Mon 18-12-17 15:53:20, Michal Hocko wrote: > > > On Fri 01-12-17 08:23:27, Seth Forshee wrote: > > > > On Mon, Sep 25, 2017 at 02:58:

Re: Memory hotplug regression in 4.13

2017-12-22 Thread Seth Forshee
On Fri, Dec 22, 2017 at 10:12:40AM -0600, Seth Forshee wrote: > On Fri, Dec 22, 2017 at 03:49:25PM +0100, Michal Hocko wrote: > > On Mon 18-12-17 15:53:20, Michal Hocko wrote: > > > On Fri 01-12-17 08:23:27, Seth Forshee wrote: > > > > On Mon, Sep 25, 2017 at 02:58:

Re: Memory hotplug regression in 4.13

2017-12-22 Thread Seth Forshee
On Fri, Dec 22, 2017 at 03:49:25PM +0100, Michal Hocko wrote: > On Mon 18-12-17 15:53:20, Michal Hocko wrote: > > On Fri 01-12-17 08:23:27, Seth Forshee wrote: > > > On Mon, Sep 25, 2017 at 02:58:25PM +0200, Michal Hocko wrote: > > > > On Thu 21-09-1

Re: Memory hotplug regression in 4.13

2017-12-22 Thread Seth Forshee
On Fri, Dec 22, 2017 at 03:49:25PM +0100, Michal Hocko wrote: > On Mon 18-12-17 15:53:20, Michal Hocko wrote: > > On Fri 01-12-17 08:23:27, Seth Forshee wrote: > > > On Mon, Sep 25, 2017 at 02:58:25PM +0200, Michal Hocko wrote: > > > > On Thu 21-09-1

Re: Memory hotplug regression in 4.13

2017-12-01 Thread Seth Forshee
On Mon, Sep 25, 2017 at 02:58:25PM +0200, Michal Hocko wrote: > On Thu 21-09-17 00:40:34, Seth Forshee wrote: > > On Wed, Sep 20, 2017 at 11:29:31AM +0200, Michal Hocko wrote: > > > Hi, > > > I am currently at a conference so I will most probably get to this next > &

Re: Memory hotplug regression in 4.13

2017-12-01 Thread Seth Forshee
On Mon, Sep 25, 2017 at 02:58:25PM +0200, Michal Hocko wrote: > On Thu 21-09-17 00:40:34, Seth Forshee wrote: > > On Wed, Sep 20, 2017 at 11:29:31AM +0200, Michal Hocko wrote: > > > Hi, > > > I am currently at a conference so I will most probably get to this next > &

[PATCH] selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

2017-09-28 Thread Seth Forshee
and skip any paths which are too long for the filename buffer. Signed-off-by: Seth Forshee <seth.fors...@canonical.com> --- tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/powerp

[PATCH] selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

2017-09-28 Thread Seth Forshee
and skip any paths which are too long for the filename buffer. Signed-off-by: Seth Forshee --- tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c b/tools/testing

[PATCH] powerpc: Always initialize input array when calling epapr_hypercall()

2017-09-28 Thread Seth Forshee
in this function [-Werror=maybe-uninitialized] unsigned long register r3 asm("r3") = in[0]; ~~^~~ Fix callers to this function to always zero-initialize the input arguments array to prevent this. Signed-off-by: Seth Forshee <seth.fors...@canonical.c

[PATCH] powerpc: Always initialize input array when calling epapr_hypercall()

2017-09-28 Thread Seth Forshee
in this function [-Werror=maybe-uninitialized] unsigned long register r3 asm("r3") = in[0]; ~~^~~ Fix callers to this function to always zero-initialize the input arguments array to prevent this. Signed-off-by: Seth Forshee --- arch/powerpc/i

Re: Memory hotplug regression in 4.13

2017-09-20 Thread Seth Forshee
On Wed, Sep 20, 2017 at 11:29:31AM +0200, Michal Hocko wrote: > Hi, > I am currently at a conference so I will most probably get to this next > week but I will try to ASAP. > > On Tue 19-09-17 11:41:14, Seth Forshee wrote: > > Hi Michal, > > > > I'm seeing

Re: Memory hotplug regression in 4.13

2017-09-20 Thread Seth Forshee
On Wed, Sep 20, 2017 at 11:29:31AM +0200, Michal Hocko wrote: > Hi, > I am currently at a conference so I will most probably get to this next > week but I will try to ASAP. > > On Tue 19-09-17 11:41:14, Seth Forshee wrote: > > Hi Michal, > > > > I'm seeing

Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h

2017-09-07 Thread Seth Forshee
On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote: > The 2.26 release of glibc changed how siginfo_t is defined, and the earlier > work-around to using the kernel definition are no longer needed. The old > way needs to stay around for a while, though. > > Reported-b

Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h

2017-09-07 Thread Seth Forshee
On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote: > The 2.26 release of glibc changed how siginfo_t is defined, and the earlier > work-around to using the kernel definition are no longer needed. The old > way needs to stay around for a while, though. > > Reported-by: Set

seccomp selftest fails to build with glibc 2.26

2017-09-07 Thread Seth Forshee
Hi Kees, I'm seeing build failures with your seccomp selftest when using glibc 2.26. The first are related to changing macro names from __have_sig*_t to __sig*_t_defined. But after defining those there are more conflicting definitions. I was able to get it to build with the changes below, however

seccomp selftest fails to build with glibc 2.26

2017-09-07 Thread Seth Forshee
Hi Kees, I'm seeing build failures with your seccomp selftest when using glibc 2.26. The first are related to changing macro names from __have_sig*_t to __sig*_t_defined. But after defining those there are more conflicting definitions. I was able to get it to build with the changes below, however

[PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace

2017-06-23 Thread Seth Forshee
088 ("scsi: aacraid: Retrieve HBA host information ioctl") Signed-off-by: Seth Forshee <seth.fors...@canonical.com> --- drivers/scsi/aacraid/commctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c index d2f8d59

[PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace

2017-06-23 Thread Seth Forshee
088 ("scsi: aacraid: Retrieve HBA host information ioctl") Signed-off-by: Seth Forshee --- drivers/scsi/aacraid/commctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c index d2f8d5954840..476ada6e39d0 100644 --- a/

Re: audit regressions in 4.11

2017-04-09 Thread Seth Forshee
On Sun, Apr 09, 2017 at 09:14:03AM -0400, Paul Moore wrote: > On Sat, Apr 8, 2017 at 11:02 PM, Seth Forshee > <seth.fors...@canonical.com> wrote: > > I've observed audit regressions in 4.11-rc when not using a userspace > > audit daemon. The most obvious issu

Re: audit regressions in 4.11

2017-04-09 Thread Seth Forshee
On Sun, Apr 09, 2017 at 09:14:03AM -0400, Paul Moore wrote: > On Sat, Apr 8, 2017 at 11:02 PM, Seth Forshee > wrote: > > I've observed audit regressions in 4.11-rc when not using a userspace > > audit daemon. The most obvious issue is that audit messages are not > > ap

audit regressions in 4.11

2017-04-08 Thread Seth Forshee
I've observed audit regressions in 4.11-rc when not using a userspace audit daemon. The most obvious issue is that audit messages are not appearing in dmesg anymore. If a sufficient number of audit messages are generated the kernel will also start invoking the OOM killer. It looks like

audit regressions in 4.11

2017-04-08 Thread Seth Forshee
I've observed audit regressions in 4.11-rc when not using a userspace audit daemon. The most obvious issue is that audit messages are not appearing in dmesg anymore. If a sufficient number of audit messages are generated the kernel will also start invoking the OOM killer. It looks like

Re: [PATCH] vfs: Partially revert addition of cred override in follow_automount()

2017-02-22 Thread Seth Forshee
e_creds() and > revert_creds() and their variable. > > Fixes: aeaa4a79ff6a ("fs: Call d_automount with the filesystems creds") > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Seth Forshee <seth.fors...@canonical.com> > cc: "Eric W. Bi

Re: [PATCH] vfs: Partially revert addition of cred override in follow_automount()

2017-02-22 Thread Seth Forshee
ds() and their variable. > > Fixes: aeaa4a79ff6a ("fs: Call d_automount with the filesystems creds") > Signed-off-by: David Howells > cc: Seth Forshee > cc: "Eric W. Biederman" > cc: Al Viro Eric's already applied a patch that should fix this problem. As

Re: cifs mount regression in 4.8 and 4.4 stable

2016-09-23 Thread Seth Forshee
On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote: > On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote: > > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote: > > > We've received reports from users of a cifs mount regression in our > > >

Re: cifs mount regression in 4.8 and 4.4 stable

2016-09-23 Thread Seth Forshee
On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote: > On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote: > > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote: > > > We've received reports from users of a cifs mount regression in our > > >

Re: cifs mount regression in 4.8 and 4.4 stable

2016-09-22 Thread Seth Forshee
On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote: > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote: > > We've received reports from users of a cifs mount regression in our > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing > > comm

Re: cifs mount regression in 4.8 and 4.4 stable

2016-09-22 Thread Seth Forshee
On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote: > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote: > > We've received reports from users of a cifs mount regression in our > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing > > comm

cifs mount regression in 4.8 and 4.4 stable

2016-09-22 Thread Seth Forshee
We've received reports from users of a cifs mount regression in our 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing commit from 4.8 which was applied to 4.4 stable: a6b5058 fs/cifs: make share unaccessible at root level mountable Testing against 4.8-rc7 shows that the problem

cifs mount regression in 4.8 and 4.4 stable

2016-09-22 Thread Seth Forshee
We've received reports from users of a cifs mount regression in our 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing commit from 4.8 which was applied to 4.4 stable: a6b5058 fs/cifs: make share unaccessible at root level mountable Testing against 4.8-rc7 shows that the problem

[PATCH RESEND] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
interface to modules, then use it in xenbus when creating /proc/xen. Acked-by: David Vrabel <david.vra...@citrix.com> Signed-off-by: Seth Forshee <seth.fors...@canonical.com> --- Resending to add some Cc's I missed the first time. drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/proc/generic

[PATCH RESEND] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
interface to modules, then use it in xenbus when creating /proc/xen. Acked-by: David Vrabel Signed-off-by: Seth Forshee --- Resending to add some Cc's I missed the first time. drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/proc/generic.c | 1 + fs/proc/internal.h| 1

Re: [Xen-devel] [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
On Tue, Aug 30, 2016 at 04:00:03PM +0100, David Vrabel wrote: > On 29/08/16 16:03, Seth Forshee wrote: > > Mounting proc in user namespace containers fails if the xenbus > > filesystem is mounted on /proc/xen because this directory fails > > the "permanently empty"

Re: [Xen-devel] [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
On Tue, Aug 30, 2016 at 04:00:03PM +0100, David Vrabel wrote: > On 29/08/16 16:03, Seth Forshee wrote: > > Mounting proc in user namespace containers fails if the xenbus > > filesystem is mounted on /proc/xen because this directory fails > > the "permanently empty"

Re: [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
On Tue, Aug 30, 2016 at 04:48:08PM +0200, Juergen Gross wrote: > On 29/08/16 17:03, Seth Forshee wrote: > > Mounting proc in user namespace containers fails if the xenbus > > filesystem is mounted on /proc/xen because this directory fails > > the "permanently empty"

Re: [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread Seth Forshee
On Tue, Aug 30, 2016 at 04:48:08PM +0200, Juergen Gross wrote: > On 29/08/16 17:03, Seth Forshee wrote: > > Mounting proc in user namespace containers fails if the xenbus > > filesystem is mounted on /proc/xen because this directory fails > > the "permanently empty"

[PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-29 Thread Seth Forshee
interface to modules, then use it in xenbus when creating /proc/xen. Signed-off-by: Seth Forshee <seth.fors...@canonical.com> --- drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/proc/generic.c | 1 + fs/proc/internal.h| 1 - include/linux/proc_fs.h | 2 ++ 4

[PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-29 Thread Seth Forshee
interface to modules, then use it in xenbus when creating /proc/xen. Signed-off-by: Seth Forshee --- drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/proc/generic.c | 1 + fs/proc/internal.h| 1 - include/linux/proc_fs.h | 2 ++ 4 files changed, 4 insertions(+), 2

  1   2   3   4   5   6   7   8   9   10   >