Hi Brice:
> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS690,
> > quirk_disable_all_msi);
>
> This patch disable MSI for the _whole_ system, not only behind the
> RS690. Is this on purpose? Is MSI really going to be broken on any
> bus that's _not_ behind RS690. If not, you
Hi Tejun:
> Okay, here's reformatted in-line version. Shane, please invest some
> time into setting up email environment. Sending patches via email is
> an important part of the linux kernel development process and if
> you're gonna submit patches, you're just gonna have to do it.
Right. In
because 0x4395 is SB800 device
ID.
Signed-off-by: Shane Huang <[EMAIL PROTECTED]>
diff -ruN linux-2.6.24-rc7_org/drivers/pci/quirks.c
linux-2.6.24-rc7_new/drivers/pci/quirks.c
--- linux-2.6.24-rc7_org/drivers/pci/quirks.c 2008-01-23
14:44:53.0 +0800
+++ linux-2.6.24-rc7_new/drive
Hi Tejun:
> You need to merge the above two messages into one patch description.
>
> After S-O-B, you can put --- and between it and the patch
> body, you can say things which you wanna mention but don't
> think should be included in commit message.
OK, I'll have to submit another update patc
I did some modification to this patch and send it again, Please check
it.
The quirk to 0x4395 has been removed because 0x4395 only belongs to
SB800.
Thanks
Shane
> -Original Message-
> From: Shane Huang
>
> SB700 SATA MSI bug will be fixed in SB700 revision A21 at
>
SB700 SATA MSI bug will be fixed in SB700 revision A21 at hardware
level,
but the SB700 revision older than A21 will also be found in the market.
This patch modify the original quirk commit
bc38b411fe696fad32b261f492cb4afbf1835256 instead of withdrawing it.
Signed-off-by: Shane Huang <[EM
RS690 is the workaround.
Signed-off-by: Shane Huang <[EMAIL PROTECTED]>
Since there is some word wrapping problem with my mail client MS outlook
if I copy the patch into the text, so I'll also attach the patch as an
attachment. Please check it.
diff -ruN old/drivers/pci/quirks.c
> I would like those to be removed, but to be conservative we should
> first get some testing feedback that confirms this just like those
> provided to me from the AMD folks for the RS690, RX790 and RD580
> cases.
>
> Otherwise the risk to break people's systems is very real.
In fact, our team o
PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; Shane Huang;
[EMAIL PROTECTED];
> [EMAIL PROTECTED]; [EMAIL PROTECTED]
> Subject: [PATCH 4/4]: [PCI]: Add MSI INTX_DISABLE quirks for ATI
SB700/800 SATA and IXP SB400 USB
>
>
> Signed-off-by: David S. Miller <[EMAIL PROTECTED]&g
> If the pci_intx change will be applied to the SATA driver, can it be
> applied for the ATI USB-HCDs too? See
> http://lkml.org/lkml/2006/12/21/47 for more details. That should help
> most of the ATI MSI quirks. It helped me (Acer Aspire 502x laptop with
> ATI RS480/SB400).
I checked the USB MSI
Hi David:
> I think this pretty much sums up the situation accurately.
>
> My suggestion is:
>
> 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
>
> 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
>a flag in the pci_dev.
>
> 3) The pci_intx() calls in drivers/pci/
Hi David
>> When I used "here", I was just meaning our youthful linux southbridge
>> drivers team instead of the whole AMD. Sorry for the confusion to you.
>
> I am still somewhat confused: most people developing the Linux kernel
> are limited to look at this hardware from the outside. They had t
Quoting "David G"
> "Here" as in "here at AMD"?! I'm stunned...
> Both AMD and the former ATI should have quite some experience?!
When I used "here", I was just meaning our youthful linux southbridge
drivers team instead of the whole AMD. Sorry for the confusion to you.
Quoting "Linas"
> As so
Hi Guys:
> This logic seems backwards, to me. "shoot first, ask questions later"
> To me this it not how to approach this problem.
>
> Once you turn MSI off, there is next to no incentive to fix the
> problem because users aren't running into it any longer.
>
> The only two devices in that bug r
forms.
BTW, There already some disablements to some ATI NB MSIs in the kernel,
the reasons are similar.
Thanks
Shane
> -Original Message-
> From: David Miller [mailto:[EMAIL PROTECTED]
> Sent: Thursday, October 18, 2007 6:20 PM
> To: Shane Huang
> Cc: [EMAIL PROTECTED]; [EMA
More ATI North Bridges like RS780 can't do MSI like its predecessors
in linux. Disable MSIs on them.
Signed-off-by: Shane Huang <[EMAIL PROTECTED]>
Since there is some word wrapping problem with my mail client MS outlook
if I copy the patch into the text, so I'll have to attach
16 matches
Mail list logo
