Hi Thirumalesha,
I think it is better to split the patch into two:
1. Changes for the devices which are already present
2. For the device MT29F2G01AAAED, which you want to add
>
> The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> ECC
>
> Signed-off-by: Thirumalesha
Hi Thirumalesha,
>
> The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> ECC
>
> Signed-off-by: Thirumalesha Narasimhappa
> ---
> drivers/mtd/nand/spi/micron.c | 77 +++
> 1 file changed, 77 insertions(+)
>
> diff --git
Hi Naresh and Poonam,
> Subject: [EXT] Re: [PATCH v7 0/6] Add new series Micron SPI NAND devices
>
> Hi Poonam,
>
> Poonam Aggrwal wrote on Fri, 15 May 2020
> 05:29:07 +:
>
> > Adding Ashish.
> >
> > Regards
> > Poonam
> >
> > > -Original Message-
> > > From: Naresh Kamboju
> > >
Hi Boris,
Thank you for the review.
>
> On Mon, 19 Aug 2019 09:03:38 +0000
> "Shivamurthy Shastri (sshivamurthy)" wrote:
>
> > >
> > > > static int micron_spinand_detect(struct spinand_device *spinand)
> > > > {
> > > > +
Hello Miquel & Boris,
Just a gentle reminder that I'd like some feedback.
Thanks,
Shiva
>
> Hi Boris,
>
> Another question for you :)
>
> "Shivamurthy Shastri (sshivamurthy)" wrote
> on
> Mon, 19 Aug 2019 08:51:52 +:
>
> > Hi Miquel,
>
Hello Miquel & Boris,
Just a gentle reminder that I'd like some feedback.
Thanks,
Shiva
>
> Hi Boris,
>
> I need your opinion on the question below.
>
> "Shivamurthy Shastri (sshivamurthy)" wrote
> on
> Mon, 19 Aug 2019 09:03:38 +:
>
Hi Miquel,
>
> Hi Shiva,
>
> shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200:
>
> > From: Shivamurthy Shastri
> >
>
> I am not sure the "turn implemenatation generic" title describes what
> you do.
>
> > Driver is redesigned using parameter page to support Micron SPI
Hi Miquel,
>
> Hi Shiva,
>
> shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:17 +0200:
>
> "mtd: spinand: enable parameter page support"
>
> > From: Shivamurthy Shastri
> >
> > Some of the SPI NAND devices has parameter page, which is similar to
> -
Hi Miquel,
>
> Hi shiva.linuxwo...@gmail.com,
>
> shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:15 +0200:
>
> > From: Shivamurthy Shastri
>
> "mtd: nand: move ONFI specific helpers to nand/onfi.c"?
I will use this.
>
> >
> > These functions are support functions for enabling
Hi Miquel,
Thanks for reviewing.
>
> Hi Shiva,
>
> shiva.linuxwo...@gmail.com wrote on Mon, 22 Jul 2019 07:56:14 +0200:
>
> > From: Shivamurthy Shastri
> >
> > These functions will be used by both raw NAND and SPI NAND, which
> > supports ONFI like standards.
>
> This is not exactly what
Hi Boris,
> > Create onfi_helper object. This is base to turn ONFI code to generic.
> >
> > Signed-off-by: Shivamurthy Shastri
> > ---
> > include/linux/mtd/nand.h | 21 +
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/include/linux/mtd/nand.h
Move generic ONFI code to nand/ directory, which can be used by SPI
NAND layer.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/Makefile| 2 +-
drivers/mtd/nand/{raw/nand_onfi.c => onfi.c} | 1 +
drivers/mtd/nand/raw/Makefile| 1 -
3 files changed, 2
Parameter page not following any standard. Hence, manufacturers may
interpret parameters differently, and it is better to have a fixup
function.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/spi/core.c | 6 ++
include/linux/mtd/spinand.h | 2 ++
2 files changed, 8 insertions(+)
ONFI reated functions are used by nand_jedec.c and in next patch
nand_onfi.c will be moving to nand/ directory, it is necessary to move
these functions to nand.h.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/raw/internals.h | 4
drivers/mtd/nand/raw/nand_onfi.c | 8
>From 654f8acf5d0724fda54c352cc91b0ab576dff928 Mon Sep 17 00:00:00 2001
From: Shivamurthy Shastri
Date: Tue, 7 May 2019 15:19:22 +0200
Subject: [PATCH 09/12] mtd: spinand: micron: prepare for generalizing driver
Generalize OOB layout structure and function names.
Signed-off-by: Shivamurthy
Driver is redesigned using parameter page to support Micron SPI NAND
flashes.
The reason why spinand_select_op_variant globalized is that the Micron
driver no longer calling spinand_match_and_init.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/spi/core.c | 2 +-
Create onfi_helper object. This is base to turn ONFI code to generic.
Signed-off-by: Shivamurthy Shastri
---
include/linux/mtd/nand.h | 21 +
1 file changed, 21 insertions(+)
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 3cdf06cae8b6..645dde4c5797
Instantiate onfi_helper object for SPI NAND.
Enable SPI NAND core to detect SPI NANDs with parameter page.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/spi/core.c | 103
1 file changed, 103 insertions(+)
diff --git a/drivers/mtd/nand/spi/core.c
Some of the Micron flashes has multi-die, and need to select the die
each time while accessing it.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/spi/micron.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/mtd/nand/spi/micron.c
M70A series flashes by default enable continuous read feature (BIT0 in
configuration register). This feature will not expose the ECC to host
and causing read failure.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/spi/micron.c | 10 ++
1 file changed, 10 insertions(+)
diff
It is necessary to turn nand_onfi_detect to use nand_device structure,
to make ONFI related codes generic for all NAND devices.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/raw/internals.h | 2 +-
drivers/mtd/nand/raw/nand_base.c | 2 +-
drivers/mtd/nand/raw/nand_onfi.c | 8 +---
Instantiate the onfi_helper object for raw NAND and turn ONFI support to
generic. Later this generic ONFI code will be used by SPI NAND as well.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/raw/nand_base.c | 218 ++-
drivers/mtd/nand/raw/nand_onfi.c | 183
sanitize_strings is not used in nand_base.c but used in nand_onfi.c. It
is better to move sanitize_strings definition to nand_onfi.c, with this
all ONFI related functions will be in the same file.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/raw/nand_base.c | 18 --
Current support to ONFI parameter page is only for raw NAND, this patch
series turn ONFI support into generic. So that, other NAND devices like
SPI NAND can use this.
There are five parts in this series.
1. Prepare for turning ONFI into generic
2. Turn ONFI into generic, which can be used by SPI
Hi Miquel,
> > >
> > > > Some of the SPI NAND devices has parameter page which is similar to
> ONFI
> > > > table.
> > > >
> > > > But, it may not be self sufficient to propagate all the required
> > > > parameters. Fixup function has been added in struct manufacturer to
> > > > accommodate this.
Hi Miquel,
>
> Hi Shivamurthy,
>
> "Shivamurthy Shastri (sshivamurthy)" wrote
> on
> Tue, 26 Mar 2019 10:52:04 +:
>
> > Driver is redesigned using parameter page to support Micron SPI NAND
> > flashes.
> >
> > Support for selecting di
Hi Miquel,
>
> Hi Shivamurthy,
>
> "Shivamurthy Shastri (sshivamurthy)" wrote
> on
> Tue, 26 Mar 2019 10:52:00 +:
>
> > Some of the SPI NAND devices has parameter page which is similar to ONFI
> > table.
> >
> > But, it m
Hi Miquel,
> Hi Shivamurthy,
>
> Sorry for the long delay I was a bit overloaded.
>
> "Shivamurthy Shastri (sshivamurthy)" wrote
> on
> Tue, 26 Mar 2019 10:51:47 +:
>
> > Fix headers to make way for adding helper functions.
> >
> > Add
Some of the SPI NAND devices has parameter page which is similar to ONFI
table.
But, it may not be self sufficient to propagate all the required
parameters. Fixup function has been added in struct manufacturer to
accommodate this.
Signed-off-by: Shivamurthy Shastri
---
Move generic ONFI code to nand/ directory, which can be used by SPI
NAND layer.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/Makefile| 2 +-
drivers/mtd/nand/{raw/nand_onfi.c => onfi.c} | 0
drivers/mtd/nand/raw/Makefile| 1 -
3 files changed, 1
Driver is redesigned using parameter page to support Micron SPI NAND
flashes.
Support for selecting die is enabled for multi-die flashes.
Turn OOB layout generic.
Fixup some of the parameter page data as per Micron datasheet.
Signed-off-by: Shivamurthy Shastri
---
Current support to ONFI parameter page is only for raw NAND, this patch
series turn ONFI support into generic. So that, other NAND devices like SPI
NAND can use this.
Support to detect parameter page is enabled in SPI NAND core.
Turned Micron SPI NAND driver to use parameter page.
>From SPI
Fix headers to make way for adding helper functions.
Add onfi helper structure.
Add helper functions in raw NAND core, which later will be used during
ONFI detection.
Signed-off-by: Shivamurthy Shastri
---
drivers/mtd/nand/raw/internals.h | 6 +-
drivers/mtd/nand/raw/nand_base.c | 236
Hi Boris,
> -Original Message-
> From: Boris Brezillon
> Sent: Monday, February 4, 2019 7:02 PM
> To: Shivamurthy Shastri (sshivamurthy)
> Cc: Miquel Raynal ; linux-
> m...@lists.infradead.org; linux-kernel@vger.kernel.org; Chuanhong Guo
> ; Richard Weinberger
Hi Emil,
> Hi,
>
> Den mån 4 feb. 2019 kl 12:18 skrev Shivamurthy Shastri (sshivamurthy)
> :
> >
> > Driver is redesigned using parameter page to support all the Micron
> > SPI NAND flashes.
> >
> > Parameter page of Micron flashes is similar to ONFI par
Driver is redesigned using parameter page to support all the Micron
SPI NAND flashes.
Parameter page of Micron flashes is similar to ONFI parameter table and
functionality is same, so copied some of the common functions like crc16
and bit_wise_majority from nand_onfi.c.
This driver is tested
Some of the manufacturers support parameter page, which can be used
to get the device details during detection.
This function reads parameter page and this page can be accessed by
set of commands, which are common across the manufacturers.
Signed-off-by: Shivamurthy Shastri
Reviewed-by: Bean
Parameter page is supported by some of the manufacturers and instead of
maintaining spinand_info structure for each flash it is better to use
the parameter page to get the flash info. As I have seen the different
datasheets, command required to access parameter page is same across the
38 matches
Mail list logo
