Re: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()

2012-11-08 Thread Shreyas Bhatewara
- Original Message - > Signed-off-by: Sasha Levin > --- > drivers/net/vmxnet3/vmxnet3_drv.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Shreyas N Bhatewara -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()

2012-11-08 Thread Shreyas Bhatewara
- Original Message - Signed-off-by: Sasha Levin sasha.le...@oracle.com --- drivers/net/vmxnet3/vmxnet3_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Shreyas N Bhatewara sbhatew...@vmware.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] vmxnet3: must split too big fragments

2012-10-29 Thread Shreyas Bhatewara
> > Signed-of-by: Shreyas Bhatewara Pardon the typo. And also, thanks to Jongman for testing. Signed-off-by: Shreyas Bhatewara -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH] vmxnet3: must split too big fragments

2012-10-29 Thread Shreyas Bhatewara
; > Signed-off-by: Eric Dumazet > Reported-by: jongman heo > Tested-by: jongman heo > Cc: Shreyas Bhatewara > --- > drivers/net/vmxnet3/vmxnet3_drv.c | 65 > +++- > 1 file changed, 45 insertions(+), 20 deletions(-) > Thanks f

Re: [PATCH] vmxnet3: must split too big fragments

2012-10-29 Thread Shreyas Bhatewara
-off-by: Eric Dumazet eduma...@google.com Reported-by: jongman heo jongman@samsung.com Tested-by: jongman heo jongman@samsung.com Cc: Shreyas Bhatewara sbhatew...@vmware.com --- drivers/net/vmxnet3/vmxnet3_drv.c | 65 +++- 1 file changed, 45 insertions(+), 20

Re: [PATCH] vmxnet3: must split too big fragments

2012-10-29 Thread Shreyas Bhatewara
Signed-of-by: Shreyas Bhatewara sbhatew...@vmware.com Pardon the typo. And also, thanks to Jongman for testing. Signed-off-by: Shreyas Bhatewara sbhatew...@vmware.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted

2012-10-23 Thread Shreyas Bhatewara
Well, actually the driver does split large frags into frags of VMXNET3_MAX_TX_BUF_SIZE bytes each. vmxnet3_drv.c 711 while (len) { 712 u32 buf_size; 713 714 if (len < VMXNET3_MAX_TX_BUF_SIZE) { 715 buf_size = len; 716

Re: 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted

2012-10-23 Thread Shreyas Bhatewara
Eric, thanks for the note. I will submit a patch to do it. Shreyas - Original Message - > On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote: > > > > > FYI, vmxnet3 driver is used for ethernet. > > Yes, this driver needs some changes > > #define VMXNET3_MAX_TX_BUF_SIZE (1 << 14) >

Re: 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted

2012-10-23 Thread Shreyas Bhatewara
Eric, thanks for the note. I will submit a patch to do it. Shreyas - Original Message - On Tue, 2012-10-23 at 08:17 +, Jongman Heo wrote: FYI, vmxnet3 driver is used for ethernet. Yes, this driver needs some changes #define VMXNET3_MAX_TX_BUF_SIZE (1 14) Thats 16KB

Re: [Pv-drivers] 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted

2012-10-23 Thread Shreyas Bhatewara
Well, actually the driver does split large frags into frags of VMXNET3_MAX_TX_BUF_SIZE bytes each. vmxnet3_drv.c 711 while (len) { 712 u32 buf_size; 713 714 if (len VMXNET3_MAX_TX_BUF_SIZE) { 715 buf_size = len; 716