Re: [PATCH HID v3 0/9] HID: bpf: add a new hook to control hid-generic

2024-10-02 Thread Shuah Khan
tools/testing/selftests/hid/progs/hid.c| 12 ++ .../testing/selftests/hid/progs/hid_bpf_helpers.h | 6 +- 12 files changed, 296 insertions(+), 151 deletions(-) I am assuming selftests go with the driver changes. For selftests: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/vdso: Add linux/sched.h to fix CLONE_NEWTIME build error

2024-10-02 Thread Shuah Khan
On 10/2/24 09:28, SurajSonawane2415 wrote: Fix build error in vdso_test_getrandom.c due to missing CLONE_NEWTIME. Include linux/sched.h to define CLONE_NEWTIME. Ensure successful compilation by resolving the missing header issue. Did you run "make headers" before building this test? It builds

Re: [PATCH net-next v8 24/24] testing/selftest: add test tool and scripts for ovpn module

2024-10-02 Thread Shuah Khan
On 10/2/24 03:02, Antonio Quartulli wrote: The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. Does this test load ovpn module before running tests? If so does it unload the modules after tests are complete? It implementes the netlink API and can thus be integr

Re: [PATCH] Revert "list: test: fix tests for list_cut_position()"

2024-10-02 Thread Shuah Khan
On 9/30/24 17:18, Jacob Keller wrote: On 9/22/2024 8:05 AM, Guenter Roeck wrote: This reverts commit e620799c414a035dea1208bcb51c869744931dbb. The commit introduces unit test failures. Expected cur == &entries[i], but cur == 037fffadfd80 &entries[i] == 037ff

Re: [PATCH v3] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python3

2024-10-02 Thread Shuah Khan
On 10/2/24 03:00, Alessandro Zanni wrote: Hello, this email is just a friendly reminder to know if the present patch is going to be applied or not. Thank you. Best Regards, Alessandro Zanni No top posting please. On 24/08/06 02:14, Alessandro Zanni wrote: Insert raw strings to prevent Py

Re: [PATCH v3 2/2] selftests/exec: add a test to enforce execveat()'s comm

2024-10-01 Thread Shuah Khan
On 10/1/24 07:49, Tycho Andersen wrote: From: Tycho Andersen We want to ensure that /proc/self/comm stays useful for execveat() callers. This commit message is vague? What does staying useful mean? Elaborate on the staying useful and the tests added to ensure. Add test results as well. Sig

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

2024-10-01 Thread Shuah Khan
On 9/30/24 20:43, luyun wrote: 在 2024/10/1 04:57, Shuah Khan 写道: On 9/30/24 02:38, Benjamin Tissoires wrote: On Sep 29 2024, Yun Lu wrote: The HID test cases actually run tests using the run-hid-tools-tests.sh script. However, if installed with "make install", the run-hid-tool

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

2024-09-30 Thread Shuah Khan
On 9/30/24 02:38, Benjamin Tissoires wrote: On Sep 29 2024, Yun Lu wrote: The HID test cases actually run tests using the run-hid-tools-tests.sh script. However, if installed with "make install", the run-hid-tools-tests.sh script will not be copied over, resulting in the following error message.

Re: update core.c

2024-09-30 Thread Shuah Khan
On 9/29/24 16:40, Okan Tümüklü wrote: 1:The control flow was simplified by using else if statements instead of goto structure. 2:Error conditions are handled more clearly. 3:The device_unlock call at the end of the function is guaranteed in all cases. Github request : https://github.com/torva

Re: [PATCH] selftests: timers: improve timer_create failure message

2024-09-30 Thread Shuah Khan
On 9/30/24 13:19, John Stultz wrote: On Mon, Sep 30, 2024 at 11:49 AM Shuah Khan wrote: Jon, Does this look good to you? I can pick this up if you okay with this change. No objection from me, sorry this slipped by me. Acked-by: John Stultz Thank you. Applied to linux-kselftest next

Re: [PATCH] selftests: timers: improve timer_create failure message

2024-09-30 Thread Shuah Khan
On 8/29/24 09:37, Gianfranco Trad wrote: improve timer_create failure message with strerror() function to give more information to the user. Signed-off-by: Gianfranco Trad --- tools/testing/selftests/timers/alarmtimer-suspend.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: [PATCH v3 5/5] selftests: exec: update gitignore for load_address

2024-09-30 Thread Shuah Khan
On 9/25/24 15:55, Javier Carrasco wrote: The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore file to account for the new names, adding an exception to keep on tracking load_add

Re: [PATCH v3 1/5] selftests: core: add unshare_test to gitignore

2024-09-30 Thread Shuah Khan
On 9/25/24 15:55, Javier Carrasco wrote: This executable is missing from the corresponding gitignore file. Add unshare_test to the core gitignore list. Signed-off-by: Javier Carrasco --- tools/testing/selftests/core/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing

Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data

2024-09-28 Thread Shuah Khan
On 9/28/24 11:54, Shuah Khan wrote: On 9/28/24 11:31, Guenter Roeck wrote: On 9/27/24 17:08, Guenter Roeck wrote: On 9/27/24 13:45, Shuah Khan wrote: On 9/27/24 10:19, Guenter Roeck wrote: Copying devicetree maintainers. On Thu, Sep 26, 2024 at 09:39:38PM -0700, Guenter Roeck wrote: On Thu

Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data

2024-09-28 Thread Shuah Khan
On 9/28/24 11:31, Guenter Roeck wrote: On 9/27/24 17:08, Guenter Roeck wrote: On 9/27/24 13:45, Shuah Khan wrote: On 9/27/24 10:19, Guenter Roeck wrote: Copying devicetree maintainers. On Thu, Sep 26, 2024 at 09:39:38PM -0700, Guenter Roeck wrote: On Thu, Sep 26, 2024 at 09:14:11PM -0700

[GIT PULL] Kselftest fixes update for Linux 6.12-rc1

2024-09-28 Thread Shuah Khan
Hi Linus, Please pull this fixes update for Linux 6.12-rc1. This kselftest fixes update for Linux 6.12-rc1 consists of an urgent fix to vDSO as automated testing is failing due to this bug. diff is attached. thanks, -- Shuah The

Re: [PATCH] selftests: vDSO: align stack for O2-optimized memcpy

2024-09-27 Thread Shuah Khan
On 9/27/24 11:24, Jason A. Donenfeld wrote: Hi Shuah, On Tue, Sep 24, 2024 at 01:47:23PM +0200, Jason A. Donenfeld wrote: When switching on -O2, gcc generates SSE2 instructions that assume a 16-byte aligned stack, which the standalone test's start point wasn't aligning. Fix this with the usual

Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data

2024-09-27 Thread Shuah Khan
On 9/27/24 10:19, Guenter Roeck wrote: Copying devicetree maintainers. On Thu, Sep 26, 2024 at 09:39:38PM -0700, Guenter Roeck wrote: On Thu, Sep 26, 2024 at 09:14:11PM -0700, Guenter Roeck wrote: Hi Stephen, On Thu, Jul 18, 2024 at 02:05:07PM -0700, Stephen Boyd wrote: Test that clks regist

Re: [PATCH v1 1/2] selftests/mm: hugetlb_fault_after_madv: use default hguetlb page size

2024-09-26 Thread Shuah Khan
e_size, MADV_DONTNEED); Magical effects of hard-coded values :) Thank you for fixing this Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables

2024-09-25 Thread Shuah Khan
. Thank you. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Shuah Khan
On 9/25/24 10:25, Javier Carrasco wrote: On 25/09/2024 17:46, Shuah Khan wrote: On 9/24/24 06:49, Javier Carrasco wrote: The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the

Re: [PATCH] clone3: clone3_cap_checkpoint_restore: remove unused MAX_PID_NS_LEVEL macro

2024-09-25 Thread Shuah Khan
On 9/25/24 02:34, Christian Brauner wrote: On Tue, Sep 03, 2024 at 11:36:28AM GMT, Ba Jing wrote: The macro MAX_PID_NS_LEVEL is never referenced in the code, so remove it. Signed-off-by: Ba Jing --- Reviewed-by: Christian Brauner Quick note to say that I will apply the patch after the mer

Re: [PATCH] selftests: Makefile: create OUTPUT dir

2024-09-25 Thread Shuah Khan
On 9/20/24 04:38, Jakub Kicinski wrote: On Thu, 19 Sep 2024 09:51:47 -0600 Shuah Khan wrote: @@ -261,6 +261,7 @@ ifdef INSTALL_PATH @ret=1; \ for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ + mkdir -p

Re: [PATCH v2 1/4] selftests: add unshare_test and msg_oob to gitignore

2024-09-25 Thread Shuah Khan
On 9/25/24 06:23, Javier Carrasco wrote: These executables are missing from their corresponding gitignore files. Add them to the lists. Signed-off-by: Javier Carrasco --- tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/net/.gitignore | 1 + 2 files changed, 2 inserti

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Shuah Khan
On 9/24/24 06:49, Javier Carrasco wrote: The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore file to account for the new names. Signed-off-by: Javier Carrasco --- tools/tes

Re: [PATCH] memfd: fuse_mnt: remove unused macro

2024-09-25 Thread Shuah Khan
On 9/2/24 22:44, Ba Jing wrote: The macro FUSE_USE_VERSION is never referenced in the code, just remove it. How did you find this problem and how did you test this change? This patch is incorrect - please see below. When you find unused defines, do check first if they are indeed unused checki

Re: [PATCH 2/2] selftests: timers: Remove local NSEC_PER_SEC and USEC_PER_SEC defines

2024-09-25 Thread Shuah Khan
On 9/24/24 17:59, John Stultz wrote: On Tue, Sep 24, 2024 at 8:57 AM Shuah Khan wrote: Remove local NSEC_PER_SEC and USEC_PER_SEC defines. Pick them up from include/vdso/time64.h. This requires -I $(top_srcdir) to the timers Makefile to include the include/vdso/time64.h. posix_timers test

Re: [PATCH 1/2] selftests:timers: posix_timers: Fix warn_unused_result in __fatal_error()

2024-09-25 Thread Shuah Khan
On 9/24/24 09:56, Shuah Khan wrote: __fatal_error routine doesn't check strerror_r() return value, which results in the following compile time warning: posix_timers.c: In function ‘__fatal_error’: posix_timers.c:31:9: warning: ignoring return value of ‘strerror_r’ declared with attr

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-24 Thread Shuah Khan
On 9/24/24 13:31, Alexandre Belloni wrote: Hello, On 24/09/2024 10:05:43-0600, Shuah Khan wrote: On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch

Re: [PATCH 2/2] selftest: rtc: Check if could access /dev/rtc0 before testing

2024-09-24 Thread Shuah Khan
On 9/23/24 23:37, Joseph Jang wrote: Hi Alexandre, Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch ? Thank you, Joseph. Please don't top post. It is hard to follow the thread. On 2024/6/21 3:37 AM

[PATCH 2/2] selftests: timers: Remove local NSEC_PER_SEC and USEC_PER_SEC defines

2024-09-24 Thread Shuah Khan
change NSECS_PER_SEC and USECS_PER_SEC references to NSEC_PER_SEC and USEC_PER_SEC respectively. Signed-off-by: Shuah Khan --- tools/testing/selftests/timers/Makefile | 2 +- tools/testing/selftests/timers/adjtick.c | 4 +--- .../testing/selftests/timers/alarmtimer-suspend.c | 2

[PATCH 1/2] selftests:timers: posix_timers: Fix warn_unused_result in __fatal_error()

2024-09-24 Thread Shuah Khan
es are stored (the string may be truncated if buflen is too small and errnum is unknown). The string always includes a terminating null byte." Signed-off-by: Shuah Khan --- tools/testing/selftests/timers/posix_timers.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[PATCH 0/2] timers test fix and duplicate defines cleanup

2024-09-24 Thread Shuah Khan
, etc. without any explanation why it is necessary. These defines can be picked up from include/vdso/time64.h header file. In the interest of making it easier to maintain, remove the local defines. Include include/vdso/time64.h instead. This change will also make the defines consistent. Shuah Khan

Re: [PATCH] damon: access_memory_even: remove unused variables

2024-09-23 Thread Shuah Khan
/access_memory_even.c @@ -14,10 +14,8 @@ int main(int argc, char *argv[]) { char **regions; - clock_t start_clock; int nr_regions; int sz_region; - int access_time_ms; int i; if (argc != 3) { With these changes: Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 0/2] unicode: kunit: refactor selftest to kunit tests

2024-09-23 Thread Shuah Khan
On 9/23/24 09:42, Pedro Orlando wrote: +CC linux-kselftest --- On 22/09/2024 17:16, Gabriela Bittencourt wrote: Hey all, We are making these changes as part of a KUnit Hackathon at LKCamp [1]. This patch sets out to refactor fs/unicode/utf8-selftest.c to KUnit tests. The first commit is

Re: [PATCH v3 0/3] selftests: livepatch: test livepatching a kprobed function

2024-09-23 Thread Shuah Khan
-kprobe.sh  create mode 100644 tools/testing/selftests/livepatch/test_modules/test_klp_kprobe.c Assuming this is going through livepatch tree: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-23 Thread Shuah Khan
On 9/22/24 23:35, Muhammad Usama Anjum wrote: ... grep -rnIF "#define __NR_userfaultfd" tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define __NR_userfaultfd 374 arch/x86/include/generated/uapi/asm/unistd_64.h:327:#

Re: [PATCH v2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-23 Thread Shuah Khan
+15,7 @@ #include #include #include -#include +#include #include #include #include Thank you. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v3 0/1] Add KUnit tests for llist

2024-09-23 Thread Shuah Khan
On 9/20/24 20:49, Artur Alves Cavalcante de Barros wrote: On 9/20/24 4:10 AM, David Gow wrote: On Fri, 20 Sept 2024 at 00:01, Shuah Khan wrote: On 9/16/24 18:51, Artur Alves wrote: Hi all, This is part of a hackathon organized by LKCAMP[1], focused on writing tests using KUnit. We reached

Re: [PATCH v3 0/1] Add KUnit tests for llist

2024-09-20 Thread Shuah Khan
On 9/20/24 01:10, David Gow wrote: On Fri, 20 Sept 2024 at 00:01, Shuah Khan wrote: On 9/16/24 18:51, Artur Alves wrote: Hi all, This is part of a hackathon organized by LKCAMP[1], focused on writing tests using KUnit. We reached out a while ago asking for advice on what would be a useful

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-20 Thread Shuah Khan
On 9/17/24 23:46, Muhammad Usama Anjum wrote: On 9/17/24 6:56 AM, Shuah Khan wrote: On 9/16/24 00:32, Muhammad Usama Anjum wrote: On 9/12/24 8:44 PM, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was

Re: [PATCH v3 0/1] Add KUnit tests for llist

2024-09-19 Thread Shuah Khan
On 9/16/24 18:51, Artur Alves wrote: Hi all, This is part of a hackathon organized by LKCAMP[1], focused on writing tests using KUnit. We reached out a while ago asking for advice on what would be a useful contribution[2] and ended up choosing data structures that did not yet have tests. This p

Re: [PATCH] selftests: Makefile: create OUTPUT dir

2024-09-19 Thread Shuah Khan
On 9/16/24 01:56, Anders Roxell wrote: When cross building kselftest out-of-tree the following issue can be seen: [...] make[4]: Entering directory '/src/kernel/linux/tools/testing/selftests/net/lib' CC csum /usr/lib/gcc-cross/aarch64-linux-gnu/13/../../../../aarch64-linux-gnu/bin/ld: c

Re: [PATCH v2] selftests/vDSO: support DT_GNU_HASH

2024-09-19 Thread Shuah Khan
On 9/15/24 00:49, Fangrui Song wrote: glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many Linux distributions. Many vDSOs support DT_GNU_HASH. This patch adds selftests support. Signed-off-by: Fangrui Song Tested-by: Xi Ruoyao -- Changes

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-16 Thread Shuah Khan
On 9/16/24 00:32, Muhammad Usama Anjum wrote: On 9/12/24 8:44 PM, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was included. It makes the test to fail every time as the correct number of this syscall

[GIT PULL] KUnit update for Linux 6.12-rc1

2024-09-16 Thread Shuah Khan
Hi Linus, Please pull the following kunit update for Linux 6.12-rc1. This kunit update for Linux 6.12-rc1 consists of: -- a new int_pow test suite -- documentation update to clarify filename best practices -- kernel-doc fix for EXPORT_SYMBOL_IF_KUNIT -- change to build compile_commands.json aut

[GIT PULL] Kselftest update for Linux 6.12-rc1

2024-09-16 Thread Shuah Khan
user suite selftests: lib: remove strscpy test Piotr Zalewski (1): kselftest: timers: Fix const correctness Shreeya Patel (1): kselftest: cpufreq: Add RTC wakeup alarm Shuah Khan (1): selftests:resctrl: Fix build failure on archs without __cpuid_count() Steven Rostedt

[GIT PULL] nolibc for 6.12-rc1

2024-09-16 Thread Shuah Khan
Highlights -- * Clang support (including LTO) Other Changes - * stdbool.h support * argc/argv/envp arguments for constructors * Small #include ordering fix -------- Shuah Khan (1): Merge tag 'nolibc-20240824-for-6.

Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found

2024-09-12 Thread Shuah Khan
On 9/12/24 10:10, Shuah Khan wrote: On 9/12/24 04:31, Muhammad Usama Anjum wrote: The userfaultfd is enabled in the config fragment of mm selftest suite. It must always be present. If it isn't present, we should throw error and not just skip. This would have helped us catch the test bre

Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

2024-09-12 Thread Shuah Khan
On 9/12/24 09:23, Jakub Kicinski wrote: On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote: Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") Signed-off-by: Anders Roxell --- tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/s

Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found

2024-09-12 Thread Shuah Khan
On 9/12/24 04:31, Muhammad Usama Anjum wrote: The userfaultfd is enabled in the config fragment of mm selftest suite. It must always be present. If it isn't present, we should throw error and not just skip. This would have helped us catch the test breakage. Please elaborate on this to help unde

Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value

2024-09-12 Thread Shuah Khan
On 9/12/24 04:31, Muhammad Usama Anjum wrote: The value of __NR_userfaultfd was changed to 282 when asm-generic/unistd.h was included. It makes the test to fail every time as the correct number of this syscall on x86_64 is 323. Fix the header to asm/unistd.h. "please elaborate every time" - I

Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

2024-09-11 Thread Shuah Khan
On 9/11/24 09:44, Thomas Weißschuh wrote: Hi Shuah, On 2024-09-11 09:36:50+, Shuah Khan wrote: On 9/10/24 22:42, zhangjiao2 wrote: From: zhang jiao Nolibc gained an implementation of strerror() recently. Use it and drop the ifndef. Signed-off-by: zhang jiao --- tools/testing

Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

2024-09-11 Thread Shuah Khan
On 9/10/24 22:42, zhangjiao2 wrote: From: zhang jiao Nolibc gained an implementation of strerror() recently. Use it and drop the ifndef. Signed-off-by: zhang jiao --- tools/testing/selftests/kselftest.h | 8 1 file changed, 8 deletions(-) diff --git a/tools/testing/selftests/ksel

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-09 Thread Shuah Khan
On 9/8/24 23:16, Dev Jain wrote: On 9/7/24 01:29, Shuah Khan wrote: On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24

[GIT PULL] KUnit fixes second update for Linux 6.11-rc7

2024-09-06 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes second update for Linux 6.11-rc7. This KUnit fixes update for Linux 6.11-rc7 consists of a fix to missing function parameter warning found during documentation build in linux-next. diff is attached. thanks, -- Shuah -

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-06 Thread Shuah Khan
On 9/4/24 23:56, Dev Jain wrote: On 9/4/24 22:35, Shuah Khan wrote: On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename

Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

2024-09-06 Thread Shuah Khan
On 9/6/24 11:02, John Stultz wrote: On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan wrote: On 9/5/24 20:52, zhangjiao2 wrote: diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c index c8e6bffe4e0a..83450145fe65 100644 --- a/tools

Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

2024-09-06 Thread Shuah Khan
uot;../kselftest.h" -#define NSEC_PER_SEC 10LL - int main(int argc, char **argv) { struct timex tx; This looks good to me. Reviewed-by: Shuah Khan John, I can pick this up with if you are okay with this change. thanks, -- Shuah

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-06 Thread Shuah Khan
On 9/6/24 01:35, Muhammad Usama Anjum wrote: Hi Shuah, Thank you for fixing it. On 9/5/24 11:02 PM, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem is seen

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-06 Thread Shuah Khan
On 9/6/24 04:12, Ilpo Järvinen wrote: On Thu, 5 Sep 2024, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem is seen while building resctrl on aarch64, this error

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-05 Thread Shuah Khan
On 9/5/24 14:43, Reinette Chatre wrote: Hi Shuah, On 9/5/24 11:06 AM, Shuah Khan wrote: On 9/4/24 06:54, Ilpo Järvinen wrote: On Wed, 4 Sep 2024, Shuah Khan wrote: On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-05 Thread Shuah Khan
On 9/5/24 14:45, Reinette Chatre wrote: Hi Shuah, Thank you very much for looking into this. On 9/5/24 11:02 AM, Shuah Khan wrote: When resctrl is built on architectures without __cpuid_count() support, build fails. resctrl uses __cpuid_count() defined in kselftest.h. Even though the problem

Re: [PATCH v2] selftests: futex: Fix missing free in main

2024-09-05 Thread Shuah Khan
On 9/4/24 20:01, zhangjiao2 wrote: From: zhang jiao By readind the code, I found there is no free() after asprintf(). Just free it. Signed-off-by: zhang jiao --- v1->v2: Set a flag to determine if test_name needs free. tools/testing/selftests/futex/functional/futex_requeue_

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-05 Thread Shuah Khan
On 9/4/24 06:54, Ilpo Järvinen wrote: On Wed, 4 Sep 2024, Shuah Khan wrote: On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor

[PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-05 Thread Shuah Khan
cro ‘__cpuid_count’ 306 | __cpuid_count(0x10, 2, eax, ebx, ecx, edx); Reported-by: Muhammad Usama Anjum Reported-by: Ilpo Järvinen Signed-off-by: Shuah Khan --- tools/testing/selftests/kselftest.h| 2 ++ tools/testing/selftests/resctrl/cat_test.c | 6 -- 2 files changed, 6 insertions(+), 2 d

Re: [PATCH] Date: Remove unused macro

2024-09-05 Thread Shuah Khan
On 9/5/24 02:52, zhangjiao2 wrote: From: zhang jiao This macro NSEC_PER_SEC is never referenced in the code. Just remove it. Is this duplicate patch? I think I commented on your patch on futex - include how you found the problem in change logs. Also you have to include subsystem prefix in th

Re: [PATCH] Date: Remove unused macro

2024-09-05 Thread Shuah Khan
On 9/5/24 02:13, zhangjiao2 wrote: From: zhang jiao This macro NSEC_PER_SEC is never referenced in the code. Just remove it. I think I commented on your patch on futex - include how you found the problem in change logs. Also you have to include subsystem prefix in the subject line: selftests

Re: [PATCH] kunit: Fix missing kerneldoc comment

2024-09-05 Thread Shuah Khan
On 9/4/24 20:47, David Gow wrote: Add a missing kerneldoc comment for the 'test' test context parameter, fixing the following warning: include/kunit/test.h:492: warning: Function parameter or struct member 'test' not described in 'kunit_kfree_const' Reported-by: Stephen Rothwell Closes: https

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-04 Thread Shuah Khan
On 9/3/24 22:52, Dev Jain wrote: On 9/4/24 03:14, Shuah Khan wrote: On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests

Re: [PATCH] selftests: futex: Fix missing free in main

2024-09-04 Thread Shuah Khan
On 9/3/24 20:55, zhangjiao2 wrote: From: zhang jiao Free string allocated by asprintf(). How did you find this problem? Include the details in the change log - The tool and output from the tool. Signed-off-by: zhang jiao --- tools/testing/selftests/futex/functional/futex_requeue_pi.c |

Re: [PATCH v2] selftests/futex: Create test for robust list

2024-09-04 Thread Shuah Khan
On 9/3/24 07:40, André Almeida wrote: Create a test for the robust list mechanism. What does this test - can you elaborate on the testing details? It will help reviewers catch if any tests are missed or not - be able to review the patch. Include output from the test in the chane log. Signed

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-04 Thread Shuah Khan
On 9/4/24 06:18, Ilpo Järvinen wrote: On Tue, 3 Sep 2024, Shuah Khan wrote: On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor implies Intel. Second, it improves selftests such that the use of

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-03 Thread Shuah Khan
On 9/3/24 08:45, Ilpo Järvinen wrote: This series first generalizes resctrl selftest non-contiguous CAT check to not assume non-AMD vendor implies Intel. Second, it improves selftests such that the use of __cpuid_count() does not lead into a build failure (happens at least on ARM). While ARM doe

Re: [PATCH v2] selftests: splice: Add usage() to splice_read.c

2024-09-03 Thread Shuah Khan
On 8/30/24 23:14, Rong Tao wrote: From: Rong Tao Give the programmer more help information to inform the program on how to use it. Signed-off-by: Rong Tao --- tools/testing/selftests/splice/splice_read.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/test

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-03 Thread Shuah Khan
On 8/30/24 10:29, Dev Jain wrote: On 8/27/24 17:16, Dev Jain wrote: On 8/27/24 17:14, Shuah Khan wrote: On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests in the future. Sorry - I think I mentioned I don't like this

Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

2024-09-03 Thread Shuah Khan
On 8/27/24 07:37, Fangrui Song wrote: On Tue, Aug 27, 2024 at 10:12 PM Shuah Khan wrote: On 8/26/24 00:07, Xi Ruoyao wrote: On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote: glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many

Re: [PATCH] selftests: filesystems: fix warn_unused_result build warnings

2024-09-03 Thread Shuah Khan
On 8/16/24 07:11, Shuah Khan wrote: On 8/10/24 07:53, Abhinav Jain wrote: Add return value checks for read & write calls in test_listmount_ns function. This patch resolves below compilation warnings: ``` statmount_test_ns.c: In function ‘test_listmount_ns’: statmount_test_ns.c:322:17: war

Re: [PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-05-21 Thread Shuah Khan
On 4/3/24 19:10, Shuah Khan wrote: Fix the following -Wformat-security compile warnings adding missing format arguments: latency-collector.c: In function ‘show_available’: latency-collector.c:938:17: warning: format not a string literal and no format arguments [-Wformat-security] 938

[PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-04-03 Thread Shuah Khan
literal and no format arguments [-Wformat-security] 1881 | errx(EXIT_FAILURE, no_tracer_msg); | ^~~~ Signed-off-by: Shuah Khan --- tools/tracing/latency/latency-collector.c | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [PATCH v3] Documentation: dev-tools: Add Testing Overview

2021-04-20 Thread Shuah Khan
On 4/14/21 11:40 PM, David Gow wrote: The kernel now has a number of testing and debugging tools, and we've seen a bit of confusion about what the differences between them are. Add a basic documentation outlining the testing tools, when to use each, and how they interact. This is a pretty quick

Re: [PATCH 5.4 00/73] 5.4.114-rc1 review

2021-04-19 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/103] 5.10.32-rc1 review

2021-04-19 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/122] 5.11.16-rc1 review

2021-04-19 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH RFC v3] media: em28xx: Fix race condition between open and init function

2021-04-16 Thread Shuah Khan
On 4/16/21 1:33 PM, Igor Torrente wrote: On 4/15/21 2:25 PM, Shuah Khan wrote: On 4/15/21 8:07 AM, Igor Matheus Andrade Torrente wrote: Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev

Re: [PATCH 4.4 00/38] 4.4.267-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.14 00/68] 4.14.231-rc1 review

2021-04-15 Thread Shuah Khan
rivers: net: fix memory leak in atusb_probe Phillip Potter net: tun: set tun->dev->addr_len during TUNSETLINK processing Du Cheng cfg80211: remove WARN_ON() in cfg80211_sme_connect Shuah Khan usbip: fix vudc usbip_sockfd_store races leading to gpf Samuel Mendoza-Jonas

Re: [PATCH 4.9 00/47] 4.9.267-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.14 00/68] 4.14.231-rc1 review

2021-04-15 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.4 00/18] 5.4.113-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 4.19 00/13] 4.19.188-rc1 review

2021-04-15 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 00/25] 5.10.31-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 00/23] 5.11.15-rc1 review

2021-04-15 Thread Shuah Khan
/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH RFC v3] media: em28xx: Fix race condition between open and init function

2021-04-15 Thread Shuah Khan
On 4/15/21 8:07 AM, Igor Matheus Andrade Torrente wrote: Fixes a race condition - for lack of a more precise term - between em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev, media_pad and vdev structs from the em28xx_v4l2, and managing the lifetime of those objects more dynamicaly

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-15 Thread Shuah Khan
On 4/14/21 9:26 AM, Shuah Khan wrote: On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed

Re: [PATCH v3] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-14 Thread Shuah Khan
On 4/14/21 6:55 AM, Luis Chamberlain wrote: Shuah, a question for you toward the end here. On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote: This use-after-free happens when a fw_priv object has been freed but hasn't been removed from the pending list (pending_fw_head). The ne

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. No problems with wifi this time. I will be on the lookout for this in the future. Tested-by: Shuah Khan thanks

Re: [PATCH 5.4 000/111] 5.4.112-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 5.11 000/210] 5.11.14-rc1 review

2021-04-12 Thread Shuah Khan
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.11.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan thanks, -- Shuah

  1   2   3   4   5   6   7   8   9   10   >