Re: [PATCHv2] i2c: cadence: Enable power management

On Wed, Oct 28, 2015 at 11:34 AM, Shubhrajyoti Datta wrote: > Currently the clocks are enabled at probe and disabled at remove. > This patch enables the clocks at the start of transfer and disables > after it. > > Also adapts to runtime pm. > Remove xi2c->suspended and

[PATCH v2] i2c: cadence: Move to sensible power management

ead. converts dev pm to const to silence a checkpatch warning. Signed-off-by: Shubhrajyoti Datta --- changes since v2 update the cc list drivers/i2c/busses/i2c-cadence.c | 73 -- 1 files changed, 46 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/bus

[PATCH v2] i2c: cadence: Move to sensible power management

ead. converts dev pm to const to silence a checkpatch warning. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- changes since v2 update the cc list drivers/i2c/busses/i2c-cadence.c | 73 -- 1 files changed, 46 insertions(+), 27 deletions(-) d

Re: [PATCHv2] i2c: cadence: Enable power management

On Wed, Oct 28, 2015 at 11:34 AM, Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> wrote: > Currently the clocks are enabled at probe and disabled at remove. > This patch enables the clocks at the start of transfer and disables > after it. > > Also adapts to runtime pm. >

[PATCHv2] i2c: cadence: Enable power management

ned-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- changes since v1: update the cc list. drivers/i2c/busses/i2c-cadence.c | 74 -- 1 files changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/b

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

On Thu, Oct 8, 2015 at 8:40 PM, Jean-Francois Dagenais wrote: > >> On Jun 4, 2013, at 1:32 PM, Mark Brown wrote: >> >> Applied but this is a bit sad, having to defer the refill to process >> context means that we're adding extra latency which takes us further >> away from being able to saturate

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

On Thu, Oct 8, 2015 at 8:40 PM, Jean-Francois Dagenais wrote: > >> On Jun 4, 2013, at 1:32 PM, Mark Brown wrote: >> >> Applied but this is a bit sad, having to defer the refill to process >> context means that we're adding extra latency which takes us

Re: [[PATCH v2] 2/2] Altera Modular ADC driver support

> +static int alt_modular_adc_probe(struct platform_device *pdev) > +{ > + struct altera_adc *adc; > + struct device_node *np = pdev->dev.of_node; > + struct iio_dev *indio_dev; > + struct resource *mem; > + int ret; > + > + if (!np) > + return

Re: [[PATCH v2] 2/2] Altera Modular ADC driver support

> +static int alt_modular_adc_probe(struct platform_device *pdev) > +{ > + struct altera_adc *adc; > + struct device_node *np = pdev->dev.of_node; > + struct iio_dev *indio_dev; > + struct resource *mem; > + int ret; > + > + if (!np) > + return

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

On Tue, Aug 4, 2015 at 1:35 PM, Lars-Peter Clausen wrote: > > Well there is no need to use a threaded IRQ. The interrupt handler is quite > small and doesn't take too much time and doesn't have any delays or sleeps > in it either. > > Ok thanks for the explanation. -- To unsubscribe from this

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

On Tue, Aug 4, 2015 at 1:35 PM, Lars-Peter Clausen l...@metafoo.de wrote: Well there is no need to use a threaded IRQ. The interrupt handler is quite small and doesn't take too much time and doesn't have any delays or sleeps in it either. Ok thanks for the explanation. -- To unsubscribe from

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath wrote: > From: Yi Zhang > > Enable i2c module/unit before transmission and disable when it > finishes. > > why? > It's because the i2c bus may be disturbed if the slave device, > typically a touch, powers on. Why should that be an issue? Is

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: From: Yi Zhang yizh...@marvell.com Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device, typically a touch,

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

On Fri, Jul 24, 2015 at 6:08 PM, Lars-Peter Clausen wrote: > Hi, > > Sorry, but I don't think this patch has been sufficiently tested against a > mainline kernel. The driver wont even probe the way it is right now. > > On 07/21/2015 01:14 AM, Xander Huff wrote: >> >> The driver currently

Re: [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context

On Fri, Jul 24, 2015 at 6:08 PM, Lars-Peter Clausen l...@metafoo.de wrote: Hi, Sorry, but I don't think this patch has been sufficiently tested against a mainline kernel. The driver wont even probe the way it is right now. On 07/21/2015 01:14 AM, Xander Huff wrote: The driver currently

Re: [PATCH v2] ARM64: zynqmp: Add eeprom memories on i2c bus

On Wed, Jul 29, 2015 at 7:49 PM, Michal Simek wrote: > Add i2c eeprom memories on i2c bus. > Thanks for the patch. Feel free to add Reviewed-by: Shubhrajyoti Datta > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Change eeprom max freq from 100k to 400k > >

Re: [PATCH v2] ARM64: zynqmp: Add eeprom memories on i2c bus

On Wed, Jul 29, 2015 at 7:49 PM, Michal Simek michal.si...@xilinx.com wrote: Add i2c eeprom memories on i2c bus. Thanks for the patch. Feel free to add Reviewed-by: Shubhrajyoti Datta shubh...@xilinx.com Signed-off-by: Michal Simek michal.si...@xilinx.com --- Changes in v2: - Change eeprom

Re: [PATCH 7/7] ARM64: zynqmp: Add eeprom memories on i2c bus

Hi, On Mon, Jul 27, 2015 at 3:18 PM, Michal Simek wrote: > Add i2c eeprom memories on i2c bus. > > Signed-off-by: Michal Simek > --- > > arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git

Re: [PATCH 7/7] ARM64: zynqmp: Add eeprom memories on i2c bus

Hi, On Mon, Jul 27, 2015 at 3:18 PM, Michal Simek michal.si...@xilinx.com wrote: Add i2c eeprom memories on i2c bus. Signed-off-by: Michal Simek michal.si...@xilinx.com --- arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH] mtd: spi-nor: Only set Micron quad-read mode when controller in 4-lane TX mode

On Tue, Jun 30, 2015 at 4:47 PM, Mike Looijmans wrote: > Micron QUAD mode expects command, address and data on 4 lanes instead of just > one for command (extended SPI mode). This requires the controller to be in a > special mode, so check first if the controller could be in that mode. If a >

Re: [PATCH] mtd: spi-nor: Only set Micron quad-read mode when controller in 4-lane TX mode

On Tue, Jun 30, 2015 at 4:47 PM, Mike Looijmans mike.looijm...@topic.nl wrote: Micron QUAD mode expects command, address and data on 4 lanes instead of just one for command (extended SPI mode). This requires the controller to be in a special mode, so check first if the controller could be in

Re: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support

On Mon, Jun 15, 2015 at 8:06 PM, Punnaiah Choudary Kalluri wrote: > Added the basic driver for zynqmp dma engine used in Zynq > UltraScale+ MPSoC. The initial release of this driver supports > only memory to memory transfers. > > Signed-off-by: Punnaiah Choudary Kalluri > --- > +/** > + *

Re: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support

On Mon, Jun 15, 2015 at 8:06 PM, Punnaiah Choudary Kalluri punnaiah.choudary.kall...@xilinx.com wrote: Added the basic driver for zynqmp dma engine used in Zynq UltraScale+ MPSoC. The initial release of this driver supports only memory to memory transfers. Signed-off-by: Punnaiah Choudary

Re: [LINUX RFC V2 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller

hi, Some minor comments. On Fri, Jun 5, 2015 at 6:37 PM, Ranjit Waghmode wrote: > This patch adds support for GQSPI controller driver used by > Zynq Ultrascale+ MPSoC > > Signed-off-by: Ranjit Waghmode > --- > Here is the v2 series. > + */ > +static void zynqmp_qspi_chipselect(struct

Re: [LINUX RFC V2 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller

hi, Some minor comments. On Fri, Jun 5, 2015 at 6:37 PM, Ranjit Waghmode ranjit.waghm...@xilinx.com wrote: This patch adds support for GQSPI controller driver used by Zynq Ultrascale+ MPSoC Signed-off-by: Ranjit Waghmode ranjit.waghm...@xilinx.com --- Here is the v2 series. snip + */

Re: [PATCH 1/3] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

Hi Moritz, Overall looks good some nitpicks below. On Fri, May 22, 2015 at 5:07 AM, Moritz Fischer wrote: > The Xilinx LogiCORE IP mailbox is a FPGA core that allows for > interprocessor communication via AXI4 memory mapped / AXI4 stream > interfaces. > > It is single channel per core and

Re: [PATCH 1/3] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

Hi Moritz, Overall looks good some nitpicks below. On Fri, May 22, 2015 at 5:07 AM, Moritz Fischer moritz.fisc...@ettus.com wrote: The Xilinx LogiCORE IP mailbox is a FPGA core that allows for interprocessor communication via AXI4 memory mapped / AXI4 stream interfaces. It is single

Re: [PATCH 02/12] net: axienet: Handle 0 packet receive gracefully

On Tue, May 5, 2015 at 2:55 PM, Michal Simek wrote: > From: Peter Crosthwaite > > The AXI-DMA rx-delay interrupt can sometimes be triggered > when there are 0 outstanding packets received. This is due > to the fact that the receive function will greedily consume > as many packets as possible on

Re: [PATCH 02/12] net: axienet: Handle 0 packet receive gracefully

On Tue, May 5, 2015 at 2:55 PM, Michal Simek michal.si...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com The AXI-DMA rx-delay interrupt can sometimes be triggered when there are 0 outstanding packets received. This is due to the fact that the receive function will

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan wrote: > If timeout error occurs in the i2c transfer then it was dumping warning > of call stack. > > Remove the warning dump as there is may be possibility that some slave > devices are busy and not responding the i2c communication. > >

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan ldewan...@nvidia.com wrote: If timeout error occurs in the i2c transfer then it was dumping warning of call stack. Remove the warning dump as there is may be possibility that some slave devices are busy and not responding the i2c communication.

Re: [PATCH V3 2/3] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

On 1/17/13, Amit Daniel Kachhap wrote: > Below fixes are done to support falling threshold interrupt, > * Falling interrupt status macro corrected according to exynos5 data sheet. > * The get trend function modified to calculate trip temperature correctly. > * The clearing of interrupt status in

Re: [PATCH V3 2/3] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

On 1/17/13, Amit Daniel Kachhap amit.dan...@samsung.com wrote: Below fixes are done to support falling threshold interrupt, * Falling interrupt status macro corrected according to exynos5 data sheet. * The get trend function modified to calculate trip temperature correctly. * The clearing of

Re: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

On Thu, Nov 22, 2012 at 10:13 AM, Tushar Behera wrote: > It is not required to free devm_ allocated data. Since kref_put > needs a valid release function, da9052_wdt_release_resources() > is not deleted. > > Fixes following warning. > drivers/watchdog/da9052_wdt.c:59:1-6: WARNING: invalid free of

Re: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

On Thu, Nov 22, 2012 at 10:13 AM, Tushar Behera tushar.beh...@linaro.org wrote: It is not required to free devm_ allocated data. Since kref_put needs a valid release function, da9052_wdt_release_resources() is not deleted. Fixes following warning. drivers/watchdog/da9052_wdt.c:59:1-6:

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera wrote: > This patchset cleans up the probe function of i2c-s3c2410 driver. > These have been tested on Exynos4210 based Origen board. > > Tushar Behera (7): > i2c: s3c2410: Remove unnecessary label err_noclk > i2c: s3c2410: Convert to use

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410:

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait for the tx to complete. > >

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait for the tx to complete. > >

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait

Re: [PATCH] i2c: omap: adopt pinctrl support

On Tue, Oct 16, 2012 at 8:53 PM, Sebastien Guiriec wrote: > Some GPIO expanders need some early pin control muxing. Due to > legacy boards sometimes the driver uses subsys_initcall instead of > module_init. This patch takes advantage of defer probe feature > and pin control in order to wait until

Re: [PATCH] i2c: omap: adopt pinctrl support

On Tue, Oct 16, 2012 at 8:53 PM, Sebastien Guiriec s-guir...@ti.com wrote: Some GPIO expanders need some early pin control muxing. Due to legacy boards sometimes the driver uses subsys_initcall instead of module_init. This patch takes advantage of defer probe feature and pin control in order

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones wrote: > From: Jonas Aaberg Some change logs would have helped. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Acked-by: Lee Jones > Signed-off-by: Jonas Aaberg > Signed-off-by: Philippe Langlais > Reviewed-by: Bengt Jonsson > --- >

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones lee.jo...@linaro.org wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Some change logs would have helped. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-in...@vger.kernel.org Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by:

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires wrote: > Hi, > > thanks also for the review. Two in the same day! I was about to send a > ping on that patch ;-) > > On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta > wrote: >> On Fri, Sep 14, 2012 at 7:11 PM, b

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires wrote: > From: Benjamin Tissoires > > Microsoft published the protocol specification of HID over i2c: > http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx > > This patch introduces an implementation of this protocol. > >

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires benjamin.tissoi...@gmail.com wrote: From: Benjamin Tissoires benjamin.tissoi...@enac.fr Microsoft published the protocol specification of HID over i2c: http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx This patch

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi, thanks also for the review. Two in the same day! I was about to send a ping on that patch ;-) On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta omaplinuxker...@gmail.com wrote: On Fri, Sep 14

Re: [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c

On Thu, Sep 20, 2012 at 12:04 PM, Pantelis Antoniou wrote: > Add support for pinctrl mux settings in the OMAP I2C driver. > If no such pinctl bindings are found a warning message is printed. > > Signed-off-by: Pantelis Antoniou > --- looks good Acked-by: Shubhrajyoti D -- To unsubscribe from

Re: [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c

On Thu, Sep 20, 2012 at 12:04 PM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Add support for pinctrl mux settings in the OMAP I2C driver. If no such pinctl bindings are found a warning message is printed. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- looks

Re: [PATCHv2 6/6] media: Convert struct i2c_msg initialization to C99 format

On Tue, Sep 18, 2012 at 3:26 PM, Venu Byravarasu wrote: >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Shubhrajyoti D >> Sent: Tuesday, September 18, 2012 3:21 PM >> To: linux-me...@vger.kernel.org >> Cc:

Re: [PATCHv2 6/6] media: Convert struct i2c_msg initialization to C99 format

On Tue, Sep 18, 2012 at 3:26 PM, Venu Byravarasu vbyravar...@nvidia.com wrote: -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Shubhrajyoti D Sent: Tuesday, September 18, 2012 3:21 PM To: linux-me...@vger.kernel.org

Re: [PATCHv2 0/3] spi: omap2-mcspi: spi cleanups

On Wed, Aug 22, 2012 at 10:29 PM, Mark Brown wrote: > On Wed, Aug 22, 2012 at 11:35:11AM +0530, Shubhrajyoti D wrote: >> This patch does the following >> >> Calls the pm_runtime_* functions directly. >> Remove the MOD_REG_BIT macro usage thereby removiing un-needed branch. >> At remove dont use

Re: [PATCHv2 0/3] spi: omap2-mcspi: spi cleanups

On Wed, Aug 22, 2012 at 10:29 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Aug 22, 2012 at 11:35:11AM +0530, Shubhrajyoti D wrote: This patch does the following Calls the pm_runtime_* functions directly. Remove the MOD_REG_BIT macro usage thereby removiing un-needed

Re: [PATCH] spi: omap2-mcspi: Fix the below warning

On Fri, Jul 20, 2012 at 3:40 PM, Mark Brown wrote: > On Thu, Jul 19, 2012 at 11:16:52PM +0530, Shubhrajyoti D wrote: >> The dma_map and dma_unmap should have same parameter >> passed otherwise we get the below warn. > > Applied, thanks. thanks, -- To unsubscribe from this list: send the line

Re: [PATCH] spi: omap2-mcspi: Fix the below warning

On Fri, Jul 20, 2012 at 3:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Jul 19, 2012 at 11:16:52PM +0530, Shubhrajyoti D wrote: The dma_map and dma_unmap should have same parameter passed otherwise we get the below warn. Applied, thanks. thanks, -- To unsubscribe from

Re: [PATCH 1/5] i2c: tegra: remove unused member variable

Hi Laxman, On Tue, Jul 10, 2012 at 4:50 PM, Laxman Dewangan wrote: > Remove unused member variable "iomem" of the > i2c device structure. You might want to mention the commit which removed the last usage etc. > > Signed-off-by: Laxman Dewangan > --- > This patch is resend of earlier patch >

Re: [PATCH 1/5] i2c: tegra: remove unused member variable

Hi Laxman, On Tue, Jul 10, 2012 at 4:50 PM, Laxman Dewangan ldewan...@nvidia.com wrote: Remove unused member variable iomem of the i2c device structure. You might want to mention the commit which removed the last usage etc. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com --- This

<    1   2