[PATCH] remoteproc: qcom_q6v5_mss: Re-order writes to the IMEM region

2024-08-19 Thread Sibi Sankar
A log extraction support") Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_mss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index 2a42215ce8e0..32c3531b20c7 100644 --- a/drivers/

Re: [PATCH 3/3] remoteproc: qcom_q6v5_pas: Unload lite firmware on ADSP

2024-02-08 Thread Sibi Sankar
On 1/31/24 15:00, Abel Vesa wrote: On 24-01-29 17:17:28, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 15:35, Abel Vesa wrote: From: Sibi Sankar The UEFI loads a lite variant of the ADSP firmware to support charging use cases. The kernel needs to unload and reload it with the firmware

Re: [PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings

2021-04-19 Thread Sibi Sankar
On 2021-03-14 03:07, Stephen Boyd wrote: Quoting Sibi Sankar (2021-03-08 21:51:49) Add PDC Global reset controller bindings for SC7280 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 include/dt-bindings/reset/qcom,sdm845-pdc.h

Re: [PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS

2021-04-19 Thread Sibi Sankar
On 2021-03-24 12:19, Sibi Sankar wrote: On 2021-03-24 03:36, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-03-13 20:16:39) On Sat 13 Mar 15:46 CST 2021, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-03-08 21:51:51) > > Add miscellaneous nodes to boot the Wireless Processor Sub

[PATCH 10/12] arm64: dts: qcom: sm8250: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SM8250 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH 11/12] arm64: dts: qcom: sm8350: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SM8350 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 30 -- 1 file changed, 16 insertions

[PATCH 08/12] arm64: dts: qcom: sdm845: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SDM845 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 12/12] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions

2021-04-16 Thread Sibi Sankar
Delete unused power-domain definitions exposed by AOSS QMP. Signed-off-by: Sibi Sankar --- include/dt-bindings/power/qcom-aoss-qmp.h | 14 -- 1 file changed, 14 deletions(-) delete mode 100644 include/dt-bindings/power/qcom-aoss-qmp.h diff --git a/include/dt-bindings/power/qcom

[PATCH 09/12] arm64: dts: qcom: sm8150: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SM8150 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 ++-- 1 file changed, 14 insertions

[PATCH 07/12] arm64: dts: qcom: sc7280: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SC7280 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot

[PATCH 04/12] dt-bindings: remoteproc: qcom: Add QMP bindings

2021-04-16 Thread Sibi Sankar
Add Qualcomm Mailbox Protocol (QMP) binding to replace the power domains exposed by the AOSS QMP node. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH 06/12] arm64: dts: qcom: sc7180: Use QMP binding to control load state

2021-04-16 Thread Sibi Sankar
Use the Qualcomm Mailbox Protocol (QMP) binding to control the load state resources on SC7180 SoCs and drop deprecated power-domains exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 05/12] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state

2021-04-16 Thread Sibi Sankar
by the AOSS QMP node and replace them with generic qmp_send interface instead. Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5.c | 57 +- drivers/remoteproc/qcom_q6v5.h | 7 +++- drivers/remoteproc/qcom_q6v5_adsp.c | 7 +++- drivers/remoteproc

[PATCH 02/12] soc: qcom: aoss: Drop power domain support

2021-04-16 Thread Sibi Sankar
by replacing load state resource control through the generic qmp message send interface instead. Signed-off-by: Sibi Sankar --- drivers/soc/qcom/qcom_aoss.c | 109 ++- 1 file changed, 3 insertions(+), 106 deletions(-) diff --git a/drivers/soc/qcom

[PATCH 03/12] dt-bindings: remoteproc: qcom: pas: Add QMP bindings

2021-04-16 Thread Sibi Sankar
Add Qualcomm Mailbox Protocol (QMP) binding to replace the power domains exposed by the AOSS QMP node. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings

2021-04-16 Thread Sibi Sankar
Drop power-domain bindings exposed by AOSS QMP node. Signed-off-by: Sibi Sankar --- .../devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b

[PATCH 00/12] Use qmp_send to update co-processor load state

2021-04-16 Thread Sibi Sankar
and replace them with generic qmp_send interface instead. https://lore.kernel.org/lkml/20200913034603.GV3715@yoga/ Previous dicussion on dropping power-domain support from AOSS QMP driver https://lore.kernel.org/lkml/1617943188-23278-2-git-send-email-dee...@qti.qualcomm.com/ Depends on ^^ Sibi

Re: [PATCH] soc: qcom: mdt_loader: Validate that p_filesz < p_memsz

2021-04-08 Thread Sibi Sankar
filesz > phdr->p_memsz) { + dev_err(dev, + "refusing to load segment %d with p_filesz > p_memsz\n", + i); + ret = -EINVAL; + break; +

Re: [PATCH] soc: qcom: mdt_loader: Detect truncated read of segments

2021-04-08 Thread Sibi Sankar
i, fw_name); + ret = -EINVAL; + break; seg_fw has to be released on error condition as well. With ^^ fixed you can have my R-b. Reviewed-by: Sibi Sankar + } + release_firmware(seg_fw);

Re: [PATCH] arm64: dts: qcom: Move rmtfs memory region

2021-04-07 Thread Sibi Sankar
gt;; Sorry for the late comments. Can you please do the same for sc7180-idp as well? Reviewed-by: Sibi Sankar }; / { diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 1ea3344ab62c..ac956488908f 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi

Re: [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node

2021-03-24 Thread Sibi Sankar
On 2021-03-23 09:08, Stephen Boyd wrote: Quoting Sibi Sankar (2021-03-08 21:58:21) On 2021-02-27 19:26, Sai Prakash Ranjan wrote: > On 2021-02-27 00:16, Stephen Boyd wrote: >> Quoting Sai Prakash Ranjan (2021-02-25 23:51:00) >>> On 2021-02-26 01:11, Stephen Boyd wrote: >>

Re: [PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS

2021-03-23 Thread Sibi Sankar
On 2021-03-24 03:36, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-03-13 20:16:39) On Sat 13 Mar 15:46 CST 2021, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-03-08 21:51:51) > > Add miscellaneous nodes to boot the Wireless Processor Subsystem on > > Maybe add (WPSS) after

Re: [PATCH] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

2021-03-15 Thread Sibi Sankar
On 2021-03-10 13:07, Rakesh Pillai wrote: Add the WPSS remoteproc node in dts for PIL loading. Signed-off-by: Rakesh Pillai --- - This change is dependent on the below patch series 1) https://lore.kernel.org/patchwork/project/lkml/list/?series=487403 2) https://lore.kernel.org/patchwork/project

Re: [PATCH 2/2] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS

2021-03-15 Thread Sibi Sankar
On 2021-03-10 12:58, Rakesh Pillai wrote: Add support for PIL loading of WPSS processor for SC7280 WPSS boot will be requested by the wifi driver and hence disable auto-boot for WPSS. Also add a separate shutdown sequence handler for WPSS. Signed-off-by: Rakesh Pillai --- drivers/remoteproc/qc

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support

2021-03-15 Thread Sibi Sankar
On 2021-03-10 12:58, Rakesh Pillai wrote: Add WPSS PIL loading support for SC7280 SoCs. Signed-off-by: Rakesh Pillai --- .../bindings/remoteproc/qcom,hexagon-v56.txt | 35 -- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bi

Re: [PATCH 8/9] arm64: dts: qcom: sc7280: Add AOSS QMP node

2021-03-08 Thread Sibi Sankar
On 2021-02-27 19:26, Sai Prakash Ranjan wrote: On 2021-02-27 00:16, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2021-02-25 23:51:00) On 2021-02-26 01:11, Stephen Boyd wrote: > Quoting Sai Prakash Ranjan (2021-02-25 01:30:24) >> Add a DT node for the AOSS QMP on SC7280 SoC. >> >> Signed-off-

[PATCH 5/6] reset: qcom: Add PDC Global reset signals for WPSS

2021-03-08 Thread Sibi Sankar
Add PDC Global reset signals for Wireless Processor Subsystem (WPSS) on SC7280 SoCs. Signed-off-by: Sibi Sankar --- drivers/reset/reset-qcom-pdc.c | 62 ++ 1 file changed, 51 insertions(+), 11 deletions(-) diff --git a/drivers/reset/reset-qcom-pdc.c b

[PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings

2021-03-08 Thread Sibi Sankar
Add PDC Global reset controller bindings for SC7280 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 include/dt-bindings/reset/qcom,sdm845-pdc.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/Documentation

[PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS

2021-03-08 Thread Sibi Sankar
Add miscellaneous nodes to boot the Wireless Processor Subsystem on SC7280 SoCs. Signed-off-by: Sibi Sankar --- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=438217 Depends on ipcc dt node enablement from ^^ arch/arm64/boot/dts/qcom/sc7280.dtsi | 143

[PATCH 2/6] dt-bindings: mailbox: Add WPSS client index to IPCC

2021-03-08 Thread Sibi Sankar
Add WPSS remote processor client index to Inter-Processor Communication Controller (IPCC) block. Signed-off-by: Sibi Sankar --- include/dt-bindings/mailbox/qcom-ipcc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/mailbox/qcom-ipcc.h b/include/dt-bindings/mailbox/qcom

[PATCH 1/6] soc: qcom: smem: Update max processor count

2021-03-08 Thread Sibi Sankar
Update max processor count to reflect the number of co-processors on SC7280 SoCs. Signed-off-by: Sibi Sankar --- drivers/soc/qcom/smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index cc4e0655a47b..4fb5aeeb0843 100644

[PATCH 3/6] dt-bindings: reset: aoss: Add AOSS reset controller binding

2021-03-08 Thread Sibi Sankar
Add AOSS reset controller bindings for SC7280 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/reset/qcom,aoss-reset.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.yaml b/Documentation/devicetree

[PATCH 0/6] Enable miscellaneous hardware blocks to boot WPSS

2021-03-08 Thread Sibi Sankar
This series enables miscellaneous hardware blocks to boot Wireless Processor Subsystem (WPSS) on SC7280 SoC. [1] https://lore.kernel.org/patchwork/cover/1389010/ The series depends on ^^ Sibi Sankar (6): soc: qcom: smem: Update max processor count dt-bindings: mailbox: Add WPSS client index

Re: [PATCH] arm64: dts: qcom: sm8250: Fix epss_l3 unit address

2021-02-16 Thread Sibi Sankar
On 2021-02-12 01:06, Georgi Djakov wrote: The unit address of the epss_l3 node is incorrect and does not match the address of its "reg" property. Let's fix it. Signed-off-by: Georgi Djakov Thanks for catching it :) Reviewed-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/

[PATCH v2 2/2] arm64: dts: qcom: sc7180: Add DDR/L3 votes for the pro variant

2020-11-23 Thread Sibi Sankar
Add DDR/L3 bandwidth votes for the pro variant of SC7180 SoC, as it support frequencies upto 2.5 GHz. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom

[PATCH v2 1/2] arm64: dts: qcom: sc7180-lite: Tweak DDR/L3 scaling on SC7180-lite

2020-11-23 Thread Sibi Sankar
Tweak the DDR/L3 bandwidth votes on the lite variant of the SC7180 SoC since the gold cores only support frequencies upto 2.1 GHz. Signed-off-by: Sibi Sankar --- V2: * Updated the lite ddr/l3 cpufreq map to have better power numbers with similar perf. arch/arm64/boot/dts/qcom/sc7180

Re: [PATCH 1/2] soc: qcom: aoss: Expose send for generic usecase

2020-11-11 Thread Sibi Sankar
Hey Chris, Thanks for the patch. On 2020-11-03 08:49, Chris Lew wrote: Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew --- drive

Re: [PATCH 1/2] arm64: dts: qcom: sc7180-lite: Tweak DDR/L3 scaling on SC7180-lite

2020-11-10 Thread Sibi Sankar
On 2020-10-17 04:29, Doug Anderson wrote: Hi, On Thu, Oct 15, 2020 at 10:53 AM Sibi Sankar wrote: Tweak the DDR/L3 bandwidth votes on the lite variant of the SC7180 SoC since the gold cores only support frequencies upto 2.1 GHz. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom

[PATCH 1/2] remoteproc: qcom_q6v5_mss: Replace ioremap with memremap

2020-11-03 Thread Sibi Sankar
Fix the sparse warnings reported by the kernel test bot by replacing ioremap calls with memremap. Reported-by: kernel test robot Signed-off-by: Sibi Sankar --- I'll send out the patches to convert ioremap to memremap on other qc remoteproc drivers once I get a chance to test them. dr

[PATCH 2/2] remoteproc: qcom_q6v5_mss: map/unmap MBA region before/after use

2020-11-03 Thread Sibi Sankar
The application processor accessing the MBA region after assigning it to the remote Q6 would lead to an XPU violation. Fix this by un-mapping the MBA region post firmware copy and MBA text log dumps. Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_mss.c | 37

[PATCH 1/2] arm64: dts: qcom: sc7180-lite: Tweak DDR/L3 scaling on SC7180-lite

2020-10-15 Thread Sibi Sankar
Tweak the DDR/L3 bandwidth votes on the lite variant of the SC7180 SoC since the gold cores only support frequencies upto 2.1 GHz. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180-lite.dtsi | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 arch/arm64/boot

[PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

2020-10-15 Thread Sibi Sankar
The modem firmware memory requirements vary between 32M/140M on no-lte/lte skus respectively, so fixup the modem memory region to reflect the requirements. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

[PATCH 2/2] arm64: dts: qcom: sc7180: Add DDR/L3 votes for the pro variant

2020-10-15 Thread Sibi Sankar
Add DDR/L3 bandwidth votes for the pro variant of SC7180 SoC, as it support frequencies upto 2.5 GHz. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-09-21 Thread Sibi Sankar
On 2020-09-22 01:26, Stephen Boyd wrote: Quoting Rafael J. Wysocki (2020-09-21 09:18:17) On Fri, Aug 21, 2020 at 10:49 PM Sibi Sankar wrote: > > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > status of the PM domain unaltered during suspend/resume respective

[PATCH v3] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot

2020-09-17 Thread Sibi Sankar
On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region before MBA boot. This will be a nop during a modem SSR. Signed-off-by: Sibi Sankar --- V3: * Fixup comment style [Stephen] V2: * Fixup

Re: [PATCH v2] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot

2020-09-17 Thread Sibi Sankar
Stephen, Thanks for taking time to review the series. On 2020-09-16 22:47, Stephen Boyd wrote: Quoting Sibi Sankar (2020-09-16 07:52:52) On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region

[PATCH v2] remoteproc: Fixup coredump debugfs disable request

2020-09-16 Thread Sibi Sankar
Fix the discrepancy observed between accepted input and read back value while disabling remoteproc coredump through the coredump debugfs entry. Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry") Cc: sta...@vger.kernel.org Signed-off-by: Sibi Sankar --- V2: * Fixup comm

[PATCH v2] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot

2020-09-16 Thread Sibi Sankar
On secure devices which support warm reset, the MBA firmware requires access to the modem region to clear them out. Hence provide Q6 access to this region before MBA boot. This will be a nop during a modem SSR. Signed-off-by: Sibi Sankar --- V2: * Fixup comments as suggested by Bjorn

Re: [PATCH] remoteproc: Fixup coredump debugfs disable request

2020-09-15 Thread Sibi Sankar
Hey Bjorn, Thanks for taking time to review the patch. On 2020-09-15 20:48, Bjorn Andersson wrote: On Tue 15 Sep 07:34 UTC 2020, Sibi Sankar wrote: Currently the coredump debugfs entry takes in "disable" to set the coredump state to "disabled". Let's just accept t

[PATCH] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA cold boot

2020-09-15 Thread Sibi Sankar
On secure devices which support warm reset, the modem subsystem requires access to the mpss region to clear them out. Hence assign the mpss region to Q6 before MBA cold boot. This will be a nop during a modem SSR. Signed-off-by: Sibi Sankar --- I didn't want to add any new flags for warm

[PATCH] soc: qcom: apr: Fixup the error displayed on lookup failure

2020-09-15 Thread Sibi Sankar
APR client incorrectly prints out "ret" variable on pdr_add_lookup failure, it should be printing the error value returned by the lookup instead. Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality") Signed-off-by: Sibi Sankar --- drivers/soc/qcom/

[PATCH] remoteproc: Fixup coredump debugfs disable request

2020-09-15 Thread Sibi Sankar
Currently the coredump debugfs entry takes in "disable" to set the coredump state to "disabled". Let's just accept the expected state instead. Fixes: 3afdc59e43904 ("remoteproc: Add coredump debugfs entry") Signed-off-by: Sibi Sankar --- drivers/remoteproc/

[PATCH] soc: qcom: pdr: Fixup array type of get_domain_list_resp message

2020-09-14 Thread Sibi Sankar
), db(27), tl(160), i(1), el(1) failed to decode incoming message PDR: tms/servreg get domain list txn wait failed: -14 PDR: service lookup for tms/servreg failed: -14 Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") Reported-by: Rishabh Bhatnagar Signed-of

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-09-10 Thread Sibi Sankar
On 2020-08-25 23:23, Bjorn Andersson wrote: On Tue 25 Aug 02:20 CDT 2020, Stephen Boyd wrote: Quoting Bjorn Andersson (2020-08-24 09:42:12) > On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote: [..] > > I find it odd that this is modeled as a power domain instead of some > > Qualcomm specific me

Re: R: [RFC PATCH v3 0/2] Add Krait Cache Scaling support

2020-09-03 Thread Sibi Sankar
On 2020-09-03 12:23, Viresh Kumar wrote: On 31-08-20, 09:41, ansuels...@gmail.com wrote: On 31-08-20, Sibi wrote: > On 2020-08-24 16:10, Viresh Kumar wrote: > > +Vincent/Saravana/Sibi > > > > On 21-08-20, 16:00, Ansuel Smith wrote: > >> This adds Krait Cache scaling support using the cpufreq not

Re: [RFC PATCH v3 0/2] Add Krait Cache Scaling support

2020-08-30 Thread Sibi Sankar
On 2020-08-24 16:10, Viresh Kumar wrote: +Vincent/Saravana/Sibi On 21-08-20, 16:00, Ansuel Smith wrote: This adds Krait Cache scaling support using the cpufreq notifier. I have some doubt about where this should be actually placed (clk or cpufreq)? Also the original idea was to create a dedica

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-25 Thread Sibi Sankar
On 2020-08-25 12:50, Stephen Boyd wrote: Quoting Bjorn Andersson (2020-08-24 09:42:12) On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote: > Quoting Sibi Sankar (2020-08-21 13:49:20) > > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > > status of the PM d

Re: [PATCH] soc: qcom: initialize local variable

2020-08-25 Thread Sibi Sankar
an earlier loop. However req is a stack variable and its initial value is undefined. So initialize req to 0. Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers") Tom, Thanks for the patch. Reviewed-by: Sibi Sankar Signed-off-by: Tom Rix --- driver

[PATCH v2 2/2] soc: qcom: aoss: Use both GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-21 Thread Sibi Sankar
model this behavior. Signed-off-by: Sibi Sankar --- V2: * Use the renamed flags * Drop R-b/T-b drivers/soc/qcom/qcom_aoss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index ed2c687c16b31..da763ac6bca2f 100644 --- a/drivers/soc

[PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-21 Thread Sibi Sankar
starting its sleep sequence. The application processor powers off these power domains only if the co-processor has crashed or powered off and remains unaltered during system suspend/resume. Signed-off-by: Sibi Sankar --- V2: * Add more info in commit msg and description [Uffe/Kevin/Stephen

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-18 Thread Sibi Sankar
On 2020-08-18 14:01, Ulf Hansson wrote: On Mon, 17 Aug 2020 at 18:49, Sibi Sankar wrote: On 2020-08-17 14:14, Ulf Hansson wrote: > On Thu, 13 Aug 2020 at 19:26, Sibi Sankar wrote: >> >> On 2020-08-13 18:04, Ulf Hansson wrote: >> > On Wed, 12 Aug 2020 at 1

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-17 Thread Sibi Sankar
On 2020-08-17 14:14, Ulf Hansson wrote: On Thu, 13 Aug 2020 at 19:26, Sibi Sankar wrote: On 2020-08-13 18:04, Ulf Hansson wrote: > On Wed, 12 Aug 2020 at 19:03, Sibi Sankar wrote: >> >> Uffe, >> Thanks for taking time to review the >> series! >> >>

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-13 Thread Sibi Sankar
On 2020-08-13 18:04, Ulf Hansson wrote: On Wed, 12 Aug 2020 at 19:03, Sibi Sankar wrote: Uffe, Thanks for taking time to review the series! On 2020-08-12 15:15, Ulf Hansson wrote: > On Tue, 11 Aug 2020 at 21:03, Sibi Sankar wrote: >> >> This is for power domains which needs

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-12 Thread Sibi Sankar
Uffe, Thanks for taking time to review the series! On 2020-08-12 15:15, Ulf Hansson wrote: On Tue, 11 Aug 2020 at 21:03, Sibi Sankar wrote: This is for power domains which needs to stay powered on for suspend but can be powered on/off as part of runtime PM. This flag is aimed at power

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-12 Thread Sibi Sankar
Kevin, Thanks for taking time to review the series! On 2020-08-12 05:49, Kevin Hilman wrote: Sibi Sankar writes: This is for power domains which needs to stay powered on for suspend but can be powered on/off as part of runtime PM. This flag is aimed at power domains coupled to remote

Re: [PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-12 Thread Sibi Sankar
Hey Stephen, Thanks for taking time to review the series! On 2020-08-12 03:08, Stephen Boyd wrote: Quoting Sibi Sankar (2020-08-11 12:02:51) diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index ee11502a575b0..3002a2d68936a 100644 --- a/include/linux/pm_domain.h +++ b

[PATCH 2/2] soc: qcom: aoss: Use GENPD_FLAG_SUSPEND_ON flag

2020-08-11 Thread Sibi Sankar
: Sibi Sankar --- drivers/soc/qcom/qcom_aoss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index ed2c687c16b31..5a5b4bf928147 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -366,6 +366,7 @@ static int

[PATCH 1/2] PM / Domains: Add GENPD_FLAG_SUSPEND_ON flag

2020-08-11 Thread Sibi Sankar
on remote processor crash/shutdown. Signed-off-by: Sibi Sankar --- drivers/base/power/domain.c | 3 ++- include/linux/pm_domain.h | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2cb5e04cf86cd

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-10 Thread Sibi Sankar
da Bhanu Signed-off-by: Rajendra Nayak Reviewed-by: Sibi Sankar --- drivers/opp/core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 0c8c74a..a994f30 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@

Re: [PATCH 1/2] soc: qcom: aoss: Don't wait for IRQ if we might be in suspend/resume noirq

2020-08-06 Thread Sibi Sankar
On 2020-08-06 04:32, Stephen Boyd wrote: +Sibi who wrote the code Quoting Doug Anderson (2020-08-05 13:24:06) On Wed, Aug 5, 2020 at 10:36 AM Stephen Boyd wrote: > > Why is the genpd being powered off at all? It looks like the driver is > written in a way that it doesn't expect this to happ

Re: [PATCH 1/2] soc: qcom: aoss: Don't wait for IRQ if we might be in suspend/resume noirq

2020-08-06 Thread Sibi Sankar
On 2020-08-06 22:40, Doug Anderson wrote: Hi, On Thu, Aug 6, 2020 at 7:36 AM Sibi Sankar wrote: On 2020-08-06 04:32, Stephen Boyd wrote: > +Sibi who wrote the code > > Quoting Doug Anderson (2020-08-05 13:24:06) >> >> On Wed, Aug 5, 2020 at 10:36 AM Stephen Boyd >&

[PATCH 3/7] interconnect: qcom: Lay the groundwork for adding EPSS support

2020-08-01 Thread Sibi Sankar
Lay the groundwork for adding Epoch Subsystem (EPSS) L3 support on SM8250. Signed-off-by: Sibi Sankar --- drivers/interconnect/qcom/osm-l3.c | 37 +- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers

[PATCH 7/7] arm64: dts: qcom: sm8250: Add EPSS L3 interconnect provider

2020-08-01 Thread Sibi Sankar
Add Epoch Subsystem (EPSS) L3 interconnect provider node on SM8250 SoCs. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index

[PATCH 6/7] arm64: dts: qcom: sm8150: Add OSM L3 interconnect provider

2020-08-01 Thread Sibi Sankar
Add Operation State Manager (OSM) L3 interconnect provider node on SM8150 SoCs. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index

[PATCH 1/7] dt-bindings: interconnect: Add OSM L3 DT binding on SM8150

2020-08-01 Thread Sibi Sankar
Add Operation State Manager (OSM) L3 interconnect provider binding on SM8150 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml

[PATCH 5/7] interconnect: qcom: Add EPSS L3 support on SM8250

2020-08-01 Thread Sibi Sankar
Add Epoch Subsystem (EPSS) L3 interconnect provider support on SM8250 SoCs. Signed-off-by: Sibi Sankar --- drivers/interconnect/qcom/osm-l3.c | 23 +++ drivers/interconnect/qcom/sm8250.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/drivers/interconnect/qcom/osm

[PATCH 0/7] Add L3 provider support for SM8150/SM8250

2020-08-01 Thread Sibi Sankar
Add Operation State Manager (OSM) L3 provider support on SM8150 and Epoch Subsystem (EPSS) L3 provider support on SM8250 SoCs. Depends on: https://patchwork.kernel.org/cover/11687925/ Sibi Sankar (7): dt-bindings: interconnect: Add OSM L3 DT binding on SM8150 interconnect: qcom: Add OSM L3

[PATCH 2/7] interconnect: qcom: Add OSM L3 support on SM8150

2020-08-01 Thread Sibi Sankar
Add Operation State Manager (OSM) L3 interconnect provider support on SM8150 SoCs. Signed-off-by: Sibi Sankar --- drivers/interconnect/qcom/osm-l3.c | 15 +++ drivers/interconnect/qcom/sm8150.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/interconnect/qcom/osm-l3

[PATCH 4/7] dt-bindings: interconnect: Add EPSS L3 DT binding on SM8250

2020-08-01 Thread Sibi Sankar
Add Epoch Subsystem (EPSS) L3 interconnect provider binding on SM8250 SoCs. Signed-off-by: Sibi Sankar --- .../devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + include/dt-bindings/interconnect/qcom,osm-l3.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a

Re: [PATCH v3 7/7] arm64: dts: qcom: sm8250: add interconnect nodes

2020-07-28 Thread Sibi Sankar
On 2020-07-28 08:08, Jonathan Marek wrote: Add the interconnect dts nodes for sm8250. Signed-off-by: Jonathan Marek Reviewed-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 1 file changed, 82 insertions(+) diff --git a/arch/arm64/boot/dts/qcom

Re: [PATCH v3 6/7] arm64: dts: qcom: sm8150: add interconnect nodes

2020-07-28 Thread Sibi Sankar
;; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@170 { + compatible = "qcom,sm8150-aggre2-noc"; + re

Re: [PATCH v3 5/7] interconnect: qcom: Add SM8250 interconnect provider driver

2020-07-28 Thread Sibi Sankar
and generated from downstream dts. Signed-off-by: Jonathan Marek Reviewed-by: Sibi Sankar --- drivers/interconnect/qcom/Kconfig | 10 + drivers/interconnect/qcom/Makefile | 2 + drivers/interconnect/qcom/sm8250.c | 651 + drivers/interconnect/qcom/sm8250.h

Re: [PATCH v3 4/7] interconnect: qcom: Add SM8150 interconnect provider driver

2020-07-28 Thread Sibi Sankar
and generated from downstream dts. Signed-off-by: Jonathan Marek Reviewed-by: Sibi Sankar --- drivers/interconnect/qcom/Kconfig | 10 + drivers/interconnect/qcom/Makefile | 2 + drivers/interconnect/qcom/sm8150.c | 635 + drivers/interconnect/qcom/sm8150.h

Re: [PATCH v3 3/7] dt-bindings: interconnect: Add Qualcomm SM8250 DT bindings

2020-07-28 Thread Sibi Sankar
On 2020-07-28 08:08, Jonathan Marek wrote: The Qualcomm SM8250 platform has several bus fabrics that could be controlled and tuned dynamically according to the bandwidth demand. Signed-off-by: Jonathan Marek Reviewed-by: Rob Herring Reviewed-by: Sibi Sankar --- .../bindings/interconnect

Re: [PATCH v3 2/7] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings

2020-07-28 Thread Sibi Sankar
On 2020-07-28 08:08, Jonathan Marek wrote: The Qualcomm SM8150 platform has several bus fabrics that could be controlled and tuned dynamically according to the bandwidth demand. Signed-off-by: Jonathan Marek Reviewed-by: Rob Herring Reviewed-by: Sibi Sankar --- .../bindings/interconnect

Re: [PATCH v3 1/7] dt-bindings: interconnect: single yaml file for RPMh interconnect drivers

2020-07-28 Thread Sibi Sankar
On 2020-07-28 08:08, Jonathan Marek wrote: These two bindings are almost identical, so combine them into one. This will make it easier to add the sm8150 and sm8250 interconnect bindings. Signed-off-by: Jonathan Marek Reviewed-by: Sibi Sankar --- .../{qcom,sdm845.yaml => qcom,rpmh.y

Re: [PATCH 2/6] interconnect: qcom: Implement xlate_extended() to parse tags

2020-07-27 Thread Sibi Sankar
_GPL(qcom_icc_set); +struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec, void *data) +{ + struct icc_node_data *ndata; + struct icc_node *node; + + if (!spec) + return ERR_PTR(-EINVAL); + you could probably skip ^^ check Tested-by: Sibi Sa

Re: [PATCH 4/6] arm64: dts: qcom: sdm845: Increase the number of interconnect cells

2020-07-27 Thread Sibi Sankar
On 2020-07-23 18:39, Georgi Djakov wrote: Increase the number of interconnect-cells, as now we can include the tag information. The consumers can specify the path tag as an additional argument to the endpoints. Tested-by: Sibi Sankar Reviewed-by: Sibi Sankar https://patchwork.kernel.org

Re: [PATCH 3/6] interconnect: qcom: sdm845: Replace xlate with xlate_extended

2020-07-27 Thread Sibi Sankar
On 2020-07-23 18:39, Georgi Djakov wrote: Use the qcom_icc_xlate_extended() in order to parse tags, that are specified as an additional arguments to the path endpoints in DT. Signed-off-by: Georgi Djakov Tested-by: Sibi Sankar Reviewed-by: Sibi Sankar --- drivers/interconnect/qcom

Re: [PATCH 1/6] interconnect: Introduce xlate_extended() callback

2020-07-27 Thread Sibi Sankar
, but the phandle arguments could contain an additional data, such as tag information. Let's create another callback xlate_extended() for the cases where providers want also populate the tagging data. Signed-off-by: Georgi Djakov Tested-by: Sibi Sankar Reviewed-by: Sibi Sankar --

Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes

2020-07-24 Thread Sibi Sankar
On 2020-07-24 20:06, Jonathan Marek wrote: On 7/24/20 10:13 AM, Sibi Sankar wrote: Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. Thanks for the suggestions, I was unsure what to use for the sizes. The reg field is unused by the upstream

Re: [PATCH v2 5/7] interconnect: qcom: Add SM8250 interconnect provider driver

2020-07-24 Thread Sibi Sankar
Hey Jonathan, Thanks for the patch! On 2020-07-13 21:11, Jonathan Marek wrote: Add driver for the Qualcomm interconnect buses found in SM8250 based platforms. The topology consists of several NoCs that are controlled by a remote processor that collects the aggregated bandwidth for each master-sl

Re: [PATCH v2 4/7] interconnect: qcom: Add SM8150 interconnect provider driver

2020-07-24 Thread Sibi Sankar
Hey Jonathan, Thanks for the patch! On 2020-07-13 21:11, Jonathan Marek wrote: Add driver for the Qualcomm interconnect buses found in SM8150 based platforms. The topology consists of several NoCs that are controlled by a remote processor that collects the aggregated bandwidth for each master-sl

Re: [PATCH v2 6/7] arm64: dts: qcom: sm8150: add interconnect nodes

2020-07-24 Thread Sibi Sankar
Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. On 2020-07-13 21:11, Jonathan Marek wrote: Add the interconnect dts nodes for sm8150. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 82 1 f

Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes

2020-07-24 Thread Sibi Sankar
Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. On 2020-07-13 21:11, Jonathan Marek wrote: Add the interconnect dts nodes for sm8250. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 1 f

[PATCH v3 2/3] remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load

2020-07-22 Thread Sibi Sankar
r for the self-authenticating Hexagon v5") Cc: sta...@vger.kernel.org Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_mss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index 4e7

[PATCH v3 1/3] remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load

2020-07-22 Thread Sibi Sankar
sysfs_kf_write+0x58/0x80 kernfs_fop_write+0x140/0x230 vfs_write+0xc4/0x208 ksys_write+0x74/0xf8 __arm64_sys_write+0x24/0x30 ... Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating Hexagon v5") Cc: sta...@vger.kernel.org Signed-off-by: Sibi Sankar --- drivers/

[PATCH v3 3/3] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-22 Thread Sibi Sankar
Add modem debug policy support which will enable coredumps and live debug support when the msadp firmware is present on secure devices. Signed-off-by: Sibi Sankar --- v3: * Fix dp_fw leak and create a separate func for dp load [Bjorn] * Reset dp_size on mba_reclaim v2: * Use

[PATCH v3 0/3] Add modem debug features

2020-07-22 Thread Sibi Sankar
t mba logs * Drop patch 3 where mba text logs are added to imem Sibi Sankar (3): remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load remoteproc: qcom_q6v5_mss: Add modem debug policy support drivers/

Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_mss: Add modem debug policy support

2020-07-21 Thread Sibi Sankar
On 2020-07-22 09:24, Bjorn Andersson wrote: On Tue 21 Jul 04:29 PDT 2020, Sibi Sankar wrote: Add modem debug policy support which will enable coredumps and live debug support when the msadp firmware is present on secure devices. Signed-off-by: Sibi Sankar --- v2: * Use

  1   2   3   4   5   6   >