Re: Revised statx(2) man page for review

Hi Michael On Tue, Apr 25, 2017 at 01:14:26PM +0200, Michael Kerrisk (man-pages) wrote: > > [...] > > Could you please carefully review the text below, in case > I added any errors. Just a few comments below. > [...] > >Invoking statx(): >To access a file's status, no permissio

Re: [PATCH] HID: roccat: Remove use of the "exist" field

Hi Benjamin Thanks for the review! On Mon, Aug 29, 2016 at 12:15 PM, Benjamin Tissoires wrote: > Hi Silvan, > > On Aug 21 2016 or thereabouts, Silvan Jegen wrote: >> The "exist" field is only checked when "roccat_open" has already been >> called or when

[PATCH] HID: roccat: Remove use of the "exist" field

g "exist" we can just check if "open" is equal to zero to the same effect and remove the "exist" field as well as the code that touches it. Signed-off-by: Silvan Jegen --- I have tested this patch with the only Roccat hardware I own, a Roccat Kone Pure. Testing the p

Re: [patch] Squashfs: silence some uninitialized variable warnings

Hi Dan On Wed, Jul 13, 2016 at 12:02 PM, Dan Carpenter wrote: > We print these values in the TRACE() code before we check that > fill_meta_index() was successful. It makes my static checker complain. > > Signed-off-by: Dan Carpenter > > diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c > ind

Re: [PATCH] Input: xpad - Add Mad Catz FightStick TE 2 VID/PID

Hi Ping! Please let me know if you want me to change anything to get this change in. Cheers, Silvan On Mon, Mar 14, 2016 at 8:07 PM, Silvan Jegen wrote: > This adds the VID/PID combination for the Xbox One version of the Mad > Catz FightStick TE 2. > > The functionality that t

[PATCH] Input: xpad - Add Mad Catz FightStick TE 2 VID/PID

n but in my (limited) testing there was no practical difference with or without. The FightStick does not have triggers though so adding it makes sense. Signed-off-by: Silvan Jegen --- drivers/input/joystick/xpad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/joystick/xpad.c b/dr

Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt

On Fri, May 22, 2015 at 1:49 PM, Thierry Reding wrote: > On Fri, May 22, 2015 at 12:33:42PM +0200, Arnd Bergmann wrote: >> On Friday 22 May 2015 12:00:03 Thierry Reding wrote: >> > >> > > Remember, if I have to hand-edit, or do something special with your >> > > patch, I will not do it, you need t

[PATCH V3] [media] mantis: fix error handling

: Silvan Jegen --- V3 Changes (due to Dan Carpenter's and Walter Harms' reviews): - return -ENOMEM/0 directly - remove dprintk calls in the error handling part V2 Changes (due to Dan Carpenter's review): - Remove dead code, do not activate it - Make goto labels

[PATCH v2] [media] mantis: fix error handling

: Silvan Jegen --- V2 Changes (due to Dan Carpenter's review): - Remove dead code, do not activate it - Make goto labels more expressive - Add a call to mantis_dvb_exit drivers/media/pci/mantis/mantis_cards.c | 33 - 1 file changed, 16 inser

Re: [PATCH man-pages] bpf.2: new page documenting bpf(2)

Hi Alexei Please find some comments and suggestions below. On Mon, Mar 9, 2015 at 11:10 PM, Alexei Starovoitov wrote: > Signed-off-by: Alexei Starovoitov > --- > man2/bpf.2 | 593 > > 1 file changed, 593 insertions(+) > create mo

Re: [PATCH 1/2] [media] mantis: Move jump label to activate dead code

Thanks for the review, Dan! On Mon, Feb 16, 2015 at 10:04 AM, Dan Carpenter wrote: > On Sun, Feb 15, 2015 at 01:11:04PM +0100, Silvan Jegen wrote: >> diff --git a/drivers/media/pci/mantis/mantis_cards.c >> b/drivers/media/pci/mantis/mantis_cards.c >> index 801fc55..e5

[PATCH 1/2] [media] mantis: Move jump label to activate dead code

Due to a misplaced goto label mantis_uart_exit is never called. Adjusting the label position (while correcting its numbering) changes this. This issue was found using the smatch static checker. Signed-off-by: Silvan Jegen --- drivers/media/pci/mantis/mantis_cards.c | 5 +++-- 1 file changed

[PATCH 2/2] [media] mantis: Use correct goto labels for cleanup on error

-by: Silvan Jegen --- drivers/media/pci/mantis/mantis_cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c index e566061..71497d8 100644 --- a/drivers/media/pci/mantis/mantis_cards.c +++ b

[PATCH 0/2] [media] mantis: Fix goto labels

I found two issues regarding goto labels in the mantis driver when checking a smatch warning and addressed them in two separate patches. Please be aware that these patches have only been compile-tested since I do not have access to the corresponding hardware. Silvan Jegen (2): [media] mantis

[PATCH] pata_legacy: Remove dead code

The current flow of control prevents this function from being called. Let's remove the call. Signed-off-by: Silvan Jegen --- drivers/ata/pata_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c index be81642..bce2a8c 100644

[PATCH] net: Replace min macro with min_t

Instead of an explicit cast, use the min_t macro. Signed-off-by: Silvan Jegen --- drivers/net/wireless/b43/main.c | 2 +- drivers/net/wireless/b43/sysfs.c | 2 +- drivers/net/wireless/b43/xmit.c | 2 +- drivers/net/wireless/b43legacy/main.c | 4 ++-- drivers/net

[PATCH] Staging: rtl8192e: Replace min macro with min_t

Instead of an explicit cast the min_t macro should be used. Signed-off-by: Silvan Jegen --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

[PATCH] Documentation: Fix trivial spelling mistake in efi-stub.txt

Signed-off-by: Silvan Jegen --- Documentation/efi-stub.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/efi-stub.txt b/Documentation/efi-stub.txt index 44e6bb6..c628788 100644 --- a/Documentation/efi-stub.txt +++ b/Documentation/efi-stub.txt @@ -20,7 +20,7