[PATCH 6/6] staging: pi433: Remove SET_CHECKED usage from pi433_probe

2017-12-06 Thread Simon Sandström
SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7 del

[PATCH 6/6] staging: pi433: Remove SET_CHECKED usage from pi433_probe

2017-12-06 Thread Simon Sandström
SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

[PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

2017-12-06 Thread Simon Sandström
The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.h b/drivers

[PATCH 3/6] staging: pi433: Remove enum data_mode

2017-12-06 Thread Simon Sandström
Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.

[PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Simon Sandström
Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi43

[PATCH 3/6] staging: pi433: Remove enum data_mode

2017-12-06 Thread Simon Sandström
Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 6 -- 4 files

[PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Simon Sandström
Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4 ++-- 3

[PATCH 4/6] staging: pi433: Combine all rf69_set_amplifier_x()

2017-12-06 Thread Simon Sandström
Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH 4/6] staging: pi433: Combine all rf69_set_amplifier_x()

2017-12-06 Thread Simon Sandström
Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c | 46

[PATCH 2/6] staging: pi433: Split rf69_set_sync_enabled into two functions

2017-12-06 Thread Simon Sandström
Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging

[PATCH 2/6] staging: pi433: Split rf69_set_sync_enabled into two functions

2017-12-06 Thread Simon Sandström
Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4

[PATCH 0/6] staging: pi433: Minor cleanup and style fixes

2017-12-06 Thread Simon Sandström
These are the six remaining patches from "[PATCH v2 00/11] Fix indentation and CamelCase issues in staging/pi433" that couldn't be applied, rebased on top of staging-next. - Simon --- Simon Sandström (6): staging: pi433: Split rf69_set_crc_enabled into two functions staging: pi

[PATCH 0/6] staging: pi433: Minor cleanup and style fixes

2017-12-06 Thread Simon Sandström
These are the six remaining patches from "[PATCH v2 00/11] Fix indentation and CamelCase issues in staging/pi433" that couldn't be applied, rebased on top of staging-next. - Simon --- Simon Sandström (6): staging: pi433: Split rf69_set_crc_enabled into two functions staging: pi

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Simon Sandström
On Wed, Dec 06, 2017 at 04:16:04PM +0100, Greg KH wrote: > > I had to stop here in applying this series, as the merge conflicts just > got too much for me to resolve by hand. > > Can you rebase this series on my staging-testing branch of staging.git > and send the remaining patches please? > >

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Simon Sandström
On Wed, Dec 06, 2017 at 04:16:04PM +0100, Greg KH wrote: > > I had to stop here in applying this series, as the merge conflicts just > got too much for me to resolve by hand. > > Can you rebase this series on my staging-testing branch of staging.git > and send the remaining patches please? > >

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-06 Thread Simon Sandström
On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: > On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > > patchset... > > > > I

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-06 Thread Simon Sandström
On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: > On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > > patchset... > > > > I

[PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h

2017-12-05 Thread Simon Sandström
Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 de

[PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h

2017-12-05 Thread Simon Sandström
Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 deletions(-) diff --git

[PATCH v2 05/11] staging: pi433: Rename enum modShaping in rf69_enum.h

2017-12-05 Thread Simon Sandström
Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/

[PATCH v2 05/11] staging: pi433: Rename enum modShaping in rf69_enum.h

2017-12-05 Thread Simon Sandström
Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 21 +++-

[PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe

2017-12-05 Thread Simon Sandström
SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7 del

[PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe

2017-12-05 Thread Simon Sandström
SET_CHECKED returns from the function on failure and in pi433_probe it is necessary to free the GPIOs and the device on failure. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

[PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h

2017-12-05 Thread Simon Sandström
The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h

2017-12-05 Thread Simon Sandström
The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.h b/drivers

[PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-05 Thread Simon Sandström
Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi43

[PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-05 Thread Simon Sandström
Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4 ++-- 3

[PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg

2017-12-05 Thread Simon Sandström
Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2

[PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg

2017-12-05 Thread Simon Sandström
Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2 files changed, 2 insert

[PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-05 Thread Simon Sandström
Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/

[PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-05 Thread Simon Sandström
Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 ++--- drivers/sta

[PATCH v2 08/11] staging: pi433: Remove enum data_mode

2017-12-05 Thread Simon Sandström
Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.

[PATCH v2 08/11] staging: pi433: Remove enum data_mode

2017-12-05 Thread Simon Sandström
Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 6 -- 4 files

[PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled into two functions

2017-12-05 Thread Simon Sandström
Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging

[PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled into two functions

2017-12-05 Thread Simon Sandström
Splits rf69_set_sync_enabled(dev, enabled) into rf69_enable_sync(dev) and rf69_disable_sync(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 21 +++-- drivers/staging/pi433/rf69.c | 18 ++ drivers/staging/pi433/rf69.h | 4

[PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

2017-12-05 Thread Simon Sandström
Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433

2017-12-05 Thread Simon Sandström
only used for ioctl. - Fix issue where GPIOs and device not being deallocated in pi433_probe() if SET_CHECKED fails. - Simon --- Simon Sandström (11): staging: pi433: Fix indentation in rf69_enum.h staging: pi433: Capitalize constant definitions staging: pi

[PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

2017-12-05 Thread Simon Sandström
Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c | 46

[PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433

2017-12-05 Thread Simon Sandström
only used for ioctl. - Fix issue where GPIOs and device not being deallocated in pi433_probe() if SET_CHECKED fails. - Simon --- Simon Sandström (11): staging: pi433: Fix indentation in rf69_enum.h staging: pi433: Capitalize constant definitions staging: pi

[PATCH v2 02/11] staging: pi433: Capitalize constant definitions

2017-12-05 Thread Simon Sandström
Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 i

[PATCH v2 02/11] staging: pi433: Capitalize constant definitions

2017-12-05 Thread Simon Sandström
Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 insertions(+), 38 deletion

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: > > Hi Simon, hi Dan, > > if you both are of the same opinion, for me, it's fine, if we go with two > functions. > > But I don't get the advantage, if we split approx. 10 functions, to get rid > of enum optionOnOff. > > Keep in mind,

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: > > Hi Simon, hi Dan, > > if you both are of the same opinion, for me, it's fine, if we go with two > functions. > > But I don't get the advantage, if we split approx. 10 functions, to get rid > of enum optionOnOff. > > Keep in mind,

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: > > > Am 04.12.2017 um 21:15 schrieb Dan Carpenter: > > > > That's a bad name, because it doesn't just enable it also disables. > > Please split them. > > > > regards, > > dan carpenter > > > > > > Same applies to all other stuff,

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: > > > Am 04.12.2017 um 21:15 schrieb Dan Carpenter: > > > > That's a bad name, because it doesn't just enable it also disables. > > Please split them. > > > > regards, > > dan carpenter > > > > > > Same applies to all other stuff,

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Sun, Dec 03, 2017 at 06:49:40PM +0200, Marcus Wolf wrote: > > Hi Simon, Hi, > > thanks for your effort. > > I have two questions: > * According to my practical experiance, enums were always written in lower > case. Does kernel style guide ask for upper case for enums? Yes. From

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Sun, Dec 03, 2017 at 06:49:40PM +0200, Marcus Wolf wrote: > > Hi Simon, Hi, > > thanks for your effort. > > I have two questions: > * According to my practical experiance, enums were always written in lower > case. Does kernel style guide ask for upper case for enums? Yes. From

[PATCH 2/6] staging: pi433: Capitalize constant definitions

2017-12-03 Thread Simon Sandström
Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 i

[PATCH 2/6] staging: pi433: Capitalize constant definitions

2017-12-03 Thread Simon Sandström
Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 insertions(+), 38 deletion

[PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/

[PATCH 3/6] staging: pi433: Rename variable in struct pi433_rx_cfg

2017-12-03 Thread Simon Sandström
Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2

[PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 ++--- drivers/sta

[PATCH 3/6] staging: pi433: Rename variable in struct pi433_rx_cfg

2017-12-03 Thread Simon Sandström
Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2 files changed, 2 insert

[PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/

[PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 21 +++-

[PATCH 1/6] staging: pi433: Fix indentation in rf69_enum.h

2017-12-03 Thread Simon Sandström
Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 de

[PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid CamelCase: , ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/pi433/pi433_if.c

[PATCH 1/6] staging: pi433: Fix indentation in rf69_enum.h

2017-12-03 Thread Simon Sandström
Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 deletions(-) diff --git

[PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid CamelCase: , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi

[PATCH 0/6] Fix indentation and CamelCase issues in staging/pi433

2017-12-03 Thread Simon Sandström
These patches fixes a bunch of code style issues in staging/pi433. The first patch fixes indentation in rf69_enum.h and the rest of the patches fixes CamelCase issues in all of staging/pi433. In total the patches get rids of around 140 warnings generated by checkpatch.pl. - Simon --- Simon

[PATCH 0/6] Fix indentation and CamelCase issues in staging/pi433

2017-12-03 Thread Simon Sandström
These patches fixes a bunch of code style issues in staging/pi433. The first patch fixes indentation in rf69_enum.h and the rest of the patches fixes CamelCase issues in all of staging/pi433. In total the patches get rids of around 140 warnings generated by checkpatch.pl. - Simon --- Simon

[PATCH 2/4] staging: vt6656: Remove unnecessary blank lines

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open brace". Also adds braces to balance if-else statement. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/vt6656/power.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 0/4] staging: vt6656: Correct checkpatch.pl warnings

2017-06-30 Thread Simon Sandström
files. It was easier to write commit messages when grouped on type of warning, so that's what I did :-) - Simon --- Simon Sandström (4): staging: vt6656: Add spaces between operators staging: vt6656: Remove unnecessary blank lines staging: vt6656: Align function parameters staging

[PATCH 2/4] staging: vt6656: Remove unnecessary blank lines

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warning "Blank lines aren't necessary after an open brace". Also adds braces to balance if-else statement. Signed-off-by: Simon Sandström --- drivers/staging/vt6656/power.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stag

[PATCH 0/4] staging: vt6656: Correct checkpatch.pl warnings

2017-06-30 Thread Simon Sandström
files. It was easier to write commit messages when grouped on type of warning, so that's what I did :-) - Simon --- Simon Sandström (4): staging: vt6656: Add spaces between operators staging: vt6656: Remove unnecessary blank lines staging: vt6656: Align function parameters staging

[PATCH 4/4] staging: vt6656: Use variable instead of its type in sizeof(...)

2017-06-30 Thread Simon Sandström
Use sizeof(variable) instead of sizeof(type) in memory allocations to prevent problems if the variable type changes in the future. Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/vt6656/main_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 4/4] staging: vt6656: Use variable instead of its type in sizeof(...)

2017-06-30 Thread Simon Sandström
Use sizeof(variable) instead of sizeof(type) in memory allocations to prevent problems if the variable type changes in the future. Signed-off-by: Simon Sandström --- drivers/staging/vt6656/main_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656

[PATCH 1/4] staging: vt6656: Add spaces between operators

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "spaces preferred around that ". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/firmware.c | 2 +- drivers/staging/vt6656/rf.c | 4 ++-- 3 files changed, 4 insertions

[PATCH 3/4] staging: vt6656: Align function parameters

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "Alignment should match open parenthesis". Signed-off-by: Simon Sandström <si...@nikanor.nu> --- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/rf.c | 2 +- drivers/staging/vt6656/usbpipe.c | 4 ++-- 3 files changed, 4 insertions

[PATCH 1/4] staging: vt6656: Add spaces between operators

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "spaces preferred around that ". Signed-off-by: Simon Sandström --- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/firmware.c | 2 +- drivers/staging/vt6656/rf.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 3/4] staging: vt6656: Align function parameters

2017-06-30 Thread Simon Sandström
Fixes checkpatch.pl warnings "Alignment should match open parenthesis". Signed-off-by: Simon Sandström --- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/rf.c | 2 +- drivers/staging/vt6656/usbpipe.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-23 Thread Simon Sandström
On Thu, Feb 23, 2017 at 01:17:02AM -0500, Jeff King wrote: > On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: > > > > > I don't know what happened, I used git for this, I don't use quilt for > > "normal" patches accepted into my trees anymore, only for stable kernel > > work. > > > > So

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-23 Thread Simon Sandström
On Thu, Feb 23, 2017 at 01:17:02AM -0500, Jeff King wrote: > On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: > > > > > I don't know what happened, I used git for this, I don't use quilt for > > "normal" patches accepted into my trees anymore, only for stable kernel > > work. > > > > So

<    1   2