RE: drivers/net/tokenring/3c359.c

2007-08-15 Thread Sivakumar Subramani
What exactly the difference between kzalloc and kcalloc? From the definition, I could see that kcalloc should be used for array allocation. But I could see kzalloc is used for allocation arrays as in the below patch. Any coding standard (or) developers can use kzalloc and kcalloc as per their codi

RE: 2.6.22: ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined!

2007-06-21 Thread Sivakumar Subramani
Hi, We will include this fix in next set of patch submission. Thanks for the fix. Thanks, ~Siva -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Olaf Hering Sent: Wednesday, June 20, 2007 2:11 AM To: Stephen Hemminger Cc: linux-kernel@vger.kernel.org; [EM

RE: [PATCH 1/2] s2io: add PCI error recovery support

2007-05-18 Thread Sivakumar Subramani
Hi, Fix looks good. I have couple of comments, 1) Return from s2io_updt_stats function if the PCI bus is offline (pci_channel_offline). if (pci_channel_offline(pdev)) return; 2) No Need to call netif_wake_queue() in s2io_io_resume as netif_device_attach() will take care