Re: [PATCH] Bluetooth: btusb: Always fallback to alt 1 for WBS

2021-02-06 Thread Sjoerd Simons
et: Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints") In my testing this indeed fixes mSBC audio with both a Belkin (Broadcom BCM20702A, 050d:065a) and an Intel Bluetooth (8087:0a2b) adapters. Tested-By: Sjoerd Simons Regards, Sjoerd

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
On Tue, 2018-11-20 at 15:24 +0100, Ulf Hansson wrote: > On 20 November 2018 at 15:00, Sjoerd Simons > wrote: > > On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: > > > + Hal Emmerich > > > > > > On 20 November 2018 at 12:38, Sjoerd Simons > >

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
On Tue, 2018-11-20 at 15:24 +0100, Ulf Hansson wrote: > On 20 November 2018 at 15:00, Sjoerd Simons > wrote: > > On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: > > > + Hal Emmerich > > > > > > On 20 November 2018 at 12:38, Sjoerd Simons > >

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: > + Hal Emmerich > > On 20 November 2018 at 12:38, Sjoerd Simons > wrote: > > On Tue, 2018-11-20 at 11:23 +0100, Wolfram Sang wrote: > > > > > > > > So if you know the pattern, or just happen to

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
On Tue, 2018-11-20 at 14:08 +0100, Ulf Hansson wrote: > + Hal Emmerich > > On 20 November 2018 at 12:38, Sjoerd Simons > wrote: > > On Tue, 2018-11-20 at 11:23 +0100, Wolfram Sang wrote: > > > > > > > > So if you know the pattern, or just happen to

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
ould be nice if someone happens to have the right contacts with Micron to see if it's a known issue for their cards in general or just this one. Also would be good to have a timeout higher then 1 seconds (or for these cards not have one?); On our testing thusfar we've seen timeouts up to 850ms, but it's impossible to ensure that that's the true upper bound. -- Sjoerd Simons Collabora Ltd.

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-20 Thread Sjoerd Simons
ould be nice if someone happens to have the right contacts with Micron to see if it's a known issue for their cards in general or just this one. Also would be good to have a timeout higher then 1 seconds (or for these cards not have one?); On our testing thusfar we've seen timeouts up to 850ms, but it's impossible to ensure that that's the true upper bound. -- Sjoerd Simons Collabora Ltd.

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-06 Thread Sjoerd Simons
On Tue, 2018-11-06 at 19:34 +0530, Faiz Abbas wrote: > Hi Sjoerd, > > On Tuesday 06 November 2018 07:00 PM, Sjoerd Simons wrote: > > On some of our boards containing Micron eMMC chips compatible with > > the eMMC 5.0 specification we starting seeing boot failures due to >

Re: [PATCH] mmc: core: Remove timeout when enabling cache

2018-11-06 Thread Sjoerd Simons
On Tue, 2018-11-06 at 19:34 +0530, Faiz Abbas wrote: > Hi Sjoerd, > > On Tuesday 06 November 2018 07:00 PM, Sjoerd Simons wrote: > > On some of our boards containing Micron eMMC chips compatible with > > the eMMC 5.0 specification we starting seeing boot failures due to >

[PATCH] mmc: core: Remove timeout when enabling cache

2018-11-06 Thread Sjoerd Simons
HE command. Signed-off-by: Sjoerd Simons --- drivers/mmc/core/mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index bc1bd2c25613..ac70b508a939 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1794

[PATCH] mmc: core: Remove timeout when enabling cache

2018-11-06 Thread Sjoerd Simons
HE command. Signed-off-by: Sjoerd Simons --- drivers/mmc/core/mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index bc1bd2c25613..ac70b508a939 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1794

[PATCH] drm/tilcdc: Defer probe if there are no connectors

2018-03-30 Thread Sjoerd Simons
During probe there may not be any connectors yet if e.g. the panel failed or hasn't been probed yet. I hitting this in practice the panels probing was being delayed due to using a gpio backlight. Fix this by returning -EPROBE_DEFER so the probing will be retried. Signed-off-by: Sjoerd Simons

[PATCH] drm/tilcdc: Defer probe if there are no connectors

2018-03-30 Thread Sjoerd Simons
During probe there may not be any connectors yet if e.g. the panel failed or hasn't been probed yet. I hitting this in practice the panels probing was being delayed due to using a gpio backlight. Fix this by returning -EPROBE_DEFER so the probing will be retried. Signed-off-by: Sjoerd Simons

Re: [PATCH 4.12 00/84] 4.12.3-stable review

2017-07-24 Thread Sjoerd Simons
ss differes from mine in the same way. Correct, tuning the load addresses there results in a happy boot. The kernel does relocate itself on boot if it detects decompression will overwrite itself. On the panda though that seemingly meant the dtb got overwritten, just bumping that out of the way made it boot as well. I didn't check if the same happened on XU3 (which has/had far more space between the kernel and the dtb).. That said, it's far safer (and faster) to avoid running into that corner case :) > @Sjoerd: can someone in lab-collabora maybe have a closer look? > > Kevin -- Sjoerd Simons Collabora Ltd.

Re: [PATCH 4.12 00/84] 4.12.3-stable review

2017-07-24 Thread Sjoerd Simons
the same way. Correct, tuning the load addresses there results in a happy boot. The kernel does relocate itself on boot if it detects decompression will overwrite itself. On the panda though that seemingly meant the dtb got overwritten, just bumping that out of the way made it boot as well. I didn't check if the same happened on XU3 (which has/had far more space between the kernel and the dtb).. That said, it's far safer (and faster) to avoid running into that corner case :) > @Sjoerd: can someone in lab-collabora maybe have a closer look? > > Kevin -- Sjoerd Simons Collabora Ltd.

Re: [PATCH] RFC: serial: core: Dynamic minor support

2017-04-20 Thread Sjoerd Simons
On Thu, 2017-04-20 at 14:15 +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 02:03:57PM +0200, Sjoerd Simons wrote: > > --- a/include/linux/serial_core.h > > +++ b/include/linux/serial_core.h > > @@ -31,6 +31,8 @@ > >  #include > >  #include > >

Re: [PATCH] RFC: serial: core: Dynamic minor support

2017-04-20 Thread Sjoerd Simons
On Thu, 2017-04-20 at 14:15 +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 02:03:57PM +0200, Sjoerd Simons wrote: > > --- a/include/linux/serial_core.h > > +++ b/include/linux/serial_core.h > > @@ -31,6 +31,8 @@ > >  #include > >  #include > >

[PATCH v2 1/2] serial: pl010: Move uart_register_driver call to device probe

2017-04-20 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- Changes in v2: - Add locking to prevent issues when two probes run in parallel drivers/tty/serial/amba-pl010.c | 31 +---

[PATCH v2 1/2] serial: pl010: Move uart_register_driver call to device probe

2017-04-20 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons --- Changes in v2: - Add locking to prevent issues when two probes run in parallel drivers/tty/serial/amba-pl010.c | 31 +-- 1 file changed, 21 insertions(+), 10

[PATCH v2 0/2] Move uart_register_driver call to device probe for pl010 and sh-sci

2017-04-20 Thread Sjoerd Simons
to probe time for both drivers avoiding the issue. Changes in v2: - Add locking to prevent issues when two probes run in parallel Sjoerd Simons (2): serial: pl010: Move uart_register_driver call to device probe serial: sh-sci: Move uart_register_driver call to device probe drivers/tty/serial

[PATCH v2 0/2] Move uart_register_driver call to device probe for pl010 and sh-sci

2017-04-20 Thread Sjoerd Simons
to probe time for both drivers avoiding the issue. Changes in v2: - Add locking to prevent issues when two probes run in parallel Sjoerd Simons (2): serial: pl010: Move uart_register_driver call to device probe serial: sh-sci: Move uart_register_driver call to device probe drivers/tty/serial

[PATCH v2 2/2] serial: sh-sci: Move uart_register_driver call to device probe

2017-04-20 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- Changes in v2: - Add locking to prevent issues when two probes run in parallel drivers/tty/serial/sh-sci.c | 26 +++--- 1 file c

[PATCH v2 2/2] serial: sh-sci: Move uart_register_driver call to device probe

2017-04-20 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons --- Changes in v2: - Add locking to prevent issues when two probes run in parallel drivers/tty/serial/sh-sci.c | 26 +++--- 1 file changed, 15 insertions(+), 11

[PATCH] RFC: serial: core: Dynamic minor support

2017-04-20 Thread Sjoerd Simons
of deterministically specifying serial console devices. While it would be an option to move to consistent serial device naming while keeping the current console names, having both not aligned would probably confuse everyone massively. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co

[PATCH] RFC: serial: core: Dynamic minor support

2017-04-20 Thread Sjoerd Simons
of deterministically specifying serial console devices. While it would be an option to move to consistent serial device naming while keeping the current console names, having both not aligned would probably confuse everyone massively. Signed-off-by: Sjoerd Simons --- drivers/tty/seria

[PATCH 3/3] usb: dwc2: Power off the phy on shutdown

2017-04-05 Thread Sjoerd Simons
ave the issue). This can be avoided by turning off the phy (thus vbus) during shutdown, which turns off the usb hub. For devices where this isn't required, powering down the phy is harmless so we can do this unconditionally. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- dr

[PATCH 3/3] usb: dwc2: Power off the phy on shutdown

2017-04-05 Thread Sjoerd Simons
ave the issue). This can be avoided by turning off the phy (thus vbus) during shutdown, which turns off the usb hub. For devices where this isn't required, powering down the phy is harmless so we can do this unconditionally. Signed-off-by: Sjoerd Simons --- drivers/usb/dwc2/platform.c | 3 +++ 1 f

[PATCH 0/3] rockchip dwc2: Turn off vbus on shutdown

2017-04-05 Thread Sjoerd Simons
add the ability to describe vbus regulators for the rockchip usb phy, second one starts using that on the rock2 square board and while the final one adds the actual workaround of turning off the phy on shutdown. Sjoerd Simons (3): phy: rockchip-usb: Add vbus regulator support. ARM: dts: rockc

[PATCH 0/3] rockchip dwc2: Turn off vbus on shutdown

2017-04-05 Thread Sjoerd Simons
add the ability to describe vbus regulators for the rockchip usb phy, second one starts using that on the rock2 square board and while the final one adds the actual workaround of turning off the phy on shutdown. Sjoerd Simons (3): phy: rockchip-usb: Add vbus regulator support. ARM: dts: rockc

[PATCH 1/3] phy: rockchip-usb: Add vbus regulator support.

2017-04-05 Thread Sjoerd Simons
On rockchip devices vbus is supplied by a separate power supply, often through a regulator. Add support for describing the the regulator in device-tree following the same convention as several other usb phy's. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- .../devi

[PATCH 1/3] phy: rockchip-usb: Add vbus regulator support.

2017-04-05 Thread Sjoerd Simons
On rockchip devices vbus is supplied by a separate power supply, often through a regulator. Add support for describing the the regulator in device-tree following the same convention as several other usb phy's. Signed-off-by: Sjoerd Simons --- .../devicetree/bindings/phy/rockchip-usb-phy.txt

[PATCH 2/3] ARM: dts: rockchip: rock2: Setup usb vbus-supply

2017-04-05 Thread Sjoerd Simons
Now that the rockchip usb phy has a vbus-supply property use that to control the vbus regulator on rock2. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- arch/arm/boot/dts/rk3288-rock2-square.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/3] ARM: dts: rockchip: rock2: Setup usb vbus-supply

2017-04-05 Thread Sjoerd Simons
Now that the rockchip usb phy has a vbus-supply property use that to control the vbus regulator on rock2. Signed-off-by: Sjoerd Simons --- arch/arm/boot/dts/rk3288-rock2-square.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-rock2

[PATCH 2/2] serial: sh-sci: Move uart_register_driver call to device probe

2017-03-24 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/tty/serial/sh-sci.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/sh-s

[PATCH 1/2] serial: pl010: Move uart_register_driver call to device probe

2017-03-24 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/tty/serial/amba-pl010.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/tty/seria

[PATCH 0/2] Move uart_register_driver call to device probe for pl010 and sh-sci

2017-03-24 Thread Sjoerd Simons
to probe time for both drivers avoiding the issue. Sjoerd Simons (2): serial: pl010: Move uart_register_driver call to device probe serial: sh-sci: Move uart_register_driver call to device probe drivers/tty/serial/amba-pl010.c | 27 +-- drivers/tty/serial/sh-sci.c

[PATCH 2/2] serial: sh-sci: Move uart_register_driver call to device probe

2017-03-24 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons --- drivers/tty/serial/sh-sci.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index

[PATCH 1/2] serial: pl010: Move uart_register_driver call to device probe

2017-03-24 Thread Sjoerd Simons
if multiple serial drivers with overlapping major/minor numbers are included. Signed-off-by: Sjoerd Simons --- drivers/tty/serial/amba-pl010.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/amba-pl010.c b/drivers/tty/serial/amba

[PATCH 0/2] Move uart_register_driver call to device probe for pl010 and sh-sci

2017-03-24 Thread Sjoerd Simons
to probe time for both drivers avoiding the issue. Sjoerd Simons (2): serial: pl010: Move uart_register_driver call to device probe serial: sh-sci: Move uart_register_driver call to device probe drivers/tty/serial/amba-pl010.c | 27 +-- drivers/tty/serial/sh-sci.c

[PATCH] ARM: dts: rockchip: Enable sata support on rock2 square

2017-03-17 Thread Sjoerd Simons
The Rock 2 square board has a USB -> SATA converter hooked up to its usb host1 connection. Enable the usb controller and always turn on the power on the 5V sata power connector (controlled by gpio). Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- arch/arm/boot/dts/rk3

[PATCH] ARM: dts: rockchip: Enable sata support on rock2 square

2017-03-17 Thread Sjoerd Simons
The Rock 2 square board has a USB -> SATA converter hooked up to its usb host1 connection. Enable the usb controller and always turn on the power on the 5V sata power connector (controlled by gpio). Signed-off-by: Sjoerd Simons --- arch/arm/boot/dts/rk3288-rock2-square.dts |

Re: [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module

2016-06-20 Thread Sjoerd Simons
sg.samsung.com> Make sense to me, Reviewed-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> > --- > >  arch/arm/configs/multi_v7_defconfig | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch

Re: [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module

2016-06-20 Thread Sjoerd Simons
module autoload was not > working when the I2C device was registered by OF but this got fixed > in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C > table for module autoload") so it's safe to enable as a module now. > > Signed-off-by: Javier Martinez Canillas Make

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-08 Thread Sjoerd Simons
On Thu, 2016-04-07 at 16:21 -0700, Stephen Boyd wrote: > On 04/06, Sjoerd Simons wrote: > > > > On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > > > > > > CC Mike, Stephen, linux-clk (this time with the new Mike) > > > > >

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-08 Thread Sjoerd Simons
On Thu, 2016-04-07 at 16:21 -0700, Stephen Boyd wrote: > On 04/06, Sjoerd Simons wrote: > > > > On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > > > > > > CC Mike, Stephen, linux-clk (this time with the new Mike) > > > > >

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-07 Thread Sjoerd Simons
Hey Sergei, Thanks for your review. On Thu, 2016-04-07 at 02:15 +0300, Sergei Shtylyov wrote: > On 04/06/2016 03:52 PM, Sjoerd Simons wrote: > > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > can > > cause drivers to be deferred forever

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-07 Thread Sjoerd Simons
Hey Sergei, Thanks for your review. On Thu, 2016-04-07 at 02:15 +0300, Sergei Shtylyov wrote: > On 04/06/2016 03:52 PM, Sjoerd Simons wrote: > > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > can > > cause drivers to be deferred forever

[PATCH] Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

2016-04-06 Thread Sjoerd Simons
This reverts commit 19417bd9c5112f58ea63e97ba72edabd5e1cc0fe as according to http://elinux.org/File:R-CarM2-KOELSCH_PORTER-B_PORTER_C_Comparison.pdf the external oscilator for SCIF_CLK is not mounted on the porter boards. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> ---

[PATCH] Revert "ARM: dts: porter: Enable SCIF_CLK frequency and pins"

2016-04-06 Thread Sjoerd Simons
This reverts commit 19417bd9c5112f58ea63e97ba72edabd5e1cc0fe as according to http://elinux.org/File:R-CarM2-KOELSCH_PORTER-B_PORTER_C_Comparison.pdf the external oscilator for SCIF_CLK is not mounted on the porter boards. Signed-off-by: Sjoerd Simons --- arch/arm/boot/dts/r8a7791-porter.dts

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > CC Mike, Stephen, linux-clk (this time with the new Mike) > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > <sjoerd.sim...@collabora.co.uk> wrote: > > > > clk_get on a disabled clock node will retu

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > CC Mike, Stephen, linux-clk (this time with the new Mike) > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > wrote: > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > can &g

[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 1 + arch/arm/boot/dts/r8a7791-porter.dts | 1 + arch/arm/boot/dts/r8a7791.dtsi| 5 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.

[PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
-by: Sjoerd Simons --- arch/arm/boot/dts/r8a7791-koelsch.dts | 1 + arch/arm/boot/dts/r8a7791-porter.dts | 1 + arch/arm/boot/dts/r8a7791.dtsi| 5 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791

[PATCH] drm: rcar-du: Only unwindow as necessary on probe failure

2016-04-06 Thread Sjoerd Simons
+0x58/0xa8) [2.917976] r9: r8:c0a1cca4 r7:c0a71a48 r6:c0a1cca4 r5:ef1dc610 r4:c0440b80 Adjust the code to only unwind as necessary on probe failures Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/gpu/drm/rcar-du/rcar_du_drv.

[PATCH] drm: rcar-du: Only unwindow as necessary on probe failure

2016-04-06 Thread Sjoerd Simons
+0x58/0xa8) [2.917976] r9: r8:c0a1cca4 r7:c0a71a48 r6:c0a1cca4 r5:ef1dc610 r4:c0440b80 Adjust the code to only unwind as necessary on probe failures Signed-off-by: Sjoerd Simons --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 32 +--- 1 file changed, 25

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-26 Thread Sjoerd Simons
an get a better idea how often this happens and its behaviour. I guess one other thing to note is that both Doug and myself were seeing this on Rockchip RK3288 based devices. It would ofcourse be interesting to know if this has been seen on other types of devices.. --  Sjoerd Simons Collabora Ltd.

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-26 Thread Sjoerd Simons
an get a better idea how often this happens and its behaviour. I guess one other thing to note is that both Doug and myself were seeing this on Rockchip RK3288 based devices. It would ofcourse be interesting to know if this has been seen on other types of devices.. --  Sjoerd Simons Collabora Ltd.

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
On Mon, 2016-01-25 at 16:36 +0100, Arend van Spriel wrote: > On 25-01-16 11:47, Sjoerd Simons wrote: > > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it > > seems > > the card responds very quickly most of the time, unfortunately > > during > >

[PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally

2016-01-25 Thread Sjoerd Simons
issues when the clock framework get support for deferring on orphaned clocks, while specific boards can always change the parent clock if an external input is preferred. Signed-off-by: Sjoerd Simons --- arch/arm/boot/dts/rk3288-veyron.dtsi | 5 - arch/arm/boot/dts/rk3288.dtsi| 3 +++ 2

Re: [PATCH 1/2] drm/rockchip: Don't build rockchip_drm_vop as modules

2016-01-25 Thread Sjoerd Simons
> + rockchip_drm_gem.o rockchip_drm_vop.o >   >  obj-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o >   > -obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_drm_vop.o \ > - rockchip_vop_reg.o > +obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_vop_reg.o -- Sjoerd Simons Collabora Ltd.

[PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
has a similar patch in their ChromeOS tree, so this doesn't seem specific to the board I'm using. Signed-off-by: Sjoerd Simons --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
On Mon, 2016-01-25 at 16:36 +0100, Arend van Spriel wrote: > On 25-01-16 11:47, Sjoerd Simons wrote: > > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it > > seems > > the card responds very quickly most of the time, unfortunately > > during > >

[PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally

2016-01-25 Thread Sjoerd Simons
issues when the clock framework get support for deferring on orphaned clocks, while specific boards can always change the parent clock if an external input is preferred. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- arch/arm/boot/dts/rk3288-veyron.dtsi | 5 - arch/arm/bo

[PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
has a similar patch in their ChromeOS tree, so this doesn't seem specific to the board I'm using. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH 1/2] drm/rockchip: Don't build rockchip_drm_vop as modules

2016-01-25 Thread Sjoerd Simons
rockchip_drm_fbdev.o \ > - rockchip_drm_gem.o > + rockchip_drm_gem.o rockchip_drm_vop.o >   >  obj-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o >   > -obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_drm_vop.o \ > - rockchip_vop_reg.o > +obj-$(CONF

[PATCH] ASoC: rockchip: spdif: Set transmit data level to 16 samples

2015-12-11 Thread Sjoerd Simons
in the TDL mask definition Signed-off-by: Sjoerd Simons --- sound/soc/rockchip/rockchip_spdif.c | 6 -- sound/soc/rockchip/rockchip_spdif.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockchip_spdif.c index

[PATCH] ASoC: rockchip: spdif: Set transmit data level to 16 samples

2015-12-11 Thread Sjoerd Simons
in the TDL mask definition Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- sound/soc/rockchip/rockchip_spdif.c | 6 -- sound/soc/rockchip/rockchip_spdif.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sou

[PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit

2015-11-25 Thread Sjoerd Simons
Correct valid data word register value for 24 bit data width. The bit value should be 10 (aka 0x2), not 0x10. This fixes playback of 24 bit audio. Signed-off-by: Sjoerd Simons --- sound/soc/rockchip/rockchip_spdif.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit

2015-11-25 Thread Sjoerd Simons
Correct valid data word register value for 24 bit data width. The bit value should be 10 (aka 0x2), not 0x10. This fixes playback of 24 bit audio. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- sound/soc/rockchip/rockchip_spdif.h | 6 +++--- 1 file changed, 3 inse

Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases

2015-11-24 Thread Sjoerd Simons
p)) >   *tmp = '_'; >   > - add_wildcard(alias); >   return 1; >  } >  ADD_TO_DEVTABLE("of", of_device_id, do_of_entry); Reviewed-by: Sjoerd Simons -- Sjoerd Simons Collabora Ltd.

Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases

2015-11-24 Thread Sjoerd Simons
p)) >   *tmp = '_'; >   > - add_wildcard(alias); >   return 1; >  } >  ADD_TO_DEVTABLE("of", of_device_id, do_of_entry); Reviewed-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> -- Sjoerd Simons Collabora Ltd.

[PATCH] ARM: dts: rockchip: Add IR receiver to Radxa Rock 2 Square

2015-11-23 Thread Sjoerd Simons
Add support for the IR receiver as present on the Radxa Rock 2 Square board. Signed-off-by: Sjoerd Simons --- arch/arm/boot/dts/rk3288-rock2-square.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts b/arch/arm/boot/dts/rk3288

[PATCH] [media] rc-core: Try loading modules if the kernel supports them

2015-11-23 Thread Sjoerd Simons
Always try to load modules for RC keymaps when the kernel supports modules, not just when the RC Core is build as a module. Fixes module autoloading issues when the core is builtin but the keymaps are not. Signed-off-by: Sjoerd Simons --- drivers/media/rc/rc-main.c | 2 +- 1 file changed, 1

[PATCH] [media] rc-core: Try loading modules if the kernel supports them

2015-11-23 Thread Sjoerd Simons
Always try to load modules for RC keymaps when the kernel supports modules, not just when the RC Core is build as a module. Fixes module autoloading issues when the core is builtin but the keymaps are not. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/media

[PATCH] ARM: dts: rockchip: Add IR receiver to Radxa Rock 2 Square

2015-11-23 Thread Sjoerd Simons
Add support for the IR receiver as present on the Radxa Rock 2 Square board. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- arch/arm/boot/dts/rk3288-rock2-square.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-rock2-squa

Re: [PATCH] dmaengine: pl330: Fix race in residue reporting

2015-11-09 Thread Sjoerd Simons
On Sat, 2015-11-07 at 21:40 +0900, Krzysztof Kozlowski wrote: > W dniu 06.11.2015 o 20:11, Sjoerd Simons pisze: > > When a transfer completes there is a small window between the > > descriptor > > being unset as the current active one in the thread and it being > > mark

Re: [PATCH] dmaengine: pl330: Fix race in residue reporting

2015-11-09 Thread Sjoerd Simons
On Sat, 2015-11-07 at 21:40 +0900, Krzysztof Kozlowski wrote: > W dniu 06.11.2015 o 20:11, Sjoerd Simons pisze: > > When a transfer completes there is a small window between the > > descriptor > > being unset as the current active one in the thread and it being > > mark

[RESEND PATCH] drm/rockchip: vop: Correct enabled clocks during setup

2015-11-06 Thread Sjoerd Simons
). While there also switch to doing prepare and enable in one step rather then separate steps to reduce the amount of code required. Signed-off-by: Sjoerd Simons Acked-by: Mark Yao Tested-by: Yakir Yang Tested-by: Romain Perier --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36

[PATCH] dmaengine: pl330: Fix race in residue reporting

2015-11-06 Thread Sjoerd Simons
change underneath it. Signed-off-by: Sjoerd Simons --- drivers/dma/pl330.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 17ee758..6c8243b 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -503,6 +503,8

[RESEND PATCH] drm/rockchip: vop: Correct enabled clocks during setup

2015-11-06 Thread Sjoerd Simons
). While there also switch to doing prepare and enable in one step rather then separate steps to reduce the amount of code required. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> Acked-by: Mark Yao <mark@rock-chips.com> Tested-by: Yakir Yang <y...@rock-chips.com>

[PATCH] dmaengine: pl330: Fix race in residue reporting

2015-11-06 Thread Sjoerd Simons
change underneath it. Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk> --- drivers/dma/pl330.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 17ee758..6c8243b 100644 --- a/drivers/dma/pl330.c +++ b/d

Re: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036

2015-10-19 Thread Sjoerd Simons
drvdata(pdev); > + > + snd_soc_unregister_card(card); > + > + return 0; > +} > + > +static const struct of_device_id rockchip_rk3036_of_match[] = { > + { .compatible = "rockchip,rk3036-audio", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of

Re: [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036

2015-10-19 Thread Sjoerd Simons
_device > *pdev) > +{ > + struct snd_soc_card *card = platform_get_drvdata(pdev); > + > + snd_soc_unregister_card(card); > + > + return 0; > +} > + > +static const struct of_device_id rockchip_rk3036_of_match[] = { > + { .compatible = "r

Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings

2015-10-09 Thread Sjoerd Simons
Hey Rob, On Thu, 2015-10-08 at 11:50 -0500, Rob Herring wrote: > On Thu, Oct 8, 2015 at 8:31 AM, Sjoerd Simons > wrote: > > Add devicetree bindings for the spdif tranceiver found on > > found on rk3066, rk3188 and rk3288 SoCs > > > > Signed-off-by: Sjoerd Simons

Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent

2015-10-09 Thread Sjoerd Simons
Hey Heiko, On Thu, 2015-10-08 at 17:10 +0200, Heiko Stuebner wrote: > Am Donnerstag, 8. Oktober 2015, 15:31:16 schrieb Sjoerd Simons: > > The clock branches leading to sclk_spdif and sclk_spdif_8ch on > > RK3288 > > SoCs only feed those clocks, allow those clocks to cha

Re: [PATCHv3 1/2] ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-09 Thread Sjoerd Simons
On Thu, 2015-10-08 at 16:41 +0200, Arnd Bergmann wrote: > On Thursday 08 October 2015 11:27:13 Sjoerd Simons wrote: > > On Thu, 2015-10-08 at 10:37 +0200, Arnd Bergmann wrote: > > > On Thursday 08 October 2015 16:46:27 Krzysztof Kozlowski wrote: > > > > On 08.10.2

Re: [PATCHv3 1/2] ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-09 Thread Sjoerd Simons
On Thu, 2015-10-08 at 16:41 +0200, Arnd Bergmann wrote: > On Thursday 08 October 2015 11:27:13 Sjoerd Simons wrote: > > On Thu, 2015-10-08 at 10:37 +0200, Arnd Bergmann wrote: > > > On Thursday 08 October 2015 16:46:27 Krzysztof Kozlowski wrote: > > > > On 08.10.2

Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent

2015-10-09 Thread Sjoerd Simons
Hey Heiko, On Thu, 2015-10-08 at 17:10 +0200, Heiko Stuebner wrote: > Am Donnerstag, 8. Oktober 2015, 15:31:16 schrieb Sjoerd Simons: > > The clock branches leading to sclk_spdif and sclk_spdif_8ch on > > RK3288 > > SoCs only feed those clocks, allow those clocks to cha

Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings

2015-10-09 Thread Sjoerd Simons
Hey Rob, On Thu, 2015-10-08 at 11:50 -0500, Rob Herring wrote: > On Thu, Oct 8, 2015 at 8:31 AM, Sjoerd Simons > <sjoerd.sim...@collabora.co.uk> wrote: > > Add devicetree bindings for the spdif tranceiver found on > > found on rk3066, rk3188 and rk3288 SoCs > > &g

[PATCH v4 3/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3188

2015-10-08 Thread Sjoerd Simons
Add the SPDIF transceiver controller and pin for RK3188 Signed-off-by: Sjoerd Simons --- Changes in v4: - Adjust clock names to match the new names (hclk/mclk) Changes in v3: None Changes in v2: - Sort the spdif node properties - Drop the 0x prefix from the node name - Rename the spdif@ node

[PATCH v4 2/8] ASoC: rockchip: Add rockchip SPDIF transceiver driver

2015-10-08 Thread Sjoerd Simons
Add a driver for the SPDIF transceiver available on RK3066, RK3188 and RK3288. Heavily based on the rockchip i2s driver. Signed-off-by: Sjoerd Simons --- Changes in v4: - Use hclk and mclk as the clock names matching the update devicetree documentation - Drop something useless to_info

[PATCH v4 6/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3288

2015-10-08 Thread Sjoerd Simons
Add the SPDIF transceiver controller definition and pin setup for RK3288 SoCs Signed-off-by: Sjoerd Simons --- Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot

[PATCH v4 7/8] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock2 Square

2015-10-08 Thread Sjoerd Simons
Enable the SPDIF optical output on Radxa Rock2 square boards Signed-off-by: Sjoerd Simons --- Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-rock2-square.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/rk3288

[PATCH v4 0/8] Add SPDIF support for rockchip

2015-10-08 Thread Sjoerd Simons
able - use rk_spdif as a prefix consistenly throughout the driver - Check return code of regmap_update and bubble it up - Sort the spdif node properties - Drop the 0x prefix from the node name - Rename the spdif@ node to sound@ Sjoerd Simons (8): ASoC: dt-bindings: add rockchip tranceiver bindi

[PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings

2015-10-08 Thread Sjoerd Simons
Add devicetree bindings for the spdif tranceiver found on found on rk3066, rk3188 and rk3288 SoCs Signed-off-by: Sjoerd Simons --- Changes in v4: - Require rockchip,grf on RK3288 as the 8 channel solution has to be selected on that SoC - Make the compatibility string one of a known list

[PATCH v4 8/8] ARM: multi_v7_defconfig: Add rockchip audio support

2015-10-08 Thread Sjoerd Simons
Enable support for audio device found on rockchip boards. Signed-off-by: Sjoerd Simons --- Changes in v4: None Changes in v3: None Changes in v2: None arch/arm/configs/multi_v7_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm

[PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent

2015-10-08 Thread Sjoerd Simons
The clock branches leading to sclk_spdif and sclk_spdif_8ch on RK3288 SoCs only feed those clocks, allow those clocks to change their parents all the way up the hierarchy. Signed-off-by: Sjoerd Simons --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/clk/rockchip/clk

[PATCH v4 4/8] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock

2015-10-08 Thread Sjoerd Simons
This enables the SPDIF optical audio output on the Radxa Rock Signed-off-by: Sjoerd Simons --- Changes in v4: None Changes in v3: - Resent patches to a more complete list of maintainers. Changes in v2: None arch/arm/boot/dts/rk3188-radxarock.dts | 19 +++ 1 file changed, 19

Re: [PATCHv3 1/2] ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-08 Thread Sjoerd Simons
without further comments when I indicated in the cover letter that i used the NFS root use-case as one of the deciding factors for y vs. m). It would be really good to see someone put their foot down on the general policy (e.g. the arm-soc maintainers?), such that this discussion doesn't need to happen every time

Re: [PATCHv3 1/2] ARM: exynos_defconfig: Enable rtl8152 ethernet driver for Odroid-XU4

2015-10-08 Thread Sjoerd Simons
without further comments when I indicated in the cover letter that i used the NFS root use-case as one of the deciding factors for y vs. m). It would be really good to see someone put their foot down on the general policy (e.g. the arm-soc maintainers?), such that this discussion doesn't need to happen every time

  1   2   3   >