Re: [PATCH v3] pwm: core: Use octal permission

On Wed, 18 Nov 2020 at 23:29, Thierry Reding wrote: > > On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote: > > Permission bits are easier readable in octal than with using the > > symbolic names. > > > > Fixes the following warning generated by checkpat

Re: [PATCH] pwm: core: Use octal permission

On Wed, 18 Nov 2020 at 22:26, Uwe Kleine-König wrote: > > On Wed, Nov 18, 2020 at 02:46:54PM +, Lee Jones wrote: > > On Wed, 18 Nov 2020, Uwe Kleine-König wrote: > > > > > On Wed, Nov 18, 2020 at 07:36:28PM +0530, Soham Biswas wrote: > > > > On

Re: [PATCH v3] pwm: core: Use octal permission

On Wed, 18 Nov 2020 at 20:21, Soham Biswas wrote: > > Permission bits are easier readable in octal than with using the > symbolic names. > > Fixes the following warning generated by checkpatch: > > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are >

[PATCH v3] pwm: core: Use octal permission

;, S_IFREG | S_IRUGO, NULL, NULL, _debugfs_fops); Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/co

Re: [PATCH] pwm: core: Use octal permission

On Wed, 18 Nov 2020 at 19:29, Soham Biswas wrote: > > Permission bits are easier readable in octal than with using the symbolic > names. > > Fixes the following warning generated by checkpatch: > > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not &g

[PATCH] pwm: core: Use octal permission

;, S_IFREG | S_IRUGO, NULL, NULL, _debugfs_fops); Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/co

Re: [PATCH v2] pwm: core: Use octal permission

I don't know if/how this confuses tools like b4 and patchwork] > > Hello, > > On Wed, Nov 18, 2020 at 04:17:30PM +0530, Soham Biswas wrote: > > Fixes the following warning generated by checkpatch: > > > > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_I

[PATCH] pwm: core: Use octal permission

Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(p

Re: [PATCH] pwm: core: Use octal permission

Jones wrote: > > On Tue, 17 Nov 2020, Soham Biswas wrote: > > > Fixed Warning. > > Which warning does this fix? > > > Replaced symbolic permission 'S_IRUGO' with octal permission '0444'. > > This is semantically equivalent. > > Not sure what and/or how this

[PATCH] pwm: core: Use octal permission

Fixed Warning. Replaced symbolic permission 'S_IRUGO' with octal permission '0444'. Signed-off-by: Soham Biswas --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1f16f5365d3c..a8eff4b3ee36 100644