>
> You *definitely* want to do that - good catch.
>
> And TBH, all the screaming words aren't helping either... :)
>
:) I thought the same as well. But, I felt inconsistently screaming
words might be worse. Maybe just update all the words that are not
acronyms (such as Processor, Time, Socke
On 3/27/2024 1:54 PM, Avadhut Naik wrote:
> - TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx,
> ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN:
> %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
> + TP_printk("CPU: %d, MCGc/s: %llx/
;
> Signed-off-by: Avadhut Naik
> ---
A couple of nits below.
Apart from that the patch looks fine to me.
Reviewed-by: Sohil Mehta
> include/trace/events/mce.h | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mce.h
the tracepoint.
>
> Export PPIN through the tracepoint as it may provide useful information
> for debug and analysis.
>
> Signed-off-by: Avadhut Naik
> ---
The patch looks fine to me expect for a nit below.
With that fixed, please feel free to add:
Reviewed-by: Sohil Mehta
Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Co-Developed-by: Gayatri Kammela
Signed-off-by: Gayatri Kammela
Signed-off-by: Sohil Mehta
---
v7: Print the IR table physical base address
Simplify IR table formatting
v6: Change a couple of seq_puts to seq_putc
v5: Fix seq_puts formatting and remove
CCMD0x280x0800
FSTS0x340x
FECTL 0x380x
FEDATA 0x3c0xfee010044021
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Co-Developed-by: Sohil Mehta
Signed-off-by: Sohil
upport to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Add debugfs support for Interrupt remapping
drivers/iommu/Kconfig | 8 +
drivers/iommu/Makefile| 1 +
drivers/iommu/intel-iommu-debug.c | 338 ++
drivers/iommu/intel
From: Gayatri Kammela
To reuse the static functions and the struct declarations, move them to
corresponding header files and export the needed functions.
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v7: Split patch 1/5 and 2/5
Entries for domain 0:
[Entry] Contents
[0] 12c409801
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Co-Developed-by: Sohil Mehta
Signed-off-by: Sohil Mehta
Signed-off-by: Gayatri Kammela
---
v7: Improve code indentation and formatting
v6: No change
v5: No change
v4: Remove
: Fenghua Yu
Cc: Ashok Raj
Co-Developed-by: Sohil Mehta
Signed-off-by: Jacob Pan
Signed-off-by: Sohil Mehta
Signed-off-by: Gayatri Kammela
---
v7: Split patch 1/5 and 2/5 differently
Update commit message and copyright year
Fix typo in a comment
Simplify code
v6: Change the order of
d debugfs support to show register contents
iommu/vt-d: Add debugfs support to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Add debugfs support for Interrupt remapping
drivers/iommu/Kconfig | 10 ++
drivers/iommu/Makefile| 1 +
drivers/iommu/intel
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v6: No change
v5: No change
v4: No change
v3: No change
v2: No change
drivers/iommu
0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v6: No change
v5: No change
v4: Fix checkpatch.pl warnings
Remove error reporting for
entries for domain 0:
[Entry] Contents
[0] 12c409801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v6: No change
v5: No change
v4: Remove the unused function parameter
Fix checkpatch.pl warnings
v3: No change
v2: Fix
40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
v6: Change a couple of seq_puts to seq_putc
v5: Fix seq_puts formatting and remove
4467c9001 602
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v6
0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v5: No change
v4: Fix checkpatch.pl warnings
Remove error reporting for
pping is not enabled
Gayatri Kammela (4):
iommu/vt-d: Add debugfs support for Intel IOMMU internals
iommu/vt-d: Add debugfs support to show context internals
iommu/vt-d: Add debugfs support to show register contents
iommu/vt-d: Add debugfs support to show Pasid table contents
Sohil Mehta (1
4467c9001 602
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v5
entries for domain 0:
[Entry] Contents
[0] 12c409801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v5: No change
v4: Remove the unused function parameter
Fix checkpatch.pl warnings
v3: No change
v2: Fix seq_printf
40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
v5: Fix seq_puts formatting and remove leading '\n's
v4: Remove the unuse
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v5: No change
v4: No change
v3: No change
v2: No change
drivers/iommu/Kconfig | 10
Add a check to verify IOMMU 1GB page support. If the CPU supports 1GB
pages but the IOMMU does not support it then disable SVM by not
allocating PASID tables.
Signed-off-by: Sohil Mehta
---
drivers/iommu/intel-svm.c | 4
include/linux/intel-iommu.h | 1 +
2 files changed, 5 insertions
Add a check to verify IOMMU 5-level paging support. If the CPU supports
supports 5-level paging but the IOMMU does not support it then disable
SVM by not allocating PASID tables.
Signed-off-by: Sohil Mehta
---
drivers/iommu/intel-svm.c | 4
include/linux/intel-iommu.h | 1 +
2 files
If the CPU has support for 5-level paging enabled and the IOMMU also
supports 5-level paging then enable the 5-level paging mode for first-
level translations - used when SVM is enabled.
Signed-off-by: Sohil Mehta
---
drivers/iommu/intel-svm.c | 15 +--
1 file changed, 13 insertions
the actual supported address
width to the maximum support available in IOMMU hardware.
Signed-off-by: Sohil Mehta
---
drivers/iommu/intel-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 4a2de34..457795b
-directed-io-spec.pdf
Sohil Mehta (4):
iommu/vt-d: Enable upto 57 bits of domain address width
iommu/vt-d: Add a check for 1GB page support
iommu/vt-d: Add a check for 5-level paging support
iommu/vt-d: Enable 5-level paging mode in the PASID entry
drivers/iommu/intel-iommu.c | 2 +-
drivers
4467c9001 602
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v4
dd debugfs support to show context internals
iommu/vt-d: Add debugfs support to show register contents
iommu/vt-d: Add debugfs support to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Add debugfs support for Interrupt remapping
drivers/iommu/Kconfig | 10 ++
dri
entries for domain 0:
[Entry] Contents
[0] 12c409801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v4: Remove the unused function parameter
Fix checkpatch.pl warnings
v3: No change
v2: Fix seq_printf formatting
0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v4: Fix checkpatch.pl warnings
Remove error reporting for debugfs_create_file function
40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
v4: Remove the unused function parameter
Fix checkpatch.pl warnings
Remove
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v4: No change
v3: No change
v2: No change
drivers/iommu/Kconfig | 10
40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
v3: Use a macro for seq file operations
Change the intel_iommu_interrupt_remap
602
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v3: Add a macro
0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v3: Use a macro for seq file operations
Change the intel_iommu_regset file name to
w extended context internals
iommu/vt-d: Add debugfs extension to show register contents
iommu/vt-d: Add debugfs extension to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping
drivers/iommu/Kconfig | 10 +
drivers/iomm
entries:
Bus 0 L: 4016f4001 H: 0
Lower Context table entries for Bus: 0
[entry] DID :B :D .FLow High
[80]:00:0a.00 4016f3a05 102
Higher Context tbl entries for Bus: 0
[80]:00:0a.00 4015c 671b8000
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc
Pasid table entries for domain:
[Entry] Contents
[0] 26a609801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v3: No change
v2: Fix seq_printf formatting
drivers/iommu/intel-iommu-debug.c | 32
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v3: No change
v2: No change
drivers/iommu/Kconfig | 10 ++
drivers/iommu
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v2: No change
drivers/iommu/Kconfig | 10 ++
drivers/iommu/intel-iommu.c | 31
0 L: 4016f4001 H: 0
Lower Context table entries for Bus: 0
[entry] DID :B :D .FLow High
[80]:00:0a.00 4016f3a05 102
Higher Context tbl entries for Bus: 0
[80]:00:0a.00 4015c 671b8000
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok
0x34 0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v2: Fix seq_printf formatting
drivers/iommu/intel-iommu-debug.c | 96
MU debugfs to show extended context internals
iommu/vt-d: Add debugfs extension to show register contents
iommu/vt-d: Add debugfs extension to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping
drivers/iommu/Kconfig
0010 40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
v2: Handle the case when IR is not enabled. Fix seq_printf formatting
entries for domain:
[Entry] Contents
[0] 26a609801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
v2: Fix seq_printf formatting
drivers/iommu/intel-iommu-debug.c | 32
drivers/iommu
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
v2: No change
drivers
From: Gayatri Kammela
Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
drivers/iommu/Kconfig | 10 ++
drivers/iommu/intel-iommu.c | 31
entries for domain:
[Entry] Contents
[0] 26a609801
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
drivers/iommu/intel-iommu-debug.c | 33 +
drivers/iommu/intel-svm.c | 8
0 L: 4016f4001 H: 0
Lower Context table entries for Bus: 0
[entry] DID :B :D .FLow High
[80]:00:0a.00 4016f3a05 102
Higher Context tbl entries for Bus: 0
[80]:00:0a.00 4015c 671b8000
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok
0x34 0x
FECTL0x38 0x
FEDATA 0x3c 0xfee0100c4141
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Jacob Pan
Cc: Ashok Raj
Signed-off-by: Gayatri Kammela
---
drivers/iommu/intel-iommu-debug.c | 97 +++
1
Root tbl entries:
Bus 1 L: 3fc8c2001 H: 0
Context table entries for Bus: 1
[entry] DID :B :D .FLow High
[0] :01:00.00 3fc8c3001 402
Cc: Sohil Mehta
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Jacob Pan
Signed-off-by: Gayatri Kammela
---
drivers/iommu/Makefile
0010 40c7c880 41 00144300 40c7c88000418001
5 4300 0010 40c7c880 51 00144300 40c7c88000518001
Cc: Gayatri Kammela
Cc: Jacob Pan
Cc: Fenghua Yu
Cc: Ashok Raj
Signed-off-by: Sohil Mehta
---
drivers/iommu/intel-iommu-debug.c | 115
iommu/vt-d: Add debugfs extension to show Pasid table contents
Sohil Mehta (1):
iommu/vt-d: Debugfs support for Intel IOMMU Interrupt remapping
drivers/iommu/Kconfig | 10 +
drivers/iommu/Makefile| 1 +
drivers/iommu/intel-iommu-deb
54 matches
Mail list logo
