Re: [PATCH 1/1] hfsplus: fix longname handling

2014-02-25 Thread sougata santra
On 02/25/2014 09:37 AM, Vyacheslav Dubeyko wrote: Hi Sougata, On Mon, 2014-02-24 at 21:28 +0200, Sougata Santra wrote: -ENAMETOOLONG returned from hfsplus_asc2uni was not propaged to iops. This allowed hfsplus to create files/directories with HFSPLUS_MAX_STRLEN and incorrect keys, leaving the

[PATCH 1/1] hfsplus: fix longname handling

2014-02-24 Thread Sougata Santra
-ENAMETOOLONG returned from hfsplus_asc2uni was not propaged to iops. This allowed hfsplus to create files/directories with HFSPLUS_MAX_STRLEN and incorrect keys, leaving the FS in an inconsistent state. This patch fixes this issue. Signed-off-by: Sougata Santra Reviewed-by: Christoph Hellwig

[PATCH 0/1] hfsplus: fix longname handling

2014-02-24 Thread Sougata Santra
a 3 Feb 20 19:56 . drwxrwxrwx 1 rootroot6 Feb 20 19:56 .. -? ? ? ? ?? _123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_1234 [sougata@ultrabook TEST_DIR]$ cd $cdir [sougata@ultrabook tmp]$ rm -rf $dir rm: cannot remove ‘TEST_DIR’: Directory not empty Sougata Santra (1): hfsplus: fix longname handling fs/hfsplus/catalog.c| 89

Re: [PATCH] hfsplus: fix concurrent acess of alloc_blocks

2014-02-19 Thread sougata santra
On 02/19/2014 12:06 AM, Andrew Morton wrote: On Mon, 17 Feb 2014 14:20:47 +0200 Sougata Santra wrote: Concurrent access to alloc_blocks in hfsplus_inode_info is protected by extents_lock mutex. This patch fixes two instances where alloc_blocks modification was not protected with this lock

Re: [PATCH] hfsplus: fix concurrent acess of alloc_blocks

2014-02-19 Thread Sougata Santra
On Tue, 2014-02-18 at 14:06 -0800, Andrew Morton wrote: > On Mon, 17 Feb 2014 14:20:47 +0200 Sougata Santra wrote: > > > > > Concurrent access to alloc_blocks in hfsplus_inode_info is > > protected by extents_lock mutex. This patch fixes two > > instances where all

[PATCH] hfsplus: remove unused variable in hfsplus_get_block

2014-02-17 Thread Sougata Santra
The variable is defined but not used. Generally it compiles away with -O2 optimization hence it does not show a warning. Signed-off-by: Sougata Santra --- fs/hfsplus/extents.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c index fbb212f

[PATCH] hfsplus: fix concurrent acess of alloc_blocks

2014-02-17 Thread Sougata Santra
. Signed-off-by: Sougata Santra Reviewed-by: Christoph Hellwig --- fs/hfsplus/extents.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c index fbb212f..314c858 100644 --- a/fs/hfsplus/extents.c +++ b/fs/hfsplus/extents.c @@ -498,11

[PATCH] hfsplus: Remove hfsplus_file_lookup

2013-12-12 Thread Sougata Santra
From: Sougata Santra HFS+ resource fork lookup breaks opendir() library function. Since opendir first calls open() with O_DIRECTORY flag set. O_DIRECTORY means "refuse to open if not a directory". The open system call in the kernel does a check for inode->i_op->lookup and retu

[PATCH] hfsplus: Remove hfsplus_file_lookup

2013-12-11 Thread Sougata Santra
From: Sougata Santra HFS+ resource fork lookup breaks opendir() library function. Since opendir first calls open() with O_DIRECTORY flag set. O_DIRECTORY means "refuse to open if not a directory". The open system call in the kernel does a check for inode->i_op->lookup and returns