[PATCH v2 3/4] platform/x86: intel_telemetry: Improve S0ix logs

2017-11-23 Thread Souvik Kumar Chakravarty
more than one during suspend. Hence the field is superfluous and can be removed. This patch also slightly renames the S0ix total field for better viewability. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 45 -- 1 file changed

[PATCH v3 2/4] platform/x86: intel_telemetry: Fix suspend stats

2017-11-23 Thread Souvik Kumar Chakravarty
: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 25 + 1 file changed, 25 insertions(+) Changes since v2: * Use pmc_ipc_gcr_read64() API to read 64-bits at a time * Re-introduce the static qualifier to handle the case where the telemetry

[PATCH v1 1/4] platform/x86: intel_pmc_ipc: Add read64 API

2017-11-23 Thread Souvik Kumar Chakravarty
Add intel_pmc_gcr_read64() API for reading from 64-bit GCR registers. This API will be called from intel_telemetry. Update description of intel_pmc_gcr_read(). Signed-off-by: Souvik Kumar Chakravarty --- arch/x86/include/asm/intel_pmc_ipc.h | 6 ++ drivers/platform/x86/intel_pmc_ipc.c | 33

[PATCH v2 4/4] platform/x86: intel_telemetry: Remove redundancies

2017-11-23 Thread Souvik Kumar Chakravarty
This patch removes unnecessary header files and newlines. It also fixes some alignment issues. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) Changes since v1: * Consolidated

[PATCH v3 0/4] platform/x86: intel_telemetry: Fix logs and formatting

2017-11-23 Thread Souvik Kumar Chakravarty
qualifier to account for case of missing logs during suspend/resume Changes since v1: * Code-Review comments have been incorporated. Souvik Kumar Chakravarty (4): platform/x86: intel_pmc_ipc: Add read64 API platform/x86: intel_telemetry: Fix suspend stats platform/x86: intel_telemetry

[PATCH v2 0/4] platform/x86: intel_telemetry: Fix logs and formatting

2017-11-20 Thread Souvik Kumar Chakravarty
This patchset fixes https://bugzilla.kernel.org/show_bug.cgi?id=197833, and other issues related to telemetry counters. It also cleans up formatting and removes redundant code. It is rebased on top of the TESTING branch. Code-Review comments have been incorporated. Souvik Kumar Chakravarty (4

[PATCH v1 1/4] platform/x86: intel_pmc_ipc: Add readq API for GCR

2017-11-20 Thread Souvik Kumar Chakravarty
Add intel_pmc_gcr_readq API for reading from 64-bit GCR registers. This API will be called from intel_telemetry. Rename intel_pmc_gcr_read to more appropriate intel_pmc_gcr_readl. Signed-off-by: Souvik Kumar Chakravarty --- arch/x86/include/asm/intel_pmc_ipc.h | 10 -- drivers/platform

[PATCH v2 3/4] platform/x86: intel_telemetry: Improve S0ix logs

2017-11-20 Thread Souvik Kumar Chakravarty
more than one during suspend. Hence the field is superfluous and can be removed. This patch also slightly renames the S0ix total field for better viewability. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 45 -- 1 file changed

[PATCH v2 2/4] platform/x86: intel_telemetry: Fix suspend stats

2017-11-20 Thread Souvik Kumar Chakravarty
from local variables. Reported-and-tested-by: Rajneesh Bhardwaj Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 29 -- 1 file changed, 27 insertions(+), 2 deletions(-) Changes since v1: * Use pmc_ipc_gcr_readq API to read 64-bits

[PATCH v2 4/4] platform/x86: intel_telemetry: Remove redundancies

2017-11-20 Thread Souvik Kumar Chakravarty
This patch removes unnecessary header files and newlines. It also fixes some alignment issues. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) Changes since v1: * Consolidated

[PATCH v1 5/5] platform/x86: intel_telemetry: Improve S0ix logs

2017-11-16 Thread Souvik Kumar Chakravarty
more than one during suspend. Hence the field is superfluous and can be removed. This patch also slightly renames the S0ix total field for better viewability. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 47 +- 1 file changed

[PATCH v1 4/5] platform/x86: intel_telemetry: Remove redundancies

2017-11-16 Thread Souvik Kumar Chakravarty
This patch removes unnecessary header files and newlines. It also fixes some alignment issues. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86

[PATCH v1 0/5] platform/x86: intel_telemetry: Fix counters and formatting

2017-11-16 Thread Souvik Kumar Chakravarty
This patchset fixes https://bugzilla.kernel.org/show_bug.cgi?id=197833, and other issues related to telemetry counters. It also cleans up formatting and removes redundanant code. It is rebased on top of the TESTING branch. Souvik Kumar Chakravarty (5): platform/x86: intel_pmc_ipc: Fix register

[PATCH v1 1/5] platform/x86: intel_pmc_ipc: Fix register names

2017-11-16 Thread Souvik Kumar Chakravarty
: Souvik Kumar Chakravarty --- arch/x86/include/asm/intel_pmc_ipc.h | 10 ++ drivers/platform/x86/intel_pmc_ipc.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/intel_pmc_ipc.h b/arch/x86/include/asm/intel_pmc_ipc.h index fac89eb..b41f388

[PATCH v1 2/5] platform/x86: intel_telemetry: Fix suspend stats

2017-11-16 Thread Souvik Kumar Chakravarty
: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c index 4249e826..d0fce8c 100644 --- a/drivers

[PATCH v1 3/5] platform/x86: intel_telemetry: Fix local variables

2017-11-16 Thread Souvik Kumar Chakravarty
Remove unnecesary 'static' qualifier. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/pl

[PATCH] intel_telemetry_pltdrv: Change verbosity control bits

2016-02-16 Thread Souvik Kumar Chakravarty
Due to a recent fix in the firmware, the Punit verbosity control bits now adhere to the correct pattern. Hence remove the workaround and do a read-mofiy-write of the register. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86/intel_telemetry_pltdrv.c | 13 - 1 file

[PATCH] MAINTAINERS: Combine multiple telemetry entries

2016-01-20 Thread Souvik Kumar Chakravarty
This patch combines all the telemetry file entries in MAINTAINERS via wildcard. Signed-off-by: Souvik Kumar Chakravarty --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cb872cb..02a330c 100644 --- a/MAINTAINERS +++ b

[PATCH v3 5/5] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

2016-01-07 Thread Souvik Kumar Chakravarty
Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. It depends on PUNIT and PMC IPC drivers. Signed-off-by: Souvik Kumar Chakravarty --- MAINTAINERS |9 + drivers/platform/x86/Kconfig | 11 +++ drivers/platform/x86/Makefile |3 ++

[PATCH v5 2/5] platform:x86: Add Intel telemetry platform driver

2016-01-07 Thread Souvik Kumar Chakravarty
Telemetry platform driver implements the telemetry interfaces. Currently it supports ApolloLake. It uses the PUNIT and PMC IPC interfaces to configure the telemetry samples to read. The samples are read from a Secure SRAM region. Signed-off-by: Souvik Kumar Chakravarty --- drivers/platform/x86