> If the pin descriptor requested for the physical pin fails then the
> descriptor is dereferenced without checking for its validity which
> may lead to crash, hence added preventive code to check for NULL
> and accordingly dereference.
> Signed-off-by: Srikanth K H
> ---
> drivers/pinctrl/pinco
> It is fine to crash because /proc is not modular.
Dear Alexey, this was theoretical solution. If you feel this should crash
instead if the call fail's then ignore the patch.
Regards,
Srikanth
> Thanks for the patch! Do you have a reproducer or is this theoretical?
> This will affect if it should go to stable or not.
Dear Luis, this is theoretical as I observed in most of the call's to api -
"proc_mkdir" the NULL check is being done. Hence I thought of adding one here.
Regards,
Srikan
> The checks in proc are moot if we guarantee the non-NULL card at
> snd_timer_new() in the above.
> So it's not about fixing in sound module. It serves right. Your
> patch would add a sanity check to catch a buggy code in the caller
> side.
You are right Takashi, as you said this changes w
>>
>> Signed-off-by: Srikanth K H
>What does this fix, and above all, why is this needed?
Hi,
When the sound driver creates the timer without sound card object, then while
reading the sound info entry the timer object’s card information is
dereferenced without checking for NULL pointer wh
5 matches
Mail list logo
