[PATCH v3 08/13]] staging: lustre: fix multi line strings

Fixes the following checkpatch warning: WARNING: quoted string split across lines Signed-off-by: Srikrishan Malik --- Changes in v3: Removed leading space from debug message. drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++ drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3

Re: [PATCH v2 08/13] staging: lustre: fix multi line strings

On Tue, Aug 12, 2014 at 02:17:07AM +, Drokin, Oleg wrote: > > On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote: > > > Fixes the following checkpatch warning: > > > > WARNING: quoted string split across lines > > > diff --git a/drivers/staging/lu

[PATCH v2 07/13] staging: lustre: add blank lines after declarations

Fixes the following checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 + drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++ drivers/staging/lustre/lustre/mdc/mdc_request.c | 5

[PATCH v2 01/13] staging: lustre: remove space between function name and and open parenthesis

Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4 ++-- drivers/staging/lus

[PATCH v2 02/13] staging: lustre: remove spaces from start of line

Fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b

[PATCH v2 09/13] staging: lustre: Added space between type name and *

Fixes the following checkpatch error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.

[PATCH v2 11/13] staging: lustre: move else on the same line as closing brace

Fix the following checkpatch error: ERROR: else should follow close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c

[PATCH v2 13/13] staging: lustre: Cleanup variable declarations in mdc_enqueue()

Changes: - move const union vars to the top - move rc to bottom - do not initialize req - set lvb_type to enum member instead of 0 - change __u64 to u64 - fix inconsistant columnization Signed-off-by: Srikrishan Malik --- These changes were suggested by Dan Carpenter . drivers/staging/lustre

[PATCH v2 12/13] staging: lustre: remove parentheses usage with return

Fix the following checkpatch error: ERROR: return is not a function, parentheses are not required Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc

[PATCH v2 10/13] staging: lustre: Fix misplaced opening brace warnings

Fixes the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 18 +++--- drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc

[PATCH v2 08/13] staging: lustre: fix multi line strings

Fixes the following checkpatch warning: WARNING: quoted string split across lines Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++ drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc/mdc_request.c | 36

[PATCH v2 03/13] staging: lustre: move open brace to next line after functions

Fixes the following checkpatch error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++- 2 files changed, 4

[PATCH v2 06/13] staging: lustre: replace c99 style comments with C89

Fixes the following checkpatch error: ERROR: do not use C99 // comments Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c b/drivers/staging

[PATCH v2 04/13] staging: lustre: fix lines over 80 chars

Fixes the following checkpatch warning: WARNING: line over 80 characters Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 -- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++--- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 7

[PATCH v2 05/13] staging: lustre: Add missing spaces around operators and braces.

Fixes the following checkpatch errors: ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 + drivers/stagi

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote: > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote: > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote: > > > On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > > > &g

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

On Sat, Aug 09, 2014 at 09:32:22PM -0700, Greg KH wrote: > On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: > > Fixes following checkpatch warning: > > > > WARNING: space prohibited between function name and open parenthesis '(' > > > >

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote: > On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote: > > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > > b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > > index c03d77c9c5b8

[PATCH 06/12] staging: lustre: replace c99 style comments with C89

Fixes the following checkpatch error: ERROR: do not use C99 // comments Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c b/drivers/staging

[PATCH 07/12] staging: lustre: add blank lines after declarations

Fixes the following checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 + drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++ drivers/staging/lustre/lustre/mdc/mdc_request.c | 5

[PATCH 12/12] staging: lustre: remove parentheses usage with return

Fix the following checkpatch error: ERROR: return is not a function, parentheses are not required Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc

[PATCH 11/12] staging: lustre: move else on the same line as closing brace

Fix the following checkpatch error: ERROR: else should follow close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c

[PATCH 04/12] staging: lustre: fix lines over 80 chars

Fixes the following checkpatch warning: WARNING: line over 80 characters Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 -- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++--- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 7

[PATCH 08/12] staging: lustre: fix multi line strings

Fixes the following checkpatch warning: WARNING: quoted string split across lines Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++ drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc/mdc_request.c | 36

[PATCH 03/12] staging: lustre: move open brace to next line after functions

Fixes the following checkpatch error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++- 2 files changed, 4

[PATCH 09/12] staging: lustre: Added space between type name and *

Fixes the following checkpatch error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.

[PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

Fixes the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 12 ++-- drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc

[PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

Fixes the following checkpatch errors: ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 + drivers/stagi

[PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4 ++-- drivers/staging/lus

[PATCH 02/12] staging: lustre: remove spaces from start of line

Fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b