On 22/07/20, 8:49 PM, "Jakub Kicinski" wrote:
> Please run checkpatch on your submissions:
> WARNING: Missing a blank line after declarations
> #76: FILE: drivers/net/hyperv/netvsc_drv.c:614:
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);
> ERROR: code
& the VLAN is stripped from the
frame.
4. TX VLAN is re-inserted by HOST OS based on the NDIS header. If it sees
a VLAN in the frame the packet is dropped.
Cc: xe-linux-exter...@cisco.com
Cc: Sriram Krishnan
Signed-off-by: Sriram Krishnan
---
drivers/net/hyperv/hyperv_net.h | 1 +
dri
On 21/07/20, 9:36 PM,
Stephen Hemminger wrote:
> Printing error messages is good for debugging but bad IRL.
> Users ignore it, or it overflows the log buffer.
> A better alternative would be to add a counter to netvsc_ethtool_stats.
Thanks, the recommended change can be
On 22/07/20, 3:48 AM, "Haiyang Zhang" wrote:
> If you make this change, did you see any drop in a live test? The
> "packet->total_bytes" in struct hv_netvsc_packet is for book keeping
> only, which is used for stats info, and not visible by the host at all.
> I made this
& the VLAN is is stripped from the
frame.
4. TX VLAN is re-inserted by HOST OS based on the NDIS header. If it sees
a VLAN in the frame the packet is dropped.
Cc: xe-linux-exter...@cisco.com
Cc: Sriram Krishnan
Signed-off-by: Sriram Krishnan
---
drivers/net/hyperv/hyperv_net.h
& the VLAN is is stripped from the
frame.
4. TX VLAN is re-inserted by HOST OS based on the NDIS header. If it sees
a VLAN in the frame the packet is dropped.
Cc: xe-linux-exter...@cisco.com
Cc: Sriram Krishnan
Signed-off-by: Sriram Krishnan
---
drivers/net/hyperv/netvsc_drv.c
On 21/07/20, 4:57 AM, "David Miller" wrote:
From: Sriram Krishnan
Date: Mon, 20 Jul 2020 22:15:51 +0530
> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);
> Please place an
l 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2)
wrote:
>
> +Stephen Hemminger
>
> Hi Willem,
> Thanks for looking into the code, I understand that this is more of a
generic problem wherein many of the filtering functions assume the vlan tag to
be in the skb
& the VLAN is is stripped from the
frame.
4. TX VLAN is re-inserted by HOST OS based on the NDIS header. If it sees
a VLAN in the frame the packet is dropped.
Cc: xe-linux-exter...@cisco.com
Cc: Sriram Krishnan
Signed-off-by: Sriram Krishnan
---
drivers/net/hyperv/netvsc_drv.c
in the offload info.
Cc: xe-linux-exter...@cisco.com
Cc: Sriram Krishnan
Signed-off-by: Sriram Krishnan
---
net/packet/af_packet.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 29bd405adbbd
When an application sends with AF_PACKET and places a vlan header on
the raw packet; then the AF_PACKET needs to move the tag into the skb
so that it gets processed normally through the rest of the transmit
path.
This is particularly a problem on Hyper-V where the host only allows
vlan in the
11 matches
Mail list logo
