Re: [PATCH 00/10] ipc MSG_COPY fixes

2013-02-28 Thread Stanislav Kinsbursky
26.02.2013 16:00, Peter Hurley пишет: On Tue, 2013-02-26 at 11:53 +0400, Stanislav Kinsbursky wrote: Looks good to me. Thanks you, Peter! Acked-by: Stanislav Kinsbursky Next time please, add maintainer to "To" list instead of "CC" list (no need to resend - I've

[PATCH] nfsd: check client tracker initialization result

2013-02-28 Thread Stanislav Kinsbursky
Function nfsd4_client_tracking_init() can return error. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfs4state.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index f194f86..fc4b81b 100644 --- a/fs/nfsd/nfs4state.c

[PATCH] nfsd: check client tracker initialization result

2013-02-28 Thread Stanislav Kinsbursky
Function nfsd4_client_tracking_init() can return error. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfs4state.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index f194f86..fc4b81b 100644

Re: [PATCH 00/10] ipc MSG_COPY fixes

2013-02-28 Thread Stanislav Kinsbursky
26.02.2013 16:00, Peter Hurley пишет: On Tue, 2013-02-26 at 11:53 +0400, Stanislav Kinsbursky wrote: Looks good to me. Thanks you, Peter! Acked-by: Stanislav Kinsbursky skinsbur...@parallels.com Next time please, add maintainer to To list instead of CC list (no need to resend - I've added

Re: [PATCH 00/10] ipc MSG_COPY fixes

2013-02-25 Thread Stanislav Kinsbursky
Looks good to me. Thanks you, Peter! Acked-by: Stanislav Kinsbursky Next time please, add maintainer to "To" list instead of "CC" list (no need to resend - I've added Andrew Morton to "To" list in this reply). 26.02.2013 06:21, Peter Hurley пишет: Over th

Re: [PATCH 00/10] ipc MSG_COPY fixes

2013-02-25 Thread Stanislav Kinsbursky
Looks good to me. Thanks you, Peter! Acked-by: Stanislav Kinsbursky skinsbur...@parallels.com Next time please, add maintainer to To list instead of CC list (no need to resend - I've added Andrew Morton to To list in this reply). 26.02.2013 06:21, Peter Hurley пишет: Over the weekend testing

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
20.02.2013 22:24, Dave Jones пишет: On Wed, Feb 20, 2013 at 12:23:22PM +0400, Stanislav Kinsbursky wrote: > > Pid: 887, comm: trinity-child2 Not tainted 3.8.0+ #57 Gigabyte Technology Co., Ltd. GA-MA78GM-S2H/GA-MA78GM-S2H > > RIP: 0010:[] [] do_msgrcv+0x22a/0x670 > &g

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
20.02.2013 14:03, Gleb Natapov пишет: On Wed, Feb 20, 2013 at 12:23:22PM +0400, Stanislav Kinsbursky wrote: 19.02.2013 22:04, Dave Jones пишет: general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC Modules linked in: can af_rxrpc binfmt_misc scsi_transport_iscsi ax25 ipt_ULOG decnet

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
ix affects only the case, when MSG_COPY flag is set. And this is not your case, I suppose? Dave -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
to reproduce? Do you use KVM? There is a NULL selinux handler bug fix by Stephen Smalley here: https://lkml.org/lkml/2013/2/6/663 But anyway, this bug fix affects only the case, when MSG_COPY flag is set. And this is not your case, I suppose? Dave -- Best regards, Stanislav

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
20.02.2013 14:03, Gleb Natapov пишет: On Wed, Feb 20, 2013 at 12:23:22PM +0400, Stanislav Kinsbursky wrote: 19.02.2013 22:04, Dave Jones пишет: general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC Modules linked in: can af_rxrpc binfmt_misc scsi_transport_iscsi ax25 ipt_ULOG decnet

Re: general protection fault in do_msgrcv [3.8]

2013-02-20 Thread Stanislav Kinsbursky
20.02.2013 22:24, Dave Jones пишет: On Wed, Feb 20, 2013 at 12:23:22PM +0400, Stanislav Kinsbursky wrote: Pid: 887, comm: trinity-child2 Not tainted 3.8.0+ #57 Gigabyte Technology Co., Ltd. GA-MA78GM-S2H/GA-MA78GM-S2H RIP: 0010:[812aebba] [812aebba] do_msgrcv+0x22a

Re: [PATCH v2 0/4] nfsd: make is works in a container

2013-02-17 Thread Stanislav Kinsbursky
15.02.2013 20:20, J. Bruce Fields пишет: On Fri, Feb 01, 2013 at 03:56:05PM +0300, Stanislav Kinsbursky wrote: This patch set finally enables NFSd in container. I've tested it in container with it's own root, and also pid, net and mount namespaces. Thanks, these look fine to me; applying

Re: [PATCH v2 0/4] nfsd: make is works in a container

2013-02-17 Thread Stanislav Kinsbursky
15.02.2013 20:20, J. Bruce Fields пишет: On Fri, Feb 01, 2013 at 03:56:05PM +0300, Stanislav Kinsbursky wrote: This patch set finally enables NFSd in container. I've tested it in container with it's own root, and also pid, net and mount namespaces. Thanks, these look fine to me; applying

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-13 Thread Stanislav Kinsbursky
if (net->user_ns != current_user_ns()) + return -EINVAL; No? Eric -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH review 52/85] sunrpc: Properly encode kuids and kgids in auth.unix.gid rpc pipe upcalls.

2013-02-13 Thread Stanislav Kinsbursky
!= current_user_ns()) + return -EINVAL; No? Eric -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-12 Thread Stanislav Kinsbursky
hanks for the notice. ps -Original Message- From: linux-nfs-ow...@vger.kernel.org [mailto:linux-nfs-ow...@vger.kernel.org] On Behalf Of J. Bruce Fields Sent: Tuesday, February 12, 2013 3:46 PM To: Stanislav Kinsbursky Cc: a...@linux-foundation.org; linux-...@vger.kernel.org; trond.

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-12 Thread Stanislav Kinsbursky
svc_clean_up_xprts(serv, net); > + msleep(delay++); > + } ? Anyway, thanks! Acked-by: Stanislav Kinsbursky -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-12 Thread Stanislav Kinsbursky
)) { + svc_clean_up_xprts(serv, net); + msleep(delay++); + } ? Anyway, thanks! Acked-by: Stanislav Kinsbursky skinsbur...@parallels.com -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-12 Thread Stanislav Kinsbursky
. ps -Original Message- From: linux-nfs-ow...@vger.kernel.org [mailto:linux-nfs-ow...@vger.kernel.org] On Behalf Of J. Bruce Fields Sent: Tuesday, February 12, 2013 3:46 PM To: Stanislav Kinsbursky Cc: a...@linux-foundation.org; linux-...@vger.kernel.org; trond.mykleb...@netapp.com; linux

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-11 Thread Stanislav Kinsbursky
11.02.2013 20:37, J. Bruce Fields пишет: On Mon, Feb 11, 2013 at 10:18:18AM +0400, Stanislav Kinsbursky wrote: This one looks a bit complicated and confusing to me. Probably because I'm not that familiar with service transports processing logic. So, as I can see, we now try to run over all per

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-11 Thread Stanislav Kinsbursky
11.02.2013 20:37, J. Bruce Fields пишет: On Mon, Feb 11, 2013 at 10:18:18AM +0400, Stanislav Kinsbursky wrote: This one looks a bit complicated and confusing to me. Probably because I'm not that familiar with service transports processing logic. So, as I can see, we now try to run over all per

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-10 Thread Stanislav Kinsbursky
11.02.2013 04:25, J. Bruce Fields пишет: On Fri, Feb 01, 2013 at 02:28:21PM +0300, Stanislav Kinsbursky wrote: After "NFS" (SUNRPC + NFSd actually) containerization work some basic principles of SUNRPC service initialization and deinitialization has been changed: now one service can

Re: [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-10 Thread Stanislav Kinsbursky
11.02.2013 04:25, J. Bruce Fields пишет: On Fri, Feb 01, 2013 at 02:28:21PM +0300, Stanislav Kinsbursky wrote: After NFS (SUNRPC + NFSd actually) containerization work some basic principles of SUNRPC service initialization and deinitialization has been changed: now one service can be shared

Re: linux-next: build failure after merge of the nfsd tree

2013-02-07 Thread Stanislav Kinsbursky
you wish. But it's up to you, what to commit, Bruce. -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: selinux_msg_queue_msgrcv() oops

2013-02-07 Thread Stanislav Kinsbursky
problem appear, is you disable CONFIG_CHECKPOINT_RESTORE config option? -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: linux-next: build failure after merge of the nfsd tree

2013-02-07 Thread Stanislav Kinsbursky
, what to commit, Bruce. -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: selinux_msg_queue_msgrcv() oops

2013-02-07 Thread Stanislav Kinsbursky
disable CONFIG_CHECKPOINT_RESTORE config option? -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 2/4] SUNRPC: remove cache_detail->cache_upcall callback

2013-02-04 Thread Stanislav Kinsbursky
04.02.2013 20:50, Jeff Layton пишет: On Tue, 15 Jan 2013 11:09:36 +0300 Stanislav Kinsbursky wrote: This callback is redundant since all that its' implementations are doing is calling sunrpc_cache_pipe_upcall() with proper function address argument. This function address is now stored

Re: [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread Stanislav Kinsbursky
04.02.2013 18:17, J. Bruce Fields пишет: On Mon, Feb 04, 2013 at 02:02:29PM +0300, Stanislav Kinsbursky wrote: swapping The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry

[PATCH v2 1/6] NFS: use SUNRPC cache creation and destruction helper for DNS cache

2013-02-04 Thread Stanislav Kinsbursky
This cache was the first containerized and doesn't use net-aware cache creation and destruction helpers. This is a cleanup patch which just makes code looks clearer and reduce amount of lines of code. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/dns_resolve.c | 60

[PATCH v2 6/6] SUNRPC: move cache_detail->cache_request callback call to cache_read()

2013-02-04 Thread Stanislav Kinsbursky
() (which is cache_request callback) calls d_path(), which, in turn, traverse dentry up to current->fs->root. Kernel threads always have global root, while container have be in "root jail" - i.e. have it's own nested root. Signed-off-by: Stanislav Kinsbursky --- net/sunrp

[PATCH v2 5/6] SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function

2013-02-04 Thread Stanislav Kinsbursky
Passing this pointer is redundant since it's stored on cache_detail structure, which is also passed to sunrpc_cache_pipe_upcall () function. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/dns_resolve.c |2 +- include/linux/sunrpc/cache.h |6 +- net/sunrpc/cache.c

[PATCH v2 4/6] SUNRPC: rework cache upcall logic

2013-02-04 Thread Stanislav Kinsbursky
all the code can be simplified. Now, for those cache details, which doesn't have cache_upcall callback (the only one, which still has is nfs_dns_resolve_template) sunrpc_cache_pipe_upcall will be called instead. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/export.c |

[PATCH v2 2/6] NFS; simlify and clean cache library

2013-02-04 Thread Stanislav Kinsbursky
to nfs_cache_register_net() and nfs_cache_unregister_net() respectively (since they are called together anyway). Signed-off-by: Stanislav Kinsbursky --- fs/nfs/cache_lib.c | 12 +++- fs/nfs/cache_lib.h |2 -- fs/nfs/dns_resolve.c |6 +- 3 files changed, 4 insertions(+), 16 deletions(-) diff

[PATCH v2 3/6] SUNRPC: introduce cache_detail->cache_request callback

2013-02-04 Thread Stanislav Kinsbursky
This callback will allow to simplify upcalls in further patches in this series. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/dns_resolve.c |3 ++- fs/nfsd/export.c |6 -- fs/nfsd/nfs4idmap.c |6 -- include/linux/sunrpc/cache.h

[PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread Stanislav Kinsbursky
e, because it's still required for NFS DNS cache. The following series implements... --- Stanislav Kinsbursky (6): NFS: use SUNRPC cache creation and destruction helper for DNS cache NFS; simlify and clean cache library SUNRPC: introduce cache_detail->cache_request callback

Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-02-04 Thread Stanislav Kinsbursky
: On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after calling d_path() in kthread root context

Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-02-04 Thread Stanislav Kinsbursky
: On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after calling d_path() in kthread root context

[PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread Stanislav Kinsbursky
still required for NFS DNS cache. The following series implements... --- Stanislav Kinsbursky (6): NFS: use SUNRPC cache creation and destruction helper for DNS cache NFS; simlify and clean cache library SUNRPC: introduce cache_detail-cache_request callback SUNRPC: rework

[PATCH v2 2/6] NFS; simlify and clean cache library

2013-02-04 Thread Stanislav Kinsbursky
to nfs_cache_register_net() and nfs_cache_unregister_net() respectively (since they are called together anyway). Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/cache_lib.c | 12 +++- fs/nfs/cache_lib.h |2 -- fs/nfs/dns_resolve.c |6 +- 3 files changed, 4 insertions

[PATCH v2 3/6] SUNRPC: introduce cache_detail-cache_request callback

2013-02-04 Thread Stanislav Kinsbursky
This callback will allow to simplify upcalls in further patches in this series. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/dns_resolve.c |3 ++- fs/nfsd/export.c |6 -- fs/nfsd/nfs4idmap.c |6

[PATCH v2 5/6] SUNRPC: remove cache_request argument in sunrpc_cache_pipe_upcall() function

2013-02-04 Thread Stanislav Kinsbursky
Passing this pointer is redundant since it's stored on cache_detail structure, which is also passed to sunrpc_cache_pipe_upcall () function. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/dns_resolve.c |2 +- include/linux/sunrpc/cache.h |6 +- net

[PATCH v2 4/6] SUNRPC: rework cache upcall logic

2013-02-04 Thread Stanislav Kinsbursky
the code can be simplified. Now, for those cache details, which doesn't have cache_upcall callback (the only one, which still has is nfs_dns_resolve_template) sunrpc_cache_pipe_upcall will be called instead. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/export.c

[PATCH v2 6/6] SUNRPC: move cache_detail-cache_request callback call to cache_read()

2013-02-04 Thread Stanislav Kinsbursky
() (which is cache_request callback) calls d_path(), which, in turn, traverse dentry up to current-fs-root. Kernel threads always have global root, while container have be in root jail - i.e. have it's own nested root. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- net/sunrpc

[PATCH v2 1/6] NFS: use SUNRPC cache creation and destruction helper for DNS cache

2013-02-04 Thread Stanislav Kinsbursky
This cache was the first containerized and doesn't use net-aware cache creation and destruction helpers. This is a cleanup patch which just makes code looks clearer and reduce amount of lines of code. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/dns_resolve.c | 60

Re: [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread Stanislav Kinsbursky
04.02.2013 18:17, J. Bruce Fields пишет: On Mon, Feb 04, 2013 at 02:02:29PM +0300, Stanislav Kinsbursky wrote: swapping The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry

Re: [PATCH 2/4] SUNRPC: remove cache_detail-cache_upcall callback

2013-02-04 Thread Stanislav Kinsbursky
04.02.2013 20:50, Jeff Layton пишет: On Tue, 15 Jan 2013 11:09:36 +0300 Stanislav Kinsbursky skinsbur...@parallels.com wrote: This callback is redundant since all that its' implementations are doing is calling sunrpc_cache_pipe_upcall() with proper function address argument. This function

[PATCH 4/4] nfsd: enable NFSv4 state in containers

2013-02-01 Thread Stanislav Kinsbursky
Currently, NFSd is ready to operate in network namespace based containers. So let's drop check for "init_net" and make it able to fly. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfs4state.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git

[PATCH 3/4] nfsd: disable usermode helper client tracker in container

2013-02-01 Thread Stanislav Kinsbursky
per, which will swap root to desired one. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfs4recover.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index ba6fdd4..e0ae1cf 100644 --- a/fs/nfsd/nfs4recover.c +++

[PATCH v2 0/4] nfsd: make is works in a container

2013-02-01 Thread Stanislav Kinsbursky
implements... --- Stanislav Kinsbursky (4): nfsd: containerize NFSd filesystem nfsd: use proper net while reading "exports" file nfsd: disable usermode helper client tracker in container nfsd: enable NFSv4 state in containers fs/nfsd/nfs4recover.c |6 fs/nfsd/

[PATCH 2/4] nfsd: use proper net while reading "exports" file

2013-02-01 Thread Stanislav Kinsbursky
only current->nsproxy->net_ns can be used. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfsctl.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 2eb03c1..1825f72 100644 --- a/fs/nfsd/nfsc

[PATCH 1/4] nfsd: containerize NFSd filesystem

2013-02-01 Thread Stanislav Kinsbursky
underneath of it. This, obviously, means, that in case of kill of a container's "init" (which is not a mount namespace, but network namespace creator) netowrk namespace won't be destroyed. Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfsctl.c | 46 ++

[PATCH 2/2] SUNRPC: protect transport processing with per-cpu rw semaphore

2013-02-01 Thread Stanislav Kinsbursky
ite. Note: add the PERCPU_RWSEM config option selected by SUNRPC. Signed-off-by: Stanislav Kinsbursky --- include/linux/sunrpc/svc.h |2 ++ net/sunrpc/Kconfig |1 + net/sunrpc/svc.c |2 ++ net/sunrpc/svc_xprt.c | 33 +++-- 4 fi

[PATCH 1/2] per-cpu semaphores: export symbols to modules

2013-02-01 Thread Stanislav Kinsbursky
o obj-y so that modules may use this library. Signed-off-by: Stanislav Kinsbursky --- lib/Makefile |2 +- lib/percpu-rwsem.c |6 ++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index 02ed6c0..22e0c03 100644 --- a/lib/Makefile +++ b/li

[PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-01 Thread Stanislav Kinsbursky
the running service. This leads to races, described here: https://bugzilla.redhat.com/show_bug.cgi?id=904870 and which this small patch set is aimed to solve by using per-cpu rw semphores to sync per-net resources processing and shutdown. The following series implements... --- Stanislav Kinsb

[PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-01 Thread Stanislav Kinsbursky
. This leads to races, described here: https://bugzilla.redhat.com/show_bug.cgi?id=904870 and which this small patch set is aimed to solve by using per-cpu rw semphores to sync per-net resources processing and shutdown. The following series implements... --- Stanislav Kinsbursky (2): per-cpu

[PATCH 1/2] per-cpu semaphores: export symbols to modules

2013-02-01 Thread Stanislav Kinsbursky
that modules may use this library. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- lib/Makefile |2 +- lib/percpu-rwsem.c |6 ++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index 02ed6c0..22e0c03 100644 --- a/lib/Makefile

[PATCH 2/2] SUNRPC: protect transport processing with per-cpu rw semaphore

2013-02-01 Thread Stanislav Kinsbursky
. Note: add the PERCPU_RWSEM config option selected by SUNRPC. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- include/linux/sunrpc/svc.h |2 ++ net/sunrpc/Kconfig |1 + net/sunrpc/svc.c |2 ++ net/sunrpc/svc_xprt.c | 33

[PATCH 1/4] nfsd: containerize NFSd filesystem

2013-02-01 Thread Stanislav Kinsbursky
of it. This, obviously, means, that in case of kill of a container's init (which is not a mount namespace, but network namespace creator) netowrk namespace won't be destroyed. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfsctl.c | 46

[PATCH v2 0/4] nfsd: make is works in a container

2013-02-01 Thread Stanislav Kinsbursky
... --- Stanislav Kinsbursky (4): nfsd: containerize NFSd filesystem nfsd: use proper net while reading exports file nfsd: disable usermode helper client tracker in container nfsd: enable NFSv4 state in containers fs/nfsd/nfs4recover.c |6 fs/nfsd/nfs4state.c | 10

[PATCH 2/4] nfsd: use proper net while reading exports file

2013-02-01 Thread Stanislav Kinsbursky
-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfsctl.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 2eb03c1..1825f72 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -125,11 +125,11

[PATCH 3/4] nfsd: disable usermode helper client tracker in container

2013-02-01 Thread Stanislav Kinsbursky
will swap root to desired one. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfs4recover.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index ba6fdd4..e0ae1cf 100644 --- a/fs/nfsd/nfs4recover.c

[PATCH 4/4] nfsd: enable NFSv4 state in containers

2013-02-01 Thread Stanislav Kinsbursky
Currently, NFSd is ready to operate in network namespace based containers. So let's drop check for init_net and make it able to fly. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfs4state.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff

Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-30 Thread Stanislav Kinsbursky
31.01.2013 03:00, J. Bruce Fields пишет: On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after

Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-30 Thread Stanislav Kinsbursky
31.01.2013 03:00, J. Bruce Fields пишет: On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after

Re: [RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-29 Thread Stanislav Kinsbursky
30.01.2013 02:57, J. Bruce Fields пишет: On Tue, Jan 29, 2013 at 02:03:30PM +0300, Stanislav Kinsbursky wrote: There could be a service transport, which is processed by service thread and racing in the same time with per-net service shutdown like listed below: CPU#0

[RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-29 Thread Stanislav Kinsbursky
ken for write. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/callback.c |2 ++ include/linux/sunrpc/svc.h |2 ++ net/sunrpc/svc.c |2 ++ net/sunrpc/svc_xprt.c | 24 ++-- 4 files changed, 24 insertions(+), 6 deletions(-) diff --git a/fs/

[RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-29 Thread Stanislav Kinsbursky
for write. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/callback.c |2 ++ include/linux/sunrpc/svc.h |2 ++ net/sunrpc/svc.c |2 ++ net/sunrpc/svc_xprt.c | 24 ++-- 4 files changed, 24 insertions(+), 6 deletions

Re: [RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-29 Thread Stanislav Kinsbursky
30.01.2013 02:57, J. Bruce Fields пишет: On Tue, Jan 29, 2013 at 02:03:30PM +0300, Stanislav Kinsbursky wrote: There could be a service transport, which is processed by service thread and racing in the same time with per-net service shutdown like listed below: CPU#0

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-21 Thread Stanislav Kinsbursky
18.01.2013 19:56, J. Bruce Fields пишет: On Fri, Jan 18, 2013 at 10:48:02AM -0500, Mark Lord wrote: On 13-01-18 12:37 AM, Stanislav Kinsbursky wrote: You have more than one NFS mount in different network namespaces, haven't you? No, I don't (knowingly) use (multiple) namespaces at all

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-21 Thread Stanislav Kinsbursky
18.01.2013 19:56, J. Bruce Fields пишет: On Fri, Jan 18, 2013 at 10:48:02AM -0500, Mark Lord wrote: On 13-01-18 12:37 AM, Stanislav Kinsbursky wrote: You have more than one NFS mount in different network namespaces, haven't you? No, I don't (knowingly) use (multiple) namespaces at all

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread Stanislav Kinsbursky
18.01.2013 03:41, Mark Lord пишет: On 13-01-17 08:24 AM, Stanislav Kinsbursky wrote: .. This looks like the old issue I was trying to fix with "SUNRPC: protect service sockets lists during per-net shutdown". So, here is the problem as I see it: there is a transport, which is

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread Stanislav Kinsbursky
17.01.2013 17:03, J. Bruce Fields пишет: On Thu, Jan 17, 2013 at 09:05:51AM +0400, Stanislav Kinsbursky wrote: 17.01.2013 02:51, Mark Lord пишет: On 13-01-16 12:20 AM, Stanislav Kinsbursky wrote: Mark, could you provide any call traces? Call traces from where/what? There's this one, posted

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread Stanislav Kinsbursky
17.01.2013 17:03, J. Bruce Fields пишет: On Thu, Jan 17, 2013 at 09:05:51AM +0400, Stanislav Kinsbursky wrote: 17.01.2013 02:51, Mark Lord пишет: On 13-01-16 12:20 AM, Stanislav Kinsbursky wrote: Mark, could you provide any call traces? Call traces from where/what? There's this one, posted

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-17 Thread Stanislav Kinsbursky
18.01.2013 03:41, Mark Lord пишет: On 13-01-17 08:24 AM, Stanislav Kinsbursky wrote: .. This looks like the old issue I was trying to fix with SUNRPC: protect service sockets lists during per-net shutdown. So, here is the problem as I see it: there is a transport, which is processed

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-16 Thread Stanislav Kinsbursky
17.01.2013 02:51, Mark Lord пишет: On 13-01-16 12:20 AM, Stanislav Kinsbursky wrote: Mark, could you provide any call traces? Call traces from where/what? There's this one, posted earlier in the BUG report: kernel BUG at net/sunrpc/svc_xprt.c:921! Call Trace: [] ? svc_recv+0xcc/0x338

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-16 Thread Stanislav Kinsbursky
17.01.2013 02:51, Mark Lord пишет: On 13-01-16 12:20 AM, Stanislav Kinsbursky wrote: Mark, could you provide any call traces? Call traces from where/what? There's this one, posted earlier in the BUG report: kernel BUG at net/sunrpc/svc_xprt.c:921! Call Trace: [a016a56a] ? svc_recv

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-15 Thread Stanislav Kinsbursky
. -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 3/4] SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function

2013-01-15 Thread Stanislav Kinsbursky
Passing this pointer is redundant since it's stored on cache_detail structure, which is also passed to sunrpc_cache_pipe_upcall () function. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/dns_resolve.c |2 +- include/linux/sunrpc/cache.h |6 +- net/sunrpc/cache.c

[PATCH 4/4] SUNRPC: move cache_detail->cache_request callback call to cache_read()

2013-01-15 Thread Stanislav Kinsbursky
: svc_export_request() (which is cache_request callback) calls d_path(), which, in turn, traverse dentry up to current->fs->root. Kernel threads always have global root, while container have be in "root jail" - i.e. have it's own nested root. Signed-off-by: Stanislav Kinsbursky --- net/sunrp

[PATCH 1/4] SUNRPC: introduce cache_detail->cache_request callback

2013-01-15 Thread Stanislav Kinsbursky
This callback will allow to simplify upcalls in further patches in this series. Signed-off-by: Stanislav Kinsbursky --- fs/nfs/dns_resolve.c |2 +- fs/nfsd/export.c |6 -- fs/nfsd/nfs4idmap.c |6 -- include/linux/sunrpc/cache.h

[PATCH 2/4] SUNRPC: remove cache_detail->cache_upcall callback

2013-01-15 Thread Stanislav Kinsbursky
This callback is redundant since all that its' implementations are doing is calling sunrpc_cache_pipe_upcall() with proper function address argument. This function address is now stored on cache_detail structure and thus all the code can be simplified. Signed-off-by: Stanislav Kinsbursky --- fs

[RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-15 Thread Stanislav Kinsbursky
, but containers can work in "root jail" - i.e. have it's own nested root. The following series implements... --- Stanislav Kinsbursky (4): SUNRPC: introduce cache_detail->cache_request callback SUNRPC: remove cache_detail->cache_upcall callback SUNRPC: remov

Re: BUG at net/sunrpc/svc_xprt.c:921

2013-01-15 Thread Stanislav Kinsbursky
. -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-15 Thread Stanislav Kinsbursky
, but containers can work in root jail - i.e. have it's own nested root. The following series implements... --- Stanislav Kinsbursky (4): SUNRPC: introduce cache_detail-cache_request callback SUNRPC: remove cache_detail-cache_upcall callback SUNRPC: remove cache_request argument

[PATCH 1/4] SUNRPC: introduce cache_detail-cache_request callback

2013-01-15 Thread Stanislav Kinsbursky
This callback will allow to simplify upcalls in further patches in this series. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/dns_resolve.c |2 +- fs/nfsd/export.c |6 -- fs/nfsd/nfs4idmap.c |6 -- include

[PATCH 2/4] SUNRPC: remove cache_detail-cache_upcall callback

2013-01-15 Thread Stanislav Kinsbursky
This callback is redundant since all that its' implementations are doing is calling sunrpc_cache_pipe_upcall() with proper function address argument. This function address is now stored on cache_detail structure and thus all the code can be simplified. Signed-off-by: Stanislav Kinsbursky skinsbur

[PATCH 4/4] SUNRPC: move cache_detail-cache_request callback call to cache_read()

2013-01-15 Thread Stanislav Kinsbursky
: svc_export_request() (which is cache_request callback) calls d_path(), which, in turn, traverse dentry up to current-fs-root. Kernel threads always have global root, while container have be in root jail - i.e. have it's own nested root. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- net

[PATCH 3/4] SUNRPC: remove cache_request argument in sunrpc_cache_pipe_upcall() function

2013-01-15 Thread Stanislav Kinsbursky
Passing this pointer is redundant since it's stored on cache_detail structure, which is also passed to sunrpc_cache_pipe_upcall () function. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/dns_resolve.c |2 +- include/linux/sunrpc/cache.h |6 +- net

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-13 Thread Stanislav Kinsbursky
Thanks! 11.01.2013 21:20, J. Bruce Fields пишет: On Fri, Jan 11, 2013 at 12:03:12PM -0500, J. Bruce Fields wrote: On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-13 Thread Stanislav Kinsbursky
11.01.2013 21:03, J. Bruce Fields пишет: On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-13 Thread Stanislav Kinsbursky
11.01.2013 21:03, J. Bruce Fields пишет: On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-13 Thread Stanislav Kinsbursky
Thanks! 11.01.2013 21:20, J. Bruce Fields пишет: On Fri, Jan 11, 2013 at 12:03:12PM -0500, J. Bruce Fields wrote: On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread Stanislav Kinsbursky
11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I don't really understand, how mountd's root can be wrong. I.e. its' always right as I see it. NFSd kthreads have

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread Stanislav Kinsbursky
11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I don't really understand, how mountd's root can be wrong. I.e. its' always right as I see it. NFSd kthreads have

Re: [PATCH] nfsd: fix unused "nn" variable warning in free_client()

2013-01-09 Thread Stanislav Kinsbursky
Bruce, sorry, forgot to add: Reported-by: Toralf Förster 09.01.2013 13:38, Stanislav Kinsbursky пишет: If CONFIG_LOCKDEP is disabled, then there would be a warning like this: CC [M] fs/nfsd/nfs4state.o fs/nfsd/nfs4state.c: In function ‘free_client’: fs/nfsd/nfs4state.c:1051:19: warning

[PATCH] nfsd: fix unused "nn" variable warning in free_client()

2013-01-09 Thread Stanislav Kinsbursky
Signed-off-by: Stanislav Kinsbursky --- fs/nfsd/nfs4state.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 8f7362c..739a6c2 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1048,7 +1048,7 @@ static struct n

Re: [RFC PATCH v8 0/5] IPC: checkpoint/restore in userspace enhancements

2013-01-09 Thread Stanislav Kinsbursky
22.12.2012 19:43, Sasha Levin пишет: On 12/21/2012 04:57 PM, Sasha Levin wrote: On 12/21/2012 03:46 PM, Stanislav Kinsbursky wrote: 21.12.2012 00:47, Andrew Morton пишет: On Thu, 20 Dec 2012 08:06:32 +0400 Stanislav Kinsbursky wrote: 19.12.2012 00:36, Andrew Morton __: On Wed, 24

Re: [RFC PATCH v8 0/5] IPC: checkpoint/restore in userspace enhancements

2013-01-09 Thread Stanislav Kinsbursky
22.12.2012 19:43, Sasha Levin пишет: On 12/21/2012 04:57 PM, Sasha Levin wrote: On 12/21/2012 03:46 PM, Stanislav Kinsbursky wrote: 21.12.2012 00:47, Andrew Morton пишет: On Thu, 20 Dec 2012 08:06:32 +0400 Stanislav Kinsburskyskinsbur...@parallels.com wrote: 19.12.2012 00:36, Andrew Morton

<    1   2   3   4   5   6   7   8   >