On 26/07/2019, Colin King wrote:
> From: Colin Ian King
>
> Variable err is initialized to a value that is never read and it
> is re-assigned later. The initialization is redundant and can
> be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
> ---
> drivers/ne
ireless/intel/ipw2x00/ipw2200.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
Acked-by: Stanislav Yakovlev
Thanks, and sorry for the long review.
Kalle, could you please apply it to the wireless-drivers-next tree?
Thanks,
Stanislav.
x27;inline' is not
> at beginning of declaration [-Werror=old-style-declaration]
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Stanislav Yakovlev
Stanislav.
On 15 June 2015 at 21:24, Nicholas Mc Guire wrote:
> commit: commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
> HW_PHY_OFF_LOOP_DELAY (HZ / 5000) which always evaluated to 0. Clarified
> by Stanislav Yakovlev that it should be 50
> milliseconds thus fixed up
Hi Nicholas,
On 12 June 2015 at 20:58, Nicholas Mc Guire wrote:
> Hi !
>
> commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced
>
> drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511
> 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv)
> 1411 {
> 1412
> 141
On 27 May 2015 at 16:05, Laurent Pinchart
wrote:
> Even though 'compatability' has a dedicated entry in the Wiktionary,
> it's listed as 'Mispelling of compatibility'. Fix it.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/net/wireless/ipw2x0
Hi Joe,
On 25 September 2013 23:37, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the com
Hi Stan,
> I am having intermittent problems with dropping wifi network while the AP
> is still visible and dmesg produces this:
>
> [26617.864791] ipw2200: Failed to send ASSOCIATE: Already sending a
> command.
>
Thank you for the information, I will take a look. Could you please
reproduc
Hi Yijing,
On 4 June 2013 00:07, Yijing Wang wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in ipw2100_pci_init_one().
>
> Signed-off-by: Yijing Wang
> Cc: Stanislav Yakovlev
> Cc: "John W. Linville"
> Cc
d_delayed_work() w/ 0 delay for immediate scanning.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Stanislav Yakovlev
> Cc: linux-wirel...@vger.kernel.org
> ---
> Please let me know how this patch should be routed. I can take it
> through the workqueue tree if
sid, at the suggestion of Stanislav Yakovlev.
>
> The semantic match that finds the first problem is as follows:
>
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression ret;
> identifier f;
> statement S1,S2;
> @@
>
> *ret = f(...);
> if (\(ret != 0\|ret <
Hello Julia,
On 19 August 2012 01:25, Julia Lawall wrote:
> - ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid, &len);
> + ret = ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid,
> + &len);
This is correct, but this line has one
12 matches
Mail list logo
