[PATCH v8 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-06-26 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access

[PATCH v8 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-26 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new

[PATCH v8 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-26 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

Re: Enabling interrupts in QEMU TPM TIS

2020-06-26 Thread Stefan Berger
On 6/25/20 7:19 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 06:48:09PM -0400, Stefan Berger wrote: On 6/25/20 5:26 PM, Stefan Berger wrote: On 6/25/20 1:28 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: Hello!   I want to enable IRQs now

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-26 Thread Stefan Berger
On 6/26/20 7:48 AM, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 05:27:50PM -0400, Stefan Berger wrote: On 6/25/20 5:25 PM, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 08:41:18AM -0400, Stefan Berger wrote: On 6/25/20 12:38 AM, Jarkko Sakkinen wrote: Re-allocate context and session

Re: Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
On 6/25/20 5:26 PM, Stefan Berger wrote: On 6/25/20 1:28 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: Hello!   I want to enable IRQs now in QEMU's TPM TIS device model and I need to work with the following patch to Linux TIS. I am wondering

[PATCH v7 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-06-25 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access

[PATCH v7 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-25 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new

[PATCH v7 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-25 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
Bottomley Suggested-by: Stefan Berger Signed-off-by: Jarkko Sakkinen --- Tested only for compilation. v2: TPM2_SPACE_DEFAULT_BUFFER_SIZE drivers/char/tpm/tpm2-space.c | 87 --- include/linux/tpm.h | 6 ++- 2 files changed, 64 insertions(+), 29

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
On 6/25/20 5:25 PM, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 08:41:18AM -0400, Stefan Berger wrote: On 6/25/20 12:38 AM, Jarkko Sakkinen wrote: Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus

Re: Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
On 6/25/20 1:28 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: Hello!  I want to enable IRQs now in QEMU's TPM TIS device model and I need to work with the following patch to Linux TIS. I am wondering whether the changes there look reasonable to you

Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
        irq); @@ -1074,6 +1082,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,     } else {         tpm_tis_probe_irq(chip, intmask);     } +        tpm_chip_stop(chip); } rc = tpm_chip_register(chip); -- 2.26.2    Stefan

Re: [PATCH v4 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2020 at 05:02:54PM +0300, Paraschiv, Andra-Irina wrote: > On 23/06/2020 11:56, Stefan Hajnoczi wrote: > > On Mon, Jun 22, 2020 at 11:03:12PM +0300, Andra Paraschiv wrote: > > > +/* User memory region flags */ > > > + > > > +/* Mem

Re: [PATCH v4 17/18] nitro_enclaves: Add overview documentation

2020-06-25 Thread Stefan Hajnoczi
On Wed, Jun 24, 2020 at 05:39:39PM +0300, Paraschiv, Andra-Irina wrote: > > > On 23/06/2020 11:59, Stefan Hajnoczi wrote: > > On Mon, Jun 22, 2020 at 11:03:28PM +0300, Andra Paraschiv wrote: > > > +The kernel bzImage, the kernel command line, the ramdisk(s) are part of

[PATCH v6 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-25 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new

[PATCH v6 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-25 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

[PATCH v6 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-06-25 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
Bottomley Suggested-by: Stefan Berger Signed-off-by: Jarkko Sakkinen You don't want to try a fixes tag? None of the previous versions of this code will work with newer versions of the TPM 2 then...    Stefan

Re: [PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
Bottomley Suggested-by: Stefan Berger Signed-off-by: Jarkko Sakkinen --- Tested only for compilation. drivers/char/tpm/tpm2-space.c | 80 --- include/linux/tpm.h | 6 ++- 2 files changed, 59 insertions(+), 27 deletions(-) diff --git a/drivers/char

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-25 Thread Stefan Berger
On 6/24/20 10:34 PM, Jarkko Sakkinen wrote: On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Stefan Berger
On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area

Re: [PATCH v2] ima_evm_utils: extended calc_bootaggr to PCRs 8 - 9

2020-06-24 Thread Stefan Berger
On 6/23/20 2:13 PM, Bruno Meneguele wrote: On Tue, Jun 23, 2020 at 02:01:22PM -0400, Maurizio Drocco wrote: From: Maurizio If PCRs 8 - 9 are set (i.e. not all-zeros), cal_bootaggr should include them into the digest. Wouldn't you have to check for not all-zeros in your code?    Stefan

[PATCH v5 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-06-23 Thread Stefan Berger
From: Stefan Berger This series of patches extends the existing TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access to a TPM 1.2's

[PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-23 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we extend the existing structure with these fields to allow non-UEFI systems to access

[PATCH v5 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-23 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-23 Thread Stefan Berger
On 6/22/20 8:56 PM, Jarkko Sakkinen wrote: On Fri, Jun 19, 2020 at 11:14:20AM -0400, Stefan Berger wrote: On 4/2/20 3:21 PM, Jarkko Sakkinen wrote: On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote: On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen wrote: On Tue, Mar 31, 2020

Re: [PATCH v4 17/18] nitro_enclaves: Add overview documentation

2020-06-23 Thread Stefan Hajnoczi
amazon.com/ec2/nitro/nitro-enclaves/ > +[2] https://www.kernel.org/doc/Documentation/vm/hugetlbpage.txt > +[3] https://lwn.net/Articles/807108/ > +[4] https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html > +[5] https://man7.org/linux/man-pages/man7/vsock.7.html Is the

Re: [PATCH v4 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-23 Thread Stefan Hajnoczi
On Mon, Jun 22, 2020 at 11:03:12PM +0300, Andra Paraschiv wrote: > diff --git a/include/uapi/linux/nitro_enclaves.h > b/include/uapi/linux/nitro_enclaves.h > new file mode 100644 > index ..3270eb939a97 > --- /dev/null > +++ b/include/uapi/linux/nitro_enclaves.h > @@ -0,0 +1,137 @@ >

Re: [PATCH v2 14/15] vfio: Document dual stage control

2020-06-22 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 06:27:27AM +, Liu, Yi L wrote: > > From: Stefan Hajnoczi > > Sent: Monday, June 15, 2020 5:41 PM > > On Thu, Jun 11, 2020 at 05:15:33AM -0700, Liu Yi L wrote: > > > > > From: Eric Auger > > > > > > The VFIO API wa

Re: [PATCH v2 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-06-22 Thread Stefan Hajnoczi
On Tue, Jun 16, 2020 at 12:09:16PM -0400, Peter Xu wrote: > On Tue, Jun 16, 2020 at 04:49:28PM +0100, Stefan Hajnoczi wrote: > > Isolation between applications is preserved but there is no isolation > > between the device and the application itself. The application needs to >

Re: [PATCH v2 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-06-22 Thread Stefan Hajnoczi
On Tue, Jun 16, 2020 at 10:00:16AM -0700, Raj, Ashok wrote: > On Tue, Jun 16, 2020 at 04:49:28PM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 16, 2020 at 02:26:38AM +, Tian, Kevin wrote: > > > > From: Stefan Hajnoczi > > > > Sent: Monday, June 15, 2020 6:02 P

Re: [RFC v9 09/11] vhost/scsi: switch to buf APIs

2020-06-22 Thread Stefan Hajnoczi
on virtio_scsi_ctrl_tmf_resp\n"); > } The curly brackets are not necessary, but the patch still looks fine: Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC v9 10/11] vhost/vsock: switch to the buf API

2020-06-22 Thread Stefan Hajnoczi
> 1 file changed, 18 insertions(+), 12 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH V2] drivers/block: Use kobj_to_dev() API

2020-06-22 Thread Stefan Hajnoczi
On Sat, Jun 20, 2020 at 09:53:43AM +0800, Wang Qing wrote: > Use kobj_to_dev() API instead of container_of(). > > Signed-off-by: Wang Qing > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.as

Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-19 Thread Stefan Berger
On 4/2/20 3:21 PM, Jarkko Sakkinen wrote: On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote: On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen wrote: On Tue, Mar 31, 2020 at 05:49:49PM -0400, Stefan Berger wrote: From: Stefan Berger Recent extensions of the TPM2 ACPI table

Re: [PATCH] drivers\block: Use kobj_to_dev() API

2020-06-19 Thread Stefan Hajnoczi
ivers/block/virtio_blk.c Please fix the '\' -> '/' in the commit message. Looks good otherwise: Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[RFC 1/2] genirq: honor device NUMA node when allocating descs

2020-06-17 Thread Stefan Hajnoczi
Use the device's NUMA node instead of the first masked CPUs node when descs are allocated. The mask may include all CPUs and therefore not correspond to the home NUMA node of the device. Signed-off-by: Stefan Hajnoczi --- kernel/irq/irqdesc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[RFC 0/2] genirq: take device NUMA node into account for managed IRQs

2020-06-17 Thread Stefan Hajnoczi
reason why managed IRQs should *not* take NUMA into account that I've missed? 2. Is there a better place to implement this logic? For example, pci_alloc_irq_vectors_affinity() where the cpumasks are calculated. Any suggestions on how to proceed would be appreciated. Thanks! Stefan Hajnoczi (2):

[RFC 2/2] genirq/matrix: take NUMA into account for managed IRQs

2020-06-17 Thread Stefan Hajnoczi
Select CPUs from the IRQ's NUMA node in preference over other CPUs. This ensures that managed IRQs are assigned to the same NUMA node as the device. Signed-off-by: Stefan Hajnoczi --- include/linux/irq.h | 2 +- arch/x86/kernel/apic/vector.c | 3 ++- kernel/irq/matrix.c

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-16 Thread Stefan Wahren
Hi Maxime, Am 16.06.20 um 14:30 schrieb Maxime Ripard: > On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: >> Am 11.06.20 um 15:34 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: >>

Re: [PATCH v2 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-06-16 Thread Stefan Hajnoczi
On Tue, Jun 16, 2020 at 02:26:38AM +, Tian, Kevin wrote: > > From: Stefan Hajnoczi > > Sent: Monday, June 15, 2020 6:02 PM > > > > On Thu, Jun 11, 2020 at 05:15:19AM -0700, Liu Yi L wrote: > > > Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memo

Re: [PATCH v2 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-06-16 Thread Stefan Hajnoczi
On Mon, Jun 15, 2020 at 12:39:40PM +, Liu, Yi L wrote: > > From: Stefan Hajnoczi > > Sent: Monday, June 15, 2020 6:02 PM > > > > On Thu, Jun 11, 2020 at 05:15:19AM -0700, Liu Yi L wrote: > > > Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memory (SVM

Re: [PATCH v2 00/15] vfio: expose virtual Shared Virtual Addressing to VMs

2020-06-15 Thread Stefan Hajnoczi
ces instead of translating to IOVAs? If yes, can guest applications restrict the vSVA address space so the device only has access to certain regions? On one hand replacing IOVA translation with virtual addresses simplifies the application programming model, but does it give up isolation if the device can now access all application memory? Thanks, Stefan signature.asc Description: PGP signature

Re: [PATCH v2 14/15] vfio: Document dual stage control

2020-06-15 Thread Stefan Hajnoczi
On Thu, Jun 11, 2020 at 05:15:33AM -0700, Liu Yi L wrote: > From: Eric Auger > > The VFIO API was enhanced to support nested stage control: a bunch of > new iotcls and usage guideline. > > Let's document the process to follow to set up nested mode. > > Cc: Kevin Tian > CC: Jacob Pan > Cc:

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-14 Thread Stefan Wahren
Hi Maxime, Am 11.06.20 um 15:34 schrieb Maxime Ripard: > Hi Stefan, > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 05.06.20 um 16:35 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jun 03,

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Stefan Wahren
Am 11.06.20 um 19:06 schrieb Florian Fainelli: > > On 6/11/2020 9:52 AM, Maxime Ripard wrote: >> Hi Stefan, >> >> On Thu, Jun 11, 2020 at 05:50:30PM +0200, Stefan Wahren wrote: >>>> diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c >>>> b/drivers/clk

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Stefan Wahren
..84dbc886e303 > --- /dev/null > +++ b/drivers/clk/bcm/clk-bcm2711-dvp.c > @@ -0,0 +1,120 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2020 Cerno > + > +#include > +#include > +#include > +#include > +#include > + > +#define DVP_HT_RPI_SW_INIT 0x04 > +#define DVP_HT_RPI_MISC_CONFIG 0x08 sorry for not noticing this before. Are these defines specific to the Raspberry Pi, because of RPI? Otherwise i like to see this RPI part removed. Regards Stefan

Re: [PATCH RFC v5 12/13] vhost/vsock: switch to the buf API

2020-06-08 Thread Stefan Hajnoczi
On Sun, Jun 07, 2020 at 10:11:49AM -0400, Michael S. Tsirkin wrote: > A straight-forward conversion. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vsock.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) Reviewed-b

Re: [PATCH RFC v5 11/13] vhost/scsi: switch to buf APIs

2020-06-08 Thread Stefan Hajnoczi
ers/vhost/scsi.c | 73 ++-- > 1 file changed, 44 insertions(+), 29 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-06 Thread Stefan Wahren
Hi Maxime, Am 05.06.20 um 16:35 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: >>> On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >>>> On Wed, M

Re: [PATCH] tpm: ibmvtpm: Wait for ready buffer before probing for TPM2 attributes

2020-06-05 Thread Stefan Berger
Reviewed-by: Stefan Berger --- drivers/char/tpm/tpm_ibmvtpm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c index 09fe45246b8c..994385bf37c0 100644 --- a/drivers/char/tpm/tpm_ibmvtpm.c +++

Re: [PATCH RFC 11/13] vhost/scsi: switch to buf APIs

2020-06-05 Thread Stefan Hajnoczi
t drivers might be happier (especially drivers for niche OSes that were only tested against QEMU's virtio-scsi). On the other hand, it's a guest-visible change that could break similar niche drivers that assume length is always 0. I'd leave it as-is unless people hit issues that justify the risk of changing it. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH RFC 12/13] vhost/vsock: switch to the buf API

2020-06-05 Thread Stefan Hajnoczi
On Tue, Jun 02, 2020 at 09:06:22AM -0400, Michael S. Tsirkin wrote: > A straight-forward conversion. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vsock.c | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) Reviewed-b

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-06-05 Thread Stefan Hajnoczi
On Mon, Jun 01, 2020 at 10:20:18AM +0300, Paraschiv, Andra-Irina wrote: > > > On 01/06/2020 06:02, Benjamin Herrenschmidt wrote: > > On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote: > > > What about feature bits or a API version number field? If you add > &g

Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings

2020-06-04 Thread Stefan Wahren
Am 04.06.20 um 18:40 schrieb Florian Fainelli: > > On 6/3/2020 9:20 PM, Lukas Wunner wrote: >> On Wed, Jun 03, 2020 at 08:46:54PM -0700, Florian Fainelli wrote: >>> The BCM2711 SoC features 5 SPI controllers which all share the same >>> interrupt line, the SPI driver needs to support interrupt

Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings

2020-06-04 Thread Stefan Wahren
Hi Florian, Am 04.06.20 um 05:46 schrieb Florian Fainelli: > The BCM2711 SoC features 5 SPI controllers which all share the same > interrupt line, the SPI driver needs to support interrupt sharing, > therefore use the chip specific compatible string to help with that. the commit message is

Re: [PATCH v3 105/105] ARM: dts: bcm2711: Enable the display pipeline

2020-06-03 Thread Stefan Wahren
Hi Maxime, Am 27.05.20 um 17:49 schrieb Maxime Ripard: > Now that all the drivers have been adjusted for it, let's bring in the > necessary device tree changes. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 46 +++- > arch/arm/boot/dts/bcm2711.dtsi

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-03 Thread Stefan Wahren
Am 02.06.20 um 17:54 schrieb Maxime Ripard: > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: >>> the vc4_hdmi driver has some custom structures to hold the data it needs to >>> associate with the drm_encoder and drm_connector

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-06-03 Thread Stefan Wahren
Hi Maxime, Am 03.06.20 um 15:14 schrieb Maxime Ripard: > Hi Stefan, > > On Tue, Jun 02, 2020 at 10:03:13PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 21:31 schrieb Eric Anholt: >>> On Tue, Jun 2, 2020 at 8:02 AM Dave Stevenson >>> wrote: >>>> Hi

Re: [PATCH v3 000/105] drm/vc4: Support BCM2711 Display Pipeline

2020-06-02 Thread Stefan Wahren
Hi Maxime, Am 27.05.20 um 17:47 schrieb Maxime Ripard: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-06-02 Thread Stefan Wahren
ncluding the ARM). That's why the VEC has to >> be explicitly enabled for the firmware to enable it as the only >> output. It's annoying, but that's just a restriction of the chip. > I'm more concerned with "make sure we don't regress pre-pi4 with this > series" than "

[PATCH v2] capabilities: add description for CAP_SETFCAP

2020-06-02 Thread Stefan Hajnoczi
Document the purpose of CAP_SETFCAP. For some reason this capability had no description while the others did. Signed-off-by: Stefan Hajnoczi --- v2: * Rebased onto git master include/uapi/linux/capability.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/capability.h

Re: [PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-30 Thread Stefan Wahren
Hi Florian, Am 30.05.20 um 23:19 schrieb Florian Fainelli: > > On 5/30/2020 12:49 AM, Stefan Wahren wrote: >> Hi Florian, >> >> Am 29.05.20 um 21:15 schrieb Florian Fainelli: >>> } >>> >>> +static int bcm2835_gpio_irq_set_wake(struct irq_data

Re: [PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-30 Thread Stefan Wahren
Hi Florian, Am 29.05.20 um 21:15 schrieb Florian Fainelli: > Leverage the IRQCHIP_MASK_ON_SUSPEND flag in order to avoid having to > specifically treat the GPIO interrupts during suspend and resume, and > simply implement an irq_set_wake() callback that is responsible for > enabling the parent

Re: [PATCH 3/4] pinctrl: bcm2835: Match BCM7211 compatible string

2020-05-29 Thread Stefan Wahren
11-gpio", > + .data = _pinconf_ops, this doesn't look safe. Maybe bcm2711_plat_data? Looks like the original patch series based on a older version. Please double check this still applies since the introduction of 58 GPIO support for BCM2711. Regards Stefan > + }, > {} > }; >

Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

2020-05-27 Thread Stefan Hajnoczi
On Tue, May 26, 2020 at 01:13:17AM +0300, Andra Paraschiv wrote: > The Nitro Enclaves driver handles the enclave lifetime management. This > includes enclave creation, termination and setting up its resources such > as memory and CPU. > > An enclave runs alongside the VM that spawned it. It is

Re: [PATCH v2] firewire-core: remove cast of function callback

2020-05-24 Thread Stefan Richter
urn -EINVAL; - - cb = iso_callback; break; case FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL: - cb = (fw_iso_callback_t)iso_mc_callback; break; default: @@ -990,9 +984,15 @@ static int ioctl_create_iso_context(struct client *client, union ioctl_arg *arg) } context = fw_iso_context_create(client->device->card, a->type, - a->channel, a->speed, a->header_size, cb, client); + a->channel, a->speed, a->header_size, NULL, client); if (IS_ERR(context)) return PTR_ERR(context); + + if (a->type == FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL) + context->callback.mc = iso_mc_callback; + else + context->callback.sc = iso_callback; + if (client->version < FW_CDEV_VERSION_AUTO_FLUSH_ISO_OVERFLOW) context->drop_overflow_headers = true; -- Stefan Richter -==--=-- -=-= ==--= http://arcgraph.de/sr/

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-21 Thread Stefan Wahren
ou please mention in the commit the used hardware implementation(s) of iproc-rng200 to get this quality? AFAIK there is still no public register description at least for the bcm2711. So is it safe to assume that the suggested quality applies to all possible configurations? Thanks Stefan >

[PATCH v4 0/2] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-19 Thread Stefan Haberland
ome comments and some cleanup Christoph Hellwig (1): dasd: refactor dasd_ioctl_information Stefan Haberland (1): s390/dasd: remove ioctl_by_bdev calls MAINTAINERS | 1 + block/partitions/ibm.c | 24 --- drivers/s390/block/dasd_ioctl.c |

[PATCH v4 1/2] dasd: refactor dasd_ioctl_information

2020-05-19 Thread Stefan Haberland
From: Christoph Hellwig Prepare for in-kernel callers of this functionality. Signed-off-by: Christoph Hellwig [s...@de.ibm.com: remove leftover kfree] Signed-off-by: Stefan Haberland Reviewed-by: Peter Oberparleiter Reviewed-by: Jan Hoeppner --- drivers/s390/block/dasd_ioctl.c | 42

[PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls

2020-05-19 Thread Stefan Haberland
. Suggested-by: Christoph Hellwig Signed-off-by: Stefan Haberland Reviewed-by: Jan Hoeppner Reviewed-by: Peter Oberparleiter --- MAINTAINERS | 1 + block/partitions/ibm.c | 24 +-- drivers/s390/block/dasd_ioctl.c | 34

Re: [PATCH v3 3/3] s390/dasd: remove ioctl_by_bdev calls

2020-05-18 Thread Stefan Haberland
Am 16.05.20 um 17:43 schrieb Christoph Hellwig: > On Mon, May 11, 2020 at 06:30:44PM +0200, Stefan Haberland wrote: >> Am 08.05.20 um 17:53 schrieb Christoph Hellwig: >>> I think this should use symbol_get instead. >> Thanks for the Feedback, also for the previous patc

Re: [PATCH v3 3/3] s390/dasd: remove ioctl_by_bdev calls

2020-05-11 Thread Stefan Haberland
Am 08.05.20 um 17:53 schrieb Christoph Hellwig: > I think this should use symbol_get instead. Thanks for the Feedback, also for the previous patch. I will incorporate it, run some test cycles and submit the patches again when I am ready.

Re: [PATCH v1 00/15] Add support for Nitro Enclaves

2020-05-11 Thread Stefan Hajnoczi
. when AWS deploys the > functionality. You don't need the hypervisor itself to be open source. > > In fact, in this case, it's not even low level invasive arch code like > some of the above can be. It's a driver for a PCI device :-) Granted a > virtual one. We merge drivers for PCI

RE: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Stefan Chulski
> -Original Message- > From: Matteo Croce > Sent: Saturday, May 9, 2020 3:16 PM > To: Stefan Chulski > Cc: David S . Miller ; Maxime Chevallier > ; netdev ; LKML > ; Antoine Tenart > ; Thomas Petazzoni > ; gregory.clem...@bootlin.com; > miquel.ray...@boot

RE: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Stefan Chulski
> -Original Message- > From: Matteo Croce > Sent: Saturday, May 9, 2020 3:13 AM > To: David S . Miller > Cc: Maxime Chevallier ; netdev > ; LKML ; Antoine > Tenart ; Thomas Petazzoni > ; gregory.clem...@bootlin.com; > miquel.ray...@bootlin.com; Nadav Haklai

Re: [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-09 Thread Stefan Wahren
Am 09.05.20 um 12:02 schrieb Stefan Wahren: > Hi Nicolas, > > Am 07.05.20 um 23:48 schrieb Rob Herring: >> On Tue, 5 May 2020 18:13:15 +0200, Nicolas Saenz Julienne wrote: >>> The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip >>> that implemen

Re: [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-09 Thread Stefan Wahren
"VL805 RAM firmware version %08x\n", version);     return 0;  }  EXPORT_SYMBOL_GPL(rpi_firmware_init_vl805); Here are the my results with 3x Raspberry Pi 4: VL805 EEPROM firmware version 000137ad VL805 EEPROM firmware version 00013701 VL805 RAM firmware version 000137ad So the whole patch series is: Tested-by: Stefan Wahren

Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

2020-05-08 Thread Stefan Wahren
100.1) 56(84) bytes of data. >> From 192.168.100.53 icmp_seq=1 Destination Host Unreachable >> ... > Okay, I've played a bit more with this and found that enabling > CONFIG_BROADCOM_PHY fixes this network issue. I wonder if Genet driver > should simply select CONFIG_BROADCOM_PHY the same way as it selects > CONFIG_BCM7XXX_PHY. thanks for finding this issue. So it seems arm64/defconfig is also affected. I don't have a strong opinion how to solve this. Best regards Stefan > > Best regards

[PATCH v3 2/3] block: add a s390-only biodasdinfo method

2020-05-08 Thread Stefan Haberland
...@linux.ibm.com: remove fop, add gendisk check, export funcion] Signed-off-by: Stefan Haberland --- drivers/s390/block/dasd_int.h | 1 + drivers/s390/block/dasd_ioctl.c | 21 + include/linux/blkdev.h | 1 + 3 files changed, 23 insertions(+) diff --git a/drivers/s390/block

[PATCH v3 3/3] s390/dasd: remove ioctl_by_bdev calls

2020-05-08 Thread Stefan Haberland
Call getgeo method directly and obtain pointer to dasd_biodasdinfo function and use this instead of ioctl. Suggested-by: Christoph Hellwig Signed-off-by: Stefan Haberland --- block/partitions/ibm.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/block

[PATCH v3 1/3] dasd: refactor dasd_ioctl_information

2020-05-08 Thread Stefan Haberland
From: Christoph Hellwig Prepare for in-kernel callers of this functionality. Signed-off-by: Christoph Hellwig Signed-off-by: Stefan Haberland --- drivers/s390/block/dasd_ioctl.c | 38 +++-- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v3 0/3] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-08 Thread Stefan Haberland
: add a s390-only biodasdinfo method Stefan Haberland (1): s390/dasd: remove ioctl_by_bdev calls block/partitions/ibm.c | 15 +++-- drivers/s390/block/dasd_int.h | 1 + drivers/s390/block/dasd_ioctl.c | 59 - include/linux/blkdev.h | 1 + 4

Re: [PATCH v2 89/91] drm/vc4: hdmi: Support the BCM2711 HDMI controllers

2020-05-07 Thread Stefan Wahren
Hi Maxime, Am 24.04.20 um 17:35 schrieb Maxime Ripard: > Now that the driver is ready for it, let's bring in the HDMI controllers > variants for the BCM2711. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 276 +- > drivers/gpu/drm/vc4/vc4_hdmi.h

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Stefan Haberland
Am 07.05.20 um 17:29 schrieb Christoph Hellwig: > On Thu, May 07, 2020 at 05:22:28PM +0200, Stefan Haberland wrote: >> OK, just thought again about your suggestion and also that >> you have already been talking about a symbol lookup I just >> have written a prototype tha

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Stefan Haberland
Am 06.05.20 um 06:52 schrieb Christoph Hellwig: > > No, I mean the series that I actually sent out: > > https://lkml.org/lkml/2020/4/21/66 > https://lkml.org/lkml/2020/4/21/68 > https://lkml.org/lkml/2020/4/21/69 OK, just thought again about your suggestion and also that you have already been

Re: linux-next: Fixes tag needs some work in the vhost tree

2020-05-05 Thread Stefan Hajnoczi
45bd8e2c45ce1d3 > > has these problem(s): > > - missing subject > > Should be > > Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature") > > Please don't split Fixes tags over more than one line. Got it, thanks for letting me know. I'll keep the tag on one line in the future. Stefan signature.asc Description: PGP signature

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-05 Thread Stefan Haberland
Am 05.05.20 um 14:44 schrieb Christoph Hellwig: > On Mon, May 04, 2020 at 10:45:33AM +0200, Stefan Haberland wrote: >>> findthe corresponding device for example. Not sure if this is that easy. >> I did some additional research on this. >> What I could imagine: >>

Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread Nuernberger, Stefan
end, I decided to > quickly > revert the commits first and consider better refactoring later. > While lebench might be exercising a rather pathological case, the increase in memory pressure is real. I am concerned that the OOM killer is actually engaging and killing off processes when

Re: [PATCH v7 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-04 Thread Stefan Wahren
Hi Nicolas, Am 04.05.20 um 10:59 schrieb Nicolas Saenz Julienne: > Hi Stefan, thanks for the review! > > On Sat, 2020-05-02 at 11:05 +0200, Stefan Wahren wrote: >>> + if (version) >>> + goto exit; >>> + >>> + dev_addr = pdev->

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-04 Thread Stefan Haberland
Am 30.04.20 um 16:02 schrieb Stefan Haberland: > Am 30.04.20 um 15:13 schrieb Christoph Hellwig: >> On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: >>> Remove the calls to ioctl_by_bdev from the DASD partition detection code >>> to enable the r

Re: [PATCH v7 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-02 Thread Stefan Wahren
Hi Nicolas, Am 29.04.20 um 18:47 schrieb Nicolas Saenz Julienne: > The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip > that implements xHCI. After a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > co-processor,

Re: [PATCH v4 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-04-30 Thread Stefan Berger
Hi Rafael,   can you ACK this patch? Regards,    Stefan From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we extend the existing

[PATCH v4] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-30 Thread Stefan Hajnoczi
all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby Signed-off-by: Stefan Hajnoczi --- v4: * Clarify vdev_mutex usage [Stefano and Michael] drivers/block/virtio_blk.c | 86 +++

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-04-30 Thread Stefan Haberland
Am 30.04.20 um 15:13 schrieb Christoph Hellwig: > On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: >> Remove the calls to ioctl_by_bdev from the DASD partition detection code >> to enable the removal of the specific code. >> >> To do so reuse the g

[PATCH 0/1] remove ioclt_by_bdev from DASD

2020-04-30 Thread Stefan Haberland
for suggestions. Regards, Stefan Stefan Haberland (1): s390/dasd: remove ioctl_by_bdev from DASD driver block/partitions/ibm.c | 67 ++-- drivers/s390/block/dasd_devmap.c | 17 +++- drivers/s390/block/dasd_diag.c | 10 + drivers/s390/block/dasd_eckd.c | 10

[PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-04-30 Thread Stefan Haberland
information for the partition detection. This makes it independent from the dasd_information2_t structure. Suggested-by: Christoph Hellwig Signed-off-by: Stefan Haberland Reviewed-by: Jan Hoeppner --- block/partitions/ibm.c | 67 ++-- drivers/s390/block

Re: [PATCH v3] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-30 Thread Stefan Hajnoczi
On Thu, Apr 30, 2020 at 10:43:23AM +0200, Stefano Garzarella wrote: > On Wed, Apr 29, 2020 at 05:53:45PM +0100, Stefan Hajnoczi wrote: > > A userspace process holding a file descriptor to a virtio_blk device can > > still invoke block_device_operations after hot unplug. This lea

[PATCH v3] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-29 Thread Stefan Hajnoczi
all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby Signed-off-by: Stefan Hajnoczi --- drivers/block/virtio_blk.c | 87 ++ 1 file changed, 79 insertions(+), 8 delet

<    1   2   3   4   5   6   7   8   9   10   >