Re: [PATCH v2] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-28 Thread Stefan Hajnoczi
On Tue, Apr 28, 2020 at 11:25:07AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2020 at 03:30:09PM +0100, Stefan Hajnoczi wrote: > > A userspace process holding a file descriptor to a virtio_blk device can > > still invoke block_device_operations after hot unplug. For example

[PATCH v2] virtio-blk: handle block_device_operations callbacks after hot unplug

2020-04-28 Thread Stefan Hajnoczi
ported-by: Lance Digby Signed-off-by: Stefan Hajnoczi --- If someone has a simpler solution please let me know. I looked at various approaches including reusing device_lock(>vdev.dev) but they were more complex and extending the lifetime of virtio_device after remove() has been called seems que

Re: [PATCH] capabilities: add description for CAP_SETFCAP

2020-04-28 Thread Stefan Hajnoczi
On Tue, Apr 14, 2020 at 04:49:45PM +0100, Stefan Hajnoczi wrote: > Document the purpose of CAP_SETFCAP. For some reason this capability > had no description while the others did. > > Signed-off-by: Stefan Hajnoczi > --- > include/uapi/linux/capability.h | 2 ++ > 1 file

Re: [PATCH -next] virtiofs: remove unused variable 'fc'

2019-10-23 Thread Stefan Hajnoczi
t; > Signed-off-by: YueHaibing > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Stefan Agner
rivers/rtc/rtc-rc5t619.c | 476 > ++ Parts of this driver look very similar to drivers/rtc/rtc-rc5t583.c. Can it maybe shared? -- Stefan > 3 files changed, 487 insertions(+) > create mode 100644 drivers/rtc/rtc-rc5t619.c > > diff --

Re: memory leaks in dasd_eckd_check_characteristics() error paths

2019-10-18 Thread Stefan Haberland
On 16.10.19 17:28, Stefan Haberland wrote: > On 16.10.19 17:26, Qian Cai wrote: >> On Wed, 2019-10-16 at 16:56 +0200, Stefan Haberland wrote: >>> On 16.10.19 16:09, Qian Cai wrote: >>>> On Wed, 2019-10-16 at 15:29 +0200, Stefan Haberland wrote: >>>

Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

2019-10-16 Thread Stefan Agner
ter description UARTMODIR_* instead of UARTMODEM_*. The value is the same, so there is no functional change. Otherwise looks good to me: Reviewed-by: Stefan Agner -- Stefan > > Signed-off-by: Philippe Schenker > --- > > drivers/tty/serial/fsl_lpuart.c | 4 ++-- > 1 file change

Re: memory leaks in dasd_eckd_check_characteristics() error paths

2019-10-16 Thread Stefan Haberland
On 16.10.19 17:26, Qian Cai wrote: > On Wed, 2019-10-16 at 16:56 +0200, Stefan Haberland wrote: >> On 16.10.19 16:09, Qian Cai wrote: >>> On Wed, 2019-10-16 at 15:29 +0200, Stefan Haberland wrote: >>>> Hi, >>>> >>>> thanks for repor

Re: memory leaks in dasd_eckd_check_characteristics() error paths

2019-10-16 Thread Stefan Haberland
On 16.10.19 16:09, Qian Cai wrote: > On Wed, 2019-10-16 at 15:29 +0200, Stefan Haberland wrote: >> Hi, >> >> thanks for reporting this. >> >> On 02.10.19 21:33, Qian Cai wrote: >>> For some reasons, dasd_eckd_check_characteristics() received -ENOMEM

Re: [PATCH] vsock/virtio: remove unused 'work' field from 'struct virtio_vsock_pkt'

2019-10-16 Thread Stefan Hajnoczi
the per-packet 'struct virtio_vsock_pkt' > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Stefano Garzarella > --- > include/linux/virtio_vsock.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: memory leaks in dasd_eckd_check_characteristics() error paths

2019-10-16 Thread Stefan Haberland
Hi, thanks for reporting this. On 02.10.19 21:33, Qian Cai wrote: > For some reasons, dasd_eckd_check_characteristics() received -ENOMEM and then > dasd_generic_set_online() emits this message, > > dasd: 0.0.0122 Setting the DASD online with discipline ECKD failed with rc=-12 > > After that,

[PATCH v7 0/5] Add initial support for S32V234-EVB

2019-10-16 Thread Stefan-Gabriel Mirea
ux/kernel/git/torvalds/linux.git/commit/?id=9050079719021776e48437827eb9d5986b6e45d4 Eddy Petrișor (1): dt-bindings: arm: fsl: Add the S32V234-EVB board Mihaela Martinas (2): arm64: Introduce config for S32 arm64: defconfig: Enable configs for S32V234 Stefan-Gabriel Mirea (1): serial: fsl_linflexuart:

[PATCH v7 5/5] arm64: defconfig: Enable configs for S32V234

2019-10-16 Thread Stefan-Gabriel Mirea
From: Mihaela Martinas Enable support for the S32V234 SoC, including the previously added UART driver. Signed-off-by: Mihaela Martinas Signed-off-by: Adrian.Nitu Signed-off-by: Stoica Cosmin-Stefan Signed-off-by: Stefan-Gabriel Mirea --- arch/arm64/configs/defconfig | 3 +++ 1 file changed

[PATCH v7 1/5] dt-bindings: arm: fsl: Add the S32V234-EVB board

2019-10-16 Thread Stefan-Gabriel Mirea
From: Eddy Petrișor Add entry for the NXP S32V234 Customer Evaluation Board to the board/SoC bindings. Signed-off-by: Eddy Petrișor Signed-off-by: Stefan-Gabriel Mirea Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++ 1 file changed, 6 insertions

[PATCH v7 4/5] arm64: dts: fsl: Add device tree for S32V234-EVB

2019-10-16 Thread Stefan-Gabriel Mirea
From: Stoica Cosmin-Stefan Add initial version of device tree for S32V234-EVB, including nodes for the 4 Cortex-A53 cores, AIPS bus with UART modules, ARM architected timer and Generic Interrupt Controller (GIC). Keep SoC level separate from board level to let future boards with this SoC share

[PATCH v7 2/5] arm64: Introduce config for S32

2019-10-16 Thread Stefan-Gabriel Mirea
Cosmin-Stefan Signed-off-by: Stefan-Gabriel Mirea --- arch/arm64/Kconfig.platforms | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 16d761475a86..17f1c34ec750 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64

[PATCH v7 3/5] serial: fsl_linflexuart: Be consistent with the name

2019-10-16 Thread Stefan-Gabriel Mirea
For consistency reasons, spell the controller name as "LINFlexD" in comments and documentation. Signed-off-by: Stefan-Gabriel Mirea --- Documentation/admin-guide/kernel-parameters.txt | 2 +- drivers/tty/serial/Kconfig | 8 drivers/tty/serial/fsl_lin

Re: [PATCH 3/6] drivers: firmware: psci: Register with kernel restart handler

2019-10-16 Thread Stefan Agner
gt; Acked-by: Lorenzo Pieralisi > Signed-off-by: Thierry Reding Looks good to me! And helps also in my case, a board which has a broken PSCI reset capability. Reviewed-by: Stefan Agner -- Stefan > --- > drivers/firmware/psci/psci.c | 12 ++-- > 1 file changed, 10 inserti

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-15 Thread Stefan Wahren
Hi Florian, Am 11.10.19 um 21:31 schrieb Florian Fainelli: > On 10/11/19 11:48 AM, matthias@kernel.org wrote: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. >> >> Signed-off-by: Matthias Brugger >> >> --- >> >>

[GIT PULL 2/3] bcm2835-soc-next-2019-10-15

2019-10-15 Thread Stefan Wahren
. Stefan Wahren (1): ARM: bcm: Add support for BCM2711 SoC arch/arm/mach-bcm/Kconfig| 4 +++- arch/arm/mach-bcm/Makefile | 3 ++- arch/arm/mach-bcm/bcm2711.c | 24 arch/arm64/Kconfig.platforms | 5 +++-- 4 files changed, 32

[GIT PULL 1/3] bcm2835-dt-next-2019-10-15

2019-10-15 Thread Stefan Wahren
. Stefan Wahren (7): ARM: dts: bcm283x: Remove simple-bus from fixed clocks ARM: dts: bcm283x: Remove brcm,bcm2835-pl011 compatible ARM: dts: bcm283x: Move BCM2835/6/7 specific to bcm2835-common.dtsi dt-bindings

[GIT PULL 3/3] bcm2835-maintainers-next-2019-10-15

2019-10-15 Thread Stefan Wahren
contributor. Simon Arlott (1): mailmap: Add Simon Arlott (replacement for expired email address) Stefan Wahren (1): MAINTAINERS: Add BCM2711 to BCM2835 ARCH .mailmap| 1 + MAINTAINERS | 3 ++- 2 files changed, 3

Re: [PATCH net 0/2] vsock: don't allow half-closed socket in the host transports

2019-10-15 Thread Stefan Hajnoczi
so please discard this series. > > > > My problem during the tests, was trying to figure out if half-closed > > sockets were supported or not, so as you say adding an IOCTL or maybe > > better a getsockopt() could solve the problem. > > > > What do you think? > &

Re: [PATCH V3 0/7] mdev based hardware virtio offloading support

2019-10-14 Thread Stefan Hajnoczi
PCI devices that support datapath offloading then how are physical devices presented to the guest without SR-IOV? Stefan signature.asc Description: PGP signature

Re: [PATCH] drivers: firmware: psci: use kernel restart handler functionality

2019-10-14 Thread Stefan Agner
Hi Sudeep, On 2019-10-14 12:07, Sudeep Holla wrote: > On Sat, Oct 12, 2019 at 11:47:35PM +0200, Stefan Agner wrote: >> From: Stefan Agner >> >> Use the kernels restart handler to register the PSCI system reset >> capability. The restart handler use notifier chai

Re: [PATCH v4 1/5] vsock/virtio: limit the memory used per-socket

2019-10-14 Thread Stefan Hajnoczi
he vring with new 4 KB free buffers > > > > > to avoid starvation of other sockets. > > > > > > > > > > This patch mitigates this issue copying the payload of small > > > > > packets (< 128 bytes) into the buffer of last packet queued, in &

Re: [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

2019-10-13 Thread Stefan Wahren
start with the 2nd part of Joe's suggestion first. Stefan

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-13 Thread Stefan Wahren
Hi Florian, Am 11.10.19 um 21:31 schrieb Florian Fainelli: > On 10/11/19 11:48 AM, matthias@kernel.org wrote: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. >> >> Signed-off-by: Matthias Brugger >> >> --- >> >>

[PATCH] drivers: firmware: psci: use kernel restart handler functionality

2019-10-12 Thread Stefan Agner
From: Stefan Agner Use the kernels restart handler to register the PSCI system reset capability. The restart handler use notifier chains along with priorities. This allows to use restart handlers with higher priority (in case available) while still supporting PSCI. Since the ARM handler had

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-12 Thread Stefan Wahren
Am 12.10.19 um 01:09 schrieb Stefan Wahren: > Am 11.10.19 um 20:48 schrieb matthias@kernel.org: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. > I asked some questions about genet to the RPi guys [1] whic

Re: [PATCH] mailmap: Add Simon Arlott (replacement for expired email address)

2019-10-12 Thread Stefan Wahren
Am 22.08.19 um 21:01 schrieb Simon Arlott: > Add replacement email address for the one on my expired domain. > > Signed-off-by: Simon Arlott > --- Applied to bcm2835-maintainers-next

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-12 Thread Stefan Wahren
or 5.5 (arch opt-in? clang only? invert the logic? work to move functions > over to __always_inline /before/ flipping the CONFIG option? ...?) what's the status on this? In need to prepare my pull requests for 5.5 and all recent kernelci targets (including linux-next) with bcm2835_defconfig are still broken. Stefan > > Will

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-11 Thread Stefan Wahren
Am 11.10.19 um 20:48 schrieb matthias@kernel.org: > From: Matthias Brugger > > Enable Gigabit Ethernet support on the Raspberry Pi 4 > Model B. I asked some questions about genet to the RPi guys [1] which are relevant to this patch (missing clocks and interrupt, MAC address assignment) but i

Re: [RFC PATCH 07/13] vsock: handle buffer_size sockopts in the core

2019-10-11 Thread Stefan Hajnoczi
On Thu, Oct 10, 2019 at 11:32:54AM +0200, Stefano Garzarella wrote: > On Wed, Oct 09, 2019 at 01:30:26PM +0100, Stefan Hajnoczi wrote: > > On Fri, Sep 27, 2019 at 01:26:57PM +0200, Stefano Garzarella wrote: > > Another issue is that this patch drops the VIRTIO_VSOCK_MAX_BUF

Re: [PATCH v2 07/11] VSOCK: add AF_VSOCK test cases

2019-10-09 Thread Stefan Hajnoczi
On Wed, Oct 09, 2019 at 12:03:53PM +0200, Stefano Garzarella wrote: > Hi Stefan, > I'm thinking about dividing this test into single applications, one > for each test, do you think it makes sense? > Or is it just a useless complication? I don't mind either way but personally I

Re: [RFC PATCH 00/13] vsock: add multi-transports support

2019-10-09 Thread Stefan Hajnoczi
On Fri, Sep 27, 2019 at 01:26:50PM +0200, Stefano Garzarella wrote: > Hi all, > this series adds the multi-transports support to vsock, following > this proposal: > https://www.spinics.net/lists/netdev/msg575792.html Nice series! I have left a few comments but overall it looks promis

Re: [RFC PATCH 13/13] vsock: fix bind() behaviour taking care of CID

2019-10-09 Thread Stefan Hajnoczi
with different CID, and > it prevents a connection to a wrong socket bound to the same > port, but with different CID. > > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/af_vsock.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-

Re: [RFC PATCH 12/13] vsock: prevent transport modules unloading

2019-10-09 Thread Stefan Hajnoczi
ssign_transport(struct vsock_sock *vsk, > struct vsock_sock *psk) > return -ESOCKTNOSUPPORT; > } > > - if (!vsk->transport) > + /* We increase the module refcnt to prevent the tranport unloading s/tranport/transport/ Otherwise: Reviewed-by: Stefan H

Re: [RFC PATCH 11/13] vsock: add 'transport_hg' to handle g2h\h2g transports

2019-10-09 Thread Stefan Hajnoczi
On Fri, Sep 27, 2019 at 01:27:01PM +0200, Stefano Garzarella wrote: > VMCI transport provides both g2h and h2g behaviors in a single > transport. > We are able to set (or not) the g2h behavior, detecting if we > are in a VMware guest (or not), but the h2g feature is always set. > This prevents to

Re: [RFC PATCH 10/13] vsock: add multi-transports support

2019-10-09 Thread Stefan Hajnoczi
On Fri, Sep 27, 2019 at 01:27:00PM +0200, Stefano Garzarella wrote: > RFC: > - I'd like to move MODULE_ALIAS_NETPROTO(PF_VSOCK) to af_vsock.c. > @Jorgen could this break the VMware products? What will cause the vmw_vsock_vmci_transport.ko module to be loaded after you remove

Re: [RFC PATCH 09/13] hv_sock: set VMADDR_CID_HOST in the hvs_remote_addr_init()

2019-10-09 Thread Stefan Hajnoczi
d, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC PATCH 08/13] vsock: move vsock_insert_unbound() in the vsock_create()

2019-10-09 Thread Stefan Hajnoczi
directly. They always pass NULL as the parent socket, so we could have a more specific function that transports call without a parent sock argument. This would eliminate any concern over moving vsock_insert_unbound() out of this function. In any case, I've checked the code and this patch is corre

Re: [RFC PATCH 07/13] vsock: handle buffer_size sockopts in the core

2019-10-09 Thread Stefan Hajnoczi
On Fri, Sep 27, 2019 at 01:26:57PM +0200, Stefano Garzarella wrote: > @@ -140,18 +145,11 @@ struct vsock_transport { > struct vsock_transport_send_notify_data *); > int (*notify_send_post_enqueue)(struct vsock_sock *, ssize_t, > struct

Re: [RFC PATCH 06/13] vsock: add 'struct vsock_sock *' param to vsock_core_get_transport()

2019-10-09 Thread Stefan Hajnoczi
transport uses this >* function and only while registered. >*/ > - return transport_single; This comment is about protecting transport_single. It no longer applies when using vsk->transport. Please drop it. Otherwise: Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC PATCH 05/13] vsock/virtio: add transport parameter to the virtio_transport_reset_no_sock()

2019-10-09 Thread Stefan Hajnoczi
h| 3 +- > net/vmw_vsock/virtio_transport.c| 160 > net/vmw_vsock/virtio_transport_common.c | 12 +- > 4 files changed, 135 insertions(+), 134 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC PATCH 04/13] vsock: add 'transport' member in the struct vsock_sock

2019-10-09 Thread Stefan Hajnoczi
1 + > net/vmw_vsock/af_vsock.c | 56 +++- > 2 files changed, 39 insertions(+), 18 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC PATCH 01/13] vsock/vmci: remove unused VSOCK_DEFAULT_CONNECT_TIMEOUT

2019-10-09 Thread Stefan Hajnoczi
T_CONNECT_TIMEOUT is used and defined in > net/vmw_vsock/af_vsock.c > > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/vmci_transport.c | 5 - > 1 file changed, 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [RFC PATCH 02/13] vsock: remove vm_sockets_get_local_cid()

2019-10-09 Thread Stefan Hajnoczi
off-by: Stefano Garzarella > --- > include/linux/vm_sockets.h | 2 -- > net/vmw_vsock/af_vsock.c| 10 -- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 3 files changed, 1 insertion(+), 13 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [RFC PATCH 03/13] vsock: remove include/linux/vm_sockets.h file

2019-10-09 Thread Stefan Hajnoczi
- > include/net/af_vsock.h| 2 +- > include/net/vsock_addr.h | 2 +- > net/vmw_vsock/vmci_transport_notify.h | 1 - > 4 files changed, 2 insertions(+), 16 deletions(-) > delete mode 100644 include/linux/vm_sockets.h Reviewed-by: Stefan

Re: [PATCH] rcu/nocb: Fix dump_tree hierarchy print always active

2019-10-07 Thread Stefan
On 07/10/2019 03:26, Paul E. McKenney wrote: > > On Fri, Oct 04, 2019 at 03:24:02PM -0700, Paul E. McKenney wrote: >> On Fri, Oct 04, 2019 at 07:49:10PM +, Stefan Reiter wrote: >>> Commit 18cd8c93e69e ("rcu/nocb: Print gp/cb kthread hierarchy if >>>

Re: [PATCH v4 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board

2019-10-07 Thread Stefan-gabriel Mirea
On 10/6/2019 5:00 AM, Shawn Guo wrote: > On Thu, Sep 05, 2019 at 11:58:32AM +0000, Stefan-gabriel Mirea wrote: >> From: Eddy Petrișor >> >> Add entry for the NXP S32V234 Customer Evaluation Board to the board/SoC >> bindings. >> >> Signed-off-by: Eddy Pet

[PATCH] rcu/nocb: Fix dump_tree hierarchy print always active

2019-10-04 Thread Stefan Reiter
statements with dump_tree, while also changing the second pr_alert to a pr_cont, to print the hierarchy in a single line (assuming that's how it was supposed to work). Fixes: 18cd8c93e69e ("rcu/nocb: Print gp/cb kthread hierarchy if dump_tree") Signed-off-by: Stefan Reiter --- First time contri

[PATCH] tty: serial: Fix PORT_LINFLEXUART definition

2019-10-04 Thread Stefan-gabriel Mirea
The port type macros should have different values for different devices. Currently, PORT_LINFLEXUART conflicts with PORT_SUNIX. Fixes: 09864c1cdf5c ("tty: serial: Add linflexuart driver for S32V234") Signed-off-by: Stefan-Gabriel Mirea --- include/uapi/linux/serial_core.h | 2 +- 1 fi

Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711

2019-10-04 Thread Stefan Wahren
>> Signed-off-by: Nicolas Saenz Julienne >> Tested-by: Matthias Brugger > Forgot to add: > > Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") > > I'll resend if needed. Yes, please and you can add my: Acked-by: Stefan Wahren > > Regards, > Nicolas > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dt: check MPIDR on MP devices built without SMP

2019-10-03 Thread Stefan Wahren
ble. > > This was seen on a Raspberry Pi 2 build with bcm2835_defconfig. > > Reported-by: "kernelci.org bot" > Signed-off-by: Nicolas Saenz Julienne > --- Tested-by: Stefan Wahren Thanks

Re: [PATCH RFC V2] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
Hi Johannes, Am 29.09.19 um 16:12 schrieb Stefan Wahren: > The commit 2a38075cd0be ("nl80211: Add support for EDMG channels") > introduced a member to the cfg80211 channel definition. Unfortunately > the channel definitions are allocated on the stack and are not always >

[PATCH RFC V2] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
r, because cfg80211_chandef_valid() accesses uninitialized memory and fail. Fix this by init the remaining occurences with memset. Reported-by: Dmitry Osipenko Signed-off-by: Stefan Wahren Fixes: 2a38075cd0be ("nl80211: Add support for EDMG channels") --- net/mac80211/util.c| 1 + ne

[PATCH RFC] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
r, because cfg80211_chandef_valid() accesses uninitialized memory and fail. Fix this by init the remaining occurences with memset. Reported-by: Dmitry Osipenko Signed-off-by: Stefan Wahren --- net/mac80211/util.c| 1 + net/wireless/nl80211.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletio

Re: [PATCH] ieee802154: ca8210: prevent memory leak

2019-09-27 Thread Stefan Schmidt
of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-27 Thread Stefan Wahren
Hi Matthias, Am 17.09.19 um 20:03 schrieb Stefan Wahren: > Hi Matthias, > > Am 17.09.19 um 11:04 schrieb Matthias Brugger: >> On 16/09/2019 21:19, Stefan Wahren wrote: >>> Hi Matthias, >>> >>> [drop uninvolved receiver] >>> >>>

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-25 Thread Stefan Schmidt
Hello. On 24.09.19 23:40, Xue Liu wrote: On Sat, 21 Sep 2019 at 13:52, Stefan Schmidt wrote: Hello Xue. On 20.09.19 21:45, Christophe JAILLET wrote: Use a 'skb_put_data()' variant instead of rewritting it. The __skb_put_data variant is safe here. It is obvious that the skb can not overflow

Re: [PATCH] ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'

2019-09-21 Thread Stefan Schmidt
buf, len); > ieee802154_rx_irqsafe(lp->hw, skb, lp->rx_lqi[0]); > > print_hex_dump_debug("mcr20a rx: ", DUMP_PREFIX_OFFSET, 16, 1, > Could you please review and ACK this? If you are happy I will take it through my tree. regards Stefan Schmidt

[PATCH v2 2/2] dt-bindings: arm: fsl: Add PHYTEC i.MX6 devicetree bindings

2019-09-20 Thread Stefan Riedmueller
Add devicetree bindings for i.MX6 based phyCORE-i.MX6, phyBOARD-Mira and phyFLEX-i.MX6. Signed-off-by: Stefan Riedmueller --- Changes in v2: - Use seperate description for each board instead of squashing them into the standard board. --- Documentation/devicetree/bindings/arm/fsl.yaml | 37

[PATCH v2 1/2] dt-bindings: arm: fsl: Add PHYTEC i.MX6 UL/ULL devicetree bindings

2019-09-20 Thread Stefan Riedmueller
Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and phyBOARD-Segin. Signed-off-by: Stefan Riedmueller --- Changes in v2: - Use seperate description for each board instead of squashing them into the standard board. --- Documentation/devicetree/bindings/arm/fsl.yaml | 18

Re: [PATCH] ieee802154: ca8210: prevent memory leak

2019-09-19 Thread Stefan Schmidt
spi, pdata); > if (ret) { > dev_crit(_device->dev, "ca8210_get_platform_data failed\n"); > goto error; > } > - priv->spi->dev.platform_data = pdata; > > ret = ca8210_dev_com_init(priv); > if (ret) { > Could you review this patch for the ca8210 driver? regards Stefan Schmidt

Re: [PATCH] ieee802154: atusb: fix use-after-free at disconnect

2019-09-19 Thread Stefan Schmidt
done\n", __func__); > } > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks a lot for having a look at this! regards Stefan Schmidt

Re: [PATCH] fuse: unexport fuse_put_request

2019-09-19 Thread Stefan Hajnoczi
xes: 66abc3599c3c ("fuse: unexport request ops") > Signed-off-by: Arnd Bergmann > --- > fs/fuse/dev.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[PATCH] tty: serial: linflexuart: Fix magic SysRq handling

2019-09-18 Thread Stefan-gabriel Mirea
serial: Add linflexuart driver for S32V234") Signed-off-by: Stefan-Gabriel Mirea Reported-by: kbuild test robot Reported-by: Dan Carpenter --- drivers/tty/serial/fsl_linflexuart.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/fsl_

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-17 Thread Stefan Wahren
Hi Matthias, Am 17.09.19 um 11:04 schrieb Matthias Brugger: > > On 16/09/2019 21:19, Stefan Wahren wrote: >> Hi Matthias, >> >> [drop uninvolved receiver] >> >> Am 13.09.19 um 12:39 schrieb Matthias Brugger: >>>>>>> If you talk about th

Re: [PATCH v2 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples

2019-09-17 Thread Popa, Stefan Serban
On Du, 2019-09-15 at 14:27 +0100, Jonathan Cameron wrote: > > > > On Tue, 10 Sep 2019 17:43:32 +0300 > Stefan Popa wrote: > > > > > > > > > > > Currently, the driver sets the FIFO_SAMPLES register with the number of > > sample sets (

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-16 Thread Stefan Wahren
lot of my spare time to prepare these patch series in order to get a clean solution. Either mixing bcm2711/bcm2838 or changing everything to bcm2838 in the upstream tree has the following drawbacks: - additional review time and delay of the Raspberry Pi 4 support - harder to understand for develope

Re: [PATCH] staging: bcm2835-audio: Fix draining behavior regression

2019-09-15 Thread Stefan Wahren
ent to provide more context of the unexpected behavior? Nevertheless: Acked-by: Stefan Wahren > Cc: sta...@vger.kernel.org > Signed-off-by: Takashi Iwai > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++-- > drivers/staging/vc04_services/bcm2835-audi

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-14 Thread Stefan Lippers-Hollmann
Hi On 2019-09-14, Greg Kroah-Hartman wrote: > On Sat, Sep 14, 2019 at 02:54:11AM +0200, Stefan Lippers-Hollmann wrote: > > On 2019-09-13, Greg Kroah-Hartman wrote: > > > From: Michael S. Tsirkin > > > > > > commit a89db445fbd7f1f8457b03759aa7343fa530ef6b u

Re: [PATCH 5.2 36/37] vhost: block speculation of translated descriptors

2019-09-13 Thread Stefan Lippers-Hollmann
ed long)(addr - node->start), | ^~ make[3]: *** [/build/linux-5.2/scripts/Makefile.build:285: drivers/vhost/vhost.o] Error 1 make[2]: *** [/build/linux-5.2/scripts/Makefile.build:489: drivers/vhost] Error 2 make[1]: *** [/build/linux-5.2/Makefile:1072: drivers] Error 2 make: *** [/build/linux-5.2/Makefile:179: sub-make] Error 2 Regards Stefan Lippers-Hollmann

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-13 Thread Stefan Wahren
Am 13.09.19 um 11:25 schrieb Matthias Brugger: > > On 13/09/2019 10:50, Stefan Wahren wrote: >> Am 13.09.19 um 10:09 schrieb Matthias Brugger: >>> On 12/09/2019 21:32, Stefan Wahren wrote: >>>> Am 12.09.19 um 19:18 schrieb Matthias Brugger: >>>>

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-13 Thread Stefan Wahren
Am 13.09.19 um 10:09 schrieb Matthias Brugger: > > On 12/09/2019 21:32, Stefan Wahren wrote: >> Am 12.09.19 um 19:18 schrieb Matthias Brugger: >>> On 10/09/2019 11:27, Matthias Brugger wrote: >>>> On 09/09/2019 21:33, Stefan Wahren wrote: >>>>> Hi N

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-12 Thread Stefan Wahren
Am 12.09.19 um 19:18 schrieb Matthias Brugger: > > On 10/09/2019 11:27, Matthias Brugger wrote: >> >> On 09/09/2019 21:33, Stefan Wahren wrote: >>> Hi Nicolas, >>> >>> Am 09.09.19 um 11:58 schrieb Nicolas Saenz Julienne: >>>> Hi all,

Re: [PATCH v5 0/4] virtio-fs: shared file system for virtual machines

2019-09-12 Thread Stefan Hajnoczi
On Thu, Sep 12, 2019 at 10:14:11AM +0200, Miklos Szeredi wrote: > On Wed, Sep 11, 2019 at 5:54 PM Stefan Hajnoczi wrote: > > > > On Tue, Sep 10, 2019 at 05:12:02PM +0200, Miklos Szeredi wrote: > > > I've folded the series from Vivek and fixed a couple of TODO comments &

Re: [PATCH v5 0/4] virtio-fs: shared file system for virtual machines

2019-09-11 Thread Stefan Hajnoczi
hen locking fails. Live migration has the same problem since the FUSE session will be moved to a new virtio-fs device instance. It makes sense to tackle both features together. This is something that can be implemented in the next year, but it's not a quick fix. Stefan signature.asc Description: PGP signature

Re: [PATCH v5 0/4] virtio-fs: shared file system for virtual machines

2019-09-11 Thread Stefan Hajnoczi
gt; > I've folded the series from Vivek and fixed a couple of TODO comments > myself. AFAICS two issues remain that need to be resolved in the short > term, one way or the other: freeze/restore and full virtqueue. Thank you! I am investigating freeze/restore. Stefan signature.asc Description: PGP signature

[PATCH v2 3/3] iio: accel: adxl372: Perform a reset at start up

2019-09-10 Thread Stefan Popa
We need to perform a reset a start up to make sure that the chip is in a consistent state. This reset also disables all the interrupts which should only be enabled together with the iio buffer. Not doing this, was sometimes causing unwanted interrupts to trigger. Signed-off-by: Stefan Popa

[PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples

2019-09-10 Thread Stefan Popa
One in two sample sets was lost by multiplying fifo_set_size with sizeof(u16). Also, the double number of available samples were pushed to the iio buffers. Signed-off-by: Stefan Popa --- Changes in v2: - Nothing changed. drivers/iio/accel/adxl372.c | 3 +-- 1 file changed, 1 insertion

[PATCH v2 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples

2019-09-10 Thread Stefan Popa
-by: Stefan Popa --- Changes in v2: - st->watermark needs to store the number of sample sets, the total number of samples is computed in adxl372_configure_fifo() func. drivers/iio/accel/adxl372.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-09 Thread Stefan Wahren
Hi Nicolas, Am 09.09.19 um 11:58 schrieb Nicolas Saenz Julienne: > Hi all, > this series attempts to address some issues we found while bringing up > the new Raspberry Pi 4 in arm64 and it's intended to serve as a follow > up of these discussions: > v4: https://lkml.org/lkml/2019/9/6/352 > v3:

Re: [Virtio-fs] [PATCH 00/18] virtiofs: Fix various races and cleanups round 1

2019-09-09 Thread Stefan Hajnoczi
On Sun, Sep 08, 2019 at 07:53:55PM +0800, piaojun wrote: > > > On 2019/9/6 19:52, Miklos Szeredi wrote: > > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: > >> > >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > >>> On T

Re: [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path

2019-09-09 Thread Stefan Hajnoczi
On Fri, Sep 06, 2019 at 09:51:31AM -0400, Vivek Goyal wrote: > On Fri, Sep 06, 2019 at 01:05:34PM +0100, Stefan Hajnoczi wrote: > > On Thu, Sep 05, 2019 at 03:48:57PM -0400, Vivek Goyal wrote: > > > It is possible that a mount is in progress and device is being removed at > &

Re: [PATCH 15/18] virtiofs: Make virtio_fs object refcounted

2019-09-09 Thread Stefan Hajnoczi
On Fri, Sep 06, 2019 at 09:50:32AM -0400, Vivek Goyal wrote: > On Fri, Sep 06, 2019 at 01:03:09PM +0100, Stefan Hajnoczi wrote: > > On Thu, Sep 05, 2019 at 03:48:56PM -0400, Vivek Goyal wrote: > > > This object is used both by fuse_connection as well virt device. So make

Re: [PATCH 08/18] virtiofs: Drain all pending requests during ->remove time

2019-09-09 Thread Stefan Hajnoczi
On Fri, Sep 06, 2019 at 10:18:49AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 06, 2019 at 10:17:05AM -0400, Vivek Goyal wrote: > > On Fri, Sep 06, 2019 at 11:52:10AM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 05, 2019 at 03:48:49PM -0400, Vivek Goyal wrote: &g

Re: [PATCH 18/18] virtiofs: Remove TODO item from virtio_fs_free_devs()

2019-09-06 Thread Stefan Hajnoczi
nal locking yet. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 17/18] virtiofs: Remove TODO to quiesce/end_requests

2019-09-06 Thread Stefan Hajnoczi
gned-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path

2019-09-06 Thread Stefan Hajnoczi
nces. This is fine for now. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 15/18] virtiofs: Make virtio_fs object refcounted

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:56PM -0400, Vivek Goyal wrote: > This object is used both by fuse_connection as well virt device. So make > this object reference counted and that makes it easy to define life cycle > of the object. > > Now deivce can be removed while filesystem is still mounted.

Re: [PATCH 14/18] virtiofs: Add a fuse_iqueue operation to put() reference

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:55PM -0400, Vivek Goyal wrote: > diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h > index 85e2dcad68c1..04e2c000d63f 100644 > --- a/fs/fuse/fuse_i.h > +++ b/fs/fuse/fuse_i.h > @@ -479,6 +479,11 @@ struct fuse_iqueue_ops { >*/ > void

Re: [PATCH 13/18] virtiofs: Do not access virtqueue in request submission path

2019-09-06 Thread Stefan Hajnoczi
pointer deference. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 12/18] virtiofs: Use virtio_fs_free_devs() in error path

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:53PM -0400, Vivek Goyal wrote: > We already have an helper to cleanup fuse devices. Use that instead of > duplicating the code. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 11/18] virtiofs: stop and drain queues after sending DESTROY

2019-09-06 Thread Stefan Hajnoczi
me > just to be sure and then free up the devices. > > Given drain queues will call flush_work() on various workers, remove this > logic from virtio_free_devs(). > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 11 --- > 1 file changed, 8 insertions(+),

Re: [PATCH 10/18] virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vq

2019-09-06 Thread Stefan Hajnoczi
st reference to object is dropped. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 09/18] virtiofs: Add an helper to start all the queues

2019-09-06 Thread Stefan Hajnoczi
eletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 08/18] virtiofs: Drain all pending requests during ->remove time

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:49PM -0400, Vivek Goyal wrote: > +static void virtio_fs_drain_queue(struct virtio_fs_vq *fsvq) > +{ > + WARN_ON(fsvq->in_flight < 0); > + > + /* Wait for in flight requests to finish.*/ > + while (1) { > + spin_lock(>lock); > + if

Re: [PATCH 06/18] virtiofs: ->remove should not clean virtiofs fuse devices

2019-09-06 Thread Stefan Hajnoczi
ld > stop queues and virtuques can go away. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

<    2   3   4   5   6   7   8   9   10   11   >