[PATCH v2 0/2] mfd: rk808: Fix pointers and poweroff

This patch is actually follow-up to: [PATCH 1/1] mfd: rk808: Prepare rk8085 for poweroff The patchset fixes poweroff function for boards with RK8085 PMU. During the preparation of v2 possible wrong pointer access was spot (pm_power_off), so one more patch was introduced in the series. Stefan

[PATCH v2 2/2] mfd: rk808: Prepare rk805 for poweroff

. The solution is to enable pm_power_off_prepare function, which will configure SLEEP pin for OFF function. Signed-off-by: Stefan Mavrodiev --- Changes for v2: - Move pm_pwroff_prep_fn to header - Check pm_power_off_prepare before make it NULL drivers/mfd/rk808.c | 29

Re: [PATCH] MAINTAINERS: Update Stefan Wahren email address

Hi Florian, Am 01.05.19 um 21:47 schrieb Stefan Wahren: > I2SE has been acquired, so i decided to use my private address now. > > Signed-off-by: Stefan Wahren should i send a pull request or can you pick it up directly? > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insert

Re: [RFC v2 4/5] dts: bcm2837: add per-cpu clock devices

Hi Nicolas, On 20.05.19 12:47, Nicolas Saenz Julienne wrote: > The four CPUs share a same clock source called pllb_arm. The clock can > be scaled through the raspberrypi firmware interface. do you see a problem with applying this also to bcm2835.dtsi and bcm2836.dtsi?

Re: [RFC v2 5/5] cpufreq: add driver for Raspbery Pi

On 20.05.19 12:47, Nicolas Saenz Julienne wrote: > Raspberry Pi's firmware offers and interface though which update it's > performance requirements. It allows us to request for specific runtime > frequencies, which the firmware might or might not respect, depending on > the firmware configuration

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

On 20.05.19 14:11, Stefan Wahren wrote: > > Please verify that the kernel still works (and this clock driver probe) > under the following conditions: > > - CONFIG_RASPBERRYPI_FIRMWARE=n > - CONFIG_RASPBERRYPI_FIRMWARE=m > - older DTBs without patch #1 Sorry, i meant patch #4

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

> .flags = CLK_GET_RATE_NOCACHE, > - > - .ana = _ana_default, > - > - .min_rate = 6u, > - .max_rate = 30u, > - .max_fb_rate = BCM2835_MAX_FB_RATE), > + .rate_rescale = 2, > + .firmware_clk_id = RPI_FIRMWARE_ARM_CLK_ID), > [BCM2835_PLLB_ARM] = REGISTER_PLL_DIV( > .name = "pllb_arm", > .source_pll = "pllb", > @@ -2133,9 +2361,24 @@ static int bcm2835_clk_probe(struct platform_device > *pdev) > struct resource *res; > const struct bcm2835_clk_desc *desc; > const size_t asize = ARRAY_SIZE(clk_desc_array); > + struct device_node *firmware_node; > + struct rpi_firmware *firmware; > size_t i; > int ret; > > + firmware_node = of_find_node_by_name(NULL, "firmware"); I prefer of_find_compatible_node() which is more specific. > + if (!firmware_node) { > + dev_err(dev, "Missing firmware node\n"); > + return -ENOENT; > + } The firmware node should be optional for the driver. > + > + firmware = rpi_firmware_get(firmware_node); > + of_node_put(firmware_node); > + if (!firmware) { > + dev_err(dev, "Can't get raspberrypi's firmware\n"); For in case the driver for the Raspberry Pifirmware is enabled, we shouldn't spam with errors here. Stefan

Re: [RFC v2 2/5] clk: bcm2835: set pllb_arm divisor as readonly

On 20.05.19 12:47, Nicolas Saenz Julienne wrote: > This divisor is controlled by the firmware, we don't want the clock > subsystem to update it inadvertently. > > Signed-off-by: Nicolas Saenz Julienne Acked-by: Stefan Wahren

Re: [RFC v2 1/5] clk: bcm2835: set CLK_GET_RATE_NOCACHE on CPU clocks

On 20.05.19 12:47, Nicolas Saenz Julienne wrote: > Raspberry Pi's firmware is responsible for updating the cpu clocks and > pll. This makes sure we get the right rates anytime. > > Signed-off-by: Nicolas Saenz Julienne Acked-by: Stefan Wahren

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

On Fri, May 17, 2019 at 10:25:05AM +0200, Stefano Garzarella wrote: > On Thu, May 16, 2019 at 04:25:33PM +0100, Stefan Hajnoczi wrote: > > On Fri, May 10, 2019 at 02:58:36PM +0200, Stefano Garzarella wrote: > > > +static struct virtio_vsock_buf * > > > +virtio

[PATCH v2 2/3] media: dvbsky: Remove duplicate error reporting for dvbsky_usb_generic_rw

Errors are already reported by the common code in dvb_usb_v2_generic_io (which dvbsky_usb_generic_rw is a wrapper of), so there is no reason report the error again. Signed-off-by: Stefan Brüns --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 11 --- 1 file changed, 11 deletions(-) diff

[PATCH v2 1/3] media: dvb-usb-v2: Report error on all error paths

, and ret is returned. Skip setting ret and return immediately (no cleanup necessary). Signed-off-by: Stefan Brüns --- drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c b/drivers

[PATCH v2 0/3] Cleanup error reporting

and af9035. v2: Add Signed-off-by Stefan Brüns (3): media: dvb-usb-v2: Report error on all error paths media: dvbsky: Remove duplicate error reporting for dvbsky_usb_generic_rw media: af9035: Remove duplicate error reporting for dvbsky_usb_generic_rw drivers/media/usb/dvb-usb-v

[PATCH v2 3/3] media: af9035: Remove duplicate error reporting for dvbsky_usb_generic_rw

All error cases inside the function already report errors via dev_err(), and dvb_usb_v2_generic_rw also reports all error cases, so there is no silent code path when an error has occured. Signed-off-by: Stefan Brüns --- drivers/media/usb/dvb-usb-v2/af9035.c | 2 -- 1 file changed, 2 deletions

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

On 16.05.19 18:11, Stefan Wahren wrote: > Hi Linus, > > On 16.05.19 17:07, Linus Torvalds wrote: >> On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin wrote: >>> - thermal core has a new devm_* API for registering cooling devices, thanks >>> to Guenter

Re: [PATCH v2] Staging: bcm2835-camera: Prefer kernel types

Am 16.05.2019 um 23:33 schrieb Madhumitha Prabakaran: Fix the warning issued by checkpatch Prefer kernel type 'u32' over 'uint32_t'. Along with that include a blank line after a declaration to maintain Linux kernel coding style. Signed-off-by: Madhumitha Prabakaran Acked-by: Stefan Wahren

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

ution that meshed with > the new devm cleanup model, but while I build-tested the result, I > obviously did no actual use testing. And maybe there's some reason why > that approach is flawed. i will try to test on our custom i.MX6 board. Unfortunately this take some ti

Re: [PATCH v2 12/30] dax: remove block device dependencies

On Wed, May 15, 2019 at 05:21:51PM -0700, Dan Williams wrote: > On Wed, May 15, 2019 at 12:28 PM Vivek Goyal wrote: > > > > From: Stefan Hajnoczi > > > > Although struct dax_device itself is not tied to a block device, some > > DAX code assumes there is a

[PATCH 1/2] iio: frequency: adf4371: Add support for ADF4371 PLL

/adf4371.pdf Signed-off-by: Stefan Popa --- drivers/iio/frequency/Kconfig | 10 + drivers/iio/frequency/Makefile | 1 + drivers/iio/frequency/adf4371.c | 573 3 files changed, 584 insertions(+) create mode 100644 drivers/iio/frequency/adf4371.c diff

[PATCH 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL

Document support for Analog Devices ADF4371 SPI Wideband Synthesizer. Signed-off-by: Stefan Popa --- .../devicetree/bindings/iio/frequency/adf4371.yaml | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/frequency/adf4371.yaml

Re: [PATCH] Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'

d name the patch like staging: bcm2835-camera: prefer kernel types Regards Stefan > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/st

Re: [PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()"

mainly used as an interface to V4L2 and ALSA devices. > > Fixes: ff5979ad8636 ("staging: vchiq_2835_arm: quit using custom > down_interruptible()") > Signed-off-by: Nicolas Saenz Julienne This whole series is: Acked-by: Stefan Wahren

Re: [PATCH 3/3] pinctrl: bcm2835: bcm7211: Add support for 7211 pull-up functionality

Hi Florian, On 09.05.19 22:59, Florian Fainelli wrote: > From: Al Cooper > > The 7211 has a new way of selecting the pull-up/pull-down setting > for a GPIO pin. The registers used for the bcm2837, GP_PUD and > GP_PUDCLKn0, are no longer connected. A new set of registers, >

Re: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

nused Value") > Signed-off-by: Colin Ian King Acked-by: Stefan Wahren

Re: [PATCH v2 00/10] RFC: NVME MDEV

e same time as VMs, but I'm not sure that's useful in performance-critical use cases and for non-performance use cases this driver isn't necessary. Stefan signature.asc Description: PGP signature

Re: [PATCH v2 0/3] staging: vchiq: use interruptible waits

arm/vchiq_arm.c | 21 +++-- > .../interface/vchiq_arm/vchiq_core.c | 31 --- > .../interface/vchiq_arm/vchiq_util.c | 6 ++-- > 4 files changed, 35 insertions(+), 25 deletions(-) > against which tree should this series apply? Since the merge window opened the current staging-linus wont be available soon. Stefan

Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

fix it. i also agree with Dan, but this specific patch should revert the changes of a772f116702e3f0afdd7e6acadc1b8fb3b20b9ff . So mentioned style issue should be fixed in a separate patch. Regards Stefan > > Regards, > Nicolas > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] MAINTAINERS: Update Stefan Wahren email address

I2SE has been acquired, so i decided to use my private address now. Signed-off-by: Stefan Wahren --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2c7d4e1..75a7876 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3068,7 +3068,7

Re: [PATCH v3] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

d by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran Acked-by: Stefan Wahren

Re: [PATCH] staging: vc04_services: bcm2835-camera: Modify return statement.

Am 27.04.19 um 18:07 schrieb Vatsala Narang: > Modify return statement and remove the respective assignment. > > Issue found by Coccinelle. > > Signed-off-by: Vatsala Narang Acked-by: Stefan Wahren

Re: [v8 09/10] arm64: add sysfs vulnerability show for speculative store bypass

now the firmware isn't responding to avoid a case > where we miss the whitelist, but the firmware goes ahead and > reports the core is not vulnerable. If all the cores in the > machine have SSBS, then __ssb_safe will remain true. > > Signed-off-by: Jeremy Linton Tested-by: Stefan Wahren on a Raspberry Pi 3 B

Re: Kconfig dependency issue on function-graph tracer and frame pointer on arm

n >> still choose either option irrespective of the state of the function >> graph tracer. They should only be able to select the frame pointer >> option in that case. >> >> Another way forward would be for someone to put the work in to making >> the function graph

Re: [PATCH v3 1/4] ARM: use arch_extension directive instead of arch argument

On 11.04.2019 09:54, Stefan Agner wrote: > The LLVM Target parser currently does not allow to specify the security > extension as part of -march (see also LLVM Bug 40186 [0]). When trying > to use Clang with LLVM's integrated assembler, this leads to build > errors such as this: >

Re: [PATCH] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

dev->instance, encoder_out, > - mmal_ctrl->mmal_id, > - >val, sizeof(ctrl->val)); > - ret = 0; > - return ret; > + return 0; i don't understand why we can remove here the function call. Stefan > } > > static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,

Re: [PATCH V2] staging: vc04_services: handle kzalloc failure

re so checks for != VCHIQ_SUCCESS > and pass VCHIQ_ERROR up to vchiq_platform_init() which then > will fail with -EINVAL. > > Signed-off-by: Nicholas Mc Guire > Reported-by: kbuild test robot > --- Acked-By: Stefan Wahren

[PATCH] mtd: rawnand: use longest matching pattern

->DATA_IN [64 B] Reported-by: Sascha Hauer Suggested-by: Boris Brezillon Tested-by: Stefan Agner Signed-off-by: Stefan Agner --- drivers/mtd/nand/raw/nand_base.c | 50 +++- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/mtd/nand/raw/nand

Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure

CHIQ_SUCCESS > and pass VCHIQ_ERROR up to vchiq_platform_init() which then > will fail with -EINVAL. > > Signed-off-by: Nicholas Mc Guire Acked-by: Stefan Wahren

[PATCH v3 3/4] ARM: mvebu: drop unnecessary label

-by: Stefan Agner Acked-by: Nicolas Pitre --- arch/arm/mach-mvebu/pmsu_ll.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-mvebu/pmsu_ll.S b/arch/arm/mach-mvebu/pmsu_ll.S index 88651221dbdd..c1fb713e9306 100644 --- a/arch/arm/mach-mvebu/pmsu_ll.S +++ b/arch/arm/mach-mvebu/pmsu_ll.S

[PATCH v3 2/4] ARM: OMAP2: drop explicit assembler architecture

OMAP2 depends on ARCH_MULTI_V6, which makes sure that the kernel is compiled with -march=armv6. The compiler frontend will pass the architecture to the assembler. There is no explicit architecture specification necessary. Signed-off-by: Stefan Agner --- Changes since v2: - New patch arch/arm

[PATCH v3 1/4] ARM: use arch_extension directive instead of arch argument

is available since binutils 2.21 according to its documentation [1]. [0] https://bugs.llvm.org/show_bug.cgi?id=40186 [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html Signed-off-by: Stefan Agner Acked-by: Mans Rullgard Acked-by: Arnd Bergmann Acked-by: Krzysztof Kozlowski --

[PATCH v3 4/4] ARM: mvebu: prefix coprocessor operand with p

, cr0, cr0, 5 ^ arch/arm/mach-mvebu/pmsu_ll.S:19:6: error: invalid operand for instruction mrc 15, 0, r0, cr0, cr0, 5 @ get the CPU ID ^ Signed-off-by: Stefan Agner Acked-by: Nicolas Pitre --- arch/arm/mach-mvebu/coherency_ll.S | 2 +- arch/arm/mach-mvebu/pmsu_ll.S | 2 +- 2

[PATCH] ARM: imx: use generic function to exit coherency

-by: Stefan Agner Signed-off-by: Stefan Agner --- arch/arm/mach-imx/hotplug.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/arch/arm/mach-imx/hotplug.c b/arch/arm/mach-imx/hotplug.c index b35e99cc5e5b..7a74a9b89a49 100644 --- a/arch/arm/mach-imx

Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

On 09.04.2019 16:50, Tony Lindgren wrote: > Hi, > > * Stefan Agner [190408 20:59]: >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -41,11 +41,6 @@ obj-$(CONFIG_SOC_OMAP5) += >> $(omap-4-5-com

Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

On 09.04.2019 14:25, Måns Rullgård wrote: > Stefan Agner writes: > >> The LLVM Target parser currently does not allow to specify the security >> extension as part of -march (see also LLVM Bug 40186 [0]). When trying >> to use Clang with LLVM's integrated assembler, this

Re: [PATCH v1 1/1] ARM: dts: colibri/apalis: convert to SPDX license tags

si Also can you split this in two patches: One for NXP SoC's and one for the Tegra's? Maybe we should actually harmonize and use the same license everywhere... However, I'd rather prefer to do this in a separate patch after this mechanical change. -- Stefan > 20 files changed, 35 insertions

Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

On 09.04.2019 14:25, Måns Rullgård wrote: > Stefan Agner writes: > >> The LLVM Target parser currently does not allow to specify the security >> extension as part of -march (see also LLVM Bug 40186 [0]). When trying >> to use Clang with LLVM's integrated assembler, this

RE: [PATCH V2 2/5] can: flexcan: add CAN FD mode support

> From: Joakim Zhang > Sent: Tuesday, April 9, 2019 5:07 AM > Hi Stefan, > > Thanks for your validation! Could you add your test tag if you can > successfully validated? Sure, no problem. Please note that I needed to replace "flexcan_read" and "flexcan_write&qu

Re: [PATCH 05/22] watchdog: bcm2835_wdt: drop platform_set_drvdata

emantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: Eric Anholt > Cc: Stefan Wahren > Si

[PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

is available since binutils 2.21 according to its documentation [1]. [0] https://bugs.llvm.org/show_bug.cgi?id=40186 [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html Signed-off-by: Stefan Agner Acked-by: Mans Rullgard Acked-by: Arnd Bergmann Acked-by: Krzysztof Kozlowski --

[PATCH v2 2/3] ARM: mvebu: drop unnecessary label

-by: Stefan Agner Acked-by: Nicolas Pitre --- arch/arm/mach-mvebu/pmsu_ll.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-mvebu/pmsu_ll.S b/arch/arm/mach-mvebu/pmsu_ll.S index 88651221dbdd..c1fb713e9306 100644 --- a/arch/arm/mach-mvebu/pmsu_ll.S +++ b/arch/arm/mach-mvebu/pmsu_ll.S

[PATCH v2 3/3] ARM: mvebu: prefix coprocessor operand with p

, cr0, cr0, 5 ^ arch/arm/mach-mvebu/pmsu_ll.S:19:6: error: invalid operand for instruction mrc 15, 0, r0, cr0, cr0, 5 @ get the CPU ID ^ Signed-off-by: Stefan Agner Acked-by: Nicolas Pitre --- arch/arm/mach-mvebu/coherency_ll.S | 2 +- arch/arm/mach-mvebu/pmsu_ll.S | 2 +- 2

Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument

On 31.03.2019 19:34, Arnd Bergmann wrote: > On Sun, Mar 24, 2019 at 3:06 AM Arnd Bergmann wrote: >> >> On Sat, Mar 23, 2019 at 4:52 PM Stefan Agner wrote: >> > >> > The LLVM Target parser currently does not allow to specify the security >> > extension

Re: [PATCH RFC 0/4] vsock/virtio: optimizations to increase the throughput

ecause it's simple. But there's no need for the guest to enqueue multiple VIRTIO_VSOCK_OP_RW packets when a single large packet could combine all payloads for a connection. This is not the same as TCP_NODELAY but related. I think it's worth exploring TCP_NODELAY and send_pkt_list merging. Hopefully it won't make the code much more complicated. Stefan signature.asc Description: PGP signature

Re: [PATCH 3/3] staging: vchiq: make wait events interruptible

Am 05.04.19 um 13:34 schrieb Nicolas Saenz Julienne: > The killable version of wait_event() is meant to be used on situations > where it's not meant to fail at all costs, but still have the convenience > of being able to kill it if really necessary. For instance it's used > while waiting on an

Re: [PATCH 0/3] staging: vchiq: use interruptible waits

tage this driver, we'd really need a proper justification for using > the killable family of functions. Which I think it's not really clear at > the moment. I like to see this decision as a short comment in the code to prevent other for doing this mistake again. Thanks Stefan > > As Raspbia

Re: [PATCH] vhost/vsock: initialize vhost_vsock->hash

v_open(struct inode *inode, > struct file *file) > spin_lock_init(>send_pkt_list_lock); > INIT_LIST_HEAD(>send_pkt_list); > vhost_work_init(>send_pkt_work, vhost_transport_send_pkt_work); > + INIT_HLIST_NODE(>hash); > return 0; > > o

Re: [PATCH] dmaengine: bcm2835: Drop duplicate capability setting.

Am 04.04.19 um 19:25 schrieb Michal Suchanek: > Signed-off-by: Michal Suchanek Except of the point there is no commit log: Acked-by: Stefan Wahren > --- > drivers/dma/bcm2835-dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers

Re: [PATCH] staging: vchiq_arm: remove space after open '('

Am 03.04.19 um 05:07 schrieb Mario Balan: > Fix checkpatch error "ERROR: space prohibited after that open > parenthesis '('" in vchiq_arm.c:563. > > Signed-off-by: Mario Balan Acked-by: Stefan Wahren

[PATCH V4 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan

This adds the tachometer interrupt to the pwm-fan binding, which is necessary for RPM support. Signed-off-by: Stefan Wahren Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files

it up easily. > > Cc: Eric Anholt > Cc: Stefan Wahren > Cc: Tuomas Tynkkynen > Cc: Aymen Qader > Cc: "Tobias Büttner" > Cc: Dominic Braun > Cc: Nicolas Saenz Julienne > Cc: Alejandro Ismael Silva > Cc: Phil Elwell > Cc: Luis Chamberlain > Cc: Arnd

Re: [PATCH 06/16] staging: vc04_services: remove remaining redundant license text

done on a quest to remove the 700+ different ways that files in > the kernel describe the license text. > > No copyright headers or other non-license-description text was removed. > > Cc: Eric Anholt > Cc: Stefan Wahren > Cc: Tuomas Tynkkynen > Cc: Aymen Qader > Cc: &

Re: [PATCH] vhost: zero vhost_vsock memory on allocation

On Wed, Mar 27, 2019 at 01:08:53PM -0400, Vitaly Mayatskih wrote: > On Wed, Mar 27, 2019 at 12:49 PM Stefan Hajnoczi wrote: > > > Which field was accessed before initialization? > > > > I ask because the situation is now unclear since code remains that > > assumes v

Re: [PATCH v2] MAiNTAINERS: add Paolo, Stefan for virtio blk/scsi

- use R tag for new reviewers > - readd Jason as M > > MAINTAINERS | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH] vhost: zero vhost_vsock memory on allocation

On Tue, Mar 26, 2019 at 08:56:14PM -0400, Vitaly Mayatskikh wrote: > This fixes OOPS when using under-initialized vhost_vsock object. > > The code had a combo of kzalloc plus vmalloc as a fallback > initially, but it has been replaced by plain kvmalloc in > commit 6c5ab6511f71 ("mm: support

[PATCH v2] MAINTAINERS: Fix the link to ad7606 dt-bindings

The devicetree bindings documentation for ad7606 should also include the vendor prefix: ad7606.txt -> adi,ad7606.txt Fixes: 6e33a125df66 ("dt-bindings: iio: adc: Add docs for AD7606 ADC") Signed-off-by: Stefan Popa --- Changes in v2: - Added Fixes tag MAINTAINERS | 2 +- 1

[PATCH] MAINTAINERS: Fix the link to ad7606 dt-bindings

The devicetree bindings documentation for ad7606 should also include the vendor prefix: ad7606.txt -> adi,ad7606.txt Signed-off-by: Stefan Popa --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ff2c2f2..4f81cdc 100

Re: [PATCH 0/9] RFC: NVME VFIO mediated device [BENCHMARKS]

> interrupts sent : avg cycles: 590.227 avg time(usec): 0.174 > > avg time total: 0.413 usec > > All measurmenets done in the host kernel. the time calculated using tsc_khz > kernel variable. > > The biggest take from this is that both spdk and my driver are very fast and > overhead is just a thousand of cpu cycles give it or take. Nice! Stefan signature.asc Description: PGP signature

Re: your mail

On Thu, Mar 21, 2019 at 07:07:38PM +0200, Maxim Levitsky wrote: > On Thu, 2019-03-21 at 16:13 +0000, Stefan Hajnoczi wrote: > > On Tue, Mar 19, 2019 at 04:41:07PM +0200, Maxim Levitsky wrote: > > > Date: Tue, 19 Mar 2019 14:45:45 +0200 > > > Subject: [PATCH 0/9] RFC

Re: [PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

struct vchiq_2835_state *platform_state; > > state->platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL); > + if (!state->platform_state) > + return VCHIQ_ERROR; this change is good, but vchiq_init_state doesn't bail out immediately in cas

Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument

On 23.03.2019 21:06, Arnd Bergmann wrote: > On Sat, Mar 23, 2019 at 4:52 PM Stefan Agner wrote: >> >> The LLVM Target parser currently does not allow to specify the security >> extension as part of -march (see also LLVM Bug 40186 [0]). When trying >> to use Clang with

[PATCH 3/3] ARM: mvebu: prefix coprocessor operand with p

, cr0, cr0, 5 ^ arch/arm/mach-mvebu/pmsu_ll.S:19:6: error: invalid operand for instruction mrc 15, 0, r0, cr0, cr0, 5 @ get the CPU ID ^ Signed-off-by: Stefan Agner --- arch/arm/mach-mvebu/coherency_ll.S | 2 +- arch/arm/mach-mvebu/pmsu_ll.S | 2 +- 2 files changed, 2

[PATCH 2/3] ARM: mvebu: drop unnecessary label

-by: Stefan Agner --- arch/arm/mach-mvebu/pmsu_ll.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-mvebu/pmsu_ll.S b/arch/arm/mach-mvebu/pmsu_ll.S index 88651221dbdd..c1fb713e9306 100644 --- a/arch/arm/mach-mvebu/pmsu_ll.S +++ b/arch/arm/mach-mvebu/pmsu_ll.S @@ -56,7 +56,6 @@ ENDPROC

[PATCH 1/3] ARM: use arch_extension directive instead of arch argument

llvm.org/show_bug.cgi?id=40186 [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html Signed-off-by: Stefan Agner --- arch/arm/mach-bcm/Makefile | 3 --- arch/arm/mach-bcm/bcm_kona_smc.c | 2 -- arch/arm/mach-exynos/Makefile | 4 arch/arm/mach-exynos/exynos-smc.S | 2 +-

Re: [PATCH] regulator: rn5t618: Constify regulator_desc

On 20.03.2019 13:10, Axel Lin wrote: > The regulator_desc never need to be modified, so define them as const as a > hint to the compiler that they can go into .rodata. > > Signed-off-by: Axel Lin Looks good to me. Reviewed-by: Stefan Agner -- Stefan > --- > drivers

Re: [PATCH v6 10/10] arm64: enable generic CPU vulnerabilites support

off-by: Jeremy Linton > Reviewed-by: Andre Przywara > Tested-by: Stefan Wahren FWIW i tested the series on top of today's linux-next with RPi 3B+ and it's still fine. Stefan

Re: your mail

e and provide > more formal performance numbers. > > Latency numbers: > ~80ms - spdk with fio plugin on the host. > ~84ms - nvme driver on the host > ~87ms - mdev-nvme + nvme driver in the guest You mentioned the spdk numbers are with vhost-user-nvme. Have you measured SPDK's vhost-user-blk? Stefan signature.asc Description: PGP signature

Re:

o support > migration while beeing able to run on top both SR-IOV device, my vfio-nvme > abit > with double admin queue emulation (its a bit ugly but won't affect performance > at all) and on top of even regular NVME device vfio assigned to guest. mdev-nvme seems like a duplication of SPDK. The performance is not better and the features are more limited, so why focus on this approach? One argument might be that the kernel NVMe subsystem wants to offer this functionality and loading the kernel module is more convenient than managing SPDK to some users. Thoughts? Stefan signature.asc Description: PGP signature

Re: [PATCH 7/9] nvme/core: add mdev interfaces

On Tue, Mar 19, 2019 at 04:41:14PM +0200, Maxim Levitsky wrote: > +int nvme_core_register_mdev_driver(struct nvme_mdev_driver *driver_ops) > +{ > + struct nvme_ctrl *ctrl; > + > + if (mdev_driver_interface) > + return -EEXIST; > + > + mdev_driver_interface = driver_ops;

Re: [PATCH v2 1/2] ARM: drop WASM to work around LLVM issue

On 18.03.2019 19:09, Nick Desaulniers wrote: > On Sun, Mar 17, 2019 at 4:05 PM Stefan Agner wrote: >> >> Currently LLVM's integrated assembler does not recognize .w form >> of the pld instructions (LLVM Bug 40972 [0]): >> >> ./arch/arm/include/asm/processor.h:

Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding

roller's registers. > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a > description of the cells format. It seems that the driver supports polarity. Can we use 3 cells so we can specify the polarity in the device tree? Also use 3 cells in the base device tree to enable other boards

[PATCH v2 2/2] ARM: drop -mauto-it

to -mauto-it and use -mimplicit-it=always only. [0] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=529707530657a333a304c651c808ea630c955223 Signed-off-by: Stefan Agner Reviewed-by: Nick Desaulniers --- Changes in v2: - Drop $(comma) since we are no longer use the call to as-option

[PATCH v2 1/2] ARM: drop WASM to work around LLVM issue

ended when compiling an Thumb-2 kernel. Drop the macro to work around LLVM Bug 40972 issue. [0] https://bugs.llvm.org/show_bug.cgi?id=40972 Signed-off-by: Stefan Agner --- Changes in v2: - Reword commit message to reflect the fact that this is a work around for LLVM. arch/arm/include/asm/proce

Re: [PATCH 1/2] ARM: drop unnecessary WASM

On 06.03.2019 01:47, Nick Desaulniers wrote: > On Tue, Mar 5, 2019 at 3:39 PM Robin Murphy wrote: >> >> Hi Stefan, >> >> On 2019-03-05 10:18 pm, Stefan Agner wrote: >> > The W macro for generating wide instructions when targeting Thumb-2 >> > is not re

Re: [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree

ent SoC's. I have a couple of SD cards with various rootfs and use internal eMMC boot quite often as well. Remembering which board uses which numbering is a pain. Maintaining a patch is just easier... Furthermore, U-Boot allows reordering and all boards I deal with use mmc 0 for the internal eMMC. The aliases allow consistency. -- Stefan

Re: [PATCH] iio: adc: fix indentation issue, remove extra tab

On Jo, 2019-03-14 at 23:26 +, Colin King wrote: > [External] > > > From: Colin Ian King > > A return statement is indented one level too deeply; clean this > up by removing a tab. > > Signed-off-by: Colin Ian King Acked-by: Stefan Popa Thanks! > --- &

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

On 14.03.19 14:14, Matthias Brugger wrote: On 14/03/2019 12:37, Armando Miraglia wrote: Absolutely! Please don't top post :) Cheers, A. On Thu, Mar 14, 2019 at 12:36 PM Stefan Roese wrote: [...] Would it be possible for you to wait a bit with this minor cleanup? As I'm preparing

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

I'm preparing a patch to move this driver out of staging right now. You can definitely follow-up with your cleanup, once this move is done. Otherwise the move might be delayed even more. Thanks, Stefan

Re: [PATCH] firewire: mark expected switch fall-throughs

ers/firewire/core-topology.c > index 7db234d3fbdd..82c67e900aad 100644 > --- a/drivers/firewire/core-topology.c > +++ b/drivers/firewire/core-topology.c > @@ -67,6 +67,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count, > int *child_port_count) > switch (port_type) { >

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

out of staging into drivers/spi very shortly. Thanks, Stefan

[PATCH v2 2/2] dt-bindings: iio: imu: adis16480: Document external clock

pin which is used as external clock input is selected by using a custom optional property called "adi,ext-clk-pin". If this field is left empty, DIO2 is assigned as default external clock input pin. Signed-off-by: Stefan Popa --- Changes in v2: - Mentioned that both "clocks&

[PATCH v2 1/2] iio: imu: adis16480: Add support for external clock

one function at a time (data ready line selection or external clock input). Signed-off-by: Stefan Popa --- Changes in v2: - used ADIS16480_DRDY_SEL() macro when checking for external clock input pin. drivers/iio/imu/adis16480.c | 186 ++

Re: [PATCH] arm64: bcm2835: Add missing dependency on MFD_CORE.

an > MFD.") > Signed-off-by: Eric Anholt > Reported-by: Stefan Wahren Acked-by: Stefan Wahren

Re: [PATCH v2] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

fb_sys_fops virtio_net psmouse drm net_failover pata_acpi > virtio_blk failover floppy > > Fixes: 22b5c0b63f32 ("vsock/virtio: fix kernel panic after device hot-unplug") > Reported-by: Alexandru Herghelegiu > Signed-off-by: Adalbert Lazăr > Co-developed-by: Stefan Hajnoczi > --- > net/vmw_vsock/virtio_transport_common.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) Excellent, thanks! Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[PATCH 2/2] dt-bindings: iio: imu: adis16480: Document external clock

pin which is used as external clock input is selected by using a custom optional property called "adi,ext-clk-pin". If this field is left empty, DIO2 is assigned as default external clock input pin. Signed-off-by: Stefan Popa --- .../devicetree/bindings/iio/imu/adi,adis16480.txt | 34 +

[PATCH 1/2] iio: imu: adis16480: Add support for external clock

one function at a time (data ready line selection or external clock input). Signed-off-by: Stefan Popa --- drivers/iio/imu/adis16480.c | 186 ++-- 1 file changed, 179 insertions(+), 7 deletions(-) diff --git a/drivers/iio/imu/adis16480.c b/drivers/ii

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

On Wed, Mar 06, 2019 at 11:10:41AM +0200, Adalbert Lazăr wrote: > On Wed, 6 Mar 2019 08:41:04 +0000, Stefan Hajnoczi wrote: > > On Tue, Mar 05, 2019 at 08:01:45PM +0200, Adalbert Lazăr wrote: > > The pkt argument is the received packet that we must reply to. > > The reply pac

Re: [PATCH] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

o read like this: struct virtio_vsock_pkt *reply; ... -- avoid reusing 'pkt' v reply = virtio_transport_alloc_pkt(, 0, ...); if (!reply) return -ENOMEM; t = virtio_transport_get_ops(); if (!t) { virtio_transport_free_pkt(reply); <-- prevent memory leak retu

Re: [PATCH 1/2] ARM: drop unnecessary WASM

On 06.03.2019 00:39, Robin Murphy wrote: > Hi Stefan, > > On 2019-03-05 10:18 pm, Stefan Agner wrote: >> The W macro for generating wide instructions when targeting Thumb-2 >> is not required for the preload data instructions (pld, pldw) since >> they are only ava

Re: [PATCH 2/2] ARM: drop -mauto-it

On 05.03.2019 23:21, Nick Desaulniers wrote: > On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner wrote: >> >> The assembler option -mauto-it is no longer a valid option. It has >> been removed from the documentation in July 2009, which is well >> before the release date

[PATCH 2/2] ARM: drop -mauto-it

The assembler option -mauto-it is no longer a valid option. It has been removed from the documentation in July 2009, which is well before the release date of the currently supported binutils version 2.20. Signed-off-by: Stefan Agner --- arch/arm/Makefile | 3 +-- 1 file changed, 1 insertion

<    5   6   7   8   9   10   11   12   13   14   >