[PATCH] kbuild: allow to use GCC toolchain not in Clang search path

2018-09-17 Thread Stefan Agner
-off-by: Stefan Agner --- Nick, I removed your Reviewed-by since I had to change variable assignment slightly... Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 4d5c883a98e5..d5de2db4b549 100644 --- a/Makefile +++ b/Makefile @@ -495,13

Re: [PATCH] iio: adc: max9611: Avoid implicit enum conversion warning

2018-09-17 Thread Stefan Agner
pe of the variable 'gain_selectors' to int so that Clang >> > > understands this is expected behavior. >> > > >> > > Reported-by: Nick Desaulniers >> > > Signed-off-by: Nathan Chancellor >> > How does this interact with the patch that Stefan

Re: [PATCH] iio: adc: max9611: Avoid implicit enum conversion warning

2018-09-17 Thread Stefan Agner
pe of the variable 'gain_selectors' to int so that Clang >> > > understands this is expected behavior. >> > > >> > > Reported-by: Nick Desaulniers >> > > Signed-off-by: Nathan Chancellor >> > How does this interact with the patch that Stefan

Re: [PATCH 4.18 082/197] block: dont warn for flush on read-only device

2018-09-16 Thread Stefan Agner
y on-media data by itself. > > Reported-by: Stefan Agner > Fixes: 721c7fc701c7 ("block: fail op_is_write() requests to read-only > partitions") > Signed-off-by: Jens Axboe > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- >

Re: [PATCH 4.18 082/197] block: dont warn for flush on read-only device

2018-09-16 Thread Stefan Agner
y on-media data by itself. > > Reported-by: Stefan Agner > Fixes: 721c7fc701c7 ("block: fail op_is_write() requests to read-only > partitions") > Signed-off-by: Jens Axboe > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- >

Re: [PATCH v4 06/13] Compiler Attributes: naked can be shared

2018-09-10 Thread Stefan Agner
On 08.09.2018 14:24, Miguel Ojeda wrote: > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > which is the only current user), gcc >= 8 (for x86), clang >= 3.1 > and icc >= 13. See https://godbolt.org/z/350Dyc > > Therefore, move it out of compiler-gcc.h so that the definition >

Re: [PATCH v4 06/13] Compiler Attributes: naked can be shared

2018-09-10 Thread Stefan Agner
On 08.09.2018 14:24, Miguel Ojeda wrote: > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > which is the only current user), gcc >= 8 (for x86), clang >= 3.1 > and icc >= 13. See https://godbolt.org/z/350Dyc > > Therefore, move it out of compiler-gcc.h so that the definition >

Re: [PATCH v4 05/13] Compiler Attributes: naked was fixed in gcc 4.6

2018-09-10 Thread Stefan Agner
Hi, On 08.09.2018 14:24, Miguel Ojeda wrote: > Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone > and noinline on __naked functions") added noinline and noclone > as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0. > > Since now the minimum gcc supported version is 4.6, >

Re: [PATCH v4 05/13] Compiler Attributes: naked was fixed in gcc 4.6

2018-09-10 Thread Stefan Agner
Hi, On 08.09.2018 14:24, Miguel Ojeda wrote: > Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone > and noinline on __naked functions") added noinline and noclone > as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0. > > Since now the minimum gcc supported version is 4.6, >

[PATCH] include/linux/compiler-clang.h: define __naked

2018-09-10 Thread Stefan Agner
Signed-off-by: Stefan Agner --- include/linux/compiler-clang.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h index b1ce500fe8b3..a593e3ac0720 100644 --- a/include/linux/compiler-clang.h +++ b/include/linux/compiler-clang.h @@ -2

[PATCH] include/linux/compiler-clang.h: define __naked

2018-09-10 Thread Stefan Agner
Signed-off-by: Stefan Agner --- include/linux/compiler-clang.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h index b1ce500fe8b3..a593e3ac0720 100644 --- a/include/linux/compiler-clang.h +++ b/include/linux/compiler-clang.h @@ -2

[PATCH] ARM: dts: imx6q-apalis: mux RESET_MOCI# signal

2018-09-06 Thread Stefan Agner
as a GPIO by default not muxing it explicitly worked fine in practise. Signed-off-by: Stefan Agner --- arch/arm/boot/dts/imx6q-apalis-eval.dts | 2 ++ arch/arm/boot/dts/imx6q-apalis-ixora-v1.1.dts | 2 ++ arch/arm/boot/dts/imx6q-apalis-ixora.dts | 2 ++ arch/arm/boot/dts/imx6qdl-apalis.dtsi

[PATCH] ARM: dts: imx6q-apalis: mux RESET_MOCI# signal

2018-09-06 Thread Stefan Agner
as a GPIO by default not muxing it explicitly worked fine in practise. Signed-off-by: Stefan Agner --- arch/arm/boot/dts/imx6q-apalis-eval.dts | 2 ++ arch/arm/boot/dts/imx6q-apalis-ixora-v1.1.dts | 2 ++ arch/arm/boot/dts/imx6q-apalis-ixora.dts | 2 ++ arch/arm/boot/dts/imx6qdl-apalis.dtsi

Re: [PATCH] HID: core: fix NULL pointer dereference

2018-09-04 Thread Stefan Agner
Addresses-Coverity-ID: 1473081 ("Dereference after null check") > Fixes: b2dd9f2e5a8a ("HID: core: fix memory leak on probe") > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Stefan Agner -- Stefan > --- > drivers/hid/hid-core.c | 3 ++- > 1 file changed, 2 insert

Re: [PATCH] HID: core: fix NULL pointer dereference

2018-09-04 Thread Stefan Agner
Addresses-Coverity-ID: 1473081 ("Dereference after null check") > Fixes: b2dd9f2e5a8a ("HID: core: fix memory leak on probe") > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Stefan Agner -- Stefan > --- > drivers/hid/hid-core.c | 3 ++- > 1 file changed, 2 insert

[PATCH] HID: core: fix memory leak on probe

2018-08-28 Thread Stefan Agner
The dynamically allocted collection stack does not get freed in all situations. Make sure to also free the collection stack when using the parser in hid_open_report(). Fixes: 08a8a7cf1459 ("HID: core: do not upper bound the collection stack") Signed-off-by: Stefan Agner --- Found wit

[PATCH] HID: core: fix memory leak on probe

2018-08-28 Thread Stefan Agner
The dynamically allocted collection stack does not get freed in all situations. Make sure to also free the collection stack when using the parser in hid_open_report(). Fixes: 08a8a7cf1459 ("HID: core: do not upper bound the collection stack") Signed-off-by: Stefan Agner --- Found wit

[PATCH] HID: input: fix leaking custom input node name

2018-08-28 Thread Stefan Agner
Make sure to free the custom input node name on disconnect. Cc: sta...@vger.kernel.org # v4.18+ Fixes: c554bb045511 ("HID: input: append a suffix matching the application") Signed-off-by: Stefan Agner --- Found with kmemleak, after unplugging a Logitech Unifying receiver: unreferen

[PATCH] HID: input: fix leaking custom input node name

2018-08-28 Thread Stefan Agner
Make sure to free the custom input node name on disconnect. Cc: sta...@vger.kernel.org # v4.18+ Fixes: c554bb045511 ("HID: input: append a suffix matching the application") Signed-off-by: Stefan Agner --- Found with kmemleak, after unplugging a Logitech Unifying receiver: unreferen

[PATCH] tty: serial: lpuart: avoid leaking struct tty_struct

2018-08-28 Thread Stefan Agner
() and .set_termios() callback, it is safe to assume the tty instance is valid. Cc: sta...@vger.kernel.org # v4.9+ Fixes: 5887ad43ee02 ("tty: serial: fsl_lpuart: Use cyclic DMA for Rx") Signed-off-by: Stefan Agner --- This fixes a memory leak observable when opening/closing the tty in a loop. Th

[PATCH] tty: serial: lpuart: avoid leaking struct tty_struct

2018-08-28 Thread Stefan Agner
() and .set_termios() callback, it is safe to assume the tty instance is valid. Cc: sta...@vger.kernel.org # v4.9+ Fixes: 5887ad43ee02 ("tty: serial: fsl_lpuart: Use cyclic DMA for Rx") Signed-off-by: Stefan Agner --- This fixes a memory leak observable when opening/closing the tty in a loop. Th

[PATCH] ARM: wire up io_pgetevents syscall

2018-08-27 Thread Stefan Agner
Wire up the new io_pgetevents syscall for ARM. Signed-off-by: Stefan Agner --- arch/arm/tools/syscall.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl index fbc74b5fa3ed..8edf93b4490f 100644 --- a/arch/arm/tools/syscall.tbl +++ b

[PATCH] ARM: wire up io_pgetevents syscall

2018-08-27 Thread Stefan Agner
Wire up the new io_pgetevents syscall for ARM. Signed-off-by: Stefan Agner --- arch/arm/tools/syscall.tbl | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl index fbc74b5fa3ed..8edf93b4490f 100644 --- a/arch/arm/tools/syscall.tbl +++ b

[PATCH] bpf: fix build error with clang

2018-08-27 Thread Stefan Agner
resolving hweight_long at compile time. Since SK_FL_PROTO_MASK is a constant, we can use the interface for known constant arguments which works fine with clang. Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") Signed-off-by: Stefan Agner --- net/core/filter.c | 2 +- 1 file

[PATCH] bpf: fix build error with clang

2018-08-27 Thread Stefan Agner
resolving hweight_long at compile time. Since SK_FL_PROTO_MASK is a constant, we can use the interface for known constant arguments which works fine with clang. Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") Signed-off-by: Stefan Agner --- net/core/filter.c | 2 +- 1 file

[PATCH] ARM: ftrace: remove old mcount support

2018-08-26 Thread Stefan Agner
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") raised the minimum GCC version to 4.6. Old mcount is only required for GCC versions older than 4.4.0. Hence old mcount support can be dropped too. Signed-off-by: Stefan Agner --- Besides cleaning up code it also

[PATCH] ARM: ftrace: remove old mcount support

2018-08-26 Thread Stefan Agner
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") raised the minimum GCC version to 4.6. Old mcount is only required for GCC versions older than 4.4.0. Hence old mcount support can be dropped too. Signed-off-by: Stefan Agner --- Besides cleaning up code it also

Re: [PATCH] ARM: use choice for kernel unwinders

2018-08-22 Thread Stefan Agner
On 22.08.2018 12:02, Arnd Bergmann wrote: > On Wed, Aug 22, 2018 at 12:24 AM Stefan Agner wrote: >> >> While in theory multiple unwinders could be compiled in, it does >> not make sense in practise. Use a choice to make the unwinder >> selection mutually exclusive a

Re: [PATCH] ARM: use choice for kernel unwinders

2018-08-22 Thread Stefan Agner
On 22.08.2018 12:02, Arnd Bergmann wrote: > On Wed, Aug 22, 2018 at 12:24 AM Stefan Agner wrote: >> >> While in theory multiple unwinders could be compiled in, it does >> not make sense in practise. Use a choice to make the unwinder >> selection mutually exclusive a

[PATCH] ARM: use choice for kernel unwinders

2018-08-21 Thread Stefan Agner
, and clang is not able to generate the required prologue. Make the FRAME_POINTER config symbol depending on !clang. Suggested-by: Arnd Bergmann Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 43 ++ 1 file changed, 27 insertions(+), 16 deletions

[PATCH] ARM: use choice for kernel unwinders

2018-08-21 Thread Stefan Agner
, and clang is not able to generate the required prologue. Make the FRAME_POINTER config symbol depending on !clang. Suggested-by: Arnd Bergmann Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 43 ++ 1 file changed, 27 insertions(+), 16 deletions

Re: [PATCH v2] ASoC: tegra: probe deferral error reporting

2018-08-18 Thread Stefan Agner
t;> goto err_clk_put; >> } > > Thanks, looks good to me. However, I wonder why we don't request the > 'sync_gpio' in the probe like we do for the reset? Otherwise ... The comment in tegra20_ac97_codec_warm_reset() is probably the reason: /* * although sync line is driven by the DAC pad group warm reset using * the controller cmd is not working, have to toggle sync line * manually. */ I guess the GPIO need to be freed so that the DAC pad group can use the sync line? > > Acked-by: Jon Hunter Also looks good to me: Reviewed-by: Stefan Agner -- Stefan

Re: [PATCH v2] ASoC: tegra: probe deferral error reporting

2018-08-18 Thread Stefan Agner
t;> goto err_clk_put; >> } > > Thanks, looks good to me. However, I wonder why we don't request the > 'sync_gpio' in the probe like we do for the reset? Otherwise ... The comment in tegra20_ac97_codec_warm_reset() is probably the reason: /* * although sync line is driven by the DAC pad group warm reset using * the controller cmd is not working, have to toggle sync line * manually. */ I guess the GPIO need to be freed so that the DAC pad group can use the sync line? > > Acked-by: Jon Hunter Also looks good to me: Reviewed-by: Stefan Agner -- Stefan

Re: [PATCH v2] clk: tegra: probe deferral error reporting

2018-08-18 Thread Stefan Agner
On 14.08.2018 11:18, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Actually report the error code from devm_regulator_get() which may as > well just be a probe deferral. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Stefan Agner > > --- > > Changes in

Re: [PATCH v2] clk: tegra: probe deferral error reporting

2018-08-18 Thread Stefan Agner
On 14.08.2018 11:18, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Actually report the error code from devm_regulator_get() which may as > well just be a probe deferral. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Stefan Agner > > --- > > Changes in

Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Stefan Agner
Hi, Using Linux 4.18 on a i.MX 6Q I see the following warning during boot-up: [ 23.928916] [ cut here ] [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 generic_make_request_checks+0x868/0xa18 [ 23.943306] generic_make_request: Trying to write to

Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Stefan Agner
Hi, Using Linux 4.18 on a i.MX 6Q I see the following warning during boot-up: [ 23.928916] [ cut here ] [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 generic_make_request_checks+0x868/0xa18 [ 23.943306] generic_make_request: Trying to write to

Re: [PATCH] gcc-plugins: require GCC

2018-08-13 Thread Stefan Agner
On 13.08.2018 22:18, Kees Cook wrote: > On Mon, Aug 13, 2018 at 1:10 PM, Kees Cook wrote: >> On Mon, Aug 13, 2018 at 12:38 AM, Masahiro Yamada >> wrote: >>> 2018-08-11 18:48 GMT+09:00 Stefan Agner : >>>> Unsurprisingly GCC plugins require GCC as a compiler

Re: [PATCH] gcc-plugins: require GCC

2018-08-13 Thread Stefan Agner
On 13.08.2018 22:18, Kees Cook wrote: > On Mon, Aug 13, 2018 at 1:10 PM, Kees Cook wrote: >> On Mon, Aug 13, 2018 at 12:38 AM, Masahiro Yamada >> wrote: >>> 2018-08-11 18:48 GMT+09:00 Stefan Agner : >>>> Unsurprisingly GCC plugins require GCC as a compiler

Re: [PATCH] ARM: drop experimental mark for ARM stack unwinding

2018-08-11 Thread Stefan Agner
On 11.08.2018 18:57, Russell King - ARM Linux wrote: > On Sat, Aug 11, 2018 at 12:31:27PM +0200, Stefan Agner wrote: >> ARM stack unwinding is upstream since 2009 and has been proven >> working well. At this time it is the preferred stack unwinding >> support since it also

Re: [PATCH] ARM: drop experimental mark for ARM stack unwinding

2018-08-11 Thread Stefan Agner
On 11.08.2018 18:57, Russell King - ARM Linux wrote: > On Sat, Aug 11, 2018 at 12:31:27PM +0200, Stefan Agner wrote: >> ARM stack unwinding is upstream since 2009 and has been proven >> working well. At this time it is the preferred stack unwinding >> support since it also

[PATCH] ARM: drop experimental mark for ARM stack unwinding

2018-08-11 Thread Stefan Agner
ARM stack unwinding is upstream since 2009 and has been proven working well. At this time it is the preferred stack unwinding support since it also supports Thumb 2. Do not scare people and drop the EXPERIMENTAL mark. Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 2 +- 1 file changed

[PATCH] ARM: drop experimental mark for ARM stack unwinding

2018-08-11 Thread Stefan Agner
ARM stack unwinding is upstream since 2009 and has been proven working well. At this time it is the preferred stack unwinding support since it also supports Thumb 2. Do not scare people and drop the EXPERIMENTAL mark. Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 2 +- 1 file changed

[PATCH] ARM: require GCC for FRAME_POINTER

2018-08-11 Thread Stefan Agner
on clang, and clang is not able to generate the required prologue. Make the FRAME_POINTER config symbol dependent on GCC. Suggested-by: Arnd Bergmann Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch

[PATCH] ARM: require GCC for FRAME_POINTER

2018-08-11 Thread Stefan Agner
on clang, and clang is not able to generate the required prologue. Make the FRAME_POINTER config symbol dependent on GCC. Suggested-by: Arnd Bergmann Signed-off-by: Stefan Agner --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch

[PATCH] gcc-plugins: require GCC

2018-08-11 Thread Stefan Agner
Unsurprisingly GCC plugins require GCC as a compiler. This avoids GCC plugins being selectable when using clang. Signed-off-by: Stefan Agner --- arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index 1aa59063f1fd..8c693a837ed7 100644

[PATCH] gcc-plugins: require GCC

2018-08-11 Thread Stefan Agner
Unsurprisingly GCC plugins require GCC as a compiler. This avoids GCC plugins being selectable when using clang. Signed-off-by: Stefan Agner --- arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/Kconfig b/arch/Kconfig index 1aa59063f1fd..8c693a837ed7 100644

[PATCH] iio: adc: max9611: explicitly cast gain_selectors

2018-08-11 Thread Stefan Agner
conversion from enumeration type 'enum max9611_conf_ids' to different enumeration type 'enum max9611_csa_gain' [-Wenum-conversion] *csa_gain = gain_selectors[i]; ~ ^ Signed-off-by: Stefan Agner --- drivers/iio

[PATCH] iio: adc: max9611: explicitly cast gain_selectors

2018-08-11 Thread Stefan Agner
conversion from enumeration type 'enum max9611_conf_ids' to different enumeration type 'enum max9611_csa_gain' [-Wenum-conversion] *csa_gain = gain_selectors[i]; ~ ^ Signed-off-by: Stefan Agner --- drivers/iio

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-06 Thread Stefan Agner
On 06.08.2018 15:38, Dmitry Osipenko wrote: > On Monday, 6 August 2018 16:03:01 MSK Stefan Agner wrote: >> On 04.08.2018 16:01, Dmitry Osipenko wrote: >> > On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote: >> >> On Thu, Aug 2, 2018 at 1:31 PM Stefan Agne

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-06 Thread Stefan Agner
On 06.08.2018 15:38, Dmitry Osipenko wrote: > On Monday, 6 August 2018 16:03:01 MSK Stefan Agner wrote: >> On 04.08.2018 16:01, Dmitry Osipenko wrote: >> > On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote: >> >> On Thu, Aug 2, 2018 at 1:31 PM Stefan Agne

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-06 Thread Stefan Agner
On 04.08.2018 16:01, Dmitry Osipenko wrote: > On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote: >> On Thu, Aug 2, 2018 at 1:31 PM Stefan Agner wrote: >> > A while back at least using those init lists were not well received even >> > for GPIO/pinct

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-06 Thread Stefan Agner
On 04.08.2018 16:01, Dmitry Osipenko wrote: > On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote: >> On Thu, Aug 2, 2018 at 1:31 PM Stefan Agner wrote: >> > A while back at least using those init lists were not well received even >> > for GPIO/pinct

[PATCH 2/3] mtd: rawnand: vf610_nfc: explicitly disable interrupts first

2018-08-06 Thread Stefan Agner
Explicitly disable all interrupts on probe. This should be the default state, but the bootloader could leave the device in any state. No issues have been observed so far, but it is still worth fixing it. Signed-off-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 9 + 1 file

[PATCH 1/3] mtd: rawnand: vf610_nfc: align IRQ bit naming

2018-08-06 Thread Stefan Agner
Rename the IRQ DONE clear bit to align with other IRQ bits. Signed-off-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index d5a22fc96878

[PATCH 3/3] mtd: rawnand: vf610_nfc: handle only idle interrupts

2018-08-06 Thread Stefan Agner
adverse effects. Signed-off-by: Stefan Agner Tested-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index 52e7811c0bde

[PATCH 1/3] mtd: rawnand: vf610_nfc: align IRQ bit naming

2018-08-06 Thread Stefan Agner
Rename the IRQ DONE clear bit to align with other IRQ bits. Signed-off-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index d5a22fc96878

[PATCH 3/3] mtd: rawnand: vf610_nfc: handle only idle interrupts

2018-08-06 Thread Stefan Agner
adverse effects. Signed-off-by: Stefan Agner Tested-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index 52e7811c0bde

[PATCH 2/3] mtd: rawnand: vf610_nfc: explicitly disable interrupts first

2018-08-06 Thread Stefan Agner
Explicitly disable all interrupts on probe. This should be the default state, but the bootloader could leave the device in any state. No issues have been observed so far, but it is still worth fixing it. Signed-off-by: Stefan Agner --- drivers/mtd/nand/raw/vf610_nfc.c | 9 + 1 file

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-02 Thread Stefan Agner
them loaded early. It avoids unnecessary EPROBE_DEFER and hence probably even boots faster. And in this case it even resolves real world issues. This should definitely go in, at least as a stop gap solution. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Dmitry Osipenko > --

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-02 Thread Stefan Agner
them loaded early. It avoids unnecessary EPROBE_DEFER and hence probably even boots faster. And in this case it even resolves real world issues. This should definitely go in, at least as a stop gap solution. Acked-by: Stefan Agner -- Stefan > > Signed-off-by: Dmitry Osipenko > --

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Stefan Agner
On 02.08.2018 12:17, Philipp Zabel wrote: > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: >> On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: >> > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: >> > > Adding lcdif nodes to a power domain currently does work, it

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-02 Thread Stefan Agner
On 02.08.2018 12:17, Philipp Zabel wrote: > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: >> On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: >> > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: >> > > Adding lcdif nodes to a power domain currently does work, it

Re: [PATCH] net: fec: check DMA addressing limitations

2018-08-02 Thread Stefan Agner
On 02.08.2018 04:00, Andy Duan wrote: > From: Stefan Agner Sent: 2018年8月1日 19:45 >> Check DMA addressing limitations as suggested by the DMA API how-to. >> This does not fix a particular issue seen but is considered good style. >> >> Signed-off-by: Stefan Agner >

Re: [PATCH] net: fec: check DMA addressing limitations

2018-08-02 Thread Stefan Agner
On 02.08.2018 04:00, Andy Duan wrote: > From: Stefan Agner Sent: 2018年8月1日 19:45 >> Check DMA addressing limitations as suggested by the DMA API how-to. >> This does not fix a particular issue seen but is considered good style. >> >> Signed-off-by: Stefan Agner >

Re: [PATCH 2/2] ARM: tegra: readd gpio-ranges properties

2018-08-01 Thread Stefan Agner
On 01.08.2018 22:51, Dmitry Osipenko wrote: > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote: >> The properties have been commented out to prevent a regression a >> while ago. The first regression should be resolved by >> commit 44af7927316e ("spi: Map SPI O

Re: [PATCH 2/2] ARM: tegra: readd gpio-ranges properties

2018-08-01 Thread Stefan Agner
On 01.08.2018 22:51, Dmitry Osipenko wrote: > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote: >> The properties have been commented out to prevent a regression a >> while ago. The first regression should be resolved by >> commit 44af7927316e ("spi: Map SPI O

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 31.07.2018 18:29, Robin Murphy wrote: > On 31/07/18 16:53, Stefan Agner wrote: >> On 31.07.2018 14:32, Robin Murphy wrote: >>> On 31/07/18 09:19, Stefan Agner wrote: >>>> On 30.07.2018 16:38, Robin Murphy wrote: >>>>> On 28/07/18 17:58, Guenter Roec

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 31.07.2018 18:29, Robin Murphy wrote: > On 31/07/18 16:53, Stefan Agner wrote: >> On 31.07.2018 14:32, Robin Murphy wrote: >>> On 31/07/18 09:19, Stefan Agner wrote: >>>> On 30.07.2018 16:38, Robin Murphy wrote: >>>>> On 28/07/18 17:58, Guenter Roec

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 31.07.2018 14:32, Robin Murphy wrote: > On 31/07/18 09:19, Stefan Agner wrote: >> On 30.07.2018 16:38, Robin Murphy wrote: >>> On 28/07/18 17:58, Guenter Roeck wrote: >>>> On Fri, Jul 27, 2018 at 04:04:48PM +0200, Christoph Hellwig wrote: >>>>

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 31.07.2018 14:32, Robin Murphy wrote: > On 31/07/18 09:19, Stefan Agner wrote: >> On 30.07.2018 16:38, Robin Murphy wrote: >>> On 28/07/18 17:58, Guenter Roeck wrote: >>>> On Fri, Jul 27, 2018 at 04:04:48PM +0200, Christoph Hellwig wrote: >>>>

[PATCH] fs: ubifs: introduce Kconfig symbol for xattr support

2018-07-31 Thread Stefan Agner
Allow to disable extended attribute support. This aids in reliability testing, especially since some xattr related bugs have surfaced. Also an embedded system might not need it, so this allows for a slightly smaller kernel (about 4KiB). Signed-off-by: Stefan Agner --- fs/ubifs/Kconfig | 15

[PATCH] fs: ubifs: introduce Kconfig symbol for xattr support

2018-07-31 Thread Stefan Agner
Allow to disable extended attribute support. This aids in reliability testing, especially since some xattr related bugs have surfaced. Also an embedded system might not need it, so this allows for a slightly smaller kernel (about 4KiB). Signed-off-by: Stefan Agner --- fs/ubifs/Kconfig | 15

Re: [PATCH v2 03/10] mmc: tegra: Power on the calibration pad

2018-07-31 Thread Stefan Agner
On 26.07.2018 14:26, Aapo Vienamo wrote: > Automatic pad drive strength calibration is performed on a separate pad > identical to the ones used for driving the actual bus. Power on the > calibration pad during the calibration procedure and power it off > afterwards to save power. > >

Re: [PATCH v2 03/10] mmc: tegra: Power on the calibration pad

2018-07-31 Thread Stefan Agner
On 26.07.2018 14:26, Aapo Vienamo wrote: > Automatic pad drive strength calibration is performed on a separate pad > identical to the ones used for driving the actual bus. Power on the > calibration pad during the calibration procedure and power it off > afterwards to save power. > >

Re: [PATCH v2 00/10] Tegra SDHCI update the pad autocal procedure

2018-07-31 Thread Stefan Agner
On 30.07.2018 17:43, Aapo Vienamo wrote: > On Mon, 30 Jul 2018 17:07:59 +0200 > Ulf Hansson wrote: > >> On 26 July 2018 at 14:26, Aapo Vienamo wrote: >> > Hi all, >> > >> > Update the tegra_sdhci_pad_autocalib() pad drive strength calibration >> > procedure to match the ones specified in the

Re: [PATCH v2 00/10] Tegra SDHCI update the pad autocal procedure

2018-07-31 Thread Stefan Agner
On 30.07.2018 17:43, Aapo Vienamo wrote: > On Mon, 30 Jul 2018 17:07:59 +0200 > Ulf Hansson wrote: > >> On 26 July 2018 at 14:26, Aapo Vienamo wrote: >> > Hi all, >> > >> > Update the tegra_sdhci_pad_autocalib() pad drive strength calibration >> > procedure to match the ones specified in the

Re: [PATCH v2 03/10] mmc: tegra: Reconfigure pad voltages during voltage switching

2018-07-31 Thread Stefan Agner
On 27.07.2018 10:44, Aapo Vienamo wrote: > On Thu, 26 Jul 2018 15:33:11 +0200 > Stefan Agner wrote: > >> On 26.07.2018 14:19, Aapo Vienamo wrote: >> > Parse the pinctrl state and nvidia,only-1-8-v properties from the device >> > tree and implement pad voltage

Re: [PATCH v2 03/10] mmc: tegra: Reconfigure pad voltages during voltage switching

2018-07-31 Thread Stefan Agner
On 27.07.2018 10:44, Aapo Vienamo wrote: > On Thu, 26 Jul 2018 15:33:11 +0200 > Stefan Agner wrote: > >> On 26.07.2018 14:19, Aapo Vienamo wrote: >> > Parse the pinctrl state and nvidia,only-1-8-v properties from the device >> > tree and implement pad voltage

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 30.07.2018 16:38, Robin Murphy wrote: > On 28/07/18 17:58, Guenter Roeck wrote: >> On Fri, Jul 27, 2018 at 04:04:48PM +0200, Christoph Hellwig wrote: >>> On Fri, Jul 27, 2018 at 03:18:14PM +0200, Krzysztof Kozlowski wrote: On 27 July 2018 at 15:11, Krzysztof Kozlowski wrote: > Hi,

Re: [BUG BISECT] Ethernet fail on VF50 (OF: Don't set default coherent DMA mask)

2018-07-31 Thread Stefan Agner
On 30.07.2018 16:38, Robin Murphy wrote: > On 28/07/18 17:58, Guenter Roeck wrote: >> On Fri, Jul 27, 2018 at 04:04:48PM +0200, Christoph Hellwig wrote: >>> On Fri, Jul 27, 2018 at 03:18:14PM +0200, Krzysztof Kozlowski wrote: On 27 July 2018 at 15:11, Krzysztof Kozlowski wrote: > Hi,

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 18:39, Peter Geis wrote: > I finally got around to testing this on the Ouya (Tegra 3). Thanks for testing! > > I found that the "Got command interrupt 0x0001 even though no > command operation was in progress." error occurred when the interface

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 18:39, Peter Geis wrote: > I finally got around to testing this on the Ouya (Tegra 3). Thanks for testing! > > I found that the "Got command interrupt 0x0001 even though no > command operation was in progress." error occurred when the interface

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 17:12, Peter Geis wrote: > On 07/26/2018 10:47 AM, Stefan Agner wrote: >> On 26.07.2018 15:56, Peter Geis wrote: >>> On 07/12/2018 03:39 AM, Stefan Agner wrote: >>>> It seems that SD3.0 advertisement needs to be set for higher eMMC >>>> s

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 17:12, Peter Geis wrote: > On 07/26/2018 10:47 AM, Stefan Agner wrote: >> On 26.07.2018 15:56, Peter Geis wrote: >>> On 07/12/2018 03:39 AM, Stefan Agner wrote: >>>> It seems that SD3.0 advertisement needs to be set for higher eMMC >>>> s

[PATCH] gpio: tegra: drop tegra specific GPIO lockdep classes

2018-07-26 Thread Stefan Agner
he lockdep class set by the driver is useless. Remove it. Signed-off-by: Stefan Agner --- drivers/gpio/gpio-tegra.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 94396caaca75..e5fcc012179e 100644 --- a/drivers/gpio/gpio-tegra.

[PATCH] gpio: tegra: drop tegra specific GPIO lockdep classes

2018-07-26 Thread Stefan Agner
he lockdep class set by the driver is useless. Remove it. Signed-off-by: Stefan Agner --- drivers/gpio/gpio-tegra.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 94396caaca75..e5fcc012179e 100644 --- a/drivers/gpio/gpio-tegra.

[PATCH 1/2] pinctrl: tegra: define GPIO compatible node per SoC

2018-07-26 Thread Stefan Agner
ee. Fixes: 9462510ce31e ("pinctrl: tegra: Only set the gpio range if needed") Signed-off-by: Stefan Agner --- drivers/pinctrl/tegra/pinctrl-tegra.c| 6 +++--- drivers/pinctrl/tegra/pinctrl-tegra.h| 1 + drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra

[PATCH 1/2] pinctrl: tegra: define GPIO compatible node per SoC

2018-07-26 Thread Stefan Agner
ee. Fixes: 9462510ce31e ("pinctrl: tegra: Only set the gpio range if needed") Signed-off-by: Stefan Agner --- drivers/pinctrl/tegra/pinctrl-tegra.c| 6 +++--- drivers/pinctrl/tegra/pinctrl-tegra.h| 1 + drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 + drivers/pinctrl/tegra/pinctrl-tegra

[PATCH 2/2] ARM: tegra: readd gpio-ranges properties

2018-07-26 Thread Stefan Agner
probe breaking suspend resume order") and/or maybe others. Readd the gpio-ranges properties to see whether regressions still get reported. This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73 ("ARM: tegra: Comment out gpio-ranges properties"). Signed-off-by: Stefan Agner -

[PATCH 2/2] ARM: tegra: readd gpio-ranges properties

2018-07-26 Thread Stefan Agner
probe breaking suspend resume order") and/or maybe others. Readd the gpio-ranges properties to see whether regressions still get reported. This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73 ("ARM: tegra: Comment out gpio-ranges properties"). Signed-off-by: Stefan Agner -

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 15:56, Peter Geis wrote: > On 07/12/2018 03:39 AM, Stefan Agner wrote: >> It seems that SD3.0 advertisement needs to be set for higher eMMC >> speed modes (namely DDR52) as well. The TRM states that the SD3.0 >> advertisement bit should be set for all contr

Re: [PATCH 3/3] mmc: tegra: prevent ACMD23 on Tegra 3

2018-07-26 Thread Stefan Agner
On 26.07.2018 15:56, Peter Geis wrote: > On 07/12/2018 03:39 AM, Stefan Agner wrote: >> It seems that SD3.0 advertisement needs to be set for higher eMMC >> speed modes (namely DDR52) as well. The TRM states that the SD3.0 >> advertisement bit should be set for all contr

Re: [PATCH v2 03/10] mmc: tegra: Reconfigure pad voltages during voltage switching

2018-07-26 Thread Stefan Agner
On 26.07.2018 14:19, Aapo Vienamo wrote: > Parse the pinctrl state and nvidia,only-1-8-v properties from the device > tree and implement pad voltage state reconfiguration in the mmc > start_signal_voltage_switch() callback. Validate the pinctrl and > regulator configuration before unmasking UHS

Re: [PATCH v2 03/10] mmc: tegra: Reconfigure pad voltages during voltage switching

2018-07-26 Thread Stefan Agner
On 26.07.2018 14:19, Aapo Vienamo wrote: > Parse the pinctrl state and nvidia,only-1-8-v properties from the device > tree and implement pad voltage state reconfiguration in the mmc > start_signal_voltage_switch() callback. Validate the pinctrl and > regulator configuration before unmasking UHS

Re: [PATCH v2 02/10] dt-bindings: mmc: tegra: Add nvidia,only-1-8-v property

2018-07-26 Thread Stefan Agner
On 26.07.2018 14:19, Aapo Vienamo wrote: > Add a property to mark controllers which operate at a 1.8 V fixed I/O > voltage. > > This feature of the hardware needs to be signaled this way because it > cannot be probed at runtime or reliably derived from other properties. Is this really needed?

Re: [PATCH v2 02/10] dt-bindings: mmc: tegra: Add nvidia,only-1-8-v property

2018-07-26 Thread Stefan Agner
On 26.07.2018 14:19, Aapo Vienamo wrote: > Add a property to mark controllers which operate at a 1.8 V fixed I/O > voltage. > > This feature of the hardware needs to be signaled this way because it > cannot be probed at runtime or reliably derived from other properties. Is this really needed?

Re: [PATCH 2/2] ARM: dts: tegra20/tegra30: add pmu interrupt-affinity

2018-07-26 Thread Stefan Agner
On 20.07.2018 18:34, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This is similar to tegra124 and avoids the following being reported > upon boot: > > hw perfevents: no interrupt-affinity property for /pmu, guessing. > > Signed-off-by: Marcel Ziswiler R

Re: [PATCH 2/2] ARM: dts: tegra20/tegra30: add pmu interrupt-affinity

2018-07-26 Thread Stefan Agner
On 20.07.2018 18:34, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This is similar to tegra124 and avoids the following being reported > upon boot: > > hw perfevents: no interrupt-affinity property for /pmu, guessing. > > Signed-off-by: Marcel Ziswiler R

Re: [PATCH 1/2] ARM: dts: tegra20: restore address order

2018-07-26 Thread Stefan Agner
Fix this. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Stefan Agner > > --- > > arch/arm/boot/dts/tegra20.dtsi | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/te

<    1   2   3   4   5   6   7   8   9   10   >