Re: [PATCH v5] btrfs: Fix memory leakage in the tree-log.c

2013-10-11 Thread Stefan Behrens
On Thu, 10 Oct 2013 19:11:22 -0300, Geyslan G. Bem wrote: > In add_inode_ref() function: > > Initializes local pointers. > > Reduces the logical condition with the __add_inode_ref() return > value by using only one 'goto out'. > > Centralizes the exiting, ensuring the freeing of all used memory.

Re: [PATCH v4] btrfs: Fix memory leakage in the tree-log.c

2013-10-10 Thread Stefan Behrens
On Wed, 9 Oct 2013 23:01:35 -0300, Geyslan G. Bem wrote: > When 'dir' is NULL, after calling extref_get_fields(), add_inode_ref() > can be returning without freeing the 'name' pointer. > > Added kfree when necessary. > > Signed-off-by: Geyslan G. Bem > --- > fs/btrfs/tree-log.c | 5 - > 1

Re: btrfs GPF in read_extent_buffer() while scrubbing with kernel 3.4.2

2013-03-27 Thread Stefan Behrens
On Tue, 3 Jul 2012 02:01:21 +0300, Sami Liedes wrote: > Hi, > > I just got this oops on a computer running 3.4.2. > > A few minutes before I had started "btrfs device scrub /" and had a > watcher process running "btrfs scrub status /" every 5 seconds. After > a few gigabytes of scrubbing, I got t

Re: [PATCH] btrfs: Kill some bi_idx references

2012-09-12 Thread Stefan Behrens
it to something that might be a bit more useful. > > Signed-off-by: Kent Overstreet > CC: Chris Mason > CC: Stefan Behrens > --- > fs/btrfs/extent_io.c | 4 ++-- > fs/btrfs/scrub.c | 15 --- > 2 files changed, 2 insertions(+), 17 deletions(-) > > dif