[PATCH] MAINTAINERS: remove reference to bogus vsock file

The file drivers/vhost/vsock.h never existed. Remove the bogus MAINTAINERS reference. Fixes: 433fc58e6bf2c8bd97e57153ed28e64fd78207b8 ("VSOCK: Introduce vhost_vsock.ko") Reported-by: Joe Perches Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH V4 2/2] kvm/x86 : add document for coalesced pio

On Fri, Aug 31, 2018 at 12:17:21AM +0800, Peng Hao wrote: > Signed-off-by: Peng Hao > --- > Documentation/virtual/kvm/00-INDEX | 2 ++ > Documentation/virtual/kvm/coalesced-pio.txt | 15 +++ > 2 files changed, 17 insertions(+) > create mode 100644

Re: [PATCH V4 2/2] kvm/x86 : add document for coalesced pio

On Fri, Aug 31, 2018 at 12:17:21AM +0800, Peng Hao wrote: > Signed-off-by: Peng Hao > --- > Documentation/virtual/kvm/00-INDEX | 2 ++ > Documentation/virtual/kvm/coalesced-pio.txt | 15 +++ > 2 files changed, 17 insertions(+) > create mode 100644

Re: [PATCH] scsi/virio_scsi.c: do not call virtscsi_remove_vqs() in virtscsi_init() to avoid crash bug

On Thu, Aug 23, 2018 at 10:24:58AM +0800, piaojun wrote: > If some error happened before find_vqs, error branch will goto > virtscsi_remove_vqs to free vqs. Actually the vqs have not been allocated > successfully, so this will cause wild-pointer-free problem. So > virtscsi_remove_vqs could be

Re: [PATCH] scsi/virio_scsi.c: do not call virtscsi_remove_vqs() in virtscsi_init() to avoid crash bug

On Thu, Aug 23, 2018 at 10:24:58AM +0800, piaojun wrote: > If some error happened before find_vqs, error branch will goto > virtscsi_remove_vqs to free vqs. Actually the vqs have not been allocated > successfully, so this will cause wild-pointer-free problem. So > virtscsi_remove_vqs could be

Re: [PATCH net V2] vhost-vsock: fix use after free

. > > Reported-by: syzbot+e3e074963495f92a8...@syzkaller.appspotmail.com > Fixes: 16320f363ae1 ("vhost-vsock: add pkt cancel capability") > Fixes: 433fc58e6bf2 ("VSOCK: Introduce vhost_vsock.ko") > Cc: Stefan Hajnoczi > Signed-off-by: Jason Wang > -

Re: [PATCH net V2] vhost-vsock: fix use after free

. > > Reported-by: syzbot+e3e074963495f92a8...@syzkaller.appspotmail.com > Fixes: 16320f363ae1 ("vhost-vsock: add pkt cancel capability") > Fixes: 433fc58e6bf2 ("VSOCK: Introduce vhost_vsock.ko") > Cc: Stefan Hajnoczi > Signed-off-by: Jason Wang > -

Re: [PATCH] fuse: fix NULL dereference when new_inode() fails

On Fri, Jun 01, 2018 at 11:28:31AM +0200, Miklos Szeredi wrote: > On Fri, Jun 1, 2018 at 11:24 AM, Stefan Hajnoczi wrote: > > Ping? > > > > Archive link in case I broke email threading: > > https://marc.info/?l=linux-fsdevel=152719324102009=2 > > Thanks for th

Re: [PATCH] fuse: fix NULL dereference when new_inode() fails

On Fri, Jun 01, 2018 at 11:28:31AM +0200, Miklos Szeredi wrote: > On Fri, Jun 1, 2018 at 11:24 AM, Stefan Hajnoczi wrote: > > Ping? > > > > Archive link in case I broke email threading: > > https://marc.info/?l=linux-fsdevel=152719324102009=2 > > Thanks for th

Re: [PATCH] fuse: fix NULL dereference when new_inode() fails

Ping? Archive link in case I broke email threading: https://marc.info/?l=linux-fsdevel=152719324102009=2 Stefan signature.asc Description: PGP signature

Re: [PATCH] fuse: fix NULL dereference when new_inode() fails

Ping? Archive link in case I broke email threading: https://marc.info/?l=linux-fsdevel=152719324102009=2 Stefan signature.asc Description: PGP signature

[PATCH] fuse: fix NULL dereference when new_inode() fails

lve the NULL dereference. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- I spotted this when reading the code. Compile-tested only. fs/fuse/control.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/fuse/control.c b/fs/fuse/control.c index b9ea99c5b5b3..ef3

[PATCH] fuse: fix NULL dereference when new_inode() fails

lve the NULL dereference. Signed-off-by: Stefan Hajnoczi --- I spotted this when reading the code. Compile-tested only. fs/fuse/control.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/fuse/control.c b/fs/fuse/control.c index b9ea99c5b5b3..ef3af9c32147 100644 --- a/fs/f

Re: [virtio-dev] Re: [PATCH v1] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 10, 2018 at 06:39:41PM +0800, Tiwei Bie wrote: > On Thu, May 10, 2018 at 10:53:17AM +0100, Stefan Hajnoczi wrote: > > On Fri, May 04, 2018 at 12:59:15PM +0800, Tiwei Bie wrote: > > > diff --git a/include/uapi/linux/virtio_config.h > > > b/include/uapi/linux/

Re: [virtio-dev] Re: [PATCH v1] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 10, 2018 at 06:39:41PM +0800, Tiwei Bie wrote: > On Thu, May 10, 2018 at 10:53:17AM +0100, Stefan Hajnoczi wrote: > > On Fri, May 04, 2018 at 12:59:15PM +0800, Tiwei Bie wrote: > > > diff --git a/include/uapi/linux/virtio_config.h > > > b/include/uapi/linux/

Re: [virtio-dev] [PATCH v1] virtio: support VIRTIO_F_IO_BARRIER

On Fri, May 04, 2018 at 12:59:15PM +0800, Tiwei Bie wrote: > diff --git a/include/uapi/linux/virtio_config.h > b/include/uapi/linux/virtio_config.h > index 308e2096291f..9fb519a9df28 100644 > --- a/include/uapi/linux/virtio_config.h > +++ b/include/uapi/linux/virtio_config.h > @@ -49,7 +49,7 @@ >

Re: [virtio-dev] [PATCH v1] virtio: support VIRTIO_F_IO_BARRIER

On Fri, May 04, 2018 at 12:59:15PM +0800, Tiwei Bie wrote: > diff --git a/include/uapi/linux/virtio_config.h > b/include/uapi/linux/virtio_config.h > index 308e2096291f..9fb519a9df28 100644 > --- a/include/uapi/linux/virtio_config.h > +++ b/include/uapi/linux/virtio_config.h > @@ -49,7 +49,7 @@ >

Re: [RFC] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 3, 2018 at 2:26 PM, Tiwei Bie <tiwei@intel.com> wrote: > On Thu, May 03, 2018 at 10:06:52AM +0100, Stefan Hajnoczi wrote: >> On Thu, May 03, 2018 at 10:59:55AM +0800, Tiwei Bie wrote: >> > This patch introduces the support for VIRTIO_F_IO_BARRIER

Re: [RFC] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 3, 2018 at 2:26 PM, Tiwei Bie wrote: > On Thu, May 03, 2018 at 10:06:52AM +0100, Stefan Hajnoczi wrote: >> On Thu, May 03, 2018 at 10:59:55AM +0800, Tiwei Bie wrote: >> > This patch introduces the support for VIRTIO_F_IO_BARRIER. >> > When this feature is

Re: [RFC] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 03, 2018 at 10:59:55AM +0800, Tiwei Bie wrote: > This patch introduces the support for VIRTIO_F_IO_BARRIER. > When this feature is negotiated, driver will use the barriers > suitable for hardware devices. > > Signed-off-by: Tiwei Bie I should have thought of

Re: [RFC] virtio: support VIRTIO_F_IO_BARRIER

On Thu, May 03, 2018 at 10:59:55AM +0800, Tiwei Bie wrote: > This patch introduces the support for VIRTIO_F_IO_BARRIER. > When this feature is negotiated, driver will use the barriers > suitable for hardware devices. > > Signed-off-by: Tiwei Bie I should have thought of this earlier, but why is

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

On Thu, Apr 26, 2018 at 11:44:59AM -0400, Pankaj Gupta wrote: > > > + int err; > > > + > > > + sg_init_one(, buf, sizeof(buf)); > > > + > > > + err = virtqueue_add_outbuf(vpmem->req_vq, , 1, buf, GFP_KERNEL); > > > + > > > + if (err) { > > > + dev_err(>dev, "failed to send command to

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

On Thu, Apr 26, 2018 at 11:44:59AM -0400, Pankaj Gupta wrote: > > > + int err; > > > + > > > + sg_init_one(, buf, sizeof(buf)); > > > + > > > + err = virtqueue_add_outbuf(vpmem->req_vq, , 1, buf, GFP_KERNEL); > > > + > > > + if (err) { > > > + dev_err(>dev, "failed to send command to

Re: [RFC v2] qemu: Add virtio pmem device

On Wed, Apr 25, 2018 at 04:54:15PM +0530, Pankaj Gupta wrote: > +static void virtio_pmem_flush(VirtIODevice *vdev, VirtQueue *vq) > +{ > +VirtQueueElement *elem; > +VirtIOPMEM *pmem = VIRTIO_PMEM(vdev); > +HostMemoryBackend *backend = MEMORY_BACKEND(pmem->memdev); > +int fd =

Re: [RFC v2] qemu: Add virtio pmem device

On Wed, Apr 25, 2018 at 04:54:15PM +0530, Pankaj Gupta wrote: > +static void virtio_pmem_flush(VirtIODevice *vdev, VirtQueue *vq) > +{ > +VirtQueueElement *elem; > +VirtIOPMEM *pmem = VIRTIO_PMEM(vdev); > +HostMemoryBackend *backend = MEMORY_BACKEND(pmem->memdev); > +int fd =

Re: [RFC v2 2/2] pmem: device flush over VIRTIO

On Wed, Apr 25, 2018 at 04:54:14PM +0530, Pankaj Gupta wrote: > This patch adds functionality to perform > flush from guest to hosy over VIRTIO > when 'ND_REGION_VIRTIO'flag is set on > nd_negion. Flag is set by 'virtio-pmem' > driver. > > Signed-off-by: Pankaj Gupta > ---

Re: [RFC v2 2/2] pmem: device flush over VIRTIO

On Wed, Apr 25, 2018 at 04:54:14PM +0530, Pankaj Gupta wrote: > This patch adds functionality to perform > flush from guest to hosy over VIRTIO > when 'ND_REGION_VIRTIO'flag is set on > nd_negion. Flag is set by 'virtio-pmem' > driver. > > Signed-off-by: Pankaj Gupta > --- >

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

On Wed, Apr 25, 2018 at 04:54:13PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM > guest. > > Guest reads the persistent memory range > information from Qemu over VIRTIO and registers > it on nvdimm_bus. It also creates a nd_region > object with the persistent

Re: [Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

On Wed, Apr 25, 2018 at 04:54:13PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM > guest. > > Guest reads the persistent memory range > information from Qemu over VIRTIO and registers > it on nvdimm_bus. It also creates a nd_region > object with the persistent

[PATCH v3 1/2] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; This patch fixes the regression by rewriting the checks in the obvious way, no longer returning A when vq->iotlb is non-NULL (which is hard to understand). Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang <jasow...@red

[PATCH v3 1/2] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; This patch fixes the regression by rewriting the checks in the obvious way, no longer returning A when vq->iotlb is non-NULL (which is hard to understand). Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang Signed-off-by: St

[PATCH v3 2/2] vhost: return bool from *_access_ok() functions

changes the return type from int to bool so that false means failure and true means success. This eliminates a potential source of errors. Suggested-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/vhost.h | 4 +

[PATCH v3 2/2] vhost: return bool from *_access_ok() functions

changes the return type from int to bool so that false means failure and true means success. This eliminates a potential source of errors. Suggested-by: Linus Torvalds Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vhost.h | 4 ++-- drivers/vhost/vhost.c | 66

[PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check

broken. The second patch replaces the int return type with bool to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70

[PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check

broken. The second patch replaces the int return type with bool to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70

Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

On Tue, Apr 10, 2018 at 09:23:53AM +, Liang, Cunming wrote: > If QEMU is going to build a user space driver framework there, we're open > mind on that, even leveraging DPDK as the underlay library. Looking forward > to more others' comments from community. There is already an NVMe VFIO

Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost backend

On Tue, Apr 10, 2018 at 09:23:53AM +, Liang, Cunming wrote: > If QEMU is going to build a user space driver framework there, we're open > mind on that, even leveraging DPDK as the underlay library. Looking forward > to more others' comments from community. There is already an NVMe VFIO

Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check

On Tue, Apr 10, 2018 at 10:50:43AM -0400, David Miller wrote: > From: Jason Wang <jasow...@redhat.com> > Date: Tue, 10 Apr 2018 14:40:10 +0800 > > > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: > >> v2: > >> * Rewrote the conditional to make the vq acce

Re: [PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check

On Tue, Apr 10, 2018 at 10:50:43AM -0400, David Miller wrote: > From: Jason Wang > Date: Tue, 10 Apr 2018 14:40:10 +0800 > > > On 2018年04月10日 13:26, Stefan Hajnoczi wrote: > >> v2: > >> * Rewrote the conditional to make the vq access check clearer [Linu

[PATCH v2 1/2] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; This patch fixes the regression by rewriting the checks in the obvious way, no longer returning A when vq->iotlb is non-NULL (which is hard to understand). Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang <jasow...@red

[PATCH v2 1/2] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; This patch fixes the regression by rewriting the checks in the obvious way, no longer returning A when vq->iotlb is non-NULL (which is hard to understand). Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang Signed-off-by: St

[PATCH v2 2/2] vhost: return bool from *_access_ok() functions

changes the return type from int to bool so that false means failure and true means success. This eliminates a potential source of errors. Suggested-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/vhost/vhost.h | 4 +

[PATCH v2 2/2] vhost: return bool from *_access_ok() functions

changes the return type from int to bool so that false means failure and true means success. This eliminates a potential source of errors. Suggested-by: Linus Torvalds Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vhost.h | 4 ++-- drivers/vhost/vhost.c | 66

[PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check

to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70 ++- 2 files changed, 38 insertions(+), 36 deletions

[PATCH v2 0/2] vhost: fix vhost_vq_access_ok() log check

to prevent future bugs. Stefan Hajnoczi (2): vhost: fix vhost_vq_access_ok() log check vhost: return bool from *_access_ok() functions drivers/vhost/vhost.h | 4 +-- drivers/vhost/vhost.c | 70 ++- 2 files changed, 38 insertions(+), 36 deletions

Re: [PATCH RESEND net] vhost: fix vhost_vq_access_ok() log check

On Tue, Apr 10, 2018 at 3:40 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > From: Stefan Hajnoczi <stefa...@redhat.com> > > Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log > when IOTLB is enabled") introduced a regression. The logic was

Re: [PATCH RESEND net] vhost: fix vhost_vq_access_ok() log check

On Tue, Apr 10, 2018 at 3:40 AM, Michael S. Tsirkin wrote: > From: Stefan Hajnoczi > > Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log > when IOTLB is enabled") introduced a regression. The logic was > originally: > > if (vq->iotlb) &

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Mon, Apr 9, 2018 at 11:28 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Apr 09, 2018 at 05:44:36AM +0300, Michael S. Tsirkin wrote: >> On Mon, Apr 09, 2018 at 10:37:45AM +0800, Stefan Hajnoczi wrote: >> > On Sat, Apr 7, 2018 at 3:02 AM, syzbot >&g

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Mon, Apr 9, 2018 at 11:28 AM, Stefan Hajnoczi wrote: > On Mon, Apr 09, 2018 at 05:44:36AM +0300, Michael S. Tsirkin wrote: >> On Mon, Apr 09, 2018 at 10:37:45AM +0800, Stefan Hajnoczi wrote: >> > On Sat, Apr 7, 2018 at 3:02 AM, syzbot >> > wrote: >> &

[PATCH] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; The correct logic is: if (!A || vq->iotlb) return A; return B; Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang <jasow...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/

[PATCH] vhost: fix vhost_vq_access_ok() log check

->iotlb) return A; return B; The correct logic is: if (!A || vq->iotlb) return A; return B; Reported-by: syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com Cc: Jason Wang Signed-off-by: Stefan Hajnoczi --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+)

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Mon, Apr 09, 2018 at 05:44:36AM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 09, 2018 at 10:37:45AM +0800, Stefan Hajnoczi wrote: > > On Sat, Apr 7, 2018 at 3:02 AM, syzbot > > <syzbot+65a84dde0214b0387...@syzkaller.appspotmail.com> wrote: > > > syzbot hit t

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Mon, Apr 09, 2018 at 05:44:36AM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 09, 2018 at 10:37:45AM +0800, Stefan Hajnoczi wrote: > > On Sat, Apr 7, 2018 at 3:02 AM, syzbot > > wrote: > > > syzbot hit the following crash on upstream commit > > > 38c23685b273

Re: [Qemu-devel] [RFC] qemu: Add virtio pmem device

On Thu, Apr 05, 2018 at 08:09:26AM -0400, Pankaj Gupta wrote: > > Will this raw file already have the "disk information header" (no idea > > how that stuff is called) encoded? Are there any plans/possible ways to > > > > a) automatically create the headers? (if that's even possible) > > Its raw.

Re: [Qemu-devel] [RFC] qemu: Add virtio pmem device

On Thu, Apr 05, 2018 at 08:09:26AM -0400, Pankaj Gupta wrote: > > Will this raw file already have the "disk information header" (no idea > > how that stuff is called) encoded? Are there any plans/possible ways to > > > > a) automatically create the headers? (if that's even possible) > > Its raw.

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Sat, Apr 7, 2018 at 3:02 AM, syzbot wrote: > syzbot hit the following crash on upstream commit > 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) > Merge tag 'armsoc-drivers' of >

Re: kernel BUG at drivers/vhost/vhost.c:LINE! (2)

On Sat, Apr 7, 2018 at 3:02 AM, syzbot wrote: > syzbot hit the following crash on upstream commit > 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) > Merge tag 'armsoc-drivers' of > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc > syzbot dashboard link: >

Re: [PATCH v2] vhost: add vsock compat ioctl

On Wed, Mar 14, 2018 at 02:36:25PM -0700, Sonny Rao wrote: > This will allow usage of vsock from 32-bit binaries on a 64-bit > kernel. > > Signed-off-by: Sonny Rao <sonny...@chromium.org> > --- > drivers/vhost/vsock.c | 11 +++ > 1 file changed, 11 inserti

Re: [PATCH v2] vhost: add vsock compat ioctl

On Wed, Mar 14, 2018 at 02:36:25PM -0700, Sonny Rao wrote: > This will allow usage of vsock from 32-bit binaries on a 64-bit > kernel. > > Signed-off-by: Sonny Rao > --- > drivers/vhost/vsock.c | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Stefan Hajn

Re: [PATCH] drivers: vhost: vsock: fixed a brace coding style issue

On Fri, Mar 09, 2018 at 08:26:03AM +0530, Vaibhav Murkute wrote: > Fixed a coding style issue. > > Signed-off-by: Vaibhav Murkute <vaibhavmurkut...@gmail.com> > --- > drivers/vhost/vsock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by

Re: [PATCH] drivers: vhost: vsock: fixed a brace coding style issue

On Fri, Mar 09, 2018 at 08:26:03AM +0530, Vaibhav Murkute wrote: > Fixed a coding style issue. > > Signed-off-by: Vaibhav Murkute > --- > drivers/vhost/vsock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-block] (v2. forward to qemu )-Panic with ext4, nbd, qemu-img, block

On Mon, Jan 22, 2018 at 10:06:26AM +0800, Hongzhi, Song wrote: > Hello, > > I create a virtual disk-image using qemu-img. > > And then I use /dev/nbd to map the image. > > I mount the /dev/nbd to a local dir with ext4-format > > Finally, I have some trouble about ext4-filesystem and block

Re: [Qemu-block] (v2. forward to qemu )-Panic with ext4, nbd, qemu-img, block

On Mon, Jan 22, 2018 at 10:06:26AM +0800, Hongzhi, Song wrote: > Hello, > > I create a virtual disk-image using qemu-img. > > And then I use /dev/nbd to map the image. > > I mount the /dev/nbd to a local dir with ext4-format > > Finally, I have some trouble about ext4-filesystem and block

Re: [PATCH] virtio_blk: print capacity at probe time

On Wed, Jan 3, 2018 at 4:03 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > Print the capacity of the block device when the driver is probed. Many > users expect this since SCSI disks (sd) do it. Moreover, kernel dmesg > output is the primary source of troubleshooting info

Re: [PATCH] virtio_blk: print capacity at probe time

On Wed, Jan 3, 2018 at 4:03 PM, Stefan Hajnoczi wrote: > Print the capacity of the block device when the driver is probed. Many > users expect this since SCSI disks (sd) do it. Moreover, kernel dmesg > output is the primary source of troubleshooting information so it's > helpfu

[PATCH] virtio_blk: print capacity at probe time

fre...@redhat.com> Cc: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- drivers/block/virtio_blk.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/

[PATCH] virtio_blk: print capacity at probe time

: Michael S. Tsirkin Signed-off-by: Stefan Hajnoczi --- drivers/block/virtio_blk.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 68846897d213..787cd2a10b0b 100644 --- a/drivers/block

Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()

/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych <gomonov...@gmail.com> > --- > drivers/firmware/qemu_fw_cfg.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()

/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/firmware/qemu_fw_cfg.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

is TCP_SYN_SENT. This change moves the > sk_state change back to the original locations in that function. > > Signed-off-by: Jorgen Hansen <jhan...@vmware.com> > --- > net/vmw_vsock/vmci_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Sorry, silly bug on

Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

is TCP_SYN_SENT. This change moves the > sk_state change back to the original locations in that function. > > Signed-off-by: Jorgen Hansen > --- > net/vmw_vsock/vmci_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Sorry, silly bug on my part! Reviewed-by:

Re: [PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

dive <ad...@vmware.com> > Reviewed-by: Aditya Sarwade <asarw...@vmware.com> > Signed-off-by: Jorgen Hansen <jhan...@vmware.com> > --- > net/vmw_vsock/vmci_transport.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Re: [PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

tya Sarwade > Signed-off-by: Jorgen Hansen > --- > net/vmw_vsock/vmci_transport.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: BUG: unable to handle kernel paging request in vsock_diag_dump

On Tue, Oct 24, 2017 at 08:14:01AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 28f50eb20931f32a2ceeb6aba8fa2cd5ca96ad9f > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel paging request in vsock_diag_dump

On Tue, Oct 24, 2017 at 08:14:01AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 28f50eb20931f32a2ceeb6aba8fa2cd5ca96ad9f > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel paging request in vsock_diag_dump

On Tue, Oct 24, 2017 at 08:14:01AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 28f50eb20931f32a2ceeb6aba8fa2cd5ca96ad9f > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: unable to handle kernel paging request in vsock_diag_dump

On Tue, Oct 24, 2017 at 08:14:01AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 28f50eb20931f32a2ceeb6aba8fa2cd5ca96ad9f > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: > On Wed, Oct 18, 2017 at 6:03 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > > On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: > >> > >> > > Are you saying do it a

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Wed, Oct 18, 2017 at 08:51:37AM -0700, Dan Williams wrote: > On Wed, Oct 18, 2017 at 6:03 AM, Stefan Hajnoczi wrote: > > On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: > >> > >> > > Are you saying do it as existing i.e ACPI pmem like inter

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: > > > > Are you saying do it as existing i.e ACPI pmem like interface? > > > The reason we have created this new driver is exiting pmem driver > > > does not define proper semantics for guest flushing requests. > > > > At this point

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

On Tue, Oct 17, 2017 at 04:30:41AM -0400, Pankaj Gupta wrote: > > > > Are you saying do it as existing i.e ACPI pmem like interface? > > > The reason we have created this new driver is exiting pmem driver > > > does not define proper semantics for guest flushing requests. > > > > At this point

Re: [PATCH 0/9] Intel Processor Trace virtulization enabling

Please send patch series with git's sendemail.thread=shallow and sendemail.chainReplyTo=false settings (see the man git-send-email --thread option for an explanation of the different settings). That way email clients treat the entire series as a single email thread. Patch management and

Re: [PATCH 0/9] Intel Processor Trace virtulization enabling

Please send patch series with git's sendemail.thread=shallow and sendemail.chainReplyTo=false settings (see the man git-send-email --thread option for an explanation of the different settings). That way email clients treat the entire series as a single email thread. Patch management and

Re: [RFC 2/2] KVM: add virtio-pmem driver

On Fri, Oct 13, 2017 at 06:48:15AM -0400, Pankaj Gupta wrote: > > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: > > > +static blk_qc_t virtio_pmem_make_request(struct request_queue *q, > > > + struct bio *bio) > > > +{ > > > + blk_status_t rc = 0; > > > + struct

Re: [RFC 2/2] KVM: add virtio-pmem driver

On Fri, Oct 13, 2017 at 06:48:15AM -0400, Pankaj Gupta wrote: > > On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: > > > +static blk_qc_t virtio_pmem_make_request(struct request_queue *q, > > > + struct bio *bio) > > > +{ > > > + blk_status_t rc = 0; > > > + struct

Re: [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block > device

Re: [RFC 2/2] KVM: add virtio-pmem driver

On Thu, Oct 12, 2017 at 09:20:26PM +0530, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block > device

Re: [RFC] KVM "fake DAX" device flushing

On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality without

Re: [RFC] KVM "fake DAX" device flushing

On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality without

Re: [PATCH net-next RFC 3/5] vhost: introduce vhost_add_used_idx()

drivers/vhost/vhost.c | 33 + > drivers/vhost/vhost.h | 1 + > 2 files changed, 34 insertions(+) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Re: [PATCH net-next RFC 3/5] vhost: introduce vhost_add_used_idx()

rs/vhost/vhost.c | 33 + > drivers/vhost/vhost.h | 1 + > 2 files changed, 34 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [PATCH net-next RFC 2/5] vhost: introduce helper to prefetch desc index

On Fri, Sep 22, 2017 at 04:02:32PM +0800, Jason Wang wrote: > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index f87ec75..8424166d 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2437,6 +2437,61 @@ struct vhost_msg_node *vhost_dequeue_msg(struct >

Re: [PATCH net-next RFC 2/5] vhost: introduce helper to prefetch desc index

On Fri, Sep 22, 2017 at 04:02:32PM +0800, Jason Wang wrote: > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index f87ec75..8424166d 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2437,6 +2437,61 @@ struct vhost_msg_node *vhost_dequeue_msg(struct >

Re: [PATCH net-next RFC 1/5] vhost: split out ring head fetching logic

On Fri, Sep 22, 2017 at 04:02:31PM +0800, Jason Wang wrote: > +/* This looks in the virtqueue and for the first available buffer, and > converts > + * it to an iovec for convenient access. Since descriptors consist of some > + * number of output then some number of input descriptors, it's

Re: [PATCH net-next RFC 1/5] vhost: split out ring head fetching logic

On Fri, Sep 22, 2017 at 04:02:31PM +0800, Jason Wang wrote: > +/* This looks in the virtqueue and for the first available buffer, and > converts > + * it to an iovec for convenient access. Since descriptors consist of some > + * number of output then some number of input descriptors, it's

Re: [PATCH] tools/kvm_stat: Add Python 3 support to kvm_stat

is change, kvm_stat is usable with Python 2.6 and greater. > > Signed-off-by: Jeremy Cline <jer...@jcline.org> > --- > tools/kvm/kvm_stat/kvm_stat | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Re: [PATCH] tools/kvm_stat: Add Python 3 support to kvm_stat

is change, kvm_stat is usable with Python 2.6 and greater. > > Signed-off-by: Jeremy Cline > --- > tools/kvm/kvm_stat/kvm_stat | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote: > > On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote: > If we allow multiple host side transports, virtio host side support and > vmci should be able to coexist regardless of the order of initialization. That

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote: > > On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote: > If we allow multiple host side transports, virtio host side support and > vmci should be able to coexist regardless of the order of initialization. That sounds good to me. This

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

On Tue, Aug 22, 2017 at 09:40:01PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > > > > +static bool hvs_stream_allow(u32 cid, u32 port) > > > > > +{ &

<    1   2   3   4   5   6   7   8   >