Re: [patch 1/2] staging: line6: delete an unused function

On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter dan.carpen...@oracle.com wrote: line6_send_sysex_message_async() isn't called from anywhere. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line

Re: [Line6linux-devel] [PATCH] line6: Use kmemdup rather than duplicating its implementation

On Mon, Dec 3, 2012 at 2:20 PM, Laurent Navet wrote: > staging: line6: driver.c > The semantic patch that makes this output is available > in scripts/coccinelle/api/memdup.cocci. > > Signed-off-by: Laurent Navet > --- > drivers/staging/line6/driver.c |5 ++--- > 1 file changed, 2

Re: [Line6linux-devel] [PATCH] line6: Use kmemdup rather than duplicating its implementation

On Mon, Dec 3, 2012 at 2:20 PM, Laurent Navet laurent.na...@gmail.com wrote: staging: line6: driver.c The semantic patch that makes this output is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/line6/driver.c |

Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

on doing just one thing makes it easier to revert, bisect, and review them. Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

one thing makes it easier to revert, bisect, and review them. Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

return code. > > Signed-off-by: Laurent Navet [Mali] > --- > drivers/staging/line6/pcm.c |8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

the return code. Signed-off-by: Laurent Navet [Mali] laurent.na...@gmail.com --- drivers/staging/line6/pcm.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: KVM Disk i/o or VM activities causes soft lockup?

On Fri, Nov 23, 2012 at 10:34:16AM -0800, Vincent Li wrote: > On Thu, Nov 22, 2012 at 11:29 PM, Stefan Hajnoczi wrote: > > On Wed, Nov 21, 2012 at 03:36:50PM -0800, Vincent Li wrote: > >> We have users running on redhat based distro (Kernel > >> 2.6.32-131.21.1.

Re: KVM Disk i/o or VM activities causes soft lockup?

On Fri, Nov 23, 2012 at 10:34:16AM -0800, Vincent Li wrote: On Thu, Nov 22, 2012 at 11:29 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Nov 21, 2012 at 03:36:50PM -0800, Vincent Li wrote: We have users running on redhat based distro (Kernel 2.6.32-131.21.1.el6.x86_64 ) with kvm

Re: KVM Disk i/o or VM activities causes soft lockup?

On Wed, Nov 21, 2012 at 03:36:50PM -0800, Vincent Li wrote: > We have users running on redhat based distro (Kernel > 2.6.32-131.21.1.el6.x86_64 ) with kvm, when customer made cron job > script to copy large files between kvm guest or some other user space > program leads to disk i/o or VM

[PATCH 02/46] staging: line6: drop clip sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 23 --- drivers/staging/line6/pod.h | 5 - 2 files changed, 28 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index e3e2247..4abe2de 100644 --- a/drivers/staging/line6

[PATCH 01/46] staging: line6: drop channel sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 51 - drivers/staging/line6/pod.h | 5 - 2 files changed, 56 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 4a86f7a..e3e2247 100644

[PATCH 06/46] staging: line6: drop dump_buf sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 40 1 file changed, 40 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 56eab0a..c1eb145 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers

[PATCH 07/46] staging: line6: drop monitor_level sysfs attr

The monitor level can be adjusted using an ALSA volume control. Therefore the sysfs attribute is unnecessary. Note that we leave the monitor_level driver variable so that the ALSA volume control still works. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 12 1

[PATCH 08/46] staging: line6: change monitor_level type ValueWait -> int

The monitor_level sysfs attr has been dropped and we never need to wait on the monitor_level value to change. Switch to a plain int and drop the wait queue. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 10 +- drivers/staging/line6/pod.h | 2 +- 2 files changed, 6

[PATCH 12/46] staging: line6: drop retrieve_channel sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 6d6cd5a..bc65fc7 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -608,16

[PATCH 13/46] staging: line6: drop retrieve_effects_setup sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 48 - 1 file changed, 48 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index bc65fc7..95769c5 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers

[PATCH 14/46] staging: line6: drop store_amp_setup sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 95769c5..deafee9 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -565,16

[PATCH 15/46] staging: line6: drop store_channel sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index deafee9..abf7ebe 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -545,16

[PATCH 16/46] staging: line6: drop store_effects_setup sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 68 - 1 file changed, 68 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index abf7ebe..949b8f7 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers

[PATCH 18/46] staging: line6: drop tuner_freq sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 8 drivers/staging/line6/pod.h | 5 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index f84a4ea..3184570 100644 --- a/drivers/staging/line6/pod.c +++ b

[PATCH 20/46] staging: line6: drop tuner_mute sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 34 -- drivers/staging/line6/pod.h | 5 - 2 files changed, 39 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 57fbe27..df2f37a 100644 --- a/drivers

[PATCH 21/46] staging: line6: drop tuner_pitch sysfs attr

the ALSA volume control should reflect the current monitor volume level used by the device. Therefore, drop the switch statement entirely and just check for POD_monitor_level, ignoring unknown system parameter changes. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 102

Re: [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

On Thu, Nov 22, 2012 at 8:58 PM, Greg Kroah-Hartman wrote: > On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote: >> Markus and I have discussed the MIDI processing that currently happens in the >> line6 driver. This stuff really belongs in userspace where a library or

[PATCH 22/46] staging: line6: drop finish sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 052db4a..797f6e0 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c

[PATCH 24/46] staging: line6: drop midi_mask_receive

of this feature. Therefore we drop it as part of the effort to clean up the staging driver. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/driver.c | 5 - drivers/staging/line6/midi.c | 42 -- drivers/staging/line6/midi.h | 5 - 3 files

[PATCH 19/46] staging: line6: drop tuner_note sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 7 --- drivers/staging/line6/pod.h | 5 - 2 files changed, 12 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 3184570..57fbe27 100644 --- a/drivers/staging/line6/pod.c +++ b

[PATCH 11/46] staging: line6: drop retrieve_amp_setup sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index dbf821e..6d6cd5a 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -628,16

[PATCH 10/46] staging: line6: drop name_buf sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 43 --- 1 file changed, 43 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 76525c5..dbf821e 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers

[PATCH 04/46] staging: line6: drop dirty sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 21 + drivers/staging/line6/pod.h | 5 - 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 8fdbe9f..7c76b65 100644 --- a/drivers

[PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

because the driver presents an ALSA volume control. Stefan Hajnoczi (46): staging: line6: drop channel sysfs attr staging: line6: drop clip sysfs attr staging: line6: drop unused param_dirty bitmap staging: line6: drop dirty sysfs attr staging: line6: drop dump sysfs attr staging: line6

[PATCH 29/46] staging: line6: drop variax model sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 38 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 43 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 8df529f..e76255b 100644

[PATCH 30/46] staging: line6: drop variax volume sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 42 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 47 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index e76255b..ef78f5a

[PATCH 31/46] staging: line6: drop variax tone sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 42 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 47 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index ef78f5a..31ece34

[PATCH 33/46] staging: line6: drop variax bank sysfs attr

The get_string() function is no longer used so drop it too. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 34 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 39 deletions(-) diff --git a/drivers/staging/line6/variax.c b

[PATCH 32/46] staging: line6: drop variax name sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 31ece34..94a9f71 100644 --- a/drivers/staging/line6/variax.c +++ b/drivers

[PATCH 34/46] staging: line6: drop variax dump sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 8eec139..0f1846e 100644 --- a/drivers/staging/line6/variax.c +++ b/drivers/staging

[PATCH 35/46] staging: line6: drop variax active sysfs attr

The get_string() function has no other callers so remove it too. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index

[PATCH 37/46] staging: line6: drop variax raw sysfs attrs

Note that VARIAX_SYSEX_ACTIVATE was never used so drop it along with the other VARIAX_SYSEX_* constants which are now unused. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 73 -- 1 file changed, 73 deletions(-) diff --git a/drivers

[PATCH 39/46] staging: line6: drop amp/effects dump request triggers

Since the driver no longer needs to keep state of device parameters it is no longer necessary to refresh state when messages that affect other parameters are sent. Drop the code to trigger a dump when amp/effects are changed. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 9

[PATCH 43/46] staging: line6: drop variax model_data field

The sysfs attrs to access the model dump have been removed so it's safe to drop the model_data field. The next step will be to simplify the startup process since we no longer need to fetch this data via dump requests, but that will be done in a later patch. Signed-off-by: Stefan Hajnoczi

[PATCH 44/46] staging: line6: drop dump requests from variax startup

The variax startup procedure dumps model data. This is no longer useful since the sysfs attrs which expose this information to userspace have been removed. The dump request wasn't been processed anymore. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 106

[PATCH 45/46] staging: line6: drop dump requests from pod startup

The pod startup procedure dumps model data. This is no longer useful since the sysfs attrs which expose this information to userspace have been removed. The dump request wasn't been processed anymore. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 44

[PATCH 46/46] staging: line6: drop unused dumprequest code

The line6 drive no longer requests MIDI dumps from the device so dumprequest.c is not needed. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/Makefile | 1 - drivers/staging/line6/dumprequest.c | 135 drivers/staging/line6/dumprequest.h | 76

[PATCH 42/46] staging: line6: drop unused pod atomic_flags field

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 11 --- drivers/staging/line6/pod.h | 5 - 2 files changed, 16 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index e892b4a..f8257be 100644 --- a/drivers/staging/line6/pod.c +++ b

[PATCH 38/46] staging: line6: drop CONFIG_LINE6_USB_RAW

the filtering ("raw"). Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/Kconfig | 11 --- drivers/staging/line6/driver.c | 14 -- 2 files changed, 25 deletions(-) diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig index a5ded1

[PATCH 41/46] staging: line6: drop pod prog_data buffers

The driver no longer keeps state of MIDI-accessible device parameters. Drop the buffers but be careful to keep the device startup procedure working even though we no longer store the contents of the dump request. The startup procedure will be simplified in a later patch. Signed-off-by: Stefan

[PATCH 36/46] staging: line6: drop variax guitar sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/variax.c | 22 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 27 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 4600d24..4db21a3 100644 --- a/drivers

[PATCH 28/46] staging: line6: drop tuner param filtering

The pod_set_system_param_int() helper function is only used to set the monitor level. Previously it was also used to control the tuner and has special checks. These checks can now be dropped, along with the tuner constants. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 21

[PATCH 25/46] staging: line6: drop midi_mask_transmit

of it. Therefore we drop it and rely on applications or MIDI sequencers to select the channels used for communication. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/midi.c | 56 drivers/staging/line6/midi.h | 5 2 files changed, 61

[PATCH 26/46] staging: line6: drop midi_postprocess flag

after a dump request have been dropped. Therefore we can safely remove this dead code. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/midi.c | 22 -- drivers/staging/line6/pod.c | 34 -- drivers/staging/line6/pod.h | 7 --- 3

[PATCH 27/46] staging: line6: drop pod.c raw sysfs attr

The raw sysfs attr transmits MIDI messages with less filtering. This was a useful debugging tool while the staging driver still had a lot of state and filtering. It is not useful anymore since the filtering is being dropped. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 13

[PATCH 23/46] staging: line6: drop midi_postprocess sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 797f6e0..37b20d7 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 17/46] staging: line6: drop routing sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 8 drivers/staging/line6/pod.h | 9 - 2 files changed, 17 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 949b8f7..f84a4ea 100644 --- a/drivers/staging/line6/pod.c +++ b

[PATCH 09/46] staging: line6: drop name sysfs attr

Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 165c7ad..76525c5 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c

[PATCH 05/46] staging: line6: drop dump sysfs attr

Once further sysfs attrs have been removed it will also be possible to drop prog_data and other pieces which we keep for now. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 60 +++-- 1 file changed, 3 insertions(+), 57 deletions(-) diff

[PATCH 03/46] staging: line6: drop unused param_dirty bitmap

The param_dirty bitmap tracks which parameters have been modified since saving a preset. The bitmap is never used though so we can drop this deadcode. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 16 drivers/staging/line6/pod.h | 5 - 2 files changed

[PATCH 03/46] staging: line6: drop unused param_dirty bitmap

The param_dirty bitmap tracks which parameters have been modified since saving a preset. The bitmap is never used though so we can drop this deadcode. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 16 drivers/staging/line6/pod.h | 5

[PATCH 05/46] staging: line6: drop dump sysfs attr

Once further sysfs attrs have been removed it will also be possible to drop prog_data and other pieces which we keep for now. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 60 +++-- 1 file changed, 3 insertions(+), 57

[PATCH 09/46] staging: line6: drop name sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 165c7ad..76525c5 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 17/46] staging: line6: drop routing sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 8 drivers/staging/line6/pod.h | 9 - 2 files changed, 17 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 949b8f7..f84a4ea 100644 --- a/drivers/staging

[PATCH 23/46] staging: line6: drop midi_postprocess sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 797f6e0..37b20d7 100644 --- a/drivers/staging/line6/pod.c

[PATCH 26/46] staging: line6: drop midi_postprocess flag

after a dump request have been dropped. Therefore we can safely remove this dead code. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/midi.c | 22 -- drivers/staging/line6/pod.c | 34 -- drivers/staging/line6/pod.h

[PATCH 27/46] staging: line6: drop pod.c raw sysfs attr

The raw sysfs attr transmits MIDI messages with less filtering. This was a useful debugging tool while the staging driver still had a lot of state and filtering. It is not useful anymore since the filtering is being dropped. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging

[PATCH 25/46] staging: line6: drop midi_mask_transmit

of it. Therefore we drop it and rely on applications or MIDI sequencers to select the channels used for communication. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/midi.c | 56 drivers/staging/line6/midi.h | 5 2 files

[PATCH 28/46] staging: line6: drop tuner param filtering

The pod_set_system_param_int() helper function is only used to set the monitor level. Previously it was also used to control the tuner and has special checks. These checks can now be dropped, along with the tuner constants. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging

[PATCH 36/46] staging: line6: drop variax guitar sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 22 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 27 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 4600d24..4db21a3 100644

[PATCH 38/46] staging: line6: drop CONFIG_LINE6_USB_RAW

the filtering (raw). Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/Kconfig | 11 --- drivers/staging/line6/driver.c | 14 -- 2 files changed, 25 deletions(-) diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig index

[PATCH 41/46] staging: line6: drop pod prog_data buffers

The driver no longer keeps state of MIDI-accessible device parameters. Drop the buffers but be careful to keep the device startup procedure working even though we no longer store the contents of the dump request. The startup procedure will be simplified in a later patch. Signed-off-by: Stefan

[PATCH 42/46] staging: line6: drop unused pod atomic_flags field

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 11 --- drivers/staging/line6/pod.h | 5 - 2 files changed, 16 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index e892b4a..f8257be 100644 --- a/drivers/staging

[PATCH 46/46] staging: line6: drop unused dumprequest code

The line6 drive no longer requests MIDI dumps from the device so dumprequest.c is not needed. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/Makefile | 1 - drivers/staging/line6/dumprequest.c | 135 drivers/staging/line6

[PATCH 45/46] staging: line6: drop dump requests from pod startup

The pod startup procedure dumps model data. This is no longer useful since the sysfs attrs which expose this information to userspace have been removed. The dump request wasn't been processed anymore. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 44

[PATCH 44/46] staging: line6: drop dump requests from variax startup

The variax startup procedure dumps model data. This is no longer useful since the sysfs attrs which expose this information to userspace have been removed. The dump request wasn't been processed anymore. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 106

[PATCH 43/46] staging: line6: drop variax model_data field

The sysfs attrs to access the model dump have been removed so it's safe to drop the model_data field. The next step will be to simplify the startup process since we no longer need to fetch this data via dump requests, but that will be done in a later patch. Signed-off-by: Stefan Hajnoczi stefa

[PATCH 39/46] staging: line6: drop amp/effects dump request triggers

Since the driver no longer needs to keep state of device parameters it is no longer necessary to refresh state when messages that affect other parameters are sent. Drop the code to trigger a dump when amp/effects are changed. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging

[PATCH 37/46] staging: line6: drop variax raw sysfs attrs

Note that VARIAX_SYSEX_ACTIVATE was never used so drop it along with the other VARIAX_SYSEX_* constants which are now unused. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 73 -- 1 file changed, 73 deletions

[PATCH 35/46] staging: line6: drop variax active sysfs attr

The get_string() function has no other callers so remove it too. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6

[PATCH 34/46] staging: line6: drop variax dump sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 8eec139..0f1846e 100644 --- a/drivers/staging/line6/variax.c +++ b

[PATCH 33/46] staging: line6: drop variax bank sysfs attr

The get_string() function is no longer used so drop it too. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 34 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 39 deletions(-) diff --git a/drivers/staging

[PATCH 32/46] staging: line6: drop variax name sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 31ece34..94a9f71 100644 --- a/drivers/staging/line6/variax.c

[PATCH 31/46] staging: line6: drop variax tone sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 42 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 47 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index

[PATCH 30/46] staging: line6: drop variax volume sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 42 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 47 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index

[PATCH 29/46] staging: line6: drop variax model sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/variax.c | 38 -- drivers/staging/line6/variax.h | 5 - 2 files changed, 43 deletions(-) diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 8df529f

[PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

because the driver presents an ALSA volume control. Stefan Hajnoczi (46): staging: line6: drop channel sysfs attr staging: line6: drop clip sysfs attr staging: line6: drop unused param_dirty bitmap staging: line6: drop dirty sysfs attr staging: line6: drop dump sysfs attr staging: line6

[PATCH 04/46] staging: line6: drop dirty sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 21 + drivers/staging/line6/pod.h | 5 - 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 8fdbe9f..7c76b65

[PATCH 10/46] staging: line6: drop name_buf sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 43 --- 1 file changed, 43 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 76525c5..dbf821e 100644 --- a/drivers/staging/line6

[PATCH 11/46] staging: line6: drop retrieve_amp_setup sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index dbf821e..6d6cd5a 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 19/46] staging: line6: drop tuner_note sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 7 --- drivers/staging/line6/pod.h | 5 - 2 files changed, 12 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 3184570..57fbe27 100644 --- a/drivers/staging/line6

[PATCH 24/46] staging: line6: drop midi_mask_receive

of this feature. Therefore we drop it as part of the effort to clean up the staging driver. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/driver.c | 5 - drivers/staging/line6/midi.c | 42 -- drivers/staging/line6/midi.h

[PATCH 22/46] staging: line6: drop finish sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 052db4a..797f6e0 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers

Re: [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

On Thu, Nov 22, 2012 at 8:58 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote: Markus and I have discussed the MIDI processing that currently happens in the line6 driver. This stuff really belongs in userspace where

[PATCH 21/46] staging: line6: drop tuner_pitch sysfs attr

the ALSA volume control should reflect the current monitor volume level used by the device. Therefore, drop the switch statement entirely and just check for POD_monitor_level, ignoring unknown system parameter changes. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6

[PATCH 20/46] staging: line6: drop tuner_mute sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 34 -- drivers/staging/line6/pod.h | 5 - 2 files changed, 39 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 57fbe27..df2f37a 100644

[PATCH 18/46] staging: line6: drop tuner_freq sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 8 drivers/staging/line6/pod.h | 5 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index f84a4ea..3184570 100644 --- a/drivers/staging/line6

[PATCH 16/46] staging: line6: drop store_effects_setup sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 68 - 1 file changed, 68 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index abf7ebe..949b8f7 100644 --- a/drivers/staging/line6

[PATCH 15/46] staging: line6: drop store_channel sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index deafee9..abf7ebe 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 14/46] staging: line6: drop store_amp_setup sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 95769c5..deafee9 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 13/46] staging: line6: drop retrieve_effects_setup sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 48 - 1 file changed, 48 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index bc65fc7..95769c5 100644 --- a/drivers/staging/line6

[PATCH 12/46] staging: line6: drop retrieve_channel sysfs attr

Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 6d6cd5a..bc65fc7 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 08/46] staging: line6: change monitor_level type ValueWait - int

The monitor_level sysfs attr has been dropped and we never need to wait on the monitor_level value to change. Switch to a plain int and drop the wait queue. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 10 +- drivers/staging/line6/pod.h | 2 +- 2

<    1   2   3   4   5   6   7   8   >