sion since v3.10.
Stefan Richter (2):
firewire: net: fix use after free
firewire: ohci: fix probe failure with Agere/LSI controllers
drivers/firewire/net.c | 6 +++---
drivers/firewire/ohci.c | 15 ++-
2 files changed, 5 insertions(+), 16 deletions(-)
Thanks.
--
Stef
On Feb 21 Stefan Richter wrote:
> On Feb 20 Tejun Heo wrote:
> > PREPARE_[DELAYED_]WORK() are being phased out. They have few users
> > and a nasty surprise in terms of reentrancy guarantee as workqueue
> > considers work items to be different if they don't have
only the first of these two alternatives can
> +occur.
^^^
...these {,three} alternatives...
--
Stefan Richter
-=-- --=- ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
So rather than deadlock, "the UNLOCK would simply complete". But
/why/ does it complete? It is left unclear (to me at least), why
it would do so. IOW, what mechanism will make it always proceed
to the UNLOCK? Without knowing that, it is left entirely unclear
(to me) why the dea
te the users to set the
> ->workfn fields instead of overriding work functions using
> PREPARE_DELAYED_WORK().
>
> It would probably be best to route this with other related updates
> through the workqueue tree.
>
> Compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Ste
debugging documentation
firewire: ohci: Turn remote DMA support into a module parameter
Stefan Richter (1):
firewire: Enable remote DMA above 4 GB
Documentation/debugging-via-ohci1394.txt | 41
+++--
Documentation/power/basic-pm-debuggin
ter is opened through firewire-sbp2.
Derived from patch "firewire: Enable physical DMA above 4GB" by
Peter Hurley from March 27, 2013.
Signed-off-by: Stefan Richter
---
v2: updated documentation, extended changelog
Documentation/debugging-via-ohci1394.txt | 13 +
dr
On Jan 18 Stefan Richter wrote:
> This makes all of a machine's memory accessible to remote debugging via
> FireWire, using the physical response unit (i.e. RDMA) of OHCI-1394 link
> layer controllers.
>
> This requires actual support by the controller. The only ones currentl
addresses.
Derived from patch "firewire: Enable physical DMA above 4GB" by
Peter Hurley from March 27, 2013.
Signed-off-by: Stefan Richter
---
drivers/firewire/core-transaction.c |6 +++---
drivers/firewire/core.h |3 +++
drivers/firewire/ohci.c |8
On Dec 23 Stefan Richter wrote:
> CC'ing linux1394-devel, quoting in full.
(forgot to Cc akpm, who pointed me to the patch in the first place.)
> On Dec 22 Lubomir Rintel wrote:
> > The old firewire stack is long dead now and a new version firescope has been
> > released w
On Dec 23 Stefan Richter wrote:
> On Dec 22 Lubomir Rintel wrote:
> > This makes it possible to debug kernel over FireWire without the need to
> > recompile it.
> >
> > Cc: Stefan Richter
> > Cc: Dave Hansen
> > Signed-off-by: Lubomir Rintel
>
On Dec 22 Lubomir Rintel wrote:
> This makes it possible to debug kernel over FireWire without the need to
> recompile it.
>
> Cc: Stefan Richter
> Cc: Dave Hansen
> Signed-off-by: Lubomir Rintel
Looks good to me. A load-time option is preferable over a compile-time
option
gt; Signed-off-by: Lubomir Rintel
Reviewed-by: Stefan Richter
> ---
> Documentation/debugging-via-ohci1394.txt | 24 +---
> Documentation/power/basic-pm-debugging.txt | 2 +-
> 2 files changed, 10 insertions(+), 16 deletions(-)
Rob, will you be taking this or sho
gy targets which could malfunction when being subjected to this command
are already sufficiently protected by a scsi_level check in sd + SCSI core.
Stefan Richter (1):
firewire: sbp2: bring back WRITE SAME support
drivers/firewire/sbp2.c | 1 -
1 file changed, 1 deletion
deadlocked between transaction completion handling and bus reset
handling if the worker pool could not be increased in time.
- janitorial updates
Backports of the regression fix for -stable and -longterm will be
posted after upstream merge.
Stefan Richter (3):
firewire: core: typecast
ween 2.5 months ( = a mainline kernel release period)
and more than a year ( = two release periods of typical distributions).
--
Stefan Richter
-=-===-= =--- ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
o the for-next branch.
> -- 8< ---
> dbf2576e37 ("workqueue: make all workqueues non-reentrant") made
> WQ_NON_REENTRANT no-op and the flag is going away. Remove its usages.
>
> This patch doesn't introduce any behavior changes.
>
> Signed-off-by
eintroduce the old behaviour for old clients.
Tested-by: Stepan Salenikovich
Tested-by: Josep Bosch
Cc: # 3.4+
Signed-off-by: Clemens Ladisch
Signed-off-by: Stefan Richter
diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c
index 7ef316f..ac1b
4 protocol drivers. This is especially useful to 1394 audio drivers
for model-specific parameters and methods.
Stefan Richter (2):
firewire: introduce fw_driver.probe and .remove methods
firewire: remove support of fw_driver.driver.probe and .remove methods
drivers/firewire/core-device.c
ver.driver.probe and .remove methods".
This means that starting from tomorrow, any FireWire driver which goes into
linux-next _must_ implement the new methods.
--
Stefan Richter
-=-===-= -==- -=--=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe li
On Jun 02 Greg Kroah-Hartman wrote:
> On Mon, Jun 03, 2013 at 12:27:49AM +0200, Stefan Richter wrote:
> > Although all in-tree drivers are being converted to the new methods,
> > support for the old methods is left in place for the time being, aiming
> > to avoid conflicts if
After all drivers being converted to bus-specific .probe/.remove methods,
remove support of the obsolete generic methods.
Signed-off-by: Stefan Richter
---
To be merged maybe one release cycle after patch "firewire: introduce
fw_driver.probe and .remove methods".
drivers/firewire/cor
error return code.
Although all in-tree drivers are being converted to the new methods,
support for the old methods is left in place for the time being, aiming
to avoid conflicts if/when new drivers are being merged into the
mainline via other trees.
Signed-off-by: Stefan Richter
Cc: Clemens Ladisc
On May 27 Greg Kroah-Hartman wrote:
> Why not pass it in the probe() function, like USB and PCI does? That
> way, if the driver wants to save it for that device, it can.
I will try that, probably at the weekend.
--
Stefan Richter
-=-===-= -=-= ===-=
http://arcgraph.de/sr/
--
To unsub
On May 26 Stefan Richter wrote:
> (Adding LKML and Greg KH, in case that there are general opinions about
> how a bus_type should work.)
>
> On May 26 Takashi Sakamoto wrote:
> > Hi all,
> >
> > I'm a newbile for Linux Firewire subsystem and not used to IE
.driver_data is
currently totally useless.
How about we make it available like in the following patch?
Besides being useful to your presently out-of-tree work, the in-tree
sound/firewire/speakers.c::fwspk_detect() could be rewritten to use this
approach. Maybe I will post an expanded version of
ituation on our system.
[...]
I retract my request to get it retested with mainline since a) the
analysis has clearly shown that a mainline bug is at the root of the
problem, and b) Ralf confirmed now that one of the possible fixes (using
two queues) does in fact work for him like the theory s
lution 3b --- Remove the higher-level worklet's dependency.
E.g. reimplement the higher-level worklet such that it is woken by
a timer and then aborts or reschedules ( = lets the lower-level
worklet bubble up in the queue).
--
Stefan Richter
-=-===-= -=-= =-==-
http://arcgra
e a timer to cancel
outbound transactions if the request-transmit IRQ event was not received
before a timeout. We had such a timeout in the older ieee1394 drivers and
we also had it in earlier versions of the firewire drivers, at a risk of a
race between CPU and OHCI.
--
Stefan Richter
-=-=
> takes too long (>50us).
> > The point being that I don't think this is contributing to the
> > create_worker() +10ms
> > delay.
>
> That depends on. The console on embedded systems (like ours) often runs
> on a serial port with 115200 baud. We measured th
ing PHY register accesses? (Since we can't get rid of
the sleeping ones.) If the accesses are not fully serialized, you will
get corrupt PHY reg reads or writes. If they are fully serialized, the
non-sleeping PHY reg accesses need to go a try-lock route and will be
forced to erro
del in the normal case (no
> work running on the rescuer thread). Maybe it's worth to think about
> that because some work looks rather heavy to me.
>
> Regards,
>
> Stephan
There is quite a bit going on in firewire-ohci's and firewire-core's parts
of self-ID-c
i: Improve bus reset error messages
firewire: ohci: dump_stack() for PHY regs read/write failures
Stefan Richter (3):
firewire: core: remove an always false test
firewire: sbp2: replace BUG_ON by WARN_ON
firewire: remove unnecessary alloc/OOM messages
drivers/firewire
restricted gfp_t
So let's convert from gfp_t bitfield to Boolean explicitly and safely.
Signed-off-by: Stefan Richter
---
drivers/firewire/core-cdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -485,7 +
) root
This failure no longer happens after the patch, without an obvious
reason for the failure or the fix.]
[Stefan R: Added quirk flag, quirk table entry, and comment.]
Reported-by: Tim Jordan
Signed-off-by: Peter Hurley
Signed-off-by: Stefan Richter
---
drivers/firewire/ohci.c
ds.
So I believe we should white-list the shorter wait after LPS write
only for Agere/LSI cards. I will be replying with a respective patch
shortly.
--
Stefan Richter
-=-===-= -=-- ===--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
}
This duplicates a mistake (?) that we already did a few times elsewhere in
firewire-ohci: msleep(1) may put the thread to sleep for much, much longer
than 1 millisecond. I will propose a patch soon.
--
Stefan Richter
-=-===-= -=-- ===--
http://arcgraph.de/sr/
--
To unsubscribe from this list:
On Mar 26 Stefan Richter wrote:
> On Mar 26 Peter Hurley wrote:
> > On Tue, 2013-03-26 at 19:56 +0100, Stefan Richter wrote:
> > > It has been a long time though since I last checked whether PhyUpperBound
> > > is implemented; maybe it has become more wides
On Mar 26 Peter Hurley wrote:
> On Tue, 2013-03-26 at 19:56 +0100, Stefan Richter wrote:
> > It has been a long time though since I last checked whether PhyUpperBound
> > is implemented; maybe it has become more widespread than it was back then.
> >
> > Or maybe it h
sn't: All OHCI-1394 chips that ever came to market are 32
bit chips anyway. So the few rare ones that do support PhyUpperBound
larger than 4 GB cannot in fact use it.
Or am I severely behind the times about this?
--
Stefan Richter
-=-===-= --== ==-=-
http://arcgraph.de/sr/
--
To unsu
These are redundant to log messages from the mm core.
Signed-off-by: Stefan Richter
---
drivers/firewire/core-cdev.c | 24 +---
drivers/firewire/core-device.c |4 +---
drivers/firewire/net.c |7 +--
drivers/firewire/ohci.c|3 ---
drivers
No need to crash and burn if S/G element sizes cannot be set to our
liking; just leave a message in the log.
Signed-off-by: Stefan Richter
---
drivers/firewire/sbp2.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewire/sbp2.c
struct fw_cdev_allocate_iso_resource.bandwidth is unsigned.
Signed-off-by: Stefan Richter
---
drivers/firewire/core-cdev.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -1365,8 +1365,7 @@ static int
data are indeed
never accessed in other contexts besides the workers.
- For serialization in non-atomic context, a struct mutex is usually
preferred over a struct semaphore. The foremost advantage of mutexes
over counting semaphores is that code using the former can be
ewire/sbp2.c
> +++ b/drivers/firewire/sbp2.c
> @@ -1636,9 +1636,7 @@ MODULE_LICENSE("GPL");
> MODULE_DEVICE_TABLE(ieee1394, sbp2_id_table);
>
> /* Provide a module alias so root-on-sbp2 initrds don't break. */
> -#ifndef CONFIG_IEEE1394_SBP2_MODULE
> MODULE_ALIAS(
4/linux1394.git
> S: Maintained
> F: drivers/firewire/
> -F: include/linux/firewire.h
> +F: include/linux/firewire*.h
> F: include/uapi/linux/firewire*.h
> F: tools/firewire/
>
I prefer "include/linux/firewire.h".
--
Stefan Richter
-=-===-= --==
ter 3.8/
before 3.9-rc1, IOW 3.8 is not affected. (I notified akpm who handles the
faulty patch.)
--
Stefan Richter
-=-===-= --=- =--==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.o
zed in this function [-Wuninitialized]
Signed-off-by: Tim Gardner
Signed-off-by: Stefan Richter
---
Andrew, please send this on together with the other idr patches,
or even merge this into patch "firewire: convert to idr_alloc()" before
the latter reaches upstream.
drivers/firewire/core-device.
- err = ohci_enable(&ohci->card, NULL, 0);
> + err = ohci_enable_regs(&ohci->card, NULL, 0);
> if (err)
> return err;
>
> + ohci_enable_irq(ohci);
> + ohci_enable_run(ohci);
> +
> ohci_resume_iso_dma(ohci);
>
nor upper limit check.
>
> Signed-off-by: Tejun Heo
> Cc: Stefan Richter
> Cc: linux1394-de...@lists.sourceforge.net
Acked-by: Stefan Richter
> ---
> drivers/firewire/core-cdev.c | 19 ++-
> drivers/firewire/core-device.c |8 +---
> 2
On Feb 04 Tejun Heo wrote:
> fw_device_init() didn't check whether the allocated minor number isn't
> too large. Fail if it goes overflows MINORBITS.
>
> Signed-off-by: Tejun Heo
> Suggested-by: Stefan Richter
> Cc: sta...@vger.kernel.org
> ---
> dri
On Feb 03 Stefan Richter wrote:
> On Feb 02 Tejun Heo wrote:
> > --- a/drivers/firewire/core-device.c
> > +++ b/drivers/firewire/core-device.c
> > @@ -1017,13 +1017,12 @@ static void fw_device_init(struct work_struct *work)
> >
> > fw_device_get(device);
&g
On Feb 02 Tejun Heo wrote:
> Convert to the much saner new idr interface.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Stefan Richter
> Cc: linux1394-de...@lists.sourceforge.net
> ---
> This patch depends on an earlier idr changes and I think it wou
On Feb 02 Alan Stern wrote:
> On Sat, 2 Feb 2013, Stefan Richter wrote:
>
> > On Feb 01 Mark Einon wrote:
> > > On 1 February 2013 21:09, Peter Hurley wrote:
> > > >>>> On Jan 29 Alan Stern wrote:
> > > >>>>> Why does the pci
ything to plug into the port.
> I assume that any large changes I make are quite capable of breaking
> something there...
This is a valid assumption. Some years ago I caused a regression in
stable kernel branches in exactly this way myself.
--
Stefan Richter
-=-===-= --=- ---=-
http://arcgrap
On Jan 30 Mark Einon wrote:
> On 29 January 2013 16:04, Stefan Richter wrote:
> > Added Cc: linux-pm.
> >
> > On Jan 29 Mark Einon wrote:
> >> On 28 January 2013 23:01, Stefan Richter wrote:
> >> > On Jan 28 Mark Einon wrote:
> >> >> This
Added Cc: linux-pm.
On Jan 29 Mark Einon wrote:
> On 28 January 2013 23:01, Stefan Richter wrote:
> > On Jan 28 Mark Einon wrote:
> >> This patch fixes the kernel warning generated when putting an MSI MS-1727
> >> GT740 laptop into suspend mode. The call sequence in th
pci_disable_msi(dev);
> err = pci_save_state(dev);
> if (err) {
> @@ -3807,6 +3807,7 @@ static int pci_resume(struct pci_dev *dev)
> return err;
>
> ohci_resume_iso_dma(ohci);
> + enable_irq(dev->irq);
>
> r
On Jan 25 Tejun Heo wrote:
> idr_destroy() can destroy idr by itself and idr_remove_all() is being
> deprecated. Drop its usage.
>
> Signed-off-by: Tejun Heo
> Cc: Stefan Richter
> Cc: linux1394-de...@lists.sourceforge.net
> ---
> This patch depends on an earlier
his actually does the job of
Indeed neither the device nor the lower drivers check protocol checksums.
But the CRCs of the encapsulating 1394 packets are checked in hardware.
Shall protocol checksums be verified regardless?
--
Stefan Richter
-=-===-= ---= =-=--
http://arcgraph.de/sr/
--
To unsubscrib
> On Dec 15 Peter Hurley wrote:
> > The firewire core does not require or want the suggested helper fns;
> > drop suggestion from TODO file.
PS,
the patch and the other five look good to me.
--
Stefan Richter
-=-===-- ==-- -
http://arcgraph.de/sr/
--
To unsubscribe from
e.
[That's too many words about a two- or three-line piece of code; but on the
on the other hand it is a generally relevant consideration whenever new
functionality is to be added somewhere in the driver stack.]
--
Stefan Richter
-=-===-- ==-- -
http://arcgraph.de/sr/
--
To unsubscrib
Signed-off-by: Stefan Richter
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 386fce6..9722918 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3071,7 +3071,8 @@ W:http://ieee1394.wiki.kernel.org/
T: git git
allow thin-provisioning related commands
- trivia
Thanks.
Stefan Richter (2):
tools/firewire: nosy-dump: check for allocation failure
firewire: sbp2: allow WRITE SAME and REPORT SUPPORTED OPERATION CODES
Stephan Gatzka (1):
firewire: net: Fix handling of fragmented multicast/broadca
On Dec 03 Wei Yongjun wrote:
> The variable card is initialized but never used
> otherwise, so remove the unused variable.
Committed to linux1394.git.
--
Stefan Richter
-=-===-- ==-- ---==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux
u ignore the cards actual
capability and just allocate 4096 bytes.
OHCIs that you can buy offer fw_card.max_receive of 1024, or 2048, or 4096
bytes.
1024 bytes is the limit of many but not all 1394a S400 CardBus cards.
[Issues of transaction retries and possible loss at session termination to b
On Nov 13 Peter Hurley wrote:
> On Tue, 2012-11-13 at 00:33 +0100, Stefan Richter wrote:
> > On Nov 02 Peter Hurley wrote:
> > > +2. MAX_ASYNC_PAYLOAD needs to be publicly exposed by core/ohci
> > > + - otherwise how will this driver know the max size of address window
is contiguously mapped)
For the particular application "firewire-net", the present AR-Req DMA
buffer size has apparently been determined as suitable. Of course if you
find a different optimum, that could certainly be changed.
I haven't looked closely, but I suppose you
taging/fwserial/dma_fifo.h | 130 ++
> > drivers/staging/fwserial/fwserial.c | 2885
> > +++++++
> > drivers/staging/fwserial/fwserial.h | 355 +
drivers/firewire/net.c is 1721 lines, sbp_target is 2868 lines.
Why is fwserial bigger?
--
Stefan Richter
-=
nsactions:
http://marc.info/?l=linux1394-devel&m=109128028930225
That's at the physical layer; link layer and application layer performances
are less than that of course.
--
Stefan Richter
-=-===-- =-=- =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscr
Behavior of null pointer dereference is undefined in the C language.
Portably implement the desired behavior.
Reported-by: Yang Yeping
Signed-off-by: Stefan Richter
---
tools/firewire/nosy-dump.c |4
1 file changed, 4 insertions(+)
--- a/tools/firewire/nosy-dump.c
+++ b/tools
vel IRQ time accounting (IRQ_TIME_ACCOUNTING)
choice[1-2]: ?
There is no help available for this option.
I wonder if make oldconfig could be made smarter about presenting
help for choice prompts. As a complication, this particular
prompt's set of items differs from architecture to arch
Linus,
please pull from the tag "firewire-fix" at
git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git
firewire-fix
to get an old bug of the /dev/fw* ioctl ABI fixed. Thanks.
Stefan Richter (1):
firewire: cdev: fix user memory corruption (i386 userlan
truct fw_cdev_event_bus_reset.
Reported-by: Simon Kirby
Signed-off-by: Stefan Richter
Cc: sta...@kernel.org
---
drivers/firewire/core-cdev.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -473,8 +473,8 @@ stati
would I have it? The
> description says it's for SELinux, which I do not use.
It says it is /among else/ for SELinux. Another user appears to be
ConsoleKit, which wants CONFIG_AUDITSYSCALL, which depends on CONFIG_AUDIT.
--
Stefan Richter
-=-===-- =-=- --=--
http://arcgraph.de
k handling of a TI S400B phy,
- avoid holding a core lock while calling into highlevel drivers.
Thanks.
Clemens Ladisch (1):
firewire: core: feed /dev/random with devices' GUIDs
Peter Hurley (1):
firewire: remove global lock around address handlers, convert to RCU
St
On Sep 27 Stefan Richter wrote:
> --- a/drivers/firewire/core-transaction.c
> +++ b/drivers/firewire/core-transaction.c
> @@ -489,7 +489,7 @@ static struct fw_address_handler *lookup
> {
> struct fw_address_handler *handler;
>
> - list_for_each_entr
r() and in
fw_core_remove_address_handler(), and document that process context
is now required for fw_core_add_address_handler().
- Extend the documentation of fw_address_callback_t.
Signed-off-by: Stefan Richter
---
drivers/firewire/core-transaction.c | 13 -
inc
DMA tasklet for inbound request events.)
In other words, address handlers are now called in an RCU read-side
critical section instead of from within a spin_lock_bh serialized
section.
(Changelog rewritten by Stefan R.)
Signed-off-by: Peter Hurley
Signed-off-by: Stefan Richter
---
Peter, are you
to fix this when I get some time.
--
Stefan Richter
-=-===-- =--= -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
7;s fail: path is executed outside the
client->lock protected section. That might be a problem. I need to look
further into it.)
--
Stefan Richter
-=-===-- =--= -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messa
530 94268 12725 14161
> 12829 16951 TLB shootdowns
> TRM: 0 0 0 0 0 0
> 0 0 Thermal event interrupts
> THR: 0 0 0 0 0 0
>
evice->config_rom_retries = 0;
>
> set_broadcast_channel(device, device->generation);
> +
> + add_device_randomness(&device->config_rom[3], 8);
> }
>
> /*
--
Stefan Richter
-=-===-- =--- -==--
http://arcgraph.de/sr/
-
().
This is often because uncore_types_exit lacks a __init
annotation or the annotation of uncore_type_exit is wrong.
HTH,
--
Stefan Richter
-=-===-- =--- --=-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
IR with buffers larger than 2 GB
firewire: ohci: initialize multiChanMode bits after reset
firewire: core: add is_local sysfs device attribute
Stefan Richter (1):
firewire: core: document is_local sysfs attribute
Documentation/ABI/stable/sysfs-bus-firewire | 11 +++
d
compiler warnings?
Thanks,
--
Stefan Richter
-=-==--- --=- ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
ake -j..." is supposed to work. I use it all the time
and also did runtime tests of -rc2 and -rc3 built in that way, FWIW.
--
Stefan Richter
-=-==--- --=- ==--=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
Thanks for retesting.
--
Stefan Richter
-=-==--- --=- ==--=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ieee1394/sbp2.c | 15 +
> drivers/ieee1394/sbp2.h |2 +
> 7 files changed, 350 insertions(+), 109 deletions(-)
>
> Stefan Richter (19):
> firewire: fw-sbp2: unsigned int vs. unsigned
> firewire: fw-sbp2: fix logout before login retry
>
ivers/firewire/fw-device.h |2 +-
drivers/firewire/fw-sbp2.c | 358 +-
drivers/ieee1394/sbp2.c | 15 +
drivers/ieee1394/sbp2.h |2 +
7 files changed, 350 insertions(+), 109 deletions(-)
Stefan Richte
Add wrappers for getting and putting a unit.
Remove some line breaks.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-device.h | 27 +--
drivers/firewire/fw-sbp2.c |4 ++--
2 files changed, 19 insertions(+), 12 deletions(-)
Index:
The reference count of the unit dropped too low in an error path in
sbp2_probe. Fixed by moving the _get further up.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-sbp2.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux/drivers/firewire/f
the node is
to be shut down.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-card.c| 10 +-
drivers/firewire/fw-device.c | 21 ++---
drivers/firewire/fw-device.h | 16 ++--
drivers/firewire/fw-sbp2.c
The card->kref became obsolete since patch "firewire: fix crash in
automatic module unloading" added another counter of card users.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-card.c| 38 --
drivers
out of fw_card_bm_work's sight during shutdown of the
card.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-card.c | 51 ++---
drivers/firewire/fw-topology.c |1
2 files changed, 35 insertions(+), 17 deletions(-)
Index: linux/dr
bp2.c|9 ++-
drivers/firewire/fw-topology.c|1
drivers/firewire/fw-transaction.h |6 --
7 files changed, 89 insertions(+), 90 deletions(-)
--
Stefan Richter
-=-==--- --=- ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe li
NFIG_FIREWIRE_OHCI off in the kernel config of
2.6.25-rc2, rebuild and reinstall the modules and reboot, does the
problem vanish?
--
Stefan Richter
-=-==--- --=- =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
ets. (Some PL-3507 only accept unified
transactions, hence this test needs to be performed with other bridge
chips.)
--
Stefan Richter
-=-==--- --=- =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
evice in should already cause enough generation
changes for the code to trip over an endianess bug before or after thhe
patch, me thinks.
--
Stefan Richter
-=-==--- --=- =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
tion.h:93:10:got restricted unsigned int
[usertype]
drivers/firewire/fw-ohci.c:1490:8: warning: restricted degrades to integer
drivers/firewire/fw-ohci.c:1490:35: warning: restricted degrades to integer
drivers/firewire/fw-ohci.c:1516:5: warning: cast to restricted type
Signed-off-by: St
101 - 200 of 1128 matches
Mail list logo
