request_mem_region failed (was: dv camera no longer recognized)

2007-11-05 Thread Stefan Richter
ides the kernel update, did you change anything in the BIOS or even the hardware? Do you boot the old kernels with the same boot parameters as you did before you added the new kernel? -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "

Re: VIA VT6307 OHCI version?

2007-11-05 Thread Stefan Richter
Krzysztof Halasa wrote: > I guess Stefan could now try to write these values (except GUID > and probably PCI subsystem IDs, and with OHCI 1.1 bit) to the "bad" > card :-) I will get back to this in about two weeks. -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/s

Re: [PATCH] Spelling fix: lenght->length

2007-11-04 Thread Stefan Richter
Paulius Zaleckas wrote: > -/* get digits lenght, skiping blank spaces. */ > +/* get digits length, skiping blank spaces. */ skiping -> skipping I haven't checked any of the other hunks for further spelling errors; please have a look at them. -- Stefan Richter -=-=-=== =

[GIT PULL] FireWire update

2007-11-04 Thread Stefan Richter
d-by: Torsten Kaiser <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> diff --git a/drivers/ieee1394/dma.c b/drivers/ieee1394/dma.c index f5f4983..7c4eb39 100644 --- a/drivers/ieee1394/dma.c +++ b/drivers/ieee1394/dma.c @@ -103,8 +103,7 @@ int dma_region_alloc(struct

Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!

2007-11-04 Thread Stefan Richter
decide whether a SCSI low-level driver should enable chained s/g lists? The SBP-2 protocol supports s/g lists with up to 65535 entries. The sbp2 and fw-sbp2 driver limit this currently to SG_ALL. -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/sr/ - To unsubscribe from this li

Re: [PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix

2007-11-04 Thread Stefan Richter
Don't panic on chained s/g lists. Only compile-tested. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- Update: The loop body doesn't honor the 80 columns limit either. Can be cleaned up later by renaming a variable. drivers/ieee1394/sbp2.c |2 +- 1 file changed, 1

[PATCH 3/3 2.6.24-rc1-gitX] firewire: fw-sbp2: s/g list fix

2007-11-04 Thread Stefan Richter
Don't panic on chained s/g lists. Only compile-tested. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-sbp2.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux/drivers/firewir

[PATCH 2/3 2.6.24-rc1-gitX] ieee1394: sbp2: s/g list fix

2007-11-04 Thread Stefan Richter
Don't panic on chained s/g lists. Only compile-tested. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/sbp2.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux/drivers/ieee

[PATCH 1/3 2.6.24-rc1-gitX] ieee1394: iso and async streams: s/g list fix

2007-11-04 Thread Stefan Richter
ten Kaiser <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/dma.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.24-rc1/drivers/ieee1394/dma.c === ---

Re: VIA VT6307 OHCI version?

2007-11-03 Thread Stefan Richter
this page). The documentation of the tool also contains a partial description of the EEPROM contents. -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] M

Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!

2007-11-03 Thread Stefan Richter
Torsten Kaiser wrote: > On 11/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> To which extent do you need IEEE 1394 drivers? > > Using eth1394 as primary network connection on this computer. > So switching to the new stack is currently not an option, That's rig

Re: 2.6.24-rc1-git11: Reported regressions from 2.6.23

2007-11-03 Thread Stefan Richter
: Torsten Kaiser <[EMAIL PROTECTED]> References : http://lkml.org/lkml/2007/11/2/240 Handled-By : Jens Axboe <[EMAIL PROTECTED]> Stefan Richter <[EMAIL PROTECTED]> -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/sr/ - To unsubscri

Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!

2007-11-02 Thread Stefan Richter
t; 51 sg->page_link = page_link | (unsigned long) page; >> 52 } >> 53 > > Uh oh... > > I'm afraid the ieee1394 core's own scatter-gather list managing code > didn't survive the changes in the kernel's s/g list implementation. >

Re: 2.6.24-rc1-54866f032307063776b4eff7eadb131d47f9f9b4 fails to boot: kernel BUG at include/linux/scatterlist.h:49!

2007-11-02 Thread Stefan Richter
entation. Alas I will be quite busy with non-Linux related stuff during at least the next two weeks and can't fix this myself for now. -- Stefan Richter -=-=-=== =-== ---=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Stefan Richter
Nick Piggin wrote: > On Thursday 01 November 2007 12:49, Stefan Richter wrote: >> fw_device.node_id and fw_device.generation are accessed without mutexes. >> We have to ensure that all readers will get to see node_id updates >> before generation updates. >> > > H

Re: RFC: remove CONFIG_EXPERIMENTAL

2007-11-01 Thread Stefan Richter
in production and trains users to lower their expectations. -- Stefan Richter -=-=-=== =-== = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

[PATCH] firewire: fw-core: react on bus resets while the config ROM is being fetched

2007-10-31 Thread Stefan Richter
e ROM reading. We now restart reading the ROM if the bus generation changed. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-device.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) Index: linux/drivers/firewire/

[PATCH] firewire: fw-sbp2: enforce read order of device generation and node ID

2007-10-31 Thread Stefan Richter
ned-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-sbp2.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Index: linux/drivers/firewire/fw-sbp2.c === --- linux.orig/drivers/firewire/fw-

[PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Stefan Richter
fw_device.node_id and fw_device.generation are accessed without mutexes. We have to ensure that all readers will get to see node_id updates before generation updates. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-device.c |6 ++ drivers/firew

[GIT PULL] FireWire updates

2007-10-31 Thread Stefan Richter
by the Intel C Compiler. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> diff --git a/drivers/ieee1394/ieee1394_transactions.c b/drivers/ieee1394/ieee1394_transactions.c index c39c70a..6779893 100644 ---

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Stefan Richter
Cornelia Huck wrote: > On Wed, 31 Oct 2007 10:52:35 +0100, > Stefan Richter <[EMAIL PROTECTED]> wrote: >> if (!grp->is_visible || >> grp->is_visible(kobj, *attr, i)) >> add or remove(); >>

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Stefan Richter
urn the meaning of the callback > around? > > for (...) { > if (grp->mask_out && grp->mask_out(kobj, *attr, i)) > continue; > error |= sysfs_add_file(...); > } if (!grp->is_visible || grp->is_visib

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Stefan Richter
James Bottomley wrote: > OK, so is this latest revision acceptable to everyone? No complaint from me. (I'm more or less by accident in this thread anyway. Once this feature is available in mainline, I may have use for it in drivers/firewire/ though.) Thanks, -- Stefan

Re: [PATCH] sysfs: add filter function to groups

2007-10-29 Thread Stefan Richter
ed. How about this: int (*is_visible)(...); or bool (*shall_be_shown)(...); or bool (*should_be_displayed)(...); or whatever, so that it indicates that this function merely answers a question, but doesn't filter nor show anything. -- Stefan Richter -=-=-===

Re: VIA VT6307 OHCI version?

2007-10-28 Thread Stefan Richter
Krzysztof Halasa wrote: > Stefan Richter <[EMAIL PROTECTED]> writes: >> # ./a.out 00:0a.3 >> I/O region #1 is at C800 >> It seems your VT6307 chip is connected to 93c46 EEPROM > > Interesting, really. Perhaps they aimed at I2C too with 9306 but >

Re: VIA VT6307 OHCI version?

2007-10-28 Thread Stefan Richter
UID PROM register is at virtual address 0xb7f2f004 EEPROM dump: 00: 00 11 06 00 00 00 41 CC 04 04 32 55 F8 00 92 02 10: A1 00 40 63 06 11 44 30 03 DF 40 80 00 20 00 73 20: 3C 10 00 00 00 00 A0 00 FF FF FF FF FF FF FF FF Your VT6307 chip is in OHCI 1.0 mode

Re: [2.6 patch] ieee1394_transactions.c: remove dead code

2007-10-28 Thread Stefan Richter
Adrian Bunk wrote: > This patch removes dead code spotted by the Intel C Compiler. Committed to linux1394-2.6.git, thanks. -- Stefan Richter -=-=-=== =-=- ===-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: eradicating out of tree modules

2007-10-28 Thread Stefan Richter
Tilman Schmidt wrote: > Am 28.10.2007 10:25 schrieb Stefan Richter: >> You two are hypothesizing. > > No, we're not. We're discussing the very real issue of whether > LSM should be amputated in such a way as to make life difficult > for out of tree security module d

Re: eradicating out of tree modules

2007-10-28 Thread Stefan Richter
o feed their changes into mainline, IOW to take part in the Linux kernel project. ²) Of course if such projects chose to become part of the Linux kernel project, they would get to enjoy additional bonuses as outlined at the end of stable_api_nonsense.txt. Sure, becoming part of the project i

Re: eradicating out of tree modules

2007-10-27 Thread Stefan Richter
Tilman Schmidt wrote about: > breaking interfaces they rely on for no other "very good > reason" than to discourage out-of-tree development? How often did this happen yet? -- Stefan Richter -=-=-=== =-=- ==-== http://arcgraph.de/sr/ - To unsubscribe from this list: send the l

[GIT PULL] FireWire updates

2007-10-22 Thread Stefan Richter
changed, 9 insertions(+), 4 deletions(-) Stefan Richter (2): firewire: fw-ohci: log a note about unsupported features firewire: fw-ohci: shut up a superfluous compiler warning Full log and diff: commit 4b6d51ec62d9c57432430528d6293605794a9f1b Author: Stefan Richter <[EMAIL PROTEC

[PATCH] firewire: fw-ohci: shut up a superfluous compiler warning

2007-10-21 Thread Stefan Richter
unction Access to payload_bus is conditional on packet->payload_length > 0, and that won't change while in at_context_queue_packet. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c |2 +- 1 file changed, 1 insertion(+), 1 delet

Re: VIA VT6307 OHCI version?

2007-10-20 Thread Stefan Richter
n. Both chips are quite widespread. From what I remember to have seen, most VT6307 are programmed in OHCI 1.1 mode while all VT6306 seem to be OHCI 1.0. -- Stefan Richter -=-=-=== =-=- =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: VIA VT6307 OHCI version?

2007-10-19 Thread Stefan Richter
register contents which state OHCI 1.0 implementation level, and just treats these VIA chips as OHCI 1.1 implementations? -- Stefan Richter -=-=-=== =-=- =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [

Re: VIA VT6307 OHCI version?

2007-10-17 Thread Stefan Richter
Krzysztof Halasa wrote: > Is the "dual buffer reception" involved in receiving video from > a DV camera, using the new driver? Yes, isochronous reception (and thus DV) with the new drivers currently requires dual buffer mode. -- Stefan Richter -=-=-=== =-=- =---= http://arcg

Re: VIA VT6307 OHCI version?

2007-10-17 Thread Stefan Richter
Krzysztof Halasa wrote: > Stefan Richter <[EMAIL PROTECTED]> writes: > >> And in case of VT6307, I suspect it's VIA who >> selects the implementation level (based on chip revision), not the card >> vendor. > > Can't be, the customers (real ones - bo

Re: What still uses the block layer?

2007-10-17 Thread Stefan Richter
in common. The only thing that could be common in the best case is the symlink to the partition's device file, based on filesystem UUID or filesystem label. ¹) unless you write your own rule specific to this on particular enclosure -- Stefan Richter -=-=-=== =-=- =---= http://arcgra

[GIT PULL] FireWire updates post 2.6.23

2007-10-16 Thread Stefan Richter
thias Kaehlcke (1): ieee1394: ieee1394_core.c: use DEFINE_SPINLOCK for spinlock definition Satyam Sharma (1): ieee1394: Fix kthread stopping in nodemgr_host_thread Stefan Richter (20): ieee1394: eth1394: superfluous local variable ieee1394: eth1394: fix lock imbalance iee

Re: VIA VT6307 OHCI version?

2007-10-16 Thread Stefan Richter
; i.e. this documentation can't be trusted to begin with. As far as VT6306 is concerned, the wording could be copy'n'waste from the VT6307 datasheet. And in case of VT6307, I suspect it's VIA who selects the implementation level (based on chip revision), not the

Re: What still uses the block layer?

2007-10-16 Thread Stefan Richter
iding speaking default names for device files, just like we already provide speaking default names for network interfaces. (Not for all, but for many.) -- Stefan Richter -=-=-=== =-=- = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: What still uses the block layer?

2007-10-16 Thread Stefan Richter
ose once PATA went into the SCSI namespace and then this namespace is divided again, it's not a big issue anymore whether PATA and SATA share an ATA namespace or are distinct, except perhaps for people with IDE drive and eSATA slots. -- Stefan Richter -=-=-=== =-=- = http://arcgra

Re: [PATCH corrected] firewire: fw-ohci: fix DMA mapping for ar context

2007-10-16 Thread Stefan Richter
I wrote: > The CPU must not touch the buffer after it was DMA-mapped. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > drivers/firewire/fw-ohci.c |1 + > 1 file changed, 1 insertion(+) > > Index: li

[PATCH] firewire: fw-ohci: avoid an atomic allocation

2007-10-16 Thread Stefan Richter
All of the buffers which are allocated during fw-ohci's pci_probe can be allocated with GFP_KERNEL. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6.23-rc6/drivers/

[PATCH] firewire: fw-ohci: optimize initialization of ar context

2007-10-16 Thread Stefan Richter
Sync only the parts for CPU which are actually accessed by the CPU. Replace a memset by direct assignment. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) Index: linux/d

[PATCH corrected] firewire: fw-ohci: fix DMA mapping for ar context

2007-10-16 Thread Stefan Richter
The CPU must not touch the buffer after it was DMA-mapped. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c |1 + 1 file changed, 1 insertion(+) Index: linux/drivers/firewire/fw-

Re: [PATCH] firewire: fw-ohci: fix DMA mapping for ar context

2007-10-16 Thread Stefan Richter
rection follows in a minute. -- Stefan Richter -=-=-=== =-=- = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH] firewire: fw-ohci: fix DMA mapping for ar context

2007-10-16 Thread Stefan Richter
The CPU must not touch the buffer after it was DMA-mapped. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) Index: linux/drivers/firewire/fw-

Re: What still uses the block layer?

2007-10-15 Thread Stefan Richter
driver make use of the new naming functions in lib/, providing either just "sd", "sr" etc. or "sd-$transport-" as name prefix No patch yet, and alas I'm currently short of spare time. -- Stefan Richter -=-=-=== =-=- = http://arcgraph.de/sr/

Re: What still uses the block layer?

2007-10-15 Thread Stefan Richter
[EMAIL PROTECTED] wrote: > On Mon, 15 Oct 2007, Stefan Richter wrote: >> Low-level networking drivers suggest a default interface name (per >> interface or as a template like eth%d into which the networking core >> inserts a lowest spare number). ... >> Could low-level S

Re: What still uses the block layer?

2007-10-15 Thread Stefan Richter
-0 - a USB CD-ROM, /dev/st-fw-0- a FireWire tape drive, /dev/sda- a device whose transport driver didn't propose a name Of course the really interesting names will still be provided by udev-generated symlinks. -- Stefan Richter -=-=-=== =-=- - http://arcgraph.de/sr/ - To u

Re: What still uses the block layer?

2007-10-14 Thread Stefan Richter
SBP-2 is a SCSI transport protocol, hence ieee1394/sbp2 and firewire/fw-sbp2 are Linux SCSI low-level drivers. Anything else would be just wrong and infeasible in this particular case. -- Stefan Richter -=-=-=== =-=- - http://arcgraph.de/sr/ - To unsubscribe from this list: send the line

Re: [PATCH] fw-cdev __user annotations

2007-10-14 Thread Stefan Richter
;packets); > end = (void __user *)p + request->size; > count = 0; > while (p < end) { Acked-by: Stefan Richter <[EMAIL PROTECTED]> I will enqueue it in case Linus doesn't pick it up before my next pull request. -- Stefan Richter -=-=-=== =-=- -===- http:

Re: What still uses the block layer?

2007-10-14 Thread Stefan Richter
e is out for a fight rather than interested in help. -- Stefan Richter -=-=-=== =-=- -===- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
Jan Engelhardt wrote: > On Oct 13 2007 10:16, Stefan Richter wrote: >> Perhaps say >> >> warning("override: switching to choice %s", sym->name); >> >> if sym->name is [CONFIG_]PREEMPT_VOLUNTARY. Or what is it? > > .config:176:war

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
PREEMPT_NONE is not set > CONFIG_REEMPT_VOLUNTARY=y Perhaps say warning("override: switching to choice %s", sym->name); if sym->name is [CONFIG_]PREEMPT_VOLUNTARY. Or what is it? -- Stefan Richter -=-=-=== =-=- -==-= http://arcgraph.de/sr/ - To unsubscribe from th

Re: [PATCH 2/2] ieee1394_core.c: use DEFINE_SPINLOCK for spinlock definition

2007-10-12 Thread Stefan Richter
Matthias Kaehlcke wrote: > drivers/ieee1394/ieee1394_core.c: Define spinlock using > DEFINE_SPINLOCK instead of assignment to SPIN_LOCK_UNLOCKED Committed to linux1394-2.6.git, thanks. -- Stefan Richter -=-=-=== =-=- -==-- http://arcgraph.de/sr/ - To unsubscribe from this list: send th

Re: [PATCH] Documentation/patch-tags v3

2007-10-11 Thread Stefan Richter
Trond Myklebust wrote: > On Thu, 2007-10-11 at 23:21 +0200, Stefan Richter wrote: >> people in the patch >> forwarding chain should only add this tag if the reviewer sent it >> explicitly in his response. Unlike with Acked-by and Tested-by, we must >> not guess wheth

Re: [PATCH] Documentation/patch-tags v3

2007-10-11 Thread Stefan Richter
hat it will achieve its stated purpose or function properly in any >> + given situation. > > I'm confused about how to reconcile (c) and (d) here. If you are not > sure about whether or not the patch will achieve its stated purpose, why > would y

[PATCH 2.6.22.y.] firewire: fix unloading of fw-ohci while devices are attached

2007-10-10 Thread Stefan Richter
Fix panic in run_timer_softirq right after "modprobe -r firewire-ohci" if a FireWire disk was attached and firewire-sbp2 loaded. Same as commit 8a2d9ed3210464d22fccb9834970629c1c36fa36. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- (I somehow forgot to send this ear

Re: (resubmitting) typo fixes for 2.6.23

2007-10-10 Thread Stefan Richter
Matt LaPlante wrote: [...] > this is a consolidation of a couple old missed patches, it touches > both Kconfigs and documentation texts. As a side note: Submissions which touch multiple files are more readable if prepended by the diffstat. Thanks, -- Stefan Richter -=-=-=== =-=- -=-=

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
> Sam Ravnborg wrote: >> On Tue, Oct 09, 2007 at 08:11:53AM +0200, Stefan Richter wrote: >>> The SCM changelog should contain _what_ a patch does and if >>> necessary _why_ it does so. >> The _why_ part is more important than _what_. The diff should hopefully >&

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
Sam Ravnborg wrote: > On Tue, Oct 09, 2007 at 08:11:53AM +0200, Stefan Richter wrote: >> The SCM changelog should contain _what_ a patch does and if >> necessary _why_ it does so. > The _why_ part is more important than _what_. The diff should hopefully > explain the _wha

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
gn-off tag to state that the licensing is alright, and any other tags) should have its meaning sufficiently defined outside the changelog. Remember what the SCM changelog is for, i.e. what we do with it after commit. -- Stefan Richter -=-=-=== =-=- -=--= http://arcgraph.de/sr/ - To unsubscrib

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
27;ll just be ignored for now, but you can do this to mark internal company procedures or just point out some special detail about the sign-off.", says SubmittingPatches. I actually do so on occasions. -- Stefan Richter -=-=-=== =-=- -=--= http://arcgraph.de/sr/ - To unsubscribe from this

possible recursive locking detected... in __wake_up

2007-10-08 Thread Stefan Richter
irewire_ohci] >>[] tasklet_action+0x68/0xd3 >>[] __do_softirq+0x78/0xff >>[] do_softirq+0x74/0xf7 >>=== (from https://bugzilla.redhat.com/show_bug.cgi?id=323411) We wake up the queue from a workqueue context (rarely) and from taskl

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
gs into the SCM changelog, and what can the list archives provide? -- Stefan Richter -=-=-=== =-=- -=--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
which is not "worthwhile" is also not "appropriate". Mere correctness in a mathematical sense is not enough as technical review criterion. -- Stefan Richter -=-=-=== =-=- -=--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
ul if the necessary testing is rather simple (i.e. "fixed the bug which I was always able to reproduce before") or if the tester is known to have performed rigorous and sufficiently broad tests. -- Stefan Richter -=-=-=== =-=- -=--- http://arcgraph.de/sr/ - To unsubscribe from th

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Stefan Richter
al submitter(s). > * Also used by maintainers to track the patch's path > (ATM, does not imply "I have look at it in depth") Signed-off-by (as far as the Developer's Certificate of Origin defines it) says: I made sure that this patch complies with all involved licens

[GIT PULL] last minute FireWire update

2007-10-07 Thread Stefan Richter
a1134dd48d59e532b801659163539bf01cae7673 Author: Stefan Richter <[EMAIL PROTECTED]> Date: Sun Oct 7 12:31:22 2007 +0200 firewire: point to migration document Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/K

[PATCH] firewire: point to migration document

2007-10-07 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux/drivers/firewire/Kconfig === --- linux.orig/drivers/firewire/Kconfig +++

Re: CodingStyle: mention bitfields/whitespace style, prefer (!foo) in examples

2007-10-06 Thread Stefan Richter
Pavel Machek wrote: > It just would be nice to have example specifying one way... I don't see a necessity. -- Stefan Richter -=-=-=== =-=- --==- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [1/3] 2.6.23-rc6: known regressions v2 --- ieee1394, empty suspend stopped working

2007-09-30 Thread Stefan Richter
h else going on here at the moment. If I find time to follow up reasonably soon, I'll do. Thanks for the advice. -- Stefan Richter -=-=-=== =--= - http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [

Re: [PATCH] firewire: adopt read cycle timer ABI from raw1394

2007-09-29 Thread Stefan Richter
ag set. The cycle is then written out in the fw_cdev_event_iso_interrupt event which happens when this particular packet was received. Right? Pieter, do applications like yours need the cycle counter only for a few predetermined packets or for each and every packet? -- Stefan Richter -=-=

[PATCH] firewire: adopt read cycle timer ABI from raw1394

2007-09-29 Thread Stefan Richter
This duplicates the read cycle timer feature of raw1394 (added in Linux 2.6.21) in firewire-core's userspace ABI. The argument to the ioctl is reordered though to ensure 32/64 bit compatibility. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- Only compile-tested. Counterpart for

What's in linux1394-2.6.git

2007-09-26 Thread Stefan Richter
ich I felt were too late for 2.6.23. To be merged: Jean Delvare (1): ieee1394: pcilynx: I2C cleanups Satyam Sharma (1): ieee1394: Fix kthread stopping in nodemgr_host_thread Stefan Richter (18): ieee1394: eth1394: superfluous local variable ieee1394: eth1394: fix

[PATCH 2.6.22.y, 2.6.20.y] ieee1394: ohci1394: fix initialization if built non-modular

2007-09-20 Thread Stefan Richter
Andi Kleen. Same as pre-2.6.23 commit be7963b7e7f08a149e247c0bf29a4abd174e0929. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/ieee1394_core.c |2 +- drivers/ieee1394/ohci1394.c |4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) Index: li

[GIT PULL] IEEE1394 fix

2007-09-20 Thread Stefan Richter
files changed, 2 insertions(+), 4 deletions(-) commit be7963b7e7f08a149e247c0bf29a4abd174e0929 Author: Stefan Richter <[EMAIL PROTECTED]> Date: Thu Sep 20 21:17:33 2007 +0200 ieee1394: ohci1394: fix initialization if built non-modular Initialization of ohci1394 was broken accord

Re: [PATCH] ide-cd is unmaintained

2007-09-20 Thread Stefan Richter
Alan Cox wrote: > IDE/ATAPI CDROM DRIVER > -P: Alan Cox > -M: [EMAIL PROTECTED] > L: [EMAIL PROTECTED] > -S: Maintained > +S: Unmaintained Should be "Orphan", not Unmaintained. -- Stefan Richter -=-=-=== =--= =-=-- http://arcgraph.de/sr/ - To unsubscr

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-17 Thread Stefan Richter
tual SCSI hardware... Of course there is no way around the issue that Linux' SCSI core's and highlevel's role cannot be characterized in 3...6 words only, but there should be a way to point out its general importance. > Referring to your example it is like calling generic n

Re: regression: fireware causes oops during system

2007-09-16 Thread Stefan Richter
nt in 2.6.23-rc6. To reproduce | | swapoff -a | echo disk > /sys/power/state | echo disk > /sys/power/state | | Unsetting | | CONFIG_IEEE1394=y | | solves the problem. -- Stefan Richter -=-=-=== =--= = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "

Re: regression: fireware causes oops during system

2007-09-16 Thread Stefan Richter
r other post: > On Tue 2007-09-11 21:45:58, Stefan Richter wrote: >> Between -rc3 and -rc4: >> >> ieee1394: sbp2: fix sbp2_remove_device for error cases >> a2ee3f9bbb0ce57102dad8928d54f59acdc4b8f7 >> should not occur in suspend path > > Plus I d

Re: [1/3] 2.6.23-rc6: known regressions v2 --- ieee1394, empty suspend stopped working

2007-09-16 Thread Stefan Richter
Andrew Morton wrote: > On Sun, 16 Sep 2007 11:35:04 +0200 Stefan Richter <[EMAIL PROTECTED]> wrote: >> Regardless whether swap is on or off and whether ieee1394 and >> ohci1394 are loaded or not, it always behaves the same. It does >> something, then ends up with power

Re: [1/3] 2.6.23-rc6: known regressions v2 --- ieee1394, empty suspend stopped working

2007-09-16 Thread Stefan Richter
firewire can be seen at http://me.in-berlin.de/~s5r6/linux1394/merged/in_2.6.23/.) -- Stefan Richter -=-=-=== =--= = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH] x86_64: configure HPET_EMULATE_RTC automatically

2007-09-15 Thread Stefan Richter
I don't know exactly what this option does... Andi says it should be automatic rather than exposed as a prompt. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- --- linux.orig/arch/x86_64/Kconfig +++ linux/arch/x86_64/Kconfig @@ -469,8 +469,9 @@ config HPET_TIMER

x86_64 usability bug: Kconfig prompt without help text (was Re: sata & scsi suggestion for make menuconfig)

2007-09-15 Thread Stefan Richter
I take the liberty to modify the CC list. Paul Rolland wrote: > Stefan Richter <[EMAIL PROTECTED]> wrote: >> I assert that a Kconfig prompt (a visible Kconfig variable) _without_ >> help text is a bug. > > Here is an example from 2.6.34-rc6 : > .config - Linux Ke

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Stefan Richter
Adrian Bunk wrote: > On Sat, Sep 15, 2007 at 04:11:45PM +0200, Stefan Richter wrote: >> Perfect is in the eye of the beholder. You would consequently have to >> add such options into all menus which contain scsi low-level providers. > > Kconfig is a user interface, so perfec

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Stefan Richter
Adrian Bunk wrote: > On Sat, Sep 15, 2007 at 03:20:06PM +0200, Stefan Richter wrote: >> It still doesn't entirely clarify whether users need sd, sr, st, and >> whether thy need sd for the disk with root filesystem. > > If you want to do it in a really perfect

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-15 Thread Stefan Richter
Adrian Bunk wrote: > On Fri, Sep 14, 2007 at 11:14:21PM +0200, Stefan Richter wrote: >> + You need it >> + - for classic parallel SCSI hardware, >> + - for newer SCSI transports such as Fibre Channel, FireWire storage, >> +SAS, or iSCSI, >&g

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Stefan Richter
her users need sd, sr, st, and whether thy need sd for the disk with root filesystem. -- Stefan Richter -=-=-=== =--= - http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

[PATCH] ieee1394: csr1212: proper refcounting

2007-09-15 Thread Stefan Richter
tation non-recursively then?) Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/csr1212.c | 57 +++-- drivers/ieee1394/csr1212.h |6 ++- drivers/ieee1394/nodemgr.c |4 +- 3 files changed, 36 insertions(+), 31 deletions(-) Inde

[PATCH] ieee1394: nodemgr: fix leak of struct csr1212_keyval

2007-09-15 Thread Stefan Richter
ady exists is now fixed for good. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/nodemgr.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) Index: linux/drivers/ieee1394/

Re: sysfs: spit a warning to users when they try to create a duplicate sysfs file

2007-09-15 Thread Stefan Richter
XIST; > + } > > sd->s_parent = sysfs_get(acxt->parent_sd); > As a side story: I've got code which has checks for device_create_file != 0 but keeps quiet if it got -EEXIST. I rewrote it now so that it does not rely on the driver core to skip over already exis

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-15 Thread Stefan Richter
FUJITA Tomonori wrote: > On Sat, 15 Sep 2007 08:16:03 +0200 > Stefan Richter <[EMAIL PROTECTED]> wrote: >> Or would be "for newer SCSI transports such as Fibre Channel, >> FireWire storage, iSCSI, SAS, and more," be OK? > > scsi-ml has SPI, FC, iSCSI, S

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-15 Thread Stefan Richter
Adrian Bunk wrote: > On Fri, Sep 14, 2007 at 10:01:18PM +0200, Stefan Richter wrote: >> drivers/Kconfig |4 >> drivers/scsi/Kconfig | 1589 -- >> drivers/scsi/Kconfig.lowlevel | 1578

Re: sata & scsi suggestion for make menuconfig

2007-09-15 Thread Stefan Richter
Paul Rolland wrote: > getting too much of "No help text available" > usually results in people no more reading the help text. I assert that a Kconfig prompt (a visible Kconfig variable) _without_ help text is a bug. -- Stefan Richter -=-=-=== =--= - http://arcg

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
FUJITA Tomonori wrote: > On Fri, 14 Sep 2007 23:14:21 +0200 (CEST) > Stefan Richter <[EMAIL PROTECTED]> wrote: ... >> And one more update: >> There is SAS too, ... >> + You need it >> + - for classic parallel SCSI hardware, >> + - for n

[PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- And one more update: There is SAS too, and I forgot 'is' in "on a disk which __ accessed via". drivers/scsi/Kconfig | 67 ++- 1 file changed, 35 insertions(+), 32 deletio

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

2007-09-14 Thread Stefan Richter
On 14 Sep, Lennart Sorensen wrote: > On Fri, Sep 14, 2007 at 10:14:16PM +0200, Stefan Richter wrote: >> - If you want to use a SCSI or FireWire CD-ROM under Linux, >> + If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM, >>say Y and read t

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-14 Thread Stefan Richter
ld very well be collapsed into one. (I'll gladly do that, or only send an update of the 'split Kconfig menu' patch with that sentence backed out, if desired.) -- Stefan Richter -=-=-=== =--= -===- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubs

<    1   2   3   4   5   6   7   8   9   10   >