Re: [PATCH] driver core: multithreaded probing - more parallelism control

2007-06-21 Thread Stefan Richter
d or disappeared. The new FireWire stack will schedule respective scanning workqueue jobs after such an event.) -- Stefan Richter -=-=-=== -==- =-=-= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

Re: How to improve the quality of the kernel?

2007-06-21 Thread Stefan Richter
doesn't mean I'm against such tags, on the contrary. They may help us to (a) look harder for review, (b) have a better picture of actual lack of review, patch by patch, subsystem by subsystem, and (c) get more volunteer reviewers by emphasizing the merits of code review. Alas, experienc

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-21 Thread Stefan Richter
DEBUG_RODATA by CONFIG_WRITEPROTECT_RODATA and CONFIG_WRITEPROTECT_TEXT might be a better idea. The latter should be mutual exclusive with CONFIG_KPROBES. -- Stefan Richter -=-=-=== -==- =-=-= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: PROBLEM: menuconfig

2007-06-21 Thread Stefan Richter
ree-electrons.com/source/net/ipv4/ipvs/Kconfig?v=2.6.21#007 In Linux 2.6.22, the menu + the first menu item were fused into a hybrid, a so-called menuconfig. (Bad choice of term, but it wasn't mine. It's something different from the make menuconfig program.) This

Re: [PATCH] driver core: multithreaded probing - more parallelism control

2007-06-21 Thread Stefan Richter
subsystem had a future, I would most certainly not use your mechanism but implement what you described. I am not sure about the new FireWire subsystem; there isn't much practical experience with it yet. -- Stefan Richter -=-=-=== -==- =-=-= http://arcgraph.de/sr/ - To unsubscribe fr

[GIT PULL] ieee1394 fixes

2007-06-20 Thread Stefan Richter
to ether1394_tx in ether1394.c Kristian Høgsberg (1): firewire: Only set client->iso_context if allocation was successful. Stefan Richter (1): firewire: fix hang after card ejection diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c index 5d402d6..dbb7642 100

Re: [PATCH] driver core: multithreaded probing - more parallelism control

2007-06-20 Thread Stefan Richter
> Huang, Ying wrote: ... >> + * @probe: probing infromation include probing function and parameter > ^^^ > typo: information Also, the meaning of the rest of the sentence is unclear. -- Stefan Richter -=-=-=== -==- =-=-- http://arcgraph.de/sr/ -

Re: [PATCH] driver core: multithreaded probing - more parallelism control

2007-06-20 Thread Stefan Richter
ld. Is the queue number kernel-global or per subsystem? ... > + * schedule_probe - schedule a probing to be done later > + * @probe_queue_no: probing queue No. on which the probing will be done > + * @probe: probing infromation include probing function and parameter ^^^ t

[PATCH update] Documentation/HOWTO: update URLs of git trees

2007-06-19 Thread Stefan Richter
On 19 Jun, Chris Wright wrote: > * Stefan Richter ([EMAIL PROTECTED]) wrote: >> + Other kernel trees can be found listed at http://kernel.org/git and in > > Should be http://git.kernel.org/ these days Right. From: Stefan Richter <[EMAIL PROTECTED]> Subject: Documentation/

Re: This is [Re:] How to improve the quality of the kernel[?].

2007-06-19 Thread Stefan Richter
[1:] > > [1:] Your User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; > rv:1.8.1.4) Gecko/20070509 SeaMonkey/1.1.2 Seamonkey isn't interoperable with Debian's BTS? Lucky me that I frequently use other MUAs too. -- Stefan Richter -=-=-=== -==- =--== http://arcg

[PATCH] Documentation/HOWTO: remove stale git URL

2007-06-19 Thread Stefan Richter
and mention MAINTAINERS as pointer to development trees. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- Documentation/HOWTO |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index: linux-2.6.22-rc5/Documentation

Re: This is [Re:] How to improve the quality of the kernel[?].

2007-06-19 Thread Stefan Richter
Oleg Verych wrote: > On Tue, Jun 19, 2007 at 04:27:15PM +0200, Stefan Richter wrote: >> There are different people involved in >> - patch handling, >> - bug handling (bugs are reported by end-users), >> therefore don't forget that PTS and BTS have different

Re: This is [Re:] How to improve the quality of the kernel[?].

2007-06-19 Thread Stefan Richter
#x27;s right. But the production of subsystem test patchkits is volunteer work which will be hard to unify. I'm not saying it's impossible to reach some degree of organized production of test patchkits; after all we already have some standardization regarding patch submission which is volunt

Re: This is [Re:] How to improve the quality of the kernel[?].

2007-06-19 Thread Stefan Richter
orted by end-users), therefore don't forget that PTS and BTS have different requirements. -- Stefan Richter -=-=-=== -==- =--== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: How to improve the quality of the kernel?

2007-06-19 Thread Stefan Richter
anging patch to a driver of very specific hardware ( = a single type or few types with little variance) does not introduce regressions for this hardware. -- Stefan Richter -=-=-=== -==- =--== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: How to improve the quality of the kernel?

2007-06-17 Thread Stefan Richter
He can ask his eager contributors to also help with cross-reviewing and bug fixing, otherwise all the fine work will be stuck in the clogged pipeline. (E.g. post a subsystem todo-list now and then, as a subtle hint.) -- Stefan Richter -=-=-=== -==- =--=- http://arcgraph.de/sr/ - To unsubscrib

Re: How to improve the quality of the kernel?

2007-06-17 Thread Stefan Richter
that a maintainer (who signs off on patches after all) can easily afford to take the "bastard approach". I may be naive. -- Stefan Richter -=-=-=== -==- =--=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH] ieee1394: nodemgr: parallelize between several hosts

2007-06-17 Thread Stefan Richter
led from outside the host threads' contexts. Get() and put() the device.driver when calling its hooks. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- This is more or less a follow-up to some nodemgr locking changes way back in the past and to Greg KH's "IEEE1394: remove

Re: [Bug 8646] New: fw-ohci and ohci1394: panic in softirq, below smp_apic_timer_interrupt

2007-06-17 Thread Stefan Richter
M-266/ AMD-Athlon single-CPU PC, even if running an SMP kernel. BTW, I didn't give this bug high priority while I knew of this bug in conjunction with ohci1394, because module removal of ohci1394 is not possible while sbp2 is logged in into a target since Linux 2.6.17. But the new firewire

Re: How to improve the quality of the kernel?

2007-06-17 Thread Stefan Richter
ors, like reputation of the submitter, hardly matter. -- Stefan Richter -=-=-=== -==- =---= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/m

Re: How to improve the quality of the kernel?

2007-06-17 Thread Stefan Richter
Adrian Bunk wrote: > On Sun, Jun 17, 2007 at 06:26:55PM +0200, Stefan Richter wrote: >> Another approach: Figure out areas where quality is exemplary and try >> to draw conclusions for areas where quality is lacking. > > ieee1394 has a maintainer who is looking after al

Re: How to improve the quality of the kernel?

2007-06-17 Thread Stefan Richter
ions for areas where quality is lacking. -- Stefan Richter -=-=-=== -==- =---= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] (Re: regression tracking (Re: Linux 2.6.21))

2007-06-17 Thread Stefan Richter
Michal Piotrowski wrote: > "choose minor evil to prevent a greater one" The measurement of "evil" is subjective. That's why there are releases with known regressions. -- Stefan Richter -=-=-=== -==- =---= http://arcgraph.de/sr/ - To unsubscribe from this list

[PATCH] driver core: fix kernel doc of device_release_driver

2007-06-17 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/base/dd.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Index: linux-2.6.22-rc3/drivers/base/dd.c === --- linux-2.6.22-rc3.orig/driver

[PATCH] driver core: properly get driver in device_release_driver

2007-06-17 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/base/dd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.22-rc3/drivers/base/dd.c === --- linux-2.6.22-rc3.orig/drivers/base/dd.c +++

Re: coding style

2007-06-16 Thread Stefan Richter
[EMAIL PROTECTED] wrote: > [Stefan Richter - Sat, Jun 16, 2007 at 03:07:43PM +0200] > | Cyrill Gorcunov wrote: > | > There sould be someting making strict rule over alignment (as it done > | > for the tabs size). > | > | That's impracticable. Alignment, as it

Re: coding style

2007-06-16 Thread Stefan Richter
Cyrill Gorcunov wrote: > There sould be someting making strict rule over alignment (as it done > for the tabs size). That's impracticable. Alignment, as it serves readability, cannot be covered by a few strict rules. -- Stefan Richter -=-=-=== -==- = http://arcgraph.

please keep the CodingStyle text in check (was Re: coding style)

2007-06-16 Thread Stefan Richter
> line continuations. People seem to forget: - CodingStyle is a lot about agreement and existing practice. - A longer, bulkier, convoluted, bureaucratic CodingStyle will not enhance quality of contributions. -- Stefan Richter -=-=-=== -==- = http://arcgraph.de/sr/ - To unsubscr

Re: coding style

2007-06-16 Thread Stefan Richter
ly enforce CodingStyle as far as I am aware of deviations, but because I get so few contributions, I more and more tend to adjust coding style on my own before commit, rather than to bother the contributor. -- Stefan Richter -=-=-=== -==- = http://arcgraph.de/sr/ - To unsubscribe from thi

Re: coding style

2007-06-16 Thread Stefan Richter
the kernel coding style. > > That clarification ("in the kernel coding style") should end up in > CodingStyle. (Since tabs *are not* just 8 everywhere, which current > CodingStyle seems to imply. But maybe I'm just to blunt.) linux/Documentation/CodingStyle is about..

Re: regression tracking (Re: Linux 2.6.21)

2007-06-16 Thread Stefan Richter
#x27;s tree --- more so than at the moment.] [Adrian, I'm not saying "too few users run -rc kernels", I'm saying "too few FireWire driver users run -rc kernels".] -- Stefan Richter -=-=-=== -==- = http://arcgraph.de/sr/ - To unsubscribe from this list: se

[GIT PULL] ieee1394 fixes

2007-06-16 Thread Stefan Richter
+++-- 2 files changed, 16 insertions(+), 7 deletions(-) Carlos E. Ugarte (1): ieee1394: fix to ether1394_tx in ether1394.c Stefan Richter (1): firewire: fix hang after card ejection diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c index 0d08bf9..b72a5c1

Re: regression tracking (Re: Linux 2.6.21)

2007-06-14 Thread Stefan Richter
ause Adrian just started doing it and others soon found it very useful. -- Stefan Richter -=-=-=== -==- -===- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: regression tracking (Re: Linux 2.6.21)

2007-06-14 Thread Stefan Richter
me to send e-mails to bugs). [...] > Why you didn't proposed (used) Debian's BTS as alternative to bugzilla, [...] BTS has been mentioned in that thread in a few posts; mostly positively as I recall. -- Stefan Richter -=-=-=== -==- -===- http://arcgraph.de/sr/ - To unsubsc

Re: [PATCH] driver core: multithreaded device matching with dependency

2007-06-12 Thread Stefan Richter
s to public members turn out too difficult and fragile, make the members private and provide documented public accessors. -- Stefan Richter -=-=-=== -==- -==-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: [PATCH] driver core: multithreaded device matching with dependency

2007-06-09 Thread Stefan Richter
i.e. those which do not belong to the API. See Documentation/kernel-doc-nano-HOWTO.txt. PPS: Sadly, the whole struct device and some other driver core API items lack kerneldocs. It's ironic that the deprecated class_device is the only drivercore struct which comes with a kerneldoc. -- Stefa

Re: [PATCH] driver core: multithreaded device matching with dependency

2007-06-08 Thread Stefan Richter
Huang, Ying wrote: >>From: Stefan Richter [mailto:[EMAIL PROTECTED] >> >>How can subsystems control multithreaded vs. singlethreaded probes? >> >>For example, the IEEE 1394 subsystem should probe different nodes in >>parallel, but different units on the same no

Re: [PATCH] driver core: multithreaded device matching with dependency

2007-06-08 Thread Stefan Richter
bes? ... > +EXPORT_SYMBOL_GPL(device_match_freeze); > +EXPORT_SYMBOL_GPL(device_match_thaw); Their definitions lack kerneldoc comments. -- Stefan Richter -=-=-=== -==- -=--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: why is it called "asm-generic/atomic.h"?

2007-06-07 Thread Stefan Richter
CH_SOMETHING and won't need to be in foreseeable future, therefore they don't have this protection. -- Stefan Richter -=-=-=== -==- --=== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

Re: Kernel inclusion policy, meta desicion making structure?

2007-06-06 Thread Stefan Richter
ng the specific features you have in mind directly with the developers and maintainers of the existing cluster FSs. Then it should become clearer how to proceed most effectively. -- Stefan Richter -=-=-=== -==- ---=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "u

Re: [2/3] 2.6.22-rc2: known regressions v2

2007-06-02 Thread Stefan Richter
Michal Piotrowski wrote: > Subject: 2.6.22-rc1 suspend to RAM problem > References : > http://permalink.gmane.org/gmane.linux.power-management.general/5819 > Submitter : Marcus Better <[EMAIL PROTECTED]> > Handled-By : Stefan Richter <[EMAIL PROTECTED]> >

Re: [PATCH] lib: add idr_for_each()

2007-06-01 Thread Stefan Richter
n)(int id, void *p, void *data), void *data) > +{ ...must serialize idr_for_each() vs... -- Stefan Richter -=-=-=== -==- = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [3/3] 2.6.22-rc3: known regressions v2 (suspend, fw-ohci)

2007-06-01 Thread Stefan Richter
Michal Piotrowski wrote: > Suspend > > Subject: 2.6.22-rc1 suspend to RAM problem > References : > http://permalink.gmane.org/gmane.linux.power-management.general/5819 > Submitter : Marcus Better <[EMAIL PROTECTED]> > Handled-By : Stefan Richter <[EMAIL PROTE

Re: [GIT PULL] ieee1394 fixes

2007-06-01 Thread Stefan Richter
2 Mon Sep 17 00:00:00 2001 From: Stefan Richter <[EMAIL PROTECTED]> Date: Sun, 27 May 2007 13:11:47 +0200 Subject: [PATCH] ieee1394: fix calculation of sysfs attribute "address" struct csr1212_keyval.offset is relative to 0x f000 rather than 0xffff f000 0400. Signed-off

[GIT PULL] ieee1394 fixes

2007-06-01 Thread Stefan Richter
stian Høgsberg (3): firewire: Implement suspend/resume PCI driver hooks. firewire: Change struct fw_cdev_iso_packet to not use bitfields. firewire: Install firewire-constants.h and firewire-cdev.h for userspace. Stefan Richter (4): ieee1394: fix calculation of sysfs attribute &qu

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
> c) A drawback of this general option is, it's hard to tell what will be > omitted in particular. -- Stefan Richter -=-=-=== -=-= = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

Re: [RFC 1/4] CONFIG_STABLE: Define it

2007-05-31 Thread Stefan Richter
will be omitted. c) A drawback of this general option is, it's hard to tell what will be omitted in particular. -- Stefan Richter -=-=-=== -=-= = http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat_t

2007-05-30 Thread Stefan Richter
submitting a fairly innocuous patch. live and learn. I've could have seen that it is defined outside #ifdef __KERNEL__. From: Stefan Richter <[EMAIL PROTECTED]> Subject: fs: clarify "dummy" member in struct inodes_stat_t Signed-off-by: Stefan Richter <[EMAIL PROTECTED]

Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t.

2007-05-29 Thread Stefan Richter
From: Stefan Richter <[EMAIL PROTECTED]> Subject: fs: clarify "dummy" member in struct inodes_stat_t Found by Robert P. J. Day: The role of inodes_stat_t.dummy wasn't clear and one might be tempted to remove it. Give it a better name and add a comment. Signed-off-by: S

[PATCH 2.6.21.3] ieee1394: eth1394: bring back a parent device

2007-05-29 Thread Stefan Richter
Date: Mon, 21 May 2007 01:05:41 +0200 From: Stefan Richter <[EMAIL PROTECTED]> Subject: ieee1394: eth1394: bring back a parent device This adds a real parent device to eth1394's ethX device like in Linux 2.6.20 and older. However, due to unfinished conversion of the ieee139

[GIT PULL] ieee1394 fixes post 2.6.22-rc3

2007-05-27 Thread Stefan Richter
grams. Petr Vandrovec (1): ieee1394: raw1394: Fix async send Stefan Richter (5): ieee1394: sbp2: include workqueue.h ieee1394: eth1394: remove bogus netif_wake_queue ieee1394: eth1394: handle tlabel exhaustion ieee1394: eth1394: bring back a parent device fir

Re: [PATCH] [condingstyle] Add chapter on tests

2007-05-27 Thread Stefan Richter
Jan Engelhardt wrote: > if (!p) /* Everytime you shorten it, God kills a kitten */ Very bad news for felines, judging from current coding practice. -- Stefan Richter -=-=-=== -=-= ==-== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] [condingstyle] Add chapter on tests

2007-05-27 Thread Stefan Richter
nd "if (!p)" tests of pointers and many integer expressions, but I tend to the longer form in less obvious cases like "if (strcmp(a, b) != 0)".) -- Stefan Richter -=-=-=== -=-= ==-== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] firewire: fix return code

2007-05-27 Thread Stefan Richter
Jeff Garzik wrote: > Fix this warning on x86-64 > > drivers/firewire/fw-cdev.c:798: warning: initialization from incompatible > pointer type Committed to linux1394-2.6.git, will include it in the next batch of updates for Linus. Thanks, -- Stefan Richter -=-=-=== -=-

[PATCH] ieee1394: eth1394: bring back a parent device

2007-05-26 Thread Stefan Richter
I will submit this for 2.6.22-rc and 2.6.21.y if nobody objects. Date: Mon, 21 May 2007 01:05:41 +0200 From: Stefan Richter <[EMAIL PROTECTED]> Subject: ieee1394: eth1394: bring back a parent device This adds a real parent device to eth1394's ethX device like in Linux 2.6.20 and olde

Re: [PATCH 2/2] [condingstyle] Add chapter on tests

2007-05-25 Thread Stefan Richter
Auke Kok wrote: > +If you give your variables and pointers good names, there is never a need > +to compare the value stored in that variable to NULL or true/false, so > +omit all that and keep it short. I agree with this in principle. But do we have to standardize it? -- Stefa

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Stefan Richter
Auke Kok wrote: > +Don't put spaces before tabs or mix them. Make it "Don't put spaces before tabs." We do mix them if we combine tabs for indentation with spaces for alignment. -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.de/sr/ - To unsubscribe from t

Re: [2/3] 2.6.22-rc2: known regressions v2

2007-05-25 Thread Stefan Richter
ed up. The program 'firescope' and the raw1394 driver is needed on the 2nd machine; the test machine has to have ohci1394 loaded. -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[rfc patch] firewire: prefix modules with firewire- instead of fw-

2007-05-25 Thread Stefan Richter
Of course everybody immediately associates "fw-" with FireWire, not firmware or firewall or whatever. But "firewire-" has a nice ring to it too. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- So everybody, do you prefer the longer names? Alas this RFC is a litt

Re: [2/3] 2.6.22-rc2: known regressions v2

2007-05-25 Thread Stefan Richter
Ingo Molnar wrote: > i was adding WARN_ON()s that werent true 'warnings' but 'bugs'. IME, the trace dump in the kernel log looks scary enough to be eventually reported, even if prefixed with "WARNING:". -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Jiri Slaby wrote: > On 5/25/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> Ismail Dönmez wrote: >> > On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: >> >> Maybe this is a too picky requeriment, but IMO it would be nice if the >> >> module wo

Re: [PATCH] old declaration ritchie style fix

2007-05-25 Thread Stefan Richter
pe-on-its-own-line > style return-type-on-its-own-line is IMO OK if it occurs consistently in a file. It can improve readability particularly if long return types are combined with long function names. > + remove the space before parenthesis. Indeed. -- Stefan Richter -=-=-=== -=-=

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
anted here and there about why some of those less obvious things are done. Or do it as more or less self-documenting code like static inline void stk11xx_unjam_registry(struct stk11xx *dev, u16 index) { int dummy; stk11xx_read_registry(dev, index, &dummy); } -- Stefan Richt

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
ules have no camera_ > prefix like pwc,spca5xx, etc. Then how about adding that prefix to all of them and provide the current name as module alias? Or at least, why not use better names for new modules? -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.de/sr/ - To unsubscribe from

Re: 2.6.22-rc2 amd64 slab allocator bug reported at boot time

2007-05-24 Thread Stefan Richter
[] kobject_get+0x12/0x17 > [] class_register+0x10a/0x13d > [] pci_iommu_init+0x9/0x12 ... This is a known "zero allocation" problem, patch available. http://kernelnewbies.org/known_regressions#line-249 -- Stefan Richter -=-=-=== -=-= ==--- http://arcgraph.de/sr/ - To unsubscribe from this list:

Re: [GIT PULL] ieee1394 fixes post 2.6.22-rc2

2007-05-23 Thread Stefan Richter
ilure, tlabel exhaustion.) > > - trivial sbp2 fix Linus, if you didn't pull already, please don't. Rather wait for my next batch of -rc fixes. At the moment it looks as if I should postpone raw1394's 32bit compat fixes (or call them feature addition) until after the relea

Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

2007-05-22 Thread Stefan Richter
Dan Dennedy wrote: > On Sunday 20 May 2007 08:28, Stefan Richter wrote: >> maybe we should change ... >> struct raw1394_cycle_timer { [to consist of two u64 to get same alignment on all architectures] ... >> before a libraw1394 with get-cycle-timer support is released. >>

Re: RFC: kconfig select warnings bogus?

2007-05-22 Thread Stefan Richter
Satyam Sharma wrote: > On 5/22/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> When I said "The standard and maintainable way (for drivers at least) >> is..." I didn't mean the example expression, I meant the *direction* in >> which the example was stat

Re: RFC: kconfig select warnings bogus?

2007-05-22 Thread Stefan Richter
Satyam Sharma wrote: > On 5/22/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> >> > On 5/20/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> >> >> depends on !PLATFORM_X || HELPER_N_ON_PLATFORM_X ... >> This is a synthetic example whi

Re: RFC: kconfig select warnings bogus?

2007-05-22 Thread Stefan Richter
Satyam Sharma wrote: > On 5/20/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> > On 5/20/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> >> config A >> >> bool-or-tristate "option A" >> >> depends on !PLATFOR

[PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel, amendment

2007-05-21 Thread Stefan Richter
Pointed out by Arnd Bergmann: PPC32 aligns this at 64bit, IA32 packs it. A kernel-wide available __compat_u64 which is 4-byte aligned on AMD64 and IA64 would be nicer though. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/raw1394.c |6 +- 1 file chan

Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

2007-05-21 Thread Stefan Richter
; in include/asm-{x86_64,ia64}/compat.h and as > > typdef __u64 __compat_u64; > > in the other architectures. Other people have hit the same problem > before and found varying workarounds, but I think we should just > do it correctly now. should be put into practice though. --

Re: [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after network class_device conversion

2007-05-20 Thread Stefan Richter
> I wrote on 2007-03-21: >> On 20 Mar, Greg KH wrote: >>> On Tue, Mar 20, 2007 at 10:43:22PM +0100, Stefan Richter wrote: >>>>SET_MODULE_OWNER(dev); >>>> +#if 0 >>>> + /* FIXME - Is this the correct parent device anyway? */ >>>&

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
dependencies. If that's so, then we have /a/ an incomplete definition of the Kconfig language (what is supposed to happen if "select" attempts to set an impossible value?) and /b/ a bug in the make xyzconfig programs (they generate invalid configs). -- Stefan Richter -=-=-=== -=-

Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

2007-05-20 Thread Stefan Richter
Arnd Bergmann wrote: > On Sunday 20 May 2007, Stefan Richter wrote: >> maybe we should change ... >> struct raw1394_cycle_timer { ... >> before a libraw1394 with get-cycle-timer support is released. > > Yes, if you still have the chance to change this without breaking &

Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

2007-05-20 Thread Stefan Richter
Arnd Bergmann wrote: > On Sunday 20 May 2007, Stefan Richter wrote: >>> Note that this data structure only needs conversion on x86_64 and ia64, but >>> not on powerpc and other 64 bit architectures that align __u64 also in >>> 32 bit mode. >> Is this conversion

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
Satyam Sharma wrote: > On 5/20/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> config A >> bool-or-tristate "option A" >> depends on !PLATFORM_X || HELPER_N_ON_PLATFORM_X > > ??? I didn't get this entry, "A is available if

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
ake randconfig" deal with the hint or ignore the hint --- according to the purpose and usability requirements of the respective UI. The "hint THIS_IS_SOMETHING" isn't even necessary in many cases to detect roles of options, because their position in the dependency graph is alrea

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
Satyam Sharma wrote: > On 5/20/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> However you fix it --- don't remove "depends on" or "select". You can >> interchange them, but not remove them, unless there wasn't a dependency >> to begin w

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
Trent Piepho wrote: > On Sun, 20 May 2007, Stefan Richter wrote: >> Basically you replace >> >> A... depends on B >> >> by >> >> B... serves A >> >> The latter variant is a pain to maintain. Dependencies change over >&

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
g upwards and downwards the dependency graph is the duty of "make snafuconfig", not of the maintainers. Besides, the "serves" form cannot stand in for constructs like A... depends on (B && C) || D -- Stefan Richter -=-=-=== -=-= =-=-- http://arcgraph.de/sr/ -

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Stefan Richter
pendencies, prompt texts and help texts in Kconfig files, maybe amended by new machine-readable markers regarding the role of an option. The presentation and ways to select and deselect should be entirely left to UIs. -- Stefan Richter -=-=-=== -=-= =-=-- http://arcgraph.de/sr/ - To unsubscribe fro

Re: RFC: kconfig select warnings bogus?

2007-05-19 Thread Stefan Richter
y commented on this. Let me just add that these above changes are in so far *totally wrong* as they remove the "depends on XYZ" which is implied by "select XYZ". Remember, "select" is like "depends on", just with the added twist that the 'make snafuconf

Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

2007-05-19 Thread Stefan Richter
nd ia64, but > not on powerpc and other 64 bit architectures that align __u64 also in > 32 bit mode. Is this conversion just unnecessary or actually harmful on ppc64 and others? -- Stefan Richter -=-=-=== -=-= =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line &quo

Re: [2/5] 2.6.22-rc2: known regressions

2007-05-19 Thread Stefan Richter
l/2007/5/18/19 "avoid-zero-size-allocation-in-cache_k8_northbridges" Category is x86-64, not memory management. -- Stefan Richter -=-=-=== -=-= =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [4/5] 2.6.22-rc2: known regressions

2007-05-19 Thread Stefan Richter
inux1394-devel, hence: Handled-By : Stefan Richter <[EMAIL PROTECTED]>, Kristian Høgsberg <[EMAIL PROTECTED]> Alas I am lacking a machine which suspends, but I'm working on it. If all fails, I'm gonna have to pull an old APM laptop out of the rubbish. --

Re: [GIT PULL] ieee1394 fixes post 2.6.22-rc2

2007-05-19 Thread Stefan Richter
ead() for 32bit userland on 64bit kernel > ieee1394: raw1394: Fix write() for 32bit userland on 64bit kernel > ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel > > Stefan Richter (3): > ieee1394: sbp2: include workqueue.h &

[GIT PULL] ieee1394 fixes post 2.6.22-rc2

2007-05-19 Thread Stefan Richter
32bit userland on 64bit kernel Stefan Richter (3): ieee1394: sbp2: include workqueue.h ieee1394: eth1394: remove bogus netif_wake_queue ieee1394: eth1394: handle tlabel exhaustion -- Stefan Richter -=-=-=== -=-= =--== http://arcgraph.de/sr/ - To unsubscribe from this list: send the

Re: Asynchronous scsi scanning

2007-05-18 Thread Stefan Richter
d. sbp2 and its successor fw-sbp2 are not yet integrated with scsi_wait_scan, but should be _some_ day. http://bugzilla.kernel.org/show_bug.cgi?id=3225#c2 -- Stefan Richter -=-=-=== -=-= =--=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: usb-storage nice value

2007-05-17 Thread Stefan Richter
lock/hda/queue/scheduler # echo deadline > /sys/block/hda/queue/scheduler -- Stefan Richter -=-=-=== -=-= =---= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [RFC] select and dependencies in Kconfig

2007-05-16 Thread Stefan Richter
ends on A || C You mean, "B... serves A, C". However, it shouldn't matter which way around the dependencies are written down in the Kconfigs. What does matter is how "make {old,menu,...}config" deal with it. -- Stefan Richter -=-=-=== -=-= =---= http://arcgraph.de/sr/ - To

Re: [RFC] select and dependencies in Kconfig

2007-05-16 Thread Stefan Richter
Timur Tabi wrote: > Stefan Richter wrote: >> "A... select B" is just a flavor of "A... depends on B", ... > I think you mean "A... select B" is just a flavor of "B... depends on > A". No, A requires B's symbols. -- Stefan Richter -==

Re: [PATCH] SCSI: Let users disable SCSI_WAIT_SCAN to be built

2007-05-16 Thread Stefan Richter
waiting, and that this is useful or required in initrds. > + Most people can say n here. This sentence should probably be omitted, as it may be wrong in the future and unsafe already now. I will resend an updated patch. -- Stefan Richter -=-=-=== -=-= = http://arcgraph.de/sr/ - To un

Re: How to force Kconfig tristate into range n..m?

2007-05-16 Thread Stefan Richter
Andi Kleen wrote: > One way is to use a separate symbol that is not user visible, but depends > on your main symbol and uses default m > > (similar to the now infamous CONFIG_SCSI_WAIT_SCAN) Actually CONFIG_SCSI_WAIT_SCAN should be visible and restricted to m or n. :-) -- St

Re: [RFC] select and dependencies in Kconfig

2007-05-16 Thread Stefan Richter
doesn't really let us get by with less powerful "make fooconfig" programs, because proper treatment of "depends" is sometimes nontrivial. PPS: Other current discussions indicate that additional metadata in the Kconfigs might perhaps be useful, e.g. metadata about a kernel part&

Re: How to guarantee that kmalloc returns an address below 4GB

2007-05-16 Thread Stefan Richter
Cestonaro, Thilo (external) wrote: > is there an option for kmalloc, which I can use to allocate > a buffer which is in physical memory placed below 4GB? > Not in a remapped area. GFP_DMA32 http://lxr.linux.no/source/include/linux/gfp.h#L82 -- Stefan Richter -=-=-=== -=-= =

Re: Linux 2.6.22-rc1

2007-05-15 Thread Stefan Richter
Satyam Sharma wrote: > * Also, some "[MENU]" kind of prefix/tag in the text of configmenu > options would also be nice. This belongs into the UIs, not into Kconfigs. And it'd not just be nice, it's a requirement. -- Stefan Richter -=-=-=== -=-= = http://arcgra

[PATCH 2/3] ieee1394: raw1394: Fix write() for 32bit userland on 64bit kernel

2007-05-15 Thread Stefan Richter
y: Dan Dennedy <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> (split into 3 patches) --- drivers/ieee1394/raw1394.c | 65 +++-- 1 file changed, 34 insertions(+), 31 deletions(-) Index:

[PATCH 3/3] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel

2007-05-15 Thread Stefan Richter
assing array of integers around as integers seem to have same size (32 bits) on all architectures supported by Linux. Signed-off-by: Petr Vandrovec <[EMAIL PROTECTED]> Acked-by: Dan Dennedy <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> (split into 3 patche

[PATCH 1/3] ieee1394: raw1394: Fix read() for 32bit userland on 64bit kernel

2007-05-15 Thread Stefan Richter
o copy data from 'r' to 'r', which is not good. Signed-off-by: Petr Vandrovec <[EMAIL PROTECTED]> Acked-by: Dan Dennedy <[EMAIL PROTECTED]> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> (split into 3 patches) --- drivers/ieee1394/raw1394.c |2 +- 1 fil

<    3   4   5   6   7   8   9   10   11   12   >